profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/mpdel/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

mpdel/mpdel 51

Emacs user interface for MPD

mpdel/libmpdel 6

Emacs library to communicate with Music Player Daemon (MPD)

mpdel/ivy-mpdel 4

Emacs' ivy interface to communicate with Music Player Daemon (MPD)

startedmpdel/mpdel

started time in 13 days

startedmpdel/mpdel

started time in 2 months

startedmpdel/libmpdel

started time in 3 months

fork lucasminah/libmpdel

Emacs library to communicate with Music Player Daemon (MPD)

https://gitea.petton.fr/mpdel/libmpdel

fork in 3 months

fork lucasminah/mpdel

Emacs user interface for MPD

https://gitea.petton.fr/mpdel/mpdel

fork in 3 months

push eventmpdel/libmpdel

Kenny Ballou

commit sha 42fac7f614ed126f2ac0daa4f80828bc6ad6839e

display file name if missing song name metadata HTTP streams defined in playlist files do not contain metadata until after the stream begins playing. Therefore, it can be difficult to distinguish between the streams when nothing is displayed for each entry in the playlist. I cannot foresee an instance where the file name is missing, but this may be failure of my imagination. Therefore, if the song title is missing, display the file name instead. This behaviour is consistent with `ncmpcpp` sans special formatting which `ncmpcpp` does to tracks starting with "http...". See also: [mpdel/mpdel#2][0] Signed-off-by: Kenny Ballou <kb@devnulllabs.io> [0]: https://github.com/mpdel/mpdel/pull/2

view details

Damien Cassou

commit sha e4ae63dd002fe07835c3c8a35b20b6e8347f8e84

Merge pull request #4 from kennyballou/display-file-name display file name if missing song name metadata

view details

push time in 3 months

PR merged mpdel/libmpdel

display file name if missing song name metadata

HTTP streams defined in playlist files do not contain metadata until after the stream begins playing. Therefore, it can be difficult to distinguish between the streams when nothing is displayed for each entry in the playlist. I cannot foresee an instance where the file name is missing, but this may be failure of my imagination.

Therefore, if the song title is missing, display the file name instead.

This behaviour is consistent with ncmpcpp sans special formatting which ncmpcpp does to tracks starting with "http...".

See also: mpdel/mpdel#2

+10 -2

1 comment

2 changed files

kennyballou

pr closed time in 3 months

PullRequestReviewEvent

push eventmpdel/libmpdel

Damien Cassou

commit sha 336982396e51e2df9b6af938f7103d294f969ca1

Update Copyright

view details

Damien Cassou

commit sha d4079dda71919ef47c24ee9219c00e19dfe212af

Release 1.3.0

view details

Damien Cassou

commit sha b49ab2fe497d61d7d00ed1ad0c3b5a1d6a65e5c4

Merge pull request 'Release 1.3.0' (#29) from 1.3.0 into master Reviewed-on: https://gitea.petton.fr/mpdel/libmpdel/pulls/29

view details

push time in 3 months

created tagmpdel/libmpdel

tagv1.3.0

Emacs library to communicate with Music Player Daemon (MPD)

created time in 3 months

push eventmpdel/libmpdel

Damien Cassou

commit sha d807e7c81abc7af17d41c32fb24832e0512efb33

Allow creating stored playlist on the fly.

view details

push time in 3 months

pull request commentmpdel/libmpdel

display file name if missing song name metadata

@DamienCassou, thank you for your suggestions. I have updated the PR by adding a new test that tests the default behavior when libmpdel-entity-name is called with only a file attribute.

kennyballou

comment created time in 3 months

Pull request review commentmpdel/mpdel

display file name if missing song name metadata

  (navigel-method mpdel navigel-entity-to-columns ((song libmpdel-song))   (vector-   (propertize (or (libmpdel-entity-name song) "") 'face 'mpdel-tablist-song-name-face)+   (propertize (or (libmpdel-entity-name song)+                   (libmpdel-song-file song) "") 'face 'mpdel-tablist-song-name-face)

:+1:

kennyballou

comment created time in 3 months

PullRequestReviewEvent
PullRequestReviewEvent

PR closed mpdel/mpdel

display file name if missing song name metadata

HTTP streams defined in playlist files do not contain metadata until after the stream begins playing. Therefore, it can be difficult to distinguish between the streams when nothing is displayed for each entry in the playlist. I cannot foresee an instance where the file name is missing, but this may be failure of my imagination.

Therefore, if the song title is missing, display the file name instead.

This behaviour is consistent with ncmpcpp sans special formatting which ncmpcpp does to tracks starting with "http...".

+2 -1

0 comment

1 changed file

kennyballou

pr closed time in 3 months

PR opened mpdel/libmpdel

display file name if missing song name metadata

HTTP streams defined in playlist files do not contain metadata until after the stream begins playing. Therefore, it can be difficult to distinguish between the streams when nothing is displayed for each entry in the playlist. I cannot foresee an instance where the file name is missing, but this may be failure of my imagination.

Therefore, if the song title is missing, display the file name instead.

This behaviour is consistent with ncmpcpp sans special formatting which ncmpcpp does to tracks starting with "http...".

See also: mpdel/mpdel#2

+5 -2

0 comment

1 changed file

pr created time in 3 months

Pull request review commentmpdel/mpdel

display file name if missing song name metadata

  (navigel-method mpdel navigel-entity-to-columns ((song libmpdel-song))   (vector-   (propertize (or (libmpdel-entity-name song) "") 'face 'mpdel-tablist-song-name-face)+   (propertize (or (libmpdel-entity-name song)+                   (libmpdel-song-file song) "") 'face 'mpdel-tablist-song-name-face)

I'm submitting a PR for libmpdel. Feel free to close this, if that's the desired outcome.

kennyballou

comment created time in 3 months

PullRequestReviewEvent

Pull request review commentmpdel/mpdel

display file name if missing song name metadata

  (navigel-method mpdel navigel-entity-to-columns ((song libmpdel-song))   (vector-   (propertize (or (libmpdel-entity-name song) "") 'face 'mpdel-tablist-song-name-face)+   (propertize (or (libmpdel-entity-name song)+                   (libmpdel-song-file song) "") 'face 'mpdel-tablist-song-name-face)

I want to make sure I understand correctly, the change for defaulting the song name should go in libmpdel-entity-name in the libmpdel project?

kennyballou

comment created time in 3 months

PullRequestReviewEvent

Pull request review commentmpdel/mpdel

display file name if missing song name metadata

  (navigel-method mpdel navigel-entity-to-columns ((song libmpdel-song))   (vector-   (propertize (or (libmpdel-entity-name song) "") 'face 'mpdel-tablist-song-name-face)+   (propertize (or (libmpdel-entity-name song)+                   (libmpdel-song-file song) "") 'face 'mpdel-tablist-song-name-face)

I suggest improving libmpdel-entity-name for songs in libmpdel instead.

kennyballou

comment created time in 3 months

PullRequestReviewEvent
PullRequestReviewEvent