profile
viewpoint
Michael Park mpark @facebook San Francisco https://mpark.github.io @facebook engineer, @cplusplus member, @llvm committer, @mesos committer

mpark/patterns 533

This is an experimental library that has evolved to P1371, proposed for C++23.

mpark/variant 526

C++17 `std::variant` for C++11/14/17

mpark/wg21 90

WG21: C++ Standards Committee Papers

mpark/format 34

Compile-time Checked, Type-Safe Formatting in C++14

JasonL9000/cppcon14 32

source code for CppCon 2014 talk on polymorphic unions

mpark/slb 9

SLB: C++ Standard Library Backport

mpark/cppcon17 6

Presentation Material for CppCon 2017

mesos/3rdparty 3

Collection of the 3rdparty dependencies bundled into Mesos.

push eventmpark/dotfiles

Michael Park

commit sha 137a5bf93fff6dd146d32cc3fcbdfabaad6a2757

Install stuff first. oh-my-zsh for example overwrites .zshrc, and we actually want to be the one to overwrite the default oh-my-zsh .zshrc.

view details

push time in a month

push eventmpark/wg21

Mathias Stearn

commit sha 634b0154e3a5721be5534b602b991e200eaba8b3

Improve readability on phones (#85) Closes #84.

view details

push time in a month

PR merged mpark/wg21

Improve readability on phones

Closes #84.

If you'd like to know more about @media queries, https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Media_queries is a good resource.

I don't know why there is a margin: 5em in the body block right now, so I decided to leave it alone except on narrow devices. If you don't think it is actually needed, this can be simplified by just setting the margin to 1.5em there and removing the whole @media block. I'd be happy to do whichever you prefer.

+7 -0

1 comment

1 changed file

RedBeard0531

pr closed time in a month

issue closedmpark/wg21

Improve readability on phones

I read most papers on my phone, but your default css has wide margins that make that difficult. Here's a screenshot (using firefox dev tools responsive viewer) of a proposal I'm working on. I extended the length so that more would be visible, but the width is the same as on a Galaxy S9:

before

Note how there are very few words per line, and how the metadata labels have fallen off the left edge.

I suggest two changes. Either set the margin to 1.5em everywhere, or at least do it within a media query like this (it needs to go after the default body block):

@media screen and (max-width: 30em) {
    body {
	margin: 1.5em;
    }
}

Also, I suggest setting text-align: justify; on the body. It makes a big difference on mobile because the ragged edges are a larger percentage of the total width. But I also think it just looks better for prose even on a desktop.

Here is another screenshot with the modified CSS, or you'd like to quickly try it on any of your devices, this draft paper is using the patched CSS:

after

If you would prefer, I'd be happy to make a PR with these changes.

closed time in a month

RedBeard0531
more