profile
viewpoint

create barnchmomotaro98/reveal.js

branch : myslides

created branch time in 2 days

push eventmomotaro98/middleware-learning

Shintaro Ikeda

commit sha 33a766db86fd424c7aaca61747bd0a9c610eaf0d

update for chapter1 of data-intensive book

view details

push time in 2 days

startedaws/serverless-application-model

started time in 3 days

push eventmomotaro98/middleware-learning

Shintaro Ikeda

commit sha 6a18ecc37e1ebcbd5d5c7c5718d44790ded07b75

update

view details

push time in 3 days

push eventmomotaro98/middleware-learning

Shintaro Ikeda

commit sha 9c1303c459f5b5d386da5ae37f4e26e031a3cafe

add example for reveal.js for データ志向アプリケーションデザイン本

view details

push time in 4 days

fork momotaro98/reveal.js

The HTML Presentation Framework

https://revealjs.com

fork in 4 days

startedcloud-native-go/examples

started time in 9 days

startedkrzysztofreczek/go-structurizr

started time in 12 days

startedinfracost/infracost

started time in 17 days

startedteivah/100-go-mistakes

started time in 20 days

startedk0kubun/sqldef

started time in 20 days

startedgoogle/ko

started time in 25 days

startedtypicode/json-server

started time in a month

startedwader/fq

started time in a month

startedim2nguyen/rover

started time in a month

startedmomotaro98/gorillang

started time in a month

push eventmomotaro98/go-codes-for-learning

Shintaro Ikeda

commit sha 262d8f7e3958952ecf3bffece87ff47c61d4a406

update for uber/goleak

view details

push time in a month

issue commentaws/aws-xray-sdk-go

goroutine leaks from BeginSegment without context canceling

I realized there's already a PR #327 for this issue.

momotaro98

comment created time in a month

push eventmomotaro98/go-codes-for-learning

Shintaro Ikeda

commit sha f0af072cc3a5f7506a29ff7965c4cb2895f83916

add for goleak

view details

Shintaro Ikeda

commit sha a29d30bba959b87e7ab905fbf4a0528a1047d998

Merge branch 'master' of ssh://github.com/momotaro98/go-codes-for-learning

view details

push time in a month

issue openedaws/aws-xray-sdk-go

goroutine leaks from BeginSegment without context canceling

Related issue and PR

#51 This issue seems to be the original.

#156 This PR seemed to have tried to fix the issue but it does't looks so.

How to reproduce goroutine leaks

I've used uber-go/goleak to check if the code makes goroutine leaks.

When an existing test function gets inserted goleak, BeginSegment with context canceling doesn't go to leak.

However, it does when I remove the context canceling like following.

func TestSegmentDataRace(t *testing.T) {
	defer goleak.VerifyNone(t)

	ctx, _ := NewTestDaemon()
	// defer td.Close()
	ctx, _ = context.WithCancel(ctx)
	// defer cancel()

	var wg sync.WaitGroup
	n := 100
	wg.Add(n)
	for i := 0; i < n; i++ { // flaky data race test, so we run it multiple times
		_, seg := BeginSegment(ctx, "TestSegment")

		go func() {
			defer wg.Done()
			seg.Close(nil)
		}()
	}
	// cancel()
	wg.Wait()
}

The result shows errors of goleak

go test ./xray... -run TestSegmentDataRace
2021-12-19T00:12:34+09:00 [INFO] Emitter using address: 127.0.0.1:52731
--- FAIL: TestSegmentDataRace (0.46s)
    leaks.go:78: found unexpected goroutines:
        [Goroutine 36 in state IO wait, with internal/poll.runtime_pollWait on top of the stack:
        goroutine 36 [IO wait]:
        internal/poll.runtime_pollWait(0x98adb18, 0x72)
                /usr/local/go/src/runtime/netpoll.go:229 +0x89
        internal/poll.(*pollDesc).wait(0xc00017c780, 0xc000300000, 0x0)
                /usr/local/go/src/internal/poll/fd_poll_runtime.go:84 +0x32
        internal/poll.(*pollDesc).waitRead(...)
                /usr/local/go/src/internal/poll/fd_poll_runtime.go:89
        internal/poll.(*FD).ReadFrom(0xc00017c780, {0xc000300000, 0x10000, 0x10000})
                /usr/local/go/src/internal/poll/fd_unix.go:223 +0x238
        net.(*netFD).readFrom(0xc00017c780, {0xc000300000, 0x0, 0x850538c000010001})
                /usr/local/go/src/net/fd_posix.go:62 +0x29
        net.(*UDPConn).readFrom(0xc000088000, {0xc000300000, 0x0, 0x9840448}, 0xc0000e0ab0)
                /usr/local/go/src/net/udpsock_posix.go:47 +0x3e
        net.(*UDPConn).readFromUDP(0xc00011a3d0, {0xc000300000, 0xc000100660, 0x18}, 0x17fd080)
                /usr/local/go/src/net/udpsock.go:116 +0x31
        net.(*UDPConn).ReadFrom(0xc0000d5f50, {0xc000300000, 0x10000, 0x10000})
                /usr/local/go/src/net/udpsock.go:125 +0x50
        github.com/aws/aws-xray-sdk-go/xray.(*TestDaemon).run(0xc000163a40, 0xc00011d0e0)
                /Users/shintaro/workspace/github.com/momotaro98/aws-xray-sdk-go/xray/util_test.go:82 +0x7a
        created by github.com/aws/aws-xray-sdk-go/xray.NewTestDaemon
                /Users/shintaro/workspace/github.com/momotaro98/aws-xray-sdk-go/xray/util_test.go:55 +0x370

         Goroutine 37 in state chan receive, with github.com/aws/aws-xray-sdk-go/xray.BeginSegmentWithSampling.func1 on top of the stack:
        goroutine 37 [chan receive]:
        github.com/aws/aws-xray-sdk-go/xray.BeginSegmentWithSampling.func1()
                /Users/shintaro/workspace/github.com/momotaro98/aws-xray-sdk-go/xray/segment.go:136 +0x32
        created by github.com/aws/aws-xray-sdk-go/xray.BeginSegmentWithSampling
                /Users/shintaro/workspace/github.com/momotaro98/aws-xray-sdk-go/xray/segment.go:135 +0xf35

created time in a month

fork momotaro98/aws-xray-sdk-go

AWS X-Ray SDK for the Go programming language.

fork in a month

PR closed schemalex/schemalex

Update a log message in alterTables to show table name

I just updated a log message in diff/diff.go file because I think it's more helpful to know error reason.

The error message in #56 becomes like this.

$ schemalex old.sql new.sql
2019/08/13 11:59:30 failed to produce diff: failed to generate alter table from table 'table#foo': can not drop index without name: index#a296fc5d3d6e4233fb3497fbbc5c0135991daa9f0cc1985873b5268f5f80284f
+1 -1

2 comments

1 changed file

momotaro98

pr closed time in a month

pull request commentschemalex/schemalex

Update a log message in alterTables to show table name

Closing

momotaro98

comment created time in a month

delete branch momotaro98/go-codes-for-learning

delete branch : dependabot/go_modules/3rd-parties/gin/github.com/gin-gonic/gin-1.7.0

delete time in a month

push eventmomotaro98/go-codes-for-learning

dependabot[bot]

commit sha 0a0297786cedc88f0a795d754e71f8076539c8ec

Bump github.com/gin-gonic/gin from 1.6.3 to 1.7.0 in /3rd-parties/gin Bumps [github.com/gin-gonic/gin](https://github.com/gin-gonic/gin) from 1.6.3 to 1.7.0. - [Release notes](https://github.com/gin-gonic/gin/releases) - [Changelog](https://github.com/gin-gonic/gin/blob/master/CHANGELOG.md) - [Commits](https://github.com/gin-gonic/gin/compare/v1.6.3...v1.7.0) --- updated-dependencies: - dependency-name: github.com/gin-gonic/gin dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Shintaro Ikeda

commit sha be8c419e3475d7cd527b555c404da2f3f021698b

Merge pull request #4 from momotaro98/dependabot/go_modules/3rd-parties/gin/github.com/gin-gonic/gin-1.7.0 Bump github.com/gin-gonic/gin from 1.6.3 to 1.7.0 in /3rd-parties/gin

view details

push time in a month

PR merged momotaro98/go-codes-for-learning

Bump github.com/gin-gonic/gin from 1.6.3 to 1.7.0 in /3rd-parties/gin dependencies

Bumps github.com/gin-gonic/gin from 1.6.3 to 1.7.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/gin-gonic/gin/releases">github.com/gin-gonic/gin's releases</a>.</em></p> <blockquote> <h2>Release v1.7.0</h2> <h3>BUGFIXES</h3> <ul> <li>fix compile error from <a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2572">#2572</a> (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2600">#2600</a>)</li> <li>fix: print headers without Authorization header on broken pipe (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2528">#2528</a>)</li> <li>fix(tree): reassign fullpath when register new node (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2366">#2366</a>)</li> </ul> <h3>ENHANCEMENTS</h3> <ul> <li>Support params and exact routes without creating conflicts (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2663">#2663</a>)</li> <li>chore: improve render string performance (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2365">#2365</a>)</li> <li>Sync route tree to httprouter latest code (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2368">#2368</a>)</li> <li>chore: rename getQueryCache/getFormCache to initQueryCache/initFormCa (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2375">#2375</a>)</li> <li>chore(performance): improve countParams (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2378">#2378</a>)</li> <li>Remove some functions that have the same effect as the bytes package (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2387">#2387</a>)</li> <li>update:SetMode function (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2321">#2321</a>)</li> <li>remove a unused type SecureJSONPrefix (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2391">#2391</a>)</li> <li>Add a redirect sample for POST method (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2389">#2389</a>)</li> <li>Add CustomRecovery builtin middleware (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2322">#2322</a>)</li> <li>binding: avoid 2038 problem on 32-bit architectures (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2450">#2450</a>)</li> <li>Prevent panic in Context.GetQuery() when there is no Request (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2412">#2412</a>)</li> <li>Add GetUint and GetUint64 method on gin.context (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2487">#2487</a>)</li> <li>update content-disposition header to MIME-style (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2512">#2512</a>)</li> <li>reduce allocs and improve the render <code>WriteString</code> (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2508">#2508</a>)</li> <li>implement ".Unwrap() error" on Error type (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2525">#2525</a>) (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2526">#2526</a>)</li> <li>Allow bind with a map[string]string (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2484">#2484</a>)</li> <li>chore: update tree (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2371">#2371</a>)</li> <li>Support binding for slice/array obj [Rewrite] (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2302">#2302</a>)</li> <li>basic auth: fix timing oracle (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2609">#2609</a>)</li> <li>Add mixed param and non-param paths (port of httprouter<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/329">#329</a>) (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2663">#2663</a>)</li> <li>feat(engine): add trustedproxies and remoteIP (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2632">#2632</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/gin-gonic/gin/blob/master/CHANGELOG.md">github.com/gin-gonic/gin's changelog</a>.</em></p> <blockquote> <h2>Gin v1.7.0</h2> <h3>BUGFIXES</h3> <ul> <li>fix compile error from <a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2572">#2572</a> (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2600">#2600</a>)</li> <li>fix: print headers without Authorization header on broken pipe (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2528">#2528</a>)</li> <li>fix(tree): reassign fullpath when register new node (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2366">#2366</a>)</li> </ul> <h3>ENHANCEMENTS</h3> <ul> <li>Support params and exact routes without creating conflicts (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2663">#2663</a>)</li> <li>chore: improve render string performance (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2365">#2365</a>)</li> <li>Sync route tree to httprouter latest code (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2368">#2368</a>)</li> <li>chore: rename getQueryCache/getFormCache to initQueryCache/initFormCa (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2375">#2375</a>)</li> <li>chore(performance): improve countParams (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2378">#2378</a>)</li> <li>Remove some functions that have the same effect as the bytes package (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2387">#2387</a>)</li> <li>update:SetMode function (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2321">#2321</a>)</li> <li>remove a unused type SecureJSONPrefix (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2391">#2391</a>)</li> <li>Add a redirect sample for POST method (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2389">#2389</a>)</li> <li>Add CustomRecovery builtin middleware (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2322">#2322</a>)</li> <li>binding: avoid 2038 problem on 32-bit architectures (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2450">#2450</a>)</li> <li>Prevent panic in Context.GetQuery() when there is no Request (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2412">#2412</a>)</li> <li>Add GetUint and GetUint64 method on gin.context (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2487">#2487</a>)</li> <li>update content-disposition header to MIME-style (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2512">#2512</a>)</li> <li>reduce allocs and improve the render <code>WriteString</code> (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2508">#2508</a>)</li> <li>implement ".Unwrap() error" on Error type (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2525">#2525</a>) (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2526">#2526</a>)</li> <li>Allow bind with a map[string]string (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2484">#2484</a>)</li> <li>chore: update tree (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2371">#2371</a>)</li> <li>Support binding for slice/array obj [Rewrite] (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2302">#2302</a>)</li> <li>basic auth: fix timing oracle (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2609">#2609</a>)</li> <li>Add mixed param and non-param paths (port of httprouter<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/329">#329</a>) (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2663">#2663</a>)</li> <li>feat(engine): add trustedproxies and remoteIP (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/pull/2632">#2632</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/gin-gonic/gin/commit/d496f64540b6707602de50ab57aeea8ff4080b74"><code>d496f64</code></a> bump to v1.7.0 version (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2672">#2672</a>)</li> <li><a href="https://github.com/gin-gonic/gin/commit/bfc8ca285eb46dad60e037d57c545cd260636711"><code>bfc8ca2</code></a> feat(engine): add trustedproxies and remoteIP (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2632">#2632</a>)</li> <li><a href="https://github.com/gin-gonic/gin/commit/f3de8132c5d955784deeadb9bcf5752e9fdf0d8c"><code>f3de813</code></a> Add mixed param and non-param paths (port of httprouter#329) (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2663">#2663</a>)</li> <li><a href="https://github.com/gin-gonic/gin/commit/a331dc6a31473b7208c57ec32e14bfcec3062dbb"><code>a331dc6</code></a> chore: remove duplicate test 'assert.Equal' (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2617">#2617</a>)</li> <li><a href="https://github.com/gin-gonic/gin/commit/ed6f85c478ba00e5168be1f29ffcdc9a983568b8"><code>ed6f85c</code></a> build: convert to go:build directives (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2664">#2664</a>)</li> <li><a href="https://github.com/gin-gonic/gin/commit/1bdf86b722026fd650fddfef7fe9bd8342b51b7a"><code>1bdf86b</code></a> Remove the tedious named return value (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2620">#2620</a>)</li> <li><a href="https://github.com/gin-gonic/gin/commit/e899771392ecf35de8ce10a030ed8fed2207e9cb"><code>e899771</code></a> chore: Deleted spaces (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2622">#2622</a>)</li> <li><a href="https://github.com/gin-gonic/gin/commit/b01605bb5b43dbf33781970af5ad6633e5549fd1"><code>b01605b</code></a> basic auth: fix timing oracle (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2609">#2609</a>)</li> <li><a href="https://github.com/gin-gonic/gin/commit/46ddd4259cac975be1eb11b4f1192264f582db16"><code>46ddd42</code></a> Fixes to the graceful shutdown example (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2552">#2552</a>)</li> <li><a href="https://github.com/gin-gonic/gin/commit/f4bc259de33c561fd3b0ae3e7aaa849c1d251c0b"><code>f4bc259</code></a> fix error gin support min Go version (<a href="https://github-redirect.dependabot.com/gin-gonic/gin/issues/2584">#2584</a>)</li> <li>Additional commits viewable in <a href="https://github.com/gin-gonic/gin/compare/v1.6.3...v1.7.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+20 -5

0 comment

2 changed files

dependabot[bot]

pr closed time in a month

push eventmomotaro98/go-codes-for-learning

Shintaro Ikeda

commit sha aa1ef54525a9a67f26519285f02876e05385ce41

update

view details

Shintaro Ikeda

commit sha 1bddbda3386be0e2a3726dfdbbd3c0d71a9bde90

update

view details

push time in a month

starteduber-go/goleak

started time in a month

startedcybozu-go/well

started time in a month

startedmosuka/phalanx

started time in a month

more