profile
viewpoint
Robert Fletcher mockdeep San Francisco, California https://boon.gl/

mockdeep/better 55

Open. Democratic. Project management platform.

mockdeep/dotfiles 2

my dotfiles and config files

mockdeep/knowledgepile 2

Learn, and stuff

jessieay/tithe 1

Startup Weekend SF Project

mockdeep/ancient-js 1

JavaScript frontend for Roark

mockdeep/bars 1

Now you're thinking with bars

mockdeep/Clutter 1

A quick-to-play language game for Android

mockdeep/dun 1

a dead simple command line based todo list manager

delete branch mockdeep/Rails-Template

delete branch : rf-bump_gems

delete time in 4 hours

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha 962d991c6906fa27382f89ca280e4a38960842c0

Upgrades: bump minor gem versions (#382)

view details

push time in 4 hours

PR opened mockdeep/Rails-Template

Upgrades: bump minor gem versions
+27 -12

0 comment

3 changed files

pr created time in 4 hours

create barnchmockdeep/Rails-Template

branch : rf-bump_gems

created branch time in 4 hours

delete branch mockdeep/Rails-Template

delete branch : rf-bump_yarn

delete time in 4 hours

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha bac6940dee4f4a9e8a75a917efd00359a6093cc1

Upgrades: bump minor npm package versions (#381)

view details

push time in 4 hours

create barnchmockdeep/Rails-Template

branch : rf-bump_yarn

created branch time in 5 hours

issue commentrspec/rspec-rails

uninitialized constant RSpec::Mocks::ExampleMethods

Got it, thanks.

mockdeep

comment created time in 4 days

issue commentdependabot/feedback

Post upgrade script

@jurre unfortunately our current plan doesn't allow Actions. I'm not familiar enough with them to know whether that would work. Can they amend a commit for an open PR?

mockdeep

comment created time in 4 days

issue openeddependabot/feedback

Post upgrade script

I'd love for it to be possible to run some command after an upgrade. For example, running yarn deduplicate or rubocop --auto-gen-config. Right now our CI fails on these, so I end up pulling down the branch, running the commands manually, and force pushing back up.

created time in 4 days

issue commentdependabot/dependabot-core

Add grouped updates

I would love to see something like this. It could actually be really useful to have all minor/patch updates grouped in one PR, and separate PRs for major version updates.

anym0us

comment created time in 4 days

issue commentrspec/rspec-rails

uninitialized constant RSpec::Mocks::ExampleMethods

@JonRowe how do you restart bootsnap? I did rm -rf tmp/cache but I don't see anything else in their docs. Either way, it still fails even after a clean reboot, as well as on our CI machines. Do you have any idea why this would only start happening after an upgrade to 4.0.0?

mockdeep

comment created time in 4 days

issue openedrspec/rspec-rails

uninitialized constant RSpec::Mocks::ExampleMethods

What Ruby, Rails and RSpec versions are you using?

Ruby version: 2.5.3 Rails version: 5.2.4.2 RSpec 3.9

  • rspec-core 3.9.1
  • rspec-expectations 3.9.1
  • rspec-mocks 3.9.1
  • rspec-rails 4.0.0
  • rspec-support 3.9.2

Observed behaviour

In one of our test helpers, we have the following:

class FeatureFlow
  include RSpec::Matchers, RSpec::Mocks::ExampleMethods, Capybara::DSL
 
  ...
end

When this class loads during the test bootup, we get the following error:

NameError:
  uninitialized constant RSpec::Mocks::ExampleMethods
# /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/active_support.rb:80:in `block in load_missing_constant'
# /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/active_support.rb:9:in `without_bootsnap_cache'
# /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/active_support.rb:80:in `rescue in load_missing_constant'
# /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/active_support.rb:59:in `load_missing_constant'
# ./spec/features/_support/feature_flow.rb:4:in `<class:FeatureFlow>'
# ./spec/features/_support/feature_flow.rb:3:in `<top (required)>'
# /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:23:in `require'
# /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:23:in `block in require_with_bootsnap_lfi'
# /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in `register'
# /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in `require_with_bootsnap_lfi'
# /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:31:in `require'
# ./spec/rails_helper.rb:33:in `block in <top (required)>'
# ./spec/rails_helper.rb:33:in `each'
# ./spec/rails_helper.rb:33:in `<top (required)>'
# ------------------
# --- Caused by: ---
# NameError:
#   uninitialized constant RSpec::Mocks::ExampleMethods
#   /home/fletch/.rvm/gems/ruby-2.5.3/gems/bootsnap-1.4.6/lib/bootsnap/load_path_cache/core_ext/active_support.rb:61:in `block in load_missing_constant'

Rails helper, up to line 33 looks like:

# frozen_string_literal: true

require 'rubygems'
require 'simplecov'
require 'vcr'

SimpleCov.coverage_dir('coverage/simplecov')
SimpleCov.start :rails do
  add_filter 'lib/mailer_previews'
end

SimpleCov.minimum_coverage(100) if ENV['CI'] && !ENV['SLOW']

# This file is copied to spec/ when you run 'rails generate rspec:install'
ENV['RAILS_ENV'] ||= 'test'
require File.expand_path('../config/environment', __dir__)
def spec_root
  @spec_root ||= Rails.root.join('spec')
end

require 'rspec'
require 'rspec/rails'
require 'capybara/rspec'
require 'capybara-screenshot/rspec'
require 'sidekiq'
require 'sidekiq/testing/inline'
require 'sidekiq-status/testing/inline'
require 'paper_trail/frameworks/rspec'

Dir[spec_root.join('_shared_examples', '*.rb')].each { |f| require f }
Dir[spec_root.join('_shared_context', '*.rb')].each { |f| require f }
Dir[spec_root.join('support', '*.rb')].each { |f| require f }
Dir[spec_root.join('features', '_support', '*.rb')].each { |f| require f }

Expected behaviour

We should be able to include the module RSpec::Mocks::ExampleMethods. This works in rspec-rails 3.9.1, but not in 4.0.0. If I add require 'rspec/mocks' above that line it does seem to work fine. But this seems like some sort of regression.

Can you provide an example app?

Sorry, no.

created time in 5 days

delete branch mockdeep/Rails-Template

delete branch : dependabot/npm_and_yarn/rails/webpacker-5.0.1

delete time in 5 days

push eventmockdeep/Rails-Template

dependabot-preview[bot]

commit sha f2c45dfb4b66f011c7b573f64423868dba7e601a

Bump @rails/webpacker from 4.2.2 to 5.0.1 (#367) Bumps [@rails/webpacker](https://github.com/rails/webpacker) from 4.2.2 to 5.0.1. - [Release notes](https://github.com/rails/webpacker/releases) - [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md) - [Commits](https://github.com/rails/webpacker/compare/v4.2.2...v5.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 5 days

PR merged mockdeep/Rails-Template

Reviewers
Bump @rails/webpacker from 4.2.2 to 5.0.1 dependencies javascript

Bumps @rails/webpacker from 4.2.2 to 5.0.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rails/webpacker/blob/master/CHANGELOG.md">@rails/webpacker's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/rails/webpacker/compare/v4.2.2...v5.0.0">[5.0.1]</a> - 2020-03-22</h2> <ul> <li>Upgrade deps and fix sass loader config options bug <a href="https://github-redirect.dependabot.com/rails/webpacker/pull/2508">#2508</a></li> </ul> <h2><a href="https://github.com/rails/webpacker/compare/v4.2.2...v5.0.0">[5.0.0]</a> - 2020-03-22</h2> <ul> <li>Bump minimum node version <a href="https://github-redirect.dependabot.com/rails/webpacker/pull/2428">#2428</a></li> <li>Bump minimum ruby/rails version <a href="https://github-redirect.dependabot.com/rails/webpacker/pull/2415">#2415</a></li> <li>Add support for multiple files per entry <a href="https://github-redirect.dependabot.com/rails/webpacker/pull/2476">#2476</a></li> </ul> <pre lang="js"><code> entry: { home: ['./home.js', './home.scss'], account: ['./account.js', './account.scss'] } </code></pre> <p>You can now have two entry files with same names inside packs folder, <code>home.scss</code> and <code>home.js</code></p> <p>And, other minor fixes, please see a list of changes <a href="https://github.com/rails/webpacker/compare/v4.2.2...v5.0.0">here</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rails/webpacker/commit/8e8e7454e3022fa01cae051fd537a82a9b4c9ebe"><code>8e8e745</code></a> 5.0.1</li> <li><a href="https://github.com/rails/webpacker/commit/49ead9ea2631f753c4a612472691667112485298"><code>49ead9e</code></a> Update dependencies (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2508">#2508</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/f107c469ee8901b49fb30fc42d236c4806783765"><code>f107c46</code></a> Update readme to reflect 5.0.0 release</li> <li><a href="https://github.com/rails/webpacker/commit/e054273a0165aa1125389eb1cbac01a2a9f8b72a"><code>e054273</code></a> 5.0.0</li> <li><a href="https://github.com/rails/webpacker/commit/f467cb315679c28293824c32bb567b3481057b0c"><code>f467cb3</code></a> EOL for Rails < 5.2 and Ruby < 2.3.0 (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2415">#2415</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/53d57722a3ef07fa10ca63c82a6d3316249e9f11"><code>53d5772</code></a> update docs/docker.md : keep it as much simple as possible (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2481">#2481</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/4606c6d0d3f9a48f99d94d8a656a28cff6ca2f9b"><code>4606c6d</code></a> Syntax error if left as string. (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2495">#2495</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/b033d55cc60d5e37e066013482c19ee3596bf240"><code>b033d55</code></a> Update js dependencies (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2428">#2428</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/42273e136182e4801da920a0559b76d0f00f62bc"><code>42273e1</code></a> fix broken links of integration docs in table content (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2493">#2493</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/d009d6b511a9888160a955172bc7b19b1a05013a"><code>d009d6b</code></a> add direct anchor link to each specific setup of integration doc (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2492">#2492</a>)</li> <li>Additional commits viewable in <a href="https://github.com/rails/webpacker/compare/v4.2.2...v5.0.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+94 -206

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 5 days

delete branch mockdeep/Rails-Template

delete branch : dependabot/bundler/rspec-rails-4.0.0

delete time in 5 days

push eventmockdeep/Rails-Template

dependabot-preview[bot]

commit sha c7689e6924840d726c802d12a1f30f64bbfc8dd0

Bump rspec-rails from 3.9.1 to 4.0.0 (#368) Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 3.9.1 to 4.0.0. - [Release notes](https://github.com/rspec/rspec-rails/releases) - [Changelog](https://github.com/rspec/rspec-rails/blob/master/Changelog.md) - [Commits](https://github.com/rspec/rspec-rails/compare/v3.9.1...v4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 5 days

PR merged mockdeep/Rails-Template

Bump rspec-rails from 3.9.1 to 4.0.0 dependencies ruby

Bumps rspec-rails from 3.9.1 to 4.0.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rspec/rspec-rails/blob/master/Changelog.md">rspec-rails's changelog</a>.</em></p> <blockquote> <h3>4.0.0 / 2020-03-24</h3> <p><a href="https://github.com/rspec/rspec-rails/compare/v3.9.1...v4.0.0">Full Changelog</a></p> <p>Enhancements:</p> <ul> <li>Adds support for Rails 6. (Penelope Phippen, Benoit Tigeot, Jon Rowe, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2071">#2071</a>)</li> <li>Adds support for JRuby on Rails 5.2 and 6</li> <li>Add support for parameterised mailers (Ignatius Reza, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2125">#2125</a>)</li> <li>Add ActionMailbox spec helpers and test type (James Dabbs, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2119">#2119</a>)</li> <li>Add ActionCable spec helpers and test type (Vladimir Dementyev, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2113">#2113</a>)</li> <li>Add support for partial args when using <code>have_enqueued_mail</code> (Ignatius Reza, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2118">#2118</a>, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2125">#2125</a>)</li> <li>Add support for time arguments for <code>have_enqueued_job</code> (<a href="https://github.com/alpaca-tc">@alpaca-tc</a>, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2157">#2157</a>)</li> <li>Improve path parsing in view specs render options. (John Hawthorn, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2115">#2115</a>)</li> <li>Add routing spec template as an option for generating controller specs. (David Revelo, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2134">#2134</a>)</li> <li>Add argument matcher support to <code>have_enqueued_*</code> matchers. (Phil Pirozhkov, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2206">#2206</a>)</li> <li>Switch generated templates to use ruby 1.9 hash keys. (Tanbir Hasan, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2224">#2224</a>)</li> <li>Add <code>have_been_performed</code>/<code>have_performed_job</code>/<code>perform_job</code> ActiveJob matchers (Isaac Seymour, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/1785">#1785</a>)</li> <li>Default to generating request specs rather than controller specs when generating a controller (Luka Lüdicke, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2222">#2222</a>)</li> <li>Allow <code>ActiveJob</code> matchers <code>#on_queue</code> modifier to take symbolic queue names. (Nils Sommer, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2283">#2283</a>)</li> <li>The scaffold generator now generates request specs in preference to controller specs. (Luka Lüdicke, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2288">#2288</a>)</li> <li>Add configuration option to disable ActiveRecord. (Jon Rowe, Phil Pirozhkov, Hermann Mayer, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2266">#2266</a>)</li> <li>Set <code>ActionDispatch::SystemTesting::Server.silence_puma = true</code> when running system specs. (ta1kt0me, Benoit Tigeot, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2289">#2289</a>)</li> </ul> <p>Bug Fixes:</p> <ul> <li><code>EmptyTemplateHandler.call</code> now needs to support an additional argument in Rails 6. (Pavel Rosický, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2089">#2089</a>)</li> <li>Suppress warning from <code>SQLite3Adapter.represent_boolean_as_integer</code> which is deprecated. (Pavel Rosický, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2092">#2092</a>)</li> <li><code>ActionView::Template#formats</code> has been deprecated and replaced by <code>ActionView::Template#format</code>(Seb Jacobs, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2100">#2100</a>)</li> <li>Replace <code>before_teardown</code> as well as <code>after_teardown</code> to ensure screenshots are generated correctly. (Jon Rowe, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2164">#2164</a>)</li> <li><code>ActionView::FixtureResolver#hash</code> has been renamed to <code>ActionView::FixtureResolver#data</code>. (Penelope Phippen, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2076">#2076</a>)</li> <li>Prevent <code>driven_by(:selenium)</code> being called due to hook precedence. (Takumi Shotoku, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2188">#2188</a>)</li> <li>Prevent a <code>WrongScopeError</code> being thrown during loading fixtures on Rails 6.1 development version. (Edouard Chin, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2215">#2215</a>)</li> <li>Fix Mocha mocking support with <code>should</code>. (Phil Pirozhkov, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2256">#2256</a>)</li> <li>Restore previous conditional check for setting <code>default_url_options</code> in feature specs, prevents a <code>NoMethodError</code> in some scenarios. (Eugene Kenny, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2277">#2277</a>)</li> <li>Allow changing <code>ActiveJob::Base.queue_adapter</code> inside a system spec. (Jonathan Rochkind, <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2242">#2242</a>)</li> </ul> </tr></table> ... (truncated) </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rspec/rspec-rails/commit/d810df59bb3b4ea7f3a2a0d0b169f2f2b9d390ac"><code>d810df5</code></a> v4.0.0</li> <li><a href="https://github.com/rspec/rspec-rails/commit/90e8b7bf9882734d3ad5600af46073f108ee7863"><code>90e8b7b</code></a> Merge branch 'add-test-mailbox-clear' into 4-0-maintenance</li> <li><a href="https://github.com/rspec/rspec-rails/commit/a597994cac62e80f79b00a54a351738bd45f6625"><code>a597994</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2295">#2295</a> from rspec/reword-specs</li> <li><a href="https://github.com/rspec/rspec-rails/commit/ee99c1112d1c216f9a76c3caaa29a255c90ebc57"><code>ee99c11</code></a> Typo 🙃</li> <li><a href="https://github.com/rspec/rspec-rails/commit/87354750f24778b5ac3e942bb1a7e790eb680bca"><code>8735475</code></a> Changelog for <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2293">#2293</a></li> <li><a href="https://github.com/rspec/rspec-rails/commit/a7891f51a55f120f3322b26df2d63bb59909d710"><code>a7891f5</code></a> Switch to an anonymous class instead</li> <li><a href="https://github.com/rspec/rspec-rails/commit/dff5c2227a36538e6662cf1740a701b8e87ad712"><code>dff5c22</code></a> More generic 'describe' description</li> <li><a href="https://github.com/rspec/rspec-rails/commit/5556f1b53b70899a9127a06877f7a4fb804ed4f7"><code>5556f1b</code></a> Clear test mailbox from ActionMailer::Base between each example</li> <li><a href="https://github.com/rspec/rspec-rails/commit/52d1665f1cbd309add363f09a0deadbc444aa087"><code>52d1665</code></a> Merge branch 'add-puma-log-silencing' into 4-0-maintenance</li> <li><a href="https://github.com/rspec/rspec-rails/commit/12ae686247e333cab29fd9dd12af56238aec3883"><code>12ae686</code></a> Refers changelog PR to <a href="https://github-redirect.dependabot.com/rspec/rspec-rails/issues/2289">#2289</a></li> <li>Additional commits viewable in <a href="https://github.com/rspec/rspec-rails/compare/v3.9.1...v4.0.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+8 -8

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 5 days

delete branch mockdeep/Rails-Template

delete branch : dependabot/bundler/webpacker-5.0.1

delete time in 5 days

push eventmockdeep/Rails-Template

dependabot-preview[bot]

commit sha 7e257a504980704e343b013c116154b663f63a5a

Bump webpacker from 4.2.2 to 5.0.1 (#373) Bumps [webpacker](https://github.com/rails/webpacker) from 4.2.2 to 5.0.1. - [Release notes](https://github.com/rails/webpacker/releases) - [Changelog](https://github.com/rails/webpacker/blob/master/CHANGELOG.md) - [Commits](https://github.com/rails/webpacker/compare/v4.2.2...v5.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 5 days

PR merged mockdeep/Rails-Template

Bump webpacker from 4.2.2 to 5.0.1 dependencies ruby

Bumps webpacker from 4.2.2 to 5.0.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rails/webpacker/blob/master/CHANGELOG.md">webpacker's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/rails/webpacker/compare/v4.2.2...v5.0.0">[5.0.1]</a> - 2020-03-22</h2> <ul> <li>Upgrade deps and fix sass loader config options bug <a href="https://github-redirect.dependabot.com/rails/webpacker/pull/2508">#2508</a></li> </ul> <h2><a href="https://github.com/rails/webpacker/compare/v4.2.2...v5.0.0">[5.0.0]</a> - 2020-03-22</h2> <ul> <li>Bump minimum node version <a href="https://github-redirect.dependabot.com/rails/webpacker/pull/2428">#2428</a></li> <li>Bump minimum ruby/rails version <a href="https://github-redirect.dependabot.com/rails/webpacker/pull/2415">#2415</a></li> <li>Add support for multiple files per entry <a href="https://github-redirect.dependabot.com/rails/webpacker/pull/2476">#2476</a></li> </ul> <pre lang="js"><code> entry: { home: ['./home.js', './home.scss'], account: ['./account.js', './account.scss'] } </code></pre> <p>You can now have two entry files with same names inside packs folder, <code>home.scss</code> and <code>home.js</code></p> <p>And, other minor fixes, please see a list of changes <a href="https://github.com/rails/webpacker/compare/v4.2.2...v5.0.0">here</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rails/webpacker/commit/8e8e7454e3022fa01cae051fd537a82a9b4c9ebe"><code>8e8e745</code></a> 5.0.1</li> <li><a href="https://github.com/rails/webpacker/commit/49ead9ea2631f753c4a612472691667112485298"><code>49ead9e</code></a> Update dependencies (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2508">#2508</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/f107c469ee8901b49fb30fc42d236c4806783765"><code>f107c46</code></a> Update readme to reflect 5.0.0 release</li> <li><a href="https://github.com/rails/webpacker/commit/e054273a0165aa1125389eb1cbac01a2a9f8b72a"><code>e054273</code></a> 5.0.0</li> <li><a href="https://github.com/rails/webpacker/commit/f467cb315679c28293824c32bb567b3481057b0c"><code>f467cb3</code></a> EOL for Rails < 5.2 and Ruby < 2.3.0 (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2415">#2415</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/53d57722a3ef07fa10ca63c82a6d3316249e9f11"><code>53d5772</code></a> update docs/docker.md : keep it as much simple as possible (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2481">#2481</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/4606c6d0d3f9a48f99d94d8a656a28cff6ca2f9b"><code>4606c6d</code></a> Syntax error if left as string. (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2495">#2495</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/b033d55cc60d5e37e066013482c19ee3596bf240"><code>b033d55</code></a> Update js dependencies (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2428">#2428</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/42273e136182e4801da920a0559b76d0f00f62bc"><code>42273e1</code></a> fix broken links of integration docs in table content (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2493">#2493</a>)</li> <li><a href="https://github.com/rails/webpacker/commit/d009d6b511a9888160a955172bc7b19b1a05013a"><code>d009d6b</code></a> add direct anchor link to each specific setup of integration doc (<a href="https://github-redirect.dependabot.com/rails/webpacker/issues/2492">#2492</a>)</li> <li>Additional commits viewable in <a href="https://github.com/rails/webpacker/compare/v4.2.2...v5.0.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+5 -3

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 5 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha aa573fa510aa614055560df7476871ee8da97ca1

Upgrades: bump minor gem versions (#375)

view details

push time in 5 days

delete branch mockdeep/Rails-Template

delete branch : rf-bump_gems

delete time in 5 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha c5fe8f926ae15dc89509d050b85eb1bd81baab40

Upgrades: bump minor gem versions

view details

push time in 5 days

delete branch mockdeep/Rails-Template

delete branch : rf-bump_yarn

delete time in 5 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha 5cab2940dd62ce415fec94ba7a263784c5272b7f

Upgrades: bump minor npm package versions (#374)

view details

push time in 5 days

create barnchmockdeep/Rails-Template

branch : rf-bump_yarn

created branch time in 5 days

push eventmockdeep/scripts

Robert Fletcher

commit sha 27d649d53daaf19face9637331531a412f036b19

Proppify: better capitalize, remove extra ts_check

view details

Robert Fletcher

commit sha 3a35bc763fae1842bf3069d43ebaa082cf2438a1

Proppify: extract BestGuessStrategy This to make room for more sophisticated strategies.

view details

push time in 7 days

pull request commentrmagick/rmagick

Fix bug of signal handling internally

@Watson1978 version 4.1.1 has been released.

Watson1978

comment created time in 8 days

created tagrmagick/rmagick

tagRMagick_4-1-1

Ruby bindings for ImageMagick

created time in 8 days

delete branch rmagick/rmagick

delete branch : rf-bump_version

delete time in 8 days

push eventrmagick/rmagick

Robert Fletcher

commit sha bddcc2b745627472ed5768e7e51b2ad35f4c0f9a

Release: bump version, update changelog (#1190)

view details

push time in 8 days

PR opened rmagick/rmagick

Release: bump version, update changelog
+7 -1

0 comment

2 changed files

pr created time in 8 days

create barnchrmagick/rmagick

branch : rf-bump_version

created branch time in 8 days

push eventmockdeep/scripts

Robert Fletcher

commit sha 2c6427a0d1555fcccf49e812942e17a02f7fcf31

better capitalize type and add props export

view details

push time in 8 days

Pull request review commentrmagick/rmagick

GitHub: Add Issue template

+### Description+<!-- A description of the bug or feature -->++### Steps to Reproduce+<!-- List of steps, sample code, failing test or link to a project that reproduces the behavior.+     Make sure you place a stack trace inside a code (```) block to avoid linking unrelated issues -->++### System Configuration+<!-- Tell us about the environment where you are experiencing the bug -->++- ImageMagick version:+- RMagick version:

@Watson1978 should this have Ruby version, too?

Watson1978

comment created time in 9 days

push eventrmagick/rmagick

Le1gh

commit sha 919e2bd00de090dc5b6f227b8c84ee7fd66af2bd

Flesh out tests for Image#charcoal (#1150) This introduces a new `match_pixels` test matcher that accepts a delta argument. These tests produce varying results on different operating systems and versions of ImageMagick, so we set the delta. We're filtering out ImageMagick 6.7 because it produces a black and white image.

view details

push time in 13 days

PR merged rmagick/rmagick

Flesh out tests for Image#charcoal

This introduces a new match_pixels test matcher that accepts a delta argument. These tests produce varying results on different operating systems and versions of ImageMagick, so we set the delta to 1.. We're filtering out ImageMagick 6.7 because it produces a black and white image.

+64 -7

4 comments

4 changed files

Le1gh

pr closed time in 13 days

issue closedrmagick/rmagick

support for ImageMagick 7.0.x

As ImageMagick renewed the prefix of its header files at version 7, I can't build RMagick with ImageMagick-7.0.2.

Probably #254 is related with this problem.

ImageMagick: Porting to ImageMagick Version 7

Header Files

Prior versions of ImageMagick (4-6) reference the ImageMagick header files as magick/ and wand/. > ImageMagick 7 instead uses MagickCore/ and MagickWand/ respectively. For example,

#include <MagickCore/MagickCore.h>
#include <MagickWand/MagickWand.h>

This is my build log on Raspberry Pi.

current directory: /home/kb10uy/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/rmagick-42aa8ce34f61/ext/RMagick
/home/kb10uy/.rbenv/versions/2.3.1/bin/ruby -r ./siteconf20160812-28804-12a4s7p.rb extconf.rb
checking for gcc... yes
checking for Magick-config... no
checking for pkg-config... yes
checking for outdated ImageMagick version (<= 6.4.9)... no
checking for presence of MagickWand API (ImageMagick version >= 6.9.0)... no
checking for Ruby version >= 1.8.5... yes
checking for stdint.h... yes
checking for sys/types.h... yes
checking for wand/MagickWand.h... no

Can't install RMagick 2.15.4. Can't find MagickWand.h.
*** extconf.rb failed ***
Could not create Makefile due to some reason, probably lack of necessary
libraries and/or headers.  Check the mkmf.log file for more details.  You may
need configuration options.

Provided configuration options:
        --with-opt-dir
        --without-opt-dir
        --with-opt-include
        --without-opt-include=${opt-dir}/include
        --with-opt-lib
        --without-opt-lib=${opt-dir}/lib
        --with-make-prog
        --without-make-prog
        --srcdir=.
        --curdir
        --ruby=/home/kb10uy/.rbenv/versions/2.3.1/bin/$(RUBY_BASE_NAME)

To see why this extension failed to compile, please check the mkmf.log which can be found here:

  /home/kb10uy/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/extensions/armv6l-linux/2.3.0-static/rmagick-42aa8ce34f61/mkmf.log

extconf failed, exit code 1

closed time in 13 days

kb10uy

issue commentrmagick/rmagick

support for ImageMagick 7.0.x

Alright, folks. ImageMagick 7 support has been shipped in 4.1.0. Effusive thanks for @Watson1978 and @dlemstra for seeing this through. It's been more than a year's worth of work. Please open a new issue if you find something that doesn't work the way you expect it.

kb10uy

comment created time in 13 days

issue closedrmagick/rmagick

RMagick 4.1.0

I think there is no blocker any more to release RMagick 4.1.0-rc3 or RMagick 4.1.0.

@mockdeep @dlemstra

closed time in 13 days

Watson1978

issue commentrmagick/rmagick

RMagick 4.1.0

Okay, version 4.1.0 is live: https://rubygems.org/gems/rmagick/versions/4.1.0

Watson1978

comment created time in 13 days

created tagrmagick/rmagick

tagRMagick_4-1-0

Ruby bindings for ImageMagick

created time in 13 days

delete branch rmagick/rmagick

delete branch : rf-bump_version

delete time in 13 days

push eventrmagick/rmagick

Robert Fletcher

commit sha e1d44a97a11f92b7304a360ca9bc4b6ac443074a

Release: bump version, update changelog (#1179)

view details

push time in 13 days

PR merged rmagick/rmagick

Release: bump version, update changelog
+64 -1

4 comments

2 changed files

mockdeep

pr closed time in 13 days

pull request commentrmagick/rmagick

Release: bump version, update changelog

Okay, we'll go ahead and release 4.1.0, then. rc2 has been out for 6 months, so if that hasn't been downloaded much, then we're probably not going to see much from rc3.

mockdeep

comment created time in 13 days

Pull request review commentrmagick/rmagick

Yardoc: Use @private primitive instead of :nodoc: for yard

 class RVG     module Describable       private -      def initialize(*args, &block) #:nodoc:+      def initialize(*args, &block)

@Watson1978 did you intend for this to become public?

Watson1978

comment created time in 14 days

delete branch mockdeep/Rails-Template

delete branch : dependabot/bundler/ffi-1.12.1

delete time in 14 days

PR closed mockdeep/Rails-Template

Bump ffi from 1.11.3 to 1.12.1

Bumps ffi from 1.11.3 to 1.12.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ffi/ffi/blob/master/CHANGELOG.md">ffi's changelog</a>.</em></p> <blockquote> <h2>1.12.1 / 2020-01-14</h2> <p>Added:</p> <ul> <li>Add binary gem support for ruby-2.7 on Windows</li> </ul> <h2>1.12.0 / 2020-01-14</h2> <p>Added:</p> <ul> <li>FFI::VERSION is defined as part of <code>require 'ffi'</code> now. It is no longer necessary to <code>require 'ffi/version'</code> .</li> </ul> <p>Changed:</p> <ul> <li>Update libffi to latest master.</li> </ul> <p>Deprecated:</p> <ul> <li>Overwriting struct layouts is now warned and will be disallowed in ffi-2.0. <a href="https://github-redirect.dependabot.com/ffi/ffi/issues/734">#734</a>, <a href="https://github-redirect.dependabot.com/ffi/ffi/issues/735">#735</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ffi/ffi/commit/b54e735b11abef310c58b0f33dfc1af8f78f007e"><code>b54e735</code></a> Bump VERSION to 1.12.1</li> <li><a href="https://github.com/ffi/ffi/commit/ee13af16bd290e9d5c9d74eecfc563017284b6f5"><code>ee13af1</code></a> Do parallel builds in CI docker containers</li> <li><a href="https://github.com/ffi/ffi/commit/2c81c6b48bd9fe7bb0790e850b6e68b70f036b5d"><code>2c81c6b</code></a> Respect MAKE environment variable for libtest build</li> <li><a href="https://github.com/ffi/ffi/commit/b2793a362f95a64ba4b99d1984e6d3fbe91d417d"><code>b2793a3</code></a> Better document enable/disable libffi switches in the README</li> <li><a href="https://github.com/ffi/ffi/commit/8169aef7e0bd65eefa49ae626bf6b61012ef470a"><code>8169aef</code></a> Bump VERSION to 1.12.0</li> <li><a href="https://github.com/ffi/ffi/commit/62c0c9712acb0b94c15cd22d316149e71bcf9658"><code>62c0c97</code></a> Update CHANGELOG for version 1.12.0</li> <li><a href="https://github.com/ffi/ffi/commit/da4402fd007b03b440c69f55c3e1fd8222294f09"><code>da4402f</code></a> Update libffi to latest master branch</li> <li><a href="https://github.com/ffi/ffi/commit/d564eb451a6372d460b156f3269381701f79ec97"><code>d564eb4</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/ffi/ffi/issues/735">#735</a> from larskanis/disallow-re-layout</li> <li><a href="https://github.com/ffi/ffi/commit/89f4258ca9d637bba8f0d149a0c764aff5ff864d"><code>89f4258</code></a> Warn about Struct layout redefinition only</li> <li><a href="https://github.com/ffi/ffi/commit/bd45ff5913757d67d96d81f24ef7a919dbdf25ce"><code>bd45ff5</code></a> Namespace all benchmarks since they are loaded into one process</li> <li>Additional commits viewable in <a href="https://github.com/ffi/ffi/compare/1.11.3...1.12.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

2 comments

1 changed file

dependabot-preview[bot]

pr closed time in 14 days

pull request commentmockdeep/Rails-Template

Bump ffi from 1.11.3 to 1.12.1

@dependabot rebase

dependabot-preview[bot]

comment created time in 14 days

delete branch mockdeep/Rails-Template

delete branch : rf-bump_yarn

delete time in 14 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha 446d906ddb3d76d87ce78581ce72174c1caf4e7a

Upgrades: bump minor npm package versions (#364)

view details

push time in 14 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha 2d83f6768c660639b5cd81bb2e28eca0c49f4050

Upgrades: bump minor gem versions (#365)

view details

Robert Fletcher

commit sha f49e9942e82997cdf7cb28decc1a6e9e8819b981

Upgrades: bump minor npm package versions

view details

push time in 14 days

delete branch mockdeep/Rails-Template

delete branch : rf-bump_gems

delete time in 14 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha 2d83f6768c660639b5cd81bb2e28eca0c49f4050

Upgrades: bump minor gem versions (#365)

view details

push time in 14 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha 7999981aaed930fcded2320782faee3898cdf59c

Upgrades: bump minor gem versions

view details

push time in 14 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha 3e0d9898d41f67997a71d9dfada4484938c13064

Upgrades: bump minor gem versions

view details

push time in 14 days

create barnchmockdeep/Rails-Template

branch : rf-bump_gems

created branch time in 14 days

create barnchmockdeep/Rails-Template

branch : rf-bump_yarn

created branch time in 14 days

push eventmockdeep/scripts

Robert Fletcher

commit sha 2c824a03a65a12aea4b0dcfc03f453ce10620343

add more deduplicate checks to bump, still seeing some duplicates

view details

Robert Fletcher

commit sha f325cb88943e14a6e61c206fc29d782712a743c4

allow proppify to support function components

view details

push time in 14 days

pull request commentrmagick/rmagick

Release: bump version, update changelog

@dlemstra I'm open to doing rc3 if you think that's appropriate. It seemed like a lot of fixes went into this most recent release, but maybe it's worth releasing another release candidate just to be safe.

mockdeep

comment created time in 14 days

PR opened rmagick/rmagick

Release: bump version, update changelog
+64 -1

0 comment

2 changed files

pr created time in 15 days

create barnchrmagick/rmagick

branch : rf-bump_version

created branch time in 15 days

pull request commentrubocop-hq/rubocop-rspec

Add NoLet cop

@pirj I renamed the file. It might take me a few days to get to the rest of it. With the COVID-19 drama, I've got my kid home, so that leaves me like 1 hour a day of concentrated work time while he's napping.

mockdeep

comment created time in 15 days

push eventmockdeep/rubocop-rspec

Ulugbek Tuychiev

commit sha 32d2e2fc71dd730349cc6d0c8c3d7081f2f37bef

implement example group repeated description\body cops

view details

Eddie Lebow

commit sha 85536ea685bc4541edf924fd1ae321dc3d01aed9

Add text to ContextWording docs encouraging configuration Context descriptions are written in freeform human language, so it is impossible to foresee all acceptable cases. Add text to the documentation encouraging users to configure the list of permitted prefixes to meet their needs. on-behalf-of: @Cofense <oss@cofense.com>

view details

Maxim Krizhanovsky

commit sha 218d2a0d37d64adb77f96b8cd4e0c5cba18e9108

Merge pull request #861 from Cofense/context-wording-new-words Encourage users to customize the permitted word list in `RSpec/ContextWording` (was: Add `before` and `after` to default list)

view details

Maxim Krizhanovsky

commit sha f7fe0113909eaee28e85c7584333b18fef24b27f

Merge pull request #860 from lazycoder9/cop/repeated_describe [Close #856] implement repeated example group description/body cops

view details

Koichi ITO

commit sha 5fcb4c9f59f263ef08dedf19e70bd32d91d43739

Workaround for cc-test-reporter with SimpleCov 0.18 This PR fixes the following build error when using cc-test-reporter with SimpleCov 0.18. ```consle % #!/bin/bash -eo pipefail ./cc-test-reporter before-build rake coverage ./cc-test-reporter after-build --exit-code $? (snip) Coverage report generated for RSpec to /home/circleci/project/coverage. 5051 / 5064 LOC (99.74%) covered. Error: json: cannot unmarshal object into Go struct field input.coverage of type []formatters.NullInt ``` https://circleci.com/gh/rubocop-hq/rubocop-rspec/10604 This patch is a workaround until the following issue will be resolved. codeclimate/test-reporter#418

view details

Benjamin Quorning

commit sha 0e4574468b9ed8a255ddbf7377c91e3aa700b0c2

Merge pull request #867 from koic/workaround_for_cc_test_reporter_with_simplecov Workaround for cc-test-reporter with SimpleCov 0.18

view details

Eddie Lebow

commit sha 318244ab53b53ba54b17d1a81dfc260cb89825ea

Add block name and other lines to RSpec/ScatteredSetup message on-behalf-of: @Cofense <oss@cofense.com>

view details

Benjamin Quorning

commit sha f39e5310beffc9b333351badc1f6ed103145c013

Merge pull request #866 from Cofense/scattered-setup-message-block-name Add block name and other lines to `RSpec/ScatteredSetup` message

view details

Ulugbek Tuychiev

commit sha 5024a1339b25a9b024cd85c1a4874700e4139f00

take metadata into account in repeated example description cop

view details

Benjamin Quorning

commit sha 292f6cb57fba11b939142a19b22fa178b106f445

Merge pull request #874 from lazycoder9/fix/repeated_example_description Take metadata into account in `RSpec/RepeatedDescription` cop

view details

Benjamin Quorning

commit sha 398f6fcfd2490f05b1325a01c28307adf2c5c674

Bump version to 1.38.0

view details

Benjamin Quorning

commit sha 9bce008e95154681945333e4a125013df43a3894

Merge pull request #875 from rubocop-hq/release Bump version to 1.38.0

view details

Benjamin Quorning

commit sha ed5d9daaef9043f39163c14b8f5589fd9a5c8a7e

Remove #one method It hasn't been used since cdce4a5ee4a576b8d25ba4db51e3483195754cae.

view details

Ulugbek Tuychiev

commit sha 2958ccbcc5fe214c53680ec5b154e6c526e6d1fb

RepeatedDescription detects not only string descriptions

view details

Benjamin Quorning

commit sha 2362e2a189950396305eea02d63bcafb1887dbfb

Merge pull request #877 from lazycoder9/fix/dstr_in_example_description RepeatedDescription detects not only string descriptions

view details

Benjamin Quorning

commit sha 29d75a307fca355e73ad7d855f6a22f404cac711

More RepeatedDescription and Example specs

view details

Benjamin Quorning

commit sha 655d031c1bd38401c0726a5998cc7b386048a09e

Bump version to 1.38.1

view details

Benjamin Quorning

commit sha d6f18f53092ebb6e2bcc9910834732e8c83fead1

Merge pull request #882 from rubocop-hq/release Bump version to 1.38.1

view details

Benjamin Quorning

commit sha be1dd98d6f08997c2d2c90da978b556c5926c0c4

Merge pull request #878 from rubocop-hq/remove-one Remove #one method

view details

Benjamin Quorning

commit sha 94d8084d91b274f26355184366be312e6751ff07

Merge pull request #881 from rubocop-hq/fix-dstr-in-example-description Extra specs for RepeatedDescription and Example

view details

push time in 15 days

issue commentrubocop-hq/rspec-style-guide

Use `before` and `let` when it's beneficial

@RobinDaugherty

However, people that use RSpec effectively understand how let-declared variables work and their precedence based on scope.

This is a little gatekeepy. I understand how let works--I've been using it for more than a decade at this point. I still think it creates confusing indirection in the tests and needless complexity.

The RSpec Style Guide should recommend the effective use of RSpec features, not avoid using them because they are unfamiliar to some developers.

Again, it's not about familiarity, it's about the complexity it creates. It's kind of condescending to imply that people who disagree with you just don't understand the feature.

pirj

comment created time in 15 days

push eventmockdeep/scripts

Robert Fletcher

commit sha 347eb3d510221a6664475b109da6bc7487b1b94e

more scripts!

view details

Robert Fletcher

commit sha 6aedca7aa12c2fa9d4c096d016f035fab3456081

add step to bump_branch script

view details

Robert Fletcher

commit sha 67f93a26cdac02fc7f1a50458440d458ee79f4ea

add script to bump dependencies

view details

Robert Fletcher

commit sha fc9623d0309e71817ef496b12d96cdbc58208b43

start script to replace propTypes with Props in React

view details

Robert Fletcher

commit sha fe16c021da971a5c0980cca2f12bb973e789063c

support props on React classes need to handle function components next.

view details

push time in 16 days

issue commentrubocop-hq/rubocop-rspec

Cop Idea: NoLet

Hmm, yeah, I guess that's true. I can try and set it up per-scope. I'll try to work on it this afternoon.

mockdeep

comment created time in 16 days

issue commentrubocop-hq/rubocop-rspec

Cop Idea: NoLet

@pirj sorry, I haven't had a chance to follow up on this. I think maybe it makes sense to count let calls in the entire file?

mockdeep

comment created time in 16 days

Pull request review commentrmagick/rmagick

Fix SEGV in rm_check_ary_len() with unexpected argument value

 Image_convolve_channel(int argc, VALUE *argv, VALUE self)         rb_raise(rb_eArgError, "order must be non-zero and positive");     } -    ary = argv[1];

@Watson1978 would it make sense to raise a ruby error here instead?

Watson1978

comment created time in 17 days

issue commentrmagick/rmagick

Annotating fails when '@' is first character

@Watson1978 could escape @ inside of RMagick for older versions of ImageMagick?

bf4

comment created time in 19 days

pull request commentrmagick/rmagick

Flesh out tests for Image#charcoal

@Watson1978 we decided to increase the delta for the tests that pass radius and sigma. I'm not sure we should disable hdri because I think we should test against what our users are most likely to be using. Because hdri is default enabled in 7.0, we should probably be testing that.

Le1gh

comment created time in 20 days

delete branch rmagick/rmagick

delete branch : rf-circle_again

delete time in 20 days

PR closed rmagick/rmagick

CI: reintroduce CircleCI

Github Actions has been very flaky, so this brings back CircleCI.

+223 -0

7 comments

1 changed file

mockdeep

pr closed time in 20 days

delete branch mockdeep/Rails-Template

delete branch : rf-bump_gems

delete time in 23 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha c4d15ebdaf55be7a4e2af742f61dea5920eb2803

Upgrades: bump minor gem versions (#358)

view details

push time in 23 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha bd50864f929c5135a0a6b51f7675b5d13de6c975

Upgrades: bump minor npm package versions (#357)

view details

Robert Fletcher

commit sha c8928f7137c64d13ae4256f3220e89e2f9fa37e5

Upgrades: bump minor gem versions

view details

push time in 23 days

delete branch mockdeep/Rails-Template

delete branch : rf-bump_yarn

delete time in 23 days

push eventmockdeep/Rails-Template

Robert Fletcher

commit sha bd50864f929c5135a0a6b51f7675b5d13de6c975

Upgrades: bump minor npm package versions (#357)

view details

push time in 23 days

create barnchmockdeep/Rails-Template

branch : rf-bump_gems

created branch time in 23 days

create barnchmockdeep/Rails-Template

branch : rf-bump_yarn

created branch time in 23 days

pull request commentrmagick/rmagick

Flesh out tests for Image#charcoal

@dlemstra can you help me understand why there is so much variability in output on different versions of ImageMagick? On IM version 6.9 charcoal produces pixel values like:

[55422, 55422, 55422, 49372, 49372, 49372, 9121, 9121, 9121, 53918, 53918, 53918]

and on 7.0 we get:

[55444, 55444, 55444, 49359, 49359, 49359, 9147, 9147, 9147, 53877, 53877, 53877]

It's not a huge deal, just curious.

Le1gh

comment created time in 24 days

more