profile
viewpoint
Mihai Maruseac mihaimaruseac Google Brain Mountain View, California, USA

google/haskell-trainings 1123

Haskell 101 and 102: slides and codelabs

mihaimaruseac/HsMaze 8

A robot trying to escape from a maze using GA

andrewbwm/DiceBot 4

Our little irc dice bot

mihaimaruseac/dphcar 4

Differentially Private High Confidence Association Rules

mihaimaruseac/HaCoTeB 4

This project is dead. It started disorganized and ended prematurely as it was expected due to a busy schedule and because I forgot some of the ideas from the start. Sorry. Transforms a textfile containing code and text into a HTML file, useful for blogging.

mihaimaruseac/id3 3

Small id3 classifier written for the Automatic Learning Course

mihaimaruseac/book-of-marks 2

Bookmark manager written in Haskell. Non-browser. Either GUI or cmdline. Linux/GTK only.

mihaimaruseac/FSFrame 2

A Frame System

mihaimaruseac/HsMinesweeper 2

A short multiagent game of Minesweeper. Homework for the Artificial Intelligence Course.

alexef/donatii.cs.pub.ro 1

Site-ul de donatii

push eventtensorflow/estimator

Thomas O'Malley

commit sha 6c2af1d8defac92e3b22d4d2f6290de8126ebf3f

Skip loss check in keras_test PiperOrigin-RevId: 296519516

view details

push time in a day

push eventtensorflow/estimator

Mihai Maruseac

commit sha 00e7a6f8f2b41f423264dafd831331958ede78f1

Estimator only releases py3 pips from now PiperOrigin-RevId: 296445036

view details

push time in a day

issue commenttensorflow/tensorflow

Make Tensorflow 2.1 available through conda

Closing per request

cossio

comment created time in a day

issue closedtensorflow/tensorflow

Make Tensorflow 2.1 available through conda

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
  • TensorFlow installed from (source or binary): conda
  • Python version: 3.7

Describe the problem

conda install tensorflow installs version 2.0 instead of 2.1. Please, make tensorflow 2.1 available through conda.

closed time in a day

cossio

pull request commenttensorflow/tensorflow

check if boxes have logical coordinates (different than a line or a p…

For the second question, please rebase against master.

For the first question, the compiler/test tests test various compilers to optimize models whereas the python tests are main TF tests.

MoussaMM

comment created time in a day

issue commenttensorflow/tensorboard

io_wrapper_test failing at head

I would recommend fixing forward in that case as the change is needed to allow TF to be tested on Windows (that is, rolling it back will break many more things).

Having globbing characters in a path, while allowed, is still a little bit iffy. But if we want to let users have this knob..

wchargin

comment created time in 2 days

issue commentpypa/pip

More verbose explanation why "Could not find a version that satisfies the requirement"

+1 on this. Right now I am getting the following:

ERROR: Could not find a version that satisfies the requirement tf-estimator-nightly==2.1.0.dev2020022102 (from versions: ..., 2.1.0.dev2020022102)
ERROR: No matching distribution found for tf-estimator-nightly==2.1.0.dev2020022102

As you see, the package already shows up in the versions listed

stdedos

comment created time in 2 days

pull request commenttensorflow/tensorflow

[S3] Skip using temp files/folders when writing to S3

I think it's because internally s3 does not exist. I'd suggest not having the test at all.

rahul003

comment created time in 2 days

push eventtensorflow/estimator

A. Unique TensorFlower

commit sha 6f0b3e760b89cb6618ce70c3053404378e3c2fe3

Fix the documentation for the return type of model export functions. PiperOrigin-RevId: 296307536

view details

push time in 2 days

pull request commenttensorflow/tensorflow

[S3] Skip using temp files/folders when writing to S3

This fails internally:

  File ".../third_party/tensorflow/python/lib/io/file_io_test.py", line 620, in testHasAtomicMove
    self.assertFalse(file_io.has_atomic_move("s3://x/y"))
  File "<embedded stdlib>/unittest/case.py", line 676, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false
rahul003

comment created time in 2 days

Pull request review commenttensorflow/tensorflow

NFC - minor spelling tweaks under core directory

 class MklReluOpBase : public OpKernel {       MklEltwiseFwdPrimitive<T>* eltwise_fwd =           MklEltwiseFwdPrimitiveFactory<T>::Get(fwdParams); +<<<<<<< HEAD

Merge conflict markers found in the file. Please fix.

kiszk

comment created time in 2 days

Pull request review commenttensorflow/tensorflow

[S3] Allow configuring AWS SDK's logging level

 class S3RandomAccessFile : public RandomAccessFile {    Status Read(uint64 offset, size_t n, StringPiece* result,               char* scratch) const override {+    VLOG(1) << "ReadFilefromS3 s3://" << bucket_ << "/" << object_ << " from " << offset << " for n:" << n;

Let's keep them both as they are

rahul003

comment created time in 2 days

pull request commenttensorflow/tensorflow

[S3] Adding retries for S3 file system operations

After review on GitHub, code is imported by Copybara into Google, integrated with local changes there and then there is another round of reviews internally. Once that passes, Copybara will try to submit the code, running internal and external tests again. If all are green, tensorflow-gardener will merge the PR, otherwise someone needs to comment on the PR to report issues or manually patch the imported change to fix internal tests.

See also https://github.com/tensorflow/tensorflow/issues/36527#issuecomment-583529777

rahul003

comment created time in 2 days

pull request commenttensorflow/tensorflow

[S3] Improving transfer to S3 for checkpoints, saved models, etc

Hmm, I still see osstringstream. Did you forget to push the next changes?

rahul003

comment created time in 2 days

Pull request review commenttensorflow/tensorflow

[S3] Improving transfer to S3 for checkpoints, saved models, etc

 class S3WritableFile : public WritableFile {     if (!sync_needed_) {       return Status::OK();     }-    Aws::S3::Model::PutObjectRequest putObjectRequest;-    putObjectRequest.WithBucket(bucket_.c_str()).WithKey(object_.c_str());     long offset = outfile_->tellp();-    outfile_->seekg(0);-    putObjectRequest.SetBody(outfile_);-    putObjectRequest.SetContentLength(offset);-    auto putObjectOutcome = this->s3_client_->PutObject(putObjectRequest);+    std::shared_ptr<Aws::Transfer::TransferHandle> handle = +      transfer_manager_.get()->UploadFile(+        outfile_, bucket_.c_str(), object_.c_str(),+        "application/octet-stream", Aws::Map<Aws::String, Aws::String>());+    handle->WaitUntilFinished();+    int retries = 0;+    while (handle->GetStatus() == Aws::Transfer::TransferStatus::FAILED &&+           retries++ < kUploadRetries) {+      // if multipart upload was used, only the failed parts will be re-sent+      VLOG(1) << "Retrying Upload of s3://" << bucket_ << "/" << object_

There should be some work to replace 0/1/2 with INFO/WARNING/ERROR to make these less unintuitive. I would prefer to use the names here but we can also merge this as it is and fix at a later time.

rahul003

comment created time in 2 days

startedchandlerc/spectre-mitigations

started time in 3 days

pull request commenttensorflow/tensorflow

Add converter for SparseSoftmaxCrossEntropyWithLogits

Internally the MLIR build succeeds. If this PR still fails then we'll have to dig deeper

rrkarim

comment created time in 3 days

pull request commenttensorflow/tensorflow

check if boxes have logical coordinates (different than a line or a p…

We should fix them: either expect the failure or change the coordinates. Let's do that in this PR too.

MoussaMM

comment created time in 3 days

pull request commenttensorflow/tensorflow

Add converter for SparseSoftmaxCrossEntropyWithLogits

Rebase again on master?

rrkarim

comment created time in 3 days

push eventtensorflow/estimator

Thomas O'Malley

commit sha 3c23022cd3a06d41e59f5dc1706ce9f3b42f49c2

Require subclass Models used in model_to_estimator to implement Model.get_config and Model.from_config PiperOrigin-RevId: 296052777

view details

push time in 3 days

Pull request review commenttensorflow/tensorflow

[S3] Improving transfer to S3 for checkpoints, saved models, etc

 Status S3FileSystem::GetFileSize(const string& fname, uint64* file_size) {   return Status::OK(); } +void S3FileSystem::MultiPartCopyCallback(const Aws::S3::Model::UploadPartCopyRequest& request,+                                         const Aws::S3::Model::UploadPartCopyOutcome& uploadPartCopyOutcome,+                                         const std::shared_ptr<const Aws::Client::AsyncCallerContext>& context) {++  std::shared_ptr<tensorflow::MultiPartCopyAsyncContext> multiPartContext =+  std::const_pointer_cast<tensorflow::MultiPartCopyAsyncContext>(std::static_pointer_cast<const tensorflow::MultiPartCopyAsyncContext>(context));++  {+    std::unique_lock <std::mutex> lock(*multiPartContext->multi_part_copy_mutex);++    Status status;+    if (uploadPartCopyOutcome.IsSuccess()) {+      // success+      Aws::String eTag = uploadPartCopyOutcome.GetResult().GetCopyPartResult().GetETag();+      multiPartContext->eTag = eTag;+      status = Status::OK();+    } else {+      LOG(ERROR) << "Error when copying part " << multiPartContext->partNumber << " " << uploadPartCopyOutcome.GetError().GetMessage();+      status = errors::Unknown(uploadPartCopyOutcome.GetError().GetExceptionName(), ": ",+                               uploadPartCopyOutcome.GetError().GetMessage());+    }++    (*multiPartContext->finishedPartStates)[multiPartContext->partNumber] = multiPartContext->incompletePartStates->at(multiPartContext->partNumber);+    multiPartContext->finishedPartStates->at(multiPartContext->partNumber).status = status;+    multiPartContext->incompletePartStates->erase(multiPartContext->partNumber);+    // Notify the thread that started the operation+    multiPartContext->multi_part_copy_cv->notify_one();+  }++}++Status S3FileSystem::CopyFile(const Aws::String& source_bucket, const Aws::String& source_key,+                              const Aws::String& target_bucket, const Aws::String& target_key) {+  Aws::String source = Aws::String((source_bucket + "/" + source_key).c_str());+  Aws::String source_full_path = Aws::String("s3://") + source;+  uint64 file_length;+  TF_RETURN_IF_ERROR(this->GetFileSize(std::string(source_full_path.c_str()), &file_length));+  int num_parts;+  if (file_length <= multi_part_copy_part_size_) {+    num_parts = 1;+  } else {+    num_parts = ceil((float) file_length / multi_part_copy_part_size_);+  }+  +  if (num_parts == 1) {+    return SimpleCopy(source, target_bucket, target_key);+  } else if (num_parts > 10000) {+    std::ostringstream s;

Let's use tensorflow::strings::StrCat instead of std::ostringstream

rahul003

comment created time in 3 days

Pull request review commenttensorflow/tensorflow

[S3] Improving transfer to S3 for checkpoints, saved models, etc

 class AWSSha256OpenSSLImpl : public Aws::Utils::Crypto::Hash {   } }; +class AWSSecureRandomBytesImpl : public Aws::Utils::Crypto::SecureRandomBytes {+public:+  AWSSecureRandomBytesImpl() {}+  virtual ~AWSSecureRandomBytesImpl() = default;+  virtual void GetBytes(unsigned char* buffer, size_t bufferSize) override {+    assert(buffer);

I'm concerned about this assert here. We have some policy to not add asserts/CHECKs into code unless really needed. But let's keep this as it is now and see how the internal review goes.

rahul003

comment created time in 3 days

Pull request review commenttensorflow/tensorflow

[S3] Improving transfer to S3 for checkpoints, saved models, etc

 class S3WritableFile : public WritableFile {     if (!sync_needed_) {       return Status::OK();     }-    Aws::S3::Model::PutObjectRequest putObjectRequest;-    putObjectRequest.WithBucket(bucket_.c_str()).WithKey(object_.c_str());     long offset = outfile_->tellp();-    outfile_->seekg(0);-    putObjectRequest.SetBody(outfile_);-    putObjectRequest.SetContentLength(offset);-    auto putObjectOutcome = this->s3_client_->PutObject(putObjectRequest);+    std::shared_ptr<Aws::Transfer::TransferHandle> handle = +      transfer_manager_.get()->UploadFile(+        outfile_, bucket_.c_str(), object_.c_str(),+        "application/octet-stream", Aws::Map<Aws::String, Aws::String>());+    handle->WaitUntilFinished();+    int retries = 0;+    while (handle->GetStatus() == Aws::Transfer::TransferStatus::FAILED &&+           retries++ < kUploadRetries) {+      // if multipart upload was used, only the failed parts will be re-sent+      VLOG(1) << "Retrying Upload of s3://" << bucket_ << "/" << object_

Let's use a constant instead of 1 in VLOG

rahul003

comment created time in 3 days

Pull request review commenttensorflow/tensorflow

[S3] Improving transfer to S3 for checkpoints, saved models, etc

 class S3WritableFile : public WritableFile {     if (!sync_needed_) {       return Status::OK();     }-    Aws::S3::Model::PutObjectRequest putObjectRequest;-    putObjectRequest.WithBucket(bucket_.c_str()).WithKey(object_.c_str());     long offset = outfile_->tellp();-    outfile_->seekg(0);-    putObjectRequest.SetBody(outfile_);-    putObjectRequest.SetContentLength(offset);-    auto putObjectOutcome = this->s3_client_->PutObject(putObjectRequest);+    std::shared_ptr<Aws::Transfer::TransferHandle> handle = +      transfer_manager_.get()->UploadFile(+        outfile_, bucket_.c_str(), object_.c_str(),+        "application/octet-stream", Aws::Map<Aws::String, Aws::String>());+    handle->WaitUntilFinished();+    int retries = 0;+    while (handle->GetStatus() == Aws::Transfer::TransferStatus::FAILED &&+           retries++ < kUploadRetries) {+      // if multipart upload was used, only the failed parts will be re-sent+      VLOG(1) << "Retrying Upload of s3://" << bucket_ << "/" << object_+              << " after failure. Current retry count:" << retries;+      transfer_manager_.get()->RetryUpload(outfile_, handle);+      handle->WaitUntilFinished();+    }+    if (handle->GetStatus() != Aws::Transfer::TransferStatus::COMPLETED) {

Let's add an extra empty line above this one

rahul003

comment created time in 3 days

pull request commenttensorflow/tensorflow

Add converter for SparseSoftmaxCrossEntropyWithLogits

Once conflicts are removed we should review and approve again. I think MLIR failures are fixed for now.

rrkarim

comment created time in 3 days

pull request commenttensorflow/tensorflow

[S3] Improving transfer to S3 for checkpoints, saved models, etc

Let me come to this one around the weekend

rahul003

comment created time in 3 days

Pull request review commenttensorflow/tensorflow

[S3] Allow configuring AWS SDK's logging level

 class S3RandomAccessFile : public RandomAccessFile {    Status Read(uint64 offset, size_t n, StringPiece* result,               char* scratch) const override {+    VLOG(1) << "ReadFilefromS3 s3://" << bucket_ << "/" << object_ << " from " << offset << " for n:" << n;

Instead of 1 we should use one of the constants to make this readable

rahul003

comment created time in 3 days

pull request commenttensorflow/tensorflow

[S3] Improving transfer to S3 for checkpoints, saved models, etc

Can you solve conflicts please? Apologies for missing the review before, it slipped through notifications.

rahul003

comment created time in 3 days

issue commenttensorflow/tensorflow

Update grpc dependency for glibc 2.30 compatibility

Apologies for the long delay. We got this fixed now, I think (not my work, but of a concurrent contributor)

m01

comment created time in 4 days

issue commenttensorflow/tensorflow

ModuleNotFoundError: No module named 'tensorflow_core.python'

As said, switching to 1.14 was a terrible advice.

mshmsh1234

comment created time in 4 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def reduce_max(input_tensor, axis=None, keepdims=False, name=None):    If `axis` is None, all dimensions are reduced, and a   tensor with a single element is returned.+  +  For example:+  >>> tf.math.reduce_max(tf.constant([32.0, 36.0]), axis=None, keepdims=True)

Empty line not added.

anigasan

comment created time in 4 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def matmul(a,          [139, 154]], dtype=int32)>    A batch matrix multiplication with batch shape [2]:-+  

Trailing whitespace. Please configure your editor/IDE to trim whitespaces on save.

anigasan

comment created time in 4 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def _mul(x, y, name=None): @tf_export("math.subtract", "subtract") @dispatch.add_dispatch_support def subtract(x, y, name=None):+  """Returns 'x' - 'y' element wise.+  +  For example:+  +  >>> x = tf.constant([32])+  >>> y = tf.constant([34])+  >>> tf.math.subtract(x, y)+  <tf.Tensor: shape=(1,), dtype=float32, numpy=array([-2.], dtype=float32)>+  +  Args:+    'x': A 'Tensor'. Must be one of the following types:+    'bfloat16', 'half', 'float32', 'float64',+    'uint8', 'int8', 'uint16', 'int16',+    'int32', 'int64', 'complex64', 'complex128'.+    'y': A 'Tensor'. Must have the same type as 'x'+    'name': A name for the operation (optional)+  +  Returns:+  A 'Tensor'. Has same type as 'x'.

Please indent this line

anigasan

comment created time in 4 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def reduce_min_v1(input_tensor,    If `axis` is None, all dimensions are reduced, and a   tensor with a single element is returned.-+  

Trailing whitespace not removed.

Screenshot from 2020-02-18 09-52-11

anigasan

comment created time in 4 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def sigmoid(x, name=None):   If a negative number is large, its sigmoid will approach to 0 since the   formula will be `y = 1 / (1 + <large_num>)` +  Specifically, `y = 1 / (1 + exp(-x))`.+  +  For example:

Missing empty line

anigasan

comment created time in 4 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def angle(input, name=None):    For example: -  ```-  input = tf.constant([-2.25 + 4.75j, 3.25 + 5.75j], dtype=tf.complex64)-  tf.math.angle(input).numpy()-  # ==> array([2.0131705, 1.056345 ], dtype=float32)-  ```+  >>> input = tf.constant([-2.25 + 4.75j, 3.25 + 5.75j], dtype=tf.complex64)

I would recommend using tf.constant([-1 + j, 2 + 2j], dtype=tf.complex64) instead as the angles (+/- 45 degrees) are easier to recognize. Plus, then the line won't be extremely long.

anigasan

comment created time in 4 days

issue commenttensorflow/tensorflow

MKL no longer works with tensorflow 1.15

The build scripts are in the branch now. They weren't before we started the patch process release.

pavanky

comment created time in 4 days

issue commenttensorflow/tensorflow

Loading Tensorflow models from disk is instant while loading from gcs is very slow

Thanks. I'll get a look into this, though not this week or the next (loaded with other work items).

Sam-Persoon

comment created time in 4 days

issue commenttensorflow/tensorflow

Installation of tensorflow 2.0 cpu on windows 10 not working

Conda built from source whereas pip used a prebuilt binary.

Building from source allows you to get working pip even if your CPU does not support AVX

If conda didn't built from source, someone else did a built for conda.

tessy1234

comment created time in 4 days

issue commentcommercialhaskell/stackage

polysemy out of bounds for co-log-polysemy

Can you please send a PR to change the relevant lines in build_constraints.yaml please? The message is printed by tooling reading the data from that file.

mihaimaruseac

comment created time in 4 days

push eventcommercialhaskell/stackage

Leonhard Markert

commit sha 168e3c4b1224e97b81be6cbd702ef4b3c766215a

add monad-bayes

view details

push time in 4 days

PR merged commercialhaskell/stackage

Add monad-bayes

Checklist:

  • [x] Meaningful commit message, eg add my-cool-package (please not mention build-constraints.yml)

  • [x] At least 30 minutes have passed since uploading to Hackage

  • [x] On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, and $version with the version of the package you want to get into Stackage):

    stack unpack $package-$version  # $version is optional
    stack init --resolver nightly
    stack build --resolver nightly --haddock --test --bench --no-run-benchmarks
    
+3 -0

0 comment

1 changed file

curiousleo

pr closed time in 4 days

issue commenttensorflow/tensorflow

MKL no longer works with tensorflow 1.15

@jingxu10 Yes, I know that. But I'm asking because the build process changed between the 1.15.0 and 1.15.2 and wanted to make sure this issue is not because of that.

pavanky

comment created time in 4 days

issue commenttensorflow/tensorflow

ModuleNotFoundError: No module named 'tensorflow_core.python'

Please also say how the issue got fixed so other people searching for their issue and reaching here can use the same fix if their issue is similar.

mshmsh1234

comment created time in 4 days

issue commenttensorflow/tensorflow

ModuleNotFoundError: No module named 'tensorflow_core.keras' in Flask

The recommended way to prevent this is to:

  1. install using python -m pip install ...
  2. check using python -m pip list

Or, to use virtualenvs or similar.

zzeniale

comment created time in 4 days

PR closed tensorflow/tensorflow

#36693 Update mnist_with_summaries.py cla: yes

Spelling of Placeholders at line 53 solved

Issue : #36693

+1 -1

1 comment

1 changed file

ayushmankumar7

pr closed time in 4 days

pull request commenttensorflow/tensorflow

#36693 Update mnist_with_summaries.py

closing as it is not against master branch.

ayushmankumar7

comment created time in 4 days

push eventcommercialhaskell/stackage

Leonhard Markert

commit sha ca7a4f4d4cc133720b343fd7c0a1f3a54df855ff

Update build instructions ... to bring them closer to what's described in MAINTAINERS.md. In particular, the `cd` and `rm -f stack.yaml` steps were missing.

view details

push time in 4 days

PR merged commercialhaskell/stackage

Update build instructions

... to bring them closer to what's described in MAINTAINERS.md.

In particular, the cd and rm -f stack.yaml steps were missing.

+2 -1

0 comment

1 changed file

curiousleo

pr closed time in 4 days

push eventcommercialhaskell/stackage

Mihai Maruseac

commit sha 4f510bb8f13c9d000a47d1f974c0f0a7918b683e

Upper bounds for newest issues (#5181, #5182, #5183)

view details

push time in 6 days

push eventcommercialhaskell/stackage

Mihai Maruseac

commit sha d71dd8834033adc0822fe0553148b4ad9c260a2c

Upper bounds for newest issues (#5181, #5182, #5183)

view details

push time in 6 days

issue openedcommercialhaskell/stackage

polysemy out of bounds for co-log-polysemy

polysemy-1.3.0.0 (changelog) (Sandy Maguire sandy@sandymaguire.me @isovector) is out of bounds for:

  • [ ] co-log-polysemy-0.0.1.0 (^>=1.2.0.0). Kowainik xrom.xkov@gmail.com @chshersh @vrom911. @kowainik. Used by: library

created time in 6 days

issue openedcommercialhaskell/stackage

lens-family and lens-family-core out of bounds

lens-family-2.1.0 (changelog) (Michael Thompson what_is_it_to_do_anything@yahoo.com @michaelt) is out of bounds for:

  • [ ] proto-lens-0.6.0.0 (>=1.2 && < 2.1). Judah Jacobson judah.jacobson@gmail.com @judah. @google. Used by: library
  • [ ] proto-lens-arbitrary-0.1.2.8 (>=1.2 && < 2.1). Judah Jacobson judah.jacobson@gmail.com @judah. @google. Used by: library
  • [ ] proto-lens-protobuf-types-0.6.0.0 (>=1.2 && < 2.1). Judah Jacobson judah.jacobson@gmail.com @judah. @google. Used by: library
  • [ ] proto-lens-protoc-0.6.0.0 (>=1.2 && < 2.1). Judah Jacobson judah.jacobson@gmail.com @judah. @google. Used by: executable
  • [ ] proto-lens-runtime-0.6.0.0 (>=1.2 && < 2.1). Judah Jacobson judah.jacobson@gmail.com @judah. @google. Used by: library

lens-family-core-2.1.0 (changelog) (Michael Thompson what_is_it_to_do_anything@yahoo.com @michaelt) is out of bounds for:

  • [ ] dhall-1.30.0 (>=1.0.0 && < 2.1). Gabriel Gonzalez Gabriel439@gmail.com @Gabriel439. @dhall-lang. Used by: library
  • [ ] pipes-group-1.0.12 (< 2.1). Grandfathered dependencies. @Gabriel439. Used by: test-suite

created time in 6 days

issue openedcommercialhaskell/stackage

doclayout out of bounds for pandoc 2.9.2

doclayout-0.2.0.1 (changelog) (John MacFarlane jgm@berkeley.edu @jgm) is out of bounds for:

  • [ ] pandoc-2.9.2 (>=0.3 && < 0.4). John MacFarlane jgm@berkeley.edu @jgm. @jgm. Used by: library

created time in 6 days

issue openedcommercialhaskell/lts-haskell

Constraints for LTS15.0

  1. genvalidity-hspec will be added with tests disabled (CC @NorfairKing)
      src/Test/Validity/Shrinking.hs:56:9: 
      1) Test.Validity.Shrinking, shrinkValid :: (Ratio Int8 -> [Ratio Int8]), preserves validity
           uncaught exception: ArithException
           arithmetic overflow
           (after 9 tests)
             (-128) % 77
    
      To rerun use: --match "/Test.Validity.Shrinking/shrinkValid :: (Ratio Int8 -> [Ratio Int8])/preserves validity/"
    
      src/Test/Validity/Shrinking.hs:58:9: 
      2) Test.Validity.Shrinking, shrinkValid :: (Ratio Int8 -> [Ratio Int8]), never shrinks to itself for valid values
           uncaught exception: ArithException
           arithmetic overflow
           (after 9 tests)
             (-128) % 77
    
      To rerun use: --match "/Test.Validity.Shrinking/shrinkValid :: (Ratio Int8 -> [Ratio Int8])/never shrinks to itself for valid values/"
    
    Randomized with seed 154193365
    
    Finished in 2.1746 seconds
    285 examples, 2 failures

  1. egison included with benchmarks disabled (CC @egisatoshi)

```    /var/stackage/work/unpack-dir/unpacked/egison-3.10.2-de257e11f4a0a9bdd6bf314893b6a0277dd64ac38429ef94c902c7b89b572f5d/benchmark/Benchmark.hs:12:33: error:
        Variable not in scope:
          defaultOption :: Language.Egison.CmdOptions.EgisonOpts
       |
    12 | runEgisonFile path = initialEnv defaultOption >>= flip (loadEgisonFile defaultOption) path >> return ()
       |                                 ^^^^^^^^^^^^^
    
    /var/stackage/work/unpack-dir/unpacked/egison-3.10.2-de257e11f4a0a9bdd6bf314893b6a0277dd64ac38429ef94c902c7b89b572f5d/benchmark/Benchmark.hs:12:72: error:
        Variable not in scope:
          defaultOption :: Language.Egison.CmdOptions.EgisonOpts
       |
    12 | runEgisonFile path = initialEnv defaultOption >>= flip (loadEgisonFile defaultOption) path >> return ()
       |                                                                        ^^^^^^^^^^^^^

also, tests are marked as failing:

io and do expression
io and do expression without newline
:nons-test/test/syntax.egi: [OK]
:nons-test/test/primitive.egi: [OK]
:nons-test/test/lib/core/base.egi: [OK]
:nons-test/test/lib/core/order.egi: [OK]
:nons-sample/math/geometry/curvature-form.egi: [Failed]
Error: file does not exist: nons-sample/math/geometry/curvature-form.egi
:nons-sample/math/geometry/hodge-laplacian-polar.egi: [Failed]
Error: file does not exist: nons-sample/math/geometry/hodge-laplacian-polar.egi
:test/syntax.egi: [OK]
:test/primitive.egi: [OK]
:test/lib/math/analysis.egi: [OK]
:test/lib/math/tensor.egi: [OK]
:test/lib/math/arithmetic.egi: [OK]
:test/lib/math/algebra.egi: [OK]
:test/lib/core/string.egi: [OK]
:test/lib/core/base.egi: [OK]
:test/lib/core/collection.egi: [OK]
:test/lib/core/order.egi: [OK]
:test/lib/core/number.egi: [OK]
:sample/poker-hands.egi: [OK]
:sample/poker-hands-with-joker.egi: [OK]
:sample/mahjong.egi: [OK]
:sample/primes.egi: [OK]
:sample/sat/cdcl.egi: [Failed]
Error: file does not exist: sample/sat/cdcl.egi
:sample/math/number/17th-root-of-unity.egi: [OK]
:sample/math/geometry/riemann-curvature-tensor-of-S2.egi: [OK]
:sample/math/geometry/riemann-curvature-tensor-of-T2.egi: [OK]
:sample/math/geometry/curvature-form.egi: [OK]
:sample/math/geometry/hodge-laplacian-polar.egi: [OK]

         Test Cases   Total       
 Passed  24           24          
 Failed  3            3           
 Total   27           27

created time in 6 days

pull request commentcommercialhaskell/stackage

bump domenkozar packages

This looks still like a draft?

domenkozar

comment created time in 6 days

delete branch commercialhaskell/stackage

delete branch : curator-update

delete time in 6 days

issue closedcommercialhaskell/lts-haskell

add HaXml-1.25.5 and haxr-3000.11.4 to LTS 14

Checklist for adding a package:

  • [x] specified the Stackage LTS version in the summary

  • [x] On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, $version with the version of the package you want to get into the LTS series, and $lts with the desired LTS series):

    stack unpack $package-$version
    cd $package-$version
    stack init --resolver lts-$lts
    stack build --haddock --test --bench --no-run-benchmarks
    
  • [x] You're using the latest version of Stack. (Otherwise please try running stack upgrade and re-running your commands. If that fails, please include the output of stack --version in this issue.)

closed time in 7 days

juhp

issue commentcommercialhaskell/lts-haskell

add HaXml-1.25.5 and haxr-3000.11.4 to LTS 14

Both packages included in both LTS-14.26 and LTS-14.27

juhp

comment created time in 7 days

issue closedcommercialhaskell/lts-haskell

Solve the random removal of PyF from lts

I'd like to get PyF back in the lts 14 (14.24 if possible).

PyF was added in #241 to 14.5, then again in #254 for 14.12 and removed again since lts-14.13 and added again in 14.18 and it disappeared again in 14.19.

Is there something I can do to ensure PyF stays in each lts? I don't understand the reasons why it is removed and I receive no notification (either mail / github) for the removal.

Checklist for adding a package:

  • [X] specified the Stackage LTS version in the summary

  • [X] On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, $version with the version of the package you want to get into the LTS series, and $lts with the desired LTS series):

    stack unpack $package-$version
    cd $package-$version
    stack init --resolver lts-$lts
    stack build --haddock --test --bench --no-run-benchmarks
    
  • [X] You're using the latest version of Stack. (Otherwise please try running stack upgrade and re-running your commands. If that fails, please include the output of stack --version in this issue.)

closed time in 7 days

guibou

issue commentcommercialhaskell/lts-haskell

Solve the random removal of PyF from lts

PyF included in both LTS-14.26 and LTS-14.27

I think the issue with the random removal is fully solved now.

guibou

comment created time in 7 days

issue closedcommercialhaskell/lts-haskell

[LTS14] Add bz2 to stackage lts-14

Checklist for adding a package:

  • [x] specified the Stackage LTS version in the summary

  • [x] On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, $version with the version of the package you want to get into the LTS series, and $lts with the desired LTS series):

    stack unpack $package-$version
    cd $package-$version
    stack init --resolver lts-$lts
    stack build --haddock --test --bench --no-run-benchmarks
    
  • [x] You're using the latest version of Stack. (Otherwise please try running stack upgrade and re-running your commands. If that fails, please include the output of stack --version in this issue.)

Thanks!

closed time in 7 days

vmchale

issue commentcommercialhaskell/lts-haskell

[LTS14] Add bz2 to stackage lts-14

bz2 included in both LTS-14.26 and LTS-14.27

vmchale

comment created time in 7 days

delete branch commercialhaskell/stackage

delete branch : reenable-yesod

delete time in 7 days

create barnchcommercialhaskell/stackage

branch : lts15

created branch time in 7 days

delete branch commercialhaskell/stackage

delete branch : enable-stylish

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : unordered-containers

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : unblock-hpack

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : reenable-stack

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : yesod-core-passes-again

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : 4215-add-back-mega-sdist

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : unblock-stack

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : jkachmar/reenable-wave

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : restore-persistent

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : revert-3975-patch-1

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : leptonyu-AddSalak

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : all-packages-explicit

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : revert-3465-master

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : re-enable-validity

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : readd-tasty-tap

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : revert-2839-revert-2835-patch-9

delete time in 7 days

delete branch commercialhaskell/stackage

delete branch : add-compact

delete time in 7 days

PR opened commercialhaskell/stackage

Reviewers
Update `CURATOR.md` to the current state

For LTS releases

+6 -6

0 comment

1 changed file

pr created time in 7 days

create barnchcommercialhaskell/stackage

branch : curator-update

created branch time in 7 days

issue closedcommercialhaskell/stackage

cursor-fuzzy-time-0.0.0.0 build failure

    Configuring cursor-fuzzy-time-0.0.0.0...
    Preprocessing library for cursor-fuzzy-time-0.0.0.0..
    Building library for cursor-fuzzy-time-0.0.0.0..
    [1 of 4] Compiling Cursor.FuzzyDay
    
    /var/stackage/work/unpack-dir/unpacked/cursor-fuzzy-time-0.0.0.0-627fece1913fd3ea7a85e2a20d721e56900e893b4b29bef147c7b14d5dfda93d/src/Cursor/FuzzyDay.hs:35:10: error:
        • No instance for (NFData TextCursor)
            arising from a use of ‘Control.DeepSeq.$dmrnf’
        • In the expression: Control.DeepSeq.$dmrnf @(FuzzyDayCursor)
          In an equation for ‘rnf’:
              rnf = Control.DeepSeq.$dmrnf @(FuzzyDayCursor)
          In the instance declaration for ‘NFData FuzzyDayCursor’
       |
    35 | instance NFData FuzzyDayCursor
       |          ^^^^^^^^^^^^^^^^^^^^^

CC @NorfairKing

closed time in 7 days

mihaimaruseac

issue commentcommercialhaskell/stackage

cursor-fuzzy-time-0.0.0.0 build failure

All good now. Thank you

mihaimaruseac

comment created time in 7 days

issue closedcommercialhaskell/lts-haskell

Dropped packages in lts 14.23

The store package has some kind of weird interaction in its TH deriving code with vector 0.12.1.2. Since store doesn't have many reverse dependencies, I decided to drop it instead of holding back vector. This also resulted in dropping mpi-hs.

CC @eschnett

closed time in 7 days

snoyberg

issue closedcommercialhaskell/lts-haskell

Constraints used for lts-14.22

This issue just records the constraints needed when building lts-14.22. No particular direct action is required, this is just largely informational.

  • selda-postgresql < 0.1.8.1

  • selda-sqlite < 0.1.7.1

  • servant-docs < 0.11.5

  • servant-foreign < 0.15.1

  • servant-lucid < 0.9.0.1

  • servant-mock < 0.8.6

  • servant-swagger < 1.1.8

closed time in 7 days

juhp

push eventcommercialhaskell/stackage

Mihai Maruseac

commit sha 0485f7dad5822ccec503871de497cfaef37f14ef

Enable `cursor-fuzzy-time` (#5171)

view details

push time in 7 days

issue closedcommercialhaskell/stackage

egison test suite failing

@egisatoshi we are seeing the egison test suite failing with the following diagnostics. The package remains on nightly but we have marked it as expected-test-failures.

:nons-test/test/syntax.egi: [Failed]
Error: file does not exist: nons-test/test/syntax.egi
:nons-test/test/primitive.egi: [Failed]
Error: file does not exist: nons-test/test/primitive.egi
:nons-test/test/lib/core/base.egi: [Failed]
Error: file does not exist: nons-test/test/lib/core/base.egi
:nons-test/test/lib/core/order.egi: [Failed]
Error: file does not exist: nons-test/test/lib/core/order.egi
:test/syntax.egi: [Failed]
Error: file does not exist: test/syntax.egi
:test/primitive.egi: [Failed]
Error: file does not exist: test/primitive.egi
:test/lib/math/analysis.egi: [Failed]
Error: file does not exist: test/lib/math/analysis.egi
:test/lib/math/tensor.egi: [Failed]
Error: file does not exist: test/lib/math/tensor.egi
:test/lib/math/arithmetic.egi: [Failed]
Error: file does not exist: test/lib/math/arithmetic.egi
:test/lib/math/algebra.egi: [Failed]
Error: file does not exist: test/lib/math/algebra.egi
:test/lib/core/string.egi: [Failed]
Error: file does not exist: test/lib/core/string.egi
:test/lib/core/base.egi: [Failed]
Error: file does not exist: test/lib/core/base.egi
:test/lib/core/collection.egi: [Failed]
Error: file does not exist: test/lib/core/collection.egi
:test/lib/core/order.egi: [Failed]
Error: file does not exist: test/lib/core/order.egi
:test/lib/core/number.egi: [Failed]
Error: file does not exist: test/lib/core/number.egi
:test/answer/sample/poker-hands-with-joker.egi: [Failed]
ERROR: test/answer/sample/poker-hands-with-joker.egi: openFile: does not exist (No such file or directory)
:test/answer/sample/primes.egi: [Failed]
ERROR: test/answer/sample/primes.egi: openFile: does not exist (No such file or directory)
:test/answer/sample/mahjong.egi: [Failed]
ERROR: test/answer/sample/mahjong.egi: openFile: does not exist (No such file or directory)
:test/answer/sample/poker-hands.egi: [Failed]
ERROR: test/answer/sample/poker-hands.egi: openFile: does not exist (No such file or directory)
:test/answer/sample/math/geometry/riemann-curvature-tensor-of-S2.egi: [Failed]
ERROR: test/answer/sample/math/geometry/riemann-curvature-tensor-of-S2.egi: openFile: does not exist (No such file or directory)
:test/answer/sample/math/number/17th-root-of-unity.egi: [Failed]
ERROR: test/answer/sample/math/number/17th-root-of-unity.egi: openFile: does not exist (No such file or directory)

closed time in 7 days

cdornan

issue commentcommercialhaskell/stackage

egison test suite failing

This works now

cdornan

comment created time in 7 days

Pull request review commenttensorflow/tensorflow

[S3] Skip using temp files/folders when writing to S3

 BundleWriter::BundleWriter(Env* env, StringPiece prefix, const Options& options)     : env_(env),       options_(options),       prefix_(prefix),-      tmp_metadata_path_(strings::StrCat(MetaFilename(prefix_), ".tempstate",-                                         random::New64())),-      tmp_data_path_(strings::StrCat(DataFilename(prefix_, 0, 1), ".tempstate",-                                     random::New64())),       out_(nullptr),       size_(0) {+  env_->HasAtomicMove(prefix_, &use_temp_file_);

This results in an error under strict checking:

tensorflow/core/util/tensor_bundle/tensor_bundle.cc:406:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
  env_->HasAtomicMove(prefix_, &use_temp_file_);
  ^~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~

Please fix.

rahul003

comment created time in 8 days

pull request commenttensorflow/tensorflow

[S3] Skip using temp files/folders when writing to S3

I think so, it just needs to pass internal tests now.

rahul003

comment created time in 8 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def _neg(x, name=None):   # pylint: enable=g-docstring-has-escape-- @tf_export(v1=["math.scalar_mul", "scalar_mul"]) def scalar_mul(scalar, x, name=None):   """Multiplies a scalar times a `Tensor` or `IndexedSlices` object.    Intended for use in gradient code which might deal with `IndexedSlices`   objects, which are easy to multiply by a scalar but more expensive to   multiply with arbitrary tensors.+  +  For example:+  >>> tf.math.scalar_mul(32, tf.constant([34,35]))

Empty line before the doctest starts

anigasan

comment created time in 8 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def reduce_sum(input_tensor, axis=None, keepdims=False, name=None):   tensor with a single element is returned.    For example:--  ```python-  x = tf.constant([[1, 1, 1], [1, 1, 1]])-  tf.reduce_sum(x)  # 6-  tf.reduce_sum(x, 0)  # [2, 2, 2]-  tf.reduce_sum(x, 1)  # [3, 3]-  tf.reduce_sum(x, 1, keepdims=True)  # [[3], [3]]-  tf.reduce_sum(x, [0, 1])  # 6-  ```-+  >>> x = tf.constant([[1, 1, 1], [1, 1, 1]])

Should also have an empty line before it starts

anigasan

comment created time in 8 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def floordiv(x, y, name=None):    `x` and `y` must have the same type, and the result will have the same type   as well.+  +  For example:+  >>> x = 32.0

And here

anigasan

comment created time in 8 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def div_no_nan(x, y, name=None): @dispatch.add_dispatch_support def multiply_no_nan(x, y, name=None):   """Computes the product of x and y and returns 0 if the y is zero, even if x is NaN or infinite.+  +  For example:+  >>> x = tf.constant(float('nan'))

And here

anigasan

comment created time in 8 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def equal(x, y, name=None):   boolean values.    For example:-+  

Trailing whitespace not removed

anigasan

comment created time in 8 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def reduce_sum_v1(input_tensor,   tensor with a single element is returned.    For example:--  ```python-  x = tf.constant([[1, 1, 1], [1, 1, 1]])-  tf.reduce_sum(x)  # 6-  tf.reduce_sum(x, 0)  # [2, 2, 2]-  tf.reduce_sum(x, 1)  # [3, 3]-  tf.reduce_sum(x, 1, keepdims=True)  # [[3], [3]]-  tf.reduce_sum(x, [0, 1])  # 6-  ```-+  +  >>> x = tf.constant([[1, 1, 1], [1, 1, 1]])+  >>> tf.reduce_sum(x)+  <tf.Tensor: shape=(), dtype=int32, numpy=6>+  >>> tf.reduce_sum(x, 0)+  <tf.Tensor: shape=(3,), dtype=int32, numpy=array([2, 2, 2], dtype=int32)>+  >>> tf.reduce_sum(x, 1)+  <tf.Tensor: shape=(2,), dtype=int32, numpy=array([3, 3], dtype=int32)>+  >>> tf.reduce_sum(x, 1, keepdims=True)+  <tf.Tensor: shape=(2, 1), dtype=int32, numpy=+  array([[3],+       [3]], dtype=int32)>+  >>> tf.reduce_sum(x, [0, 1])+  <tf.Tensor: shape=(), dtype=int32, numpy=6>+  

This example should be after documenting Args: and Returns:

anigasan

comment created time in 8 days

Pull request review commenttensorflow/tensorflow

Update math_ops.py with additional usage examples

 def _mul(x, y, name=None): @tf_export("math.subtract", "subtract") @dispatch.add_dispatch_support def subtract(x, y, name=None):+  """Returns 'x' - 'y' element wise+  +  For example:+  >>> x = tf.constant([32])

Not solved yet.

anigasan

comment created time in 8 days

more