profile
viewpoint

michaelpaul/nand2tetris 2

My projects for the course at www.nand2tetris.org.

michaelpaul/dotfiles 1

Meus arquivos de configuração.

michaelpaul/layoutside 1

An HTML/CSS grid builder and editor

michaelpaul/adyen-magento2 0

Adyen Payment plugin for Magento2

michaelpaul/awesome-compose 0

Awesome Docker Compose samples

michaelpaul/chat50-server 0

A Python chat server for my CS50 final project.

michaelpaul/chat50-ui 0

Chat User Interface for my CS50 final project.

michaelpaul/docker-sandbox 0

Dockerfile for testing packages, builds, etc.

create barnchAdyen/adyen-magento2

branch : PW-6160-v8

created branch time in a day

PR closed Adyen/adyen-magento2

Reviewers
[PW-6160] Use restore quote instead of cloning

<!-- Thank you for considering contributing to this repository! We encourage you to use PSR-2. -->

Description <!-- Please provide a description of the changes proposed in the Pull Request -->

The clone quote feature was used during error handling to restore a shopper cart. The same behavior can be achieved by using \Magento\Checkout\Model\Session::restoreQuote.

Tested scenarios <!-- Description of tested scenarios --> <!-- Please verify that the unit tests are passing by running "vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist vendor/adyen/module-payment/Test/" -->

  • Cards basic, 3DS1, and 3DS2
  • iDeal
  • PayPal
  • Donation
  • Multibanco
+51 -122

1 comment

1 changed file

michaelpaul

pr closed time in a day

PR opened Adyen/adyen-magento2

[PW-6160] Check order ownership

<!-- Thank you for considering contributing to this repository! We encourage you to use PSR-2. -->

Description <!-- Please provide a description of the changes proposed in the Pull Request -->

Check order ownership on redirect flows.

Tested scenarios <!-- Description of tested scenarios --> <!-- Please verify that the unit tests are passing by running "vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist vendor/adyen/module-payment/Test/" -->

  • iDeal
  • Multi-Shipping 3DS1
+23 -1

0 comment

1 changed file

pr created time in a day

create barnchAdyen/adyen-magento2

branch : PW-6160-v7-ms

created branch time in a day

PullRequestReviewEvent

PR opened Adyen/adyen-magento2

[PW-6160] Use restore quote instead of cloning

<!-- Thank you for considering contributing to this repository! We encourage you to use PSR-2. -->

Description <!-- Please provide a description of the changes proposed in the Pull Request -->

The clone quote feature was used during error handling to restore a shopper cart. The same behavior can be achieved by using \Magento\Checkout\Model\Session::restoreQuote.

Tested scenarios <!-- Description of tested scenarios --> <!-- Please verify that the unit tests are passing by running "vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist vendor/adyen/module-payment/Test/" -->

  • Cards basic, 3DS1, and 3DS2
  • iDeal
  • PayPal
  • Donation
  • Multibanco
+51 -122

0 comment

1 changed file

pr created time in a day

create barnchAdyen/adyen-magento2

branch : PW-6160

created branch time in a day

PullRequestReviewEvent

pull request commentAdyen/adyen-magento2

[PW-5724] Refactor Cron and use webhook module

I think we should keep our business logic in model classes instead of a "helper" class. We could create a new folder say Model/Webhook and break Helper/Webhook.php into smaller pieces inside of that folder. These classes may be more testable, so adding some basic unit tests would be a nice extra.

peterojo

comment created time in 3 days

pull request commentAdyen/adyen-magento2

[PW-5815]Handle declined flow

Since placeRedirectOrder became async, don't we also need to update this call?

What about the multi-shipping scenario in this case?

AlexandrosMor

comment created time in 5 days

PullRequestReviewEvent

PR opened Adyen/adyen-dotnet-api-library

[PW-6157] Add Store field to /sessions request

<!-- 🎉 Thank you for submitting a pull request! 🎉 -->

Summary

<!-- Describe the changes proposed in this pull request:

  • What is the motivation for this change?
  • What existing problem does this pull request solve? -->

This change introduces the parameter store for the https://docs.adyen.com/api-explorer/#/CheckoutService/v68/post/sessions__reqParam_store request.

It also changes the capitalization of other fields according to .NET standards.

Tested scenarios

<!-- Description of tested scenarios -->

  • Added unit tests
+845 -807

0 comment

4 changed files

pr created time in 8 days

create barnchAdyen/adyen-dotnet-api-library

branch : PW-6157

created branch time in 8 days

PullRequestReviewEvent

delete branch michaelpaul/explore

delete branch : patch-1

delete time in 9 days

PR opened github/explore

Add phpstan/phpstan to the Code Quality in PHP collection

<!-- Thank you for contributing! -->

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • [ ] Suggesting edits to an existing topic or collection
  • [ ] Curating a new topic or collection
  • [ ] Something that does not neatly fit into the binary options above

<!-- ⚠️ Please select either this section... ⚠️ -->

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • [ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • [ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

<!-- ⚠️ ... or this section ⚠️ -->

Curating a new topic or collection

  • [ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • [ ] My folder contains a *.png image (if applicable) and index.md
  • [ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

<!-- ⚠️ ... or this section ⚠️ -->

Something that does not neatly fit into the binary options above

  • [ ] My suggested edits are not about an existing topic or collection, or at least not a single one
  • [ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
  • [ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

+1 -0

0 comment

1 changed file

pr created time in 9 days

push eventmichaelpaul/explore

Michael Paul

commit sha 66b28fe7b9783099515116714f06a61b28036012

Add phpstan/phpstan to the collection

view details

push time in 9 days

fork michaelpaul/explore

Community-curated topic and collection pages on GitHub

https://github.com/explore

fork in 9 days

PullRequestReviewEvent

delete branch Adyen/adyen-magento2

delete branch : PW-6134

delete time in 11 days

PR merged Adyen/adyen-magento2

Reviewers
[PW-6134] Fix missing quote id on admin orders

<!-- Thank you for considering contributing to this repository! We encourage you to use PSR-2. -->

Description <!-- Please provide a description of the changes proposed in the Pull Request -->

The expression $payment->getData('quote_id') returns null causing an exception due to the lack of a required parameter. Fix it by using quote id from the order.

Tested scenarios <!-- Description of tested scenarios --> <!-- Please verify that the unit tests are passing by running "vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist vendor/adyen/module-payment/Test/" --> Admin orders:

  • Pay by link
  • Credit card
+2 -1

1 comment

1 changed file

michaelpaul

pr closed time in 11 days

push eventAdyen/adyen-magento2

Michael Paul

commit sha 85264e8ee935c44bfe68a3f491454b964565550e

[PW-6134] Fix missing quote id on admin orders (#1311)

view details

push time in 11 days

push eventAdyen/adyen-magento2

Jeantwan Teuma

commit sha 1b1f5faffba6025e3e5bd87fb4810068dfd9e7dc

[PW-6047] - Verify that component is defined when handling decline flow (#1312) * PW-6047 - Check if component is defined (giftcard case) * PW-6047 - Update requirements in readMe

view details

Michael Paul

commit sha 46d765b17398a68f38a7819a8839c084b157a70c

Merge branch 'develop' into PW-6134

view details

push time in 11 days

PullRequestReviewEvent

PR opened Adyen/adyen-magento2

[PW-6134] Fix missing quote id on admin orders

<!-- Thank you for considering contributing to this repository! We encourage you to use PSR-2. -->

Description <!-- Please provide a description of the changes proposed in the Pull Request -->

The expression $payment->getData('quote_id') returns null causing an exception due to the lack of a required parameter. Fix it by using quote id from the order.

Tested scenarios <!-- Description of tested scenarios --> <!-- Please verify that the unit tests are passing by running "vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist vendor/adyen/module-payment/Test/" --> Admin orders:

  • Pay by link
  • Credit card
+2 -1

0 comment

1 changed file

pr created time in 12 days

create barnchAdyen/adyen-magento2

branch : PW-6134

created branch time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
more