profile
viewpoint
Maximilian Heinzler mheinzler Germany

rwols/SublimeLinter-contrib-clang-tidy 7

A linter for clang-tidy

mheinzler/dropboxfilter 3

Automatically exported from code.google.com/p/dropboxfilter

mheinzler/OpenContextPath 3

Sublime Text plugin to open file paths at the current cursor position

mheinzler/SublimeGDB 1

GDB integration with Sublime Text 2

mheinzler/ANSIescape 0

ANSI escape codes color highlighting for SublimeText 3

mheinzler/autoconf-archive 0

A mirror of the GNU Autoconf Archive, a collection of more than 500 macros for GNU Autoconf that have been contributed as free software by friendly supporters of the cause from all over the Internet.

mheinzler/EasyClangComplete 0

:boom: C/C++ autocompletion in Sublime Text 3 for human beings

mheinzler/EnvironmentSettings 0

Fork of https://bitbucket.org/daniele-niero/sublimeprojectenvironment

mheinzler/ExecInput 0

Sublime Text package to send input to stdin through the exec build target

mheinzler/Font-Manager 0

Bitmap Font Manager for Corona / Lua

issue commentbillziss-gh/winfsp

Deleting a symlink actually deletes the target file

I can also no longer reproduce the issue.

Thanks a lot for the quick fix!

mheinzler

comment created time in a month

issue openedbillziss-gh/winfsp

Deleting a symlink actually deletes the target file

Bug Report

When deleting a symlink in a WinFsp filesystem with Windows Explorer the symlink target is deleted instead. Deleting the link with other tools (cmd, etc.) works correctly. I first noticed this in my filesystem but it can also be reproduced with MEMFS.

I attached log files and traces from Process Monitor of the deletion process here: logs.zip

The files memfs-delete-symlink* are about the bug, the memfs-delete-file* ones are only for comparison and show the deletion of a normal file. The logs have separators (********) to highlight the actual deletion parts.

How to Reproduce

  1. Mount a simple MEMFS filesystem: memfs-x64.exe -m Y:
  2. Create a test file: "New Text Document.txt"
  3. Create a symlink to the test file: "New Text Document - SymbolicLink.txt"
  4. Delete the symlink with Windows Explorer
  5. The symlink is still there but broken and the original file was deleted instead

Behaviors

From what I have seen yet, my best guess is that it has to do with Windows Explorer using CreateFile with a Delete On Close option to delete a file. It then sees that the file is a symlink and tries the same thing again with the target file which results in the wrong file being deleted. In most cases this will probably result in data loss.

Environment

  • OS version and build: Windows 10 20H2 / 19042.1288
  • WinFsp version and build: 2021 / 1.9.21096.0

created time in a month

created tagrwols/SublimeLinter-contrib-clang-tidy

tag1.3.3

A linter for clang-tidy

created time in 2 months

push eventrwols/SublimeLinter-contrib-clang-tidy

Maximilian Heinzler

commit sha ffe1434b08017f19863e0e7f0f8f5206583d76a6

Release 1.3.3 Fixed the missing message for the new version.

view details

push time in 2 months

release rwols/SublimeLinter-contrib-clang-tidy

1.3.2

released time in 2 months

created tagrwols/SublimeLinter-contrib-clang-tidy

tag1.3.2

A linter for clang-tidy

created time in 2 months

push eventrwols/SublimeLinter-contrib-clang-tidy

Maximilian Heinzler

commit sha 64d1eab44be4fcf503e8fa798d201895311dfb5f

Release 1.3.2

view details

push time in 2 months

delete branch mheinzler/SublimeLinter-contrib-clang-tidy

delete branch : fix-config

delete time in 2 months

push eventrwols/SublimeLinter-contrib-clang-tidy

Maximilian Heinzler

commit sha 9200f707a0d8a1bb16d8e3e619afccce99dd18fa

Remove the config argument to avoid overwriting the configuration file In newer versions of clang-tidy it seems that this option disables the configuration file and needs to be removed.

view details

Maximilian Heinzler

commit sha 2dc75e5250d6cc36ec2ef7c940b579e6c0b280e7

Merge pull request #8 from mheinzler/fix-config Remove the config argument to avoid overwriting the configuration file

view details

push time in 2 months

PR merged rwols/SublimeLinter-contrib-clang-tidy

Remove the config argument to avoid overwriting the configuration file

In newer versions of clang-tidy it seems that this option disables the configuration file and needs to be removed. At least that is the case for me, but unfortunately I can't test with older versions at the moment.

@rwols Do you know why this argument was added? I'm not sure if this would break the plugin for users with older versions of clang-tidy (<=10?).

+0 -1

2 comments

1 changed file

mheinzler

pr closed time in 2 months

pull request commentrwols/SublimeLinter-contrib-clang-tidy

Remove the config argument to avoid overwriting the configuration file

Then I will go ahead and merge this to at least fix the behavior for the more recent versions of clang-tidy.

mheinzler

comment created time in 2 months

more