profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/mgacc0/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

mgacc0/intrval 0

Relational Operators for Intervals

mgacc0/janitor 0

simple tools for data cleaning in R

mgacc0/treemap 0

R package for treemap visualisation

mgacc0/zcom-hn 0

Zara.com Hacker News clone

issue openeduBlockOrigin/uAssets

a dom filter on xunta.es/dog and xunta.gal/dog

Prerequisites

I tried to reproduce the issue when...

  • [X] uBO is the only extension
  • [X] uBO with default lists/settings
  • [X] using a new, unmodified browser profile

URL(s) where the issue occurs

https://www.xunta.gal/dog/Publicados/2001/20010625/Anuncio899A_es.html

Describe the issue

The URL https://www.xunta.gal/dog and https://www.xunta.gal/dog correspond to the government gazette of the region of Galicia (in Spain). They are wrongly affected by the rule: ###anuncio

In Spanish "anuncio" means ad, but also means announcement. And the content of this web is official announcements by the regional government.

An analogous issue has been reported a year ago to EasyList Spanish and they added an exception: https://forums.lanik.us/viewtopic.php?f=103&t=45457&sid=33d6511312c404fccf9b8298de59bd01

Screenshot(s)

image image

uBlock Origin version

1.37.2

Browser name and version

Chrome 93

Settings

No changes.

Notes

No response

created time in a month

PR opened sfirke/janitor

added the parameter "columns" to remove_constant

The new parameter "columns" to remove_constant specifies which columns to check.

The default is to check all columns. But since we don't know initially the names of the columns, it is expressed inversely as "c()".

I would prefer that "columns" could be the second parameter (instead of the last) so it would be possible to write

   df1 %>%
    remove_constant(c("col2", "col3"))

instead of having to write

   df1 %>%
    remove_constant(columns = c("col2", "col3"))

But adding a second parameter could break compatibility for some users if they had code like

   df1 %>%
    remove_constant(TRUE)

meaning

   df1 %>%
    remove_constant(na.rm = TRUE)
+50 -22

0 comment

2 changed files

pr created time in 2 months

push eventmgacc0/janitor

mgacc0

commit sha cfa5b344b20a680835dd64ca9e589c0cdbadbebf

Update test-remove-empties.R

view details

push time in 2 months

push eventmgacc0/janitor

mgacc0

commit sha e50670b5ed4ca7ec97f4379414339528ffbfeec9

added the parameter "columns" to `remove_constant` The new parameter "columns" to `remove_constant` specifies which columns to check. The default is to check all columns. But since we don't know initially the names of the columns, it is expressed inversely as "c()". I would prefer that "columns" could be the second parameter (instead of the last) so it would be possible to write ```r df1 %>% remove_constant(c("col2", "col3")) ``` instead of having to write ```r df1 %>% remove_constant(columns = c("col2", "col3")) ``` But adding a second parameter could break compatibility for some users if they had code like ```r df1 %>% remove_constant(TRUE) ``` meaning ```r df1 %>% remove_constant(na.rm = TRUE) ```

view details

push time in 2 months

fork mgacc0/janitor

simple tools for data cleaning in R

http://sfirke.github.io/janitor/

fork in 2 months

issue openedtidyverse/ggplot2

add methods for calculating number of bins in geom_histogram and geom_freqpoly

Would you consider of interest adding some methods to geom_histogram and geom_freqpoly for calculating the number of bins?

References:

  • grDevices package: grDevices::nclass.Sturges, grDevices::nclass.scott, and grDevices::nclass.FD.

  • https://github.com/atusy/ggAtusy/blob/master/R/geom_hist.R

created time in 2 months

issue commentsfirke/janitor

feature suggestion: parameter to specify decimal separator on adorn_pct_formatting

Use getOption("OutDec") as the default value for decimal.mark parameter:

adorn_pct_formatting <- function(dat, digits = 1, decimal.mark = getOption("OutDec"), rounding = "half to even", affix_sign = TRUE, ...)
mgacc0

comment created time in 3 months

issue commentrstudio/gt

add a .fn parameter to cols_label

Thanks @coatless. You are telling me that I could write

countrypops %>%
  filter(country_name == "Mongolia") %>%
  slice_tail(n = 5) %>%
  gt() %>%
  cols_label(.list = structure(as.list(str_remove(
    colnames(.), "country_"
  )),
  names = colnames(.)))

I know. I'm suggesting this feature so we could write

countrypops %>%
  filter(country_name == "Mongolia") %>%
  slice_tail(n = 5) %>%
  gt() %>%
  cols_label(.fn = ~ str_remove(., "country_"))
mgacc0

comment created time in 3 months

issue commentsfirke/janitor

feature suggestion: parameter to specify decimal separator on adorn_pct_formatting

adorn_pct_formatting converts numeric to string. So it should be the only one where it's needed.

As a reference: number from scales package https://github.com/r-lib/scales/blob/master/R/label-number.r internally calls the base::format function.

mgacc0

comment created time in 3 months

issue commentsfirke/janitor

suggestion: option to silence warnings in row_to_names

Now moments after writing the above, I learned that suppressWarnings() in base R has a classes option that will help. So, if we classed the warning, so that you could suppress it, would that solve your probelm?

rlang::warn("show this")
#> Warning: show this
rlang::warn("hide this", class="hider")
#> Warning: hide this

suppressWarnings({
  rlang::warn("show this")
  rlang::warn("hide this", class="hider")
},
classes="hider")
#> Warning: show this

Created on 2021-08-01 by the reprex package (v2.0.0)

That would be a good solution (at least for me).

mgacc0

comment created time in 3 months

issue commentsfirke/janitor

feature suggestion: parameter to specify decimal separator on adorn_pct_formatting

I'm from Europe. Internally (on scripts and storage) I often use decimal point. But for reports and output sometimes it's a requirement to use decimal comma. There are a lot of countries that use decimal comma: https://en.wikipedia.org/wiki/File:DecimalSeparator.svg

mgacc0

comment created time in 3 months

issue openedsfirke/janitor

suggestion: option to silence warnings in row_to_names

Could you consider adding an optional parameter in row_to_names to not warn about "Row X does not provide unique names. Consider running clean_names() after row_to_names()." Something like warnings = FALSE or quiet = TRUE.

The warning text is displayed always, even if the next line is exactly

%>%
    janitor::clean_names()

In my case, I have a script with many thousands of lines where the warnings (if any) should be thoroughly reviewed. So this one is inadecuate.

created time in 3 months

issue openedsfirke/janitor

feature suggestion: parameter to specify decimal separator on adorn_pct_formatting

Would you consider of interest adding a parameter "decimal.mark" (or similar) to adorn_pct_formatting?

created time in 3 months