profile
viewpoint

mbroz2/blogs 0

Blog posts for https://openliberty.io

mbroz2/docs 0

See Open Liberty documentation on https://openliberty.io/docs/

mbroz2/jsp-api 0

Jakarta Server Pages

mbroz2/microprofile-config 0

MicroProfile Configuration Feature

mbroz2/open-liberty 0

Open Liberty is a highly composable, fast to start, dynamic application server runtime environment

mbroz2/openliberty.io 0

Open Liberty website

mbroz2/openLibertyDay 0

Open Liberty Day - Liberty Applied

mbroz2/sample-getting-started 0

Getting started sample

issue openedOpenLiberty/iguide-microprofile-config-intro

Add config_ordinal for server.xml variables

@dmorgant found a bug a while back in OL that prevented the guide from included config_ordinal for server.xml variables. This has now been fixed under https://github.com/OpenLiberty/open-liberty/issues/14377 and part of 20.0.0.11. This should be added to the guide (and perhaps already exists in a branch/PR from @dmorgant )

created time in a day

issue closedOpenLiberty/open-liberty

Defining config_ordinal in server.xml has no effect on config properties

Describe the bug I am using the mpconfig-1.3 feature, which allows you to add configuration variable values to the Liberty server's server.xml file as a <variable> or <appProperty>< property> element. I tried to change the config_ordinal of the variable elements by including a config_ordinal <variable> element in my server.xml.

<variable name="config_ordinal" value="120"/>

This had no effect. It did not advance the precedence of the <variable> element setting above that of the <appProperty>< property> element or that of a value set in another configuration file like bootstrap.properties that had a config_ordinal of 700 set.

Steps to Reproduce

  1. Set a config variable in your bootstrap.properties file. Also set a value for the same property as a <variable> element and as an <appProperties><property> element in your server.xml file.
  2. Start your application and you will see that the value for the <appProperties><property> element is used because it has the highest config ordinal value (600).
  3. Set config_ordinal=700 in bootstrap.properties.
  4. Restart your application and you will see that the config variable is getting its value from bootstrap.properties since it now has the highest config_ordinal.
  5. Add a config_ordinal setting to the server.xml file as a <variable> element with a value of 800.
  6. Restart your application and the config variable still equals that set in the bootstrap.properties file. It does not appear that the setting a config_ordinal value for the <variable> element in server.xml had any effect.

Expected behavior I expect that if I set a <variable> element for config_ordinal in the Liberty server.xml file, that mpconfig would elevate the precedence of this config source above that of <appProperties><property> settings or other settings in other config sources for a variable.

Referencing: https://github.com/OpenLiberty/open-liberty/issues/2683

Additional context I am updating the mp-config-intro guide for the additional features added for mpconfig-1.3. I am using the sample application associated with the mp-config-intro guide to test: https://openliberty.io/guides/microprofile-config-intro.html

closed time in a day

dmorgant

issue commentOpenLiberty/open-liberty

Defining config_ordinal in server.xml has no effect on config properties

Fixed by https://github.com/OpenLiberty/open-liberty/issues/14377

dmorgant

comment created time in a day

issue commentOpenLiberty/open-liberty

Server.xml config sources do not respect config_ordinal

Fixes: https://github.com/OpenLiberty/open-liberty/issues/11357

Azquelt

comment created time in a day

Pull request review commentOpenLiberty/blogs

OpenLiberty 20.0.0.11 release post to staging

+---+layout: post+title: "Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11"+categories: blog+author_picture: https://avatars3.githubusercontent.com/austin0+author_github: https://github.com/austin0+seo-title: Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11 - OpenLiberty.io+seo-description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources inside Open Liberty projects. The 20.0.0.11 update also includes improved Grafana dashboard support on OpenLiberty.+blog_description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources, also included is improved support for MicroProfile Metrics visualization on Grafana dashboards.+open-graph-image: https://openliberty.io/img/twitter_card.jpg+---+= Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11+Austin Bailey <https://github.com/austin0>+:imagesdir: /+:url-prefix:+:url-about: /++// tag::intro[]++With Open Liberty 20.0.0.11 you can now make use of the Kerberos authentication protocol to secure your JDBC data sources. Also included in this release is improved support for Open Liberty Grafana dashboards, which have been updated to visualize MicroProfile Metrics data from Thanos data sources.++In link:{url-about}[Open Liberty] 20.0.0.11:++* <<kerberos, Kerberos authentication for JDBC data sources>>+* <<grafana, Grafana dashboard support for Thanos data source>>++View the list of fixed bugs in link:https://github.com/OpenLiberty/open-liberty/issues?q=label%3Arelease%3A200011+label%3A%22release+bug%22+[20.0.0.11].+// end::intro[]++// tag::run[]+[#run]++== Run your apps using 20.0.0.11++If you're using link:{url-prefix}/guides/maven-intro.html[Maven], here are the coordinates:++[source,xml]+----+<dependency>+    <groupId>io.openliberty</groupId>+    <artifactId>openliberty-runtime</artifactId>+    <version>20.0.0.11</version>+    <type>zip</type>+</dependency>+----++Or for link:{url-prefix}/guides/gradle-intro.html[Gradle]:++[source,gradle]+----+dependencies {+    libertyRuntime group: 'io.openliberty', name: 'openliberty-runtime', version: '[20.0.0.11,)'+}+----++Or if you're using Docker:++[source]+----+FROM open-liberty+----+//end::run[]++Or take a look at our link:{url-prefix}/downloads/[Downloads page].++[link=https://stackoverflow.com/tags/open-liberty]+image::img/blog/blog_btn_stack.svg[Ask a question on Stack Overflow, align="center"]++//tag::features[]++[#kerberos]+=== Kerberos authentication for JDBC data sources++Kerberos is a network authentication protocol in which a client and server authenticate by communicating with a third process called a Key Distribution Center (KDC). Kerberos authentication may be used for JDBC data sources that are backed by one of the following databases:

Of those two, I'd go with the second one:

Kerberos is a network authentication protocol in which a client and server authenticate by communicating with a Key Distribution Center (KDC).

austin0

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentOpenLiberty/blogs

OpenLiberty 20.0.0.11 release post to staging

+---+layout: post+title: "Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11"+categories: blog+author_picture: https://avatars3.githubusercontent.com/austin0+author_github: https://github.com/austin0+seo-title: Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11 - OpenLiberty.io+seo-description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources inside Open Liberty projects. The 20.0.0.11 update also includes improved Grafana dashboard support on OpenLiberty.+blog_description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources, also included is improved support for MicroProfile Metrics visualization on Grafana dashboards.+open-graph-image: https://openliberty.io/img/twitter_card.jpg+---+= Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11+Austin Bailey <https://github.com/austin0>+:imagesdir: /+:url-prefix:+:url-about: /++// tag::intro[]++With Open Liberty 20.0.0.11 you can now make use of the Kerberos authentication protocol to secure your JDBC data sources. Also included in this release is improved support for Open Liberty Grafana dashboards, which have been updated to visualize MicroProfile Metrics data from Thanos data sources.++In link:{url-about}[Open Liberty] 20.0.0.11:++* <<kerberos, Kerberos authentication for JDBC data sources>>+* <<grafana, Grafana dashboard support for Thanos data source>>++View the list of fixed bugs in link:https://github.com/OpenLiberty/open-liberty/issues?q=label%3Arelease%3A200011+label%3A%22release+bug%22+[20.0.0.11].+// end::intro[]++// tag::run[]+[#run]++== Run your apps using 20.0.0.11++If you're using link:{url-prefix}/guides/maven-intro.html[Maven], here are the coordinates:++[source,xml]+----+<dependency>+    <groupId>io.openliberty</groupId>+    <artifactId>openliberty-runtime</artifactId>+    <version>20.0.0.11</version>+    <type>zip</type>+</dependency>+----++Or for link:{url-prefix}/guides/gradle-intro.html[Gradle]:++[source,gradle]+----+dependencies {+    libertyRuntime group: 'io.openliberty', name: 'openliberty-runtime', version: '[20.0.0.11,)'+}+----++Or if you're using Docker:++[source]+----+FROM open-liberty+----+//end::run[]++Or take a look at our link:{url-prefix}/downloads/[Downloads page].++[link=https://stackoverflow.com/tags/open-liberty]+image::img/blog/blog_btn_stack.svg[Ask a question on Stack Overflow, align="center"]++//tag::features[]++[#kerberos]+=== Kerberos authentication for JDBC data sources++Kerberos is a network authentication protocol in which a client and server authenticate by communicating with a third process called a Key Distribution Center (KDC). Kerberos authentication may be used for JDBC data sources that are backed by one of the following databases:

@utle any thoughts on what term is most appropraite?

austin0

comment created time in 2 days

PullRequestReviewEvent

issue commentOpenLiberty/openliberty.io

Basic starter on downloads page

Great ty! Of those, my preference is 2 followed by 1. My issue with 3 & 4 is that they're repetitive, and what they repeat ("Version") is not important.
Perhaps if had an option like 4, but with the dropdown only containing the numerical version (avoiding the repetitive "Version"), like the dropdown in 2, that could make for a good option.

mbroz2

comment created time in 2 days

issue closedOpenLiberty/openliberty.io

Responsive TOC in docs

It would be nice if the the width of the TOC in docs adjusted based on the width of the page (like the TOC in the KC does).

closed time in 2 days

Charlotte-Holt

issue commentOpenLiberty/openliberty.io

Provide support for gradle in guides

It was decided that we will not have any new subsection regarding choosing the build tool under "Try what you'll build" and instead we'll just make sure that a guide does not reference the build tool prior to a user reaching a code section where they'd pick the build tool

mbroz2

comment created time in 2 days

Pull request review commentOpenLiberty/blogs

OpenLiberty 20.0.0.11 release post to staging

+---+layout: post+title: "Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11"+categories: blog+author_picture: https://avatars3.githubusercontent.com/austin0+author_github: https://github.com/austin0+seo-title: Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11 - OpenLiberty.io+seo-description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources inside Open Liberty projects. The 20.0.0.11 update also includes improved Grafana dashboard support on OpenLiberty.+blog_description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources, also included is improved support for MicroProfile Metrics visualization on Grafana dashboards.+open-graph-image: https://openliberty.io/img/twitter_card.jpg+---+= Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11+Austin Bailey <https://github.com/austin0>+:imagesdir: /+:url-prefix:+:url-about: /++// tag::intro[]++With Open Liberty 20.0.0.11 you can now make use of the Kerberos authentication protocol to secure your JDBC data sources. Also included in this release is improved support for Open Liberty Grafana dashboards, which have been updated to visualize MicroProfile Metrics data from Thanos data sources.++In link:{url-about}[Open Liberty] 20.0.0.11:++* <<kerberos, Kerberos authentication for JDBC data sources>>+* <<grafana, Grafana dashboard support for Thanos data source>>++View the list of fixed bugs in link:https://github.com/OpenLiberty/open-liberty/issues?q=label%3Arelease%3A200011+label%3A%22release+bug%22+[20.0.0.11].+// end::intro[]++// tag::run[]+[#run]++== Run your apps using 20.0.0.11++If you're using link:{url-prefix}/guides/maven-intro.html[Maven], here are the coordinates:++[source,xml]+----+<dependency>+    <groupId>io.openliberty</groupId>+    <artifactId>openliberty-runtime</artifactId>+    <version>20.0.0.11</version>+    <type>zip</type>+</dependency>+----++Or for link:{url-prefix}/guides/gradle-intro.html[Gradle]:++[source,gradle]+----+dependencies {+    libertyRuntime group: 'io.openliberty', name: 'openliberty-runtime', version: '[20.0.0.11,)'+}+----++Or if you're using Docker:++[source]+----+FROM open-liberty+----+//end::run[]++Or take a look at our link:{url-prefix}/downloads/[Downloads page].++[link=https://stackoverflow.com/tags/open-liberty]+image::img/blog/blog_btn_stack.svg[Ask a question on Stack Overflow, align="center"]++//tag::features[]++[#kerberos]+=== Kerberos authentication for JDBC data sources++Kerberos is a network authentication protocol in which a client and server authenticate by communicating with a third process called a Key Distribution Center (KDC). Kerberos authentication may be used for JDBC data sources that are backed by one of the following databases:

@aguibert my concern is that process is a very overloaded term, and it's not clear what its referring to. Is it talking about a system process, as in an instance of a program, (in which case 3 implies a hard number, as if multiple instances of each can't exist) or a series of events to do something.
I think we can use a better, more specific term like "trusted third-party" or "token server". If you want a broader term, then "third entity" would work.

austin0

comment created time in 2 days

PullRequestReviewEvent

issue commentOpenLiberty/openliberty.io

Provide support for gradle in guides

How about like this?

Prerequisites Copy 11

Going with this one!

mbroz2

comment created time in 2 days

Pull request review commentOpenLiberty/blogs

OpenLiberty 20.0.0.11 release post to staging

+---+layout: post+title: "Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11"+categories: blog+author_picture: https://avatars3.githubusercontent.com/austin0+author_github: https://github.com/austin0+seo-title: Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11 - OpenLiberty.io+seo-description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources inside Open Liberty projects. The 20.0.0.11 update also includes improved Grafana dashboard support on OpenLiberty.+blog_description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources, also included is improved support for MicroProfile Metrics visualization on Grafana dashboards.+open-graph-image: https://openliberty.io/img/twitter_card.jpg+---+= Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11+Austin Bailey <https://github.com/austin0>+:imagesdir: /+:url-prefix:+:url-about: /++// tag::intro[]++With Open Liberty 20.0.0.11 you can now make use of the Kerberos authentication protocol to secure your JDBC data sources. Also included in this release is improved support for Open Liberty Grafana dashboards, which have been updated to visualize MicroProfile Metrics data from Thanos data sources.++In link:{url-about}[Open Liberty] 20.0.0.11:++* <<kerberos, Kerberos authentication for JDBC data sources>>+* <<grafana, Grafana dashboard support for Thanos data source>>++View the list of fixed bugs in link:https://github.com/OpenLiberty/open-liberty/issues?q=label%3Arelease%3A200011+label%3A%22release+bug%22+[20.0.0.11].+// end::intro[]++// tag::run[]+[#run]++== Run your apps using 20.0.0.11++If you're using link:{url-prefix}/guides/maven-intro.html[Maven], here are the coordinates:++[source,xml]+----+<dependency>+    <groupId>io.openliberty</groupId>+    <artifactId>openliberty-runtime</artifactId>+    <version>20.0.0.11</version>+    <type>zip</type>+</dependency>+----++Or for link:{url-prefix}/guides/gradle-intro.html[Gradle]:++[source,gradle]+----+dependencies {+    libertyRuntime group: 'io.openliberty', name: 'openliberty-runtime', version: '[20.0.0.11,)'+}+----++Or if you're using Docker:++[source]+----+FROM open-liberty+----+//end::run[]++Or take a look at our link:{url-prefix}/downloads/[Downloads page].++[link=https://stackoverflow.com/tags/open-liberty]+image::img/blog/blog_btn_stack.svg[Ask a question on Stack Overflow, align="center"]++//tag::features[]++[#kerberos]+=== Kerberos authentication for JDBC data sources++Kerberos is a network authentication protocol in which a client and server authenticate by communicating with a third process called a Key Distribution Center (KDC). Kerberos authentication may be used for JDBC data sources that are backed by one of the following databases:

I'm not a SME on Kerberos, but "third process" seems like incorrect terminology? Perhaps "trusted third party" or "central server" or "token server" instead? Please follow up with Kerberos SME.

austin0

comment created time in 3 days

Pull request review commentOpenLiberty/blogs

OpenLiberty 20.0.0.11 release post to staging

+---+layout: post+title: "Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11"+categories: blog+author_picture: https://avatars3.githubusercontent.com/austin0+author_github: https://github.com/austin0+seo-title: Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11 - OpenLiberty.io+seo-description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources inside Open Liberty projects. The 20.0.0.11 update also includes improved Grafana dashboard support on OpenLiberty.+blog_description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources, also included is improved support for MicroProfile Metrics visualization on Grafana dashboards.+open-graph-image: https://openliberty.io/img/twitter_card.jpg

change this to point at the grafana img instead

austin0

comment created time in 3 days

Pull request review commentOpenLiberty/blogs

OpenLiberty 20.0.0.11 release post to staging

+---+layout: post+title: "Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11"+categories: blog+author_picture: https://avatars3.githubusercontent.com/austin0+author_github: https://github.com/austin0+seo-title: Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11 - OpenLiberty.io+seo-description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources inside Open Liberty projects. The 20.0.0.11 update also includes improved Grafana dashboard support on OpenLiberty.+blog_description: OpenLiberty 20.0.0.11 allows developers to use Kerberos authentication to secure their JDBC data sources, also included is improved support for MicroProfile Metrics visualization on Grafana dashboards.+open-graph-image: https://openliberty.io/img/twitter_card.jpg+---+= Kerberos authentication and improved Grafana dashboard support now available with OpenLiberty 20.0.0.11+Austin Bailey <https://github.com/austin0>+:imagesdir: /+:url-prefix:+:url-about: /++// tag::intro[]++With Open Liberty 20.0.0.11 you can now make use of the Kerberos authentication protocol to secure your JDBC data sources. Also included in this release is improved support for Open Liberty Grafana dashboards, which have been updated to visualize MicroProfile Metrics data from Thanos data sources.++In link:{url-about}[Open Liberty] 20.0.0.11:++* <<kerberos, Kerberos authentication for JDBC data sources>>+* <<grafana, Grafana dashboard support for Thanos data source>>++View the list of fixed bugs in link:https://github.com/OpenLiberty/open-liberty/issues?q=label%3Arelease%3A200011+label%3A%22release+bug%22+[20.0.0.11].+// end::intro[]++// tag::run[]+[#run]++== Run your apps using 20.0.0.11++If you're using link:{url-prefix}/guides/maven-intro.html[Maven], here are the coordinates:++[source,xml]+----+<dependency>+    <groupId>io.openliberty</groupId>+    <artifactId>openliberty-runtime</artifactId>+    <version>20.0.0.11</version>+    <type>zip</type>+</dependency>+----++Or for link:{url-prefix}/guides/gradle-intro.html[Gradle]:++[source,gradle]+----+dependencies {+    libertyRuntime group: 'io.openliberty', name: 'openliberty-runtime', version: '[20.0.0.11,)'+}+----++Or if you're using Docker:++[source]+----+FROM open-liberty+----+//end::run[]++Or take a look at our link:{url-prefix}/downloads/[Downloads page].++[link=https://stackoverflow.com/tags/open-liberty]+image::img/blog/blog_btn_stack.svg[Ask a question on Stack Overflow, align="center"]++//tag::features[]++[#kerberos]+=== Kerberos authentication for JDBC data sources++Kerberos is a network authentication protocol in which a client and server authenticate by communicating with a third process called a Key Distribution Center (KDC). Kerberos authentication may be used for JDBC data sources that are backed by one of the following databases:++* IBM DB2+* Oracle Database+* Microsoft SQLServer++Kerberos authentication in Liberty builds on top of the link:https://docs.oracle.com/en/java/javase/11/docs/api/jdk.security.auth/com/sun/security/auth/module/Krb5LoginModule.html[Kerberos Login Module and JGSS API provided by the JDK], which in turn builds on top of the Kerberos OS libraries for the specific system being used.++The `kerberos` configuration element in `server.xml` provides system-wide configuration options for the Liberty server. For example:++[source, xml]+----+  <kerberos keytab="${server.config.dir}/security/krb5.keytab" configFile="${server.config.dir}/security/krb5.conf"/>+----++Kerberos authentication is supported by a number of public features, including the following:++* acmeCA-2.0+* appSecurity-2.0/3.0/4.0+* connectors-2.0+* jdbc-4.0/4.1/4.2/4.3+* jwt-1.0+* mpMetrics-1.0/1.1/2.0/2.2/2.3/3.0+* oauth-2.0+* openapi-3.1+* restConnector-2.0+* socialLogin-1.0++Below is an example of the Kerberos protocol being used to secure a `jdbc-4.2` data source: ++[source, xml]+----+  <featureManager>+    <feature>jdbc-4.2</feature>+  </featureManager>++  <!-- optional config: This is only needed if you need to customize the location of keytab or krb5.conf -->+  <kerberos keytab="${server.config.dir}/security/krb5.keytab" configFile="${server.config.dir}/security/krb5.conf"/>++  <authData id="myKerberosAuth" krb5Principal="krbUser"/>++  <library id="db2DriverLib">+    <fileset dir="${server.config.dir}/db2"/>+  </library>++  <dataSource jndiName="jdbc/krb/basic" containerAuthDataRef="myKerberosAuth">+    <jdbcDriver libraryRef="db2DriverLib"/>+    <properties.db2.jcc databaseName="${DB2_DBNAME}" serverName="${DB2_HOSTNAME}" portNumber="${DB2_PORT}"/>+  </dataSource>+----++Before this release, it was technically possible to use Kerberos authentication with JDBC data sources, but the configuration was complex and un-documented. There was a lack of connection pooling support when using Kerberos authentication for data sources.++Full documentation for this capability will be available soon in the link:{url-prefix}/docs/latest/overview.html[Open Liberty documentation] pages.

@lauracowen do we want to make a reference to non-existing docs?

austin0

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

issue openedOpenLiberty/openliberty.io

Blog Tags with spaces do not work from individual blog posts

If a user clicks on the Tags in individual blog posts that have spaces (for example "Jakarta EE"), the link has a space instead of an underscore, and does not provide any search results.

For example: https://openliberty.io/blog/2020/09/09/pre-populating-db-connections.html

has:

<div class="post_tags_container">
  <a href="/blog/?search=MicroProfile" class="post_tag">MicroProfile</a>
  <span>, </span>
  <a href="/blog/?search=Java EE" class="post_tag">Java EE</a>
  <span>, </span>
  <a href="/blog/?search=Jakarta EE" class="post_tag">Jakarta EE</a>
  <span>, </span>
  <a href="/blog/?search=performance enhancements" class="post_tag">performance enhancements</a>
  <span>, </span>
  <a href="/blog/?search=data sources" class="post_tag">data sources</a>
  <span>, </span>
</div>

created time in 3 days

issue closedOpenLiberty/openliberty.io

Create temporary redirect from /docs/latest/why-open-liberty.html to /

We need to create a temporary redirect from /docs/latest/why-open-liberty.html to the homepage (/). Once the why-open-liberty exists in our docs, we'll remove the redirect.

This is to enable: https://github.com/OpenLiberty/docs/issues/951

closed time in 3 days

mbroz2

issue commentOpenLiberty/openliberty.io

Update Support page to explain how to obtain support if it has already been purchased

@gcharters will provide the content that needs to be added.

mbroz2

comment created time in 3 days

issue commentOpenLiberty/openliberty.io

Revise and update Contribute page and make it easier to find on website

@mbroz2 and @yeekangc will provide the content/layout for this page.

lauracowen

comment created time in 3 days

issue commentOpenLiberty/openliberty.io

Update Support page to explain how to obtain support if it has already been purchased

@mbroz2 and @yeekangc will provide the content/layout for this page.

mbroz2

comment created time in 3 days

issue commentOpenLiberty/openliberty.io

Responsive TOC in docs

Antora does not yet support this.

Charlotte-Holt

comment created time in 3 days

pull request commentOpenLiberty/openliberty.io

Remove some keyframes, allow others to run once while in view

I think we should: remove the star blink animation from all pages (homepage, get started and blog) on the 404 page, let the animation run once, not infinite on homepage & get started, only run the UFO animation when inViewport(), and for at most 15sec each time it comes into view (aka, stop moving after 15sec, each time it comes into view)

ellenwyllie

comment created time in 3 days

push eventOpenLiberty/openliberty.io

mbroz2

commit sha 095a59d7e26123770883d23c57c9ca2f6cf8922e

Add temporary redirect for why-open-liberty.html

view details

mbroz2

commit sha 19e3d53a00b3d7eb9dfc6860eca957b6e115f577

same redirect higher up See if moving the redirect higher up will cause it to take precedence

view details

mbroz2

commit sha f2b9755c9d34355d29a4a75a6618c13e39ca0032

Explicitly specify doc versions

view details

mbroz2

commit sha 61053341757b1ed3cac3076de23275c9a317293a

Merge pull request #1902 from OpenLiberty/tempRedirect Temp redirect

view details

mbroz2

commit sha 23bfc83e3180880680ac4cef92dd5eba32bb20bf

Merge pull request #1904 from OpenLiberty/staging Staging

view details

push time in 3 days

PR merged OpenLiberty/openliberty.io

Staging

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+7 -1

0 comment

1 changed file

mbroz2

pr closed time in 3 days

PR opened OpenLiberty/openliberty.io

Staging

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+7 -1

0 comment

1 changed file

pr created time in 3 days

push eventOpenLiberty/openliberty.io

Steven Zvonek

commit sha aac236aba5eefff2a6b5c137b12b172de24a1c2e

Merge pull request #1883 from OpenLiberty/staging 20.0.0.11 updates from Staging

view details

Ellen Wyllie

commit sha eeda464ab219b7a7c2b041f2ad486ccf043871f3

Merge pull request #1895 from OpenLiberty/staging Prevent callouts from getting copied

view details

mbroz2

commit sha 095a59d7e26123770883d23c57c9ca2f6cf8922e

Add temporary redirect for why-open-liberty.html

view details

mbroz2

commit sha 19e3d53a00b3d7eb9dfc6860eca957b6e115f577

same redirect higher up See if moving the redirect higher up will cause it to take precedence

view details

mbroz2

commit sha f2b9755c9d34355d29a4a75a6618c13e39ca0032

Explicitly specify doc versions

view details

mbroz2

commit sha 61053341757b1ed3cac3076de23275c9a317293a

Merge pull request #1902 from OpenLiberty/tempRedirect Temp redirect

view details

push time in 3 days

PR merged OpenLiberty/openliberty.io

Temp redirect

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+7 -1

0 comment

1 changed file

mbroz2

pr closed time in 3 days

PR opened OpenLiberty/openliberty.io

Temp redirect

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+7 -1

0 comment

1 changed file

pr created time in 3 days

push eventOpenLiberty/openliberty.io

mbroz2

commit sha f2b9755c9d34355d29a4a75a6618c13e39ca0032

Explicitly specify doc versions

view details

mbroz2

commit sha 19137e3f2ec30163c59501b789cc95c295b4a3a4

Merge pull request #1901 from OpenLiberty/tempRedirect Explicitly specify doc versions

view details

push time in 4 days

PR merged OpenLiberty/openliberty.io

Reviewers
Explicitly specify doc versions

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+3 -0

0 comment

1 changed file

mbroz2

pr closed time in 4 days

PR opened OpenLiberty/openliberty.io

Reviewers
Explicitly specify doc versions

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+3 -0

0 comment

1 changed file

pr created time in 4 days

push eventOpenLiberty/openliberty.io

mbroz2

commit sha f2b9755c9d34355d29a4a75a6618c13e39ca0032

Explicitly specify doc versions

view details

push time in 4 days

push eventOpenLiberty/openliberty.io

mbroz2

commit sha 19e3d53a00b3d7eb9dfc6860eca957b6e115f577

same redirect higher up See if moving the redirect higher up will cause it to take precedence

view details

mbroz2

commit sha 2834cba5b7458ade085bc8fd30502f4daeccf85e

Merge pull request #1900 from OpenLiberty/tempRedirect same redirect higher up

view details

push time in 4 days

PR merged OpenLiberty/openliberty.io

same redirect higher up

See if moving the redirect higher up will cause it to take precedence

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+3 -3

0 comment

1 changed file

mbroz2

pr closed time in 4 days

PR opened OpenLiberty/openliberty.io

Reviewers
same redirect higher up

See if moving the redirect higher up will cause it to take precedence

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+3 -3

0 comment

1 changed file

pr created time in 4 days

push eventOpenLiberty/openliberty.io

mbroz2

commit sha 19e3d53a00b3d7eb9dfc6860eca957b6e115f577

same redirect higher up See if moving the redirect higher up will cause it to take precedence

view details

push time in 4 days

issue commentOpenLiberty/guides-common

Update guides with option to build with Gradle

This above should not be an issue since the build tool selector is not going to be tabs like OS (except possibly the first one under getting started section). Instead, maven/gradle toggle/switch will be tied to each code block, which will reside within each OS tab.

chyt

comment created time in 4 days

issue commentOpenLiberty/guides-common

Update guides with option to build with Gradle

@mdenby from my recollection, we do not want to have the dropdown in the ToC for choosing the build tool. Instead, we wanted the toggle to be tied to each codepane, as discussed in the last paragraph in this comment https://github.com/OpenLiberty/guides-common/issues/46#issuecomment-641020358 and then mocked up in the following comment. image

Some guides (or all if we chose to) would also likely need a subsection under "Getting started" for choosing the build tool, like shown here: image but I think that design is fine, and doesn't need any changes, unless we were to more closely align it with w/e we choose to do for the switch/toggle for the build tool selection in the code pane.

chyt

comment created time in 5 days

issue commentOpenLiberty/openliberty.io

Provide support for gradle in guides

That's what I would expect (with the caveat the the maven/gradle picker in the above image is to just illustrate the overall intent of having the picker coupled with the code section, and location/styling of the picker may change as I don't believe the current one was provided by design)

mbroz2

comment created time in 5 days

issue commentOpenLiberty/openliberty.io

Provide support for gradle in guides

There's a missing && (double ampersand) between Java and Git in the above, but I think it's still clear enough what it would look like if we used logical operands for the prereqs.

mbroz2

comment created time in 5 days

issue commentOpenLiberty/openliberty.io

Guides with Skills Network

@jamiecoleman92 @yeekangc If we moved forward with LTI on ol.io, would a user then need to sign in on ol.io before being to proceed to one of the links for the SN guides?

I would rather, certainly in the short-term, just link to guide specific URLs. For example, the ol.io "Creating RESTful Web Services" guide would link directly to its SN equivalent of https://labs.cognitiveclass.ai/tools/theiadocker?md_instructions_url=https://cf-courses-data.s3.us.cloud-object-storage.appdomain.cloud/creating-a-restful-web-service-with-open-liberty/instructions.md However, the first time they went there, they would be presented with this page: image which makes it sound like this flow won't work for the long-term and the user would still need to then login.

mdenby

comment created time in 5 days

issue commentOpenLiberty/openliberty.io

Provide support for gradle in guides

@mdenby that looks good for Thurs morning; if we could also add one for Prerequisites: ([Maven] || [Gradle]) && [Java] && [Git] (note the double vertical pipe/bar and ampersands, along with the parentheses around the Maven || Gradle portion)

mbroz2

comment created time in 5 days

issue openedOpenLiberty/openliberty.io

404 page uses excessive CPU/GPU resources

In chromium based browsers, like Chrome, Vivaldi, & Edge (doesn't seem to be an issue in FF, and haven't tested Safari), the 404 page uses excessive CPU/GPU resources: image.png

created time in 8 days

issue commentOpenLiberty/openliberty.io

Provide support for gradle in guides

That was discussed in https://github.com/OpenLiberty/guides-common/issues/46 From my recollection, each code selection will have a toggle/button to switch between maven and gradle, plus one "OS Style" selector in the "Getting started" section, perhaps under a child like "Select Maven or Gradle". I think this is applicable regardless whether we do our current invocation of maven (and the equivalent gradle), or if we switch to using wrappers.

With that said, if we switch to using wrappers for maven and gradle, then we could get rid of them completely from the prereq section, unless we'd want to expose all 4 options.... but that seems redundant & unnecessary, and could lead to confusion to some users not familiar with the build tools.

mbroz2

comment created time in 8 days

push eventOpenLiberty/openliberty.io

Steven Zvonek

commit sha c890ca807d493ab02f03d5e74472fafcb4036014

Merge pull request #1882 from OpenLiberty/20.0.0.11-updates 20.0.0.11 updates

view details

Steven Zvonek

commit sha aac236aba5eefff2a6b5c137b12b172de24a1c2e

Merge pull request #1883 from OpenLiberty/staging 20.0.0.11 updates from Staging

view details

Steven Zvonek

commit sha f0337155ceb563f665bd5cfcc8d15e477d95e02a

Merge pull request #1893 from OpenLiberty/draft Prevent callouts from being copied

view details

Ellen Wyllie

commit sha eeda464ab219b7a7c2b041f2ad486ccf043871f3

Merge pull request #1895 from OpenLiberty/staging Prevent callouts from getting copied

view details

mbroz2

commit sha 095a59d7e26123770883d23c57c9ca2f6cf8922e

Add temporary redirect for why-open-liberty.html

view details

mbroz2

commit sha d921e02f153f810244cc1003dc2db151fca2edd9

Merge pull request #1898 from OpenLiberty/tempRedirect Temp redirect

view details

push time in 8 days

PR merged OpenLiberty/openliberty.io

Reviewers
Temp redirect infrastructure

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+4 -1

0 comment

1 changed file

mbroz2

pr closed time in 8 days

PR opened OpenLiberty/openliberty.io

Reviewers
Temp redirect infrastructure

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+4 -1

0 comment

1 changed file

pr created time in 8 days

create barnchOpenLiberty/openliberty.io

branch : tempRedirect

created branch time in 8 days

issue commentOpenLiberty/openliberty.io

Provide support for gradle in guides

I have no issues with it. I think it would be nice to see a full design of the prereq section with the one above, and another one with the logical operators, so: Prerequisites: [Maven | Gradle] [Java] [Git] Prerequisites: ([Maven] || [Gradle]) && [Java] && [Git]

mbroz2

comment created time in 8 days

issue openedOpenLiberty/openliberty.io

Create temporary redirect from /docs/latest/why-open-liberty.html to /

We need to create a temporary redirect from /docs/latest/why-open-liberty.html to the homepage (/). Once the why-open-liberty exists in our docs, we'll remove the redirect.

created time in 8 days

issue openedOpenLiberty/docs

Consider changing "API Documentation" to "Documenting APIs"

@barecode mentioned that the "API Documentation" header made him expect to find the content/APIs that's currently under "References" section. I suggest we rename this section to instead be "Documenting APIs" to help make it clear that it's not about our documentation for our APIs, but rather documentation on how to document their APIs.

created time in 10 days

issue commentOpenLiberty/docs

Finding the supported Javas & APIs for Open Liberty is too hard

I agree that API Documentation in the docs section can be confusing to someone. I think "Documenting APIs" would be clearer and I'll raise an issue for the docs team

barecode

comment created time in 10 days

issue openedOpenLiberty/openliberty.io

Update dev mode link on homepage

Currently the Lear More link for dev mode points at https://openliberty.io/blog/2019/10/22/liberty-dev-mode.html image

Now that we have a doc page for dev mode, we should point at it instead: https://openliberty.io/docs/20.0.0.10/development-mode.html

created time in 10 days

PullRequestReviewEvent

issue commentOpenLiberty/openliberty.io

Provide support for gradle in guides

that could work, but it would complicate the highlighting on hover over since only half the 'button' would highlight. Alternatively, we'd need to change the behavior so that instead of changing the background we'd just underline the word (regular 'link' behavior) image

mbroz2

comment created time in 16 days

issue commentOpenLiberty/openliberty.io

Provide support for gradle in guides

In general, a single line approach like in option 1 was preferred.

Another option that has been suggested is to go with option 1, but use logical operators like: Prerequisites: (Maven || Gradle) && Java && Git (technically we don't need the parentheses around Maven || Gradle, but it makes it clearer; we could also wrap the Java && Git.... portion with parentheses, but that feels unnecessary.

I think the main drawback with this approach is the repeating "&&" for a longer prereq list.

mbroz2

comment created time in 16 days

issue commentOpenLiberty/docs

Searchable messages

We don't consider the need to search (filter really) on search messages as MVP for getting the messages on the site. Instead, the proposed approach is to provide a single page with all messages, but also having links (hashes) to each of the 5 letter msg prefixes in the ToC (similarly to the server config behavior today). This provides a quick way to navigate the long page (via ToC), while also providing the Ctrl+f functionality to search for any particular message ID.

Note that currently some messages link to ibm support pages, which would need to be changed to instead link to openliberty.io/support (which first needs to be updated as per https://github.com/OpenLiberty/openliberty.io/issues/1892)

lauracowen

comment created time in 16 days

issue openedOpenLiberty/openliberty.io

Update Support page to explain how to obtain support if it has already been purchased

Currently, /support only explains how to go about purchasing support for Liberty, but it does not tell the user how to actually obtain support for the product (like opening a ticket).

We'll need content from @gcharters for this page.

created time in 16 days

issue commentOpenLiberty/openliberty.io

Provide Checksums for the packages on /downloads

Available in nightly builds: https://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/nightly/2020-10-06_1100/ next release should have it as well.

mbroz2

comment created time in 17 days

issue closedOpenLiberty/openliberty.io

Poor Entropy Cryptography

Our web application security scan tool reported the following security vulnerability:

Cryptography.PoorEntropy

ID: 49bf6e71-5fa9-ea11-96d200155d550e89 Severity: High Status: New Classification: Definitive Availability Impact: Partial Confidentiality Impact: Partial Integrity Impact: Partial CWE:331

Type:exploit Object: java.util.Random@1fab4602 Arguments: '32' Return:-406506440 Method Signature: protected int java.util.Random.next(int)

Stack: java.util.Random.next(Random.java:205) java.util.Random.nextInt(Random.java:329) com.ibm.ws.util.UUID.getPID(UUID.java:685) com.ibm.ws.util.UUID.<clinit>(UUID.java:52) com.ibm.ejs.csi.SessionKeyFactoryImpl.create(SessionKeyFactoryImpl.java:30) com.ibm.ejs.container.StatefulBeanO.initialize(StatefulBeanO.java:262) com.ibm.ejs.container.BeanOFactory.create(BeanOFactory.java:103) com.ibm.ejs.container.EJSHome.createBeanO(EJSHome.java:975) com.ibm.ejs.container.EJSHome.createBusinessObjectWrappers(EJSHome.java:1825) com.ibm.ejs.container.EJSHome.createRemoteBusinessObject(EJSHome.java:1671) com.ibm.ws.ejbcontainer.osgi.internal.naming.EJBNamingInstancer.initializeEJB(EJBNamingInstancer.java:71) com.ibm.ws.ejbcontainer.osgi.internal.naming.EJBJavaColonNamingHelper.processJavaColonGlobal(EJBJavaColonNamingHelper.java:179) com.ibm.ws.ejbcontainer.osgi.internal.naming.EJBJavaColonNamingHelper.getObjectInstance(EJBJavaColonNamingHelper.java:144) com.ibm.ws.jndi.url.contexts.javacolon.internal.JavaURLContext.lookup(JavaURLContext.java:332) com.ibm.ws.jndi.url.contexts.javacolon.internal.JavaURLContext.lookup(JavaURLContext.java:370) org.apache.aries.jndi.DelegateContext.lookup(DelegateContext.java:161) javax.naming.InitialContext.lookup(InitialContext.java:417)

closed time in 17 days

fbrillante

issue commentOpenLiberty/openliberty.io

Poor Entropy Cryptography

Thank you for opening the issue. Java Random is being used only to generate a Session Key ID, which is not used for anything security related and therefore does not need high entropy. In other words, there is no security vulnerability.

We may look into changing this code, but that would be only to avoid being incorrectly flagged by scanning tools.

fbrillante

comment created time in 17 days

pull request commentkubernetes/website

Add MP Interactive Tutorial to Config Section

The PR has been updated to point at the interactive tutorial hosted by kubernetes-bootcamp.

mbroz2

comment created time in 18 days

push eventmbroz2/website

Michal Broz

commit sha ecba51d73b71c3f134c30542aa14039072961e11

Update katacoda id to kubernetes-bootcamp

view details

push time in 18 days

pull request commentkubernetes/website

Add MP Interactive Tutorial to Config Section

@BenHall PR to move the interactive portion to kubernetes-bootcamp-scenarios has been created here: https://github.com/katacoda-scenarios/kubernetes-bootcamp-scenarios/pull/28

Once that gets merged, I'll update this PR to point to the new URL.

mbroz2

comment created time in 19 days

push eventOpenLiberty/openliberty.io

Steven Zvonek

commit sha 2639a89c68e3e13346429961b51f00520aa4e5c5

Merge pull request #1872 from OpenLiberty/staging Exclude docs from jekyll build

view details

Ellen Wyllie

commit sha bee180406391146ec9a415b6687cf6f68180b885

Merge pull request #1875 from OpenLiberty/staging Add copy to clipboard buttons back to docs

view details

Ellen Wyllie

commit sha 14a2b036826fb5daf52f073637535318198e78ab

Merge pull request #1877 from OpenLiberty/draft Add description to /guides

view details

Ellen Wyllie

commit sha 2445aaadce12451acbbc9368e73abd71c0e62ac4

Merge pull request #1880 from OpenLiberty/staging Update guides description

view details

David Mueller

commit sha cb9470f740776c557b59ba6af5d10aa103375bed

Update redirects.properties

view details

David Mueller

commit sha 8372eea1c3bc6dbaf32d2cda0a1c486492592789

Update build_jekyll_maven.sh

view details

David Mueller

commit sha bca33550c255d11f7439d70c07c21b9ccf54942d

Update head-info.hbs

view details

David Mueller

commit sha 0cee1dadbc69d39a7d24c9f986ced2993314e30a

Update sitemap.xml

view details

mbroz2

commit sha 00d6b64fc618b64a0e915f0e72ecd5aa28c49cf3

Merge pull request #1889 from OpenLiberty/20.0.0.11-updates 20.0.0.11 updates

view details

push time in 22 days

PR merged OpenLiberty/openliberty.io

Reviewers
20.0.0.11 updates

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+6 -6

0 comment

4 changed files

mbroz2

pr closed time in 22 days

PR opened OpenLiberty/openliberty.io

Reviewers
20.0.0.11 updates

What was fixed? (Issue # or description of fix)

Were the changes tested on

  • [ ] Firefox (Desktop)
  • [ ] Safari (Desktop)
  • [ ] Chrome (Desktop)
  • [ ] Internet Explorer (Desktop)
  • [ ] iOS (Mobile)
  • [ ] Android (Mobile)

Running validation tools

  • [ ] https://validator.w3.org/checklink
  • [ ] https://validator.w3.org
  • [ ] Dymanic Accessability Plugin (DAP)
  • [ ] Lighthouse (in Chrome dev tools)
+6 -6

0 comment

4 changed files

pr created time in 23 days

issue commentOpenLiberty/openliberty.io

Guides with Skills Network

The iframe approach is what I'd like to avoid for the first implementation, as it would need much more discussions and would likely be a much larger effort (which would likely end up delaying the integration).

I'm also against a pop-ups (not just for this, but in general) on the site, and I don't think it would be appropriate for this scenario. I think a simple link/button (which we can 'highlight') would be my preferred solution, at least as a cheap, first pass.

mdenby

comment created time in 23 days

issue commentOpenLiberty/openliberty.io

Guides with Skills Network

I think we should start by keeping things simple and just exposing a link (via some nice button/image) to the Skill Network equivalent of the guide, as an alternate (remote instead of local) way of completing the guide. Like YK said, we'd expose these links from the guide and perhaps from /guides as well, though personally I'm not sure we need it on the card/tile itself as I think it will get busy (unless we just mean to add a badge like we have for interactive guides, to signal that the guide is available on Skills Network as well, but that only makes sense if not all static guides will be converted).

If Any further integration into the site is wanted, we would need more discussion.

mdenby

comment created time in 24 days

issue openedOpenLiberty/guides-common

Try what you build should include the step `cd finish`

Currently, the guides tell the user to "go to the finish directory" and then run the command mvn liberty:run however, because "go to the finish directory" is not a command, it's very easy to miss, which causes an error from trying to run mvn from the root directory. We should add cd finish to the mvn liberty:run block, or add another block for cd finish

image

Looking at the common includes, it seems we have several adocs for this section, and the current being used by guides is https://github.com/OpenLiberty/guides-common/blob/master/twyb-intro.adoc which does not have this step, however, the https://github.com/OpenLiberty/guides-common/blob/master/trywhatyoubuild-intro.adoc does have it.

Perhaps this this been cause due to various copies/versions of that file? or because the wrong guides are pulling in the wrong common adoc?

created time in 25 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOpenLiberty/docs-playbook

Improve the README

 The [draft site](https://draft-openlibertyio.mybluemix.net/) is built using the  This is the flow that must be followed when releasing a new version of docs on openliberty.io. These steps update the `vNext`, `staging` and `draft` branches of the [docs repo](https://github.com/OpenLiberty/docs) so that the next version of docs can be worked on and ensures that fixes can still be made to the docs of the version being released. +Before proceeding, make sure there are no current builds on the [prod pipeline](https://cloud.ibm.com/devops/pipelines/fcc7c3e9-9c40-4a58-8a7f-09c08413ab7d?env_id=ibm:yp:us-south). This is so merging pull requests later into prod does not impact any current deployments.

I would be more explicit that you're referring to the "Build" step of the pipeline (active deployment are fine). (We could technically note that auto-builds can be temporarily disabled and then re-enabled, but that's likely overkill)

steven1046

comment created time in a month

Pull request review commentOpenLiberty/docs-playbook

Improve the README

 The [draft site](https://draft-openlibertyio.mybluemix.net/) is built using the  This is the flow that must be followed when releasing a new version of docs on openliberty.io. These steps update the `vNext`, `staging` and `draft` branches of the [docs repo](https://github.com/OpenLiberty/docs) so that the next version of docs can be worked on and ensures that fixes can still be made to the docs of the version being released. +Before proceeding, make sure there are no current builds on the [prod pipeline](https://cloud.ibm.com/devops/pipelines/fcc7c3e9-9c40-4a58-8a7f-09c08413ab7d?env_id=ibm:yp:us-south). This is so merging pull requests later into prod does not impact any current deployments.+ 1. Once all of the changes look correct on the [staging site](https://staging-openlibertyio.mybluemix.net/docs/), and all of the `staging` branch changes have been merged into the `vNext` branch, checkout the `vNext` branch and run `git pull` to get the updates. Then, create a branch off of the `vNext` branch with the next release version number. E.g. if the most recent version on openliberty.io is `20.0.0.8`, then create a `v20.0.0.9`  branch off of `vNext` by checking out the `vNext` branch and running `git checkout -b v20.0.0.9` and `git push` the branch.  2. Create `vX.0.0.X-staging` and `vX.0.0.X-draft` branches off of the new version branch just created which will be used for retroactive fixes to this version in the future. E.g. if `v20.0.0.9` is the version being released, then from that branch run `git checkout -b v20.0.0.9-staging` and push that branch to the docs repo. Switch back to the `v20.0.0.9` branch and run `git checkout -b v20.0.0.9-draft` and push that branch to the docs repo. -3. Create a new branch to add the new release version to the `branches` section of the [`prod playbook`](https://github.com/OpenLiberty/docs-playbook/blob/prod/antora-playbook.yml). Make a pull request into the `prod branch`. Once the pull request has been reviewed merge it in.+3. Create a new branch off of the `prod` branch of this repo to add the new release version to the `branches` section of the [`prod playbook`](https://github.com/OpenLiberty/docs-playbook/blob/prod/antora-playbook.yml). Make a pull request into the `prod branch`. Once the pull request has been reviewed merge it in. -4. Change the `version` in `antora.yml` in the [`staging`](https://github.com/OpenLiberty/docs/blob/staging/antora.yml) and [`draft`](https://github.com/OpenLiberty/docs/blob/draft/antora.yml) branches to the next release `vX.0.0.X` version incremented from the current release being published to openliberty.io. This is important so that the staging and draft builds can complete. Antora requires all of the versions of `antora.yml` of the branches being used in a build to have a unique version so they need to be updated to be unique from the version just released. You can either change the version and commit to draft/staging or create a pull request to do so.+4. Change the `version` in `antora.yml` in the [`staging`](https://github.com/OpenLiberty/docs/blob/staging/antora.yml) and [`draft`](https://github.com/OpenLiberty/docs/blob/draft/antora.yml) branches of the docs repo to the next release `vX.0.0.X` version incremented from the current release being published to openliberty.io. Once those changes have been reviewed merge them in. This is important so that the staging and draft builds can complete. Antora requires all of the versions of `antora.yml` of the branches being used in a build to have a unique version so they need to be updated to be unique from the version just released. You can either change the version and commit to draft/staging or create a pull request to do so. -5. Once the antora.yml [`staging`](https://github.com/OpenLiberty/docs/blob/staging/antora.yml) and [`draft`](https://github.com/OpenLiberty/docs/blob/draft/antora.yml) versions have been updated, create a pull request from `staging` to `vNext` to update the `antora.yml` version in `vNext`.+5. Once the antora.yml [`staging`](https://github.com/OpenLiberty/docs/blob/staging/antora.yml) and [`draft`](https://github.com/OpenLiberty/docs/blob/draft/antora.yml) versions have been updated in the docs repo, create a pull request from `staging` to `vNext` to update the `antora.yml` version in `vNext`.  6. (Temporary for now). Create a branch off of the `staging branch` of the [openliberty.io repo](https://github.com/OpenLiberty/openliberty.io). Make the following updates all in the same branch: * Until Antora natively supports 'latest' redirecting to the latest version, we have to update what version `latest` in the url redirects to: Update the redirects for `/docs/latest/*`, `/docs/latest/`, and `/docs/latest` in the [redirect file](https://github.com/OpenLiberty/openliberty.io/blob/staging/src/main/webapp/WEB-INF/redirects.properties) to redirect to the new released doc version (without a `v` in the url). * Update the `./scripts/build_clone_docs.sh vX.0.0.X` command in the [./scripts/build_jekyll_maven.sh](https://github.com/OpenLiberty/openliberty.io/blob/staging/scripts/build_jekyll_maven.sh) file to clone the latest doc version to get the javadocs which are not handled completely by Antora yet.  * Update the version of `{replace_version page.url 'X.0.0.X' }` in [src/main/content/antora_ui/src/partials/head-info.hbs](https://github.com/OpenLiberty/openliberty.io/blob/staging/src/main/content/antora_ui/src/partials/head-info.hbs) so that the canonical meta tag is set to the latest version of the documentation for all versions of the docs.  * Update the version of the url `<loc>https://openliberty.io/docs/X.0.0.X/overview.html</loc>` in the [src/main/content/sitemap.xml](https://github.com/OpenLiberty/openliberty.io/blob/staging/src/main/content/sitemap.xml). -7. Before proceeding, make sure all of the pull requests and changes from previous steps have been merged into their respective repos. Make a pull request from your branch into the `staging` branch. Once the pull request has been reviewed merge it in. The [staging site](http://dev-openlibertyio.mybluemix.net/) should automatically rebuild once the pull request has merged in. It will take ~40 minutes for the changes to show up on the staging site. You can track the progress using the [IBM Cloud staging pipeline](https://cloud.ibm.com/devops/pipelines/61002d76-1c13-4502-a109-3b794b3f2350?env_id=ibm:yp:us-south). Test that the docs link works and redirects to the newest doc version once the site is done building.+1. Before proceeding, make sure all of the pull requests and changes from previous steps have been merged into their respective repos. Make a pull request from your branch into both the `draft` and`staging` branches. Once the pull requests have been reviewed merge them in. The [staging site](https://staging-openlibertyio.mybluemix.net/) should automatically rebuild once the pull request has merged in. It will take ~40 minutes for the changes to show up on the staging site. You can track the progress using [Travis](https://travis-ci.com/github/OpenLiberty/openliberty.io/branches). Test that the docs link works and redirects to the newest doc version once the site is done building. -8. Make a pull request from the [UI staging branch](https://github.com/OpenLiberty/openliberty.io/tree/staging) into the [UI prod branch](https://github.com/OpenLiberty/openliberty.io/tree/prod). The [openliberty.io site](https://openliberty.io/) will automatically rebuild when the pull request is merged in. You can track the progress using the IBM Cloud pipeline(https://cloud.ibm.com/devops/pipelines/fcc7c3e9-9c40-4a58-8a7f-09c08413ab7d?env_id=ibm:yp:us-south).+2. Make a pull request from the [UI staging branch](https://github.com/OpenLiberty/openliberty.io/tree/staging) into the [UI prod branch](https://github.com/OpenLiberty/openliberty.io/tree/prod). The [openliberty.io site](https://openliberty.io/) will automatically rebuild when the pull request is merged in. You can track the progress using Travis(https://travis-ci.com/github/OpenLiberty/openliberty.io/branches).

This doesn't seem right.... Travis shouldn't know anything about the process of building the prod site? The previous version that pointed to IBM Cloud looks correct

steven1046

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOpenLiberty/blogs

New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11 beta

+---+layout: post+title: "MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta"+categories: blog+author_picture: https://avatars3.githubusercontent.com/jakub-pomykala+author_github: https://github.com/jakub-pomykala+seo-title: MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta - OpenLiberty.io+seo-description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+blog_description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+---+= New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11-beta+Jakub Pomykala <https://github.com/jakub-pomykala>+:imagesdir: /+:url-prefix:+:url-about: /++In this beta release the All Beta Features package contains our new MicroProfile OpenAPI 2.0 which allows you to generate documentation directly from APIs. In Jakarta EE 9 we have two features and also include improvements to features including many moving up to the latest API Release Candidates. ++We have two beta packages for link:{url-about}[Open Liberty]:++* <<allbeta, All Beta Features>>: a new, larger package that contains all Open Liberty beta and GA features and functions.+* <<jakarta, Jakarta EE 9 Beta Features>>: a lightweight package that contains only the Jakarta EE 9 features.++This means that you can now try out our in-development Open Liberty features by just adding the relevant coordinates to your build tools.+++If you try either package, <<feedback, let us know what you think>>.+[#allbeta]+== All Beta Features package++As well as the Jakarta EE 9 features listed above, the new All Beta Features package contains our new MicroProfile OpenAPI 2.0 feature which have been available in our link:/downloads/#development_builds[nightly builds] for a few weeks but are now easy to install from Maven Central too.++[#openAPI]+=== MicroProfile OpenAPI 2.0 ++MicroProfile OpenAPI 2.0 builds on top of the OpenAPI v3 specification. The link:https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md[OpenAPI v3 specification] defines a standard, language-agnostic, interface for describing REST APIs which allows documentation to be generated from the APIs themselves. The link:https://download.eclipse.org/microprofile/microprofile-open-api-2.0-RC3/microprofile-openapi-spec.html[MicroProfile OpenAPI specification] provides a unified Java API for the OpenAPI v3 specification which allows Java developers to generate OpenAPI v3 documents from their JAX-RS applications.+MicroProfile OpenAPI 2.0 introduces some new annotations that simplify the process of generating OpenAPI documentation for your REST APIs. It also introduces a new MicroProfile Config property prefix that can be used to define the schema for Java classes that you do not have the source code for.++[#schemaproperty]+==== @SchemaProperty++The @SchemaProperty annotation has been added to allow you to include properties in the definition of a schema when using the @Schema annotation. Previously, the @Schema annotation did not allow you to define any properties. Properties were introspected from the implementation class.+With the introduction of the @SchemaProperty annotation, a list of properties can now defined using the properties attribute on the @Schema annotation, as follows:++[source, java]+----+@Schema(+    name = "User",+        description = "Telephone number to contact the user”,+        implementation = User.class,+        properties = {+            @SchemaProperty(+                name = "phone",+                description = "Telephone number to contact the user”+            )+        }+    )} +----+[#requestbodyschema]+==== @RequestBodySchema++The @RequestBodySchema annotation has been added to provide a shorthand mechanism to specify the schema for a request body. Previously, defining the schema for a request body required the use of three different annotations, as follows:+[source, java]+----+@RequestBody(+    content = {+        @Content(+            schema = @Schema(+                implementation = MyRequestObject.class+            )+        )+    }+)+----++With the introduction of the @RequestBodySchema annotation, this can be simplified to the following:++[source, java]+----+@RequestBodySchema(MyRequestObject.class) +----++[#apiresponseschema]+==== @APIResponseSchema++The @APIResponseSchema annotation has been added to provide a shorthand mechanism to specify the schema for a response body. Previously, defining the schema for a response body required the use of three different annotations, as follows:++[source, java]+----+@APIResponse(+    content = {+            @Content(+                schema = @Schema(+                    implementation = MyResponseObject.class+                )+            )+        }+    )+----++With the introduction of the @RequestBodySchema annotation, this can be simplified to the following:++[source, java]+----+@APIResponseSchema(MyResponseObject.class)+----++[#mpopenapischeme]+==== mp.openapi.schema.*+The mp.openapi.schema.* MicroProfile Config property prefix has been added to allow you to define the schema for Java classes using configuration rather than code. The use of this property is functionally equivalent to the use of the @Schema annotation on a Java class, but may be used in cases where you do not have access to the source code of a class. The remainder of the property key must be the fully-qualified class name and the value must be a valid OpenAPI schema object, specified in the JSON format.+For example, in the case where an application wishes to represent Java Dates in epoch milliseconds, the following configuration could be used (line escapes and indentation added for readability):++[source, java]+----+mp.openapi.schema.java.util.Date = { \+   "name": "EpochMillis" \+   "type": "number", \+   "format": "int64", \+   "description": "Milliseconds since January 1, 1970, 00:00:00 GMT" \+ }+----++Enable OpenAPI 2.0 in the server.xml, along with any other features you’re using.++[source, xml]+----+<featureManager>+       <feature>mpOpenAPI-2.0</feature>+   </featureManager>+----++For more information:++* link:{url-prefix}/guides/microprofile-openapi.html[Documenting RESTful APIs]+* link:https://download.eclipse.org/microprofile/microprofile-open-api-2.0-RC3/apidocs/[Javadoc]+* link:https://download.eclipse.org/microprofile/microprofile-open-api-2.0-RC3/microprofile-openapi-spec.html#release_notes_20[Release notes]++=== Try it now++To try out these features, just update your build tools to pull the Open Liberty All Beta Features package instead of the main release. The beta works with Java SE 14, Java SE 11, or Java SE 8.++If you're using link:{url-prefix}/guides/maven-intro.html[Maven], here are the coordinates:++[source,xml]+----+<dependency>+  <groupId>io.openliberty.beta</groupId>+  <artifactId>openliberty-runtime</artifactId>+  <version>20.0.0.11-beta</version>+  <type>pom</type>+</dependency>+----++Or for link:{url-prefix}/guides/gradle-intro.html[Gradle]:++[source,gradle]+----+dependencies {+    libertyRuntime group: 'io.openliberty.beta', name: 'openliberty-runtime', version: '[20.0.0.11-beta,)'+}+----++Or take a look at our link:{url-prefix}/downloads/#runtime_betas[Downloads page].++[#jakarta]+== Jakarta EE 9 Beta Features package++The main change visible to developers in the Jakarta EE 9 planned release is the names of packages changing to accomodate the new `jakarta.*` namespace. In this Open Liberty beta, we have more Jakarta EE 9 features with their name change completed. In this release most features had improvments, including many moving up to the latest API Release Candidates.++This Open Liberty beta introduces the following Jakarta EE 9 features which now possess their all-new Jakarta EE 9 package names:++* Jakarta Enterprise Beans Remote 4.0 (`ejbRemote-4.0`)+* Jakarta EE Application Client 9.0 (`javaeeClient-9.0`) (Now supports Jakarta Enterprise Beans Remote Client 4.0)+++These join the Jakarta EE 9 features in link:{url-about}/blog/?search=beta&key=tag[previous Open Liberty betas]:++* Jakarta Authentication 2.0 (`jaspic-2.0`)+* Jakarta Authorization 2.0 (`jacc-2.0`)+* Jakarta Persistence 3.0 (includes Eclipselink 3.0-RC1.) (`jpa-3.0`)+* Jakarta XML Binding 3.0 (`jaxb-3.0`)+* Jakarta Managed Beans 2.0 (`managedBeans-2.0`)+* Jakarta Concurrency 2.0 (`concurrent-2.0`)+* Jakarta Enterprise Beans Home 4.0 (`ejbHome-4.0`)+* Jakarta Enterprise Beans Lite 4.0 (`ejbLite-4.0`)+* Jakarta Bean Validation 3.0 (`beanValidation-3.0`)+* Jakarta Contexts and Dependency Injection 3.0 (`cdi-3.0`)+* Jakarta WebSocket 2.0 (`websocket-2.0`; currently the integration with CDI is not completed)+* JDBC 4.2 & 4.3 (`jdbc-4.2` & `jdbc-4.3`)+* Jakarta Transactions 2.0 (`transaction-2.0`)+* Jakarta JSON Binding 2.0 (`jsonb-2.0`)+* Jakarta JSON Processing 2.0 (`jsonp-2.0`)+* Jakarta Servlet 5.0 (`servlet-5.0`)+* Jakarta Server Pages 3.0 (`jsp-3.0`)+* Jakarta Expression Language 4.0 (`el-4.0`)++=== Try it now++To try out these Jakarta EE 9 features on Open Liberty in a lightweight package, just update your build tools to pull the Open Liberty Jakarta EE 9 Beta Features package instead of the main release. The beta works with Java SE 14, Java SE 11, or Java SE 8.++If you're using link:{url-prefix}/guides/maven-intro.html[Maven], here are the coordinates:++[source,xml]+----+<dependency>+    <groupId>io.openliberty.beta</groupId>+    <artifactId>openliberty-jakartaee9</artifactId>+    <version>20.0.0.11-beta</version>+    <type>zip</type>+</dependency>+----++Or for link:{url-prefix}/guides/gradle-intro.html[Gradle]:++[source,gradle]+----+dependencies {+    libertyRuntime group: 'io.openliberty.beta', name: 'openliberty-jakartaee9', version: '[20.0.0.11-beta,)'+}+----++Or take a look at our link:{url-prefix}/downloads/#runtime_betas[Downloads page].++Enable the Jakarta EE 9 beta features in your app's `server.xml`. You can enable the individual features you want (but remember if you enable the `jsp-3.0` feature, the `servlet-5.0` and `el-4.0` features are automatically enabled for you) or you can just add the Jakarta EE 9 convenience feature to enable all of the Jakarta EE 9 beta features at once:

Remove "(but remember if you enable the jsp-3.0 feature, the servlet-5.0 and el-4.0 features are automatically enabled for you)" and if it's in the template for the blog post, remove it there as well

jakub-pomykala

comment created time in a month

Pull request review commentOpenLiberty/blogs

New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11 beta

+---+layout: post+title: "MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta"+categories: blog+author_picture: https://avatars3.githubusercontent.com/jakub-pomykala+author_github: https://github.com/jakub-pomykala+seo-title: MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta - OpenLiberty.io+seo-description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+blog_description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+---+= New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11-beta+Jakub Pomykala <https://github.com/jakub-pomykala>+:imagesdir: /+:url-prefix:+:url-about: /++In this beta release the All Beta Features package contains our new MicroProfile OpenAPI 2.0 which allows you to generate documentation directly from APIs. In Jakarta EE 9 we have two features and also include improvements to features including many moving up to the latest API Release Candidates. ++We have two beta packages for link:{url-about}[Open Liberty]:++* <<allbeta, All Beta Features>>: a new, larger package that contains all Open Liberty beta and GA features and functions.+* <<jakarta, Jakarta EE 9 Beta Features>>: a lightweight package that contains only the Jakarta EE 9 features.++This means that you can now try out our in-development Open Liberty features by just adding the relevant coordinates to your build tools.+++If you try either package, <<feedback, let us know what you think>>.+[#allbeta]+== All Beta Features package++As well as the Jakarta EE 9 features listed above, the new All Beta Features package contains our new MicroProfile OpenAPI 2.0 feature which have been available in our link:/downloads/#development_builds[nightly builds] for a few weeks but are now easy to install from Maven Central too.++[#openAPI]+=== MicroProfile OpenAPI 2.0 ++MicroProfile OpenAPI 2.0 builds on top of the OpenAPI v3 specification. The link:https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md[OpenAPI v3 specification] defines a standard, language-agnostic, interface for describing REST APIs which allows documentation to be generated from the APIs themselves. The link:https://download.eclipse.org/microprofile/microprofile-open-api-2.0-RC3/microprofile-openapi-spec.html[MicroProfile OpenAPI specification] provides a unified Java API for the OpenAPI v3 specification which allows Java developers to generate OpenAPI v3 documents from their JAX-RS applications.+MicroProfile OpenAPI 2.0 introduces some new annotations that simplify the process of generating OpenAPI documentation for your REST APIs. It also introduces a new MicroProfile Config property prefix that can be used to define the schema for Java classes that you do not have the source code for.++[#schemaproperty]+==== @SchemaProperty++The @SchemaProperty annotation has been added to allow you to include properties in the definition of a schema when using the @Schema annotation. Previously, the @Schema annotation did not allow you to define any properties. Properties were introspected from the implementation class.+With the introduction of the @SchemaProperty annotation, a list of properties can now defined using the properties attribute on the @Schema annotation, as follows:++[source, java]+----+@Schema(+    name = "User",+        description = "Telephone number to contact the user”,+        implementation = User.class,+        properties = {+            @SchemaProperty(+                name = "phone",+                description = "Telephone number to contact the user”+            )+        }+    )} +----+[#requestbodyschema]+==== @RequestBodySchema++The @RequestBodySchema annotation has been added to provide a shorthand mechanism to specify the schema for a request body. Previously, defining the schema for a request body required the use of three different annotations, as follows:+[source, java]+----+@RequestBody(+    content = {+        @Content(+            schema = @Schema(+                implementation = MyRequestObject.class+            )+        )+    }+)+----++With the introduction of the @RequestBodySchema annotation, this can be simplified to the following:++[source, java]+----+@RequestBodySchema(MyRequestObject.class) +----++[#apiresponseschema]+==== @APIResponseSchema++The @APIResponseSchema annotation has been added to provide a shorthand mechanism to specify the schema for a response body. Previously, defining the schema for a response body required the use of three different annotations, as follows:++[source, java]+----+@APIResponse(+    content = {+            @Content(+                schema = @Schema(+                    implementation = MyResponseObject.class+                )+            )+        }+    )+----++With the introduction of the @RequestBodySchema annotation, this can be simplified to the following:++[source, java]+----+@APIResponseSchema(MyResponseObject.class)+----++[#mpopenapischeme]+==== mp.openapi.schema.*+The mp.openapi.schema.* MicroProfile Config property prefix has been added to allow you to define the schema for Java classes using configuration rather than code. The use of this property is functionally equivalent to the use of the @Schema annotation on a Java class, but may be used in cases where you do not have access to the source code of a class. The remainder of the property key must be the fully-qualified class name and the value must be a valid OpenAPI schema object, specified in the JSON format.+For example, in the case where an application wishes to represent Java Dates in epoch milliseconds, the following configuration could be used (line escapes and indentation added for readability):++[source, java]+----+mp.openapi.schema.java.util.Date = { \+   "name": "EpochMillis" \+   "type": "number", \+   "format": "int64", \+   "description": "Milliseconds since January 1, 1970, 00:00:00 GMT" \+ }+----++Enable OpenAPI 2.0 in the server.xml, along with any other features you’re using.++[source, xml]+----+<featureManager>+       <feature>mpOpenAPI-2.0</feature>+   </featureManager>+----++For more information:++* link:{url-prefix}/guides/microprofile-openapi.html[Documenting RESTful APIs]+* link:https://download.eclipse.org/microprofile/microprofile-open-api-2.0-RC3/apidocs/[Javadoc]+* link:https://download.eclipse.org/microprofile/microprofile-open-api-2.0-RC3/microprofile-openapi-spec.html#release_notes_20[Release notes]++=== Try it now++To try out these features, just update your build tools to pull the Open Liberty All Beta Features package instead of the main release. The beta works with Java SE 14, Java SE 11, or Java SE 8.++If you're using link:{url-prefix}/guides/maven-intro.html[Maven], here are the coordinates:++[source,xml]+----+<dependency>+  <groupId>io.openliberty.beta</groupId>+  <artifactId>openliberty-runtime</artifactId>+  <version>20.0.0.11-beta</version>+  <type>pom</type>+</dependency>+----++Or for link:{url-prefix}/guides/gradle-intro.html[Gradle]:++[source,gradle]+----+dependencies {+    libertyRuntime group: 'io.openliberty.beta', name: 'openliberty-runtime', version: '[20.0.0.11-beta,)'+}+----++Or take a look at our link:{url-prefix}/downloads/#runtime_betas[Downloads page].++[#jakarta]+== Jakarta EE 9 Beta Features package++The main change visible to developers in the Jakarta EE 9 planned release is the names of packages changing to accomodate the new `jakarta.*` namespace. In this Open Liberty beta, we have more Jakarta EE 9 features with their name change completed. In this release most features had improvments, including many moving up to the latest API Release Candidates.

~The main change visible to developers in the Jakarta EE 9...~ I'd suggest instead "The main change developers should be aware of in the Jakarta EE 9...."

jakub-pomykala

comment created time in a month

Pull request review commentOpenLiberty/blogs

New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11 beta

+---+layout: post+title: "MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta"+categories: blog+author_picture: https://avatars3.githubusercontent.com/jakub-pomykala+author_github: https://github.com/jakub-pomykala+seo-title: MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta - OpenLiberty.io+seo-description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+blog_description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+---+= New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11-beta+Jakub Pomykala <https://github.com/jakub-pomykala>+:imagesdir: /+:url-prefix:+:url-about: /++In this beta release the All Beta Features package contains our new MicroProfile OpenAPI 2.0 which allows you to generate documentation directly from APIs. In Jakarta EE 9 we have two features and also include improvements to features including many moving up to the latest API Release Candidates. ++We have two beta packages for link:{url-about}[Open Liberty]:++* <<allbeta, All Beta Features>>: a new, larger package that contains all Open Liberty beta and GA features and functions.+* <<jakarta, Jakarta EE 9 Beta Features>>: a lightweight package that contains only the Jakarta EE 9 features.++This means that you can now try out our in-development Open Liberty features by just adding the relevant coordinates to your build tools.+++If you try either package, <<feedback, let us know what you think>>.+[#allbeta]+== All Beta Features package++As well as the Jakarta EE 9 features listed above, the new All Beta Features package contains our new MicroProfile OpenAPI 2.0 feature which have been available in our link:/downloads/#development_builds[nightly builds] for a few weeks but are now easy to install from Maven Central too.++[#openAPI]+=== MicroProfile OpenAPI 2.0 ++MicroProfile OpenAPI 2.0 builds on top of the OpenAPI v3 specification. The link:https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md[OpenAPI v3 specification] defines a standard, language-agnostic, interface for describing REST APIs which allows documentation to be generated from the APIs themselves. The link:https://download.eclipse.org/microprofile/microprofile-open-api-2.0-RC3/microprofile-openapi-spec.html[MicroProfile OpenAPI specification] provides a unified Java API for the OpenAPI v3 specification which allows Java developers to generate OpenAPI v3 documents from their JAX-RS applications.+MicroProfile OpenAPI 2.0 introduces some new annotations that simplify the process of generating OpenAPI documentation for your REST APIs. It also introduces a new MicroProfile Config property prefix that can be used to define the schema for Java classes that you do not have the source code for.++[#schemaproperty]+==== @SchemaProperty++The @SchemaProperty annotation has been added to allow you to include properties in the definition of a schema when using the @Schema annotation. Previously, the @Schema annotation did not allow you to define any properties. Properties were introspected from the implementation class.+With the introduction of the @SchemaProperty annotation, a list of properties can now defined using the properties attribute on the @Schema annotation, as follows:++[source, java]+----+@Schema(+    name = "User",+        description = "Telephone number to contact the user”,+        implementation = User.class,+        properties = {+            @SchemaProperty(+                name = "phone",+                description = "Telephone number to contact the user”+            )+        }+    )} +----+[#requestbodyschema]+==== @RequestBodySchema++The @RequestBodySchema annotation has been added to provide a shorthand mechanism to specify the schema for a request body. Previously, defining the schema for a request body required the use of three different annotations, as follows:+[source, java]+----+@RequestBody(+    content = {+        @Content(+            schema = @Schema(+                implementation = MyRequestObject.class+            )+        )+    }+)+----++With the introduction of the @RequestBodySchema annotation, this can be simplified to the following:++[source, java]+----+@RequestBodySchema(MyRequestObject.class) +----++[#apiresponseschema]+==== @APIResponseSchema++The @APIResponseSchema annotation has been added to provide a shorthand mechanism to specify the schema for a response body. Previously, defining the schema for a response body required the use of three different annotations, as follows:++[source, java]+----+@APIResponse(+    content = {+            @Content(+                schema = @Schema(+                    implementation = MyResponseObject.class+                )+            )+        }+    )+----++With the introduction of the @RequestBodySchema annotation, this can be simplified to the following:++[source, java]+----+@APIResponseSchema(MyResponseObject.class)+----++[#mpopenapischeme]+==== mp.openapi.schema.*+The mp.openapi.schema.* MicroProfile Config property prefix has been added to allow you to define the schema for Java classes using configuration rather than code. The use of this property is functionally equivalent to the use of the @Schema annotation on a Java class, but may be used in cases where you do not have access to the source code of a class. The remainder of the property key must be the fully-qualified class name and the value must be a valid OpenAPI schema object, specified in the JSON format.+For example, in the case where an application wishes to represent Java Dates in epoch milliseconds, the following configuration could be used (line escapes and indentation added for readability):

"wishes" -> "needs" ? note sure on this one, but I'm thinking "Java Dates" should be either "dates" or "Java Date" or java.util.Date with the middle one being my preference. @lauracowen may have an oppinion/guideline on this.

jakub-pomykala

comment created time in a month

Pull request review commentOpenLiberty/blogs

New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11 beta

+---+layout: post+title: "MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta"+categories: blog+author_picture: https://avatars3.githubusercontent.com/jakub-pomykala+author_github: https://github.com/jakub-pomykala+seo-title: MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta - OpenLiberty.io+seo-description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+blog_description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+---+= New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11-beta+Jakub Pomykala <https://github.com/jakub-pomykala>+:imagesdir: /+:url-prefix:+:url-about: /++In this beta release the All Beta Features package contains our new MicroProfile OpenAPI 2.0 which allows you to generate documentation directly from APIs. In Jakarta EE 9 we have two features and also include improvements to features including many moving up to the latest API Release Candidates. ++We have two beta packages for link:{url-about}[Open Liberty]:++* <<allbeta, All Beta Features>>: a new, larger package that contains all Open Liberty beta and GA features and functions.+* <<jakarta, Jakarta EE 9 Beta Features>>: a lightweight package that contains only the Jakarta EE 9 features.++This means that you can now try out our in-development Open Liberty features by just adding the relevant coordinates to your build tools.+++If you try either package, <<feedback, let us know what you think>>.+[#allbeta]+== All Beta Features package++As well as the Jakarta EE 9 features listed above, the new All Beta Features package contains our new MicroProfile OpenAPI 2.0 feature which have been available in our link:/downloads/#development_builds[nightly builds] for a few weeks but are now easy to install from Maven Central too.

"listed above"? do you mean "listed below"? should we change the order such that Jakarta EE 9 package is talked about first, and then the All Beta Features since the latter is a superset that includes the former?

jakub-pomykala

comment created time in a month

Pull request review commentOpenLiberty/blogs

New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11 beta

+---+layout: post+title: "MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta"+categories: blog+author_picture: https://avatars3.githubusercontent.com/jakub-pomykala+author_github: https://github.com/jakub-pomykala+seo-title: MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta - OpenLiberty.io+seo-description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+blog_description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+---+= New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11-beta+Jakub Pomykala <https://github.com/jakub-pomykala>+:imagesdir: /+:url-prefix:+:url-about: /++In this beta release the All Beta Features package contains our new MicroProfile OpenAPI 2.0 which allows you to generate documentation directly from APIs. In Jakarta EE 9 we have two features and also include improvements to features including many moving up to the latest API Release Candidates. ++We have two beta packages for link:{url-about}[Open Liberty]:++* <<allbeta, All Beta Features>>: a new, larger package that contains all Open Liberty beta and GA features and functions.+* <<jakarta, Jakarta EE 9 Beta Features>>: a lightweight package that contains only the Jakarta EE 9 features.++This means that you can now try out our in-development Open Liberty features by just adding the relevant coordinates to your build tools.+++If you try either package, <<feedback, let us know what you think>>.+[#allbeta]+== All Beta Features package++As well as the Jakarta EE 9 features listed above, the new All Beta Features package contains our new MicroProfile OpenAPI 2.0 feature which have been available in our link:/downloads/#development_builds[nightly builds] for a few weeks but are now easy to install from Maven Central too.++[#openAPI]+=== MicroProfile OpenAPI 2.0 ++MicroProfile OpenAPI 2.0 builds on top of the OpenAPI v3 specification. The link:https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.0.md[OpenAPI v3 specification] defines a standard, language-agnostic, interface for describing REST APIs which allows documentation to be generated from the APIs themselves. The link:https://download.eclipse.org/microprofile/microprofile-open-api-2.0-RC3/microprofile-openapi-spec.html[MicroProfile OpenAPI specification] provides a unified Java API for the OpenAPI v3 specification which allows Java developers to generate OpenAPI v3 documents from their JAX-RS applications.+MicroProfile OpenAPI 2.0 introduces some new annotations that simplify the process of generating OpenAPI documentation for your REST APIs. It also introduces a new MicroProfile Config property prefix that can be used to define the schema for Java classes that you do not have the source code for.++[#schemaproperty]+==== @SchemaProperty++The @SchemaProperty annotation has been added to allow you to include properties in the definition of a schema when using the @Schema annotation. Previously, the @Schema annotation did not allow you to define any properties. Properties were introspected from the implementation class.+With the introduction of the @SchemaProperty annotation, a list of properties can now defined using the properties attribute on the @Schema annotation, as follows:++[source, java]+----+@Schema(+    name = "User",+        description = "Telephone number to contact the user”,+        implementation = User.class,+        properties = {+            @SchemaProperty(+                name = "phone",+                description = "Telephone number to contact the user”+            )+        }+    )} +----+[#requestbodyschema]+==== @RequestBodySchema++The @RequestBodySchema annotation has been added to provide a shorthand mechanism to specify the schema for a request body. Previously, defining the schema for a request body required the use of three different annotations, as follows:+[source, java]+----+@RequestBody(+    content = {+        @Content(+            schema = @Schema(+                implementation = MyRequestObject.class+            )+        )+    }+)+----++With the introduction of the @RequestBodySchema annotation, this can be simplified to the following:++[source, java]+----+@RequestBodySchema(MyRequestObject.class) +----++[#apiresponseschema]+==== @APIResponseSchema++The @APIResponseSchema annotation has been added to provide a shorthand mechanism to specify the schema for a response body. Previously, defining the schema for a response body required the use of three different annotations, as follows:++[source, java]+----+@APIResponse(+    content = {+            @Content(+                schema = @Schema(+                    implementation = MyResponseObject.class+                )+            )+        }+    )+----++With the introduction of the @RequestBodySchema annotation, this can be simplified to the following:++[source, java]+----+@APIResponseSchema(MyResponseObject.class)+----++[#mpopenapischeme]+==== mp.openapi.schema.*+The mp.openapi.schema.* MicroProfile Config property prefix has been added to allow you to define the schema for Java classes using configuration rather than code. The use of this property is functionally equivalent to the use of the @Schema annotation on a Java class, but may be used in cases where you do not have access to the source code of a class. The remainder of the property key must be the fully-qualified class name and the value must be a valid OpenAPI schema object, specified in the JSON format.+For example, in the case where an application wishes to represent Java Dates in epoch milliseconds, the following configuration could be used (line escapes and indentation added for readability):++[source, java]+----+mp.openapi.schema.java.util.Date = { \+   "name": "EpochMillis" \+   "type": "number", \+   "format": "int64", \+   "description": "Milliseconds since January 1, 1970, 00:00:00 GMT" \+ }+----++Enable OpenAPI 2.0 in the server.xml, along with any other features you’re using.++[source, xml]+----+<featureManager>+       <feature>mpOpenAPI-2.0</feature>+   </featureManager>+----++For more information:++* link:{url-prefix}/guides/microprofile-openapi.html[Documenting RESTful APIs]

I think this should specify that it's linking to a guide, so [Guide: Documenting RESTful APIs] or [Documenting RESTful APIs Guide]

jakub-pomykala

comment created time in a month

PullRequestReviewEvent

Pull request review commentOpenLiberty/blogs

New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11 beta

+---+layout: post+title: "MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta"+categories: blog+author_picture: https://avatars3.githubusercontent.com/jakub-pomykala+author_github: https://github.com/jakub-pomykala+seo-title: MicroProfile OpenAPI 2.0 plus new features and loads of improvements for Jakarta EE 9 in Open Liberty 20.0.0.11-beta - OpenLiberty.io+seo-description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+blog_description: Open Liberty 20.0.0.11-beta comes with MicroProfile OpenAPI 2.0 which allows users to generate documentation directly from APIs, plus two new features for Jakarta EE 9.+---+= New features and loads of improvements for Jakarta EE 9 plus MicroProfile OpenAPI 2.0 in Open Liberty 20.0.0.11-beta+Jakub Pomykala <https://github.com/jakub-pomykala>+:imagesdir: /+:url-prefix:+:url-about: /++In this beta release the All Beta Features package contains our new MicroProfile OpenAPI 2.0 which allows you to generate documentation directly from APIs. In Jakarta EE 9 we have two features and also include improvements to features including many moving up to the latest API Release Candidates. 

~In this beta release the All Beta Features package contains our new MicroProfile OpenAPI 2.0 which allows you to generate documentation directly from APIs. In Jakarta EE 9 we have two features and also include improvements to features including many moving up to the latest API Release Candidates.~ In the 20.0.0.11-beta we have added two new Jakarta EE 9 features along with improvements to existing Jakarta EE 9 features, including many moving up to the latest API Release Candidates. These changes are available in both the Jakarta EE 9 Beta Features as well as the All Beta Features packages, however, the latter also includes our new MicroProfile OpenAPI 2.0 which allows you to generate documentation directly from APIs.

or something along those lines that makes it clear that the Jakarta EE 9 changes are available in both packages.

jakub-pomykala

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOpenLiberty/blogs

Template updates

+---+layout: post+title: "TITLE"+categories: blog+author_picture: https://avatars3.githubusercontent.com/GITHUB_USERNAME+author_github: https://github.com/GITHUB_USERNAME+seo-title: TITLE - makes sure it ends with - OpenLiberty.io+seo-description: DESCRIPTION+blog_description: DESCRIPTION+open-graph-image: https://openliberty.io/img/twitter_card.jpg+---+= TITLE+AUTHOR_NAME <https://github.com/GITHUB_USERNAME>+:imagesdir: /+:url-prefix:+:url-about: /+// // // // // // // //+// Above:+// Do not insert any blank lines between any of the lines above.+// Do not remove or edit the variables on the lines beneath the author name.+//+// "open-graph-image" is set to OL logo, howver it can be changed to a different image or left blank in which case it will be set to the default  // Open Liberty logo+//+// Replace TITLE with the blog post title eg: MicroProfile 3.3 is now available on Open Liberty 20.0.0.4+// Replace GITHUB_USERNAME with your GitHub username eg: lauracowen+// Replace DESCRIPTION with a short summary (~60 words) of the release (a more succinct version of the first paragraph of the post).+// Replace AUTHOR_NAME with your name as you'd like it to be displayed, eg: Laura Cowen+//+// If adding image into the post add :+// -------------------------+// [.img_border_light]+// image::img/blog/FILE_NAME[IMAGE NAME/DESCRIPTION ,width=70%,align="center"]+// -------------------------+// "[.img_border_light]" = This adds a faint grey border around the image to make its edges sharper. Use it around screenshots but not            // around diagrams. Then double check how it looks.+// Change "FILE_NAME" to the name of the image file. Also make sure to put the image into the right folder which is: img/blog+// change the "IAMGE NAME/DESCRIPTION" to a couple words of what the image is

I was just pointing out the spelling error

jakub-pomykala

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOpenLiberty/blogs

Template updates

 AUTHOR_NAME <https://github.com/GITHUB_USERNAME> // Above: // Do not insert any blank lines between any of the lines above. //+//+// "open-graph-image" is set to OL logo, howver it can be changed to a different image or left blank in which case it will be set to the default  // Open Liberty logo

also, seems like formatting of comments is off

jakub-pomykala

comment created time in a month

Pull request review commentOpenLiberty/blogs

Template updates

+---+layout: post+title: "TITLE"+categories: blog+author_picture: https://avatars3.githubusercontent.com/GITHUB_USERNAME+author_github: https://github.com/GITHUB_USERNAME+seo-title: TITLE - makes sure it ends with - OpenLiberty.io+seo-description: DESCRIPTION+blog_description: DESCRIPTION+open-graph-image: https://openliberty.io/img/twitter_card.jpg+---+= TITLE+AUTHOR_NAME <https://github.com/GITHUB_USERNAME>+:imagesdir: /+:url-prefix:+:url-about: /+// // // // // // // //+// Above:+// Do not insert any blank lines between any of the lines above.+// Do not remove or edit the variables on the lines beneath the author name.+//+// "open-graph-image" is set to OL logo, howver it can be changed to a different image or left blank in which case it will be set to the default  // Open Liberty logo+//+// Replace TITLE with the blog post title eg: MicroProfile 3.3 is now available on Open Liberty 20.0.0.4+// Replace GITHUB_USERNAME with your GitHub username eg: lauracowen+// Replace DESCRIPTION with a short summary (~60 words) of the release (a more succinct version of the first paragraph of the post).+// Replace AUTHOR_NAME with your name as you'd like it to be displayed, eg: Laura Cowen+//+// If adding image into the post add :+// -------------------------+// [.img_border_light]+// image::img/blog/FILE_NAME[IMAGE NAME/DESCRIPTION ,width=70%,align="center"]+// -------------------------+// "[.img_border_light]" = This adds a faint grey border around the image to make its edges sharper. Use it around screenshots but not            // around diagrams. Then double check how it looks.

formatting of comment seems incorrect

jakub-pomykala

comment created time in a month

Pull request review commentOpenLiberty/blogs

Template updates

 AUTHOR_NAME <https://github.com/GITHUB_USERNAME> // Replace AUTHOR_NAME with your name as you'd like it to be displayed, eg: Laura Cowen // // Example post: 2020-02-12-faster-startup-Java-applications-criu.adoc+//+//+// If adding image into the post add :+// -------------------------+// [.img_border_light]+// image::img/blog/FILE_NAME[IMAGE NAME/DESCRIPTION ,width=70%,align="center"]+// -------------------------+// "[.img_border_light]" = This adds a faint grey border around the image to make its edges sharper. Use it around screenshots but not            // around diagrams. Then double check how it looks.+// Change "FILE_NAME" to the name of the image file. Also make sure to put the image into the right folder which is: img/blog+// change the "IAMGE NAME/DESCRIPTION" to a couple words of what the image is

IMAGE

jakub-pomykala

comment created time in a month

Pull request review commentOpenLiberty/blogs

Template updates

 AUTHOR_NAME <https://github.com/GITHUB_USERNAME> // Replace AUTHOR_NAME with your name as you'd like it to be displayed, eg: Laura Cowen // // Example post: 2020-04-02-generate-microprofile-rest-client-code.adoc+//+//+// If adding image into the post add :+// -------------------------+// [.img_border_light]+// image::img/blog/FILE_NAME[IMAGE NAME/DESCRIPTION ,width=70%,align="center"]+// -------------------------+// "[.img_border_light]" = This adds a faint grey border around the image to make its edges sharper. Use it around screenshots but not            // around diagrams. Then double check how it looks.+// Change "FILE_NAME" to the name of the image file. Also make sure to put the image into the right folder which is: img/blog+// change the "IAMGE NAME/DESCRIPTION" to a couple words of what the image is

IMAGE

jakub-pomykala

comment created time in a month

Pull request review commentOpenLiberty/blogs

Template updates

 AUTHOR_NAME <https://github.com/GITHUB_USERNAME> // Do not provide any body text in this post - it will not be displayed. // // Example post: 2020-04-29-fast-setup-java-microservice-microprofile-starter.adoc+//+//+// If adding image into the post add :+// -------------------------+// [.img_border_light]+// image::img/blog/FILE_NAME[IMAGE NAME/DESCRIPTION ,width=70%,align="center"]+// -------------------------+// "[.img_border_light]" = This adds a faint grey border around the image to make its edges sharper. Use it around screenshots but not            // around diagrams. Then double check how it looks.

formatting of comment seems incorrect

jakub-pomykala

comment created time in a month

Pull request review commentOpenLiberty/blogs

Template updates

 AUTHOR_NAME <https://github.com/GITHUB_USERNAME> // Above: // Do not insert any blank lines between any of the lines above. //+// "open-graph-image" is set to OL logo, howver it can be changed to a different image or left blank in which case it will be set to the default  // Open Liberty logo

formatting of comment seems incorrect add comment that whenever possible, a more appropriate/specific image should be used. For example, if present, to an image used within the blog post.

jakub-pomykala

comment created time in a month

PullRequestReviewEvent
more