profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/mattklein123/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

proxy-wasm/spec 228

WebAssembly for Proxies (ABI specification)

cncf/udpa 193

🌌📊✈Universal Data Plane API Working Group (UDPA-WG)

proxy-wasm/proxy-wasm-cpp-sdk 81

WebAssembly for Proxies (C++ SDK)

cncf/xds 53

xDS API Working Group

cncf/tag-contributor-strategy 52

CNCF Technical Advisory Group on Contributor Strategy -- maintainer relations, building up contributors, governance, graduation, and more.

mattklein123/lyft_envoy_dashboards 42

Sample dashboards for Envoy that we use at Lyft

proxy-wasm/proxy-wasm-cpp-host 41

WebAssembly for Proxies (C++ host implementation)

envoyproxy/envoy-openssl 17

Envoy OpenSSL extensions

cncf/project-template 10

CNCF Project Template

mattklein123/http-parser 2

http request/response parser for c

push eventenvoy-mobile/envoy-mobile.github.io

envoy-mobile-docs(ci)

commit sha f9c35aa0ecbb4848b4e3599a7c70acc88d3d10a3

docs envoy-mobile@cac1c1445861774884ced1c7e6297683e0bc4168

view details

push time in 9 hours

push eventenvoyproxy/envoy

Rohit Agrawal

commit sha 01b90ef20f0cdb4c81f23f689bc22488641c9987

proto: add a new field called append_action in the HeaderValueOption (#18246) Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>

view details

push time in 12 hours

PR merged envoyproxy/envoy

proto: add a new field called append_action in the HeaderValueOption

This PR adds a new field called append_action to the HeaderValueOption. This is just the .proto change being done in the preparation for #18130. We'll mark the existing append field as deprecated in #18310.

append_action extends the header matcher by describing what append action to take indicating whether:

  1. The formatted header should be added only if it's not already present;
  2. New value should be appended to the existing values if header already exists; or
  3. New value should be overwritten by discarding any existing values if header already exists;

Commit Message: add a new field called append_action in the HeaderValueOption. Additional Description: Adds a new field called append_action in HeaderValueOption which will ultimately deprecate the old append and will extend the existing matcher functionality. Risk Level: - Testing: - Docs Changes: N/A (Will be done in #18130) Release Notes: N/A (Will be done in #18130) Platform Specific Features: N/A

Signed-off-by: Rohit Agrawal rohit.agrawal@databricks.com

+21 -0

5 comments

1 changed file

agrawroh

pr closed time in 12 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentenvoyproxy/envoy

Disable sigaltstack on Apple platforms

 void SignalAction::sigHandler(int sig, siginfo_t* info, void* context) { }  void SignalAction::installSigHandlers() {+#if !defined(__APPLE__)

Can you add comments on why this is disabled for apple?

keith

comment created time in 12 hours

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentenvoyproxy/envoy

api: remove [:alpha] protodoc tag and replace with annotation

 def visit_file(self, file_proto, type_context, services, msgs, enums):         if not has_messages:             header = ':orphan:\n\n' + header         warnings = ''-        if file_proto.options.HasExtension(status_pb2.file_status):-            if file_proto.options.Extensions[status_pb2.file_status].work_in_progress:-                warnings += (-                    '.. warning::\n   This API is work-in-progress and is '-                    'subject to breaking changes.\n\n')+        added_wip_warning = False+        if file_proto.options.HasExtension(udpa_status_pb2.file_status):+            if file_proto.options.Extensions[udpa_status_pb2.file_status].work_in_progress:+                added_wip_warning = True+                warnings += WIP_WARNING+        if not added_wip_warning and file_proto.options.HasExtension(xds_status_pb2.file_status):+            if file_proto.options.Extensions[xds_status_pb2.file_status].work_in_progress:+                warnings += WIP_WARNING

AFAICT there are no protodoc tests. cc @phlax if I am missing them.

I agree having tests would be nice, but I would prefer to not block on that for this change. Can I open a help wanted issue to track?

mattklein123

comment created time in 12 hours

PullRequestReviewEvent

Pull request review commentenvoyproxy/envoy

api: remove [:alpha] protodoc tag and replace with annotation

 def github_url(text, type_context):     return f":repo:`{text} <api/{type_context.source_code_info.name}#L{type_context.location.span[0]}>`"  -def format_comment_with_annotations(comment, type_name=''):+def format_comment_with_annotations(comment, show_wip_warning=False):     """Format a comment string with additional RST for annotations.      Args:         comment: comment string.-        type_name: optional, 'message' or 'enum' may be specified for additional-           message/enum specific annotations.+        show_wip_warning: whether to show the work in progress warning.      Returns:         A string with additional RST from annotations.     """-    alpha_warning = ''-    if annotations.ALPHA_ANNOTATION in comment.annotations:-        experimental_warning = (-            '.. warning::\n   This API is alpha and is not covered by the :ref:`threat model <arch_overview_threat_model>`.\n\n'-        )+    wip_warning = ''+    if show_wip_warning:+        wip_warning = WIP_WARNING

Sorry what do you mean? This I think is just related to the API alpha/wip conversion?

mattklein123

comment created time in 12 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentenvoyproxy/envoy

proto: add a new field called append_action in the HeaderValueOption

 message HeaderValueOption {   option (udpa.annotations.versioning).previous_message_type =       "envoy.api.v2.core.HeaderValueOption"; +  // Describes the supported actions types to be used in :ref:`append_action <envoy_v3_api_field_config.core.v3.HeaderValueOption.append_action>`+  enum HeaderAppendAction {+    // This action will append the specified value to the existing values if the header+    // already exists. If the header doesn't exist then this will add the header with+    // specified key and value.+    APPEND_IF_EXISTS_OR_ADD = 0;++    // This action will add the header if it doesn't already exist. If the header+    // already exists then this will be a no-op.+    ADD_IF_ABSENT = 1;++    // This action will overwrite the specified value by discarding any existing values if+    // the header already exists. If the header doesn't exist then this will add the header+    // with specified key and value.+    OVERWRITE_IF_EXISTS_OR_ADD = 2;+  }+   // Header name/value pair that this option applies to.   HeaderValue header = 1 [(validate.rules).message = {required: true}];    // Should the value be appended? If true (default), the value is appended to   // existing values. Otherwise it replaces any existing values.   google.protobuf.BoolValue append = 2;++  // Describes the action taken to append/overwrite the given value for an existing header+  // or to only add this header if it's absent. Value defaults to :ref:`APPEND_IF_EXISTS_OR_ADD<envoy_v3_api_enum_value_config.core.v3.HeaderValueOption.HeaderAppendAction.APPEND_IF_EXISTS_OR_ADD>`.

Can you mark this [#not-implemented-hide] just in case it takes a bit for the other PR to land? Thank you.

/wait

agrawroh

comment created time in a day

PullRequestReviewEvent

push eventenvoyproxy/envoy

alyssawilk

commit sha 5a20583bd7a86bf4055d8b76ab5d2459e6621471

test: moving redirect extensions test out of core (#18214) Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

view details

push time in a day

PR merged envoyproxy/envoy

test: moving redirect extensions test out of core

Risk Level: n/a Testing: n/a Docs Changes: n/a Release Notes: n/a Part of https://github.com/envoyproxy/envoy/issues/9953

+328 -222

0 comment

7 changed files

alyssawilk

pr closed time in a day

push eventenvoyproxy/envoy

Yao Zengzeng

commit sha 5ac48ba67037a26aa858cde134d887c85b7dd1e0

log: make log of listener filters consistent. (#18232) Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>

view details

push time in a day

PR merged envoyproxy/envoy

log: make log of listener filters consistent.

Signed-off-by: YaoZengzeng yaozengzeng@huawei.com

<!-- !!!ATTENTION!!!

If you are fixing any crash or any potential security issue, do not open a pull request in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately. Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the relevant section in PULL_REQUESTS.md -->

Commit Message: Additional Description: Risk Level: Testing: Docs Changes: Release Notes: Platform Specific Features: [Optional Runtime guard:] [Optional Fixes #Issue] [Optional Deprecated:] [Optional API Considerations:]

+2 -2

1 comment

2 changed files

YaoZengzeng

pr closed time in a day

push eventenvoyproxy/envoy

Snow Pettersen

commit sha 9f16bbb088dd108290ffa52ba5067fd36bdd50f3

network: set failure reason for transport socket connect timeout (#18244) Signed-off-by: Snow Pettersen <snowp@lyft.com>

view details

push time in a day

PR merged envoyproxy/envoy

network: set failure reason for transport socket connect timeout

Signed-off-by: Snow Pettersen snowp@lyft.com

Risk Level: Low Testing: Updated UT Docs Changes: n/a Release Notes: n/a

+2 -0

2 comments

2 changed files

snowp

pr closed time in a day

delete branch envoyproxy/envoy

delete branch : force-refresh-upgrade-log

delete time in a day

push eventenvoyproxy/envoy

Jose Ulises Nino Rivera

commit sha 972ac8f749b2c8782fc0e2e443a71dd9e995a727

dns cache: upgrade event (#18247) Signed-off-by: Jose Nino <jnino@lyft.com>

view details

push time in a day

PR merged envoyproxy/envoy

Reviewers
dns cache: upgrade log to log event

Signed-off-by: Jose Nino jnino@lyft.com

+2 -1

0 comment

1 changed file

junr03

pr closed time in a day

PullRequestReviewEvent

pull request commentenvoyproxy/envoy

Revert "Revert "bazel: update DEPS on googleurl (#17794)" (#17958)"

Per my other comment IMO let's merge it all together into something that theoretically will work on all platforms.

mattklein123

comment created time in a day

Pull request review commentenvoyproxy/envoy

bazel: Fix googleurl on Android

 index 6651220..a469c19 100644  #else  #define REINITIALIZES_AFTER_MOVE  #endif+diff --git a/base/containers/checked_iterators.h b/base/containers/checked_iterators.h+index b5fe925..31aa81e 100644+--- a/base/containers/checked_iterators.h++++ b/base/containers/checked_iterators.h+@@ -237,9 +237,11 @@ using CheckedContiguousConstIterator = CheckedContiguousIterator<const T>;+ // [3] https://wg21.link/pointer.traits.optmem+ namespace std {+ ++#ifdef SUPPORTS_CPP_17_CONTIGUOUS_ITERATOR

Can you add some comment here in the patch just to indicate what is going on / what the implication of this is? Also, are we tracking this upstream in any way? cc @RenjieTang @dio @yanavlasov

keith

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent