profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/mattiase/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

mattiase/xr 38

Inverse of rx: convert Emacs string regexps to rx form

mattiase/relint 21

Elisp regexp lint tool

mattiase/wraptest 2

Test of DEC VT terminal line-wrapping semantics

mattiase/haskell-mode 0

Emacs mode for Haskell

mattiase/merlin 0

Context sensitive completion for OCaml in Vim and Emacs

mattiase/regexp-disasm 0

Emacs regexp bytecode disassembler

mattiase/ripgrep 0

ripgrep recursively searches directories for a regex pattern while respecting your gitignore

mattiase/tuareg 0

Emacs OCaml mode

pull request commentBurntSushi/ripgrep

Reflow help text to fit within 80 columns

It appears that the -h help text would benefit from a similar treatment but before I extend the PR to handle that, it would be good to know that we agree on the basics to avoid wasting your time and mine.

mattiase

comment created time in 8 days

PR opened BurntSushi/ripgrep

Reflow help text to fit within 80 columns

The --help text was unnecessarily hard to read in an 80 column terminal window (which is the default on many systems, for reasons good and bad). This change reflows the paragraphs so that they fit.

As the text is printed with 12 spaces indentation, the maximum paragraph line length is 68 characters. Some people prefer not using the last (80th) column because older terminals may have trouble showing such lines without wrapping; I didn't care about that but if you do, I'll readjust.

Similarly, there are good reasons for using even shorter text lines in prose; man leaves a few more columns empty at the right margin for reasons of legibility and aesthetics. That might be a good idea here, too.

I don't think full justification in monospaced text is, well, justified but again some people like it -- do tell.

+728 -615

0 comment

1 changed file

pr created time in 11 days

create barnchmattiase/ripgrep

branch : reflow-help

created branch time in 11 days

fork mattiase/ripgrep

ripgrep recursively searches directories for a regex pattern while respecting your gitignore

fork in 11 days

pull request commentocaml/tuareg

Fix indentation and paragraph-fill inside comments

(re)<sup>2</sup>based!

mattiase

comment created time in 13 days

push eventmattiase/tuareg

Christophe Troestler

commit sha 0fd958855994eceb5019cf985022118d5295005e

README: mention NonGNU ELPA

view details

Christophe Troestler

commit sha 9f488402a447bec27f0f92406846a5292f0ee02a

README: Remove duplicate bug report URL

view details

Christophe Troestler

commit sha a156d04bff3a096635c88d29cfd51fea29104583

Faster after comment detection & match comment delimiters

view details

Christophe Troestler

commit sha 50309aed6931d1e8c07369b4dc382ffaa6d4cd05

Enable to turn off the delimiters matching (show-paren) for comments

view details

Christophe Troestler

commit sha cbe70dad979edb285df0f4c162e98e981d1d6427

Remove conditional use of add-function, available on Emacs ≥ 24.4

view details

Christophe Troestler

commit sha fe105336997a7b2eef4c46c6ac01fb45f6ca39d1

Document recent changes

view details

Christophe Troestler

commit sha c9bbe95e617e49f1d9611cb61d645106dc8662cb

Better comment delimiter match using `syntax-ppss' In particular, in a string, say "(* tata *)", comment delimiters are not matched.

view details

Christophe Troestler

commit sha 00faf47a7c65e4cdcf040f38add1c6a08cd2ee2f

Use uniform argument names for :around advice

view details

Mattias Engdegård

commit sha 1a9b3ec438d2a100cfc98f46fee60242ee4c9dbc

Fix indentation and paragraph-fill inside comments Inside comments, explicit indentation as well as the automatic indentation with electric-indent-mode active (just pressing RET, in Emacs 28) now use the indentation of the previous nonempty line, even when that line is on the same line as the initial `(*`. Filling paragraphs with M-q inside a comment now only fills a single paragraph instead of the entire comment. On an empty line, the preceding paragraph is used. Inside doc comments, lines starting with @-tags (like `@param`) start a paragraph, and subsequent lines are indented to the text after the tag. Fixes #213.

view details

Mattias Engdegård

commit sha 402649aaf024bfd614d033da7a131f0c191c660c

Indent lines under @-tags by 2 spaces ... instead of the original (1 + length of @-tag) spaces.

view details

push time in 13 days

pull request commentocaml/tuareg

Describe some recent changes in CHANGES.md

Rebased around your latest changes, with some minor clean-ups of how key bindings are mentioned; hope that is all right.

mattiase

comment created time in 13 days

push eventmattiase/tuareg

Mattias Engdegård

commit sha e7c49c6f8f6ec7d3c046525e6dc626621371c434

Copy-edit key bindings in CHANGES.md Use established Emacs style (space between subsequent keystrokes) for consistency and readability. Drop the `<>` because it annoyed Markdown.

view details

push time in 13 days

push eventmattiase/tuareg

Christophe Troestler

commit sha 0fd958855994eceb5019cf985022118d5295005e

README: mention NonGNU ELPA

view details

Christophe Troestler

commit sha 9f488402a447bec27f0f92406846a5292f0ee02a

README: Remove duplicate bug report URL

view details

Christophe Troestler

commit sha a156d04bff3a096635c88d29cfd51fea29104583

Faster after comment detection & match comment delimiters

view details

Christophe Troestler

commit sha 50309aed6931d1e8c07369b4dc382ffaa6d4cd05

Enable to turn off the delimiters matching (show-paren) for comments

view details

Christophe Troestler

commit sha cbe70dad979edb285df0f4c162e98e981d1d6427

Remove conditional use of add-function, available on Emacs ≥ 24.4

view details

Christophe Troestler

commit sha fe105336997a7b2eef4c46c6ac01fb45f6ca39d1

Document recent changes

view details

Christophe Troestler

commit sha c9bbe95e617e49f1d9611cb61d645106dc8662cb

Better comment delimiter match using `syntax-ppss' In particular, in a string, say "(* tata *)", comment delimiters are not matched.

view details

Christophe Troestler

commit sha 00faf47a7c65e4cdcf040f38add1c6a08cd2ee2f

Use uniform argument names for :around advice

view details

Mattias Engdegård

commit sha 1ccf7daad164264de55fc9100679ee261d728fc7

Describe some recent changes in CHANGES.md

view details

Mattias Engdegård

commit sha f2f6dc20d6b754d090c7bb5b51b2c3929538c138

Copy-edit key bindings in CHANGES.md Use established Emacs style (space between subsequent keystrokes, modifiers outside `<>`) for consistency and readability.

view details

push time in 13 days

push eventmattiase/tuareg

Christophe Troestler

commit sha 0fd958855994eceb5019cf985022118d5295005e

README: mention NonGNU ELPA

view details

Christophe Troestler

commit sha 9f488402a447bec27f0f92406846a5292f0ee02a

README: Remove duplicate bug report URL

view details

Christophe Troestler

commit sha a156d04bff3a096635c88d29cfd51fea29104583

Faster after comment detection & match comment delimiters

view details

Christophe Troestler

commit sha 50309aed6931d1e8c07369b4dc382ffaa6d4cd05

Enable to turn off the delimiters matching (show-paren) for comments

view details

Christophe Troestler

commit sha cbe70dad979edb285df0f4c162e98e981d1d6427

Remove conditional use of add-function, available on Emacs ≥ 24.4

view details

Christophe Troestler

commit sha fe105336997a7b2eef4c46c6ac01fb45f6ca39d1

Document recent changes

view details

Christophe Troestler

commit sha c9bbe95e617e49f1d9611cb61d645106dc8662cb

Better comment delimiter match using `syntax-ppss' In particular, in a string, say "(* tata *)", comment delimiters are not matched.

view details

Christophe Troestler

commit sha 00faf47a7c65e4cdcf040f38add1c6a08cd2ee2f

Use uniform argument names for :around advice

view details

push time in 13 days

issue commentocaml/merlin

Emacs: highlight matching {begin,struct,sig}…end blocks

Actually Tuareg attempts to do that and it should work for the keyword pairs that you mention. Try enabling show-paren-mode if you haven't already, and consider using a newer Tuareg (possibly the development version from Github; it is stable enough for daily use).

MisterDA

comment created time in 13 days

pull request commentocaml/tuareg

Comment delimiters matching

I agree with Stefan – there are merits both in matching the brackets in "(* tata *) and in not doing so. For some possible nuance, I'd prefer bracket matching inside string literals to be made entirely as if it were plain text, not OCaml code. Thus "(* tata *) would highlight the round brackets but not the stars, "[| tata |] the square brackets but not the pipes, and so on. Not sure how easy this would be to accomplish!

Chris00

comment created time in 14 days

pull request commentocaml/tuareg

Describe some recent changes in CHANGES.md

I'll rebase.

And I just noticed that I've incorrectly put the new entries under version 2.2.0; I suppose there should be a new heading for 2.3.0 (2.4.0?) for any additions – is that right?

mattiase

comment created time in 15 days

PR opened ocaml/tuareg

Describe some recent changes in CHANGES.md

I've neglected updating CHANGES.md; here is a set of new entries covering most of what I've been up to. Please tell me if there is a specific style you would like my changes to adhere to.

+35 -0

0 comment

1 changed file

pr created time in 15 days

push eventmattiase/tuareg

Mattias Engdegård

commit sha 6e2cb03869e77d5d9dd3c38d495a57b655d998a4

Describe some recent changes in CHANGES.md

view details

push time in 15 days

push eventmattiase/tuareg

Mattias Engdegård

commit sha 9188c0159aab4a015e59a6d63a885b934dce583d

More copy-editing

view details

push time in 15 days

push eventmattiase/tuareg

Mattias Engdegård

commit sha 19ccba6f807bdcb505ce718b8e07091a981bdaff

Copy-editing

view details

push time in 15 days

push eventmattiase/tuareg

Mattias Engdegård

commit sha 08c8821908ac5cad20eaebb900cc1dc43c853b11

Amend CHANGES.md with some recent changes

view details

push time in 15 days

create barnchmattiase/tuareg

branch : changes-changes

created branch time in 15 days

Pull request review commentocaml/tuareg

Comment delimiters matching

 expansion at run-time, if the run-time version of Emacs does know this macro." (defvar show-paren-data-function); Silence the byte-compiler  (defun tuareg--show-paren (orig-fun)-  (if (or (tuareg--point-before-comment-p) (tuareg--point-after-comment-p))-      nil-    (funcall orig-fun)))+  "Advice for `show-paren-data-function' to match comment delimiters."+  (let ((here (point))+        there)+    (cond+     ;; Immediately after end of a comment?+     ((and (eq (char-before) ?\))+           (eq (char-before (1- here)) ?*)+           (save-excursion (forward-comment -1)+                           (setq there (point))+                           (forward-comment 1)+                           (eq here (point))))

See previous comment. (And where did those setqs come from? Not from my (otherwise flawed) patch...)

Chris00

comment created time in 15 days

Pull request review commentocaml/tuareg

Comment delimiters matching

 See `ff-other-file-alist'."   :group 'tuareg   :type '(repeat (list regexp (choice (repeat string) function)))) +(defcustom tuareg-comment-show-paren t+  "If t, highlight the dilimiters of comments when

Spelling: "delimiters". And Emacs standard is to try to cram an entire descriptive sentence on the first line (because it's the one displayed by eldoc etc); might try something like

"Highlight comment delimiters in `show-paren-mode' if non-nil."
Chris00

comment created time in 15 days

PullRequestReviewEvent

Pull request review commentocaml/tuareg

Comment delimiters matching

 Valid names are `browse-url', `browse-url-firefox', etc."   "Return non-nil if point is inside an OCaml literal or comment."   (nth 8 (syntax-ppss pos))) +(defun tuareg--point-after-comment-p ()+  "Return non-nil if a comment (possibly inside another one)+precedes the point."+  (and (eq (char-before) ?\))+       (eq (char-before (1- (point))) ?*)+       (save-excursion+         (let ((pt (point)))+           ;; A solution based on a single call to `syntax-ppss'+           ;; takes > 1.5 the time of the following one.+           (forward-comment -1)+           (forward-comment 1)+           (eq pt (point))))))

There is a missing and inside the let here, without which the return values of the calls to forward-comment are ignored and that cannot have been the intent. However, I think Stefan is right in that the second forward-comment really isn't necessary: I cannot think of a case where it (and the subsequent comparison) would make a difference.

That said, this algorithm gives a false positive for comments inside string literals, such as after

"(* tata *)

thus a different approach is probably necessary; I don't think matching comments inside string literals would be a feature. I'm the one to blame for this – sorry for leading you astray! As mentioned before, the checks for the *) characters do the heavy lifting here so the cost of syntax-ppss is probably not intolerable in that context.

Chris00

comment created time in 15 days

PullRequestReviewEvent

issue commentocaml/merlin

Emacs bindings

My mistake, sorry. I always use C-M-x because it's faster to type!

Chris00

comment created time in 16 days

issue commentocaml/merlin

Emacs bindings

And as an alternative binding for merlin-destruct, C-c C-e seems to be free -- E for Explode?

Chris00

comment created time in 16 days

delete branch mattiase/merlin

delete branch : tre

delete time in 16 days

PR opened ocaml/merlin

Emacs Xref improvements

Fix uses of Xref from mouse events, such as the context menu new in Emacs 28, by implementing the necessary methods and smuggle the buffer position in a text property of the string.

We also get better highlighting of Xref hits in the target buffer by taking advantage of a bug fixed in Emacs 28.

+27 -7

0 comment

1 changed file

pr created time in 16 days

create barnchmattiase/merlin

branch : tre

created branch time in 16 days

create barnchmattiase/merlin

branch : xref

created branch time in 16 days