profile
viewpoint

beling/book-pl 5

Język Programowania Rust

mati865/cargo-edition-test 1

Nothing to see here; just some bugs

mati865/actix-web 0

Actix web is a small, pragmatic, and extremely fast rust web framework.

mati865/aports 0

Mirror of aports repository

mati865/backtrace-rs 0

Backtraces in Rust

mati865/browser-laptop 0

Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux

issue commentrust-lang/rust

Do not unwind on Windows with panic=abort

Anyone know whether LLVM added that intrinsic yet, or if there is an issue somewhere for that?

It's only implemented as Clang builtin, so no change for Rust.

Zoxc

comment created time in 2 hours

issue commentmsys2/MINGW-packages

h5py import failure: "DLL load failed while importing defs"

Does it work if you rebuild h5py?

sbourdeauducq

comment created time in 15 hours

pull request commentrust-lang/rust

[beta] next

LLVM is cached with sscache.

Mark-Simulacrum

comment created time in 17 hours

issue commentmsys2/MINGW-packages

libgsf package emits PE that triggers security scan

@salowenh because various LD versions had problem with it.

salowenh

comment created time in a day

delete branch mati865/MINGW-packages

delete branch : clang-fixes

delete time in a day

pull request commentrust-lang/rust

update miri

Yeah using the command you have provided.

RalfJung

comment created time in 2 days

pull request commentrust-lang/rust

update miri

With miri at eee22ffddab20f51e1866bcbe4c5a69a90bdd260 it's tests pass on native windows-gnu.

RalfJung

comment created time in 2 days

pull request commentmsys2/MINGW-packages

Few LLVM fixes

Yes but fixed libc++ has to land in the repo first. Then LLVM can be build with Clang and libc++ without hitting #6126.

mati865

comment created time in 2 days

issue commentmstorsjo/llvm-mingw

shared link llvm (this is a discussion not a issue)

I've backported the patches that fix the build it and I'm testing the toolchain (with -DLLVM_LINK_LLVM_DYLIB=TRUE) with libc++ instead of libstdc++. Expectedly I haven't encountered winpthreads bug that was causing LLD to hang (https://github.com/msys2/MINGW-packages/issues/6126).

SquallATF

comment created time in 2 days

issue commentrust-lang/rust

windows-gnu target compatibility with toolchains providing LLVM tools only

I wanted to avoid new target if possible because we will definitely need new target to allow linking with UCRT instead of MSVCRT since one cannot mix libraries build with UCRT and MSVCRT.

Okay, seems like this will need separate target (GCC's emutls vs Clang's native TLS is a good example). Instead we could avoid creating separate MSVCRT vs UCRT targets for each compiler until somebody needs them. Windows-gnu would keep MSVCRT as the default and new MinGW clang toolchain would use UCRT.

Should I close this issue and open another one or MCP for the new target?

mati865

comment created time in 2 days

pull request commentmsys2/MINGW-packages

Few LLVM fixes

This PR makes libc++ depend on libunwind instead of libgcc_s. I think the biggest benefit from it is avoiding winpthreads (and it's bugs) but at the cost of additional DLL. That said I'm not sure whether libc++ should use libunwind or libgcc.

With this fixed libc++ I was able to link LLVM dynamically without hangs we had previously (https://github.com/msys2/MINGW-packages/issues/6126).

mati865

comment created time in 2 days

issue commentrust-lang/rust

error: failed to read `/home/amcap1712/vlc-meson/extras/tools/native/rust/src/tools/clippy/Cargo.toml

I think using archives from Releases page is unsupported because they were automatically created by GitHub and are missing things like submodules and vendored directory.

Please use link from previous comment.

amCap1712

comment created time in 3 days

issue commentrust-lang/rust

tidy: Remove from EXCEPTIONS list if it is no longer used.

They are used by some of the targets. Maybe it'd work if --all-targets was passed to the Cargo?

lzutao

comment created time in 3 days

issue commentmsys2/MSYS2-packages

[BUG] To install zstd you need zstd

@bga you should update core packages first with pacman -Syuu.

bga

comment created time in 3 days

issue commentmsys2/MSYS2-packages

[BUG] To install zstd you need zstd

^ also zstd package is still in pkg.tar.xz format. mingw-w64-$CARCH-zstd are not used for decompression.

bga

comment created time in 3 days

issue commentmstorsjo/llvm-mingw

shared link llvm (this is a discussion not a issue)

Now that MSYS2 is getting working libc++ I tried to link LLVM in shared mode but it fails with both LLD and LD:

[ 74%] Linking CXX executable ../../bin/llvm-cfi-verify.exe
clang++: warning: argument unused during compilation: '-Wa,-mbig-obj' [-Wunused-command-line-argument]
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSymbolize.a(Symbolize.cpp.obj):Symbolize.cpp:(.text+0x1200): multiple definition of `llvm::symbolize::LLVMSymbolizer::flush()'; ../../lib/libLLVM.dll.a(d037264.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(CommandLine.cpp.obj):CommandLine.cpp:(.text+0x370): multiple definition of `llvm::cl::Option::addArgument()'; ../../lib/libLLVM.dll.a(d025512.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(CommandLine.cpp.obj):CommandLine.cpp:(.text+0x590): multiple definition of `llvm::cl::GenericOptionValue::anchor()'; ../../lib/libLLVM.dll.a(d025211.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(CommandLine.cpp.obj):CommandLine.cpp:(.text+0xce0): multiple definition of `llvm::cl::Option::setArgStr(llvm::StringRef)'; ../../lib/libLLVM.dll.a(d025521.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(CommandLine.cpp.obj):CommandLine.cpp:(.text+0x3ea0): multiple definition of `llvm::cl::ParseCommandLineOptions(int, char const* const*, llvm::StringRef, llvm::raw_ostream*, char const*, bool)'; ../../lib/libLLVM.dll.a(d025225.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(Error.cpp.obj):Error.cpp:(.text+0x20): multiple definition of `llvm::logAllUnhandledErrors(llvm::Error, llvm::raw_ostream&, llvm::Twine)'; ../../lib/libLLVM.dll.a(d021969.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(MemoryBuffer.cpp.obj):MemoryBuffer.cpp:(.text+0x410): multiple definition of `llvm::MemoryBuffer::getFile(llvm::Twine const&, long long, bool, bool)'; ../../lib/libLLVM.dll.a(d007903.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(NativeFormatting.cpp.obj):NativeFormatting.c:(.text+0xa0): multiple definition of `llvm::write_integer(llvm::raw_ostream&, unsigned long long, unsigned long long, llvm::IntegerStyle)'; ../../lib/libLLVM.dll.a(d010343.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(NativeFormatting.cpp.obj):NativeFormatting.c:(.text+0x310): multiple definition of `llvm::write_hex(llvm::raw_ostream&, unsigned long long, llvm::HexPrintStyle, llvm::Optional<unsigned long long>)'; ../../lib/libLLVM.dll.a(d037278.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(NativeFormatting.cpp.obj):NativeFormatting.c:(.text+0x430): multiple definition of `llvm::write_double(llvm::raw_ostream&, double, llvm::FloatStyle, llvm::Optional<unsigned long long>)'; ../../lib/libLLVM.dll.a(d008877.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(NativeFormatting.cpp.obj):NativeFormatting.c:(.text+0x8b0): multiple definition of `llvm::getDefaultPrecision(llvm::FloatStyle)'; ../../lib/libLLVM.dll.a(d020504.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(NativeFormatting.cpp.obj):NativeFormatting.c:(.text+0x8d0): multiple definition of `llvm::isPrefixedHexStyle(llvm::HexPrintStyle)'; ../../lib/libLLVM.dll.a(d018354.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(SpecialCaseList.cpp.obj):SpecialCaseList.cp:(.text+0x390): multiple definition of `llvm::SpecialCaseList::create(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, llvm::vfs::FileSystem&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&)'; ../../lib/libLLVM.dll.a(d013412.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(SpecialCaseList.cpp.obj):SpecialCaseList.cp:(.text+0x18c0): multiple definition of `llvm::SpecialCaseList::inSectionBlame(llvm::StringRef, llvm::StringRef, llvm::StringRef, llvm::StringRef) const'; ../../lib/libLLVM.dll.a(d040408.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(StringRef.cpp.obj):StringRef.cpp:(.text+0x80): multiple definition of `llvm::StringRef::startswith_lower(llvm::StringRef) const'; ../../lib/libLLVM.dll.a(d050131.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(StringRef.cpp.obj):StringRef.cpp:(.text+0xfe0): multiple definition of `llvm::StringRef::split(llvm::SmallVectorImpl<llvm::StringRef>&, char, int, bool) const'; ../../lib/libLLVM.dll.a(d050139.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(StringRef.cpp.obj):StringRef.cpp:(.text+0x1280): multiple definition of `llvm::consumeUnsignedInteger(llvm::StringRef&, unsigned int, unsigned long long&)'; ../../lib/libLLVM.dll.a(d022407.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(StringRef.cpp.obj):StringRef.cpp:(.text+0x1620): multiple definition of `llvm::getAsUnsignedInteger(llvm::StringRef, unsigned int, unsigned long long&)'; ../../lib/libLLVM.dll.a(d021197.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(VirtualFileSystem.cpp.obj):VirtualFileSystem.:(.text+0x480): multiple definition of `llvm::vfs::getRealFileSystem()'; ../../lib/libLLVM.dll.a(d028798.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(raw_ostream.cpp.obj):raw_ostream.cpp:(.text+0x120): multiple definition of `llvm::raw_ostream::operator<<(unsigned long)'; ../../lib/libLLVM.dll.a(d005245.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(raw_ostream.cpp.obj):raw_ostream.cpp:(.text+0x160): multiple definition of `llvm::raw_ostream::operator<<(unsigned long long)'; ../../lib/libLLVM.dll.a(d005247.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(raw_ostream.cpp.obj):raw_ostream.cpp:(.text+0x880): multiple definition of `llvm::raw_ostream::write(char const*, unsigned long long)'; ../../lib/libLLVM.dll.a(d005220.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(raw_ostream.cpp.obj):raw_ostream.cpp:(.text+0xb10): multiple definition of `llvm::raw_ostream::operator<<(llvm::formatv_object_base const&)'; ../../lib/libLLVM.dll.a(d005238.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(raw_ostream.cpp.obj):raw_ostream.cpp:(.text+0xe20): multiple definition of `llvm::raw_ostream::operator<<(llvm::FormattedNumber const&)'; ../../lib/libLLVM.dll.a(d005235.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(raw_ostream.cpp.obj):raw_ostream.cpp:(.text+0x1cd0): multiple definition of `llvm::outs()'; ../../lib/libLLVM.dll.a(d029325.o):(.text+0x0): first defined here
D:\msys64\mingw64\bin\ld: ../../lib/libLLVMSupport.a(raw_ostream.cpp.obj):raw_ostream.cpp:(.text+0x1d60): multiple definition of `llvm::errs()'; ../../lib/libLLVM.dll.a(d029236.o):(.text+0x0): first defined here
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [tools/llvm-cfi-verify/CMakeFiles/llvm-cfi-verify.dir/build.make:123: bin/llvm-cfi-verify.exe] Error 1
make[1]: *** [CMakeFiles/Makefile2:111215: tools/llvm-cfi-verify/CMakeFiles/llvm-cfi-verify.dir/all] Error 2
SquallATF

comment created time in 3 days

PR opened msys2/MINGW-packages

Few LLVM fixes

Fixes https://github.com/msys2/MINGW-packages/issues/6422 Fixes https://github.com/msys2/MINGW-packages/issues/6605 Fixes https://github.com/msys2/MINGW-packages/issues/6607

+472 -55

0 comment

5 changed files

pr created time in 3 days

push eventmati865/MINGW-packages

Mateusz Mikuła

commit sha bf1a765c236e19c0a59cc2c73d72c2ed80167cf0

Build shared and static libc++

view details

Mateusz Mikuła

commit sha 403ff23a3f355f80653c26c5903b4f9a8e427d30

drop -j1 from install

view details

Mateusz Mikuła

commit sha ced57b2b3743a7bb96ad4824bae78fd48efb271f

Bump pkgrel

view details

push time in 3 days

push eventmati865/MINGW-packages

Mateusz Mikuła

commit sha 2b8457406b3106a4abb32908636c30aab34f261a

Build shared and static libc++

view details

Mateusz Mikuła

commit sha e2c5681cdb82e2375eba6eb7a616520703f2436a

drop -j1 from install

view details

Mateusz Mikuła

commit sha 0e13f927c72a59e2719e9968a89881f9a1536f1c

Bump pkgrel

view details

push time in 3 days

push eventmati865/MINGW-packages

Mateusz Mikuła

commit sha 3d643b8e7f7535173996923c311116d3a0b81e0c

Do not move projects into LLVM tree

view details

Mateusz Mikuła

commit sha dd2f427a23190f54158adc1bb27a3e60a1080872

Add missing Lua dependency for LLDB

view details

Mateusz Mikuła

commit sha 248eb292f13ca848c9436b491b456e81dbbb9367

Build shared and static libc++

view details

Mateusz Mikuła

commit sha b04fef7e910f6a7119d8bfe8df982f554a2d0a16

drop -j1 from install

view details

Mateusz Mikuła

commit sha 85a947e3e2785c7699bac15e1130b00d60241fc6

Bump pkgrel

view details

push time in 3 days

push eventmati865/MINGW-packages

Mateusz Mikuła

commit sha e397d4b79b3f968ff6c2d7d9c3c19b7f3ce5729b

Do not move projects into LLVM tree

view details

Mateusz Mikuła

commit sha c270529506f82efdaab9d779ec2b39bb484a3a82

Add missing Lua dependency for LLDB

view details

Mateusz Mikuła

commit sha 0b9e972ffbf06dbaf606ceb1448c69a64ec1f23f

Build shared and static libc++

view details

Mateusz Mikuła

commit sha 5f3b6564ab2ff2aaea448da8480fff1f4cf4455d

Remove fixed TODO

view details

Mateusz Mikuła

commit sha 52ab3a6a888d31441f12157b5dbcc3e1f116e7db

drop -j1 from install

view details

push time in 3 days

push eventmati865/MINGW-packages

Mateusz Mikuła

commit sha 7211ffb882cc3b7e7583c518aad45a22b278bc81

Fix 32bit build (#6548)

view details

Oleg A. Khlybov

commit sha 11b4cff3d2ec7411037b692b0ad5a9f3e9b9978d

Added a workaround for the GCC 10 FORTRAN's increased strictness. (#6550)

view details

Alexey Pavlov

commit sha 53251409d9738b95c8dc8888d222fe3747e3f8af

qt-installer-framework: Update to 3.2.3

view details

Alexey Pavlov

commit sha bf3c56b529cfa609e1484c05e09e168c9920ff77

libgpg-error: Update to 1.38

view details

Alexey Pavlov

commit sha 11a826166fc5a1f6bc3816b45e70b260f102621e

boost: Fix makedeps, rename python3 stuff

view details

Alexey Pavlov

commit sha ddd4f4cbdb931f3d521504bb4d98da96fc327318

dlib: Fix linking flags in pkg-config files

view details

Konstantin Podsvirov

commit sha ff75f742f1ee97f2668499bdb1a95a02b6ea4ae5

coin: New package (#6543)

view details

Konstantin Podsvirov

commit sha c14b7351fd4d8c16929b1d5cb0c8c2b8f0a0542a

soqt: New package (#6544) * coin: New package * soqt: New package

view details

Alexey Pavlov

commit sha b5cdf5f9ac766f26135bf4807f7ba26b18564d5c

soqt: Fix build

view details

Alexey Pavlov

commit sha e6edb24095cc2878a98f3f1d0f223e7d2dfa55c0

libksba: Update to 1.4.0

view details

Christoph Reiter

commit sha 31a8ea4d620570835835540e4049f42e16aad451

Revert "appveyor: Update pacman first" This reverts commit 386d87efad5e034913212022f51a54449b20b4a5.

view details

Norbert Pfeiler

commit sha d0194c3defbfe8571430569c87d9808680e932d0

qt-creator: Update to 4.12.2 (#6551)

view details

Christopher Degawa

commit sha ce14972306400adb64d3967e57f78b0a12c3be88

FFmpeg: Add dav1d (#6552) * FFmpeg: Add dav1d Signed-off-by: Christopher Degawa <ccom@randomderp.com> * temp commit to find error in ffmpeg

view details

Alexey Pavlov

commit sha 3f81afc23bdb9e255f9e21252c09d7872be4f78f

ffmpeg: Rebuild

view details

Alexey Pavlov

commit sha 0089135c987f88240ef155995783388ddadb48b1

harfbuzz: Fix dependencies

view details

Alexey Pavlov

commit sha 9e8c05014a30605272cfe49391e86d79e49367c6

liblas: Fix build. Install pkg-config file

view details

Alexey Pavlov

commit sha 98bfa64998ac2e7fe9b8ccef336896a6e0a892eb

openvdb: Fix find cppunit

view details

Andrew Sun

commit sha 67c1b6d3b1f56d8fe330f87f8cf666aa9742475f

libntlm: update to 1.6

view details

Andrew Sun

commit sha 53b42c145b859969d45f8084ecdf14ddd1eeea52

msgpack-c: update to 3.3.0

view details

Christoph Reiter

commit sha 01412590bdac85908496658673f0e64345e8564d

Merge pull request #6556 from Adsun701/msgpack-c-3.3.0 msgpack-c: update to 3.3.0

view details

push time in 3 days

create barnchmati865/MINGW-packages

branch : clang-fixes

created branch time in 4 days

PR closed rust-lang/rust

Bootstrap: reorder tools to properly reflect their build order S-waiting-on-review

Noticed in https://github.com/rust-lang/rust/issues/74016#issuecomment-653714914

RLS depends on Clippy and Rustfmt.

+5 -5

5 comments

1 changed file

mati865

pr closed time in 4 days

pull request commentrust-lang/rust

Bootstrap: reorder tools to properly reflect their build order

Order in get_step_descriptions matters for test subcommand and I assumed dist would also follow it. Sorry for the noise.

mati865

comment created time in 4 days

pull request commentmsys2/MINGW-packages

[RFC] add GitHub Actions workflow(s)

if it's possible to do those large builds on Linux somehow, that could help.

I don't know if anything has changed in regards of Cygwin vs Wine issue but it's tracked here: https://github.com/msys2/MSYS2-packages/issues/682

eine

comment created time in 4 days

pull request commentrust-lang/rust

Bootstrap: reorder tools to properly reflect their build order

Also cc @ehuss

mati865

comment created time in 5 days

push eventmati865/rust

Mateusz Mikuła

commit sha 7c6258d669499633c8a8ecc0121bb18edb65b76a

Bootstrap: reorder tools to properly reflect their build order

view details

push time in 5 days

push eventmati865/rust

djugei

commit sha b4337ab8c387658b7012fa242e429f46c5f31141

added .collect() into String from Box<str> with fake feature/stability annotation

view details

Tomasz Miąsko

commit sha 291dce91b24d70382ebf1116fa836fd91960de84

Fallback to xml.etree.ElementTree The xml.etree.cElementTree has been deprecated since Python 3.3 and removed in Python 3.9 https://bugs.python.org/issue36543.

view details

mark

commit sha 3f6928f1f6eff367e6ddbfb63ebc5e568ffe0eb1

move contributing.md to rustc-dev-guide and point at getting started

view details

Alexis Bourget

commit sha 6e8251742071d56545b6ce160ed71bb60597ee01

Documenting the separate behaviors of edition 2015 and 2018

view details

Alexis Bourget

commit sha 59701360dc0c76bfa45204d307ac5055f8bff538

Fix some small mistakes

view details

David Hewitt

commit sha 6b95f3102d657a5cd0549213a073b28c7e0fe609

Add `format_args_capture` feature

view details

Simonas Kazlauskas

commit sha df88972f8ce9ddbebec6d551810f7127fe25d2a3

Update psm version This new version includes a fix for building on aarch64 windows.

view details

Ivan Tham

commit sha f772587aba7b2be9a2fa708a26ba2605e32148ff

Add unstable docs for rustc_attrs

view details

Vadim Petrochenkov

commit sha 79a42e37084d0fc584c9f312c2a355104a113889

linker: Create GNU_EH_FRAME header by default when producing ELFs

view details

Ivan Tham

commit sha 725918f17e9a2c1e8a0ffec658d1363681f768bd

Update src/doc/unstable-book/src/language-features/rustc-attrs.md Co-authored-by: Ralf Jung <post@ralfj.de>

view details

David Hewitt

commit sha 8caf60407033e84592821a3f7b3917fe80d343e0

Improve messaging from PR feedback

view details

Vadim Petrochenkov

commit sha 7055c23d2cb3baabbae6af7ab196e43035260856

ast_pretty: Pass some token streams and trees by reference

view details

David Hewitt

commit sha a1217cb29de22aae3cda717e78d1edd3e9d8ffd1

Add `format_args_capture` to the unstable book

view details

Ivan Tham

commit sha 0e6f1093be08949b6ac4ba3d92ad4e97d0137dc5

Add preamable on rustc-attrs doc discussion

view details

CAD97

commit sha db539c649866d9a25cb18a741436b3086b5d6e04

Use raw_ref_op in A|Rc::as_ptr

view details

CAD97

commit sha e4bdf47f4c0773bba93f50900612242b929eca0b

Do not require ptr validity in rc::data_offset

view details

CAD97

commit sha d8a9c61e1a23b73c04d3058a11d1b8b2a46d635e

Use impl for Weak::as_ptr that works for unsized T

view details

pierwill

commit sha 49662726afdd6f4538bada73db771b939d92bd22

Add newline to rustc MultiSpan docs Also adds back-ticks when referring to the contents of this collection.

view details

Ivan Tham

commit sha 49b4804d291bc8cc93e7b4b8c24f344aa3e3f484

Ignore example compile in rustc-attrs doc

view details

Rich Kadel

commit sha 5239a68e72d1a0c7cba2cfd219a7da911360fbb7

add spans to injected coverage counters added regions with counter expressions and counters. Added codegen_llvm/coverageinfo mod for upcoming coverage map Move coverage region collection to CodegenCx finalization Moved from `query coverageinfo` (renamed from `query coverage_data`), as discussed in the PR at: https://github.com/rust-lang/rust/pull/73684#issuecomment-649882503 Address merge conflict in MIR instrument_coverage test The MIR test output format changed for int types. moved debug messages out of block.rs This makes the block.rs calls to add coverage mapping data to the CodegenCx much more concise and readable. move coverage intrinsic handling into llvm impl I realized that having half of the coverage intrinsic handling in `rustc_codegen_ssa` and half in `rustc_codegen_llvm` meant that any non-llvm backend would be bound to the same decisions about how the coverage-related MIR terminators should be handled. To fix this, I moved the non-codegen portion of coverage intrinsic handling into its own trait, and implemented it in `rustc_codegen_llvm` alongside `codegen_intrinsic_call`. I also added the (required?) stubs for the new intrinsics to `IntrepretCx::emulate_intrinsic()`, to ensure calls to this function do not fail if called with these new but known intrinsics. address PR Feedback on 28 June 2020 2:48pm PDT

view details

push time in 5 days

PR opened rust-lang/rust

Bootstrap: reorder tools to properly reflect their build order

RLS depends on Clippy and Rustfmt

+4 -4

0 comment

1 changed file

pr created time in 5 days

create barnchmati865/rust

branch : tools-build-order

created branch time in 5 days

pull request commentmsys2/MINGW-packages

Enable Windows hypervisor support - qemu

It should not break 32 bit. Qemu uses dynamic dispatch to load Hyper-V related libraries so it doesn't need any mingw-w64 libraries that provide import symbols.

ZachBacon

comment created time in 6 days

issue commentrust-analyzer/rust-analyzer

rust-analyzer is slow to compile

Yeah, overall CPU usage looks very reasonable with exception of small 5 seconds window where only 3 threads are properly utilized.

16 thread CPU reveals some bottlenecks though: cargo-timing-20200707T103522Z.zip

matklad

comment created time in 6 days

issue commentrust-analyzer/rust-analyzer

rust-analyzer is slow to compile

@lnicola do you have up-to-date CPU usage metrics over time? Combining them with crates build chart would show bottlenecks where only a few cores are used.

matklad

comment created time in 6 days

pull request commentrust-lang/rust

Shrink ParamEnv to 16 bytes

Already reported on zulip: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/ci.20timeouts

Mark-Simulacrum

comment created time in 6 days

issue commentrust-lang/rustup

RISC-V support?

Rustup for RISC-V won't work until https://github.com/rust-lang/rust/pull/72973 is merged.

tommythorn

comment created time in 6 days

pull request commentrust-lang/rust

[beta] Backport

@Elinvynia #73136 was accepted in previous version, https://github.com/rust-lang/rust/commit/926c7b6bb53b8a30b712759eaa9641040d15caef to be exact. That's because committed version might not work with older Cargo.

As per https://github.com/rust-lang/rust/pull/73184#issuecomment-653142806 #73184 was also accepted but it's missing the label.

Elinvynia

comment created time in 7 days

pull request commentrust-lang/rust

Serialize all foreign `SourceFile`s into proc-macro crate metadata

Nice performance improvement :tada:: https://perf.rust-lang.org/compare.html?start=16957bd4d3a5377263f76ed74c572aad8e4b7e59&end=d462551a8600e57d8b6f87e71ea56868bc5da6cf&stat=instructions:u

Aaron1011

comment created time in 8 days

issue commentrust-lang/rust

rustbuild: cargo keeps being rebuilt

@ehuss they are built in this order: https://github.com/rust-lang/rust/blob/0cd7ff7ddfb75a38dca81ad3e76b1e984129e939/src/bootstrap/builder.rs#L347

In the past when Clippy was not always buildable I had added https://github.com/rust-lang/rust/blob/0cd7ff7ddfb75a38dca81ad3e76b1e984129e939/src/bootstrap/tool.rs#L653 since RLS's clippy feature works only when Clippy can build.

Reordering tools in builder.rs would remove 1 rebuild, right?

matthiaskrgr

comment created time in 9 days

issue commentmsys2/MINGW-packages

lldb cannot find libstdc++-6.dll

Use ntldd instead of ldd if you want to find missing lib.

askondro

comment created time in 9 days

pull request commentrust-lang/rust

MinGW: enable dllexport/dllimport

Added test that depends on https://github.com/rust-lang/rust/pull/74009

mati865

comment created time in 9 days

push eventmati865/rust

bors

commit sha 59493917be3e87e1dfb44a9ccb66a9f9b17228e6

Auto merge of #73266 - ehuss:update-cargo, r=ehuss Update cargo 2 commits in 1ec223effbbbf9fddd3453cdcae3a96a967608eb..79c769c3d7b4c2cf6a93781575b7f592ef974255 2020-06-09 20:03:14 +0000 to 2020-06-11 22:13:37 +0000 - Fix failure with missing readme. (rust-lang/cargo#8353) - Some LTO fixes. (rust-lang/cargo#8349)

view details

Ralf Jung

commit sha 871513d02cf4d5c40689052aa7a1f3681fc3fdcc

make miri memory TyCtxtAt a TyCtxt

view details

Ralf Jung

commit sha 416b010f4087d055febe2d55919f74e261ca8cd6

x.py: do not build Miri by default

view details

Ralf Jung

commit sha dc6ffaebd5b56793f86443a0a50c06f025321198

make miri InterpCx TyCtxtAt a TyCtxt, and separately remember the root span of the evaluation

view details

Ralf Jung

commit sha 0ac6fd0405c2f3defa9ad8ee3d4026469fbda018

fix const_prop spans and re-bless tests

view details

Ralf Jung

commit sha 32b01c78d0502c8a4cc36abbe8dc3c000436df98

avoid computing cur_span all the time

view details

LeSeulArtichaut

commit sha cd137ee33fb3343d3b5ebf28c3240f174d0dffc0

Fix Zulip pings

view details

Dylan DPC

commit sha c06799e4c4103330c972eb04f08aa72b7c1d5ace

Rollup merge of #72906 - lzutao:migrate-numeric-assoc-consts, r=dtolnay Migrate to numeric associated consts The deprecation PR is #72885 cc #68490 cc rust-lang/rfcs#2700

view details

Dylan DPC

commit sha 7c15f30701d636a7699a7ba8e7d683c351a4bb0a

Rollup merge of #72906 - lzutao:migrate-numeric-assoc-consts, r=dtolnay Migrate to numeric associated consts The deprecation PR is #72885 cc #68490 cc rust-lang/rfcs#2700

view details

Dylan DPC

commit sha 657a41fe73942006a01d67598bcbe80b8b03e69e

Rollup merge of #73178 - petrochenkov:explint, r=varkor expand: More precise locations for expansion-time lints First commit: a macro expansion doesn't have a `NodeId` associated with it, but it has a parent `DefId` which we can use for linting. The observable effect is that lints associated with macro expansions can now be `allow`ed at finer-grained level than whole crate. Second commit: each macro definition has a `NodeId` which we can use for linting, unless that macro definition was decoded from other crate.

view details

Dylan DPC

commit sha 6f9d45351031eedff0336baa20d26d789870c988

Rollup merge of #73225 - tmandry:issue-73050, r=oli-obk Allow inference regions when relating consts As first noticed by @eddyb, `super_relate_consts` doesn't need to check for inference vars since `eval` does it already (and handles lifetimes correctly by erasing them). Fixes #73050 r? @oli-obk

view details

Dylan DPC

commit sha b4cb12fd2140421e9c9a4965e247c246f3896564

Rollup merge of #73236 - GuillaumeGomez:cleanup-e0666, r=Dylan-DPC Clean up E0666 explanation r? @Dylan-DPC

view details

Dylan DPC

commit sha 77ede48ada25295cb90e520f52c1cbe653982f8a

Rollup merge of #73273 - LeSeulArtichaut:patch-1, r=Dylan-DPC Fix Zulip pings r? @Dylan-DPC

view details

Ralf Jung

commit sha b4bd180e5e330c6b3019c0d9d0ad676f07885258

fix caller_location intrinsic for Miri

view details

Wesley Wiser

commit sha f1605834a568b26bb540e743e9dd7e25d4ad9151

Disable the `SimplifyArmIdentity` pass on beta This pass is buggy so I'm disabling it to fix a stable-to-beta regression. Related to #73223

view details

bors

commit sha 7c78a5f97de07a185eebae5a5de436c80d8ba9d4

Auto merge of #73276 - Dylan-DPC:rollup-hfd81qw, r=Dylan-DPC Rollup of 5 pull requests Successful merges: - #72906 (Migrate to numeric associated consts) - #73178 (expand: More precise locations for expansion-time lints) - #73225 (Allow inference regions when relating consts) - #73236 (Clean up E0666 explanation) - #73273 (Fix Zulip pings) Failed merges: r? @ghost

view details

Dylan MacKenzie

commit sha bd4bd59ad7946f0717f1babb38a971b608fe4f3b

Helper method for whether type has structural equality This helper method works for all types, falling back to a query for `TyKind::Adt`s to determine whether the implement the `{Partial,}StructuralEq` traits.

view details

Dylan MacKenzie

commit sha 1dd45612f80e2b15d0346d4bdf8838572eeee3bf

Use "reflexive equality" in docs

view details

Dylan MacKenzie

commit sha 280176178b1449ce9ba3bc1d2b7ebf3f1d0abb6a

Make `type_marked_structural` private

view details

Ralf Jung

commit sha f0d2e78d39d0efdb431af0b59c498d532d8146e2

add raw_ref macros

view details

push time in 9 days

PR opened rust-lang/rust

Fix MinGW `run-make-fulldeps` tests

compiler-rt-works-on-mingw and libs-search-path were not ran because only-mingw doesn't match any target. Enabled and verified few ignored tests with windows-gnu toolchain. They are still ignored on MSVC since I'm not experienced with this target.

+41 -54

0 comment

11 changed files

pr created time in 9 days

create barnchmati865/rust

branch : mingw-tests-implib

created branch time in 9 days

pull request commentrust-lang/rust

Reoder order in which MinGW libs are linked to fix recent breakage

@rustbot modify labels: +beta-accepted

Label is missing.

mati865

comment created time in 10 days

pull request commentrust-lang/rust

Reoder order in which MinGW libs are linked to fix recent breakage

I should have been more explicit but

It built just fine on my PC with mingw-w64 6.3.0.

is the old mingw-w64 build (exactly the same as used on the CI).

mati865

comment created time in 10 days

push eventmati865/rust

Aaron Hill

commit sha 4646e2da2d0d3b24d1f38c9904bdb7950a658d84

Run fmt

view details

Eric Huss

commit sha 57b54c49281df9559cae4a685c0d38d62a3ee500

Use the built cargo for cargotest.

view details

bors

commit sha e91bf6c881dc8fa50dc18fc2f518a6c22424ddb5

Auto merge of #69478 - avr-rust:avr-support-upstream, r=jonas-schievink Enable AVR as a Tier 3 target upstream Tracking issue: #44052. Things intentionally left out of the initial upstream: * The `target_cpu` flag I have made the cleanup suggestions by @jplatte and @jplatte in https://github.com/avr-rust/rust/commit/043550d9db0582add42e5837f636f61acb26b915. Anybody feel free to give the branch a test and see how it fares, or make suggestions on the code patch itself.

view details

Eric Huss

commit sha 826ea22be384f2b49a99e59f92638d2ede3d1959

Update cargo

view details

bors

commit sha 59493917be3e87e1dfb44a9ccb66a9f9b17228e6

Auto merge of #73266 - ehuss:update-cargo, r=ehuss Update cargo 2 commits in 1ec223effbbbf9fddd3453cdcae3a96a967608eb..79c769c3d7b4c2cf6a93781575b7f592ef974255 2020-06-09 20:03:14 +0000 to 2020-06-11 22:13:37 +0000 - Fix failure with missing readme. (rust-lang/cargo#8353) - Some LTO fixes. (rust-lang/cargo#8349)

view details

Ralf Jung

commit sha 871513d02cf4d5c40689052aa7a1f3681fc3fdcc

make miri memory TyCtxtAt a TyCtxt

view details

Ralf Jung

commit sha 416b010f4087d055febe2d55919f74e261ca8cd6

x.py: do not build Miri by default

view details

Ralf Jung

commit sha dc6ffaebd5b56793f86443a0a50c06f025321198

make miri InterpCx TyCtxtAt a TyCtxt, and separately remember the root span of the evaluation

view details

Ralf Jung

commit sha 0ac6fd0405c2f3defa9ad8ee3d4026469fbda018

fix const_prop spans and re-bless tests

view details

Ralf Jung

commit sha 32b01c78d0502c8a4cc36abbe8dc3c000436df98

avoid computing cur_span all the time

view details

LeSeulArtichaut

commit sha cd137ee33fb3343d3b5ebf28c3240f174d0dffc0

Fix Zulip pings

view details

Dylan DPC

commit sha c06799e4c4103330c972eb04f08aa72b7c1d5ace

Rollup merge of #72906 - lzutao:migrate-numeric-assoc-consts, r=dtolnay Migrate to numeric associated consts The deprecation PR is #72885 cc #68490 cc rust-lang/rfcs#2700

view details

Dylan DPC

commit sha 7c15f30701d636a7699a7ba8e7d683c351a4bb0a

Rollup merge of #72906 - lzutao:migrate-numeric-assoc-consts, r=dtolnay Migrate to numeric associated consts The deprecation PR is #72885 cc #68490 cc rust-lang/rfcs#2700

view details

Dylan DPC

commit sha 657a41fe73942006a01d67598bcbe80b8b03e69e

Rollup merge of #73178 - petrochenkov:explint, r=varkor expand: More precise locations for expansion-time lints First commit: a macro expansion doesn't have a `NodeId` associated with it, but it has a parent `DefId` which we can use for linting. The observable effect is that lints associated with macro expansions can now be `allow`ed at finer-grained level than whole crate. Second commit: each macro definition has a `NodeId` which we can use for linting, unless that macro definition was decoded from other crate.

view details

Dylan DPC

commit sha 6f9d45351031eedff0336baa20d26d789870c988

Rollup merge of #73225 - tmandry:issue-73050, r=oli-obk Allow inference regions when relating consts As first noticed by @eddyb, `super_relate_consts` doesn't need to check for inference vars since `eval` does it already (and handles lifetimes correctly by erasing them). Fixes #73050 r? @oli-obk

view details

Dylan DPC

commit sha b4cb12fd2140421e9c9a4965e247c246f3896564

Rollup merge of #73236 - GuillaumeGomez:cleanup-e0666, r=Dylan-DPC Clean up E0666 explanation r? @Dylan-DPC

view details

Dylan DPC

commit sha 77ede48ada25295cb90e520f52c1cbe653982f8a

Rollup merge of #73273 - LeSeulArtichaut:patch-1, r=Dylan-DPC Fix Zulip pings r? @Dylan-DPC

view details

Ralf Jung

commit sha b4bd180e5e330c6b3019c0d9d0ad676f07885258

fix caller_location intrinsic for Miri

view details

Wesley Wiser

commit sha f1605834a568b26bb540e743e9dd7e25d4ad9151

Disable the `SimplifyArmIdentity` pass on beta This pass is buggy so I'm disabling it to fix a stable-to-beta regression. Related to #73223

view details

bors

commit sha 7c78a5f97de07a185eebae5a5de436c80d8ba9d4

Auto merge of #73276 - Dylan-DPC:rollup-hfd81qw, r=Dylan-DPC Rollup of 5 pull requests Successful merges: - #72906 (Migrate to numeric associated consts) - #73178 (expand: More precise locations for expansion-time lints) - #73225 (Allow inference regions when relating consts) - #73236 (Clean up E0666 explanation) - #73273 (Fix Zulip pings) Failed merges: r? @ghost

view details

push time in 10 days

pull request commentrust-lang/rust

[WIP] Bring rust-semverver in-tree and test that it builds.

@eddyb I think you should split CI image bump to another PR since it's strictly infra change.

eddyb

comment created time in 11 days

issue commentrust-lang/rust

provide a way of overriding the MinGW library path

@saurik the plan is to always disable self contained mode when cross compiling and on Windows when the linker location is outside of Rust sysroot.

To do it properly we need to stabilise link-self-contained first but that requires MCP. There is open MCP already for what https://github.com/rust-lang/rust/pull/72999 did and if it's not approved all the changes so far will be probably reverted: https://github.com/rust-lang/compiler-team/issues/310

tanriol

comment created time in 11 days

issue commentmsys2/MSYS2-packages

[BUG]mintty charset problem not yet fixed

I think it's duplicate of https://github.com/msys2/MSYS2-packages/issues/1974

yxl0756

comment created time in 11 days

issue commentrust-lang/rust

Implementation of std::f64::powi function gives inconsistent answers in multiple Rust tool-chains

Quite interesting that https://github.com/rust-lang/rust/issues/73420 affects both windows-gnu and windows-msvc targets but here only msvc output changed in the nightly. #73420 on the other hand works fine on both Windows targets:

$ rustc -vV
rustc 1.46.0-nightly (16957bd4d 2020-06-30)
binary: rustc
commit-hash: 16957bd4d3a5377263f76ed74c572aad8e4b7e59
commit-date: 2020-06-30
host: x86_64-pc-windows-gnu
release: 1.46.0-nightly
LLVM version: 10.0

$ rustc powi2.rs && ./powi2
5e-324
5e-324
5e-324

$ rustc powi2.rs -O && ./powi2
5e-324
5e-324
5e-324

$ rustc powi2.rs --target x86_64-pc-windows-msvc && ./powi2
5e-324
5e-324
5e-324

$ rustc powi2.rs --target x86_64-pc-windows-msvc -O && ./powi2
5e-324
5e-324
5e-324
hansieodendaal

comment created time in 11 days

issue commentmsys2/MINGW-packages

SDL2 linking (with CMake build) is broken since 2.0.12-2

which is not supported by lld( which is weird, as ld.lld --help state it does )

ld.lld is ELF driver, to get help for MinGW driver use ld.lld -m i386pep --help.

rzumer

comment created time in 11 days

issue commentmstorsjo/llvm-mingw

Build instructions

This issue (build instructions) seems fixed.

revelator

comment created time in 11 days

pull request commentrust-lang/rust

Avoid `unwrap_or_else` in `RawVec::allocate_in`.

Maybe closing the PR while it was tested has broke bors?

nnethercote

comment created time in 11 days

issue commentrust-lang/rust

provide a way of overriding the MinGW library path

Thanks!

@tanriol @saurik could you test if Rust nighty with -Z link-self-contained=no fixes the issue for you?

tanriol

comment created time in 11 days

issue commentrust-lang/rust

provide a way of overriding the MinGW library path

Let me undo my evil hack and I'll do, is it fine if I get you the tests results tomorrow?

Sure, there are 2 weeks left to the branching 😉.

tanriol

comment created time in 11 days

issue commentrust-lang/rust

provide a way of overriding the MinGW library path

@lu-zero could you try with -Z link-self-contained=no? I wanted to make an "announcement" here asking people to try nightly with -Z link-self-contained=yes/no right after the nightly with https://github.com/rust-lang/rust/pull/72738 has been published but forgot about it. Detection improvements will come in next PR but I wanted to gather some data first.

Short summary:

  • link-self-contained=yes is meant for native Windows only with rust-mingw component installed. It allows to build crates without C dependencies even with MinGW C toolchain not installed.
  • link-self-contained=no forces to use external MinGW C toolchain so you always want to use this option when external MinGW C toolchain is available.
  • no option right now behaves exactly the same as it did before so it's a mix of link-self-contained=no and link-self-contained=yes. In 2 weeks branching will happen and once it's done I want to land PR that will rework MinGW detection and stabilise link-self-contained option.
tanriol

comment created time in 11 days

pull request commentrust-lang/rust

[WIP] Bring rust-semverver in-tree and test that it builds.

@eddyb MinGW dist builder is Windows based and CI installs mingw-w64 5.0.x (the one with versionhelpers.h present) on it.

eddyb

comment created time in 11 days

pull request commentrust-lang/rust

[WIP] Bring rust-semverver in-tree and test that it builds.

versionhelpers.h is available in mingw-w64 starting from version 5.0.0, Ubuntu 16.04 ships version 4.0.4. I think it worked previously because mingw-check was not building libssh2-sys crate. From MinGW PoV the easiest way forward would be upgrading the builder to use newer image. Alternatively you can try bumping libssh2-sys and hoping it no longer uses that header.

eddyb

comment created time in 11 days

issue commentrust-lang/rust

linking with `cc` failed on AArch64 with `aarch64-unknown-linux-musl` target

What if you try to use AArch64 linker instead? RUSTFLAGS="-C linker=aarch64-linux-gnu-gcc cargo build --release --target aarch64-unknown-linux-musl --no-default-features --features mmio

MrXinWang

comment created time in 12 days

issue commentmsys2/MSYS2-packages

[BUG] [python3] Use of Thread silently crash on Windows 7

Is it mingw-w64-*-python or python package? Pip version suggests mingw package.

mipicard

comment created time in 12 days

issue commentcryptocorrosion/cryptocorrosion

Use no SIMD variant when no sse2/avx is detected even when the simd feature is set

I think https://github.com/mati865/cryptocorrosion/commit/dc1dff112919840a98f244b4a617bb7792844e7a would fix no_simd feature but I'm not confident if that is proper solution since it would conflict with simd feature (mutually exclusive features don't exist: https://github.com/rust-lang/cargo/issues/2980).

After looking at Rust dependency tree I think bumping rand_chacha to version 0.2.3 will disable simd: https://github.com/rust-random/rand/commit/4b99567b56f39742f8b6e746dcd910c6d1ed3a93#diff-1518fed4708b2c3e1c4bc69e9dc34775R23 since ppv-lite86 no longer uses simd by default: https://github.com/cryptocorrosion/cryptocorrosion/commit/785bfbe9b89344de9978cb80758c07e2ca3cbde3

bjorn3

comment created time in 12 days

push eventmati865/cryptocorrosion

Mateusz Mikuła

commit sha dc1dff112919840a98f244b4a617bb7792844e7a

Fix `no_simd` feature

view details

push time in 12 days

create barnchmati865/cryptocorrosion

branch : no_simd

created branch time in 12 days

fork mati865/cryptocorrosion

Performance crypto in pure Rust

fork in 12 days

issue commentr-darwish/topgrade

Self update doesn't work on Windows

I can add a configuration option that when set, causes Topgrade to move itself to the temp directory when it's run, and then move it back when it finished if it does not detect a file in its former location. This will require you to change your configuration as it's a bad idea to make it a default behavior.

Sounds good!

mati865

comment created time in 13 days

issue commentr-darwish/topgrade

Self update doesn't work on Windows

Cargo-update has workaround that works well on Windows: https://github.com/nabijaczleweli/cargo-update#self-update

mati865

comment created time in 13 days

issue openedr-darwish/topgrade

Self update doesn't work on Windows

What did you expect to happen? Topgrade should update itself successfully.

What actually happened? It fails with:

Package         Installed  Latest   Needs update
topgrade        v4.8.0     v4.9.0   Yes
cargo-update    v3.0.0     v3.0.0   No
<other crates>

Updating topgrade
  Downloaded topgrade v4.9.0
  <build log>
   Replacing C:\Users\mateusz\.cargo\bin\topgrade.exe
error: failed to move `C:\Users\mateusz\.cargo\bin\cargo-installgExTkS\topgrade.exe` to `C:\Users\mateusz\.cargo\bin\topgrade.exe`

Caused by:
  Access denied. (os error 5)

Additional details:

  • Which operating system or Linux distribution are you using? Windows 10 Pro 2004
  • How did you install Topgrade? cargo install topgrade
  • If a specific step is failing, what happens when you run the command on your own? (Run topgrade --dry-run to see which commands Topgrade is running)

<details><pre> 2020-06-30T09:29:08.334Z DEBUG topgrade::executor > Running "C:\Users\mateusz\.cargo\bin\cargo-install-update.EXE" "install-update" "--git" "--all" Updating registry 'https://github.com/rust-lang/crates.io-index'

Package Installed Latest Needs update topgrade v4.8.0 v4.9.0 Yes cargo-update v3.0.0 v3.0.0 No <other crates>

Updating topgrade Updating crates.io index Installing topgrade v4.9.0 Compiling winapi-x86_64-pc-windows-gnu v0.4.0 Compiling winapi v0.3.9 Compiling proc-macro2 v1.0.18 Compiling unicode-xid v0.2.1 Compiling syn v1.0.33 Compiling cfg-if v0.1.10 Compiling winapi-build v0.1.1 Compiling memchr v2.3.3 Compiling version_check v0.9.2 Compiling lazy_static v1.4.0 Compiling autocfg v1.0.0 Compiling libc v0.2.71 Compiling log v0.4.8 Compiling slab v0.4.2 Compiling pin-project-internal v0.4.22 Compiling winapi v0.2.8 Compiling getrandom v0.1.14 Compiling proc-macro-nested v0.1.6 Compiling unicode-segmentation v1.6.0 Compiling bitflags v1.2.1 Compiling once_cell v1.4.0 Compiling serde_derive v1.0.114 Compiling regex-syntax v0.6.18 Compiling proc-macro-hack v0.5.16 Compiling futures-sink v0.3.5 Compiling futures-core v0.3.5 Compiling unicode-width v0.1.8 Compiling serde v1.0.114 Compiling iovec v0.1.4 Compiling pin-utils v0.1.0 Compiling futures-io v0.3.5 Compiling ppv-lite86 v0.2.8 Compiling quick-error v1.2.3 Compiling anyhow v1.0.31 Compiling vec_map v0.8.2 Compiling strsim v0.8.0 Compiling encode_unicode v0.3.6 Compiling topgrade v4.9.0 Compiling bytes v0.5.5 Compiling pin-project-lite v0.1.7 Compiling glob v0.3.0 Compiling thread_local v1.0.1 Compiling kernel32-sys v0.2.2 Compiling ws2_32-sys v0.2.1 Compiling futures-task v0.3.5 Compiling heck v0.3.1 Compiling futures-channel v0.3.5 Compiling textwrap v0.11.0 Compiling humantime v1.3.0 Compiling num-traits v0.2.12 Compiling num-integer v0.1.43 Compiling proc-macro-error-attr v1.0.3 Compiling proc-macro-error v1.0.3 Compiling rand_core v0.5.1 Compiling aho-corasick v0.7.13 Compiling rand_chacha v0.2.2 Compiling quote v1.0.7 Compiling rand v0.7.3 Compiling regex v1.3.9 Compiling atty v0.2.14 Compiling winapi-util v0.1.5 Compiling net2 v0.2.34 Compiling dirs-sys v0.3.5 Compiling socket2 v0.3.12 Compiling terminal_size v0.1.12 Compiling time v0.1.43 Compiling remove_dir_all v0.5.3 Compiling dirs v2.0.2 Compiling directories v2.0.2 Compiling clicolors-control v1.0.1 Compiling clap v2.33.1 Compiling tempfile v3.1.0 Compiling termcolor v1.1.0 Compiling same-file v1.0.6 Compiling shellexpand v2.0.0 Compiling console v0.10.3 Compiling miow v0.3.5 Compiling chrono v0.4.11 Compiling walkdir v2.3.1 Compiling env_logger v0.7.1 Compiling syn-mid v0.5.0 Compiling pretty_env_logger v0.4.0 Compiling miow v0.2.1 Compiling mio v0.6.22 Compiling futures-macro v0.3.5 Compiling thiserror-impl v1.0.20 Compiling strum_macros v0.18.0 Compiling mio-named-pipes v0.1.6 Compiling tokio v0.2.21 Compiling thiserror v1.0.20 Compiling which v4.0.1 Compiling structopt-derive v0.4.8 Compiling strum v0.18.0 Compiling pin-project v0.4.22 Compiling futures-util v0.3.5 Compiling structopt v0.3.15 Compiling futures-executor v0.3.5 Compiling futures v0.3.5 Compiling toml v0.5.6 Finished release [optimized] target(s) in 1m 37s Replacing C:\Users\mateusz.cargo\bin\topgrade.exe error: failed to move C:\Users\mateusz\.cargo\bin\cargo-installORuk8I\topgrade.exe to C:\Users\mateusz\.cargo\bin\topgrade.exe

Caused by: Odmowa dost─Öpu. (os error 5)

Updated 0 packages. Failed to update topgrade. </pre></details>

Running in MSYS2 MINGW64 shell if that matters.

created time in 13 days

issue commentrust-lang/rust

Towards faster symbol lookup via DT_GNU_HASH

@tmiasko Clang is using --hash-style=both though:

 mateusz@arch  /tmp  gcc hello.c -o hello && readelf -S hello | grep -A1 -i hash
  [ 4] .gnu.hash         GNU_HASH         0000000000000308  00000308
       000000000000001c  0000000000000000   A       5     0     8
 mateusz@arch  /tmp  clang hello.c -o hello && readelf -S hello | grep -A1 -i hash
  [ 3] .hash             HASH             00000000000002e8  000002e8
       0000000000000030  0000000000000004   A       5     0     8
  [ 4] .gnu.hash         GNU_HASH         0000000000000318  00000318
       000000000000001c  0000000000000000   A       5     0     8

I'll prepare patch for Clang when I have a time unless I forget.

LifeIsStrange

comment created time in 13 days

pull request commentrust-lang/rust

[WIP] Upgrade to LLVM 11

Debug regressions seem to be coming from LLVM's increased amount of work. There are also small check regressions indicating slightly slower binaries.

cuviper

comment created time in 13 days

pull request commentrust-lang/rust

proc_macro: Stop flattening groups with dummy spans

Bors doesn't listen on closed issues.

petrochenkov

comment created time in 13 days

pull request commentrust-lang/rust

Added io forwarding methods to the stdio structs

False positive perf regression is another case of https://github.com/rust-lang/compiler-team/issues/281

Lucretiel

comment created time in 13 days

issue commentrust-lang/rust

Towards faster symbol lookup via DT_GNU_HASH

if this is what the rust community want we can close this thread

Well, there are plans to directly link with LLD at some point and in that mode Rust will have to choose hash-style itself. When using other compiler as the linker IMO Rust should follow what the other compiler does but let's cc Rust's linkage expert @petrochenkov

wait for upstream instead of overriding it's current behavior.

That in Clang code hasn't been updated for years and I doubt anybody is going to touch that mess soon...

LifeIsStrange

comment created time in 13 days

pull request commentmsys2/MINGW-packages

Add rav1e

ssh2-rs issue has been fixed.

lazka

comment created time in 13 days

issue commentrust-lang/rust

Towards faster symbol lookup via DT_GNU_HASH

@LifeIsStrange this is arguably Clang's issue, another issue is Distro.IsOpenSUSE() appearing twice... GCC is not affected: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/gcc&id=a9fc6ff951ae117dd8ca01506c331e8c2c843b64#n83

LifeIsStrange

comment created time in 13 days

issue commentrust-lang/rust

Towards faster symbol lookup via DT_GNU_HASH

@LifeIsStrange in other words: Rust does not call linker directly but instead invokes system C compiler (GCC or Clang). That compiler (like in the snippet that you pasted above) will use proper --hash-style.

LifeIsStrange

comment created time in 13 days

delete branch mati865/libssh2

delete branch : mingw-fix

delete time in 13 days

PR closed wez/libssh2

wincng: fix multiple definition of `_libssh2_wincng'

Fix for https://github.com/alexcrichton/ssh2-rs/issues/187

+8 -2

7 comments

2 changed files

mati865

pr closed time in 13 days

pull request commentwez/libssh2

wincng: fix multiple definition of `_libssh2_wincng'

Obsoleted by https://github.com/alexcrichton/ssh2-rs/commit/e8d4dc165fbcd3fceeec96db9d1e9be9b67bef7b

mati865

comment created time in 13 days

issue commentalexcrichton/ssh2-rs

Version "0.8.1" won't compile on Windows 10 with MSYS2 using cargo build

This appears to build in the CI, but before I push updated packages to crates.io, I'd appreciate it if you could try pointing one of your real projects to github master and confirming that this resolves things.

Running cargo test --no-run --target x86_64-pc-windows-gnu was reproducing the issue. Windows-gnu is not tested on the CI. Confirmed the issue is fixed by locally running testsuite for both i686 and x86_64 windows-gnu targets.

Thank you for fixing it!

mhavrlent

comment created time in 13 days

issue commentmsys2/MINGW-packages

The problem of no such file or directory

I think you have to give a path to --prefix= otherwise it tries to use --with-xerces=/mingw64 as the path.

Timothy71

comment created time in 14 days

pull request commentrust-lang/rust

ci: Update dist-{i686,x86_64}-linux to CentOS 6

we should check the state of other LTS distros in comparison

Oldest non EOL Ubuntu is 14.04 with glibc 2.19 and 3.13 kernel: https://wiki.ubuntu.com/Releases Debian is similar but has been released with 3.16 kernel.

cuviper

comment created time in 15 days

delete branch mati865/rust

delete branch : cleanup-mingw-llvm-linkage

delete time in 16 days

pull request commentrust-lang/rust

Reoder order in which MinGW libs are linked to fix recent breakage

@tmandry see https://github.com/rust-lang/rust/issues/72241#issuecomment-640892182

mati865

comment created time in 16 days

issue commentrust-lang/rust

Incorrect compilation / STATUS_ACCESS_VIOLATION when linking with lld with target-cpu set

Does not reproduce with windows-gnu on 2700X with:

[build]
rustflags = [
	"-Clink-arg=-fuse-ld=lld",
    "-Ctarget-feature=+avx"
]

@rustbot modify labels: -O-windows +O-windows-msvc

Systemcluster

comment created time in 17 days

delete branch mati865/rust

delete branch : self-contained-option

delete time in 17 days

pull request commentwez/libssh2

wincng: fix multiple definition of `_libssh2_wincng'

@wez I apologize if that sounded harsh, that wasn't my intention.

The longer answer is that I have a busy life with many competing priorities.

I understand that, I'll just tell to not expect the fix soon.

I'm afraid I don't know who you are or why people are asking you about ssh-rs

Nobody important, people have noticed I've fixed few MinGW related Rust bugs.

My suggestion is to pin to 0.8.0 if that worked better, and to be patient.

That's not easy with cargo install, guess I'll recommend to use LIBSSH2_SYS_USE_PKG_CONFIG=1 for now.

mati865

comment created time in 17 days

pull request commentrust-lang/rust

Self contained linking option

Looks like this is ready?

Yeah, forgot to write a comment 🤷‍♂️

mati865

comment created time in 18 days

pull request commentwez/libssh2

wincng: fix multiple definition of `_libssh2_wincng'

@wez can I know when you are going to do the review? I don't know what to tell people asking me why ssh2-rs is broken on Tier 1 target.

mati865

comment created time in 18 days

push eventmati865/rust

Mateusz Mikuła

commit sha 2e3f51775a6427f34878c2041be8e0c8d656ea3c

Add unstable rustc option to control self-contained linkage mode

view details

Mateusz Mikuła

commit sha 54293c1f157ee83d8e9949a7908e093ae0d5817a

Rename get_self_contained_lib_path

view details

Mateusz Mikuła

commit sha f27dcd7ee05e948c92fb7e742d6b26c34e20b39c

Rename remaining `fallback` to `self_contained`

view details

push time in 18 days

pull request commentrust-lang/rust

Bootstrap: detect Windows based on sys.platform

What effect does this have on the branches where we detect MSYS/MinGW to build pc-windows-gnu?

It's going to build x86_64-pc-windows-msvc unless the target was was explicitly set. This doesn't seem right.

ajpaverd

comment created time in 18 days

pull request commentmicrosoft/snmalloc

investigate the problem on MinGW

@SchrodingerZhu with llvm-mingw toolchain:

$ export PATH=/opt/llvm-mingw/bin

$ clang++ mingw.cpp && ./a
dtor called 2304
dtor called 21104
dtor called 9228
dtor called 11244
dtor called 9820
dtor called 13688
dtor called 20004
dtor called 20984
dtor called 7612
dtor called 2844
dtor called 7028
dtor called 5000

There is no error.

I think further discussions are not closely related to snmalloc, I have sent this problem to the mailing list; let us just sit back and relax to see what they would suggest.

Sure, thought this info would be useful.

SchrodingerZhu

comment created time in 19 days

pull request commentmicrosoft/snmalloc

investigate the problem on MinGW

I'm working on fixing MSYS2 libc++. In the meantime you can try using this MinGW toolchain: https://github.com/mstorsjo/llvm-mingw It doesn't use winpthreads at all so it could help here, I can test it if you provide me instructions.

SchrodingerZhu

comment created time in 19 days

push eventmati865/rust

Carsten Andrich

commit sha c88e6a75f5f681610142aaba351cdd6e30deed95

add Windows system error codes that map to io::ErrorKind::TimedOut

view details

Carsten Andrich

commit sha 86679967e3cc895d2b5ab4bb974664ff283fe043

use or pattern to match error codes that map to ErrorKind::TimedOut

view details

Carsten Andrich

commit sha c69d6c84c7042d767e55f69ff544de0098a6042f

fix formatting issues that fail tidy test

view details

Yoshua Wuyts

commit sha 2764e54c29d0f19242e794d5eecd00cc5470f530

impl ToSocketAddrs for (String, u16)

view details

Carsten Andrich

commit sha e27a8b59ed8046c9a9c73b680e0f767f4252077d

add link list of error codes on docs.microsoft.com

view details

Eric Huss

commit sha 8f5ff7b379ea61ee5da5200c92ea603eb955c506

Update cargo

view details

Guillaume Gomez

commit sha 1d08b1b0421cc287218196e5fdd144b3e82a482a

Clean up E0689 explanation

view details

Nathan West

commit sha c9c434dd8bcd84a30edd070e91f0d6c027333c84

Converted all platform-specific stdin/stdout/stderr implementations to io traits

view details

Nathan West

commit sha e93362b9746a42638a28f382f41cdb5e2f01f8f6

Fixed missing `mut`

view details

Nathan West

commit sha 0094f44a0b54d6ac92f3feaa939d6a3d48cb7475

Remove old commented code

view details

Oliver Scherer

commit sha 9245ba83047b14fc7c9cef4c7d2bf37828c445b6

Remove the const_raw_ptr_comparison feature gate. We can never supply a meaningful implementation of this. Instead, the follow up commits will create two intrinsics that approximate comparisons: * `ptr_maybe_eq` * `ptr_maybe_ne` The fact that `ptr_maybe_eq(a, b)` is not necessarily the same value as `!ptr_maybe_ne(a, b)` is a symptom of this entire problem.

view details

Oliver Scherer

commit sha e09b62033926dff8bfedca35b93e0dfbf767749f

Add fuzzy pointer comparison intrinsics

view details

Oliver Scherer

commit sha 84f1d73182f4882518d5eef067b18b49b49e985a

Tidy got confused on `rustc_const_unstable` `issue`s

view details

Christian Poveda

commit sha e75fbaee45a24816e8e2b27cd9f8896766aee6e3

add second message for livedrop errors

view details

Esteban Küber

commit sha 562f4967b4ce7e859b807fc022040bbb22d1f70e

Account for multiple impl/dyn Trait in return type when suggesting `'_`

view details

Rakshith Ravi

commit sha 0624a5a063c0282811ac63b13861abb768f3f9c7

Squashed all commits

view details

Oliver Scherer

commit sha 9e88b48133c703c04780a9474c029b4398ca3260

Refer just to the issue in the raw ptr cmp diagnostic instead of explaining everything in the diagnostic

view details

Oliver Scherer

commit sha 53686b91caac6c6782b8d2a41675f4f0941aa254

Satisfy tidy

view details

Oliver Scherer

commit sha 98e97a46e2201520f54082abe462728b0a770a6b

Address review comments

view details

Christian Poveda

commit sha 935516803e2822da33479bcbc8d3dfb2833a8d49

update tests

view details

push time in 19 days

pull request commentmicrosoft/snmalloc

investigate the problem on MinGW

@SchrodingerZhu I believe it's one of many MinGW libgcc issues. Your code example works better with compiler-rt + libunwind:

clang++ mingw.cpp -rtlib=compiler-rt -lunwind && LANG=C ./a
dtor called 2
dtor called 5
dtor called 4
dtor called 8
dtor called 10
dtor called 6
dtor called 12
dtor called 3
dtor called 11
dtor called 7
dtor called 13
dtor called 9
Windows error: Parameter is incorrect.
SchrodingerZhu

comment created time in 19 days

issue commentgit-for-windows/git-sdk-64

`sdk create-desktop-icon` fails with "Could not save link"

$ (set -x && sdk create-desktop-icon)
+ sdk create-desktop-icon
+ case "$1" in
+ force=t
+ case "$1" in
+ shift
+ case "$1" in
+ break
+ case "$(uname -m)" in
++ uname -m
+ bitness=' 64-bit'
+ desktop_icon_path='C:\Users\mateusz/Desktop/Git SDK 64-bit.lnk'
+ test -n t
+ create-shortcut.exe --icon-file /msys2.ico --work-dir / /git-bash.exe 'C:\Users\mateusz/Desktop/Git SDK 64-bit.lnk'
Could not save link
Error: System nie mo┐e odnalečŠ okreťlonej ťcie┐ki. # yeah, runtime is still broken

In my case (user created with Microsoft account) the desktop location is: /c/Users/mateusz/OneDrive/Pulpit. Pulpit is polish translation of Desktop.

jnareb

comment created time in 20 days

pull request commentrust-lang/rust

MinGW: enable dllexport/dllimport

the change is broken into as many "atomic" independently landable PRs as possible.

This PR is already as atomic as it can be :(

Each atomic change has a test case

Since there are import libraries created now I could make test for https://github.com/rust-lang/rust/issues/50176 to verify if the symbol is present.

mati865

comment created time in 20 days

pull request commentrust-lang/rust

impl ToSocketAddrs for (String, u16)

@Manishearth https://github.com/rust-lang/rust/pull/73237 should fix the error.

yoshuawuyts

comment created time in 20 days

Pull request review commentrust-lang/rust

Self contained linking option

 pub fn link_binary<'a, B: ArchiveBuilder<'a>>( // The third parameter is for env vars, used on windows to set up the // path for MSVC to find its DLLs, and gcc to find its bundled // toolchain-fn get_linker(sess: &Session, linker: &Path, flavor: LinkerFlavor) -> Command {+fn get_linker(sess: &Session, linker: &Path, flavor: LinkerFlavor, fallback: bool) -> Command {

Replaced all fallback variables , there are still various *_fallback functions but that seems out of scope for this PR.

mati865

comment created time in 20 days

more