profile
viewpoint

mati865/cargo-edition-test 1

Nothing to see here; just some bugs

mati865/actix-web 0

Actix web is a small, pragmatic, and extremely fast rust web framework.

mati865/aports 0

Mirror of aports repository

mati865/backtrace-rs 0

Backtraces in Rust

mati865/browser-laptop 0

Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux

mati865/cargo 0

The Rust package manager

mati865/cargo-edit 0

A utility for managing cargo dependencies from the command line.

issue commentmsys2/MINGW-packages

Mingw-w64-clang has some errors when generating profiles

It works only when compiler-rt is build by Clang+LLD.

Symbols when compiler-rt is:

  • built by GCC:
0000000000000000 r .rdata$.refptr.__llvm_profile_filename
0000000000000000 R .refptr.__llvm_profile_filename
                 U __llvm_profile_filename
0000000000000000 B .weak.__llvm_profile_filename.
                 w __llvm_profile_filename
  • built by Clang+LLD:
0000000000000000 r .rdata$.refptr.__llvm_profile_filename
0000000000000000 R .refptr.__llvm_profile_filename
                 U __llvm_profile_filename
0000000000000000 B __llvm_profile_filename
Keithcat1

comment created time in an hour

pull request commentrust-lang/rust

Translate the virtual `/rustc/$hash` prefix back to a real directory.

@eddyb you have to tell rustup-toolchain-install-master to install the component. Like this:

$ rustup-toolchain-install-master 40f2b445cd1c6c4e72d663d23c6d1bef2c674ad4 -c rust-src
$ ls ~/.rustup/toolchains/40f2b445cd1c6c4e72d663d23c6d1bef2c674ad4/lib/rustlib/src/rust/src
build_helper  libpanic_abort   libprofiler_builtins  libtest    tools
liballoc      libpanic_unwind  libstd                libunwind
libcore       libproc_macro    libterm               stdarch
eddyb

comment created time in 8 hours

Pull request review commentrust-lang/cargo

Add implib to the stamp files

 impl TargetInfo {                 should_replace_hyphens: false,             })         }+        else if target_triple.ends_with("windows-gnu")
        
        // LD can link DLL directly but LLD requires import library
        if target_triple.ends_with("windows-gnu")
chouquette

comment created time in 9 hours

Pull request review commentrust-lang/cargo

Add implib to the stamp files

 impl TargetInfo {                 should_replace_hyphens: false,             })         }+        else if target_triple.ends_with("windows-gnu")+                && crate_type.ends_with("dylib")+                && suffix == ".dll"+        {+            ret.push(FileType {+                suffix: ".dll.a".to_string(),+                prefix: "lib".to_string(),
                prefix: prefix.clone(),

There is no need to hardcode lib prefix because it works in either form.

chouquette

comment created time in 9 hours

issue commentrust-lang/rust

Replace submodules with subtrees

Clippy's CI could perform pull every time it tries to merge PR. That would avoid nearly all conflicts (from maintainer PoV) when new lint using the "old code" is being added but Clippy in Rust repo was updated for the "new code" already.

oli-obk

comment created time in 10 hours

issue commentmsys2/MINGW-packages

Update to LLVM/Clang 10?

I have it almost ready but there are still a few left things to improve.

HolyBlackCat

comment created time in a day

Pull request review commentrust-lang/rust

Translate the virtual `/rustc/$hash` prefix back to a real directory.

 fn build_session_(         _ => CtfeBacktrace::Disabled,     }); +    // Try to find a directory containing the Rust `src`, for more details see+    // the doc comment on the `real_rust_source_base_dir` field.+    let compute_real_rust_source_base_dir = || {+        // A file we expect to find inside the `real_rust_source_base_dir`.+        const SRC_FILE_TO_PROBE_FOR: &str = "src/libstd/lib.rs";++        // First look in the location used by the `rust-src` `rustup` component.+        let sysroot_candidate = sysroot.join("lib/rustlib/src/rust");+        if sysroot_candidate.join(SRC_FILE_TO_PROBE_FOR).is_file() {+            return Some(sysroot_candidate);+        }++        // As a fallback, check if the `sysroot` is inside a Rust build dir,+        //  i.e. it ends in `build/$CFG_COMPILER_HOST_TRIPLE/stage{0-sysroot,1,2,3}`.+        let mut sysroot_components = sysroot.components();+        let last = sysroot_components.next_back()?.as_os_str();+        if last == "stage0-sysroot" || last == "stage1" || last == "stage2" || last == "stage3" {+            if sysroot_components.next_back()?.as_os_str() == host_triple {+                if sysroot_components.next_back()?.as_os_str() == "build" {

@eddyb it won't work for every Windows user though: https://github.com/rust-lang/rust/blob/30ddb5a8c1e85916da0acdc665d6a16535a12dd6/src/libstd/sys/windows/fs.rs#L760-L763

eddyb

comment created time in a day

pull request commentrust-lang/rust

submodules: Update RLS and Rustfmt

Update this line: https://github.com/rust-lang/rust/blob/75ff3110ac6d8a0259023b83fd20d7ab295f8dd6/src/tools/rustc-workspace-hack/Cargo.toml#L62

Xanewok

comment created time in 2 days

pull request commentrust-lang/rust

Add missing -lmsvcrt on mingw after -lpthread

Bummer, I had thought only winpthreads depend on GCC libs.

Amanieu

comment created time in 2 days

pull request commentrust-lang/rust

Add missing -lmsvcrt on mingw after -lpthread

Why not move https://github.com/rust-lang/rust/blob/2113659479a82ea69633b23ef710b58ab127755e/src/librustc_codegen_ssa/back/link.rs#L559-L561 below https://github.com/rust-lang/rust/blob/2113659479a82ea69633b23ef710b58ab127755e/src/librustc_codegen_ssa/back/link.rs#L562-L570 instead?

late_link_args contain only "CRT" libraries that have no further dependencies: https://github.com/rust-lang/rust/blob/2113659479a82ea69633b23ef710b58ab127755e/src/librustc_target/spec/windows_base.rs#L22-L40

Amanieu

comment created time in 2 days

pull request commentrust-lang/rustc-rayon

Rebase on rayon-1.2.0 and rayon-core-1.6.0

It still needs new crates.io release to make it's way to Rust.

cuviper

comment created time in 2 days

issue commentrust-lang/rust

i686-pc-windows-gnu fails to link on appveyor

@Amanieu I'd love to upgrade MinGW on the CI as it would help me with a few thing but there is a problem. Upstream no longer provides prebuilt GCC and latest version available had issue where it ran out of memory on the CI: https://github.com/rust-lang/rust/pull/51989 I can help with building GCC or providing builds but I don't really know how to start.

retep998

comment created time in 2 days

issue commentrust-lang/rust

i686-pc-windows-gnu fails to link on appveyor

@rustbot modify labels: +E-needs-mcve

cc @Amanieu

retep998

comment created time in 2 days

issue commentrust-lang/rust

wasm target not honoring linker set at bootstrap time (1.42.0 and maybe earlier)

Linker configured during Rust compilation is not meant to propagate to the final binary. AFAIK if you want to change default linker you should patch the spec file or use Cargo configuration file.

gyakovlev

comment created time in 2 days

issue commentrust-lang/rust

Update Readme Instructions for 32-bit MinGW Builds

AFAIK 32 bit MinGW builds are fine nowadays.

camlorn

comment created time in 5 days

delete branch mati865/rust

delete branch : deps

delete time in 6 days

pull request commentrust-lang/rust

Upgrade rustc and bootstrap dependencies

Appears to be spurious chocolatey issue.

@bors retry

mati865

comment created time in 7 days

pull request commentrust-lang/rust

data_structures: Bump crossbeam_utils to 0.7

r? @Mark-Simulacrum

Already included in https://github.com/rust-lang/rust/pull/69470 but I don't have any preference on how it's done.

Xanewok

comment created time in 7 days

PullRequestEvent

pull request commentrust-lang/rust

Upgrade rustc and bootstrap dependencies

Something has broke and GitHub closed PR by itself.

mati865

comment created time in 7 days

push eventmati865/rust

Mateusz Mikuła

commit sha f5e702df0efa48018bf27fdfa791357e0d6fac78

Upgrade rustc and bootstrap dependencies

view details

push time in 7 days

create barnchmati865/rust

branch : deps

created branch time in 7 days

create barnchmati865/rust

branch : deps

created branch time in 7 days

delete branch mati865/rust

delete branch : deps

delete time in 7 days

delete branch mati865/rust

delete branch : deps

delete time in 7 days

push eventmati865/rust

Vadim Petrochenkov

commit sha 552a8875bd5520c2e8c01ab05a12c304c730c5b9

expand: Implement support for retrying macro expansions

view details

Vadim Petrochenkov

commit sha 2e6528961c44a4f3841fd319af71f1d1a6af029c

builtin_macros: Add attribute macro `#[cfg_accessible(path)]`

view details

YI

commit sha 906bb8d0e8bbd026fc933fe3f5b829be5e4ac69e

fix #62456

view details

Chris Simpkins

commit sha 0982c58edc5b9fe4cfc8b22bc3edaa95e4f5c638

update tidy documentation to recommend ./x.py test tidy

view details

Chris Simpkins

commit sha 259b06e33f533096f0b46beca8719fd4afceb78b

add documentation of x.py tool testing

view details

Chris Simpkins

commit sha 9f734c978c4c32eea552d45fef582804c1d2b9bf

Add documentation of tool testing with x.py script

view details

Chris Simpkins

commit sha 4922b683de170c70260b73426ccf16172fa63b7f

remove trailing whitespace (tidy)

view details

YI

commit sha 0a0c850d732666b1205a6f567c38e05239c65848

fix test failure due to earlier emitted error

view details

Chris Simpkins

commit sha c60d581eb15d6fbe17a657da7c1de4dc82b70b68

update x.py tidy testing command

view details

Ayush Kumar Mishra

commit sha 6f2c01bcfbdcaa9686ceb37cce29564a2d662828

Add long error explanation for E0739

view details

Christopher Durham

commit sha a56196205b1919bee851bdfd7e76e9b3ae5090db

Vec::new is const tstable in 1.39 not 1.32

view details

Ayush Kumar Mishra

commit sha 761c8c1eefa8cecb1a55628674690c53cc8c473b

Removed trailing whitespace

view details

Mazdak Farrokhzad

commit sha 5b08aad6d9630299d9fdc06fdd4d00c79d2eedd6

Rollup merge of #69475 - Zoxc:no-no-force, r=michaelwoerister Remove the `no_force` query attribute This removes the `no_force` query attribute and instead uses the `DepNodeParams` trait to find out if a query can be forced. Also the `analysis` query is moved to the query macro. r? @eddyb

view details

Mazdak Farrokhzad

commit sha 61150353bf9cc415f4554a9b4851c14e4255329f

Rollup merge of #69514 - GuillaumeGomez:remove-spotlight, r=kinnison Remove spotlight I had a few comments saying that this feature was at best misunderstood or not even used so I decided to organize a poll about on [twitter](https://twitter.com/imperioworld_/status/1232769353503956994). After 87 votes, the result is very clear: it's not useful. Considering the amount of code we have just to run it, I think it's definitely worth it to remove it. r? @kinnison cc @ollie27

view details

Mazdak Farrokhzad

commit sha 5a62acaf9e456280339f37ca2e43fcb277772a18

Rollup merge of #69677 - petrochenkov:spancode, r=eddyb rustc_metadata: Give decoder access to whole crate store Pre-requisite for https://github.com/rust-lang/rust/pull/68941. r? @eddyb

view details

Mazdak Farrokhzad

commit sha 977d69fc1992b0cef8d8ff020261d5bf9ede7424

Rollup merge of #69714 - spastorino:place-ref-lifetime, r=oli-obk Make PlaceRef take just one lifetime r? @eddyb

view details

Mazdak Farrokhzad

commit sha 6ad5e69b5af63f9044a4fab81450d49303ae8839

Rollup merge of #69799 - TimDiekmann:zst, r=Amanieu Allow ZSTs in `AllocRef` Allows ZSTs in all `AllocRef` methods. The implementation of `AllocRef` for `Global` and `System` were adjusted to reflect those changes. This is the second item on the roadmap to support ZSTs in `AllocRef`: https://github.com/rust-lang/wg-allocators/issues/38#issuecomment-595861542 After this has landed, I will adapt `RawVec`, but since this will be a pretty big overhaul, it makes sense to do a different PR for it. ~~Requires #69794 to land first~~ r? @Amanieu

view details

Mazdak Farrokhzad

commit sha 08095f4978b1dbf1aba584969e314a3caac705a2

Rollup merge of #69817 - thekuom:test/borrow-checking-pattern-features, r=Centril test(patterns): add patterns feature tests to borrowck test suite Addresses request here: https://github.com/rust-lang/rust/pull/69690#issuecomment-595763571 Fixes https://github.com/rust-lang/rust/issues/67311. r? @Centril

view details

Mazdak Farrokhzad

commit sha 436f2ec58cecdba7b03a05d89a90e6bce1e13500

Rollup merge of #69836 - JohnTitor:immediate-outputs, r=nagisa Check if output is immediate value Fixes #62046 r? @nagisa

view details

Mazdak Farrokhzad

commit sha 6f1db996c19c8eed59554b83be3ca9863cef0690

Rollup merge of #69847 - GuillaumeGomez:cleanup-e0393, r=Dylan-DPC clean up E0393 explanation r? @Dylan-DPC

view details

push time in 7 days

PR closed rust-lang/rust

Upgrade rustc and bootstrap dependencies S-waiting-on-author
+0 -0

12 comments

0 changed file

mati865

pr closed time in 7 days

issue commentrust-lang/rust

i686-pc-windows-gnu fails to link on appveyor

Has it started with latest nightly? It'd be good to rule out AppVeyor change by installing previously working nightly.

retep998

comment created time in 9 days

pull request commentmsys2/MINGW-packages

New package: capnproto

@kentonv there is a guard in the headers so you could define _WIN32_WINNT before including anything.

Xanewok

comment created time in 10 days

pull request commentmsys2/MINGW-packages

New package: capnproto

@kentonv MSYS2 supports Windows 7 and the headers reflect it. Applications that wish keep control over should undef it first. It's harmless warning though.

Xanewok

comment created time in 10 days

pull request commentrust-lang/rust

Prevent compiler stack overflow for deeply recursive code

@oli-obk it failed twice due to network issue. The error:

failed to fetch https://github.com/rust-lang/crates.io-index

oli-obk

comment created time in 11 days

issue commentrust-lang/rust

rustc segfault

Backtrace:

#0  0x00007ffff7f3dcf5 in pthread_cond_wait@@GLIBC_2.3.2 () from /usr/lib/libpthread.so.0
#1  0x0000555555f45e0e in jobserver::HelperState::for_each_request ()
#2  0x0000555555f461dc in std::sys_common::backtrace::__rust_begin_short_backtrace ()
#3  0x0000555555f46d38 in core::ops::function::FnOnce::call_once{{vtable-shim}} ()
#4  0x0000555555f5bd8f in <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once () at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa/src/liballoc/boxed.rs:1017
#5  0x0000555555f7e70d in <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once () at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa/src/liballoc/boxed.rs:1017
#6  std::sys_common::thread::start_thread () at src/libstd/sys_common/thread.rs:13
#7  std::sys::unix::thread::Thread::new::thread_start () at src/libstd/sys/unix/thread.rs:80
#8  0x00007ffff7f3746f in start_thread () from /usr/lib/libpthread.so.0
#9  0x00007ffff7e4d3d3 in clone () from /usr/lib/libc.so.6

https://github.com/rust-lang/rust/pull/68663 looks suspicious and I sort of confirmed it: nightly-2020-01-31 works fine but nightly-2020-02-01 crashes. cc @alexcrichton First broken nightly

haraldh

comment created time in 13 days

issue commentrust-lang/cargo

Cannot build statically linked cargo on musl with RUSTFLAGS="-C target-feature=+crt-static"

@ehuss I'm no longer actively using musl target but I suppose it's fixed.

jirutka

comment created time in 15 days

pull request commentrust-lang/rust

use "gcc" instead of "cc" on *-sun-solaris systems when linking

Wouldn't it be better to set proper linker name in the solaris spec files?

jclulow

comment created time in 16 days

startedsvenstaro/cargo-profiler

started time in 16 days

pull request commentrust-lang/rust

Use unrolled loop for searching NULL in [u16] on Windows

@wesleywiser in my case it was official nightly windows-gnu (the same build) running this benchmark: https://github.com/lzutao/rust-benches-wmemchr/blob/d545e5b5ae48dcf6c4071b86995a32d4da6aebe3/benches/wmemchr.rs Today iter::position ran twice as fast for me (did multiple runs yesterday and today), calling mingw-w64 wmemchr from Rust code gave identical performance as yesterday.

Now on the CI, iter::position on windows-gnu ran almost two times faster than on windows-msvc

No idea whether that benchmark has some bug or what.

lzutao

comment created time in 17 days

pull request commentrust-lang/rust

Use unrolled loop for searching NULL in [u16] on Windows

@lzutao benchmarking iter::position is somehow nonreproducible. Unrolled function performs similarly between windows-gnu and windows-msvc but iter::position does not. That's the same inconsistency I've encountered locally with windows-gnu.

lzutao

comment created time in 17 days

issue commentrust-lang/rust

Statics don't support alignments larger than the page size

Slight offtopic but windows-gnu rustc 1.43.0-nightly (c20d7eecb 2020-03-11) hangs trying to compile this code:

<details> <summary>Stack</summary>


rustc_driver-3846b4b120a304cc.dll!ZN57_$LT$log..ParseLevelError$u20$as$u20$core..fmt..Debug$GT$3fmt17hbfdab30e317c4c20E+0x8b36bb
rustc_driver-3846b4b120a304cc.dll!ZN57_$LT$log..ParseLevelError$u20$as$u20$core..fmt..Debug$GT$3fmt17hbfdab30e317c4c20E+0xbc7444
rustc_driver-3846b4b120a304cc.dll!ZN57_$LT$log..ParseLevelError$u20$as$u20$core..fmt..Debug$GT$3fmt17hbfdab30e317c4c20E+0xbc72f7
rustc_driver-3846b4b120a304cc.dll!ZN57_$LT$log..ParseLevelError$u20$as$u20$core..fmt..Debug$GT$3fmt17hbfdab30e317c4c20E+0xb30d26
rustc_driver-3846b4b120a304cc.dll!ZN57_$LT$log..ParseLevelError$u20$as$u20$core..fmt..Debug$GT$3fmt17hbfdab30e317c4c20E+0xafe3d4
rustc_driver-3846b4b120a304cc.dll!ZN57_$LT$log..ParseLevelError$u20$as$u20$core..fmt..Debug$GT$3fmt17hbfdab30e317c4c20E+0xe1b07a
rustc_driver-3846b4b120a304cc.dll!ZN57_$LT$log..ParseLevelError$u20$as$u20$core..fmt..Debug$GT$3fmt17hbfdab30e317c4c20E+0x17d8948
rustc_driver-3846b4b120a304cc.dll!ZN57_$LT$log..ParseLevelError$u20$as$u20$core..fmt..Debug$GT$3fmt17hbfdab30e317c4c20E+0x47d40
rustc_driver-3846b4b120a304cc.dll!ZN18rustc_codegen_llvm5type_120_$LT$impl$u20$rustc_codegen_ssa..traits..type_..LayoutTypeMethods$u20$for$u20$rustc_codegen_llvm..context..CodegenCx$GT$16reg_backend_type17h2e5962d8cdec0839E+0x1c57a
rustc_driver-3846b4b120a304cc.dll!ZN93_$LT$rustc_codegen_llvm..back..write..DiagnosticHandlers$u20$as$u20$core..ops..drop..Drop$GT$4drop17h9feab9942b78b38dE+0x232a
rustc_driver-3846b4b120a304cc.dll!ZN89_$LT$rustc_codegen_llvm..llv$u6d$_..OperandBundleDef$u20$as$u20$core..ops..drop..Drop$GT$4drop17h1b289036a4b6c754E+0x7885
rustc_driver-3846b4b120a304cc.dll!ZN81_$LT$rustc_codegen_llvm..llv$u6d$_..ffi..PassKind$u20$as$u20$core..fmt..Debug$GT$3fmt17h33c3c6083599899aE+0x8120
rustc_driver-3846b4b120a304cc.dll!ZN116_$LT$rustc_target..abi..TyLayout$LT$$RF$rustc..ty..TyS$GT$$u20$as$u20$rustc_codegen_llvm..type_of..LayoutLlvmExt$GT$15pointee_info_at17ha9a0722bbe04da49E+0x50a6
std-bb1869756d5e28c4.dll!_rust_maybe_catch_panic+0x19
rustc_driver-3846b4b120a304cc.dll!ZN107_$LT$rustc_codegen_llvm..builder..Builder$u20$as$u20$rustc_codegen_ssa..traits..builder..BuilderMethods$GT$14unchecked_umul17hb224b4a0601dcf96E+0x43222
std-bb1869756d5e28c4.dll+0x88f6
std-bb1869756d5e28c4.dll!ZN3std3sys7windows6thread6Thread3new17h64299152593e9dd6E+0x14c
KERNEL32.DLL!BaseThreadInitThunk+0x14
ntdll.dll!RtlUserThreadStart+0x21

</details>

Amanieu

comment created time in 17 days

pull request commentrust-lang/rust

Use wmemchr for searching NULL in [u16] on Windows

For window-gnu on Ryzen R7 2700X box wmemchr variant is roughly twice as fast

That's nice but gnu env uses memchr under the hood so wmemchr should be quite optimized there.

To be clear, windows-gnu doesn't use CRT for that but it's own implementation: https://gitlab.com/mati865/mingw-w64-mirror/-/blob/7c03b11bf173944679102bbe0ac061842e2f594b/mingw-w64-crt/misc/wmemchr.c#L25


It's hard to explain but using exactly the same nightly iter::position on the same system became about twice as fast today and is on pair with wmemchr. Unrolled is roughly two times faster than them:

<details> <summary>Details</summary>


running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Benchmarking small slice      [no null in slice]/iter::position
Benchmarking small slice      [no null in slice]/iter::position: Warming up for 3.0000 s
Benchmarking small slice      [no null in slice]/iter::position: Collecting 100 samples in estimated 5.0002 s (64M iterations)
Benchmarking small slice      [no null in slice]/iter::position: Analyzing
small slice      [no null in slice]/iter::position
                        time:   [72.035 ns 72.096 ns 72.170 ns]
Benchmarking small slice      [no null in slice]/wmemchr
Benchmarking small slice      [no null in slice]/wmemchr: Warming up for 3.0000 s
Benchmarking small slice      [no null in slice]/wmemchr: Collecting 100 samples in estimated 5.0002 s (67M iterations)
Benchmarking small slice      [no null in slice]/wmemchr: Analyzing
small slice      [no null in slice]/wmemchr
                        time:   [74.066 ns 74.123 ns 74.191 ns]
Found 26 outliers among 100 measurements (26.00%)
  13 (13.00%) low mild
  9 (9.00%) high mild
  4 (4.00%) high severe
Benchmarking small slice      [no null in slice]/unrolled
Benchmarking small slice      [no null in slice]/unrolled: Warming up for 3.0000 s
Benchmarking small slice      [no null in slice]/unrolled: Collecting 100 samples in estimated 5.0001 s (130M iterations)
Benchmarking small slice      [no null in slice]/unrolled: Analyzing
small slice      [no null in slice]/unrolled
                        time:   [38.224 ns 38.261 ns 38.319 ns]
Found 3 outliers among 100 measurements (3.00%)
  2 (2.00%) high mild
  1 (1.00%) high severe

Benchmarking small slice      [null in the middle of slice]/iter::position
Benchmarking small slice      [null in the middle of slice]/iter::position: Warming up for 3.0000 s
Benchmarking small slice      [null in the middle of slice]/iter::position: Collecting 100 samples in estimated 5.0001 s (85M iterations)
Benchmarking small slice      [null in the middle of slice]/iter::position: Analyzing
small slice      [null in the middle of slice]/iter::position
                        time:   [58.422 ns 58.495 ns 58.597 ns]
Found 24 outliers among 100 measurements (24.00%)
  8 (8.00%) low severe
  3 (3.00%) low mild
  4 (4.00%) high mild
  9 (9.00%) high severe
Benchmarking small slice      [null in the middle of slice]/wmemchr
Benchmarking small slice      [null in the middle of slice]/wmemchr: Warming up for 3.0000 s
Benchmarking small slice      [null in the middle of slice]/wmemchr: Collecting 100 samples in estimated 5.0001 s (82M iterations)
Benchmarking small slice      [null in the middle of slice]/wmemchr: Analyzing
small slice      [null in the middle of slice]/wmemchr
                        time:   [60.681 ns 60.768 ns 60.872 ns]
Found 19 outliers among 100 measurements (19.00%)
  2 (2.00%) low mild
  4 (4.00%) high mild
  13 (13.00%) high severe
Benchmarking small slice      [null in the middle of slice]/unrolled
Benchmarking small slice      [null in the middle of slice]/unrolled: Warming up for 3.0000 s
Benchmarking small slice      [null in the middle of slice]/unrolled: Collecting 100 samples in estimated 5.0001 s (173M iterations)
Benchmarking small slice      [null in the middle of slice]/unrolled: Analyzing
small slice      [null in the middle of slice]/unrolled
                        time:   [28.801 ns 28.828 ns 28.863 ns]
Found 24 outliers among 100 measurements (24.00%)
  2 (2.00%) low severe
  6 (6.00%) low mild
  3 (3.00%) high mild
  13 (13.00%) high severe

Benchmarking small slice      [null at the end of slice]/iter::position
Benchmarking small slice      [null at the end of slice]/iter::position: Warming up for 3.0000 s
Benchmarking small slice      [null at the end of slice]/iter::position: Collecting 100 samples in estimated 5.0003 s (68M iterations)
Benchmarking small slice      [null at the end of slice]/iter::position: Analyzing
small slice      [null at the end of slice]/iter::position
                        time:   [73.022 ns 73.115 ns 73.227 ns]
Found 16 outliers among 100 measurements (16.00%)
  7 (7.00%) low mild
  5 (5.00%) high mild
  4 (4.00%) high severe
Benchmarking small slice      [null at the end of slice]/wmemchr
Benchmarking small slice      [null at the end of slice]/wmemchr: Warming up for 3.0000 s
Benchmarking small slice      [null at the end of slice]/wmemchr: Collecting 100 samples in estimated 5.0001 s (65M iterations)
Benchmarking small slice      [null at the end of slice]/wmemchr: Analyzing
small slice      [null at the end of slice]/wmemchr
                        time:   [76.097 ns 76.297 ns 76.520 ns]
Benchmarking small slice      [null at the end of slice]/unrolled
Benchmarking small slice      [null at the end of slice]/unrolled: Warming up for 3.0000 s
Benchmarking small slice      [null at the end of slice]/unrolled: Collecting 100 samples in estimated 5.0001 s (130M iterations)
Benchmarking small slice      [null at the end of slice]/unrolled: Analyzing
small slice      [null at the end of slice]/unrolled
                        time:   [38.251 ns 38.301 ns 38.366 ns]
Found 9 outliers among 100 measurements (9.00%)
  2 (2.00%) high mild
  7 (7.00%) high severe

Benchmarking [medium slice    [no null in slice]/iter::position
Benchmarking [medium slice    [no null in slice]/iter::position: Warming up for 3.0000 s
Benchmarking [medium slice    [no null in slice]/iter::position: Collecting 100 samples in estimated 5.0054 s (323k iterations)
Benchmarking [medium slice    [no null in slice]/iter::position: Analyzing
[medium slice    [no null in slice]/iter::position
                        time:   [15.424 us 15.437 us 15.451 us]
Found 17 outliers among 100 measurements (17.00%)
  5 (5.00%) low mild
  8 (8.00%) high mild
  4 (4.00%) high severe
Benchmarking [medium slice    [no null in slice]/wmemchr
Benchmarking [medium slice    [no null in slice]/wmemchr: Warming up for 3.0000 s
Benchmarking [medium slice    [no null in slice]/wmemchr: Collecting 100 samples in estimated 5.0184 s (323k iterations)
Benchmarking [medium slice    [no null in slice]/wmemchr: Analyzing
[medium slice    [no null in slice]/wmemchr
                        time:   [15.527 us 15.564 us 15.606 us]
Found 6 outliers among 100 measurements (6.00%)
  3 (3.00%) high mild
  3 (3.00%) high severe
Benchmarking [medium slice    [no null in slice]/unrolled
Benchmarking [medium slice    [no null in slice]/unrolled: Warming up for 3.0000 s
Benchmarking [medium slice    [no null in slice]/unrolled: Collecting 100 samples in estimated 5.0231 s (520k iterations)
Benchmarking [medium slice    [no null in slice]/unrolled: Analyzing
[medium slice    [no null in slice]/unrolled
                        time:   [9.6392 us 9.6740 us 9.7123 us]
Found 10 outliers among 100 measurements (10.00%)
  3 (3.00%) high mild
  7 (7.00%) high severe

Benchmarking medium slice     [null in the middle of slice]/iter::position
Benchmarking medium slice     [null in the middle of slice]/iter::position: Warming up for 3.0000 s
Benchmarking medium slice     [null in the middle of slice]/iter::position: Collecting 100 samples in estimated 5.0310 s (434k iterations)
Benchmarking medium slice     [null in the middle of slice]/iter::position: Analyzing
medium slice     [null in the middle of slice]/iter::position
                        time:   [11.540 us 11.563 us 11.593 us]
Found 6 outliers among 100 measurements (6.00%)
  4 (4.00%) high mild
  2 (2.00%) high severe
Benchmarking medium slice     [null in the middle of slice]/wmemchr
Benchmarking medium slice     [null in the middle of slice]/wmemchr: Warming up for 3.0000 s
Benchmarking medium slice     [null in the middle of slice]/wmemchr: Collecting 100 samples in estimated 5.0271 s (434k iterations)
Benchmarking medium slice     [null in the middle of slice]/wmemchr: Analyzing
medium slice     [null in the middle of slice]/wmemchr
                        time:   [11.563 us 11.580 us 11.602 us]
Found 8 outliers among 100 measurements (8.00%)
  3 (3.00%) low mild
  4 (4.00%) high mild
  1 (1.00%) high severe
Benchmarking medium slice     [null in the middle of slice]/unrolled
Benchmarking medium slice     [null in the middle of slice]/unrolled: Warming up for 3.0000 s
Benchmarking medium slice     [null in the middle of slice]/unrolled: Collecting 100 samples in estimated 5.0178 s (692k iterations)
Benchmarking medium slice     [null in the middle of slice]/unrolled: Analyzing
medium slice     [null in the middle of slice]/unrolled
                        time:   [7.2313 us 7.2489 us 7.2777 us]
Found 3 outliers among 100 measurements (3.00%)
  2 (2.00%) high mild
  1 (1.00%) high severe

Benchmarking medium slice     [null at the end of slice]/iter::position
Benchmarking medium slice     [null at the end of slice]/iter::position: Warming up for 3.0000 s
Benchmarking medium slice     [null at the end of slice]/iter::position: Collecting 100 samples in estimated 5.0141 s (323k iterations)
Benchmarking medium slice     [null at the end of slice]/iter::position: Analyzing
medium slice     [null at the end of slice]/iter::position
                        time:   [15.472 us 15.501 us 15.539 us]
Found 5 outliers among 100 measurements (5.00%)
  5 (5.00%) high severe
Benchmarking medium slice     [null at the end of slice]/wmemchr
Benchmarking medium slice     [null at the end of slice]/wmemchr: Warming up for 3.0000 s
Benchmarking medium slice     [null at the end of slice]/wmemchr: Collecting 100 samples in estimated 5.0022 s (323k iterations)
Benchmarking medium slice     [null at the end of slice]/wmemchr: Analyzing
medium slice     [null at the end of slice]/wmemchr
                        time:   [15.418 us 15.436 us 15.455 us]
Found 23 outliers among 100 measurements (23.00%)
  7 (7.00%) low mild
  10 (10.00%) high mild
  6 (6.00%) high severe
Benchmarking medium slice     [null at the end of slice]/unrolled
Benchmarking medium slice     [null at the end of slice]/unrolled: Warming up for 3.0000 s
Benchmarking medium slice     [null at the end of slice]/unrolled: Collecting 100 samples in estimated 5.0318 s (520k iterations)
Benchmarking medium slice     [null at the end of slice]/unrolled: Analyzing
medium slice     [null at the end of slice]/unrolled
                        time:   [9.6401 us 9.6443 us 9.6490 us]
Found 28 outliers among 100 measurements (28.00%)
  11 (11.00%) low mild
  10 (10.00%) high mild
  7 (7.00%) high severe

</details>

lzutao

comment created time in 17 days

CommitCommentEvent

pull request commentrust-lang/rust-clippy

Rustup to rust-lang/rust#69589

Duplicate of https://github.com/rust-lang/rust-clippy/pull/5318

JohnTitor

comment created time in 18 days

pull request commentrust-lang/rust

Use wmemchr for searching NULL in [u16] on Windows

For window-gnu on Ryzen R7 2700X box wmemchr variant was roughly twice as fast. Results of cargo bench: <details> <summary>Details</summary>

Gnuplot not found, using plotters backend
Benchmarking small slice      [no null in slice]/iter::position
Benchmarking small slice      [no null in slice]/iter::position: Warming up for 3.0000 s
Benchmarking small slice      [no null in slice]/iter::position: Collecting 100 samples in estimated 5.0000 s (37M iterations)
Benchmarking small slice      [no null in slice]/iter::position: Analyzing
small slice      [no null in slice]/iter::position
                        time:   [132.00 ns 132.52 ns 133.09 ns]
                        change: [-1.8419% -1.2738% -0.7000%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high severe
Benchmarking small slice      [no null in slice]/wmemchr
Benchmarking small slice      [no null in slice]/wmemchr: Warming up for 3.0000 s
Benchmarking small slice      [no null in slice]/wmemchr: Collecting 100 samples in estimated 5.0003 s (66M iterations)
Benchmarking small slice      [no null in slice]/wmemchr: Analyzing
small slice      [no null in slice]/wmemchr
                        time:   [75.364 ns 75.735 ns 76.131 ns]
                        change: [-1.5130% -0.9615% -0.3817%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild

Benchmarking small slice      [null in the middle of slice]/iter::position
Benchmarking small slice      [null in the middle of slice]/iter::position: Warming up for 3.0000 s
Benchmarking small slice      [null in the middle of slice]/iter::position: Collecting 100 samples in estimated 5.0003 s (48M iterations)
Benchmarking small slice      [null in the middle of slice]/iter::position: Analyzing
small slice      [null in the middle of slice]/iter::position
                        time:   [104.68 ns 105.02 ns 105.38 ns]
                        change: [-0.9901% -0.5467% -0.1005%] (p = 0.02 < 0.05)
                        Change within noise threshold.
Found 7 outliers among 100 measurements (7.00%)
  7 (7.00%) high mild
Benchmarking small slice      [null in the middle of slice]/wmemchr
Benchmarking small slice      [null in the middle of slice]/wmemchr: Warming up for 3.0000 s
Benchmarking small slice      [null in the middle of slice]/wmemchr: Collecting 100 samples in estimated 5.0002 s (81M iterations)
Benchmarking small slice      [null in the middle of slice]/wmemchr: Analyzing
small slice      [null in the middle of slice]/wmemchr
                        time:   [61.391 ns 61.607 ns 61.838 ns]
                        change: [-0.5171% -0.1115% +0.2818%] (p = 0.60 > 0.05)
                        No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild

Benchmarking small slice      [null at the end of slice]/iter::position
Benchmarking small slice      [null at the end of slice]/iter::position: Warming up for 3.0000 s
Benchmarking small slice      [null at the end of slice]/iter::position: Collecting 100 samples in estimated 5.0005 s (37M iterations)
Benchmarking small slice      [null at the end of slice]/iter::position: Analyzing
small slice      [null at the end of slice]/iter::position
                        time:   [134.30 ns 134.75 ns 135.25 ns]
                        change: [-1.1961% -0.7560% -0.3037%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 10 outliers among 100 measurements (10.00%)
  1 (1.00%) low severe
  9 (9.00%) high mild
Benchmarking small slice      [null at the end of slice]/wmemchr
Benchmarking small slice      [null at the end of slice]/wmemchr: Warming up for 3.0000 s
Benchmarking small slice      [null at the end of slice]/wmemchr: Collecting 100 samples in estimated 5.0000 s (66M iterations)
Benchmarking small slice      [null at the end of slice]/wmemchr: Analyzing
small slice      [null at the end of slice]/wmemchr
                        time:   [76.419 ns 76.654 ns 76.929 ns]
                        change: [-1.2010% -0.7157% -0.2252%] (p = 0.01 < 0.05)
                        Change within noise threshold.
Found 10 outliers among 100 measurements (10.00%)
  10 (10.00%) high mild

Benchmarking [medium slice    [no null in slice]/iter::position
Benchmarking [medium slice    [no null in slice]/iter::position: Warming up for 3.0000 s
Benchmarking [medium slice    [no null in slice]/iter::position: Collecting 100 samples in estimated 5.0980 s (162k iterations)
Benchmarking [medium slice    [no null in slice]/iter::position: Analyzing
[medium slice    [no null in slice]/iter::position
                        time:   [31.464 us 31.564 us 31.673 us]
                        change: [-0.6138% -0.1810% +0.2327%] (p = 0.41 > 0.05)
                        No change in performance detected.
Benchmarking [medium slice    [no null in slice]/wmemchr
Benchmarking [medium slice    [no null in slice]/wmemchr: Warming up for 3.0000 s
Benchmarking [medium slice    [no null in slice]/wmemchr: Collecting 100 samples in estimated 5.0530 s (318k iterations)
Benchmarking [medium slice    [no null in slice]/wmemchr: Analyzing
[medium slice    [no null in slice]/wmemchr
                        time:   [15.824 us 15.912 us 16.027 us]
                        change: [-0.4151% +0.1534% +0.7968%] (p = 0.62 > 0.05)
                        No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
  2 (2.00%) high mild
  2 (2.00%) high severe

Benchmarking medium slice     [null in the middle of slice]/iter::position
Benchmarking medium slice     [null in the middle of slice]/iter::position: Warming up for 3.0000 s
Benchmarking medium slice     [null in the middle of slice]/iter::position: Collecting 100 samples in estimated 5.0215 s (212k iterations)
Benchmarking medium slice     [null in the middle of slice]/iter::position: Analyzing
medium slice     [null in the middle of slice]/iter::position
                        time:   [23.649 us 23.728 us 23.813 us]
                        change: [-1.3613% -0.9745% -0.5564%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 11 outliers among 100 measurements (11.00%)
  10 (10.00%) high mild
  1 (1.00%) high severe
Benchmarking medium slice     [null in the middle of slice]/wmemchr
Benchmarking medium slice     [null in the middle of slice]/wmemchr: Warming up for 3.0000 s
Benchmarking medium slice     [null in the middle of slice]/wmemchr: Collecting 100 samples in estimated 5.0533 s (424k iterations)
Benchmarking medium slice     [null in the middle of slice]/wmemchr: Analyzing
medium slice     [null in the middle of slice]/wmemchr
                        time:   [11.838 us 11.881 us 11.928 us]
                        change: [-0.7297% -0.2970% +0.1571%] (p = 0.20 > 0.05)
                        No change in performance detected.
Found 13 outliers among 100 measurements (13.00%)
  13 (13.00%) high mild

Benchmarking medium slice     [null at the end of slice]/iter::position
Benchmarking medium slice     [null at the end of slice]/iter::position: Warming up for 3.0000 s
Benchmarking medium slice     [null at the end of slice]/iter::position: Collecting 100 samples in estimated 5.1239 s (162k iterations)
Benchmarking medium slice     [null at the end of slice]/iter::position: Analyzing
medium slice     [null at the end of slice]/iter::position
                        time:   [31.429 us 31.551 us 31.679 us]
                        change: [-1.3095% -0.7629% -0.2579%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Benchmarking medium slice     [null at the end of slice]/wmemchr
Benchmarking medium slice     [null at the end of slice]/wmemchr: Warming up for 3.0000 s
Benchmarking medium slice     [null at the end of slice]/wmemchr: Collecting 100 samples in estimated 5.0453 s (318k iterations)
Benchmarking medium slice     [null at the end of slice]/wmemchr: Analyzing
medium slice     [null at the end of slice]/wmemchr
                        time:   [15.737 us 15.800 us 15.866 us]
                        change: [-1.1871% -0.8049% -0.4046%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 10 outliers among 100 measurements (10.00%)
  10 (10.00%) high mild

</details>

lzutao

comment created time in 18 days

issue commentmsys2/MINGW-packages

multiple definition of 'vsnprintf' with latest mingw-w64 update

Cc @mstorsjo who recently touched vsnprintf bits

Ede123

comment created time in 19 days

pull request commentrust-lang/rust-clippy

Improve release compile time

Do we know if change like this PR won't make Clippy run slower on large code bases?

lzutao

comment created time in 19 days

Pull request review commentrust-lang/rust-clippy

Remove git2 dependency.

 fn integration_test() {         .path()         .join(crate_name); -    Repository::clone(&repo_url, &repo_dir).expect("clone of repo failed");+    let st = Command::new("git")+        .args(&["clone", "--depth=1", &repo_url, repo_dir.to_str().unwrap()])+        .status()+        .expect("unstable to run git");
        .expect("unable to run git");
ehuss

comment created time in 19 days

push eventmati865/rust

push time in 21 days

Pull request review commentuutils/coreutils

Add GHA CICD

+name: CICD++# spell-checker:ignore (acronyms) CICD MSVC musl+# spell-checker:ignore (names) CodeCOV MacOS MinGW Peltoche rivy+# spell-checker:ignore (jargon) SHAs softprops toolchain+# spell-checker:ignore (shell/tools) choco clippy dmake esac fakeroot gmake halium libssl mkdir popd printf pushd rustc rustfmt rustup+# spell-checker:ignore (misc) gnueabihf issuecomment maint onexitbegin onexitend uutils++env:+  PROJECT_NAME: uutils+  PROJECT_DESC: "'Universal' (cross-platform) CLI utilities"+  PROJECT_AUTH: "uutils"+  RUST_MIN_SRV: "1.31.0"++on: [push, pull_request]++jobs:+  style:+    name: Style+    runs-on: ${{ matrix.job.os }}+    strategy:+      fail-fast: false+      matrix:+        job:+          - { os: ubuntu-latest   , features: unix }+          - { os: macos-latest    , features: unix }+          - { os: windows-latest  , features: windows }+    steps:+    - uses: actions/checkout@v1+    - name: Initialize workflow variables+      id: vars+      shell: bash+      run: |+        ## VARs setup+        # #maint: [rivy; 2020-02-08] 'windows-latest' `cargo fmt` is bugged for this project (see reasons @ GH:rust-lang/rustfmt #3324, #3590, #3688 ; waiting for repair)+        JOB_DO_FORMAT_TESTING="true"+        case '${{ matrix.job.os }}' in windows-latest) unset JOB_DO_FORMAT_TESTING ;; esac;+        echo set-output name=JOB_DO_FORMAT_TESTING::${JOB_DO_FORMAT_TESTING:-<empty>/false}+        echo ::set-output name=JOB_DO_FORMAT_TESTING::${JOB_DO_FORMAT_TESTING}+    - name: Install `rust` toolchain+      uses: actions-rs/toolchain@v1+      with:+        toolchain: stable+        override: true+        profile: minimal # minimal component installation (ie, no documentation)+        components: rustfmt, clippy+    - name: "`fmt` testing"+      if: steps.vars.outputs.JOB_DO_FORMAT_TESTING+      uses: actions-rs/cargo@v1+      with:+        command: fmt+        args: --all -- --check+    - name: "`clippy` testing"+      if: success() || failure() # run regardless of prior step ("`fmt` testing") success/failure+      uses: actions-rs/cargo@v1+      with:+        command: clippy+        args: ${{ matrix.job.cargo-options }} --features "${{ matrix.job.features }}" -- -D warnings++  min_version:+    name: MinSRV # Minimum supported rust version+    runs-on: ubuntu-latest+    steps:+    - uses: actions/checkout@v1+    - name: Install `rust` toolchain (v${{ env.RUST_MIN_SRV }})+      uses: actions-rs/toolchain@v1+      with:+        toolchain: ${{ env.RUST_MIN_SRV }}+        profile: minimal # minimal component installation (ie, no documentation)+    - name: Test+      uses: actions-rs/cargo@v1+      with:+        command: test+        args: --features "feat_os_unix"++  build:+    name: Build+    runs-on: ${{ matrix.job.os }}+    strategy:+      fail-fast: false+      matrix:+        job:+          # { os, target, cargo-options, features, use-cross, toolchain }+          - { os: ubuntu-latest  , target: arm-unknown-linux-gnueabihf , features: feat_os_unix_gnueabihf , use-cross: use-cross }+          - { os: ubuntu-16.04   , target: x86_64-unknown-linux-gnu    , features: feat_os_unix           , use-cross: use-cross }+          - { os: ubuntu-18.04   , target: i686-unknown-linux-gnu      , features: feat_os_unix           , use-cross: use-cross }+          - { os: ubuntu-18.04   , target: i686-unknown-linux-musl     , features: feat_os_unix_musl      , use-cross: use-cross }+          - { os: ubuntu-18.04   , target: x86_64-unknown-linux-gnu    , features: feat_os_unix           , use-cross: use-cross }+          - { os: ubuntu-18.04   , target: x86_64-unknown-linux-musl   , features: feat_os_unix_musl      , use-cross: use-cross }+          - { os: macos-latest   , target: x86_64-apple-darwin         , features: feat_os_unix }+          - { os: windows-latest , target: i686-pc-windows-gnu         , features: feat_os_windows }+          - { os: windows-latest , target: i686-pc-windows-msvc        , features: feat_os_windows }+          - { os: windows-latest , target: x86_64-pc-windows-gnu       , features: feat_os_windows , toolchain: nightly-x86_64-pc-windows-gnu }   ## !maint: [rivy; due 2020-21-03] disable/remove when rust beta >= v1.43.0 is available (~mid-March)+          # - { os: windows-latest , target: x86_64-pc-windows-gnu       , features: feat_os_windows , toolchain: beta-x86_64-pc-windows-gnu }      ## maint: [rivy; due 2020-21-03; due 2020-01-05] enable when rust beta >= v1.43.0 is available (~mid-March); disable when rust stable >= 1.43.0 is available (~early-May)+          # - { os: windows-latest , target: x86_64-pc-windows-gnu       , features: feat_os_windows } ## note: requires rust >= 1.43.0 to link correctly # ! maint: [rivy; due 2020-01-05] enable when rust stable >= 1.43.0 is available+          - { os: windows-latest , target: x86_64-pc-windows-msvc      , features: feat_os_windows }+    steps:+    - uses: actions/checkout@v1+    - name: Install/setup prerequisites+      shell: bash+      run: |+        ## install/setup prerequisites+        case '${{ matrix.job.target }}' in+          arm-unknown-linux-gnueabihf) sudo apt-get -y update ; sudo apt-get -y install gcc-arm-linux-gnueabihf ;;+          x86_64-pc-windows-gnu)+            # hack: move interfering 'gcc' to head of PATH; fixes linking errors, but only works for rust >= v1.43.0; see GH:rust-lang/rust#68872 (after potential fix GH:rust-lang/rust#67429) for further discussion/repairs; follow issue/solutions? via PR GH:rust-lang/rust#67429 (from GH:rust-lang/rust#47048#issuecomment-437409270); refs: GH:rust-lang/cargo#6754, GH:rust-lang/rust#47048 , GH:rust-lang/rust#53454 , GH:bike-barn/hermit#172+            echo  "::add-path::C:\\ProgramData\\Chocolatey\\lib\\mingw\\tools\\install\\mingw64\\bin"+            ;;

So, the fix for this hack is in nightly now?

Since two weeks and nobody complained so far.

It made it to the same release as my initial MinGW fix so will be included in beta soon (https://github.com/rust-lang/rust/pull/69886).

rivy

comment created time in 23 days

Pull request review commentuutils/coreutils

Add GHA CICD

+name: CICD++# spell-checker:ignore (acronyms) CICD MSVC musl+# spell-checker:ignore (names) CodeCOV MacOS MinGW Peltoche rivy+# spell-checker:ignore (jargon) SHAs softprops toolchain+# spell-checker:ignore (shell/tools) choco clippy dmake esac fakeroot gmake halium libssl mkdir popd printf pushd rustc rustfmt rustup+# spell-checker:ignore (misc) gnueabihf issuecomment maint onexitbegin onexitend uutils++env:+  PROJECT_NAME: uutils+  PROJECT_DESC: "'Universal' (cross-platform) CLI utilities"+  PROJECT_AUTH: "uutils"+  RUST_MIN_SRV: "1.31.0"++on: [push, pull_request]++jobs:+  style:+    name: Style+    runs-on: ${{ matrix.job.os }}+    strategy:+      fail-fast: false+      matrix:+        job:+          - { os: ubuntu-latest   , features: unix }+          - { os: macos-latest    , features: unix }+          - { os: windows-latest  , features: windows }+    steps:+    - uses: actions/checkout@v1+    - name: Initialize workflow variables+      id: vars+      shell: bash+      run: |+        ## VARs setup+        # #maint: [rivy; 2020-02-08] 'windows-latest' `cargo fmt` is bugged for this project (see reasons @ GH:rust-lang/rustfmt #3324, #3590, #3688 ; waiting for repair)+        JOB_DO_FORMAT_TESTING="true"+        case '${{ matrix.job.os }}' in windows-latest) unset JOB_DO_FORMAT_TESTING ;; esac;+        echo set-output name=JOB_DO_FORMAT_TESTING::${JOB_DO_FORMAT_TESTING:-<empty>/false}+        echo ::set-output name=JOB_DO_FORMAT_TESTING::${JOB_DO_FORMAT_TESTING}+    - name: Install `rust` toolchain+      uses: actions-rs/toolchain@v1+      with:+        toolchain: stable+        override: true+        profile: minimal # minimal component installation (ie, no documentation)+        components: rustfmt, clippy+    - name: "`fmt` testing"+      if: steps.vars.outputs.JOB_DO_FORMAT_TESTING+      uses: actions-rs/cargo@v1+      with:+        command: fmt+        args: --all -- --check+    - name: "`clippy` testing"+      if: success() || failure() # run regardless of prior step ("`fmt` testing") success/failure+      uses: actions-rs/cargo@v1+      with:+        command: clippy+        args: ${{ matrix.job.cargo-options }} --features "${{ matrix.job.features }}" -- -D warnings++  min_version:+    name: MinSRV # Minimum supported rust version+    runs-on: ubuntu-latest+    steps:+    - uses: actions/checkout@v1+    - name: Install `rust` toolchain (v${{ env.RUST_MIN_SRV }})+      uses: actions-rs/toolchain@v1+      with:+        toolchain: ${{ env.RUST_MIN_SRV }}+        profile: minimal # minimal component installation (ie, no documentation)+    - name: Test+      uses: actions-rs/cargo@v1+      with:+        command: test+        args: --features "feat_os_unix"++  build:+    name: Build+    runs-on: ${{ matrix.job.os }}+    strategy:+      fail-fast: false+      matrix:+        job:+          # { os, target, cargo-options, features, use-cross, toolchain }+          - { os: ubuntu-latest  , target: arm-unknown-linux-gnueabihf , features: feat_os_unix_gnueabihf , use-cross: use-cross }+          - { os: ubuntu-16.04   , target: x86_64-unknown-linux-gnu    , features: feat_os_unix           , use-cross: use-cross }+          - { os: ubuntu-18.04   , target: i686-unknown-linux-gnu      , features: feat_os_unix           , use-cross: use-cross }+          - { os: ubuntu-18.04   , target: i686-unknown-linux-musl     , features: feat_os_unix_musl      , use-cross: use-cross }+          - { os: ubuntu-18.04   , target: x86_64-unknown-linux-gnu    , features: feat_os_unix           , use-cross: use-cross }+          - { os: ubuntu-18.04   , target: x86_64-unknown-linux-musl   , features: feat_os_unix_musl      , use-cross: use-cross }+          - { os: macos-latest   , target: x86_64-apple-darwin         , features: feat_os_unix }+          - { os: windows-latest , target: i686-pc-windows-gnu         , features: feat_os_windows }+          - { os: windows-latest , target: i686-pc-windows-msvc        , features: feat_os_windows }+          - { os: windows-latest , target: x86_64-pc-windows-gnu       , features: feat_os_windows , toolchain: nightly-x86_64-pc-windows-gnu }   ## !maint: [rivy; due 2020-21-03] disable/remove when rust beta >= v1.43.0 is available (~mid-March)+          # - { os: windows-latest , target: x86_64-pc-windows-gnu       , features: feat_os_windows , toolchain: beta-x86_64-pc-windows-gnu }      ## maint: [rivy; due 2020-21-03; due 2020-01-05] enable when rust beta >= v1.43.0 is available (~mid-March); disable when rust stable >= 1.43.0 is available (~early-May)+          # - { os: windows-latest , target: x86_64-pc-windows-gnu       , features: feat_os_windows } ## note: requires rust >= 1.43.0 to link correctly # ! maint: [rivy; due 2020-01-05] enable when rust stable >= 1.43.0 is available+          - { os: windows-latest , target: x86_64-pc-windows-msvc      , features: feat_os_windows }+    steps:+    - uses: actions/checkout@v1+    - name: Install/setup prerequisites+      shell: bash+      run: |+        ## install/setup prerequisites+        case '${{ matrix.job.target }}' in+          arm-unknown-linux-gnueabihf) sudo apt-get -y update ; sudo apt-get -y install gcc-arm-linux-gnueabihf ;;+          x86_64-pc-windows-gnu)+            # hack: move interfering 'gcc' to head of PATH; fixes linking errors, but only works for rust >= v1.43.0; see GH:rust-lang/rust#68872 (after potential fix GH:rust-lang/rust#67429) for further discussion/repairs; follow issue/solutions? via PR GH:rust-lang/rust#67429 (from GH:rust-lang/rust#47048#issuecomment-437409270); refs: GH:rust-lang/cargo#6754, GH:rust-lang/rust#47048 , GH:rust-lang/rust#53454 , GH:bike-barn/hermit#172+            echo  "::add-path::C:\\ProgramData\\Chocolatey\\lib\\mingw\\tools\\install\\mingw64\\bin"+            ;;

Fixed by https://github.com/rust-lang/rust/pull/69351

rivy

comment created time in 23 days

issue commentmsys2/MINGW-packages

Please help getting Rust 1.40 working

Rust 1.41.1 is available in the repo, we can close this issue.

allquixotic

comment created time in 24 days

Pull request review commentrust-lang/rust

Don't use static crt by default when build proc-macro

+// Test proc-macro crate can be built without addtional RUSTFLAGS+// on musl target++// build-pass+// only-musl

@smaeul it failed on x86_64-gnu-llvm-7.

12101111

comment created time in 25 days

pull request commentrust-lang/rust

Don't use static crt by default when build proc-macro

I fairly confident your test would pass regardless of changes in this PR. dist-i586-gnu-i586-i686-musl cross compiles tests from x86_64-unknown-linux-gnu and proc-macro works fine in that case. x86_64-unknown-linux-musl runs tests with -crt-static in order to make dylib tests like run-make-fulldeps pass. This also makes all proc-macro tests pass.

12101111

comment created time in 25 days

issue commentrust-lang/rust

Linking with LLD

@petrochenkov yes I could build it with some hacks:

  • LLD COFF backend doesn't support linker scripts but both LD and LLD are fine with MSVC style .def files; easy to solve
  • LLD expects libraries to start with lib (it's a standard in UNIX world) but somehow Rust ended up not doing it for all windows-* targets: https://github.com/rust-lang/rust/blob/9ebf47851a357faa4cd97f4b1dc7835f6376e639/src/libstd/sys/windows/env.rs#L4 LD doesn't mind either way and I don't know whether to push on LLD or Rust side to fix it.
bstrie

comment created time in a month

pull request commentrust-lang/rust

Optimize catch_unwind to match C++ try/catch

Back when I wrote this code, I thought the desired final outcome was to have a 100% Rust toolchain, or. at least, one that depended only on LLVM libraries and tools.

libgcc could be replaced by compiler-rt+libunwind already but I doubt it'd change anything for this issue.

Mark-Simulacrum

comment created time in a month

pull request commentrust-lang/rust

Rollup of 6 pull requests

#69676 was marked as rollup=never (confirmed homu queue website). How it got included?

Centril

comment created time in a month

pull request commentlaumann/compiletest-rs

Fix some warnings

Sure, I can drop Clippy changes and move them to upstream instead.

mati865

comment created time in a month

PR opened laumann/compiletest-rs

Fix some warnings
+39 -39

0 comment

6 changed files

pr created time in a month

create barnchmati865/compiletest-rs

branch : warnings

created branch time in a month

delete branch mati865/compiletest-rs

delete branch : bump-rustfix

delete time in a month

pull request commentrust-lang/rust-clippy

Fix version of quote to 1.0.2

Alternative solution is to drop failure entirely: https://github.com/laumann/compiletest-rs/pull/213

flip1995

comment created time in a month

PR opened laumann/compiletest-rs

Bump rustfix

Workarounds https://github.com/rust-lang-nursery/failure/issues/342 by getting rid of failure.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchmati865/compiletest-rs

branch : bump-rustfix

created branch time in a month

delete branch mati865/MINGW-packages

delete branch : rust

delete time in a month

delete branch mati865/mdbook-linkcheck

delete branch : deps

delete time in a month

issue commentrust-lang/rust

Significant performance regression on the `encoding` benchmark

No idea, that's what perf shows 🤷‍♂

ecstatic-morse

comment created time in a month

issue commentrust-lang/rust

Significant performance regression on the `encoding` benchmark

Looking at https://perf.rust-lang.org/compare.html?start=d538b80ad77949e46989cd355cdec193b574f052&end=5d04ce67fd14538d03fa47a2598f80d49fd564c6&stat=task-clock there is only one PR (and also included in perf link you posted in OP): https://github.com/rust-lang/rust/pull/68406

ecstatic-morse

comment created time in a month

pull request commentMichael-F-Bryan/mdbook-linkcheck

Upgrade reqwest and pulldown-cmark dependencies

It's green now.

mati865

comment created time in a month

issue commentrust-lang/rust

TEXTREL in i686 since 1.41.0

Do you think it would be worth it to also include the regression test (#69168) in the release?

CCing the reviewers @tmandry @Mark-Simulacrum

Cogitri

comment created time in a month

push eventmati865/mdbook-linkcheck

Tom Parker-Shemilt

commit sha 6cec826f64c6df91c05d3640fc30f25b57cb9288

Uses rusttls to solve the problem of cross no longer includeing openssl

view details

Michael Bryan

commit sha fa0e1040940e11f03ce9249a14086d63df1104d3

Merge pull request #29 from palfrey/use-rusttls Use rustls for reqwest

view details

Mateusz Mikuła

commit sha 12243ffe79c07468cfd077eb4f22df91610bc615

Upgrade reqwest and pulldown-cmark dependencies

view details

push time in a month

issue commentrust-lang/rust

TEXTREL in i686 since 1.41.0

https://github.com/rust-lang/rust/pull/69086 is beta nominated, it will be backported soon and included in 1.42 release.

Cogitri

comment created time in a month

PR opened msys2/MINGW-packages

Update Rust to 1.41.1

WARNING: It won't build if build path is too long.

+8 -14

0 comment

3 changed files

pr created time in a month

push eventmati865/MINGW-packages

Christoph Reiter

commit sha 07737f8f88b0d6f1ec9a6783d9b087cde1d001b4

python-hacking: Drop Python 2 package

view details

Christoph Reiter

commit sha 79b165db76871df4ae93865ef360dda437ea98bf

python-ifaddr: Drop Python 2 package

view details

Christoph Reiter

commit sha 094d145b86a88bfc3c2b059f35067cc5c030ac05

python-ipywidgets: Drop Python 2 package

view details

Christoph Reiter

commit sha 5e1072b1b10b2faeabb6e3e0b917bcc171fc0395

python-json-rpc: Drop Python 2 package

view details

Christoph Reiter

commit sha 0d70968f7f5aa75ff4be14a9362a54a414f43d70

python-keras: Drop Python 2 package

view details

Christoph Reiter

commit sha f2cd9d37a11b831ff4af472ca1fae6b8512a678a

python-lhafile: Drop Python 2 package

view details

Christoph Reiter

commit sha 1ab40cb9ac370db9c3afc49501e111206f0cc30b

python-markups: Drop Python 2 package

view details

Christoph Reiter

commit sha 70f2fc4ac916904ae29aaf5f5056d47a7a675d3b

python-mistune: Drop Python 2 package

view details

Christoph Reiter

commit sha f8cc9e230020cca12001986feab7c3a9f8d522b5

python-oslo-concurrency: Drop Python 2 package

view details

Christoph Reiter

commit sha d95a3834e39d8e4aa8c9eaa7c53b38d644c549e9

python-oslo-db: Drop Python 2 package

view details

Christoph Reiter

commit sha b365d0ee83c5f77472dd97f05380bc5664d99763

python-oslosphinx: Drop Python 2 package

view details

Christoph Reiter

commit sha 0e72120109fff6cd5320331832e863ab4ee10fcf

python-pandocfilters: Drop Python 2 package

view details

Christoph Reiter

commit sha bfebc90b2318cfc8ad9975a2f6fee06ce3b2769f

python-pgen2: Drop Python 2 package

view details

Christoph Reiter

commit sha 9a666c84bde91915553a8de23a5f8567bf35c540

python-prometheus-client: Drop Python 2 package

view details

Christoph Reiter

commit sha 98aec9e4733b3a59fb36779b76c1948fc9f05fc2

python-protobuf: Drop Python 2 package

view details

Christoph Reiter

commit sha abe14eb65d836e440d9d7e3d38384cdf9035bdfa

python-pyamg: Drop Python 2 package

view details

Christoph Reiter

commit sha 6fe911eb70a693971f6e8778f51af6c5a961be11

python-pynacl: Drop Python 2 package

view details

Christoph Reiter

commit sha 01e75de8848c5672f56078722689871a606a6129

python-pyreadline: Drop Python 2 package

view details

Christoph Reiter

commit sha df1b6d7ebd71785e7b1f9399cec8758ecb571b53

python-pyserial: Drop Python 2 package

view details

Christoph Reiter

commit sha aaed52cdb79077b4400514828a78fe63e5a74643

python-pystemmer: Drop Python 2 package

view details

push time in a month

issue commentrust-lang/rust

provide a way of overriding the MinGW library path

@rivy I'm not decisive here.

If gcc is on the PATH and requested as a compiler, I do think that searching via faster known-path methods with a fallback to the slower gcc -print-file-name=crt2.o would be very reasonable.

Maybe it'd be feasible to do it only when cross compiling but you would need to discuss it with the team.

tanriol

comment created time in a month

delete branch mati865/rust

delete branch : mingw

delete time in a month

pull request commentrust-lang/rust

Improve MinGW detection when cross compiling

Tested both i686 and x86_64 builds, they work as good as before on Windows.

mati865

comment created time in a month

push eventmati865/rust

Mateusz Mikuła

commit sha cdb69556593c33023ca516795322ba75e6444b40

Update src/bootstrap/dist.rs Co-Authored-By: kennytm <kennytm@gmail.com>

view details

push time in a month

push eventmati865/rust

Mateusz Mikuła

commit sha 5ea383107e9dec640dbeaf0aa9eabad8b56ee742

Update src/bootstrap/dist.rs Co-Authored-By: kennytm <kennytm@gmail.com>

view details

push time in a month

issue commentrust-lang/rust

-Ctarget-cpu=skylake trashes ends_with_str performance

Assembly doesn't look suspicious: https://godbolt.org/z/BTxUDA

Right now I have Windows machine with totally different CPU nearby and it doesn't reproduce:

$ RUSTFLAGS="" cargo bench
   Compiling bench v0.1.0 (D:\msys64\home\mateusz\bench)
    Finished bench [optimized] target(s) in 2.44s
     Running target\release\deps\bench-2ddd0f70613232dd.exe

running 4 tests
test ends_with_char   ... bench:         288 ns/iter (+/- 16)
test ends_with_str    ... bench:         487 ns/iter (+/- 9)
test starts_with_char ... bench:         285 ns/iter (+/- 3)
test starts_with_str  ... bench:         289 ns/iter (+/- 15)

test result: ok. 0 passed; 0 failed; 0 ignored; 4 measured; 0 filtered out

$ RUSTFLAGS="-Ctarget-cpu=skylake" cargo bench
   Compiling bench v0.1.0 (D:\msys64\home\mateusz\bench)
    Finished bench [optimized] target(s) in 0.86s
     Running target\release\deps\bench-2ddd0f70613232dd.exe

running 4 tests
test ends_with_char   ... bench:         288 ns/iter (+/- 9)
test ends_with_str    ... bench:         413 ns/iter (+/- 8)
test starts_with_char ... bench:         287 ns/iter (+/- 18)
test starts_with_str  ... bench:         287 ns/iter (+/- 2)

test result: ok. 0 passed; 0 failed; 0 ignored; 4 measured; 0 filtered out

cpuinfo:

processor       : 15
vendor_id       : AuthenticAMD
cpu family      : 23
model           : 8
model name      : AMD Ryzen 7 2700X Eight-Core Processor
stepping        : 2
cpu MHz         : 3700.000
cache size      : 16384 KB
physical id     : 0
siblings        : 16
core id         : 7
cpu cores       : 8
apicid          : 15
initial apicid  : 15
fpu             : yes
fpu_exception   : yes
cpuid level     : 13
wp              : yes
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw skinit wdt tce topoext perfctr_core perfctr_nb perfctr_l2
clflush size    : 64
cache_alignment : 64
address sizes   : 48 bits physical, 48 bits virtual
power management: ts ttp tm hwpstate cpb eff_freq_ro

rustc -vV:

rustc 1.43.0-nightly (6fd8798f4 2020-02-25)
binary: rustc
commit-hash: 6fd8798f4de63328d743eb2a9a9c12e202a4a182
commit-date: 2020-02-25
host: x86_64-pc-windows-gnu
release: 1.43.0-nightly
LLVM version: 9.0

With -Ctarget-cpu=skylake there are AVX instructions generated. Maybe the CPU downclocks a lot since it's low TDP CPU? Do you have other machines to test it on?

matthiaskrgr

comment created time in a month

issue commentmstorsjo/llvm-mingw

[LLD] Version script support

Builds are taking quite some time but now I can confirm LD does work when LIBRARY is gone and the file has .def extension. Thank you for your time!

mati865

comment created time in a month

issue commentmstorsjo/llvm-mingw

[LLD] Version script support

It's the same result when it's named list.def. There is defparse code inside binutils repo but it appears to be used only by dlltool: https://github.com/bminor/binutils-gdb/search?p=1&q=defparse

mati865

comment created time in a month

issue commentmstorsjo/llvm-mingw

[LLD] Version script support

Passed to Clang with "-Wl,C:\\Users\\mateusz\\AppData\\Local\\Temp\\rustcylZC2s\\list":

D:\msys64\mingw64\bin\ld:
  C:\Users\mateusz\AppData\Local\Temp\rustcylZC2s\list: file format not recognized; treating as linker script
D:\msys64\mingw64\bin\ld:
  C:\Users\mateusz\AppData\Local\Temp\rustcylZC2s\list:2: syntax error

Def file contents: https://gist.github.com/mati865/85265364bcaaacc101e33a77f059a896

mati865

comment created time in a month

issue commentmstorsjo/llvm-mingw

[LLD] Version script support

Continuation to discussion in https://github.com/mstorsjo/llvm-mingw/issues/56

Seems like reusing .def files created for link.exe isn't viable option because Binutils LD doesn't understand them. Universal solution working for both LD and LLD is necessary because Rust calls CC (both GCC and Clang do work) so it cannot distinguish the linker.

Supporting LLD will have to wait until then.

mati865

comment created time in a month

PR opened rust-lang/rust

Improve MinGW detection when cross compiling

Official mingw-w64 builds, MSYS2 and LLVM MinGW provide both gcc.exe and $ARCH-w64-mingw32-gcc.exe so they should not regress but I included CI changes to verify it though @bors try (I don't have permission).

This change will come handy when cross compiling from Linux or Cygwin since they use gcc as native compiler and $ARCH-w64-mingw32-gcc.exe for MinGW. This means users will no longer have to override the linker.

+22 -60

0 comment

4 changed files

pr created time in a month

create barnchmati865/rust

branch : mingw

created branch time in a month

issue commentrust-lang/rust

`is_x86_feature_detected!("avx512f")` fails to build on nightly

It sounds like we specifically don't want to include mmx, though I'm not sure what to do with the other two.

Upstream topic about sse4a and tbm: https://github.com/rust-lang/stdarch/issues/668

oconnor663

comment created time in a month

issue commentmsys2/MINGW-packages

Clang's LLD is broken, again!

FTR here is stacktrace:

00000000`017be978 00007ffc`f5458ba3 : 00000000`000b0000 00007ffc`f7a8a867 00000000`000d0101 00000000`03890000 : ntdll!NtWaitForSingleObject+0x14
00000000`017be980 00000000`64942f6f : 00000000`00000002 00000000`000d0560 00000000`00000000 00000000`000002bc : KERNELBASE!WaitForSingleObjectEx+0x93
00000000`017bea20 00000000`64944c0f : 00000000`000b0000 00007ffc`f7a86139 00000000`00000000 00000000`64944ad3 : libwinpthread_1!pthread_mutex_lock+0xaf
00000000`017bea70 00000000`64946473 : 00000000`000b0000 00000000`000b0000 00000000`00000000 00000000`000bfa20 : libwinpthread_1!_pth_gpointer_locked+0x1f
00000000`017beab0 00000000`039d8b37 : 00000000`000cb0a0 00000000`053dfef0 00000000`7051b000 00000000`05f61a30 : libwinpthread_1!pthread_join+0x13
00000000`017beb00 00000000`6c45ad05 : 00000000`000bfa20 00000000`017bec98 00000000`00000000 00007ffc`e1419de0 : libstdc___6!ZNSt6thread4joinEv+0x17
00000000`017beb30 00000000`6c45b1ea : 00000000`00000003 00007ffc`f7a72bff 00000000`00000001 00000000`7ffe0385 : libLLVM!ZN4llvm14OptionRegistry8instanceEv+0x5d5
00000000`017bec20 00000000`6e777ac5 : 00000000`70577328 00000000`6e769963 00000000`053dff00 00000000`7051b000 : libLLVM!ZN4llvm14OptionRegistry8instanceEv+0xaba
00000000`017bec50 00000000`6c3c117c : 00000000`0000000d 00007ffc`f7a64ef7 00000000`00000000 00000000`00000001 : libLLVM!ZN4llvm16windows_manifest21WindowsManifestMerger25WindowsManifestMergerImpl13getParseErrorEv+0xfc25
00000000`017bec90 00000000`6c3c125d : 00000000`00000001 00007ffc`f4b8849e 00000000`00000000 00000000`00000000 : libLLVM+0x117c
00000000`017becf0 00007ffc`f7a650a1 : 00007ffc`00000000 00000000`00000000 00000000`00000001 00000000`7ffe0385 : libLLVM+0x125d
00000000`017bed40 00007ffc`f7aaab02 : 00000000`000b45a0 00000000`6c3c0000 00000000`00000000 00000000`6e768c70 : ntdll!LdrpCallInitRoutine+0x65
00000000`017bedb0 00007ffc`f7aaa9ad : 00000000`00000000 00000000`053e7ee0 00000000`00000035 00000000`00000000 : ntdll!LdrShutdownProcess+0x132
00000000`017beeb0 00007ffc`f603cd8a : 00000000`00000000 00000000`053e7ee0 00000000`6c49e250 00000000`00000035 : ntdll!RtlExitUserProcess+0xad
00000000`017beee0 00007ffc`f5fba245 : 00000000`7051b000 00000000`00000000 00000000`053e7ee0 00000000`00000001 : kernel32!ExitProcessImplementation+0xa
00000000`017bef10 00007ffc`f5fba8b5 : 00000000`00000001 00000000`6c4a0046 00000000`00000001 00000000`053e7ee0 : msvcrt!_crtExitProcess+0x15
00000000`017bef40 00000000`005cfc9f : 00000000`00000001 00000000`053e7ee0 00000000`00000000 00000000`053e8510 : msvcrt!doexit+0x171
00000000`017befb0 00000000`004128af : 00000000`053ecd40 00000000`006eb155 00000000`00000505 00000000`017bf1a0 : ld_lld+0x1cfc9f
00000000`017befe0 00000000`005503c1 : 00000000`0079e058 00000000`005d5e98 00000000`017bf410 00000000`017bf550 : ld_lld+0x128af
00000000`017bf070 00000000`0071f443 : 00000000`03c0d000 00000000`0073c893 00000000`00000000 00000000`00000000 : ld_lld+0x1503c1
00000000`017bfc80 00000000`004013b4 : 00000000`00000039 00000000`053d1820 00000000`007a6bb0 00000000`00000000 : ld_lld+0x31f443
00000000`017bfe30 00000000`0040150b : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : ld_lld+0x13b4
00000000`017bff00 00007ffc`f6037bd4 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : ld_lld+0x150b
00000000`017bff30 00007ffc`f7aaced1 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : kernel32!BaseThreadInitThunk+0x14
00000000`017bff60 00000000`00000000 : 00000000`00000000 00000000`00000000 00000000`00000000 00000000`00000000 : ntdll!RtlUserThreadStart+0x21

Probably a mingw-w64 bug.

HolyBlackCat

comment created time in a month

pull request commentMichael-F-Bryan/mdbook-linkcheck

Upgrade reqwest and pulldown-cmark dependencies

I think Travis has changed their images to not include openssl by default any more. To confirm that I triggered build for current master branch and it failed the same way: https://travis-ci.com/mati865/mdbook-linkcheck/builds/150833470

You can install openssl-dev package on the CI to solve it.

mati865

comment created time in a month

push eventmati865/mdbook-linkcheck

push time in a month

push eventmati865/mdbook-linkcheck

Michael Bryan

commit sha db375e219753114b4b3afc750c79783dde6c9b8c

Enabled the all-green test

view details

Michael Bryan

commit sha 9bf28fb85d369d3310851898b92484f79178199a

Updated dependencies

view details

Michael Bryan

commit sha 4b43fb255f9deec91d23ade9da57b999c5282ee5

Upgraded to the new codespan version

view details

Michael Bryan

commit sha 03548499b88f2fc412ce71937cce10b2250cede4

Made the binary compile again

view details

Michael Bryan

commit sha 6d05ba2e1c64bc90b1f2df68fe8a0407f64f4733

Made the tests compile again

view details

Michael Bryan

commit sha 3420e9068caa8859e55c9b2db0b9572ca2f7187a

Made sure all the tests pass again

view details

Michael Bryan

commit sha b48942c5891c5fe031a855dfe8ca8bc8e6e2fc94

Fixed some dodgy intra-docs links

view details

Michael Bryan

commit sha 9f64e078430cf33c6b2f0696242abd49879325ea

Made sure we can handle percent-encoded paths

view details

Michael Bryan

commit sha e4a79e9a08470a92229df81f658f517d4f6c301b

Fixes #18

view details

Michael Bryan

commit sha f64f647221b7e21a53b673c3ed57f0fdab3c1567

Merge branch 'percent-decode'

view details

Michael Bryan

commit sha ff1990eb319c379afde1663928cb51eb5d8b2130

Merge branch 'incomplete-links'

view details

Michael Bryan

commit sha d39af0a48ce8b83db1e54f723d994258689f825a

Mentioned resolve_incomplete_link_span() is a hack

view details

Michael Bryan

commit sha 7ae25d32e70cd2f7b4cd6784b9b4fe720336ad42

Added some tests for incomplete links

view details

Michael Bryan

commit sha 076240971ab10efbd2fba3fab8431e3ae4d143d8

Added a hint for resolving incomplete links

view details

Michael Bryan

commit sha fa980b1a6f18c39cf182052cd94b203a70955baf

Moved most of the business logic back into the crate

view details

Michael Bryan

commit sha cbcf5378b47b34a4de819e8d2c9f28be459bbe0c

Switched to using trust for CI

view details

Michael Bryan

commit sha d73ff524cdf3ed85a05537d7c80b56f9d9081da1

Made sure CI doesn't run the mdbook-linkcheck binary (it blocks reading stdin)

view details

Michael Bryan

commit sha e17f2c2e86a2c1086b6b6f588f6091ebff84ad14

We shuld canonicalize the source directory immediately

view details

Michael Bryan

commit sha 3424b9b099bab162c394ddb4be9a12eeca187619

Smoke tests shouldn't care about link order

view details

Michael Bryan

commit sha 239bf21ffced204c5a1401c78737f0fc37a89930

Integration tests should log things

view details

push time in a month

issue commentmsys2/MINGW-packages

Please help getting Rust 1.40 working

@Alexpux what'd you prefer: bootstrapping using repository packages (building Rust 1.38 -> 1.39 -> 1.40 -> 1.41) or bootstrapping directly from upstream provided Rust 1.40?

allquixotic

comment created time in a month

Pull request review commentrust-lang/rust

Make error codes into strings

 dependencies = [  "rustc_ast_pretty",  "rustc_attr",  "rustc_data_structures",+<<<<<<< HEAD

Bad merge

GuillaumeGomez

comment created time in a month

PR opened Michael-F-Bryan/mdbook-linkcheck

Upgrade reqwest and pulldown-cmark dependencies

About the changes:

  • use_sys_proxy is now default
  • somehow serde stops working with new reqwest unless derive feature is enabled
  • codespan is left with old version because I didn't know how to solve breaking changes
+334 -520

0 comment

3 changed files

pr created time in a month

create barnchmati865/mdbook-linkcheck

branch : deps

created branch time in a month

pull request commentrust-lang/rust

Upgrade dependencies

Please do split out changes to dependencies of std (and friends), like hashbrown.

It's unclear to me if you mean separate commits or PRs.

I would also ask that the polonius changes are either dropped or split to a separate PR

Dropped.

mati865

comment created time in a month

push eventmati865/rust

Mateusz Mikuła

commit sha 78db865ae56ed2d49dadbd91e056d7dff61ad2e7

Upgrade rustc and bootstrap dependencies

view details

Mateusz Mikuła

commit sha 4b7ae2df25fed45dc234130012201eedcf53ee78

Upgrade libstd's hashbrown

view details

push time in a month

PR opened rust-lang/rust

Upgrade dependencies

I can split out hashbrown or polonius if you want.

+98 -64

0 comment

10 changed files

pr created time in a month

create barnchmati865/rust

branch : deps

created branch time in a month

issue commentrust-lang/rust

`is_x86_feature_detected!("avx512f")` fails to build on nightly

There are good reasons to forbid MMX. It's the only instruction from the list above which can cause misoptimization (breaking otherwise sound code). It's removal is discussed in https://github.com/rust-lang/stdarch/issues/823

oconnor663

comment created time in a month

issue commentmstorsjo/llvm-mingw

Why is it needed?

Not sure what the state of libc++ in msys2 is (I remember that it didn't use to be packaged, but I do see it listed in the list of packages there now though).

Around LLVM 6/7 releases I had improved MSYS2 package enough to make static libc++abi + libc++ work (although with winpthreads). Shared libc++ was prone to segfaulting if you somehow managed to link it.

Oh, and the compiler-rt package doesn't seem to include the address sanitizer libraries. Yeah, sanitizers didn't work back then and it seems nobody checked since.

More changes:

  • LLDB was hopelessly broken, the only thing it could do was connecting to remote gdb.
  • it defaults to MSVCRT instead of UCRT
  • pthread is obligatory (MSYS2 Clang is even patched to link it by default)
KOLANICH

comment created time in a month

issue commentrust-lang/rust

undefined reference to `__imp___acrt_iob_func'

@cup Cygwin issue will be fixed with next nightly.

cup

comment created time in a month

delete branch mati865/rust

delete branch : mingw-ultimate-fix

delete time in a month

more