mati865 ( Mateusz Mikuła )

Mingw-w64-clang has some errors when generating profiles

It works only when compiler-rt is build by Clang+LLD.

Symbols when compiler-rt is:

built by GCC:

0000000000000000 r .rdata$.refptr.__llvm_profile_filename
0000000000000000 R .refptr.__llvm_profile_filename
                 U __llvm_profile_filename
0000000000000000 B .weak.__llvm_profile_filename.
                 w __llvm_profile_filename

built by Clang+LLD:

0000000000000000 r .rdata$.refptr.__llvm_profile_filename
0000000000000000 R .refptr.__llvm_profile_filename
                 U __llvm_profile_filename
0000000000000000 B __llvm_profile_filename

Keithcat1

comment created time in an hour

pull request commentrust-lang/rust

Translate the virtual `/rustc/$hash` prefix back to a real directory.

@eddyb you have to tell rustup-toolchain-install-master to install the component. Like this:

$ rustup-toolchain-install-master 40f2b445cd1c6c4e72d663d23c6d1bef2c674ad4 -c rust-src
$ ls ~/.rustup/toolchains/40f2b445cd1c6c4e72d663d23c6d1bef2c674ad4/lib/rustlib/src/rust/src
build_helper  libpanic_abort   libprofiler_builtins  libtest    tools
liballoc      libpanic_unwind  libstd                libunwind
libcore       libproc_macro    libterm               stdarch

eddyb

comment created time in 8 hours

Pull request review commentrust-lang/cargo

Add implib to the stamp files

 impl TargetInfo {                 should_replace_hyphens: false,             })         }+        else if target_triple.ends_with("windows-gnu")

        
        // LD can link DLL directly but LLD requires import library
        if target_triple.ends_with("windows-gnu")

chouquette

comment created time in 9 hours

Pull request review commentrust-lang/cargo

Add implib to the stamp files

 impl TargetInfo {                 should_replace_hyphens: false,             })         }+        else if target_triple.ends_with("windows-gnu")+                && crate_type.ends_with("dylib")+                && suffix == ".dll"+        {+            ret.push(FileType {+                suffix: ".dll.a".to_string(),+                prefix: "lib".to_string(),

                prefix: prefix.clone(),

There is no need to hardcode lib prefix because it works in either form.

chouquette

comment created time in 9 hours

issue commentrust-lang/rust

Replace submodules with subtrees

Clippy's CI could perform pull every time it tries to merge PR. That would avoid nearly all conflicts (from maintainer PoV) when new lint using the "old code" is being added but Clippy in Rust repo was updated for the "new code" already.

oli-obk

comment created time in 10 hours

issue commentmsys2/MINGW-packages

Update to LLVM/Clang 10?

I have it almost ready but there are still a few left things to improve.

HolyBlackCat

comment created time in a day

Pull request review commentrust-lang/rust

Translate the virtual `/rustc/$hash` prefix back to a real directory.

 fn build_session_(         _ => CtfeBacktrace::Disabled,     }); +    // Try to find a directory containing the Rust `src`, for more details see+    // the doc comment on the `real_rust_source_base_dir` field.+    let compute_real_rust_source_base_dir = || {+        // A file we expect to find inside the `real_rust_source_base_dir`.+        const SRC_FILE_TO_PROBE_FOR: &str = "src/libstd/lib.rs";++        // First look in the location used by the `rust-src` `rustup` component.+        let sysroot_candidate = sysroot.join("lib/rustlib/src/rust");+        if sysroot_candidate.join(SRC_FILE_TO_PROBE_FOR).is_file() {+            return Some(sysroot_candidate);+        }++        // As a fallback, check if the `sysroot` is inside a Rust build dir,+        //  i.e. it ends in `build/$CFG_COMPILER_HOST_TRIPLE/stage{0-sysroot,1,2,3}`.+        let mut sysroot_components = sysroot.components();+        let last = sysroot_components.next_back()?.as_os_str();+        if last == "stage0-sysroot" || last == "stage1" || last == "stage2" || last == "stage3" {+            if sysroot_components.next_back()?.as_os_str() == host_triple {+                if sysroot_components.next_back()?.as_os_str() == "build" {

@eddyb it won't work for every Windows user though: https://github.com/rust-lang/rust/blob/30ddb5a8c1e85916da0acdc665d6a16535a12dd6/src/libstd/sys/windows/fs.rs#L760-L763

eddyb

comment created time in a day

pull request commentrust-lang/rust

submodules: Update RLS and Rustfmt

Update this line: https://github.com/rust-lang/rust/blob/75ff3110ac6d8a0259023b83fd20d7ab295f8dd6/src/tools/rustc-workspace-hack/Cargo.toml#L62

Xanewok