profile
viewpoint
Mario Sanchez Prada mariospr @Igalia Lalín, Galicia (Spain) http://mariospr.org Software Engineer

brave/brave-browser 11861

Next generation Brave browser for Android, Linux, macOS, Windows.

brave/brave-core 1535

Core engine for the Brave browser for Android, Linux, macOS, Windows. For issues https://github.com/brave/brave-browser/issues

mariospr/chromium-browser-flatpak 21

Resources to build chromium-browser as a flatpak

mariospr/git-the-stupid-content-tracker 1

Introduction to version control with git (slides)

mariospr/aiyprojects-raspbian 0

Source code for the AIYProjects "Voice Kit"

mariospr/arduino-alarm 0

A simple experiment with Arduino, LEDs, photoresistors and speakers

mariospr/atksocket-atkplug-example 0

AtkSocket & AtkPlug example

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 1df05fe242dfea9e1f9fcb332a82d26693fcacca

More exclusions for Linux

view details

push time in 10 hours

push eventbrave/brave-core

Aleksey Khoroshilov

commit sha f4683927b3154d7f09cb85700c04277cac9d6295

Add support for Feature overrides to IsFeatureOverridden.

view details

Dov Alperin

commit sha 02f013936acc070d54803f785c43a4b72a62cddb

Preserve query strings on IPFS redirect +Adds test to make sure query string is preserved

view details

Emerick Rogul

commit sha efef87b033cb084abb16b4c13952d92b8e0316d2

Use Disconnected terminology for logout link

view details

Terry Mancey

commit sha 032358a20cacb2a4b13f96f178083fc883d2c8fe

Fixes Brave Ads dislike icon should be shown based upon the advertiser ID

view details

brave-builds

commit sha 079766f72a37c08222382d204b3866b92dbb00ca

1.36.41

view details

Brian R. Bondy

commit sha 13784cacc3e57a1c90f4bd0100a9a052e43854fc

Only build unexports for component builds

view details

Brian R. Bondy

commit sha a7650ecf0994b09f1fa2f4d504ce21c6ba0aa151

Merge pull request #11864 from brave/unexports-component-builds Only build Rust unexports for component builds on macOS

view details

Aleksey Seren

commit sha 2afe5e494976ff25e0f599c42df72615439e36c8

Support custom notification changes on Android 12. fix https://github.com/brave/brave-browser/issues/19145

view details

Michael Herrmann

commit sha 7d06a9562f222445f05f84b2a0dce5eedf227c63

Fix delta auto-update file generation on Windows Chromium's courgette.exe runs into memory allocation errors when called on Brave's binaries. Reducing the log page size from 18 (=1 MB) to 14 (=1/16th MB) fixes this. This makes it seem likely that the errors are caused by address space fragmentation. Unfortunately, we have not yet been able to find the root cause for this. So we use this workaround.

view details

brave-builds

commit sha 95fbb4ca3d3833e649fb45b07673ee05c4de1b5f

1.36.42

view details

Ivan Efremov

commit sha 61fd0f304ab8c32464f35289d7964f883d42e742

Introduce JSON P3A pings that duplicate the legacy pings. Fixes https://github.com/brave/brave-browser/issues/15967

view details

Ivan Efremov

commit sha 454af90dbfbfda156d7d8919f0c2b472524602dd

Please linter, improve naming and annotations.

view details

Ivan Efremov

commit sha 9c26c8721f8417f5f627beec958b02ec881022d6

Add p3a-json to network audit allowlist.

view details

Ivan Efremov

commit sha 5284b034b7e0e8697fc859726cf83fb591a356fc

Temporarily disable p2-json endpoint.

view details

Terry Mancey

commit sha 2dbb3a9b9e9c72946ecaa188de7a49df806ae307

Merge pull request #11855 from brave/issues/20512 Fixes Brave Ads dislike icon should be shown based upon the advertiser ID

view details

Brandon T

commit sha 327bf41a4b7e66a73b754125ce719bedb0510508

Added custom url schemes to Brave-Core and exported interface to Brave-Core browser & WebView.

view details

Brandon T

commit sha 7d80f42a7bc2e0d63996e13644652fe86c2f87c6

Addressed feedback

view details

Brandon T

commit sha babbd4e84ec15bd5f3e1bacdd237378c063fe414

Formatting

view details

Terry Mancey

commit sha af473fbc425d0462d628b8d7a84eac7b9c7a8d27

Fixes bad confirmation error when saving ad in 30-day ads history

view details

brave-builds

commit sha a83b260017e9313adf0f60228366546286a58470

1.36.43

view details

push time in a day

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 9d6914ac6b2031ac1b94916ef6ae8a22a7fb6c9e

Pass base::JSON_PARSE_CHROMIUM_EXTENSIONS to JSONReader::Read*() Upstream changed the JSON parser to be strictly compliant with RFC8259 and that breaks cases where we were feeding the JSON parser strings that contained C++ // style comments (e.g. some tests) as well as data that we don't control (e.g. Ethereum related) that arrived with control chars in the middle, for instance. Since we pass options such as JSONParserOptions::JSON_ALLOW_COMMENTS or JSONParserOptions::JSON_ALLOW_TRAILING_COMMAS to Read*() methods, the new default JSON_PARSE_CHROMIUM_EXTENSIONS (which groups all the different extensions that were not configurable until now) is not being used and we now fail to parse several cases where we shouldn't. To fix this, we follow upstream's lead and make sure that every call to a JSONReader::Read*() that is specifying the |options| parameter also includes base::JSON_PARSE_CHROMIUM_EXTENSIONS, so that we get to keep the previous functionality. Chromium change: https://source.chromium.org/chromium/chromium/src/+/115268f27364b52ec68526a758e432792dab43be commit 115268f27364b52ec68526a758e432792dab43be Author: Robert Sesek <rsesek@chromium.org> Date: Tue Dec 14 16:30:29 2021 +0000 base: Make JSON_PARSE_RFC optionally strictly compliant with RFC 8259. The existing non-configurable Chromium extensions are now individually configurable, with a flag JSON_PARSE_CHROMIUM that enables them all. This also adds metrics to record the non-standard extension usage, to see if any of these can be dropped. In order to avoid breaking the numerous callers of the JSONReader, the parse options default to the Chromium-style. Bug: 1269888 wip

view details

push time in a day

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 7affdb4d504635cee8a2571a77493b57500908ab

Only Linux is failing now

view details

push time in a day

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 5fc13dddbaff4b2af8b162bc9e92976bb15f3b34

Don't use C++ // style comments for JSON string literals in tests We used to do this like this in tests: ASSERT_TRUE(BinanceJSONParser::RevokeTokenFromJSON(R"( { "code": "000000", "message": null, "data": false,// true means clear access_token success "success": false })", &success)); ASSERT_FALSE(success); ...which worked fine until upstream changed the JSON parser to be strictly compliant with RFC8259. Now such string will cause a parsing failure unless base::JSONParserOptions::JSON_ALLOW_COMMENTS is passed along to base::JSONReader::ReadAndReturnValueWithError(), which is not the case at the moment. Since such comments are only there for documentation purposes, there is no need to translate them into the tests, so let's remove them and update the documentation to explain what the "data" member is about, but without using a C++ // style comment. Alternatively, we could update calls to ReadAndReturnValueWithError() to pass JSON_ALLOW_COMMENTS, but that would mean changing ~60 places probably for no good reason, so we simply adapt the test instead. Chromium change: https://source.chromium.org/chromium/chromium/src/+/115268f27364b52ec68526a758e432792dab43be commit 115268f27364b52ec68526a758e432792dab43be Author: Robert Sesek <rsesek@chromium.org> Date: Tue Dec 14 16:30:29 2021 +0000 base: Make JSON_PARSE_RFC optionally strictly compliant with RFC 8259. The existing non-configurable Chromium extensions are now individually configurable, with a flag JSON_PARSE_CHROMIUM that enables them all. This also adds metrics to record the non-standard extension usage, to see if any of these can be dropped. In order to avoid breaking the numerous callers of the JSONReader, the parse options default to the Chromium-style. Bug: 1269888

view details

push time in a day

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 12519824d127cd354ff8967c4f454782f3c99219

Don't use C++ // style comments for JSON string literals in tests We used to do this in tests: ASSERT_TRUE(BinanceJSONParser::RevokeTokenFromJSON(R"( { "code": "000000", "message": null, "data": false,// true means clear access_token success "success": false })", &success)); ASSERT_FALSE(success); ...which worked fine until upstream changed the JSON parser to be strictly compliant with RFC8259. Now such string will cause a parsing failure unless base::JSONParserOptions::JSON_ALLOW_COMMENTS is passed along to base::JSONReader::ReadAndReturnValueWithError(), which is not the case at the moment. Since such comment is only there for documentation purposes, there's no need to translate them into the tests, so let's remove them and update the documentation in binance_json_parser.cc to explain what the "data" member is about, but without using a C++ // style comment. Alternatively, we could update calls to ReadAndReturnValueWithError() to pass JSON_ALLOW_COMMENTS, but that would mean changing ~60 places probably for no good reason, so we simply adapt the test instead. Chromium change: https://source.chromium.org/chromium/chromium/src/+/115268f27364b52ec68526a758e432792dab43be commit 115268f27364b52ec68526a758e432792dab43be Author: Robert Sesek <rsesek@chromium.org> Date: Tue Dec 14 16:30:29 2021 +0000 base: Make JSON_PARSE_RFC optionally strictly compliant with RFC 8259. The existing non-configurable Chromium extensions are now individually configurable, with a flag JSON_PARSE_CHROMIUM that enables them all. This also adds metrics to record the non-standard extension usage, to see if any of these can be dropped. In order to avoid breaking the numerous callers of the JSONReader, the parse options default to the Chromium-style. Bug: 1269888

view details

push time in a day

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 2a131c5b2aba0ed0a42b213cf43da80a677f3bcb

Adapt test helper to expect SecureDnsPolicy::kBootstrap (vs kDisabled) Upstream has changed the default and we need to adapt our tests too, like upstream did for //net/dns/dns_transaction_unittest.cc. Chromium change: https://source.chromium.org/chromium/chromium/src/+/ commit 6f719eb2cbc236b614aeccec3aa3db3ec0ef11bb Author: Benjamin M. Schwartz <bemasc@chromium.org> Date: Wed Dec 15 17:47:28 2021 +0000 Bootstrap resolution implementation This change adds logic to HostResolverManager to use pre-configured IP addresses for the initial connection to a DoH server. If a bootstrap IP is used, the resolver also starts an asynchronous followup request to ask the DoH server for its own IP address, which will be used for subsequent connections. This change does not add the ability to store any bootstrap IPs, so this logic is not yet live. Bug: 1200908

view details

push time in a day

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 7cc6170b7d8bef8c13f30b75c28f1e2775edf7e1

Adapt to relocation of files under //c/b/privacy_sandbox privacy_sandbox_settings.{h,cc} and privacy_sandbox_test_util.{h,cc} have moved into //components/privacy_sandbox now. Chromium change: https://source.chromium.org/chromium/chromium/src/+/784b8b664b7188712e76a425f7b16c09774ebf02 commit 784b8b664b7188712e76a425f7b16c09774ebf02 Author: sauski <sauski@google.com> Date: Fri Jan 7 10:09:36 2022 +0000 Privacy Sandbox: Move PrivacySandboxSettings to components To allow APIs which live outside of chrome/ access to the PrivacySandboxSettings, the service is moved to components/. This follows on from previous work which separated the chrome/ specific logic into a separate service. Bug: 1154686

view details

samartnik

commit sha 7e28f0973f8bc248bd2576ae09c2f696e2cc3891

Adapt to removal of base::DictionaryValue::SetDictionary() method II Use base::Value::SetPath() instead. Chromium change: https://source.chromium.org/chromium/chromium/src/+/61bc6c4bf56e93687fed13327c02e0addc97a0c4 commit 61bc6c4bf56e93687fed13327c02e0addc97a0c4 Author: Alex Cooper <alcooper@chromium.org> Date: Tue Jan 4 22:53:42 2022 +0000 [CodeHealth] Remove deprecated SetDictionary method The SetDictionary method is deprecated. Now that all callers of it have been removed, it can be removed as well. Bug: 1187029

view details

samartnik

commit sha a92a23c63b3e894c3be6a7b53d55d2d691baa772

[Android] Adjusted code for new color management Chromium change: https://chromium-review.googlesource.com/c/chromium/src/+/3351221 Reland "[GMNext] Update ThemeColorProvider to use OmniboxTheme" This is a reland of 16fdb849a961bef58fb236a12ecb9ad7727c1a6d Original change's description: > [GMNext] Update ThemeColorProvider to use OmniboxTheme > > This CL updates the icon tint in some classes to follow OmniboxTheme > instead of the simple light/dark tint. It also moves OmniboxTheme out > of chrome/browser/omnibox to be able to use it in classes outside > omnibox/. > > Bug: 1233725, 1114183

view details

push time in a day

push eventbrave/brave-core

Aleksey Khoroshilov

commit sha f4683927b3154d7f09cb85700c04277cac9d6295

Add support for Feature overrides to IsFeatureOverridden.

view details

Terry Mancey

commit sha 032358a20cacb2a4b13f96f178083fc883d2c8fe

Fixes Brave Ads dislike icon should be shown based upon the advertiser ID

view details

brave-builds

commit sha 95fbb4ca3d3833e649fb45b07673ee05c4de1b5f

1.36.42

view details

Terry Mancey

commit sha 2dbb3a9b9e9c72946ecaa188de7a49df806ae307

Merge pull request #11855 from brave/issues/20512 Fixes Brave Ads dislike icon should be shown based upon the advertiser ID

view details

Brandon T

commit sha 327bf41a4b7e66a73b754125ce719bedb0510508

Added custom url schemes to Brave-Core and exported interface to Brave-Core browser & WebView.

view details

Brandon T

commit sha 7d80f42a7bc2e0d63996e13644652fe86c2f87c6

Addressed feedback

view details

Brandon T

commit sha babbd4e84ec15bd5f3e1bacdd237378c063fe414

Formatting

view details

brave-builds

commit sha a83b260017e9313adf0f60228366546286a58470

1.36.43

view details

brave-builds

commit sha cce9c47d7aad94ffa359972c7f2a3894ff5d2628

1.36.44

view details

Aleksey Khoroshilov

commit sha efdc4c141345c8a4eba02e32486e894a836fe94b

Merge pull request #11809 from brave/issues/20436 Add support for Feature overrides to IsFeatureOverridden.

view details

Mario Sanchez Prada

commit sha 7f0cfe2389903ebad03a323c3e75633c8bba8632

Remove chromium_src overrides to exclude tests These will be replaced by test filters files [1] in another commit. [1] https://chromium.googlesource.com/chromium/src/+/refs/heads/main/testing/buildbot/filters/README.md

view details

Mario Sanchez Prada

commit sha 9e2231c33f5cd61acb86210e3e831bdd7745fe98

Include the applicable exclusions when running upstream tests This adds support in the `npm run test` command when running upstream tests so that any test filters file that can be applied to the current test suite will be applied to avoid certain tests from running. This means that `npm run test` will automatically add the relevant --test-launcher-filter-file parameter if at least one of the following files are present on-disk at the time of running the tests: //brave/test/filters/<test suite>.filter //brave/test/filters/<test suite>-<OS>.filter //brave/test/filters/<test suite>-<OS>-arch.filter In case multiple files are available, all of them will be used along with the --test-launcher-filter-file parameter, so that we can provide a base filters file for all platforms and then refine it with more exclusions for specific platforms and architectures.

view details

Mario Sanchez Prada

commit sha b106ea3c54f51d85f024a98453815b43243efb32

Ensure the JavaScript world ID is set for Brave Ads This fixes several upstream browser tests crashing on DCHECK-enabled builds because of calls to dom_distiller::RunIsolatedJavaScript() being run without the ID being previously set, with erros like this: [497557:497557:1221/135319.265636:FATAL:distiller_javascript_utils.cc(41)] Check failed: distiller_javascript_world_id != invalid_world_id. #0 0x7fd8cc5b7459 base::debug::CollectStackTrace() #1 0x7fd8cc4b12d3 base::debug::StackTrace::StackTrace() #2 0x7fd8cc4d3a34 logging::LogMessage::~LogMessage() #3 0x7fd8cc4d44ae logging::LogMessage::~LogMessage() #4 0x56550ee1de70 dom_distiller::RunIsolatedJavaScript() #5 0x56550fffc990 brave_ads::AdsTabHelper::RunIsolatedJavaScript() #6 0x7fd8c6332b3d content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #7 0x7fd8c63531a9 content::WebContentsImpl::DocumentOnLoadCompleted() [...] #56 0x56550ccba27a _start Task trace: #0 0x7fd8c6c6ebee IPC::(anonymous namespace)::ChannelAssociatedGroupController::Accept() #1 0x7fd8cbce69df mojo::SimpleWatcher::Context::Notify() Crash keys: "ui_scheduler_async_stack" = "0x7FD8C6C6EBEE 0x7FD8CBCE69DF" "io_scheduler_async_stack" = "0x7FD8CBCE69DF 0x0" [1/1] TabStripBrowsertest.ShiftGroupLeft_OtherGroup (CRASHED) This is necessary or all browser tests will crash when running on CI.

view details

Mario Sanchez Prada

commit sha bbd326d472271fa2c2680f59491aec6752fcf482

Add exclusions for unit tests, including platform-specific ones

view details

Mario Sanchez Prada

commit sha d22ee499d29034fb3ba3445cdd96ecdd5a2983f8

Add exclusions for browser tests, including platform-specific ones

view details

Mario Sanchez Prada

commit sha db0d8af093d010c3b7f5f23dc5cd88e5fca76cd8

More exclusions, again

view details

push time in a day

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 8e3bbcd6c012b729506b27e9a1f775dcf3fbdc2b

Update from Chromium 99.0.4783.0 to Chromium 99.0.4818.2.

view details

Mario Sanchez Prada

commit sha 1ac26179687fee98512b8ed73c5a7c8410c1eb3a

Updated patches from Chromium 99.0.4783.0 to Chromium 99.0.4818.2.

view details

Mario Sanchez Prada

commit sha 11fef40e08e3e2fa1bca09d2aed47e401769d289

Conflict-resolved patches from Chromium 99.0.4783.0 to Chromium 99.0.4818.2.

view details

Mario Sanchez Prada

commit sha 3390c7001651c3ca20247c271ed4890b1cad1dd5

Updated strings for Chromium 99.0.4818.2.

view details

Mario Sanchez Prada

commit sha d1d836eba2a5b802374999d191763abfba507fd1

Drop references to OriginTrialFeature::kHandwritingRecognition This is gone now and we can't reference it anymore. Besides, it only applied to ChromeOS and in any case depended on having another feature enabled (blink::features::kHandwritingRecognitionWebPlatformApiFinch), which is already being disabled for Brave, so we can simply drop it. Chromium change: https://source.chromium.org/chromium/chromium/src/+/cd66def5d2c6c21f6fc01df39f64c49c01dd10d2 commit cd66def5d2c6c21f6fc01df39f64c49c01dd10d2 Author: Jiewei Qian <qjw@chromium.org> Date: Fri Jan 7 02:17:30 2022 +0000 blink/handwriting: enable HandwritingRecognition by default on ChromeOS Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/s3n3bGl6i1M Change-Id: Id24dd149242433798ccfcaa1ed38053015f83ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321052 Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#956339}

view details

Mario Sanchez Prada

commit sha d78de1c2e0373fb26b11809b5afbd15b537377fd

Adapt to removal of base::DictionaryValue::SetDictionary() method Use base::Value::SetPath() instead. Chromium change: https://source.chromium.org/chromium/chromium/src/+/61bc6c4bf56e93687fed13327c02e0addc97a0c4 commit 61bc6c4bf56e93687fed13327c02e0addc97a0c4 Author: Alex Cooper <alcooper@chromium.org> Date: Tue Jan 4 22:53:42 2022 +0000 [CodeHealth] Remove deprecated SetDictionary method The SetDictionary method is deprecated. Now that all callers of it have been removed, it can be removed as well. Bug: 1187029

view details

Mario Sanchez Prada

commit sha 05b1e51e215ee7576c1e5c8cc70a8d8a622bd843

Adapt to new signature of ContentSettingsPrefProvider::SetWebsiteSetting() Chromium change: https://source.chromium.org/chromium/chromium/src/+/ca8250e176e4b7ff384da0e00106c6ad3578b999 commit ca8250e176e4b7ff384da0e00106c6ad3578b999 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri Jan 7 12:22:15 2022 +0000 CodeHealth: Convert content_settings_provider to new base::Value API Bug: 1281896

view details

Mario Sanchez Prada

commit sha c742c5d48249a4a355363b1e728208f1cf6d6069

Don't call base::Value::FromUniquePtrValue() with ContentSettingToValue() Chromium change: https://source.chromium.org/chromium/chromium/src/+/111ca2599f46687804c05405728eb1c10e1a1ccb commit 111ca2599f46687804c05405728eb1c10e1a1ccb Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Jan 3 12:48:32 2022 +0000 Codehealth: Convert content_settings_utils to new base::Value API Bug: 1281896

view details

Mario Sanchez Prada

commit sha 4a48462e354e78951df8e5992549deee09e3bb7b

Adapt to rename of content::WebContentsObserver method DocumentOnLoadCompletedInMainFrame() has been renamed and does no longer expects a RenderFrameHost* parameter to be passed, since it will only ever be called over the primary main frame now. Chromium change: https://source.chromium.org/chromium/chromium/src/+/813475877bc722e01263bc17f5cb4a8ccecea96d commit 813475877bc722e01263bc17f5cb4a8ccecea96d Author: Sreeja Kamishetty <sreejakshetty@chromium.org> Date: Thu Jan 6 12:46:33 2022 +0000 Rename DocumentOnLoadCompletedInMainFrame to DocumentOnLoadCompletedInPrimaryMainFrame In crrev.com/c/3231019, we landed the change where we dispatch DocumentOnLoadCompletedInMainFrame for primary main frame only. This change makes it straightforward for the API users to interpret that the observer is only invoked for primary main frames. We do mass rename of the DocumentOnLoadCompletedInMainFrame use cases along with other helper methods like IsDocumentOnLoadCompletedInMainFrame and also remove the RenderFrameHost* parameter, which is not necessary as it can be obtained directly from web_contents()->GetMainFrame(). The following changes were made using tools/git/mffr.py: - DocumentOnLoadCompletedInMainFrame(RenderFrameHost* render_frame_host) -> DocumentOnLoadCompletedInPrimaryMainFrame - IsDocumentOnLoadCompletedInMainFrame -> IsDocumentOnLoadCompletedInPrimaryMainFrame For more context, please refer to: https://docs.google.com/document/d/1GjuE0wXRj304q61T_HFLj3CRV1mNqMWfYIz_8tKdEZY/edit?usp=sharing BUG=1257140, 1271481

view details

Mario Sanchez Prada

commit sha 8fe685c2306c357541dadb92464fff7afbd587a1

Don't return a bool in BraveStartupBrowserCreatorImpl::Launch() The method is overriding does no longer return anything since the path that would remove |false| has now been removed. Chromium change: https://source.chromium.org/chromium/chromium/src/+/f2a41d07147d272b93f2cd774a5ef8a55731bc4a commit f2a41d07147d272b93f2cd774a5ef8a55731bc4a Author: David Roger <droger@chromium.org> Date: Mon Jan 3 12:11:16 2022 +0000 Remove unused return values in StartupBrowserCreator The following functions had a "bool" return type, but were always returning true: StartupBrowserCreator::LaunchBrowser StartupBrowserCreator::LaunchBrowserForLastProfiles StartupBrowserCreator::ProcessLastOpenedProfiles StartupBrowserCreatorImpl::Launch This was causing unnecessary checks on the return values. This CL changes the functions to return void and removes the error handling code. Change-Id: If423246b0cf8b4d833ee762860eec3b72fba970b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3365037 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/main@{#954913}

view details

Mario Sanchez Prada

commit sha 358ca75513328d7d909daf5b67b809b87fea2ff9

Adapt to new way of registering associated mojo interface binders We override RegisterAssociatedInterfaceBindersForRenderFrameHost() now and call blink::AssociatedInterfaceRegistry::AddInterface() from there to register binder functions to which to pass the pending receivers. Chromium change: https://source.chromium.org/chromium/chromium/src/+/cdaf0c06784713c021dda5dfa59f9b198f12ce25 commit cdaf0c06784713c021dda5dfa59f9b198f12ce25 Author: Lingqi Chi <lingqi@chromium.org> Date: Thu Dec 30 14:19:00 2021 +0000 MCC Refactor step0: Allow embedders to register associated_interface binders with RenderFrameHostImpl::associated_registry_. (This series of CLs will refactor Mojo Capability Control(MCC) related logic.) Currently embedders bind the associated interfaces by retrieving the rules listed in ContentBrowserClient::BindAssociatedReceiverFromFrame, which makes it difficult to perform consistency check when specifying corresponding binding policies. So this CL replaces BindAssociatedReceiverFromFrame with RegisterAssociatedInterfaceBinderForFrame, which allows embedders to register their binders directly instead of adding rules. No behavior changes. ----------- relation chain: CL(1/N): current CL. CL(2.*/N): These CL move some binding related logic to another class. 2.1 https://crrev.com/c/3261198 2.2 https://crrev.com/c/3279325 2.3 https://crrev.com/c/3279326 CL(3/N): https://crrev.com/c/3278834 Prepare for CL(4/N). I will introduce ManagedBinderMap, which will take over the ownership of mojo::BinderMaps. CL(4/N): https://crrev.com/c/3291014 Introduce ManagedBinderMap for consistency check. CL(5/N): TODO. ManagedBinderMap should also take care of AssociatedInterfaceRegistry. Design doc https://docs.google.com/document/d/1yQ4aaHrXGiozYLhYM-HuBGKznIKcAI86kKcY9Jp3pkE/edit?resourcekey=0-RjlGRqsDbU-abftgdHpFog#heading=h.tbl610ys2iap Bug: 1265864, 1157334

view details

Mario Sanchez Prada

commit sha 3fbe750a0cfa3f080b8b657aceb57d87a4a9acd0

Add missing definition for kSCTAuditingPendingReportsFileName constant Chromium change: https://source.chromium.org/chromium/chromium/src/+/a160fa309c73e7562a773ad11e4bbc31e54c8c86 commit a160fa309c73e7562a773ad11e4bbc31e54c8c86 Author: Chris Thompson <cthomp@chromium.org> Date: Fri Jan 7 18:39:56 2022 +0000 Persist pending SCT auditing reports over browser restarts Adds support to SCTAuditingHandler to serialize and persist pending reports to disk, and read and deserializing any persisted reports after browser startup. Reports are persisted to a new "SCT Auditing" path exposed to the network service. Writing to disk is handled by an ImportantFileWriter (owned by the SCTAuditingHandler), with serialization handled by SCTAuditingHandler. Persistence is handled per-Profile. In-memory and system profiles won't have a persistence path set and won't persist reports to disk. Reports are persisted as a list of dictionaries, in JSON: [{ "reporter_key": <string of HashValue>, "report": <base64 string of TLClientReport>, "backoff_entry": <serialized BackoffEntry> }] Updates to the persisted state are triggered: - When a new SCTAuditingReporter is added to an SCTAuditingHandler - When an SCTAuditingReporter successfully completes, or runs out of retries. - When an SCTAuditingReporter updates its BackoffEntry on scheduling a retry. This also updates SCTAuditingHandler to use two explicit sequenced task runners (a foreground runner for most tasks, and a background runner for reading and writing to disk) and makes the sequences explicit throughout. Lastly, this removes the `num_retries_` member on SCTAuditingReporter and instead relies directly on the BackoffEntry's `failure_count()`. This lets the serialization of the BackoffEntry handle serializing the retry count as well. Bug: 1144205

view details

Mario Sanchez Prada

commit sha ebc7f2d50688069b111909a1b41d5c9a60dde98b

Add missing definition for kSyncTrustedVaultLearnMoreURL constant Chromium change: https://source.chromium.org/chromium/chromium/src/+/39ea74b20d673b9f468007dfca3908f087ec7c0a commit 39ea74b20d673b9f468007dfca3908f087ec7c0a Author: Mikel Astiz <mastiz@chromium.org> Date: Fri Jan 7 15:47:26 2022 +0000 [trusted vault] Update URL for help center article This addresses a TODO to update the help center article with a feature-specific URL. Change-Id: Ia0c0525c71cb4e3302673fdd2f7d451b16a406ae Bug: 1202088

view details

Mario Sanchez Prada

commit sha 77d53c2dd4b15f1b6ed6517380569d9a98f8b892

Adapt to relocation of files under //c/b/privacy_sandbox privacy_sandbox_settings.{h,cc} and privacy_sandbox_test_util.{h,cc} have moved into //components/privacy_sandbox now. Chromium change: https://source.chromium.org/chromium/chromium/src/+/784b8b664b7188712e76a425f7b16c09774ebf02 commit 784b8b664b7188712e76a425f7b16c09774ebf02 Author: sauski <sauski@google.com> Date: Fri Jan 7 10:09:36 2022 +0000 Privacy Sandbox: Move PrivacySandboxSettings to components To allow APIs which live outside of chrome/ access to the PrivacySandboxSettings, the service is moved to components/. This follows on from previous work which separated the chrome/ specific logic into a separate service. Bug: 1154686

view details

push time in 2 days

delete branch brave/brave-core

delete branch : mariospr-cr99

delete time in 2 days

issue commentbrave/brave-browser

Shield feature "Allow scripts once" doesn't work

I'm afraid this is likely related to https://github.com/brave/brave-core/commit/6d7031c4ea7b461038e0ef5ce1eebcbf75175cc1 where, besides adapting tests, we were forced to adapt UpdateContentSettingsToRendererFrames() in browser/brave_shields/brave_shields_web_contents_observer.cc to the removal of WebContents::GetAllFrames().

@iefremov @bridiver If any of you could take a look at this as Brave Shields experts, that would be great. It's possible that the way I adapted UpdateContentSettingsToRendererFrames() was not 100% correct in the end, but it's hard for me to know what exactly could be the problem here without deeper knowledge on how Shields work.

palianskas

comment created time in 2 days

create barnchbrave/brave-core

branch : mariospr-cr99

created branch time in 2 days

PullRequestReviewEvent

push eventbrave/brave-core

Mario Sanchez Prada

commit sha f4bcd0396737240d874968fcf936d71a5e6b5c5f

More exclusions, again

view details

push time in 2 days

push eventbrave/brave-core

Mikhail Atuchin

commit sha 246114b969007a03cd79c98666019cb7ed5b6ad8

Fix flaky BraveTranslateBrowserDisabledFeatureTest

view details

Mario Sanchez Prada

commit sha a6eeb459c47eb92cf456ce39c7641e94bb8b4977

Merge pull request #11870 from brave/fix-flaky-brave-translate-browsertests Fix flaky BraveTranslateBrowserDisabledFeatureTest

view details

push time in 2 days

delete branch brave/brave-core

delete branch : fix-flaky-brave-translate-browsertests

delete time in 2 days

PR merged brave/brave-core

Fix flaky BraveTranslateBrowserDisabledFeatureTest

<!-- Add brave-browser issue bellow that this PR will resolve --> Resolves https://github.com/brave/brave-browser/issues/20526

The problem is in the weird chromium logic of reusing the existing bubble. In fact, it is closed right after reusing and the test fails.

This fix covers the main scenario for Brave (creating and showing the bubble after navigation, no active bubble before). After the problem can be fixed in the upstream.

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have requested one
  • [x] There is a ticket for my issue
  • [x] Used Github auto-closing keywords in the PR description above
  • [ ] Wrote a good PR/commit description
  • [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • [x] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [x] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [ ] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

+3 -0

0 comment

1 changed file

atuchin-m

pr closed time in 2 days

push eventbrave/brave-core

William Muli

commit sha e37438aaa1bbaeb4bef48fc763792a9556fe4fc2

Change justify-content from space-evenly to flex-start

view details

Terry Mancey

commit sha 126a3ed7548a03ce3472a52844936e2d1dea23dc

Refactor Brave Ads conversion feature

view details

Terry Mancey

commit sha 1b86117ba011032d2da727ca82e71be4d0088624

Refactor Brave Ads FilterAdEventsForConversion

view details

Terry Mancey

commit sha 7cc5046425ba5969d3f0c263d48c16b1220f14f5

Refactor BraveAds FilterConversions

view details

Terry Mancey

commit sha b19a1729bb1d99269eebfc2a1bbe63bbb8faaff9

Refactor Brave Ads conversions

view details

Terry Mancey

commit sha 56fc329b0f8a6ca3501ca281f68b35c2da723ae5

Include PostClick conversion metric for all Brave News users

view details

Emerick Rogul

commit sha 747ebb9213fc4406ef3ada65a18e9d00cf2712ff

Migrate kHideButton preference to kShowButton preference

view details

zenparsing

commit sha f8ea14c9d74b64ce5552db0deff12f86904ce6c7

Handle case where promotion array may be undefined on NTP

view details

Brian R. Bondy

commit sha 819279a8016264f2299085632d91d4c2b3912a2b

Disallow deletion of ethereum properties This is for webcompat with MetaMask. The https://wallet.polygon.technology/ site does this when web3 is defined: ``` void 0 !== n.ethereumProvider ? i = n.ethereumProvider : void 0 !== n.web3 && n.web3.currentProvider && ( n.web3.currentProvider.sendAsync && (n.web3.currentProvider.send = n.web3.currentProvider.sendAsync, delete n.web3.currentProvider.sendAsync), ``` We used to not include web3 at all, then this code is not hit and there's no problem. Recently we started including a web3 shim so that's why it's hit now. Now that it's hit, we were failing because the Polygon site deleted `window.ethereum.sendAsync` and then tried to use it. We allowed this property deletion but MetaMask did not. Instead of the fix in this commit (with the proxy method), I wanted to instead do this in `components/brave_wallet/renderer/brave_wallet_js_handler.cc` but that won't work because it makes delete return false. ``` - ->Set(context, gin::StringToSymbol(isolate, "networkVersion"), + ->DefineOwnProperty(context, gin::StringToSymbol(isolate, "networkVersion", DontDelete), gin::StringToV8(isolate, std::to_string(networkVersion))) .Check(); ``` The Polygon site won't load at all if it thinks it can't delete the property.

view details

Serg

commit sha 5efd66567b500095845d51d2cc25ec1a7546e90f

Adds an option to add a custom EVM compatible network on Android wallet

view details

Serg

commit sha adb5c843f2c90a45bf8fd059e5878b633b4f2b04

Adds a custom network to networks drop down, hides buy/swap for custom networks on Android

view details

Francois Marier

commit sha 58db2b6960dd0504dea9a8a4cb0f6d1b1c545f0f

Make sec-team the owner of the audit_deps script There is a comment in the code to ask for a review from the sec-team, but we may as well enforce it.

view details

Simon Hong

commit sha 474c6d5dd6ae7b62efb71b659f2017369274f135

Added side-panel webui to bookmarks api's allow list fix https://github.com/brave/brave-browser/issues/20400

view details

Anirudha Bose

commit sha 262d39de3f00ce9cabd8899edaadccb01dbc3e75

chore(wallet): decouple token balances from asset options list

view details

Simon Hong

commit sha 7a54c0c3630c4bbdf7107c69c910c6fa159fbce1

Merge pull request #11820 from brave/fix_side_panel_bookmarks Added side-panel webui to bookmarks api's allow list

view details

brave-builds

commit sha 6f5bee920d231601f4953f4f023901ec829c6d4a

1.36.33

view details

Anirudha Bose

commit sha 01a4bd3b65daabc0c252c890a9e7d7b14915c93b

Merge pull request #11807 from brave/exp/wallet/refactor-balance-storage chore(wallet): decouple token balances from asset options list

view details

Brian R. Bondy

commit sha a75ce6eb0d2c3c10a32e085a3c4d9917726959fb

Add chain_id param to blockchainRegistry functions

view details

Brian R. Bondy

commit sha 9a41a3be266ef2cc591c130b5651f3046aa39565

Parse multiple token lists

view details

Brian R. Bondy

commit sha 0acfa3b98fc637cdfa976f7dd456eba82f4df57f

Parse Solana tokens if available

view details

push time in 2 days

push eventbrave/brave-core

Ralph Giles

commit sha 1604eb8d1778e7f98aa36fb105ba9cd1e47abeb4

P3A: Record how long rewards were enabled. Measure how long Brave Rewards were enabled to better understand user interaction with the feature. The duration is recorded in a limited number of bins, reporting whether rewards are still enabled, have never been enabled, or if they were previously on and are now turned off, the rough amount of time they were enabled. It is necessary to set the initial `kNever` measurement from `OnLedgerInitialized`, since `OnPrefChanged` isn't called for the overall enable prefs at startup. Closes brave/brave-browser#18394

view details

Ralph Giles

commit sha e34eb1fd03550f56d44df3a660d808821b9970b9

P3A: Test Rewards.EnabledDuration measurement. Turn Brave Rewards on and off, checking for the appropriate measurements. Modify the recorded timestamp to mock the passage of time. According to `RewardsServiceImpl::IsRewardsEnabled`, rewards are enabled if either of Ads or AutoContribute is enabled. In general switching these may call `OnPreferenceChanged` asynchronously after a round-trip through the ledger process. This commit overrides `RewardsObserver::OnAdsEnabled` to keep track of the enabled state, and adds a `WaitForRewardsEnable` method which blocks until changes have propagated so the test can wait for this before checking for the expected histogram values. It adds a similar invocation to `WaitForRewardsInitialization`. According to Emerick Rogul this was the intended use of the corresponding RunLoop data member. Likely it wasn't necessary in practice because the existing tests all call `FetchBalance` which calls its own local RunLoop. Rather than add a parallel `RewardsObserver::OnAutocontributeEnabled` callback, the new duration tests only check the ads case. I had further problems with multiple enable/disable cycles; it seems something with the ledger shutdown code wasn't running to completion even with an extra runloop or delay. To work around this, each duration check is written as a separate test. Also, prefer assigning a `make_unique` to `reset` for unique_ptr data members per style lint.

view details

Ralph Giles

commit sha 3a3bb04ab19d0502c830026a1d4ae7c7a290db2e

P3A: Fix rewards include ordering clang-format style lint.

view details

Ralph Giles

commit sha efd5a5887efab500ad9dedb012c109bd96a14d5c

P3A: Try mocking pref changes for the rewards duration test. Try working around problems with the Rewards browsertests interfering with each other by flipping the ads_enabled pref directly, rather than asking the service to enable/disable. This works for recording the Brave.Rewards.EnabledDuration measurement, but may still confuse the test state.

view details

William Muli

commit sha e37438aaa1bbaeb4bef48fc763792a9556fe4fc2

Change justify-content from space-evenly to flex-start

view details

Ralph Giles

commit sha 6370f9b075bdb867b82a063045d736bb36bc0e01

P3A: Address rewards duration review comments. Use explicit types in calculating duration offsets. Rename `RewardsEnabledDuration::kLonger` to `kQuarters`, referring to quarter-years, for clarity.

view details

Terry Mancey

commit sha 126a3ed7548a03ce3472a52844936e2d1dea23dc

Refactor Brave Ads conversion feature

view details

Terry Mancey

commit sha 1b86117ba011032d2da727ca82e71be4d0088624

Refactor Brave Ads FilterAdEventsForConversion

view details

Terry Mancey

commit sha 7cc5046425ba5969d3f0c263d48c16b1220f14f5

Refactor BraveAds FilterConversions

view details

Terry Mancey

commit sha b19a1729bb1d99269eebfc2a1bbe63bbb8faaff9

Refactor Brave Ads conversions

view details

Terry Mancey

commit sha 56fc329b0f8a6ca3501ca281f68b35c2da723ae5

Include PostClick conversion metric for all Brave News users

view details

Aleksey Seren

commit sha 85d519e6dd904261a78d5b7fdfff07fb39d728b1

Remove "ads_service.h" dependency from header. fix https://github.com/brave/brave-browser/issues/19379

view details

Ralph Giles

commit sha 9d97e1cc3ddc2a343040036205bef9f372355cc7

P3A: Use VLOG instead of (D)LOG for test tracing. Addresses review comments.

view details

Ralph Giles

commit sha 55ec9c0687bfb68742af6498bc76f0243aa06b1e

P3A: Use prefs::kEnabled instead of duplicating the pref name. Addresses review comments.

view details

Ralph Giles

commit sha 57a7c85c4b61c0d5d3d5814b6892acf171caa141

P3A: rename generic value to rewards_duration. More descriptive name as requested in review.

view details

Kyle Hickinson

commit sha a91f039d050c80eab705e7ba983021feec07c536

Generate concrete classes for mojo generated interfaces for testing This will create special test classes which conform to each mojo interface. Each class will contain properties for each method to override that particular calls functionality. For instance for wallet, you can create a `TestKeyringService` and setup only the `createWallet` method override to test all flows of creating a wallet without having to write multiple conforming classes.

view details

Ralph Giles

commit sha 9220fc4479006c790657175e1a6a249d807f5539

addblock_rust: Reformat to avoid lints. Re-wrap lines and alphabetize `use` statements to agree with `rustfmt`. Avoids spurious changes to the code sometimes generated by `npm run lint`.

view details

Ralph Giles

commit sha 2433c3aa52d63f6be3062f749e5ef4fb7107fb81

addblock_rust: Remove unnecessary mem::forget from ffi wrapper. These two functions call `std::mem::forget(ptr)` on a raw `c_char` pointer. This is unnecessary; the previous `.into_raw()` has already consumed ownership of the CString, so there's nothing to forget, and returning the pointer correctly transfers ownership of the underlying buffer to the caller. Put another way `*mut c_char` is a `Copy` type and does not have a destructor, so `mem::forget` is a no-op. The way `engine_hidden_class_id_selectors()` instead returns the `into_raw` value directly is correct. Corrects a clippy warning.

view details

Ralph Giles

commit sha 447377ea36e275ed0332d1b6e86dede45d84851f

speedreader: Reformat to avoid lints. Re-wrap lines and alphabetize `use` statements to agree with `rustfmt`. Avoids spurious changes to the code sometimes generated by `npm run lint`.

view details

Douglas Daniel

commit sha 3315447d8940f98cb6477e155233c826a28ba25d

feat(wallet): Accounts Page Multi Chain UI Support

view details

push time in 2 days

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 4f3f3b3bf9572d7ea346df5ee31c994e1fab7667

Ensure the JavaScript world ID is set for Brave Ads This fixes several upstream browser tests crashing on DCHECK-enabled builds because of calls to dom_distiller::RunIsolatedJavaScript() being run without the ID being previously set, with erros like this: [497557:497557:1221/135319.265636:FATAL:distiller_javascript_utils.cc(41)] Check failed: distiller_javascript_world_id != invalid_world_id. #0 0x7fd8cc5b7459 base::debug::CollectStackTrace() #1 0x7fd8cc4b12d3 base::debug::StackTrace::StackTrace() #2 0x7fd8cc4d3a34 logging::LogMessage::~LogMessage() #3 0x7fd8cc4d44ae logging::LogMessage::~LogMessage() #4 0x56550ee1de70 dom_distiller::RunIsolatedJavaScript() #5 0x56550fffc990 brave_ads::AdsTabHelper::RunIsolatedJavaScript() #6 0x7fd8c6332b3d content::WebContentsImpl::WebContentsObserverList::NotifyObservers<>() #7 0x7fd8c63531a9 content::WebContentsImpl::DocumentOnLoadCompleted() [...] #56 0x56550ccba27a _start Task trace: #0 0x7fd8c6c6ebee IPC::(anonymous namespace)::ChannelAssociatedGroupController::Accept() #1 0x7fd8cbce69df mojo::SimpleWatcher::Context::Notify() Crash keys: "ui_scheduler_async_stack" = "0x7FD8C6C6EBEE 0x7FD8CBCE69DF" "io_scheduler_async_stack" = "0x7FD8CBCE69DF 0x0" [1/1] TabStripBrowsertest.ShiftGroupLeft_OtherGroup (CRASHED) This is necessary or all browser tests will crash when running on CI.

view details

Mario Sanchez Prada

commit sha c206242c4c16082ebdfe5e498122a43bcfaaf579

Add exclusions for unit tests, including platform-specific ones

view details

Mario Sanchez Prada

commit sha 398d4bcc843ed6ff5a4356df0f4a65fd5057d479

Add exclusions for browser tests, including platform-specific ones

view details

push time in 2 days

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 209c0e9c8409dc719346421e0de7504dfd843c7d

Some more exclusions

view details

push time in 5 days

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 0f7382cba46ef31e78eeb0db0efb0b77c7ec3cee

Add browser tests exclusions for MacOS List gathered as a combination of a local run on a MacPro and information from the CI bots which didn't complete due to hititng the 150min timeout (currently in the process of being extended).

view details

push time in 5 days

push eventbrave/brave-core

Mario Sanchez Prada

commit sha d33adcdd6804fb0173210b5505aa4406b95d2eba

More exclusions from CI feedback (2)

view details

Mario Sanchez Prada

commit sha 5f612ab183939d07c85f57419484eeef258ed26e

Add browser tests exclusions for MacOS List gathered as a combination of a local run on a MacPro and information from the CI bots which didn't complete due to hititng the 150min timeout (currently in the process of being extended).

view details

push time in 5 days

push eventbrave/brave-core

Mario Sanchez Prada

commit sha 87144bb59ebacb704d5e1713db31bcd30b632c82

[network-audit] Add test coverage for the New Tab Page As reported in https://github.com/brave/brave-browser/issues/20501, the NTP was making outbound requests to ftx.com at startup without user opt-in, and the network-audit didn't catch that case because it was NOT loading a NTP as part of the different checks it does at BraveNetworkAuditTest.BasicTests. This patch adds explicit test coverage for that case by loading brave://newtab and waiting 5 minutes, like with the other checks. Resolves https://github.com/brave/brave-browser/issues/20504

view details

Mario Sanchez Prada

commit sha f38f5d63b2ba0a581934b2d5a109d856863dd865

Merge pull request #11850 from brave/issues/20504 [network-audit] Add test coverage for the New Tab Page

view details

push time in 5 days

delete branch brave/brave-core

delete branch : issues/20504

delete time in 5 days

PR merged brave/brave-core

[network-audit] Add test coverage for the New Tab Page CI/run-network-audit CI/run-audit-deps

As reported in https://github.com/brave/brave-browser/issues/20501, the NTP was making outbound requests to ftx.com at startup without user opt-in, and the network-audit didn't catch that case because it was NOT loading a NTP as part of the different checks it does at BraveNetworkAuditTest.BasicTests.

This patch adds explicit test coverage for that case by loading brave://newtab and waiting 5 minutes, like with the other checks.

Resolves https://github.com/brave/brave-browser/issues/20504

<!-- Add brave-browser issue bellow that this PR will resolve --> Resolves

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have requested one
  • [x] There is a ticket for my issue
  • [x] Used Github auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • [x] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [x] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [x] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

N/A

+5 -1

0 comment

2 changed files

mariospr

pr closed time in 5 days

issue closedbrave/brave-browser

Add coverage for the New Tab Page in the network-audit

Description

As reported in https://github.com/brave/brave-browser/issues/20501, the NTP was making outbound requests to ftx.com at startup without user opt-in, and the network-audit didn't catch that case because it is NOT loading a NTP as part of the different checks it does at BraveNetworkAuditTest.BasicTests (see it here).

Thus, this issue is filed to add explicit coverage for the NTP in the network-audit.

closed time in 5 days

mariospr

PR opened brave/brave-core

Reviewers
[network-audit] Add test coverage for the New Tab Page

As reported in https://github.com/brave/brave-browser/issues/20501, the NTP was making outbound requests to ftx.com at startup without user opt-in, and the network-audit didn't catch that case because it was NOT loading a NTP as part of the different checks it does at BraveNetworkAuditTest.BasicTests.

This patch adds explicit test coverage for that case by loading brave://newtab and waiting 5 minutes, like with the other checks.

Resolves https://github.com/brave/brave-browser/issues/20504

<!-- Add brave-browser issue bellow that this PR will resolve --> Resolves

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have requested one
  • [x] There is a ticket for my issue
  • [x] Used Github auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [x] Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • [x] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [x] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [x] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

N/A

+5 -1

0 comment

2 changed files

pr created time in 5 days

create barnchbrave/brave-core

branch : issues/20504

created branch time in 5 days

more