profile
viewpoint

marekcirkos/RoutingHTTPServer 4

A routing API for CocoaHTTPServer

marekcirkos/g0blin 0

a work-in-progress jailbreak for iOS 10.3.x (A7-A9)

push eventfacebook/homebrew-fb

Distiller

commit sha 160f491218b509a5391a2eb32ecf9a6fe3d2933d

Bump buck to version 2020.10.21.01 This commit was generated by release automation

view details

push time in a month

push eventfacebook/homebrew-fb

Paul Oโ€™Shannessy

commit sha 4a5b5b1bea9e42786e3ecf4d36fc324ab45290ec

Update buck.rb (#43) Homebrew has started enforcing grammar rules in descriptions for some insane reason so bypass that.

view details

push time in a month

PR merged facebook/homebrew-fb

Update buck.rb CLA Signed

Homebrew has started enforcing grammar rules in descriptions for some insane reason so bypass that.

+1 -1

0 comment

1 changed file

zpao

pr closed time in a month

PR opened facebook/homebrew-fb

Reviewers
Update buck.rb

Homebrew has started enforcing grammar rules in descriptions for some insane reason so bypass that.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchfacebook/homebrew-fb

branch : zpao-patch-1

created branch time in a month

created repositoryswavkulinski/ksp_prune_tool

Simple Dart tool for pruning unwanted *.cfg files from KSP

created time in 2 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

@wez how's this look?

isker

comment created time in 2 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

Aha! Homebrew's sandbox-exec profile does not allow setting setuid/setgid!

https://github.com/Homebrew/brew/issues/6019

MacPorts once had a similar issue: https://trac.macports.org/ticket/54963. Apparently file-write-setugid needs to be explicitly allowed in addition to file-write*.

The maintainers shot the proposal to allow them down.

So, I think the best we can do is print a caveat for this. What do you think @wez ?

isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

So, nothing I do inside of the formula works. Even system "chmod", "2777", "/usr/local/var/run/watchman". However, lower bits work just fine: chmod 0o444, "/usr/local/var/run/watchman has the expected effect.

However, when I fire up irb and simply do FileUtils.chmod 0o2777, "/usr/local/var/run/watchman", which is the same thing the current version of the formula in my branch is doing, it works.

I'm not very familiar with uid/gid. Is there something about the homebrew process itself that could be preventing the mode from being fully set?

isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

/bin/chmod 2777 /usr/local/var/run/watchman does get the desired result.

~/homebrew-fb:watchman ฮป chmod 2777 /usr/local/var/run/watchman
~/homebrew-fb:watchman ฮป ls -lh /usr/local/var/run/
total 1.0k
drwxr-xr-x   7 ikerins        staff    224 2020-07-22 00:06 nginx
drwxrwsrwx   3 ikerins        staff     96 2020-09-03 15:15 watchman

So what is ruby chmod doing? ๐Ÿ˜•

isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

But after starting watchman ikerins-state does have S in the group:

 ฮป tree -p /usr/local/var/run
/usr/local/var/run
โ”œโ”€โ”€ [drwxr-xr-x]  nginx
โ”‚ย ย  โ”œโ”€โ”€ [drwx------]  client_body_temp
โ”‚ย ย  โ”œโ”€โ”€ [drwx------]  fastcgi_temp
โ”‚ย ย  โ”œโ”€โ”€ [drwx------]  proxy_temp
โ”‚ย ย  โ”œโ”€โ”€ [drwx------]  scgi_temp
โ”‚ย ย  โ””โ”€โ”€ [drwx------]  uwsgi_temp
โ””โ”€โ”€ [drwxrwxrwx]  watchman
    โ””โ”€โ”€ [drwx--S---]  ikerins-state
        โ”œโ”€โ”€ [-rw-------]  log
        โ”œโ”€โ”€ [-rw-r--r--]  pid
        โ”œโ”€โ”€ [srw-------]  sock
        โ””โ”€โ”€ [-rw-------]  state

8 directories, 4 files
isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

was this captured prior to adding in the chmod?

No. I just reran everything end to end, here's the result:

~/homebrew-fb:watchman ฮป watchman shutdown-server && rm -rf /usr/local/var/run/watchman && brew remove watchman && brew install watchman.rb && tree -p /usr/local/var/run /usr/local/Cellar/watchman/2020.08.17.00/
{
    "version": "20200816.222424.0",
    "shutdown-server": true
}
Uninstalling /usr/local/Cellar/watchman/2020.08.17.00... (8 files, 7.4MB)
Updating Homebrew...
==> Auto-updated Homebrew!
Updated Homebrew from 2dbaaf35a to 793ab30bb.
Updated 1 tap (homebrew/cask-versions).
==> Updated Casks
brave-browser-beta                                                                                                                                                                                                  opera-beta

==> Downloading https://github.com/facebook/watchman/releases/download/v2020.08.17.00/watchman-v2020.08.17.00-macos.zip
Already downloaded: /Users/ikerins/Library/Caches/Homebrew/downloads/05e628c0f4811a1fa63b96efca2813e8b4d9c88caf931176768afeb1618f6226--watchman-v2020.08.17.00-macos.zip
๐Ÿบ  /usr/local/Cellar/watchman/2020.08.17.00: 8 files, 7.4MB, built in 3 seconds
/usr/local/var/run
โ”œโ”€โ”€ [drwxr-xr-x]  nginx
โ”‚ย ย  โ”œโ”€โ”€ [drwx------]  client_body_temp
โ”‚ย ย  โ”œโ”€โ”€ [drwx------]  fastcgi_temp
โ”‚ย ย  โ”œโ”€โ”€ [drwx------]  proxy_temp
โ”‚ย ย  โ”œโ”€โ”€ [drwx------]  scgi_temp
โ”‚ย ย  โ””โ”€โ”€ [drwx------]  uwsgi_temp
โ””โ”€โ”€ [drwxrwxrwx]  watchman
/usr/local/Cellar/watchman/2020.08.17.00/
โ”œโ”€โ”€ [-rw-r--r--]  INSTALL_RECEIPT.json
โ”œโ”€โ”€ [drwxr-xr-x]  bin
โ”‚ย ย  โ””โ”€โ”€ [-r-xr-xr-x]  watchman
โ””โ”€โ”€ [drwxr-xr-x]  lib
    โ”œโ”€โ”€ [-r--r--r--]  libcrypto.1.1.dylib
    โ”œโ”€โ”€ [-r--r--r--]  libgflags.2.2.dylib
    โ”œโ”€โ”€ [-r--r--r--]  libglog.0.dylib
    โ”œโ”€โ”€ [-r--r--r--]  libsodium.23.dylib
    โ””โ”€โ”€ [-r--r--r--]  libssl.1.1.dylib

9 directories, 7 files
isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

If you add another unix account to your system and try to use watchman, then you'll trigger the case where you need it to be 2777

Got it, I added a chmod.

would you mind sharing the tree -p output for the bin and lib dirs?

You mean those in Cellar?

~/homebrew-fb:watchman ฮป tree -p /usr/local/var/run/
/usr/local/var/run/
โ”œโ”€โ”€ [drwxrwxrwx]  watchman

I was hoping to see S in here for the group mode; was this captured prior to adding in the chmod?

    โ””โ”€โ”€ [drwx--S---]  ikerins-state
        โ”œโ”€โ”€ [-rw-------]  log
        โ”œโ”€โ”€ [-rw-r--r--]  pid
        โ”œโ”€โ”€ [srw-------]  sock
        โ””โ”€โ”€ [-rw-------]  state

~/homebrew-fb:watchman ฮป tree -p /usr/local/Cellar/watchman/2020.08.17.00/
/usr/local/Cellar/watchman/2020.08.17.00/
โ”œโ”€โ”€ [-rw-r--r--]  INSTALL_RECEIPT.json
โ”œโ”€โ”€ [drwxr-xr-x]  bin
โ”‚   โ””โ”€โ”€ [-r-xr-xr-x]  watchman
โ””โ”€โ”€ [drwxr-xr-x]  lib
    โ”œโ”€โ”€ [-r--r--r--]  libcrypto.1.1.dylib
    โ”œโ”€โ”€ [-r--r--r--]  libgflags.2.2.dylib
    โ”œโ”€โ”€ [-r--r--r--]  libglog.0.dylib
    โ”œโ”€โ”€ [-r--r--r--]  libsodium.23.dylib
    โ””โ”€โ”€ [-r--r--r--]  libssl.1.1.dylib

2 directories, 7 files
isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

If you add another unix account to your system and try to use watchman, then you'll trigger the case where you need it to be 2777

Got it, I added a chmod.

would you mind sharing the tree -p output for the bin and lib dirs?

You mean those in Cellar?

~/homebrew-fb:watchman ฮป tree -p /usr/local/var/run/
/usr/local/var/run/
โ”œโ”€โ”€ [drwxrwxrwx]  watchman
    โ””โ”€โ”€ [drwx--S---]  ikerins-state
        โ”œโ”€โ”€ [-rw-------]  log
        โ”œโ”€โ”€ [-rw-r--r--]  pid
        โ”œโ”€โ”€ [srw-------]  sock
        โ””โ”€โ”€ [-rw-------]  state

~/homebrew-fb:watchman ฮป tree -p /usr/local/Cellar/watchman/2020.08.17.00/
/usr/local/Cellar/watchman/2020.08.17.00/
โ”œโ”€โ”€ [-rw-r--r--]  INSTALL_RECEIPT.json
โ”œโ”€โ”€ [drwxr-xr-x]  bin
โ”‚ย ย  โ””โ”€โ”€ [-r-xr-xr-x]  watchman
โ””โ”€โ”€ [drwxr-xr-x]  lib
    โ”œโ”€โ”€ [-r--r--r--]  libcrypto.1.1.dylib
    โ”œโ”€โ”€ [-r--r--r--]  libgflags.2.2.dylib
    โ”œโ”€โ”€ [-r--r--r--]  libglog.0.dylib
    โ”œโ”€โ”€ [-r--r--r--]  libsodium.23.dylib
    โ””โ”€โ”€ [-r--r--r--]  libssl.1.1.dylib

2 directories, 7 files
isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

Thanks for doing this @isker! I can't directly test this at the moment; would you mind sharing the tree -p output for the bin and lib dirs? That's largely what I'm curious about!

isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

Just having the formula make the dir. Surprisingly I did not have to chmod it to 777, as the installation instructions say:

ฮป tree -p /usr/local/var/run/
/usr/local/var/run/
โ””โ”€โ”€ [drwxr-xr-x]  watchman
    โ””โ”€โ”€ [drwx--S---]  ikerins-state
        โ”œโ”€โ”€ [-rw-------]  log
        โ”œโ”€โ”€ [-rw-r--r--]  pid
        โ””โ”€โ”€ [srw-------]  sock

Everything seems to work fine like that.

If you add another unix account to your system and try to use watchman, then you'll trigger the case where you need it to be 2777

isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

@gonzaloserrano you tapped my branch? watchman-make simply isn't in the released zip files, so that's a problem for upstream. You can see for yourself here https://github.com/facebook/watchman/releases/download/v2020.08.17.00/watchman-v2020.08.17.00-macos.zip

isker

comment created time in 3 months

push eventfacebook/homebrew-fb

Distiller

commit sha 9149703f234dd168ec854c9c9c225566164dd067

Bump buck to version 2020.09.09.01 This commit was generated by release automation

view details

push time in 3 months

push eventfacebook/homebrew-fb

Jinlin Zhang

commit sha 6e3ed43b26a9123dc3683045ef849b91d16a4730

buck.rb syntax fix for ruby1.9 (#42) Co-authored-by: v-jizhang <66389669+buck-bot@users.noreply.github.com>

view details

push time in 3 months

PR merged facebook/homebrew-fb

buck.rb syntax fix for ruby1.9 CLA Signed

buck.rb syntax fix for ruby1.9

+5 -3

0 comment

1 changed file

v-jizhang

pr closed time in 3 months

PR opened facebook/homebrew-fb

buck.rb syntax fix for ruby1.9

buck.rb syntax fix for ruby1.9

+5 -3

0 comment

1 changed file

pr created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

@wez ping!

isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

@wez PTAL. Thanks!

isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

Just having the formula make the dir. Surprisingly I did not have to chmod it to 777, as the installation instructions say:

ฮป tree -p /usr/local/var/run/
/usr/local/var/run/
โ””โ”€โ”€ [drwxr-xr-x]  watchman
    โ””โ”€โ”€ [drwx--S---]  ikerins-state
        โ”œโ”€โ”€ [-rw-------]  log
        โ”œโ”€โ”€ [-rw-r--r--]  pid
        โ””โ”€โ”€ [srw-------]  sock

Everything seems to work fine like that.

isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

Maybe this problem is the answer to my question at https://github.com/facebook/watchman/issues/851#issuecomment-681084864 ? ๐Ÿ˜„

isker

comment created time in 3 months

pull request commentfacebook/homebrew-fb

Add a new watchman formula

Had a coworker test this out, didn't work because still wants that /usr/local/var/run/watchman to exist. Worked on my machine because I had already created it. Let me figure out what to do with this...

isker

comment created time in 3 months

PR opened facebook/homebrew-fb

Add a new watchman formula

The formula in homebrew-core is moribund, and as per https://github.com/facebook/watchman/issues/851#issuecomment-680272404, continuing to build watchman from source with brewed dependencies is untenable. So we add one that just distributes the released binaries here.

Eventually the url and sha will be updated automatically by the watchman release process.

You can test this formula out by running:

$ brew tap isker/homebrew-fb
$ brew install isker/fb/watchman
+17 -0

0 comment

1 changed file

pr created time in 3 months

more