profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/marco-c/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

llvm/llvm-project 10432

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

ishepard/pydriller 496

Python Framework to analyse Git repositories

delapuente/offliner 46

Offliner is a proof of concept about bringing offline web applications through service workers

marco-c/autowebcompat 33

Automatically detect web compatibility issues

luser/breakpad-mac-update-symbols 3

Scrape symbols from OS X system updates for Breakpad crash reporting

brendandahl/j2me.js 1

J2ME VM in JavaScript

kmos/gsi 1

General Sensors Interface API

armenzg/smart-scheduling 0

This is a project to support the Smart Scheduling initiative at Mozilla. This repo can hold various services including Taskcluster ETL cron integration.

ing-raf/SensorNode 0

Livello applicativo del nodo sensore

push eventmozilla/stab-crashes

commit sha 13ecbafea994f6e59492fca617676ed78be6d889

Updates

view details

push time in 12 hours

PullRequestReviewEvent

pull request commentmozilla/pdf.js

XFA - Create a new page in case of overflow

The contents of the "Badge details" section disappeared in firefox-xfa_bug1717668_2-page1.

calixteman

comment created time in a day

push eventmozilla/stab-crashes

commit sha 596602b03e40614dfd9b5b22a1fd7756ccdbc60f

Updates

view details

push time in a day

PullRequestReviewEvent

Pull request review commentmozilla/code-review

bot: do not throw exceptions when backend fails.

 def test_publication_failures(             "fix": None,         }     ]+++def test_publication_failures_total(

We should also add a test which runs the run function of the workflow and, even if the backend fails, it publishes some issues

abpostelnicu

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmozilla/code-review

bot: do not throw exceptions when backend fails.

 def create(self, url_path, data):         response = requests.post(url_post, json=data, auth=auth)         if not response.ok:             logger.warn("Backend rejected the payload: {}".format(response.content))-        response.raise_for_status()+            # return an empty dict

The comment no longer applies :P

abpostelnicu

comment created time in 2 days

Pull request review commentmozilla/code-review

bot: do not throw exceptions when backend fails.

 def create(self, url_path, data):         url_post = urllib.parse.urljoin(self.url, url_path)         response = requests.post(url_post, json=data, auth=auth)         if not response.ok:-            logger.warn("Backend rejected the payload: {}".format(response.content))-        response.raise_for_status()+            logger.warning("Backend rejected the payload: {}".format(response.content))
            logger.warn("Backend rejected the payload: {}".format(response.content))
abpostelnicu

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentmozilla/code-review

bot: do not throw exceptions when backend fails.

 def create(self, url_path, data):         url_post = urllib.parse.urljoin(self.url, url_path)         response = requests.post(url_post, json=data, auth=auth)         if not response.ok:-            logger.warn("Backend rejected the payload: {}".format(response.content))-        response.raise_for_status()+            logger.warning("Backend rejected the payload: {}".format(response.content))+            # return an empty dict+            return {}

We should return None instead so it's clearer for callers that there was nothing created, and so that we skip this: https://github.com/mozilla/code-review/blob/9df3342394e283213f6598100e4607c1a934d2cf/bot/code_review_bot/init.py#L142

abpostelnicu

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmozilla/code-review

bot: when a generic bot failure occurs also report it in phabricator.

 def main():             extras["error_message"] = str(e)         w.index(revision, state="error", **extras) -        # Update Harbormaster status-        w.update_status(revision, state=BuildState.Fail)+        # Update Phabricator+        failure = UnitResult(+            namespace="code-review",+            name="general",+            result=UnitResultState.Broken,+            details="WARNING: A generic error occurred in the code review bot.",+            format="remarkup",+            duration=0,+        )++        w.phabricator.update_build_target(+            revision.build_target_phid, BuildState.Fail, unit=[failure]+        )++        # Also update lando+        if lando_publish_generic_failure:+            try:+                lando_api.add_warning(

We should first delete the pre-existing "in progress" warnings, right?

abpostelnicu

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentmozilla/code-review

bot: when a generic bot failure occurs also report it in phabricator.

 def main():             extras["error_message"] = str(e)         w.index(revision, state="error", **extras) -        # Update Harbormaster status-        w.update_status(revision, state=BuildState.Fail)+        # Update Phabricator+        failure = UnitResult(+            namespace="code-review",+            name="general",+            result=UnitResultState.Broken,+            details="WARNING: A generic error occurred in the code review bot.",+            format="remarkup",+            duration=0,+        )++        w.phabricator.update_build_target(+            revision.build_target_phid, BuildState.Fail, unit=[failure]+        )++        # Also update lando+        if lando_api is not None:+            try:

Let's put it behind the same config as we have in events, so we can disable it if it gets too noisy for develoeprs

abpostelnicu

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentmozilla/code-review

bot: when a generic bot failure occurs also report it in phabricator.

 def main():         # Update Harbormaster status         w.update_status(revision, state=BuildState.Fail)

I don't know if this is still necessary after we add w.phabricator.update_build_target(, maybe not

abpostelnicu

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentmozilla/code-review

bot: when a generic bot failure occurs also report it in phabricator.

 def main():         # Update Harbormaster status         w.update_status(revision, state=BuildState.Fail) +        failure = UnitResult(

Could you report this to lando too, like we do in events?

abpostelnicu

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentmozilla/code-review

bot: when a generic bot failure occurs also report it in phabricator.

 def main():             w.ingest_autoland(revision)         else:             w.run(revision)+

Nit: please remove this extraneous new line

abpostelnicu

comment created time in 2 days

PullRequestReviewEvent

issue commentmozilla/code-review

Backend is failing with `pine` revisions

I filed #988 to document this better.

marco-c

comment created time in 2 days

issue openedmozilla/code-review

Add some steps to perform in order to add a new repository in the docs

In docs/new_repository.md.

created time in 2 days

issue commentmozilla/code-review

Backend is failing with `pine` revisions

We had to add Pine to the DB.

marco-c

comment created time in 2 days