profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/marcelofabri/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Marcelo Fabri marcelofabri iOS @Instacart San Francisco http://www.marcelofabri.com

danger/danger 4587

🚫 Stop saying "you forgot to …" in code review (in Ruby)

marcelofabri/BigBrother 445

Automatically sets the network activity indicator for any performed request.

ashfurrow/Nimble-Snapshots 303

Nimble matchers for FBSnapshotTestCase.

ashfurrow/danger-ruby-swiftlint 171

A Danger plugin for SwiftLint.

diogot/danger-xcode_summary 108

A Danger plugin that shows all build errors, warnings and unit tests results generated from xcodebuild.

CocoaPods/cocoapods-acknowledgements 106

CocoaPods plugin that generates a plist which includes the installation metadata

CocoaHeadsBrasil/equinociOS 71

O blog oficial do equinociOS

kylef-archive/CGFloatType 38

Provides various methods and functions to deal with CGFloat on 64-bit systems (CGFLOAT_IS_DOUBLE).

marcelofabri/app-store-manifesto 14

A manifesto for developers make a better App Store

fsaragoca/fastlane-plugin-changelog_generator 9

Changelog generation based on merged pull requests & tags

push eventrealm/SwiftLint

Marcelo Fabri

commit sha 896a700bfcf5da75f2cdce6471a3bd5351a8ce15

Fix unrelated test

view details

Marcelo Fabri

commit sha 6d4dc9408ccd301560e9465c2159befb097d7511

Make rule more generic and rename it

view details

push time in 17 hours

pull request commentrealm/SwiftLint

Add add_target_in_variable_declaration_closure rule

I wonder if this rule should just catch self instead

marcelofabri

comment created time in 3 days

push eventrealm/SwiftLint

Marcelo Fabri

commit sha 684650bf81753fd81caeb39a9dce8e7ac881568b

Fix violation

view details

push time in 3 days

push eventrealm/SwiftLint

Marcelo Fabri

commit sha 81097b70755973412b95ccf49efd57ec3679a13e

Remove unused function

view details

push time in 3 days

issue commentAsana/locheck

Provide binary as part of releases

Thanks!

marcelofabri

comment created time in 5 days

issue commentonevcat/Kingfisher

Instrumentation hooks

Ideally, we'd do that, but we have so many callsites that it's not super straightforward.

Also, we want to make sure this is called even when ImageDownloader is called directly, for example.

I totally understand if this extra complexity is not worth it from a library point of view though.

marcelofabri

comment created time in 5 days

issue openedAsana/locheck

Provide binary as part of releases

It'd be great to have a compiled binary uploaded to the GitHub release so it's easier for people to install/give it a try.

created time in 6 days

issue openedonevcat/Kingfisher

Instrumentation hooks

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

What

We want to add instrumentation on our app to figure out how long it takes for images to show, how often the cache is hit etc.

SessionDelegate and ImageDownloaderDelegate are good starting points, but unfortunately, they don't tell the full story. What do you think about introducing a Kingfisher​ManagerDelegate? Something like this:

protocol Kingfisher​ManagerDelegate: class {
  func kingfisherManager(_ manager: KingfisherManager, didStartLoadingImageForURL url: URL)
  func kingfisherManager(_ manager: KingfisherManager, didLoadImageForURL url: URL, result: Kingfisher.Result<Kingfisher.RetrieveImageResult, Kingfisher.KingfisherError>)
}

created time in 7 days

delete branch marcelofabri/RxSwift

delete branch : fix-permission

delete time in 13 days

PR opened ReactiveX/RxSwift

Fix swiftlint.sh permission

/Users/marcelofabri/Library/Developer/Xcode/DerivedData/Rx-hiovmvndvipdyrhimyvmvxphbqya/Build/Intermediates.noindex/Rx.build/Debug/RxSwift.build/Script-A21F589121E109AD0051AEA2.sh: line 2: /Users/marcelofabri/RxSwift/scripts/swiftlint.sh: Permission denied Command PhaseScriptExecution failed with a nonzero exit code

+0 -0

0 comment

1 changed file

pr created time in 13 days

create barnchmarcelofabri/RxSwift

branch : fix-permission

created branch time in 13 days

push eventmarcelofabri/RxSwift

dirtmelon

commit sha d0e5be62ddee4150d8d074be48902e22adca5d0a

Fix typo

view details

Daniel Tartaglia

commit sha 686b5e74f9a475245463cb6edfd79d1dcf2c438a

Check that aSelector is not nil before passing it on... (#2349)

view details

Gnoah

commit sha 63a1af5893bd9d53db5301e83ee42ee3a7deeae0

using OptionSet instead of enum for DisposeState (#2336)

view details

dungntm58

commit sha fe8f41d9a1c4225e0c2d4a0fd47572d426d8a903

Correct misspelled words

view details

Marcelo Fabri

commit sha 9c6e4ab81f4d68e73abdd8af0e488f06b467e9ff

Opt-out from RxNavigationControllerDelegateProxy being a @MainActor Apparently, moving the `UINavigationControllerDelegate` conformance to an extension makes it so `RxNavigationControllerDelegateProxy` is not recognized as `@MainActor`, avoiding compilation errors when using RxCocoa. Fixes https://github.com/ReactiveX/RxSwift/issues/2347

view details

Marcelo Fabri

commit sha baa95525c29639114c47f0d0ee1424bbaada5fa1

Update all proxies

view details

push time in 14 days

push eventmarcelofabri/RxSwift

Marcelo Fabri

commit sha 4704dffdb7b6dab5c5a0eccacbf163b439e68b6c

Update all proxies

view details

push time in 14 days

pull request commentReactiveX/RxSwift

Opt-out from RxNavigationControllerDelegateProxy being a @MainActor

Hey @marcelofabri - Thanks!

Can you take care of other delegate proxies in this PR so we have a full solution? Seems like some others were listed in #2347

Appreciate your help:)

I won't be able to get to it until next Tuesday, so feel free to push to this PR 😅

marcelofabri

comment created time in 17 days

startedAsana/locheck

started time in 19 days

issue commentdiogot/danger-xcode_summary

Full path to file in message

I suggest you do some debugging on your own then. I'd start by double checking what is the current workdir (pwd) when running Danger, as that's what we use to make paths relative.

You could also try to repro this in a smaller project that you can share. Otherwise, I'm afraid I cannot help you that much.

ismetanin

comment created time in 20 days

issue commentrealm/SwiftLint

`implicit_return` rule autocorrect output changes depending on swift version used

This is currently only on master.

fabfelici

comment created time in 20 days

issue commentdiogot/danger-xcode_summary

Full path to file in message

Interesting that the warning is on the xcodeproj file - any chance you can upload the whole xcresult so I can take a better look?

ismetanin

comment created time in 21 days

issue openedrealm/SwiftLint

False positive in closure_end_indentation

New Issue Checklist

Describe the bug

A clear and concise description of what the bug is.

Complete output when running SwiftLint, including the stack trace and command used
$ swiftlint lint
/Users/marcelofabri/SwiftLint/file.swift:10:1: warning: Closure End Indentation Violation: Closure end should have the same indentation as the line that started it. Expected 16, got 0. (closure_end_indentation)
Done linting! Found 1 violation, 0 serious in 1 file.

Environment

  • SwiftLint version (run swiftlint version to be sure)? 0.43.1
  • Installation method used (Homebrew, CocoaPods, building from source, etc)? Homebrew
  • Paste your configuration file:
opt_in_rules:
  - closure_end_indentation

No

  • Which Xcode version are you using (check xcodebuild -version)?

12.5.1

  • Do you have a sample that shows the issue? Run echo "[string here]" | swiftlint lint --no-cache --use-stdin --enable-all-rules to quickly test if your example is really demonstrating the issue. If your example is more complex, you can use swiftlint lint --path [file here] --no-cache --enable-all-rules.
Observable.combineLatest(
    mapSectionProviders(context: context)
        .map { provider -> Observable<HomeSection> in
            provider.fetch(context: context)
                .startWith(.empty)
                .catchAndReturn(.empty)
        }
).map { sections in
    sections.filter { !$0.items.isEmpty }
}

created time in 22 days

pull request commentdiogot/danger-xcode_summary

Collating test summaries

Sorry for not looking into this before. However, we've decided to move to a new direction with this plugin and as of 1.0.0, we've moved to use .xcresult. As a side effect, the test summary feature was (temporarily?) removed, but if this is something you're invested in, PRs adding it back (potentially with supporting to collating summaries) are welcome!

Vkt0r

comment created time in 22 days

release diogot/danger-xcode_summary

v1.0.0

released time in 22 days

created tagdiogot/danger-xcode_summary

tagv1.0.0

A Danger plugin that shows all build errors, warnings and unit tests results generated from xcodebuild.

created time in 22 days

push eventdiogot/danger-xcode_summary

Marcelo Fabri

commit sha 6f779564a26736bf8b098e34f6e9d1aced2da375

Add support for xcresult

view details

Marcelo Fabri

commit sha f24a3298f05dfd77ccb71bb8c6ece6ca0fa590b0

Use Xcode 11 on CI

view details

Marcelo Fabri

commit sha 51ac1d52334623f917ccc5e17829de31dc8a18d0

Install bundler 2.x

view details

Marcelo Fabri

commit sha fd92aab00bdaa83b291596c60125862f67bec5a4

Trigger CI

view details

Marcelo Fabri

commit sha 65d8a696ee658005e97abf7844e60b4d77809638

StartingLineNumber + 1

view details

Marcelo Fabri

commit sha 3fbcdb9912ca04b0ee335b1160ddce9a36dff539

Remove unimplemented summary related code

view details

Marcelo Fabri

commit sha bfc574068d9679db43b4737509e1436bba21af77

Update rubocop rules

view details

Marcelo Fabri

commit sha 91a119026514115001a73b3c3ffbfb114b690168

Update README for new release

view details

Marcelo Fabri

commit sha 8802839a81cfeb80b16dbf5d46123f39af3cecc1

Update version to 1.0.0

view details

Marcelo Fabri

commit sha e5a62660cd203eb1890eddbb78f0a1d70e65dc64

Update README

view details

Marcelo Fabri

commit sha cfe5762d997409c5a42129e2144b69afd3a3cd22

Make git treat xcresult as binary

view details

Marcelo Fabri

commit sha 0e875993ff4bb3f83d171663d41236b4ccaa0ffb

Merge pull request #48 from diogot/xcresult Add support for xcresult

view details

push time in 22 days

delete branch diogot/danger-xcode_summary

delete branch : xcresult

delete time in 22 days

push eventdiogot/danger-xcode_summary

Marcelo Fabri

commit sha cfe5762d997409c5a42129e2144b69afd3a3cd22

Make git treat xcresult as binary

view details

push time in 22 days

push eventdiogot/danger-xcode_summary

Marcelo Fabri

commit sha e5a62660cd203eb1890eddbb78f0a1d70e65dc64

Update README

view details

push time in 22 days

push eventdiogot/danger-xcode_summary

Marcelo Fabri

commit sha 3fbcdb9912ca04b0ee335b1160ddce9a36dff539

Remove unimplemented summary related code

view details

Marcelo Fabri

commit sha bfc574068d9679db43b4737509e1436bba21af77

Update rubocop rules

view details

Marcelo Fabri

commit sha 91a119026514115001a73b3c3ffbfb114b690168

Update README for new release

view details

Marcelo Fabri

commit sha 8802839a81cfeb80b16dbf5d46123f39af3cecc1

Update version to 1.0.0

view details

push time in 22 days