profile
viewpoint
Maor Friedman maorfr Red Hat Israel https://twitter.com/maorfr Principal Software Engineer, Site Reliability Engineering

helm/charts 14375

Curated applications for Kubernetes

maorfr/cain 7

Backup and restore tool for Cassandra on Kubernetes

app-sre/csnotify 1

Cloud stotage notifications for Go

app-sre/s3-reload 1

Simple binary to trigger a reload when an object in an S3 bucket is updated

app-sre/vault-manager 1

an automation tool for managing HashiCorp vault configurations based on Vault GO API Client

jmelis/hive 0

API driven OpenShift cluster provisioning and management

maorfr/amazon-emr-management-guide 0

The open source version of the Amazon EMR Management Guide. You can submit feedback & requests for changes by submitting issues in this repo or by making proposed changes & submitting a pull request.

push eventapp-sre/qontract-reconcile

Kyle Lape

commit sha 377256065b7ccda518a7a2a83c457b0729a8bfa0

Fix missing tuple return type in owner lgtm code (#1075)

view details

push time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha f7cfb734cb41073d3bf7125a297632ffa4e12a65

gitlab-housekeeping do not wait for incomplete pipelines (#1071)

view details

push time in 3 days

PR merged app-sre/qontract-reconcile

[gitlab-housekeeping] do not wait for incomplete pipelines

after changes made in #949 to wait for pipelines to complete, we now no longer want to wait. the reason for #949 was to handle a capacity issue (multiple jobs running for the same MR).

with an addition of a job cancellation (per branch) in app-interface, we now no longer want to wait: https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/9454

instead, we want to rebase as soon as we can and we will cancel the currently running job (as the only job that matters is the last one before a merge).

this should shorten the time between automated merges.

+12 -11

0 comment

1 changed file

maorfr

pr closed time in 3 days

PR opened app-sre/qontract-reconcile

[gitlab-housekeeping] do not wait for incomplete pipelines

after changes made in #949 to wait for pipelines to complete, we now no longer want to wait. the reason for #949 was to handle a capacity issue (multiple jobs running for the same MR).

with an addition of a job cancellation (per branch) in app-interface, we now no longer want to wait: https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/9454

instead, we want to rebase as soon as we can and we will cancel the currently running job (as the only job that matters is the last one before a merge).

this should shorten the time between automated merges.

+12 -11

0 comment

1 changed file

pr created time in 3 days

create barnchmaorfr/qontract-reconcile

branch : gl-hk-no-wait

created branch time in 3 days

Pull request review commentapp-sre/qontract-reconcile

secret_reader should raise a useful exception on vault forbidden error

 def read_all(secret, settings=None):     """      if settings and settings.get('vault'):-        return vault_client.read_all(secret)+        try:+            data = vault_client.read_all(secret)+        except hvac.exceptions.Forbidden:+            raise VaultForbidden(f'permission denied reading vault secret at '

this will still be retried multiple times. should we be specific in the retry function to not catch this?

jfchevrette

comment created time in 3 days

PullRequestReviewEvent

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha e517aea391560a451ab35fad168997b20d86aeba

jenkins-job-builder fix upstream error (#1070)

view details

push time in 3 days

PR merged app-sre/qontract-reconcile

[jenkins-job-builder] fix upstream error

this PR makes the default upstream value a string instead of None in case upstream is not defined on the first job.

fixes:

Traceback (most recent call last):
  File "/usr/local/bin/qontract-reconcile", line 33, in <module>
    sys.exit(load_entry_point('reconcile==0.2.2', 'console_scripts', 'qontract-reconcile')())
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/cli.py", line 506, in jenkins_job_cleaner
    run_integration(reconcile.jenkins_job_cleaner, ctx.obj)
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/cli.py", line 319, in run_integration
    func_container.run(dry_run, *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_cleaner.py", line 46, in run
    desired_job_names = get_desired_job_names(instance_name)
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_cleaner.py", line 22, in get_desired_job_names
    jjb, _ = init_jjb()
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_builder.py", line 156, in init_jjb
    configs, settings, additional_repo_urls = collect_configs()
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_builder.py", line 149, in collect_configs
    collect_saas_file_configs()
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_builder.py", line 93, in collect_saas_file_configs
    project['upstream'] += f',{upstream}'
TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'

cc @apahim

+1 -1

0 comment

1 changed file

maorfr

pr closed time in 3 days

PR opened app-sre/qontract-reconcile

[jenkins-job-builder] fix upstream error

fixes:

Traceback (most recent call last):
  File "/usr/local/bin/qontract-reconcile", line 33, in <module>
    sys.exit(load_entry_point('reconcile==0.2.2', 'console_scripts', 'qontract-reconcile')())
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click-7.1.2-py3.6.egg/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/cli.py", line 506, in jenkins_job_cleaner
    run_integration(reconcile.jenkins_job_cleaner, ctx.obj)
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/cli.py", line 319, in run_integration
    func_container.run(dry_run, *args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_cleaner.py", line 46, in run
    desired_job_names = get_desired_job_names(instance_name)
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_cleaner.py", line 22, in get_desired_job_names
    jjb, _ = init_jjb()
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_builder.py", line 156, in init_jjb
    configs, settings, additional_repo_urls = collect_configs()
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_builder.py", line 149, in collect_configs
    collect_saas_file_configs()
  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/reconcile/jenkins_job_builder.py", line 93, in collect_saas_file_configs
    project['upstream'] += f',{upstream}'
TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchmaorfr/qontract-reconcile

branch : jjb-upstream-fix

created branch time in 3 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

enable kms encryption for sqs

/retest

BumbleFeng

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retet

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 4 days

PullRequestReviewEvent

pull request commentapp-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

/retest

maorfr

comment created time in 5 days

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha fdaccd14b34291493c1538a133ce2035a48344e2

jenkins-job-cleaner include test jobs (#1066)

view details

push time in 6 days

PR merged app-sre/qontract-reconcile

[jenkins-job-cleaner] include test jobs

the cleaner should look at all jobs, including ones with test in their name :facepalm:

+5 -3

0 comment

2 changed files

maorfr

pr closed time in 6 days

PR opened app-sre/qontract-reconcile

[jenkins-job-cleaner] include test jobs

the cleaner should look at all jobs, including ones with test in their name :facepalm:

+5 -3

0 comment

2 changed files

pr created time in 6 days

create barnchmaorfr/qontract-reconcile

branch : jjb-cleaner-fix1

created branch time in 6 days

push eventmaorfr/qontract-reconcile

Maor Friedman

commit sha 3f0516e36a0e267a8ce69952b905701c0896b921

updates

view details

push time in 7 days

PR opened app-sre/qontract-reconcile

[wip][openshift-environments] introduce integration

This PR adds a new integration called openshift-environments.

This integration takes an environment file with a copy section pointing to an existing environment and to a target cluster (has to be created beforehand) and will copy all definitions relevant to the source environments. This will eventually become a MR to app-interface to add all the definitions.

Such definitions will include (for now):

  • namespace files
  • saas file targets
+132 -0

0 comment

5 changed files

pr created time in 7 days

create barnchmaorfr/qontract-reconcile

branch : openshift-environments

created branch time in 7 days

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha 18aee06e6a83f682f516f9f507f42ebf24d8201d

openshift canonicalize - remove metadata.managedFields (#1064)

view details

push time in 7 days

PR merged app-sre/qontract-reconcile

openshift canonicalize - remove metadata.managedFields

https://access.redhat.com/solutions/5332041 https://github.com/kubernetes/kubernetes/issues/90066

the new field managedFields which available in OpenShift (we're seeing it first in 4.5.7) makes all our integrations believe they need to reconcile resources over and over. this PR will make the integrations ignore this field.

+1 -0

0 comment

1 changed file

maorfr

pr closed time in 7 days

PR opened app-sre/qontract-reconcile

openshift canonicalize - remove metadata.managedFields

https://access.redhat.com/solutions/5332041 https://github.com/kubernetes/kubernetes/issues/90066

+1 -0

0 comment

1 changed file

pr created time in 7 days

create barnchmaorfr/qontract-reconcile

branch : pop-managed-fields

created branch time in 7 days

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha c7f21bc846d6d5e52b3ee3fee08b958b979b4264

jenkins-job-cleaner introduce integration (#1062)

view details

push time in 7 days

PR merged app-sre/qontract-reconcile

[jenkins-job-cleaner] introduce integration

this PR adds a new integration: jenkins-job-cleaner

this integration iterates through jenkins instances with a deleteMethod: manual and compares the existing jobs in the instance to the desired jobs calculated by jenkins-job-builder. for each such found job, if the job name starts with one of the managedProjects of the intsance - the integration will delete the job.

this ensures that we can only delete our own jobs in a multi-tenant jenkins instance.

+93 -1

0 comment

5 changed files

maorfr

pr closed time in 7 days

push eventmaorfr/qontract-reconcile

Amador Pahim

commit sha f42b5c4fd158ad2b28abd401ee55253de240d67c

Revert "tf-r-dry-run-no-oc (#1040)" This makes tf-r fail to create a new RDS isntance. This reverts commit 25e77ab8926c5b0835ee74b7c39c1b406f6a8c53.

view details

Maor Friedman

commit sha 19c02dec7a2b201ce9dd602ac5bd749f1e27d0a4

Merge branch 'master' into jenkins-job-cleaner

view details

push time in 7 days

push eventmaorfr/qontract-reconcile

Feng Huang

commit sha c65b32ac9866557e35557c5e9c04bebd49790936

s3-sqs fix (#1056) Signed-off-by: Feng Huang <fehuang@redhat.com>

view details

Feng Huang

commit sha 04f961907e3d62d643389359fe3b7cb3fc09b210

s3-sqs fix (#1059) Signed-off-by: Feng Huang <fehuang@redhat.com>

view details

Feng Huang

commit sha 33b715ac417abf1129fd07757f15b0c6521ea2cd

s3-sqs fix (#1060) Signed-off-by: Feng Huang <fehuang@redhat.com>

view details

Maor Friedman

commit sha b50cb0b6a1defb2fdba524f794fffae8655f6ce4

Merge branch 'master' into jenkins-job-cleaner

view details

push time in 9 days

PR opened app-sre/qontract-reconcile

[jenkins-job-cleaner] introduce integration

this PR adds a new integration: jenkins-job-cleaner

this integration iterates through jenkins instances with a deleteMethod: manual and compares the existing jobs in the instance to the desired jobs calculated by jenkins-job-builder. for each such found job, if the job name starts with one of the managedProjects of the intsance - the integration will delete the job.

this ensures that we can only delete our own jobs in a multi-tenant jenkins instance.

+93 -1

0 comment

5 changed files

pr created time in 9 days

create barnchmaorfr/qontract-reconcile

branch : jenkins-job-cleaner

created branch time in 9 days

pull request commentapp-sre/qontract-reconcile

add sharding for tf-r tf-u iam-key

respectfully cleaning the queue. :1st_place_medal:

BumbleFeng

comment created time in 10 days

PR closed app-sre/qontract-reconcile

tick tock

Reverts app-sre/qontract-reconcile#979

+6 -1

0 comment

1 changed file

maorfr

pr closed time in 10 days

PR closed app-sre/qontract-reconcile

more multistage build in Dockerfile

Reverts app-sre/qontract-reconcile#977

+36 -22

0 comment

1 changed file

maorfr

pr closed time in 10 days

pull request commentapp-sre/qontract-reconcile

[WIP] Add slack_sender integration

respectfully cleaning the queue. :1st_place_medal:

violetyao

comment created time in 10 days

PR closed app-sre/qontract-reconcile

WIP: use resources cache

Quite disappointing, I thought this was going to speed things up noticeably, but I only appreciate a 15s from ~300s.

+31 -12

1 comment

2 changed files

jmelis

pr closed time in 10 days

pull request commentapp-sre/qontract-reconcile

WIP: use resources cache

respectfully cleaning the queue. :1st_place_medal:

jmelis

comment created time in 10 days

pull request commentapp-sre/qontract-reconcile

[WIP] prometheus-alertmanager integration

respectfully cleaning the queue. :1st_place_medal:

jfchevrette

comment created time in 10 days

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha f087caf87c2e7a3c88cb7693a0d0cb8b2747eea9

openshift-resources fix api_resources check to match openshift-config (#1058)

view details

push time in 10 days

PR merged app-sre/qontract-reconcile

[openshift-resources] fix api_resources check to match managedResourceTypeOverrides

in the openshift-config namespace we use the managedResourceTypeOverrides field, which allows us to apply resources which have a kind that exists in more then a single api group.

this PR adds a handle for this case when checking if the desired kind exists in oc api-resources.

+5 -1

0 comment

1 changed file

maorfr

pr closed time in 10 days

push eventmaorfr/qontract-reconcile

Maor Friedman

commit sha 454c90767265f94d399eabacbc18a26d95673b4f

[ocm-clusters] add support for provision_shard_id (#1048)

view details

Maor Friedman

commit sha ab84353a50d91836d5de2727416f4f052e310269

Merge branch 'master' into oc-resource-api-res-fix

view details

push time in 10 days

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha 454c90767265f94d399eabacbc18a26d95673b4f

[ocm-clusters] add support for provision_shard_id (#1048)

view details

push time in 10 days

PR merged app-sre/qontract-reconcile

[ocm-clusters] add support for provision_shard_id

depends on https://gitlab.cee.redhat.com/service/uhc-clusters-service/-/merge_requests/2140 reaching production

this PR adds the ability to provision clusters in specific hive shards according to their id, as defined here: https://gitlab.cee.redhat.com/service/app-interface/-/blob/96ea6b2233a9416c7d3126d0462ac7bed7280d5c/data/services/ocm/namespaces/uhc-production.yml#L50

+6 -1

0 comment

3 changed files

maorfr

pr closed time in 10 days

PR opened app-sre/qontract-reconcile

[openshift-resources] fix api_resources check to match managedResourceTypeOverrides

in the openshift-config namespace we use the managedResourceTypeOverrides field, which allows us to apply resources which have a kind that exists in more then a single api group.

this PR adds a handle for this case when checking if the desired kind exists in oc api-resources.

+5 -1

0 comment

1 changed file

pr created time in 10 days

create barnchmaorfr/qontract-reconcile

branch : oc-resource-api-res-fix

created branch time in 11 days

push eventmaorfr/qontract-reconcile

Jaime Melis

commit sha 2239493b1f49162783b1f267d1a43ea8013716a1

add id to qontract-cli get cluster-upgrades (#1019) Co-authored-by: Maor Friedman <maor.friedman@redhat.com>

view details

Maor Friedman

commit sha c4a3976b575a0e60ffbf0bfa101b1e72b33aa3f0

Merge branch 'master' into ocm-cluster-provision-id

view details

push time in 11 days

push eventapp-sre/qontract-reconcile

Jaime Melis

commit sha 2239493b1f49162783b1f267d1a43ea8013716a1

add id to qontract-cli get cluster-upgrades (#1019) Co-authored-by: Maor Friedman <maor.friedman@redhat.com>

view details

push time in 11 days

push eventjmelis/qontract-reconcile

Maor Friedman

commit sha cab1370720918f61f286ff4661116c19ca8238d1

create_cloud_ingress_operator_cidr_blocks_mr support add/remove (#1021)

view details

Maor Friedman

commit sha 010ba2435e238605820e08c7d0ff5a926f9c4173

sentry-helper introduce new integration (#1023)

view details

Maor Friedman

commit sha 547fab882ea483e3b4bf33f3f1ca6a54977720b0

[sentry-helper] refactor (#1024)

view details

Maor Friedman

commit sha c65008a7cf6a2f9aeb26210a9c8853530c5d7d3b

validate saas files are reusing environment parameters (#1022)

view details

Maor Friedman

commit sha c8bd3736efb7b068072590dd750bcba3fd59a729

fix long title for cio (#1025)

view details

Maor Friedman

commit sha 2faffd9dfb1e148ce457cce7130a03b5cc63e0e9

gitlab-api add automerge for CIO add operations (#1026)

view details

Feng Huang

commit sha 70533d1d934928f3de848fb86955597b86a14e13

add advanced_options for aws_elasticsearch_domain (#1028) Signed-off-by: Feng Huang <fehuang@redhat.com>

view details

Amador Pahim

commit sha 950b6003b114b33eba3574820edf4d800e15e99c

Fix sql query identifier is not mandatory and sometimes it does not exist. Signed-off-by: Amador Pahim <apahim@redhat.com>

view details

Maor Friedman

commit sha 9ae16c45c332bc444d9611ca3189c6ffe00b39e5

openshift-resourcequotas allow empty run (#1030)

view details

Maor Friedman

commit sha e419fe33ab50797ce7ac29b8981d51a05f921054

aws-ecr-image-pull-secrets run once per 2h (#1031)

view details

Feng Huang

commit sha 37a8fa6aac6a305da7daf62de875dd3b20efce66

add s3-sqs (#1020) Signed-off-by: Feng Huang <fehuang@redhat.com>

view details

Maor Friedman

commit sha 2605fbeb5bfc4b5622b80ecb8de23dbe1154c535

[gitlab-labeler] introduce new integration (#1033)

view details

Maor Friedman

commit sha 3b20e910692bd782d59fa8f4912ee96691003203

gitlab-labeler list all project labels and add logging (#1035)

view details

Maor Friedman

commit sha 5d1f021e54484d3445a5f56052230743e02280b6

retry apply on error if it's not an invalid value error (#1036)

view details

Feng Huang

commit sha 1357675538ae74ec5055100c7ca67e77ac305175

allow running terraform-resources based integrations per account (#1032) Signed-off-by: Feng Huang <fehuang@redhat.com>

view details

Maor Friedman

commit sha e5e413cea5a175b0bbc7574721ebbecffec1bf0f

[ocm-clusters] add support for channel (#1037)

view details

Maor Friedman

commit sha c99264e71378878d0c4a3650233302f06b1d5aee

gitlab-labeler ignore cicd (#1039)

view details

Maor Friedman

commit sha 572de6c0fdf99cb6f9da3fad9f6f9b5d6f49de36

[ocm-clusters] handle empty version field (#1041)

view details

Amador Pahim

commit sha 2d6ef7456c260ad4c39fd76bafdafc32f386c22c

Adding email template The email template will replace the hard coded strings to build up an email file for app interface. Signed-off-by: Amador Pahim <apahim@redhat.com>

view details

Amador Pahim

commit sha ecae108be2058c8794971f9b6842b7858089ab0f

Adding aws access key email body template This will replace the hard coded email body for sending users that message. Signed-off-by: Amador Pahim <apahim@redhat.com>

view details

push time in 11 days

push eventmaorfr/qontract-reconcile

Amador Pahim

commit sha b5392ccf32ca8011450a100cd8a35b55cbabe465

Don't fail on template missing parameters The parameters are no really mandatory. Let's not fail when they are not present in the template. Signed-off-by: Amador Pahim <apahim@redhat.com>

view details

Maor Friedman

commit sha 3a642d10e90cae4e24981766889628a55ed48cb4

allow openshift-resources to pass when api resource is still not installed (#1054)

view details

Maor Friedman

commit sha 1af89837bdd571c16e7b707d3d098410bacc3e62

oc.api_resources fix (#1055)

view details

Maor Friedman

commit sha fe0064d2ffcb4f752d230b9f14c3ef655f208899

saas-file-owners allow users to be tagged on MRs (#1057)

view details

Maor Friedman

commit sha 79c16865d42e520e13dbc47f80006a731edcd622

use explicit bot labels (#1052)

view details

Maor Friedman

commit sha 86ea6b2e0eb697833f7ff11bd0bb8c32ecc89e9a

sentry-helper fixes (#1053)

view details

Maor Friedman

commit sha dd1c7a294263b04bfdd0085945dad79de2ea6bec

Merge branch 'master' into ocm-cluster-provision-id

view details

push time in 11 days

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha 86ea6b2e0eb697833f7ff11bd0bb8c32ecc89e9a

sentry-helper fixes (#1053)

view details

push time in 11 days

PR merged app-sre/qontract-reconcile

[sentry-helper] fixes

fixes comments in #1023.

+15 -7

0 comment

3 changed files

maorfr

pr closed time in 11 days

push eventmaorfr/qontract-reconcile

Maor Friedman

commit sha 1af89837bdd571c16e7b707d3d098410bacc3e62

oc.api_resources fix (#1055)

view details

Maor Friedman

commit sha fe0064d2ffcb4f752d230b9f14c3ef655f208899

saas-file-owners allow users to be tagged on MRs (#1057)

view details

Maor Friedman

commit sha 79c16865d42e520e13dbc47f80006a731edcd622

use explicit bot labels (#1052)

view details

Maor Friedman

commit sha 494d9a47549ce29ed974a3e495a8b801acc3fe11

Merge branch 'master' into sentry-helper-fixes

view details

push time in 11 days

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha 79c16865d42e520e13dbc47f80006a731edcd622

use explicit bot labels (#1052)

view details

push time in 11 days

PR merged app-sre/qontract-reconcile

use explicit bot labels

to make it clear that these labels are used by bots and not by humans, instead of using:

  • approved
  • hold
  • automerge
  • skip-ci we will now use:
  • bot/approved
  • bot/hold
  • bot/automerge
  • bot/skip-ci

we may remove the usage of the previous labels after this change.

+15 -12

0 comment

3 changed files

maorfr

pr closed time in 11 days

push eventmaorfr/qontract-reconcile

Amador Pahim

commit sha b5392ccf32ca8011450a100cd8a35b55cbabe465

Don't fail on template missing parameters The parameters are no really mandatory. Let's not fail when they are not present in the template. Signed-off-by: Amador Pahim <apahim@redhat.com>

view details

Maor Friedman

commit sha 3a642d10e90cae4e24981766889628a55ed48cb4

allow openshift-resources to pass when api resource is still not installed (#1054)

view details

Maor Friedman

commit sha 1af89837bdd571c16e7b707d3d098410bacc3e62

oc.api_resources fix (#1055)

view details

Maor Friedman

commit sha fe0064d2ffcb4f752d230b9f14c3ef655f208899

saas-file-owners allow users to be tagged on MRs (#1057)

view details

Maor Friedman

commit sha 7eb4eb10eb27226ebb0cefe498679b4f179a73b9

Merge branch 'master' into bot-labels

view details

push time in 11 days

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha fe0064d2ffcb4f752d230b9f14c3ef655f208899

saas-file-owners allow users to be tagged on MRs (#1057)

view details

push time in 11 days

PR merged app-sre/qontract-reconcile

[saas-file-owners] allow users to be tagged on MRs

part of https://issues.redhat.com/browse/APPSRE-2466

this PR adds an option for a user to define tag_on_merge_requests: true in their user file, which will lead to them being pinged on MRs for saas file they own.

+3 -0

0 comment

2 changed files

maorfr

pr closed time in 11 days

PR opened app-sre/qontract-reconcile

[saas-file-owners] allow users to be tagged on MRs

part of https://issues.redhat.com/browse/APPSRE-2466

this PR adds an option for a user to define tag_on_merge_requests: true in their user file, which will lead to them being pinged on MRs for saas file they own.

+3 -0

0 comment

2 changed files

pr created time in 11 days

create barnchmaorfr/qontract-reconcile

branch : tag-users

created branch time in 11 days

PullRequestReviewEvent

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha 1af89837bdd571c16e7b707d3d098410bacc3e62

oc.api_resources fix (#1055)

view details

push time in 11 days

PR merged app-sre/qontract-reconcile

oc.api_resources fix

fixes #1054

oc.api_resources is always set, either to None or to an actual value.

+1 -1

0 comment

1 changed file

maorfr

pr closed time in 11 days

PR opened app-sre/qontract-reconcile

oc.api_resources fix

fixes #1054

oc.api_resources is always set, either to None or to an actual value.

+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnchmaorfr/qontract-reconcile

branch : api-resource-fix

created branch time in 11 days

push eventmaorfr/qontract-reconcile

Amador Pahim

commit sha b5392ccf32ca8011450a100cd8a35b55cbabe465

Don't fail on template missing parameters The parameters are no really mandatory. Let's not fail when they are not present in the template. Signed-off-by: Amador Pahim <apahim@redhat.com>

view details

Maor Friedman

commit sha 3a642d10e90cae4e24981766889628a55ed48cb4

allow openshift-resources to pass when api resource is still not installed (#1054)

view details

Maor Friedman

commit sha 5660c04de179f377f4cc878a2578c111c5a8894f

Merge branch 'master' into sentry-helper-fixes

view details

push time in 11 days

push eventapp-sre/qontract-reconcile

Maor Friedman

commit sha 3a642d10e90cae4e24981766889628a55ed48cb4

allow openshift-resources to pass when api resource is still not installed (#1054)

view details

push time in 11 days

PR merged app-sre/qontract-reconcile

[openshift-resources] pass dry-run when api resource is still not installed

This is a fix for #993 which should have done this, but apparently was not tested well enough :wink: Full description in #993.

+6 -0

0 comment

1 changed file

maorfr

pr closed time in 11 days

PR opened app-sre/qontract-reconcile

[openshift-resources] pass dry-run when api resource is still not installed

This is a fix for #993 which should have done this, but apparently was not tested well enough :wink: Full description in #993.

+6 -0

0 comment

1 changed file

pr created time in 11 days

create barnchmaorfr/qontract-reconcile

branch : oc-resources-no-api-resource

created branch time in 11 days

PR opened app-sre/qontract-reconcile

[sentry-helper] fixes

fixes comments in #1023.

+15 -7

0 comment

3 changed files

pr created time in 11 days

create barnchmaorfr/qontract-reconcile

branch : sentry-helper-fixes

created branch time in 11 days

Pull request review commentapp-sre/qontract-reconcile

use explicit bot labels

-AUTO_MERGE = 'automerge'-SKIP_CI = 'skip-ci'+AUTO_MERGE = 'bot/automerge'+SKIP_CI = 'bot/skip-ci'

trying to make this PR super specific. wdyt?

maorfr

comment created time in 11 days

PullRequestReviewEvent

push eventmaorfr/qontract-reconcile

Maor Friedman

commit sha 4c796ae24be7ec05adba29217689f972cfed4146

update automerge and skip-ci

view details

push time in 11 days

PR opened app-sre/qontract-reconcile

[saas-file-owners] use explicit bot labels

instead of using approved and hold, we will now use bot/approved and bot/hold to make it clear that these labels are used by bots and not by humans.

we may remove the usage of approved and hold in a future PR.

+12 -10

0 comment

2 changed files

pr created time in 12 days

create barnchmaorfr/qontract-reconcile

branch : bot-labels

created branch time in 12 days

push eventmaorfr/qontract-reconcile

Jean-Francois Chevrette

commit sha cf00829005863aed9ccbb093590c091562b0af85

only consider targets that are not disabled (#1051)

view details

Feng Huang

commit sha 25e77ab8926c5b0835ee74b7c39c1b406f6a8c53

tf-r-dry-run-no-oc (#1040) Signed-off-by: Feng Huang <fehuang@redhat.com>

view details

Maor Friedman

commit sha f6d0f0c90723445034db788ba7f8451585c4c642

ocm-clusters add support for provision_shard_id

view details

Maor Friedman

commit sha f1f450ac90c72fe01bab2fdb918691ec9a76c1f0

fix typo

view details

push time in 12 days

PullRequestReviewEvent

pull request commentapp-sre/qontract-reconcile

Don't fail on template missing parameters

I only found this PR: #864. I didn't link any issues in it, but i believe it was about trying to look into the parameters which didn't exist. I think your approach works just as well.

apahim

comment created time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent
more