profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/mallachari/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Jakub Jankowski mallachari Warsaw, Poland

stoplightio/elements-starter-angular 2

Angular starter for stoplight elements components

mallachari/devBuilder 0

Build a developer app

mallachari/elApp 0

electron app

mallachari/incubator-samoa 0

Mirror of Apache Samoa (Incubating)

push eventmallachari/api

jakubj

commit sha bf5dc506b4a6c10717973cddd0160ec226fd9382

Modified 2 files

view details

push time in 9 days

push eventmallachari/api

jakubj

commit sha 617ba1a6c78476a31be140dfbce17c46191e2828

Added models/nesting.yaml

view details

push time in 13 days

issue closedstoplightio/elements

Missing array enum item definitions in query parameters

Describe the bug

Enums items of arrays in query parameters are not rendered correctly. This is related to https://github.com/stoplightio/elements/issues/1665 but now only appearing in query parameters.

I believe this is the right repo to post in, but if not let me know where I can add this!

To Reproduce

Given this OpenAPI path parameters:

        "parameters": [
          {
            "description": "An array query parameter",
            "in": "query",
            "name": "enum_array",
            "required": false,
            "schema": {
              "description": "An array query parameter",
              "items": {
                "enum": [
                "foo",
                "bar"
                ],
                "type": "string"
              },
              "type": "array"
            }
          }
	    ]

In the old-UI Stoplight, this is rendered as: image

In the new-UI Stoplight, this is rendered as: image

Expected behavior

I would expect the rendering to look just like body array enums, with array[string] description and allowed values: image

Additional context

Screenshots See above

Environment (remove any that are not applicable):

  • Library version: ???
  • OS: macOS catalina 10.15.6
  • Browser: Chrome 92.0.4515.159
  • Platform: web

closed time in 20 days

pelzhaus

issue closedstoplightio/elements

Enabling mocking adds an empty Prefer header

Describe the bug

When I enable mocking in try it using StoplightProject, I see an empty Prefer: header show up even though no config has been set for mocking.

To Reproduce

  1. Given this OpenAPI document: https://meta.stoplight.io/docs/sample-specs/b3A6OTM1-random-sticker
  2. Enable Mocking in Try It
  3. See error --header 'Prefer:'

Expected behavior

If no preferences set lets keep that header out of there.

Screenshots

Screen Shot 2021-09-10 at 10 29 38 AM

Environment (remove any that are not applicable):

  • Library version: Sept 10th 2021
  • Platform: web

closed time in 20 days

philsturgeon

pull request commentstoplightio/elements

Weekly lockfile maintenance

I think it might have been done for ui-kit Autosizer

stoplight-bot

comment created time in 22 days

Pull request review commentstoplightio/elements

Weekly lockfile maintenance

 describe('Response', () => {   window.URL.createObjectURL = jest.fn();    afterEach(() => {-    jest.resetAllMocks();+    (window.URL.createObjectURL as jest.Mock).mockReset();

So perhaps that is the reason why resetAllMocks nukes it. But it didn't break before, right? Anyway if that makes it work I think that's good enough. Though would be nice to know what's really happening there.

stoplight-bot

comment created time in 22 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentstoplightio/elements

Weekly lockfile maintenance

 describe('Response', () => {   window.URL.createObjectURL = jest.fn();    afterEach(() => {-    jest.resetAllMocks();+    (window.URL.createObjectURL as jest.Mock).mockReset();

Not sure if that's what you're referring to but we're using ResizeObserver in our tests setup: https://github.com/stoplightio/elements/blob/7fc0c80ead2b9e1e6cba3023579f38e6b916a990/setupTests.ts?plain=1#L24

stoplight-bot

comment created time in 22 days

pull request commentstoplightio/elements

chore: release Elements

I've added this fix to the description as it's also included now: https://github.com/stoplightio/elements/pull/1790

mmiask

comment created time in 23 days

push eventstoplightio/elements

Jakub Jankowski

commit sha 0a309c32066677cd145e4fdfb4ed1449cfccc32c

fix: use custom code component in mdv provider (#1790) Co-authored-by: paulatulis <47359669+paulatulis@users.noreply.github.com>

view details

Jakub Jankowski

commit sha 0d5f76715e3481dda98b63078d584af02f2ab4f8

Merge branch 'main' into chore/release

view details

push time in 23 days

IssuesEvent

PR merged stoplightio/elements

Reviewers
fix: use custom code component in mdv provider

Addresses: https://github.com/stoplightio/platform-internal/issues/8048 Addresses: https://github.com/stoplightio/platform-internal/issues/8047

When cleaning up markdown viewer providers we didn't add custom code component, and markdown viewer doesn't provide it itself. The result was that the default code component was used and both json_schema and http types weren't there.

This PR adds code component to provider default props and makes elements-core storybook use it.

elements-dev-portal is already using that provider in NodeContent so no need to change anything there.

+9 -3

3 comments

2 changed files

mallachari

pr closed time in 23 days

push eventstoplightio/elements

Jakub Jankowski

commit sha 0a309c32066677cd145e4fdfb4ed1449cfccc32c

fix: use custom code component in mdv provider (#1790) Co-authored-by: paulatulis <47359669+paulatulis@users.noreply.github.com>

view details

push time in 23 days

delete branch stoplightio/elements

delete branch : fix/mdv-code-component

delete time in 23 days

PullRequestReviewEvent

PR opened stoplightio/elements

fix: use custom code component in mdv provider

Addresses: https://github.com/stoplightio/platform-internal/issues/8048 Addresses: https://github.com/stoplightio/platform-internal/issues/8047

When cleaning up markdown viewer providers we didn't add custom code component, and markdown viewer doesn't provide it itself. The result was that the default code component was used and both json_schema and http types weren't there.

This PR adds code component to provider default props and makes elements-core storybook use it.

elements-dev-portal is already using that provider in NodeContent so no need to change anything there.

+9 -3

0 comment

2 changed files

pr created time in 23 days

create barnchstoplightio/elements

branch : fix/mdv-code-component

created branch time in 23 days

PullRequestReviewEvent

push eventstoplightio/elements

Jakub Jankowski

commit sha 8c4be46e8f8163a0b1da5d92e6c28d1981a3261e

fix: release (#1787)

view details

push time in 23 days

delete branch stoplightio/elements

delete branch : release

delete time in 23 days

PR merged stoplightio/elements

Reviewers
fix: release

elements-core@7.3.5 elements@7.3.5 elements-dev-portal@1.4.2

Changes: fix: dont include prefer header with no mock data (#1782) fix: default values for optional parameters (#1781)

+5 -5

3 comments

3 changed files

mallachari

pr closed time in 23 days

PR opened stoplightio/elements

Reviewers
fix: release

elements-core@7.3.5 elements@7.3.5 elements-dev-portal@1.4.2

Changes: fix: dont include prefer header with no mock data (#1782) fix: default values for optional parameters (#1781)

+5 -5

0 comment

3 changed files

pr created time in 24 days

create barnchstoplightio/elements

branch : release

created branch time in 24 days

push eventstoplightio/elements

Jakub Jankowski

commit sha 31e5c7cb8a0f6581e02db00e23f52a69ac90a44d

fix: dont include prefer header with no mock data (#1782)

view details

push time in 24 days

delete branch stoplightio/elements

delete branch : fix/try-it-prefer-header

delete time in 24 days

PR merged stoplightio/elements

Reviewers
fix: do not include prefer header with no mock data team/pierogi-platoon

Addresses https://github.com/stoplightio/elements/issues/1757

Prevents adding Prefer header when no mocking options are selected

Screenshot 2021-09-24 at 11 31 49

+34 -1

3 comments

2 changed files

mallachari

pr closed time in 24 days

push eventstoplightio/elements

Jakub Jankowski

commit sha b428fcb2c90b47f5584dfcd5fb4e49f6853050b8

fix: default values for optional parameters (#1781) * fix: default values for optional parameters * fix: optional not undefined * feat: use required parameters in form data body * fix: allow unsetting enums for optional parameters

view details

Jakub Jankowski

commit sha 02bdd1d7b263ad42c0be12b96a216648ba8b0c27

Merge branch 'main' into fix/try-it-prefer-header

view details

push time in 24 days

push eventstoplightio/elements

Jakub Jankowski

commit sha b428fcb2c90b47f5584dfcd5fb4e49f6853050b8

fix: default values for optional parameters (#1781) * fix: default values for optional parameters * fix: optional not undefined * feat: use required parameters in form data body * fix: allow unsetting enums for optional parameters

view details

push time in a month