profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/majnemer/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

google/xls 625

XLS: Accelerated HW Synthesis

regehr/opt-fuzz 27

llvm opt fuzzer and bounded exhaustive test generator

regehr/llvm-stress 1

fork of llvm-stress

majnemer/clang 0

Mirror of official clang git repository located at http://llvm.org/git/clang. Updated every five minutes.

majnemer/compiler-rt 0

Mirror of official compiler-rt git repository located at http://llvm.org/git/compiler-rt. Updated every five minutes.

majnemer/compiler-tests 0

This repo contains Microsoft compiler-tests to validate Windows platform particulars.

majnemer/docs 0

TensorFlow documentation

majnemer/draft 0

C++ standards drafts

majnemer/jax 0

Composable transformations of Python+NumPy programs: differentiate, vectorize, JIT to GPU/TPU, and more

PullRequestReviewEvent

Pull request review commenttensorflow/tensorflow

Fix endianness issue of internal data views in LiteralUtilTest (F16) on BE machines

 TEST_F(LiteralUtilTest, F16) {   half h1(1.0f);   half h2(2.0f);   auto m2 = LiteralUtil::CreateR2<half>({{h1, h2}, {h2, h1}});+  if (!tensorflow::port::kLittleEndian) {+    auto array_16 = reinterpret_cast<uint16_t*>(m2.data<half>().data());+    for (int i = 0; i < 4; i++) {+        array_16[i] = BYTE_SWAP_16(array_16[i]);+    }+  }   const char* d2 = reinterpret_cast<const char*>(m2.data<half>().data());   EXPECT_EQ(d2[0], 0);   EXPECT_EQ(d2[1], 0x3C);

LGTM, thanks!

kun-lu20

comment created time in 3 days

PullRequestReviewEvent

Pull request review commenttensorflow/tensorflow

Fix endianness issue of internal data views in LiteralUtilTest (F16) on BE machines

 TEST_F(LiteralUtilTest, F16) {   half h1(1.0f);   half h2(2.0f);   auto m2 = LiteralUtil::CreateR2<half>({{h1, h2}, {h2, h1}});+  if (!tensorflow::port::kLittleEndian) {+    auto array_16 = reinterpret_cast<uint16_t*>(m2.data<half>().data());+    for (int i = 0; i < 4; i++) {+        array_16[i] = BYTE_SWAP_16(array_16[i]);+    }+  }   const char* d2 = reinterpret_cast<const char*>(m2.data<half>().data());   EXPECT_EQ(d2[0], 0);   EXPECT_EQ(d2[1], 0x3C);

It might be nicer to instead do:

  const uint16_t* d2 = reinterpret_cast<const uint16_t*>(m2.data<half>().data());
  EXPECT_EQ(d2[0], 0x3C00);
  EXPECT_EQ(d2[1], 0x4000);
  EXPECT_EQ(d2[2], 0x4000);
  EXPECT_EQ(d2[3], 0x3C00);
kun-lu20

comment created time in 9 days

PullRequestReviewEvent

PR opened google/jax

Fix broken markdown

A backtick was missing.

+1 -1

0 comment

1 changed file

pr created time in 3 months

push eventmajnemer/jax

David Majnemer

commit sha 781f85b09ca675d901fd4bb7d409c84924cd72fc

Fix broken markdown A backtick was missing.

view details

push time in 3 months