profile
viewpoint
Luqman Aden luqmana @Microsoft Seattle, Washington http://luqman.ca/

luqmana/rust-opencl 166

OpenCL bindings for Rust.

luqmana/rust-psp-hello 75

Simple Hello World in Rust to run on a PSP.

luqmana/rhythmbox-plugins 53

Porting various Rhythmbox plugins to work with the new plugin api.

luqmana/gdax-client 32

Rust client library for Coinbase Exchange (GDAX).

luqmana/rray 8

Raytracer written in rust.

luqmana/mcchat 7

Fake client to get chat messages from minecraft (out-of-date).

luqmana/Pronto 7

Links freedesktop notifications to iOS app prowl.

luqmana/RemoteJoyPlus 6

Based on the original RemoteJoy by TyRaNiD with more stuff!

luqmana/llvm 2

Temporary fork of LLVM for Rust

luqmana/NowPlayingFile 1

A Rhythmbox plugin which simply outputs the currently playing track's information to a file. Based off of NowPlayingXML by kflorence. Updated to work with new plugin api.

push eventluqmana/xMangaPSP

Luqman Aden

commit sha c6a2bdcd475a2f358821df2728fa0dfcb49aa4ed

Don't create malformed user-agent.

view details

push time in 4 days

issue commentrust-lang/rust

Support Windows ARM

FYI the LLVM ERROR: target does not implement codeview register mapping error was because LLVM didn't completely implement the Windows debug format (codeview) for the 32-bit arm targets. So building without debuginfo would sidestep that error.

But I also submitted the fix for proper 32-bit ARM CodeView support upstream: https://reviews.llvm.org/D89622

Sadly the exception handling needed for panic=unwind is still unimplemented.

retep998

comment created time in 7 days

delete branch luqmana/llvm-project

delete branch : woa-codeview

delete time in 7 days

push eventllvm/llvm-project

Luqman Aden

commit sha 51892a42dac55558f7dbec80ced570e72ff387c4

[COFF][ARM] Fix CodeView for Windows on 32bit ARM targets. Create the LLVM / CodeView register mappings for the 32-bit ARM Window targets. Reviewed By: compnerd Differential Revision: https://reviews.llvm.org/D89622

view details

push time in 7 days

push eventluqmana/llvm-project

Luqman Aden

commit sha 91798b893824a440142fc9cf9280bd6c8936b760

[COFF][ARM] Fix CodeView for Windows on 32bit ARM targets. Create the LLVM / CodeView register mappings for the 32-bit ARM Window targets. Differential Revision: https://reviews.llvm.org/D89622

view details

push time in 7 days

push eventluqmana/llvm-project

Luqman Aden

commit sha b1ec1b35d614a6f5f245601d8c0f166fed21c5d8

[COFF][ARM] Fix CodeView for Windows on 32bit ARM targets. Create the LLVM / CodeView register mappings for the 32-bit ARM Window targets. Differential Revision: https://reviews.llvm.org/D89622

view details

push time in 7 days

push eventluqmana/llvm-project

Luqman Aden

commit sha b799ccb154d4501e0453ad20fd65d90baa6f3c57

[COFF][ARM] Fix CodeView for Windows on 32bit ARM targets. Create the LLVM / CodeView register mappings for the 32-bit ARM Window targets. Differential Revision: https://reviews.llvm.org/D89622

view details

push time in 7 days

push eventluqmana/llvm-project

Rob Suderman

commit sha ad1fe3963f30d0e7ef6796ad90bd4ddb6f7b117b

[MLIR] Fix gcc5 in D89161 Missing .str() makes gcc5 unable to infer the template to use. Differential Revision: https://reviews.llvm.org/D89516

view details

Zequan Wu

commit sha cd3090819c4eac750339496c8b8d3c92f8a3950c

[llvm-cov] don't include all source files when provided source files are filtered out When all provided source files are filtered out either due to `--ignore-filename-regex` or not part of binary, don't generate coverage reults for all source files. Because if users want to generate coverage results for all source files, they don't even need to provid selected source files or `--ignore-filename-regex`. Differential Revision: https://reviews.llvm.org/D89359

view details

Stella Laurenzo

commit sha 6771b98c4e4d5c0bd0a78a876bd212a76ec80a24

[mlir][CAPI] Add mlirAttributeGetType function. * Also fixes the const-ness of the various DenseElementsAttr construction functions. * Both issues identified when trying to use the DenseElementsAttr functions. Differential Revision: https://reviews.llvm.org/D89517

view details

Alexander Kornienko

commit sha cc175c2cc8e638462bab74e0781e06f9b6eb5017

Support ObjC in IncludeInserter Update IncludeSorter/IncludeInserter to support objective-c google style (part 1): 1) Correctly consider .mm/.m extensions 2) Correctly categorize category headers. 3) Add support for generated files to go in a separate section of imports Reviewed By: alexfh, gribozavr2 Patch by Joe Turner. Differential Revision: https://reviews.llvm.org/D89276

view details

Max Kazantsev

commit sha 905101c36025fe1c8ecdf9a20cd59db036676073

[SCEV] Use nw flag and symbolic iteration count to sharpen ranges of AddRecs We can sharpen the range of a AddRec if we know that it does not self-wrap and know the symbolic iteration count in the loop. If we can evaluate the value of AddRec on the last iteration and prove that at least one its intermediate value lies between start and end, then no-wrap flag allows us to conclude that all of them also lie between start and end. So the estimate of range can be improved to union of ranges of start and end. Differential Revision: https://reviews.llvm.org/D89381 Reviewed By: efriedma

view details

Zequan Wu

commit sha 19ae9b6e21e2491debeb910e2c541be9796f1b13

[llvm-cov] Fix test cases. `/dev/null` is treated as regualar file on Windows. native_separators.c line 11 used relative path which was not correct but worked before because when `SourceFiles` is empty, it add all source files into `SourceFiles`.

view details

Kito Cheng

commit sha cfa7094e49cfb7e37a84c0aa57c85c64c0581d17

[RISCV] Add -mtune support - The goal of this patch is improve option compatible with RISCV-V GCC, -mcpu support on GCC side will sent patch in next few days. - -mtune only affect the pipeline model and non-arch/extension related target feature, e.g. instruction fusion; in td file it called TuneFeatures, which is introduced by X86 back-end[1]. - -mtune accept all valid option for -mcpu and extra alias processor option, e.g. `generic`, `rocket` and `sifive-7-series`, the purpose is option compatible with RISCV-V GCC. - Processor alias for -mtune will resolve according the current target arch, rv32 or rv64, e.g. `rocket` will resolve to `rocket-rv32` or `rocket-rv64`. - Interaction between -mcpu and -mtune: * -mtune has higher priority than -mcpu for pipeline model and TuneFeatures. [1] https://reviews.llvm.org/D85165 Reviewed By: luismarques Differential Revision: https://reviews.llvm.org/D89025

view details

Fangrui Song

commit sha 5e09c45cbb2411a9636001894b546eb05a6fee3c

[RISCV] Fix -Wbraced-scalar-init after D89025

view details

Max Kazantsev

commit sha 1eb2c6d23f991a16afaaf898aeaf8f78e97be6fc

[SCEV][NFC] Split out type balancing in implication engine We plan to introduce more advanced ways of dealing with different types.

view details

Georgii Rymar

commit sha 3cfd9384bff476a4579c956e0c33697fee8bcf29

[lib/ObjectYAML] - Simplify the code that handles Content/Size fields. This is a follow-up for D89039 patch, which adds a support for `Content`/`Size` for all sections. Assuming that all of sections have a support of these 2 fields, we can simplify and generalize the code. Depends on D89039 Differential revision: https://reviews.llvm.org/D89120

view details

Mikael Holmen

commit sha e5e4653255ff7d78d62923038ff085fae47e950b

Remove dead variable to silence compiler warning [NFC]

view details

Nikita Popov

commit sha 7d3b475810baa26eb862bb555a0335eec6b988fc

Revert "[SCEV] Use nw flag and symbolic iteration count to sharpen ranges of AddRecs" This reverts commit 905101c36025fe1c8ecdf9a20cd59db036676073. This causes a large compile-time regression: https://llvm-compile-time-tracker.com/compare.php?from=cc175c2cc8e638462bab74e0781e06f9b6eb5017&to=905101c36025fe1c8ecdf9a20cd59db036676073&stat=instructions

view details

Konstantin Schwarz

commit sha 6030a075164c7016b29a67680ed5c9e7c5932109

Fix hidden-redecls.m test for some environments This test was failing in our CI environment, because Jenkins mounts the workspaces into Docker containers using their full path, i.e. /home/jenkins/workspaces/llvm-build. We've seen permission denied errors because /home/jenkins is mounted with root permissions and the default cache directory under Linux is $HOME/.cache. The fix is to explicitly provide the -fmodules-cache-path, which the other tests already seem to provide. Reviewed By: akyrtzi Differential Revision: https://reviews.llvm.org/D89453

view details

Florian Hahn

commit sha 51ff04567b2f8d06b2062bd3ed72eab2e93e4466

Recommit "[DSE] Switch to MemorySSA-backed DSE by default." After investigation by @asbirlea, the issue that caused the revert appears to be an issue in the original source, rather than a problem with the compiler. This patch enables MemorySSA DSE again. This reverts commit 915310bf14cbac58a81fd60e0fa9dc8d341108e2.

view details

Tony

commit sha e2af9bd6118eb9e64e28f36dd787da3905b8ba8b

[AMDGPU] Correct comment typo in AMDGPUSubtarget.h

view details

Florian Hahn

commit sha e034c3f7043a0f5a0b0af834a4b84d06e6b8948e

[SCEV] Add a few test cases where the max BTC is limited by wrapping.

view details

Dávid Bolvanský

commit sha 28691cdd714fb9b4a4d69dfc4f83a886582bf774

[MemLoc] Support memchr/memccpy in MemoryLocation::getForArgument Reviewed By: fhahn Differential Revision: https://reviews.llvm.org/D89321

view details

Simon Pilgrim

commit sha 55991b44b7f96a0aaa33ac53fc229302ca8d5d02

[InstCombine] foldAndOrOfICmpsOfAndWithPow2 - add vector support Support vector cases for folding: (iszero(A & K1) | iszero(A & K2)) -> (A & (K1 | K2)) != (K1 | K2) (!iszero(A & K1) & !iszero(A & K2)) -> (A & (K1 | K2)) == (K1 | K2)

view details

Caroline Concatto

commit sha e8d9ee9c7cfe46d9b552111a27d866fce0498b0a

[SVE][CodeGen]Use getFixedSize() function for TypeSize comparison in clang This patch makes sure that the instance of TypeSize comparison operator is done with a fixed type size. Differential Revision: https://reviews.llvm.org/D89312

view details

Simon Pilgrim

commit sha 1cf347e48b588ea277cc550b3ac57ecfa540618c

[InstCombine] narrowRotate - minor refactoring for funnel shift support. NFC. Prep work for PR35155 - renamed narrowRotate to narrowFunnelShift, rewrote some comments and adjusted code to collect separate shift values, although we bail if they don't match (still only rotations are only actually folded). I'm trying to match matchFunnelShift as much as possible in case we finally get to merge these one day.

view details

push time in 7 days

delete branch luqmana/rust

delete branch : lld-tls-alignment

delete time in 8 days

create barnchluqmana/llvm-project

branch : woa-codeview

created branch time in 9 days

create barnchluqmana/rust

branch : lld-tls-alignment

created branch time in 10 days

PR opened rust-lang/rust

LLVM: Backport fix for LLD COFF TLS Alignment.

Update LLVM submodule to pull in changes from https://github.com/rust-lang/llvm-project/pull/81.

Fixes #72145.

+1 -1

0 comment

1 changed file

pr created time in 10 days

delete branch luqmana/llvm-project

delete branch : rust-lld-tls-alignment

delete time in 10 days

create barnchluqmana/llvm-project

branch : rust-lld-tls-alignment

created branch time in 12 days

fork luqmana/llvm-project

Rust-specific fork of LLVM.

fork in 12 days

push eventllvm/llvm-project

Luqman Aden

commit sha f87c98def86be7b737799e9980af2a0b77e9bc28

Revert "[LLD] Set alignment as part of Characteristics in TLS table." Revert individual wip commits and will instead follow up with a single commit with all the changes. Makes cherry-picking easier and will contain all the right tags. This reverts commit 32a4ad3b6ce6028a371b028cf06fa5feff9534bf. This reverts commit 7fe13af676678815989a6d0ece684687953245e7. This reverts commit 51fbc1bef657bb0f5808986555ec3517a84768c4. This reverts commit f80950a8bb985c082b26534b0e157447bf803935. This reverts commit 0778cad9f325df4d7b32b22f3dba201a16a0b8fe. This reverts commit 8b70d527d7ec1c8b9e921177119a0d906ffad4f0.

view details

Luqman Aden

commit sha 6a73d6564a3c7d0757692aa93bdef5be0c8f01a5

[LLD] Set alignment as part of Characteristics in TLS table. Fixes https://bugs.llvm.org/show_bug.cgi?id=46473 LLD wasn't previously specifying any specific alignment in the TLS table's Characteristics field so the loader would just assume the default value (16 bytes). This works most of the time except if you have thread locals that want specific higher alignments (e.g. 32 as in the bug) *even* if they specify an alignment on the thread local. This change updates LLD to take the max alignment from tls section. Reviewed By: rnk Differential Revision: https://reviews.llvm.org/D88637

view details

push time in 12 days

push eventllvm/llvm-project

Luqman Aden

commit sha 32a4ad3b6ce6028a371b028cf06fa5feff9534bf

[LLD] Set alignment as part of Characteristics in TLS table. Fixes https://bugs.llvm.org/show_bug.cgi?id=46473 LLD wasn't previously specifying any specific alignment in the TLS table's Characteristics field so the loader would just assume the default value (16 bytes). This works most of the time except if you have thread locals that want specific higher alignments (e.g. 32 as in the bug) *even* if they specify an alignment on the thread local. This change updates LLD to take the max alignment from tls section. Reviewed By: rnk Differential Revision: https://reviews.llvm.org/D88637

view details

push time in 12 days

push eventllvm/llvm-project

Luqman Aden

commit sha 8b70d527d7ec1c8b9e921177119a0d906ffad4f0

[LLD] Set alignment as part of Characteristics in TLS table. Differential Revision: https://reviews.llvm.org/D88637

view details

Luqman Aden

commit sha 0778cad9f325df4d7b32b22f3dba201a16a0b8fe

Fix style warnings.

view details

Luqman Aden

commit sha f80950a8bb985c082b26534b0e157447bf803935

Update tests.

view details

Luqman Aden

commit sha 51fbc1bef657bb0f5808986555ec3517a84768c4

Mask out existing alignment bits.

view details

Luqman Aden

commit sha 7fe13af676678815989a6d0ece684687953245e7

Nit: Use early return to reduce indentation.

view details

push time in 12 days

push eventllvm/llvm-project

Luqman Aden

commit sha dc128e5968ccc632f7875ece639b0d2c94b170a6

[test][lld] Mark TLS tests as REQUIRES: x86. Fixes http://lab.llvm.org:8011/#/builders/119/builds/92

view details

push time in 13 days

push eventllvm/llvm-project

Luqman Aden

commit sha 6b7738e204b4b24b8afeccf9937e18b1f9a0eaf7

[LLD] Add baseline test for TLS alignment. NFC. Reviewed By: rnk Differential Revision: https://reviews.llvm.org/D88646

view details

push time in 13 days

push eventllvm/llvm-project

Luqman Aden

commit sha 568035ac3955790aee2a5dbc2b1f4074c76bb4d7

[llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test. Akin to dumpbin's /TLS option, this will print out the TLS directory, if present, in the image. Example output: ``` > llvm-readobj --coff-tls-directory test.exe File: test.exe Format: COFF-x86-64 Arch: x86_64 AddressSize: 64bit TLSDirectory { StartAddressOfRawData: 0x140004000 EndAddressOfRawData: 0x140004040 AddressOfIndex: 0x140002000 AddressOfCallBacks: 0x0 SizeOfZeroFill: 0x0 Characteristics [ (0x0) ] } ``` Reviewed By: jhenderson, grimar Differential Revision: https://reviews.llvm.org/D88635

view details

push time in 19 days

delete branch luqmana/cargo-xbuild

delete branch : patch-1

delete time in 20 days

PR opened rust-osdev/cargo-xbuild

Document build-std-features flag for Cargo's build-std.

Update the README to highlight the build-std-features flag cargo provides and how to use it to enable the mem feature in compiler-builtins.

+9 -1

0 comment

1 changed file

pr created time in 21 days

push eventluqmana/cargo-xbuild

Luqman Aden

commit sha fb5f54c00127f35948d37f35c107ff70fc5f6ed3

Document build-std-features flag for Cargo's build-std. Update the README to highlight the build-std-features flag cargo provides and how to use it to enable the mem feature in compiler-builtins.

view details

push time in 21 days

fork luqmana/cargo-xbuild

Automatically cross-compiles the sysroot crates core, compiler_builtins, and alloc.

fork in 21 days

delete branch luqmana/vscode

delete branch : workspace-mimetype

delete time in 23 days

issue commentrust-lang/rust

Incorrect compilation / STATUS_ACCESS_VIOLATION when linking with lld with target-cpu set

@petrochenkov Yes, it does. When the loader (ntdll) encounters a module (exe/dll) using TLS, it looks up the TLS directory in the PE image and uses the alignment specified there for all TLS data in the module. So my patch just makes LLD save the max alignment of all .tls sections it encounters in the final binary.

So that means as long as you're annotating your thread_local's with the right alignment then it will work fine, i.e. using __m512 which is align(64).

In terms of allowed values, it's powers of 2 up to 8192 bytes with 16 as the default if unspecified.

Systemcluster

comment created time in 25 days

issue commentrust-lang/rust

Incorrect compilation / STATUS_ACCESS_VIOLATION when linking with lld with target-cpu set

Finally got around to digging into LLD. Fix at https://reviews.llvm.org/D88637

Systemcluster

comment created time in 25 days

startedoverdrivenpotato/rust-psp

started time in 2 months

create barnchluqmana/rfcs

branch : windows-manifests

created branch time in 2 months

push eventluqmana/rfcs

Mazdak Farrokhzad

commit sha f1d4f6a8a67a2a78eb8b6bbba8a84cd7064236a7

RFC 2388

view details

Mazdak Farrokhzad

commit sha 05b989a3c614bddf97f058a93b77e4bf3b02ba5e

Merge pull request #2388 from Centril/rfc/try-expr RFC: Reserve `try` for `try { .. }` block expressions

view details

Simonas Kazlauskas

commit sha b1b24aaef838a6d78568ba2e9682f47ad89447ad

s/optimise/optimize

view details

boats

commit sha 99cbf010dc4bdac28948126f38554b71efc55424

Async/await.

view details

Vincent Esche

commit sha d8e240cf00459841ee6beceb45fb67c3dcfdf7c9

Fixed typos

view details

Aaron Turon

commit sha bfa5e16c7bd44391715b9b3f0d69ee0fe6b9d461

Typo fix

view details

Aaron Turon

commit sha 28626ac76190cbdefc446b82893527a5c508a37d

Add async blocks

view details

Aaron Turon

commit sha 2f28aaebe123911ae80f5d3d4028581a5b1d83ab

Rationale for async blocks

view details

Aaron Turon

commit sha 85932f5169e8466a0f6f753f67375a9c1e336f6a

Add more rationale for lazy async fn eval

view details

Aaron Turon

commit sha 55bc9b0aef2ba0b2dbe33cb8c0c3fb2040cefc8f

Update to match current futures APIs

view details

Aaron Turon

commit sha fba29e493095723e7491ecd9a4eeab9f6c60e1b1

Grab keywords

view details

Aaron Turon

commit sha 9771905952ea756167eeadb4d95d7455cf8f009b

Reorder async/move

view details

Josef Reinhard Brandl

commit sha 61062e90d7e91a5aa524e7eb8004ac904dc1d157

Fix typos

view details

Josef Reinhard Brandl

commit sha 57707fc20a0fbb19c32fe3cce2e1d8c3dadc5b4c

Explain use of initialization pattern

view details

Josef Reinhard Brandl

commit sha 17e9fbcbeca4cfaa64d46cfdd897c20dd7b2aa75

`?`-operator and control-flow constructs in async blocks

view details

Josef Reinhard Brandl

commit sha a82e5dd731d3ae4b3079284da3c3cc9a77847964

Ordering of async move keywords

view details

Josef Reinhard Brandl

commit sha 17a273dd1f3249e4260c780ebdd9dd19e986a429

Rename `async for` to `for await`

view details

boats

commit sha a9d66996021cfc02de076dc0497d329bc8fc36d2

RFC 2394 is async/await syntax.

view details

Peter Todd

commit sha 725bf172f383a21cf74189feb5073705778d2206

Fix typo in RFC 2000

view details

Mazdak Farrokhzad

commit sha adecae4da29556cc5a528b601bd2c2240ae794ea

Merge pull request #2435 from petertodd/2018-05_2000-typo Fix typo in RFC 2000

view details

push time in 2 months

PR closed bumptech/tl-dr.js

Changed it to use document.body as default root. Also removed extra semic

Changed it to use document.body as default root. Also removed extra semicolon.

+5 -6

0 comment

1 changed file

luqmana

pr closed time in 2 months

pull request commentmicrosoft/vscode

Register mimetype for *.code-workspace

Ping @Tyriar @joaomoreno

luqmana

comment created time in 2 months

delete branch luqmana/winrt-api

delete branch : vpnpacketbuffer-docs

delete time in 3 months

PR opened MicrosoftDocs/winrt-api

Update docs for retrieving VpnPacketBuffers.

The RequestVpnPacketBuffer is supported so let's remove the note indicating otherwise. Also add note regarding returning buffers back to the platform eventually.

cc @PeterSmithRedmond @stevewhims

+7 -3

0 comment

3 changed files

pr created time in 3 months

create barnchluqmana/winrt-api

branch : vpnpacketbuffer-docs

created branch time in 3 months

delete branch luqmana/winrt-api

delete branch : update-vpn-buffer-usage

delete time in 3 months

more