profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/lunaruan/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

bvaughn/react 15

A declarative, efficient, and flexible JavaScript library for building user interfaces.

lunaruan/babel 2

🐠 Babel is a compiler for writing next generation JavaScript.

lunaruan/prop-types 2

Runtime type checking for React props and similar objects

lunaruan/react 2

A declarative, efficient, and flexible JavaScript library for building user interfaces.

lunaruan/fbt 1

A JavaScript Internationalization Framework

lunaruan/flow 1

Adds static typing to JavaScript to improve developer productivity and code quality.

lunaruan/react-codemod 1

React codemod scripts

lunaruan/reactjs.org 1

The React documentation website

mission-city-swing/mcs_registration 1

Mission City Swing Front Desk Registration

ashleybot/CarnieBots 0

Programming game for 3rd-5th graders

PR opened facebook/relay

Fix: "Add project" button is not visible on users page

Not sure what the intended styles were here. But the "button" class makes the text white, making it completely invisible. Screenshot 2021-06-12 at 5 42 25 PM

Removing the class makes the link show up in orange color with an underline on hover: Screenshot 2021-06-12 at 5 44 13 PM

+1 -3

0 comment

1 changed file

pr created time in 2 days

PR opened facebook/relay

README: Fix users link

The previous link doesn't work.

+1 -1

0 comment

1 changed file

pr created time in 2 days

push eventfacebook/relay

facebook-github-bot

commit sha ba25a04668bde1a205e33d24a2478483c7330989

Deploying to gh-pages from @ f1f07ff390a30e581e6b260fb39931282eba8b77 🚀

view details

push time in 2 days

push eventfacebook/relay

Pedro Rittner

commit sha f1f07ff390a30e581e6b260fb39931282eba8b77

Bump crossbeam from 0.7 to 0.8, lsp from 0.3 to 0.5, lsp-types from 0.73 to 0.89 Reviewed By: alunyov, dtolnay Differential Revision: D29056473 fbshipit-source-id: 9434e9e0895d82482f4c70afa01a2f77702b965f

view details

push time in 2 days

push eventfacebook/relay

facebook-github-bot

commit sha 2ac9c7ea3a85a80548347d2c4dbbfa7e9338a3eb

Deploying to gh-pages from @ 8fe69804d2c04686ecb56ffcce8e5d9df1907ef8 🚀

view details

push time in 2 days

push eventfacebook/relay

Tianyu Yao

commit sha 8fe69804d2c04686ecb56ffcce8e5d9df1907ef8

Don't generate raw response type for @no_inline fragments when not needed Reviewed By: kassens Differential Revision: D29074508 fbshipit-source-id: 266da7d94204c462b6ba90138c24f678117ed856

view details

push time in 2 days

push eventfacebook/relay

facebook-github-bot

commit sha cc42c0b32038ed6d75f727ff5bb9802ea73364af

Deploying to gh-pages from @ 9fef6cc3831d10526fee820ad15b5f63a4e096b5 🚀

view details

push time in 2 days

push eventfacebook/relay

Daniel Sainati

commit sha 9fef6cc3831d10526fee820ad15b5f63a4e096b5

pre-suppress this typing errors ahead of 154 Reviewed By: samwgoldman Differential Revision: D29065246 fbshipit-source-id: f418041305a46df410dcbe3d9a4db81a61ac7014

view details

push time in 2 days

push eventfacebook/relay

facebook-github-bot

commit sha f80a0e7df20068a37e3aab2c3bbc01172f7ea81a

Deploying to gh-pages from @ 99937ec7fa681754c7a3d45f49b330b1753bf0d2 🚀

view details

push time in 2 days

push eventfacebook/relay

Robert Balicki

commit sha 99937ec7fa681754c7a3d45f49b330b1753bf0d2

Fix flag initialization in test RelayModernEnvironment-ExecuteWithSiblingAndNestedModule-test.js Reviewed By: tyao1 Differential Revision: D29045240 fbshipit-source-id: 7c24d3f054795861683555fc580bb918cfc35a68

view details

push time in 2 days

push eventfacebook/relay

facebook-github-bot

commit sha fe7e82d7f40054603ebb8cb936e17c592cc84a98

Deploying to gh-pages from @ b9957fdce680ee70845e587885cf33d1bee480d6 🚀

view details

push time in 3 days

push eventfacebook/relay

Andrey Lunyov

commit sha b9957fdce680ee70845e587885cf33d1bee480d6

Remove jest.resetModules(...) in RelayReferenceMarker-test.js Reviewed By: kassens Differential Revision: D29067216 fbshipit-source-id: df71b196c27807640ff009c33b303b580f3a879e

view details

push time in 3 days

push eventfacebook/relay

facebook-github-bot

commit sha 9957960f487f5ce28c98fc07b6d73f1789576d5a

Deploying to gh-pages from @ 9d86b349a1aa9c17540aa21ae131b416c90ed81d 🚀

view details

push time in 3 days

pull request commentfacebook/relay

Fix: Check if global exists before calling ErrorUtils

@poteto merged this pull request in facebook/relay@9d86b349a1aa9c17540aa21ae131b416c90ed81d.

mellson

comment created time in 3 days

push eventfacebook/relay

Anders Bech Mellson

commit sha 9d86b349a1aa9c17540aa21ae131b416c90ed81d

Fix: Check if global exists before calling ErrorUtils (#3465) Summary: I was experiencing some `global is not defined`'s from `RelayPublishQueue.js` when using Relay in Vite. And I think this change will solve it for the cases where global is not yet defined. Pull Request resolved: https://github.com/facebook/relay/pull/3465 Reviewed By: tyao1 Differential Revision: D28937317 Pulled By: poteto fbshipit-source-id: d95b9f3cda1fa6325a992e2886d2886c8833a134

view details

push time in 3 days

PR closed facebook/relay

Fix: Check if global exists before calling ErrorUtils CLA Signed

I was experiencing some global is not defined's from RelayPublishQueue.js when using Relay in Vite. And I think this change will solve it for the cases where global is not yet defined.

+1 -1

5 comments

1 changed file

mellson

pr closed time in 3 days

push eventfacebook/relay

facebook-github-bot

commit sha 2c45d45675b9e5da393899cf704bcb84a290ddca

Deploying to gh-pages from @ b9f8d6246096dc984198993a2f163f709445d4f7 🚀

view details

push time in 3 days

push eventfacebook/relay

Tianyu Yao

commit sha b9f8d6246096dc984198993a2f163f709445d4f7

Parallelize more of the persist_operations Reviewed By: alunyov Differential Revision: D29053309 fbshipit-source-id: 9c148c845684954a25d82f110f26217b090da21d

view details

push time in 3 days

push eventfacebook/relay

facebook-github-bot

commit sha 23e23b7ab87e1806f97d8d6df1a29370cc4d3961

Deploying to gh-pages from @ c53f819127ab4385e0373facf79a10d770599506 🚀

view details

push time in 3 days

push eventfacebook/relay

Andrey Lunyov

commit sha 71c99cc56928b499627fc6061a887e9882a5586f

Register ActorSpecificEnvironment with Relay DevTools Reviewed By: kassens Differential Revision: D29038489 fbshipit-source-id: bc2ba58c91b5da1b1f30a2fc24c046822005ebf3

view details

Andrey Lunyov

commit sha c53f819127ab4385e0373facf79a10d770599506

Add StoreInspector to the ActorSpecificEnvironment Reviewed By: kassens Differential Revision: D29040367 fbshipit-source-id: b32c12bd61fbcf062730d5b7b3037fa599cf7351

view details

push time in 3 days

push eventfacebook/relay

facebook-github-bot

commit sha 6288c895822673df2a6ca99f64c6cc81e07b912e

Deploying to gh-pages from @ ce3319502236e77dc7de9a41d126473803b413cc 🚀

view details

push time in 3 days

pull request commentfacebook/relay

Revert publish CI job to node 14

@kassens merged this pull request in facebook/relay@ce3319502236e77dc7de9a41d126473803b413cc.

kassens

comment created time in 3 days

push eventfacebook/relay

Jan Kassens

commit sha ce3319502236e77dc7de9a41d126473803b413cc

Revert publish CI job to node 14 (#3515) Summary: It appears bfb1654b2af9b7f4a789b45e39e6dbe4c08778f1 broke publishing releases automatically to NPM. Checking if this was due to the Node version bump. Pull Request resolved: https://github.com/facebook/relay/pull/3515 Reviewed By: alunyov Differential Revision: D29044519 Pulled By: kassens fbshipit-source-id: 72e3e2a64e78f5a53068c12b68824f8e75b6202f

view details

push time in 3 days

PR closed facebook/relay

Revert publish CI job to node 14 CLA Signed

It appears bfb1654b2af9b7f4a789b45e39e6dbe4c08778f1 broke publishing releases automatically to NPM. Checking if this was due to the Node version bump.

+1 -1

1 comment

1 changed file

kassens

pr closed time in 3 days

pull request commentfacebook/relay

Revert publish CI job to node 14

@kassens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kassens

comment created time in 3 days

PR opened facebook/relay

Revert publish CI job to node 14

It appears bfb1654b2af9b7f4a789b45e39e6dbe4c08778f1 broke publishing releases automatically to NPM. Checking if this was due to the Node version bump.

+1 -1

0 comment

1 changed file

pr created time in 3 days

push eventfacebook/relay

facebook-github-bot

commit sha 89dd6ed76919e71ce7cd94282d0112a4c3cacd19

Deploying to gh-pages from @ 3bb180663a7b420cbcab68fbfa80183e21d6904a 🚀

view details

push time in 3 days

push eventfacebook/relay

Andrey Lunyov

commit sha 3bb180663a7b420cbcab68fbfa80183e21d6904a

disable broken test in relay-compiler-playground/src/lib.rs Reviewed By: captbaritone Differential Revision: D29007434 fbshipit-source-id: 29a0a7c641e7ebddbe12df65a6a5c6188b3caa83

view details

push time in 3 days

issue openedfacebook/relay

Hooks - `useFragment` (sometimes) returns null when record is deleted

Version: react-relay@11.0.2

Issue: the return value for useFragment is null in some circumstances. The types suggest that this should not occur.

Repro in the example TODO app: https://codesandbox.io/s/usefragment-returns-null-6tynl?file=/src/Todo.tsx:1027-1035

https://user-images.githubusercontent.com/489896/121592515-c8106980-ca08-11eb-89fb-ecff932b9fe9.mp4

Notes:

  • A newly-created record can be deleted just fine. It is properly un-rendered.
  • A record that existed at page load does not seem to be immediately removed from the connection, and it renders once more with useFragment returning null.

Using @deleteEdge (or the corresponding updater code, as is in the example TODO app) works fine. However, in our use case, the record also needs to be deleted in order to update other bits of UI.

Other approaches tried:

  • using both @deleteRecord and @deleteEdge together (not yet supported?)
  • in updater function, performing explicit deleteEdge and deleting the record in different orders (same result)

Thanks for reading!

created time in 3 days

push eventfacebook/relay

facebook-github-bot

commit sha 926272b915803cdf867837694a8a1e38941640b5

Deploying to gh-pages from @ 7c1f3eb607b28a3b62b75f515faa6862e131e7d6 🚀

view details

push time in 4 days