profile
viewpoint
Luigi Pinca lpinca Foligno (PG), Italy

cayasso/cacheman 225

Small and efficient cache provider for Node.JS with In-memory, File, Redis and MongoDB engines

lpinca/binb 211

:notes: Competitive, multiplayer, realtime, guess the song game

cayasso/primus.io 90

Primus.IO Real Time framework build on top of the great Primus, it makes running with it a little slicker :-)

cayasso/primus-rooms 83

Node Plugin for adding rooms functionality to Primus

cayasso/primus-emitter 51

Simple emitter wrapper for Primus

cayasso/cacheman-redis 36

Redis standalone caching library for Node.JS and also cache engine for cacheman

cayasso/primus-multiplex 32

Add multiplexing to Primus

cayasso/cacheman-mongo 21

MongoDB standalone caching library for Node.JS and also cache engine for cacheman

cayasso/primus-rooms-adapter 6

In-memory default adapter for `primus-rooms`.

cayasso/cacheman-memory 5

In-memory caching library for Node.JS and also cache engine for cacheman

PR opened qgis/qwc2

Add XYZ tiles for Google Maps

Add Google Maps to CONFIGPROVIDER.

+14 -0

0 comment

1 changed file

pr created time in 4 hours

create barnchlpinca/qwc2

branch : add/google-maps

created branch time in 4 hours

push eventlpinca/qwc2

Luigi Pinca

commit sha eb133c7963e6c5a9e44f6dc1bef282d0ba1c4117

Fix production build on Windows Remove the single quotes from the value of the `NODE_ENV` environment variable.

view details

Sandro Mani

commit sha 486e4aff6e47210907f91fd3bf26900eda4eaef5

Implement logic for handling external layers

view details

Sandro Mani

commit sha b0b37cdd89f09b047e5980f7c638bd17941bf016

Enforce external layer type "wms", add fallbacks for featureInfoUrl and queryLayers

view details

Sandro Mani

commit sha 4fb259faa65413ed56f999b4c83f6790231a32a3

Robustness fixes

view details

Sandro Mani

commit sha f6573d207e982d821858192db11cfeda711d5ef0

Add missing return statement

view details

Sandro Mani

commit sha bbeb0b122bda66559af3bb36fa03c9dd3264ace4

Add fallback for external layer title

view details

spaceman99

commit sha c5396901ca324a30da00c3137e7eb8530407fbc4

add loading indication while calculating profile (#96)

view details

Sandro Mani

commit sha d0f99c4307ad7175254522f5b4eb57ecc90bd491

Fix broken english translation file

view details

Sandro Mani

commit sha 1dc6f53c9b7f160d37b5e9cab8c5566481fcbb9a

Fix incorrectly unsetting locate stopFollow handler

view details

Mathias Walker

commit sha 4fe5cff41a566d46d88ef908800c8e601acf5e50

Fix config for external layers not being optional

view details

Sandro Mani

commit sha 89e2e4a99c8b562b8fdac66106fbd10d87c6bf72

Allow re-using redlining styles also outside of Redlining container element

view details

Sandro Mani

commit sha a92e3047ddf94b1c45dd08d44c7f5e7c40f9d9b0

Add support for generic pluginData sections in themesConfig.json

view details

Sandro Mani

commit sha e31640a37bed9a59f13ef23aa8ee1ae098d0740d

Add SearchBox

view details

Sandro Mani

commit sha 74c8b09bdb10e7b9f9054d8b3c110e19036e691b

Set unset number and boolean properties to zero/false when committing newly drawn features

view details

Sandro Mani

commit sha d84d13848fd20e119067c419d2b758d505c6cc82

Allow disabling touch-friendly widgets in edit form

view details

Sandro Mani

commit sha 6aadc1518cee3a9836a2b7fa5a16d697fdd5716b

Use a textarea for edit text fields

view details

Sandro Mani

commit sha 4e9fb03b855f64c13c4d303c9f4c764bff0500b0

Robustness fixes

view details

Sandro Mani

commit sha fce80025a9427fe25bd0ba43244811207e133c60

Add option to display collapsible groups in the theme switcher

view details

push time in 5 hours

issue commentnodejs/node

Performance of for await of (async iteration)

@nodejs/streams @ronag

alubbe

comment created time in 17 hours

push eventpnmsib/qwc2-demo-app

Sandro Mani

commit sha 4ae17b1c219652066e790cc4fa74ca6c12663b3e

Update submodule

view details

lpinca

commit sha 1ddc58727151091f54ad95a687db5e68dabc91b8

Tweak configuration for Monti Sibillini National Park maps

view details

push time in a day

issue commentnodejs/node

Recent behavior change of buffered write callbacks

Ok, I've remove the blocked label from https://github.com/nodejs/node/pull/31179 so that it can land.

lpinca

comment created time in a day

issue commentwebsockets/ws

Is it possible to connect to a python websocket server with ws?

Yes it should work.

yimelia

comment created time in 2 days

push eventpnmsib/qwc2-demo-app

lpinca

commit sha bfcd69f3155bff054267c5bdaea8fec311ccb11d

Tweak configuration for Monti Sibillini National Park maps

view details

push time in 2 days

push eventprimus/metroplex

greenkeeper[bot]

commit sha 94fddb5158690797a537d8b74841dbf612cb71e7

[pkg] Update async to version 3.2.0 (#88)

view details

push time in 2 days

PR merged primus/metroplex

Update async to the latest version 🚀 greenkeeper

The dependency async was updated from 3.1.1 to 3.2.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: aearly License: MIT

Find out more about this release.


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+1 -1

0 comment

1 changed file

greenkeeper[bot]

pr closed time in 2 days

push eventprimus/omega-supreme

greenkeeper[bot]

commit sha a6df1a673beb6a7871cb9ab9c94806a0e6d3d9eb

[pkg] Update async to version 3.2.0 (#82)

view details

push time in 2 days

PR merged primus/omega-supreme

Update async to the latest version 🚀 greenkeeper

The dependency async was updated from 3.1.1 to 3.2.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: aearly License: MIT

Find out more about this release.


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+1 -1

0 comment

1 changed file

greenkeeper[bot]

pr closed time in 2 days

issue closedwebsockets/ws

How to use stream API on the server? Are there any relevant examples?

I don't see an example of using the stream API on the server side, but the websocket-stream project has

closed time in 3 days

mmm8955405

pull request commentnodejs/node

test: mark empty udp tests flaky on OS X

Oh, I forgot to use the --flaky-tests flag.

sam-github

comment created time in 3 days

issue commentwebsockets/ws

How to use stream API on the server? Are there any relevant examples?

As documented here https://github.com/websockets/ws/blob/master/doc/ws.md#websocketcreatewebsocketstreamwebsocket-options

server.on('connection', function(ws) {
  const duplex = WebSocket.createWebSocketStream(ws, { encoding: 'utf8' });
});
mmm8955405

comment created time in 3 days

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-02-26

It's the same. Anyway my main point on https://github.com/nodejs/node/issues/31317 is that https://github.com/nodejs/node/pull/30596 is an unnecessary fix and the cons outweigh the pros.

mhdawson

comment created time in 3 days

issue closedMONEI/Shopify-api-node

Create asset return 406

Have been working on this issue for hours, cannot create asset using asset() resource.

Here is example query:

const id = this.themeId;

const query = {
  asset: {
    key: "snippets/test.liquid",
    value: "Content"
  }
};

const asset = await this.shopify.asset.create(id, query); // throws 406 Not Acceptable error

By the way I notice 2 small errors on asset create test...

  1. Using the asset 'update' fixin instead of the 'create' fixin
  2. Using the res fixin data instead of the req - basically an invalid request on the test itself?

closed time in 3 days

Popesites

issue commentMONEI/Shopify-api-node

Create asset return 406

It's ok. See,

https://github.com/MONEI/Shopify-api-node/blob/f91e090c57b08008c3ecf53718c130111daf5aa3/test/asset.test.js#L69

input.asset is

const params = { 
   key: 'assets/empty.gif', 
   attachment: 'R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw==\n' 
} ;
Popesites

comment created time in 3 days

issue commentMONEI/Shopify-api-node

Create asset return 406

I don't see the error:

https://github.com/MONEI/Shopify-api-node/blob/f91e090c57b08008c3ecf53718c130111daf5aa3/test/asset.test.js#L62-L71

https://github.com/MONEI/Shopify-api-node/blob/f91e090c57b08008c3ecf53718c130111daf5aa3/test/fixtures/asset/req/create.json#L1-L6

https://github.com/MONEI/Shopify-api-node/blob/f91e090c57b08008c3ecf53718c130111daf5aa3/test/fixtures/asset/res/create.json#L1-L11

In your usage example the second argument of the create() method should only be

const params = { key: 'snippets/test.liquid', value: 'Content' };
Popesites

comment created time in 4 days

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-02-26

Thanks @mcollina but I can't make it.

mhdawson

comment created time in 4 days

pull request commentnodejs/node

test: mark empty udp tests flaky on OS X

I've run make -j8 test with the patch applied but the process still exits with 2 not sure if expected. All the tested listed timeout as expected.

sam-github

comment created time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : zonizzazione

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : vegetazione-tendenze-dinamiche

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : vegetazione-reale

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : vegetazione-potenziale

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : uso-suolo

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : percorsi

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : erosione-potenziale-suoli

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : custom-branding

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : carta-pedologica

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : carta-idrogeologica

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : carta-geologica

delete time in 4 days

delete branch pnmsib/qwc2-demo-app

delete branch : bivacco

delete time in 4 days

push eventpnmsib/qwc2-demo-app

Mathias Walker

commit sha 8571deaac6f8944897dbf36d885428c617be2f3a

Update submodule

view details

lpinca

commit sha 4112064931a11d1a19f57c225e686311145d7b28

Tweak configuration for Monti Sibillini National Park maps

view details

push time in 4 days

created tagMONEI/Shopify-api-node

tag3.2.1

Official Node Shopify connector sponsored by MONEI.net

created time in 5 days

push eventMONEI/Shopify-api-node

Luigi Pinca

commit sha f91e090c57b08008c3ecf53718c130111daf5aa3

[dist] 3.2.1

view details

push time in 5 days

push eventMONEI/Shopify-api-node

Luigi Pinca

commit sha 5644a78046cfb8b91afb16f173fa19116609819b

[ts] Fix event parameter type Fixes: https://github.com/MONEI/Shopify-api-node/issues/346

view details

push time in 5 days

issue closedMONEI/Shopify-api-node

Argument of type 'callGraphqlLimits' is not assignable to parameter of type 'callLimits'

// disclaimer: I'm new to typescript

While implementing

this.shopify.on('callGraphqlLimits', async (limits: Shopify.ICallLimits) => {
  this.graphqlLimitsCheck(limits)
})

I'm getting TS2345: Argument of type '"callGraphqlLimits"' is not assignable to parameter of type '"callLimits"'

error

Is it just a matter of adding `.on('callGraphqlLimits') definition? Let me know if that's the case and I'll be happy to submit a PR for it.

closed time in 5 days

mjsilva

issue commentMONEI/Shopify-api-node

Get all orders (status=any)

See https://shopify.dev/docs/admin-api/rest/reference/orders/order#index-2020-01.

const orders = await shopify.order.list({ status: 'any' });

should work.

rounsmith

comment created time in 5 days

issue commentMONEI/Shopify-api-node

Syntax error after upgrading to 3.2.0 Unexpected token *

Version 3.x requires Node.js >= 10.

pklitscher

comment created time in 5 days

PR opened nodejs/nodejs.org

disable the banner

~20 days passed since the security releases. I'm fine with closing/waiting if we want to keep the banner visible for some more time.

+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchlpinca/new.nodejs.org

branch : disable/banner

created branch time in 5 days

push eventlpinca/new.nodejs.org

Chakravarthy S M

commit sha 652457636dee48074aac6f8886e7e006fd78d2c5

Update v10.10.0.md (#1799) fix typo

view details

Maledong

commit sha ae5fdae17e3e480f96f39c8208ca964dc3e53772

zh-CN:Add missing Chinese part in 'Diagnostics' (#1800) Compared with what we have now in 'working-groups.md', add the missing Chinese translations for 'Diagnostics' pharagraph.`

view details

Andy Trevorah

commit sha 185e15497e543717eed1661104672d19082b3b49

Update profiling crypto example (#1796) The digest parameter is required as of v6.0.0

view details

Vse Mozhet Byt

commit sha b94a716e221e18a023861bfd3b53109fab42ee8a

uk:Add "dependencies" field translation to the locale (#1801) Make up for the missing translation for the title 'dependencies' in UK.

view details

Myles Borins

commit sha 37e1c7d45eb868dec5fbe39a8d6937e5ee99f3e0

blog: add release post for v8.12.0 Refs: https://github.com/nodejs/node/pull/21593

view details

Jakob Krigovsky

commit sha 68939e09ad1c98926ab892fcd864ccd036a37ca5

Update links to official Node.js Docker image (#1699) I wasn’t entirely sure whether to update the links to [hub.docker.com](https://hub.docker.com/_/node/) or [store.docker.com](https://store.docker.com/images/node). However, given the promotion on hub.docker.com (“node is now available in the Docker Store, the new place to discover public Docker content”), the Docker Store seems to be the way to go.

view details

Frederic Hemberger

commit sha 32d79f961c5332e04604779df73a00e7ff4358d3

npm audit: Update metalsmith-permalinks to v1.0.0 (#1807) SEMVER WARNING: Recommended action is a potentially breaking change ┌───────────────┬──────────────────────────────────────────────────────────────┐ │ Low │ Regular Expression Denial of Service │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Package │ debug │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Dependency of │ metalsmith-permalinks │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Path │ metalsmith-permalinks > debug │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ More info │ https://nodesecurity.io/advisories/534 │ └───────────────┴──────────────────────────────────────────────────────────────┘

view details

ZYSzys

commit sha 9908aa93fc9ac1390ffa375578818dc343992417

zh-CN:Fix by adding index positions to some titles When users click, 'timers' and 'poll' should index to the suitable position.

view details

Rich Trott

commit sha e354cffff775e8ca35083be843e314f31ad60182

update metalsmith-markdown This eliminates a warning from `npm audit`. It's a semver major update, so we should look at output carefully, but all tests pass, so that's something...

view details

Frederic Hemberger

commit sha 3f3d9d50c065c9e05ff12a0ee3b75b0def937a04

Fix rendering issues in #1810

view details

Maledong

commit sha 9f95cf9b30cdfc2d832763dd47254eca5798a4f4

doc: Fix 'pbkdf2Sync' encoding problem (#1805) Ref: https://github.com/nodejs/nodejs.org/pull/1796. Since the '/newUser' request is encoded by 'sha512', and your corresponding '/auth' must also use 'sha512' as the digest encoding as well.

view details

Vse Mozhet Byt

commit sha fe6fae67b3cfd611b6b34da1d36ed30b200592e3

doc: update info about Node.js installation on Android via Termux As of https://github.com/termux/termux-packages/commit/5b08d52e1922e463148c2d25c2b6e760031554b9 `nodejs-current` package is disabled and `nodejs` package, previously corresponded to the LTS, corresponds to the last available release. As of https://github.com/termux/termux-packages/commit/9612920ab521d9a8b6a0fe51785041b13d7e9db2 `nodejs` package is built with `system-icu` support. Refs: https://github.com/termux/termux-packages/issues/2210

view details

Maledong

commit sha c657e2318dd66efbfb89235dc359cb46e9d2189d

zh-CN:Update the 'package-manager.md' (#1814) Due to https://github.com/nodejs/nodejs.org/pull/1812, the corresponding Chinese part should be also changed.

view details

Michaël Zasso

commit sha d26abe8b9ee3b8bb24a15cbd572c9a127ce50ec6

Blog: v10.11.0 release post (#1816) Refs: https://github.com/nodejs/node/pull/22932

view details

Maledong

commit sha 763d937c38b2fd6ad26d15da35ced97cee235037

Fix:download should ignore 'Linux PPC BE 64-bit' (#1819) When Nodejs's version >= 8.x, 'Linux PPC BE 64-bit' should be ignored. (Ref:https://github.com/nodejs/nodejs.org/issues/1815).

view details

Patrick Boivin

commit sha 23b501e77bf80eee630ca5ea0b3275996f9141ef

Fix HTML rendering on Docs index page

view details

Rich Trott

commit sha 4c297ef7fdbbc0ac80454553b7d24f9f904c6de6

remove banner that has been up for more than 5 weeks

view details

Kaiyu Hsu

commit sha 47b443f0e07783ab55ca3cef2cf9881c1a4a1bf5

Update code-and-learn with upcoming events (#1824)

view details

ZYSzys

commit sha 6a4d906d676589d42bcf8a990bbe142435232da4

docs: Translate `includes` in suitable languages Translate `includes` into Simplified Chinese, Traditional Chinese, Japanese and Korean

view details

MaleDong

commit sha fec815e9e1f225126b4f3135b481f6566eb3d722

Add missing code-and-learn with upcoming events Ref: https://github.com/nodejs/nodejs.org/pull/1824.

view details

push time in 5 days

push eventlpinca/node

Harshitha KP

commit sha 2d3717ad847665de333c85e5239ad4e6a4c0eb95

worker: emit runtime error on loop creation failure Instead of hard asserting throw a runtime error, that is more consumable. Fixes: https://github.com/nodejs/node/issues/31614 PR-URL: https://github.com/nodejs/node/pull/31621 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 1c4e984ed970612f129db2ba6f684311418ed3a2

test: remove common.PORT from test-net-write-callbacks.js Switch test-net-write-callbacks.js from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31839 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Rich Trott

commit sha cdac18519fd14df9ece958cf8e29b846f512656e

test: remove flaky designation for test-net-connect-options-port Closes: https://github.com/nodejs/node/issues/23207 PR-URL: https://github.com/nodejs/node/pull/31841 Fixes: https://github.com/nodejs/node/issues/23207 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha 82afd85a31ab7c8f931f0bb0b23e76570aceb46d

tools: update lint-md task to lint for possessives of Node.js Add a markdown lint rule to prohibit "Node.js'" and "Node.js's". Instead, of "Node.js' module system", use "the Node.js module system". Refs: https://github.com/nodejs/node/pull/31748#issuecomment-585087745 PR-URL: https://github.com/nodejs/node/pull/31862 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Shelley Vohr

commit sha ae41049a760d55b5dcc20e137a7454e7c70415c4

doc: add note about ssh key to releases PR-URL: https://github.com/nodejs/node/pull/31856 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Michaël Zasso

commit sha cf0096104752607c7374a7f7297139e60b03c59d

tools: sync gyp code base with node-gyp repo PR-URL: https://github.com/nodejs/node/pull/30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 2f97e973ff540d2ae7de77482c631c06cc99c313

meta: move julianduque to emeritus julianduque confirmed in email that they can be moved to emeritus. PR-URL: https://github.com/nodejs/node/pull/31863 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Vse Mozhet Byt

commit sha 2f23918ca5090417ad0e06be6ecce63553f17985

doc: update stream.pipeline() signature The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: https://github.com/nodejs/node/pull/31789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Robert Nagy

commit sha 21bd6679ce150e193cacd4b1b6585928224f255a

stream: fix finished typo https://github.com/nodejs/node/pull/31509 introduced a slight typo. Fortunately this typo does not have big impact due to `isWritableFinished()`. Fixes: https://github.com/nodejs/node/pull/31509#discussion_r381809355 PR-URL: https://github.com/nodejs/node/pull/31881 Fixes: https://github.com/nodejs/node/issues/31509 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Tobias Nießen

commit sha 0e63a079e8f535e1d4f0398400c534b0b5772fa5

crypto: fix ieee-p1363 for createVerify Fixes: https://github.com/nodejs/node/issues/31866 PR-URL: https://github.com/nodejs/node/pull/31876 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Tobias Nießen

commit sha fa1fc6bf9f257f7365454dc7a28bb4cd4385919f

doc: fix anchor for ERR_TLS_INVALID_CONTEXT PR-URL: https://github.com/nodejs/node/pull/31915 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

simon

commit sha 341c06f0889e5295d7a7a34c3e38296bd2c4ac18

tls: expose SSL_export_keying_material Fixes: https://github.com/nodejs/node/issues/31802 PR-URL: https://github.com/nodejs/node/pull/31814 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Ben Noordhuis

commit sha 793cfe54cd26e0eb881eec895df41da62a3049ed

doc,crypto: re-document oaepLabel option Erroneously removed in https://github.com/nodejs/node/pull/29516. Fixes: https://github.com/nodejs/node/issues/31810 Refs: https://github.com/nodejs/node/pull/29516 PR-URL: https://github.com/nodejs/node/pull/31825 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

push time in 5 days

pull request commentnodejs/node

http,stream: make virtual methods throw an error

@nodejs/streams

lpinca

comment created time in 6 days

PR opened nodejs/node

http,stream: make virtual methods throw an error

Make virtual methods throw an ERR_METHOD_NOT_IMPLEMENTED error instead of emitting it.

The error is not recoverable and the only way to handle it is to override the method.

Refs: https://github.com/nodejs/node/pull/31818#pullrequestreview-359403469

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+63 -46

0 comment

10 changed files

pr created time in 6 days

create barnchlpinca/node

branch : throw/err-method-not-implemented

created branch time in 6 days

PR closed nodejs/node

doc: update stream.pipeline() signature doc stream
Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

The ...transforms parameter seems optional.

Refs: https://github.com/nodejs/node/blob/087583741716969edf12874d4f1f1774de581f50/lib/internal/streams/pipeline.js#L130-L132

Refs: https://github.com/nodejs/node/blob/e559842188f541b884abff2ffad4d2d3e1b841a6/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators (see the last example)

+1 -1

5 comments

1 changed file

vsemozhetbyt

pr closed time in 6 days

pull request commentnodejs/node

doc: update stream.pipeline() signature

Landed in 2f23918ca509.

vsemozhetbyt

comment created time in 6 days

push eventnodejs/node

Vse Mozhet Byt

commit sha 2f23918ca5090417ad0e06be6ecce63553f17985

doc: update stream.pipeline() signature The `...transforms` parameter is optional. Refs: https://github.com/nodejs/node/blob/0875837417/lib/internal/streams/pipeline.js#L130-L132 Refs: https://github.com/nodejs/node/blob/e559842188/doc/api/stream.md#streams-compatibility-with-async-generators-and-async-iterators PR-URL: https://github.com/nodejs/node/pull/31789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 6 days

issue closedwebsockets/ws

Unclear how to share port with http and ws protocols

I have this code:

import * as  WS from 'ws';
import * as express from 'express';

const app = express();
app.listen(3017);

const wss = new WS.Server({
  port: 3017
});

wss.on('connection', w => {
  
  const c = new WS('ws://localhost:3016/nodejs-ws');
  w.pipe(c);
  c.pipe(w);
  
});

we will get a port conflict - is there some place in the docs that mentions how to reuse the port? I think with Socket.io they do something like this:

const app = express();
app.listen(3017);
const wss = new WS.Server(app);

can this be documented/implemented? I am also curious how it works (how it's implemented).

closed time in 7 days

ORESoftware

issue closedwebsockets/ws

How to proxy websocket connection

I want to be able to proxy a websocket connection from one server to another:

import * as  WS from 'ws';
const wss = new WS.Server({
  port: 3017
});

wss.on('connection', w => {
  
  const c = new WS('ws://localhost:3016/nodejs-ws');
  w.pipe(c);
  c.pipe(w);
  
});

I tried it - and there are no pipe methods on the connections. is there a way to do this? Can it be documented? Here is my attempt?

wss.on('connection', w => {
  
  const c = new WS('ws://localhost:3016/nodejs-ws');
  
   w.on('message', data => {
    c.send(data);
   });

   c.on('message', data => {
    w.send(data);
   });
  
});

is that about right?

https://stackoverflow.com/questions/60328836/how-to-proxy-a-websocket-connection

closed time in 7 days

ORESoftware

issue commentwebsockets/ws

How to proxy websocket connection

Btw your example is not exactly proxying. A proper proxy will get data as is from the source and pass it to the destination and the other way round without parsing the incoming WebSocket frames and rebuilding them.

Check https://github.com/http-party/node-http-proxy or https://github.com/nxtedition/node-http2-proxy for a reference implementation.

ORESoftware

comment created time in 7 days

issue commentwebsockets/ws

Unclear how to share port with http and ws protocols

https://github.com/websockets/ws#external-https-server

ORESoftware

comment created time in 7 days

issue commentwebsockets/ws

How to proxy websocket connection

https://github.com/websockets/ws#use-the-nodejs-streams-api

ORESoftware

comment created time in 7 days

pull request commentnodejs/node

doc: prevent tables from shrinking page

@nodejs/website

davidgilbertson

comment created time in 8 days

issue commentnodejs/node

Recent behavior change of buffered write callbacks

https://github.com/nodejs/node/pull/30596 did not land yet. The backport PR is https://github.com/nodejs/node/pull/31179.

lpinca

comment created time in 8 days

push eventpnmsib/qwc2-demo-app

lpinca

commit sha afae36516b6b82f76636a7c6a96b6ce1dee0bc62

Tweak configuration for Monti Sibillini National Park maps

view details

push time in 8 days

push eventpnmsib/qwc2-demo-app

Sandro Mani

commit sha bef6848387d797d9d97cce3c79718947011ee19b

Update submodule

view details

Sandro Mani

commit sha c5f671e638fde019453077242835ee9db6a2b5a3

Update submodule

view details

push time in 8 days

push eventpnmsib/qwc2-demo-app

Sandro Mani

commit sha bef6848387d797d9d97cce3c79718947011ee19b

Update submodule

view details

Sandro Mani

commit sha c5f671e638fde019453077242835ee9db6a2b5a3

Update submodule

view details

lpinca

commit sha 4eea01f071d1a339fa7029b4fa84ed8a1079b79a

Tweak configuration for Monti Sibillini National Park maps

view details

push time in 8 days

issue closedprimus/metroplex

An in-range update of ws is breaking the build 🚨

The devDependency ws was updated from 7.0.0 to 7.0.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ws is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

<details> <summary>Status Details</summary>

  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details). </details>

<details> <summary>Commits</summary> <p>The new version differs by 9 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/websockets/ws/commit/38d3bf24a0caa2f504361926582ed679a22e08f8"><code>38d3bf2</code></a> <code>[dist] 7.0.1</code></li> <li><a href="https://urls.greenkeeper.io/websockets/ws/commit/a0af76440eb11c7a567581141554585e3a6e7409"><code>a0af764</code></a> <code>[test] Use the correct value for the Content-Length header</code></li> <li><a href="https://urls.greenkeeper.io/websockets/ws/commit/b08617910daa3dfcd7fd79cdb004ef383d9a35a1"><code>b086179</code></a> <code>[fix] Allow to disable sending the SNI extension (#1587)</code></li> <li><a href="https://urls.greenkeeper.io/websockets/ws/commit/e9e8ba53bc259bf7e34195df05d348717c185542"><code>e9e8ba5</code></a> <code>[pkg] Update eslint-config-prettier to version 5.0.0 (#1588)</code></li> <li><a href="https://urls.greenkeeper.io/websockets/ws/commit/36ef7570786d423038627877034cb866da8f8901"><code>36ef757</code></a> <code>[doc] Add missing dependency in code snippet (#1581)</code></li> <li><a href="https://urls.greenkeeper.io/websockets/ws/commit/911bb6fb1145c9b09ae4b1cf4c993b3b8ce9e1cf"><code>911bb6f</code></a> <code>[minor] Fix typo in JSDoc comment (#1565)</code></li> <li><a href="https://urls.greenkeeper.io/websockets/ws/commit/8050d5f395146e060140defa2119132c9f0f3ba2"><code>8050d5f</code></a> <code>[lint] Enable quotes rule</code></li> <li><a href="https://urls.greenkeeper.io/websockets/ws/commit/995c527c87d0d4833d8093c18dcfa2e4a41d9582"><code>995c527</code></a> <code>[test] Enable --throw-deprecation</code></li> <li><a href="https://urls.greenkeeper.io/websockets/ws/commit/fbc077bddbe9ae9aff26f8a2ba20d0ababe93bfc"><code>fbc077b</code></a> <code>[test] Do not use the deprecated <code>outgoingMessage._headers</code> property</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/websockets/ws/compare/092a822a41eb22f6d6745c18bc29b9c40715680f...38d3bf24a0caa2f504361926582ed679a22e08f8">full diff</a></p> </details>

<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper Bot :palm_tree:

closed time in 8 days

greenkeeper[bot]

push eventprimus/primacron

Luigi Pinca

commit sha d2faac8e5644ea2ddd46ba197bbdb7216d02768b

[pkg] Update ws to version 7.2.1 (#70)

view details

push time in 8 days

PR merged primus/primacron

Update ws to version 7.2.1

Closes #67

+1 -1

0 comment

1 changed file

lpinca

pr closed time in 8 days

PR closed primus/primacron

Update ws to the latest version 🚀 greenkeeper

The dependency ws was updated from 7.1.2 to 7.2.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: lpinca License: MIT

Find out more about this release.


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+1 -1

1 comment

1 changed file

greenkeeper[bot]

pr closed time in 8 days

PR opened primus/primacron

Update ws to version 7.2.1

Closes #67

+1 -1

0 comment

1 changed file

pr created time in 8 days

push eventprimus/primacron

greenkeeper[bot]

commit sha 53be2da2de0614677cac11764557ce9e935812d6

[pkg] Update ioredis to version 4.16.0 (#69)

view details

push time in 8 days

PR merged primus/primacron

Update ioredis to the latest version 🚀 greenkeeper

The devDependency ioredis was updated from 4.14.4 to 4.16.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: luin License: MIT

<details> <summary>Release Notes for v4.16.0</summary>

<h1><a href="https://urls.greenkeeper.io/luin/ioredis/compare/v4.15.1...v4.16.0">4.16.0</a> (2020-02-19)</h1> <h3>Features</h3> <ul> <li>ability force custom scripts to be readOnly and execute on slaves (<a href="https://urls.greenkeeper.io/luin/ioredis/issues/1057" data-hovercard-type="pull_request" data-hovercard-url="/luin/ioredis/pull/1057/hovercard">#1057</a>) (<a href="https://urls.greenkeeper.io/luin/ioredis/commit/a24c3abcf4013e74e25424d2f6b91a2ae0de12b5">a24c3ab</a>)</li> </ul> </details>

<details> <summary>Commits</summary> <p>The new version differs by 12 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/f4fe62f231b33b28fda1cb28b4f5690655007b80"><code>f4fe62f</code></a> <code>chore(release): 4.16.0 [skip ci]</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/a24c3abcf4013e74e25424d2f6b91a2ae0de12b5"><code>a24c3ab</code></a> <code>feat: ability force custom scripts to be readOnly and execute on slaves (#1057)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/e5844734d671a1e35bbb742f9105fc811d61e066"><code>e584473</code></a> <code>docs(README): Formatted Cluster docs (#1063)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/4a13a1b7140156b7514fe88f7b102c69a3ad0ed4"><code>4a13a1b</code></a> <code>docs: add more detail to the basic example (#1043)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/1d06cf4bd968fd9762b87d7cd3d756c396158ce0"><code>1d06cf4</code></a> <code>chore(release): 4.15.1 [skip ci]</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/d79a8ef40f5670af6962b598752dc5a7aa96722c"><code>d79a8ef</code></a> <code>fix: ignore empty hosts returned by CLUSTER SLOTS (#1025)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/04cad7fbf2db5e14a478e2eb1dc825346abe41dd"><code>04cad7f</code></a> <code>fix: prevent exception when send custom command</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/0e7090aac90a277f7d0ad42337292f3a16290064"><code>0e7090a</code></a> <code>docs(README): fix typo (#1032)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/0db527fd4266913583bce55245940e825dba1a46"><code>0db527f</code></a> <code>chore(release): 4.15.0 [skip ci]</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/51b14786eef4c627c178de4967434e8d4a51ebe0"><code>51b1478</code></a> <code>feat: support multiple fields for hset</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/06b28e1c0a7d9ce163037d4c569b6b94970d99d5"><code>06b28e1</code></a> <code>Allow sentinelRetryStrategy to be disabled</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/416591cfc787f2e8eb942495b73b0ef4c9514e59"><code>416591c</code></a> <code>chore: remove format-check on travis</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/luin/ioredis/compare/9bda5931334d77e91d6b09f5a6223bdfadd7220f...f4fe62f231b33b28fda1cb28b4f5690655007b80">full diff</a></p> </details>


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+1 -1

0 comment

1 changed file

greenkeeper[bot]

pr closed time in 8 days

push eventprimus/metroplex

greenkeeper[bot]

commit sha 4585ffe77581b8c7e2057a7938fbdf399a357624

[pkg] Update ioredis to version 4.16.0 (#87)

view details

push time in 8 days

PR merged primus/metroplex

Update ioredis to the latest version 🚀 greenkeeper

The dependency ioredis was updated from 4.14.4 to 4.16.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: luin License: MIT

<details> <summary>Release Notes for v4.16.0</summary>

<h1><a href="https://urls.greenkeeper.io/luin/ioredis/compare/v4.15.1...v4.16.0">4.16.0</a> (2020-02-19)</h1> <h3>Features</h3> <ul> <li>ability force custom scripts to be readOnly and execute on slaves (<a href="https://urls.greenkeeper.io/luin/ioredis/issues/1057" data-hovercard-type="pull_request" data-hovercard-url="/luin/ioredis/pull/1057/hovercard">#1057</a>) (<a href="https://urls.greenkeeper.io/luin/ioredis/commit/a24c3abcf4013e74e25424d2f6b91a2ae0de12b5">a24c3ab</a>)</li> </ul> </details>

<details> <summary>Commits</summary> <p>The new version differs by 12 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/f4fe62f231b33b28fda1cb28b4f5690655007b80"><code>f4fe62f</code></a> <code>chore(release): 4.16.0 [skip ci]</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/a24c3abcf4013e74e25424d2f6b91a2ae0de12b5"><code>a24c3ab</code></a> <code>feat: ability force custom scripts to be readOnly and execute on slaves (#1057)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/e5844734d671a1e35bbb742f9105fc811d61e066"><code>e584473</code></a> <code>docs(README): Formatted Cluster docs (#1063)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/4a13a1b7140156b7514fe88f7b102c69a3ad0ed4"><code>4a13a1b</code></a> <code>docs: add more detail to the basic example (#1043)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/1d06cf4bd968fd9762b87d7cd3d756c396158ce0"><code>1d06cf4</code></a> <code>chore(release): 4.15.1 [skip ci]</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/d79a8ef40f5670af6962b598752dc5a7aa96722c"><code>d79a8ef</code></a> <code>fix: ignore empty hosts returned by CLUSTER SLOTS (#1025)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/04cad7fbf2db5e14a478e2eb1dc825346abe41dd"><code>04cad7f</code></a> <code>fix: prevent exception when send custom command</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/0e7090aac90a277f7d0ad42337292f3a16290064"><code>0e7090a</code></a> <code>docs(README): fix typo (#1032)</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/0db527fd4266913583bce55245940e825dba1a46"><code>0db527f</code></a> <code>chore(release): 4.15.0 [skip ci]</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/51b14786eef4c627c178de4967434e8d4a51ebe0"><code>51b1478</code></a> <code>feat: support multiple fields for hset</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/06b28e1c0a7d9ce163037d4c569b6b94970d99d5"><code>06b28e1</code></a> <code>Allow sentinelRetryStrategy to be disabled</code></li> <li><a href="https://urls.greenkeeper.io/luin/ioredis/commit/416591cfc787f2e8eb942495b73b0ef4c9514e59"><code>416591c</code></a> <code>chore: remove format-check on travis</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/luin/ioredis/compare/9bda5931334d77e91d6b09f5a6223bdfadd7220f...f4fe62f231b33b28fda1cb28b4f5690655007b80">full diff</a></p> </details>


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+1 -1

0 comment

1 changed file

greenkeeper[bot]

pr closed time in 8 days

PR closed MONEI/Shopify-api-node

Pr/1
+2 -1

1 comment

1 changed file

grepx

pr closed time in 9 days

pull request commentMONEI/Shopify-api-node

Pr/1

The proposed changes cannot be applied. See https://github.com/MONEI/Shopify-api-node/blob/932ca09b05b416e391b060809cd4b94174c3d339/index.d.ts#L2090-L2097

grepx

comment created time in 9 days

delete branch MONEI/Shopify-api-node

delete branch : pr/1

delete time in 9 days

create barnchMONEI/Shopify-api-node

branch : pr/1

created branch time in 9 days

delete branch MONEI/Shopify-api-node

delete branch : pr/1

delete time in 9 days

create barnchMONEI/Shopify-api-node

branch : pr/1

created branch time in 9 days

PR opened nodejs/node

doc: remove repetition

Merge two similar sentences into one.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+5 -5

0 comment

1 changed file

pr created time in 9 days

create barnchlpinca/node

branch : remove/repetition

created branch time in 9 days

push eventlpinca/node

Anna Henningsen

commit sha a7c523e26df468782691c7e16b2e033c6256beb3

src: prefer 3-argument Array::New() This is nicer, because: 1. It reduces overall code size, 2. It’s faster, because `Object::Set()` calls are relatively slow, and 3. It helps avoid invalid `.Check()`/`.FromJust()` calls. PR-URL: https://github.com/nodejs/node/pull/31775 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Robert Nagy

commit sha c776a37791007e0d570355b731647e58ea5885be

http: end with data can cause write after end Calling end() with data while ending should trigger a write after end error. PR-URL: https://github.com/nodejs/node/pull/28666 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 568fdfb1658bfcaa7832759e03661f2cb958c155

fs: fix WriteStream autoClose order WriteStream autoClose was implemented by manually calling .destroy() instead of using autoDestroy and callback. This caused some invariants related to order of events to be broken. Fixes: https://github.com/nodejs/node/issues/31776 PR-URL: https://github.com/nodejs/node/pull/31790 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Samuel Attard

commit sha 093639614fa1cea7a1bc3493d28119a924c97bc9

doc: claim ABI version 82 for Electron 10 PR-URL: https://github.com/nodejs/node/pull/31778 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 26e49d83323c78e89b2664b6eeaee90757d52868

worker: unroll file extension regexp Refs: https://github.com/nodejs/node/pull/31662#discussion_r377016190 PR-URL: https://github.com/nodejs/node/pull/31779 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Jeff

commit sha e028ea0291b845e4bec3c7cff7319a027b8c815e

doc: fix typos in doc/api/https.md PR-URL: https://github.com/nodejs/node/pull/31793 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Jeremiah Senkpiel

commit sha 4d6c861800cc6ac1dc6a0fd9d3a8b0053baec62a

doc: move @Fishrock123 to a previous releaser I have not done a release in well over a year, maybe even two. I also don't really plan to do more, as Node.js releases are very tedious. PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 928c210a611fb6b4575843708e7cb921f311ebde

doc: move @Fishrock123 to TSC Emeriti It was a good run. Almost 5 years. I haven't really been involved in the last 3+? months though, so it's time I call it and 'retire'. I think it is unlikely that I'll be on the TSC again, as node is unfortunately becoming increasingly disinteresting (& frustrating) to me. (So long and thanks for all the fish!) PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 30e6049c75590dec8d5edbf033edbc20e79efcb7

doc: pronouns for @Fishrock123 might as well while I'm at it feels a bit weird being the first person on this list with '/they' but I guess someone's gota do it PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Gireesh Punathil

commit sha 4c746a6cfda980c1cd0de6246781c0083d9e416c

doc: move gireeshpunathil to TSC emeritus PR-URL: https://github.com/nodejs/node/pull/31770 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

James M Snell

commit sha 5bef2ccf20cceda7975f8bce860e0f60595482fc

test: add known issue test for sync writable callback If the write callbacks are invoked synchronously with an error, onwriteError would cause the error event to be emitted synchronously, making it impossible to attach an error handler after the call that triggered it. PR-URL: https://github.com/nodejs/node/pull/31756 Refs: https://github.com/nodejs/quic/commit/b0d469c69c49c9186c1a581a7cebce4c5d398947 Refs: https://github.com/nodejs/quic/pull/341 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha 85c6fcd1cd11ec6ee22891e48a67cc97f60880e8

stream: avoid writing to writable A remainder from a previous refactoring. Refs: https://github.com/nodejs/node/pull/31197 PR-URL: https://github.com/nodejs/node/pull/31805 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 99428e0858bb3cce820190770ca8217460d95c80

doc: reword possessive form of Node.js in debugger.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha d40c648e884bd64028fa0a67122a0af87c60f467

doc: reword possessive form of Node.js in process.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha d25fcb0c201286d18c07653347258ce02951ddf8

doc: reword possessive form of Node.js in http.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha eb0ade10a7af855ecdaa822dea028d661664cd43

doc: reword possessive form of Node.js in adding-new-napi-api.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha fab3eff2e53eb9bfbb890e5ac45523ae68ae95e5

src: inform callback scopes about exceptions in HTTP parser Refs: https://github.com/nodejs/node/commit/4aca277f16b8649b5fc21d41f340fad0a47c2e61 Refs: https://github.com/nodejs/node/pull/30236 Fixes: https://github.com/nodejs/node/issues/31796 PR-URL: https://github.com/nodejs/node/pull/31801 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha 794bfacb26c4059c2eab7efb475489b7010054c3

test: remove common.PORT from test-net-timeout Switch test-net-timeout from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 76fd17a7dff6b89b8851044b17125a88a3043b4e

test: remove common.PORT from test-net-throttle Switch test-net-throttle from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha a092886b1d29d17c94683348430e062cf7ae2fc9

test: remove common.PORT from test-tls-server-large-request Switch test-tls-server-large-request from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 9 days

issue closedMONEI/Shopify-api-node

Lack of support for new pagination in TS file

it would be good to have official TS support for

      if (res.headers.link) {
        const link = parseLinkHeader(res.headers.link);

        if (link.next) {
          Object.defineProperties(data, {
            nextPageParameters: { value: link.next.query }
          });
        }

        if (link.previous) {
          Object.defineProperties(data, {
            previousPageParameters: { value: link.previous.query }
          });
        }
      }

cause now I'm forced to use e.g. orders['nextPageParameters'] or Object.getOwnPropertyDescriptor(orders, 'nextPageParameters')

closed time in 9 days

gbar

issue commentMONEI/Shopify-api-node

Lack of support for new pagination in TS file

Already discussed in https://github.com/MONEI/Shopify-api-node/issues/288#issuecomment-558715800.

gbar

comment created time in 9 days

push eventprimus/eventemitter3

greenkeeper[bot]

commit sha 7a002e8cd214d835c51a1335205d57861a070338

[pkg] Update uglify-js to version 3.8.0 (#215)

view details

push time in 9 days

PR merged primus/eventemitter3

Update uglify-js to the latest version 🚀 greenkeeper

The devDependency uglify-js was updated from 3.7.7 to 3.8.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: alexlamsl License: BSD-2-Clause

<details> <summary>Release Notes for v3.8.0</summary>

<p> </p> </details>

<details> <summary>Commits</summary> <p>The new version differs by 23 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/d13b71297ed2f118b0557bb9b4cb7b1702abb746"><code>d13b712</code></a> <code>v3.8.0</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/457f958af37293f90a1cca4476a6e0ae2a7626f8"><code>457f958</code></a> <code>improve <code>--reduce-test</code> (#3727)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/53517db3e40e9a2b2a6cc64b0dd7dcef0305ec1e"><code>53517db</code></a> <code>speed up <code>--reduce-test</code> (#3726)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/c13caf487614d15cdc7d984fc5b4c558e728f0cf"><code>c13caf4</code></a> <code>speed up <code>--reduce-test</code> via result caching (#3725)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/fbfa6178a6081e03c3edcbec706b2c6e103f9ba7"><code>fbfa617</code></a> <code>improve <code>--reduce-test</code> (#3722)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/5315dd95b0402b656d07660b705b27a0404183d4"><code>5315dd9</code></a> <code>minor cleanup (#3723)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/31a7bf2a22f7e9cfa3ec309cdff626a2ea228aab"><code>31a7bf2</code></a> <code>Updated "Output options" > "comments" in README.md (#3717)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/f0a29902acc24217881529449c7f9b8815896297"><code>f0a2990</code></a> <code>enhance <code>properties</code> (#3721)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/0d820e4c0a7a1b1eeee25fb632b9496a9780b28a"><code>0d820e4</code></a> <code>workaround RegExp formatting bugs (#3720)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/f01f580d6c2312ba556a37144f6fef227bd89f77"><code>f01f580</code></a> <code>improve <code>--reduce-test</code> (#3719)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/c01ff7628868a14338aa1193da2ada011c7ad832"><code>c01ff76</code></a> <code>improve code reuse (#3718)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/83a42716c37eb644c490454d7f2119b1fe8158b1"><code>83a4271</code></a> <code>fix corner case in <code>unused</code> (#3716)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/2557148bba9e380004c69551aa07f2f424d65159"><code>2557148</code></a> <code>increase mocha <code>--reduce-test</code> timeout (#3715)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/dd22eda888380be41f47bba1f6740b283fb099cc"><code>dd22eda</code></a> <code>enhance <code>evaluate</code> (#3714)</code></li> <li><a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/commit/f4c77886e748ff5945b73f2584916ec3b760ee98"><code>f4c7788</code></a> <code>add test for <code>--reduce-test</code> (#3712)</code></li> </ul> <p>There are 23 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/mishoo/UglifyJS2/compare/36b2d35bf35618042aeba57fc7ef37a39dadf295...d13b71297ed2f118b0557bb9b4cb7b1702abb746">full diff</a></p> </details>


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+1 -1

0 comment

1 changed file

greenkeeper[bot]

pr closed time in 9 days

Pull request review commentnodejs/node

stream: throw invalid argument errors

 const unzips = [ ];  nonStringInputs.forEach(common.mustCall((input) => {-  // zlib.gunzip should not throw an error when called with bad input.-  zlib.gunzip(input, (err, buffer) => {-    // zlib.gunzip should pass the error to the callback.-    assert.ok(err);+  assert.throws(() => {+    zlib.gunzip(input);+  }, {+    name: 'TypeError'
    name: 'TypeError',
    code: 'ERR_INVALID_ARG_TYPE'
ronag

comment created time in 10 days

Pull request review commentnodejs/node

stream: throw invalid argument errors

 'use strict';  const common = require('../common');+const assert = require('assert'); const { Gunzip } = require('zlib');  const gunzip = new Gunzip({ objectMode: true });-gunzip.write({}, common.expectsError({+gunzip.on('error', common.mustNotCall());+assert.throws(() => {+  gunzip.write({});+}, {   name: 'TypeError'
  name: 'TypeError',
  code: 'ERR_INVALID_ARG_TYPE'
ronag

comment created time in 10 days

issue commentwebsockets/ws

How to authenticate a client via token using verifyClient?

You can't use POST, the handshake request must use the GET method as per spec.

subwaystation

comment created time in 10 days

delete branch lpinca/qwc2

delete branch : fix/production-build

delete time in 10 days

pull request commentqgis/qwc2

Fix production build on Windows

PS C:\Users\luigi\test> cat .\test.bat
cmd /C "set NODE_ENV='production' && node ./test.js"
PS C:\Users\luigi\test> cat test.js
console.log(process.env.NODE_ENV);
console.log(process.env.NODE_ENV === 'production');
PS C:\Users\luigi\test> .\test.bat

C:\Users\luigi\test>cmd /C "set NODE_ENV='production' && node ./test.js"
'production'
false
PS C:\Users\luigi\test>
lpinca

comment created time in 10 days

PR opened qgis/qwc2

Fix production build on Windows

Remove the single quotes from the value of the NODE_ENV environment variable.

+2 -2

0 comment

1 changed file

pr created time in 10 days

create barnchlpinca/qwc2

branch : fix/production-build

created branch time in 10 days

fork lpinca/qwc2

QGIS Web Client 2 Components

fork in 10 days

push eventpnmsib/qwc2-demo-app

lpinca

commit sha ed54fb2075dee4602c6464339139969bf679c15d

Tweak configuration for Monti Sibillini National Park maps

view details

push time in 10 days

push eventpnmsib/qwc2-demo-app

lpinca

commit sha 1783c618892e96abc4babadc18a150f214924261

Tweak configuration for Monti Sibillini National Park maps

view details

push time in 10 days

push eventpnmsib/qwc2-demo-app

Sandro Mani

commit sha 61d2ca4250d0b1c3fa13ddcf7660925a61f8db61

Update submodule and documentation

view details

Sandro Mani

commit sha e8f57c755f503485f03cbe7da89f82e14d44af4c

Update submodule

view details

lpinca

commit sha b487b0a59a56e50b4bc6787e1f2dd833115086fc

Tweak configuration for Monti Sibillini National Park maps

view details

push time in 10 days

push eventpnmsib/qwc2-demo-app

Sandro Mani

commit sha 61d2ca4250d0b1c3fa13ddcf7660925a61f8db61

Update submodule and documentation

view details

Sandro Mani

commit sha e8f57c755f503485f03cbe7da89f82e14d44af4c

Update submodule

view details

push time in 10 days

Pull request review commentnodejs/node

stream: throw invalid argument errors

  const common = require('../common'); const stream = require('stream');+const assert = require('assert');  function testWriteType(val, objectMode, code) {   const writable = new stream.Writable({     objectMode,     write: () => {}   });-  if (!code) {-    writable.on('error', common.mustNotCall());-  } else {-    writable.on('error', common.expectsError({-      code: code,-    }));+  writable.on('error', common.mustNotCall());+  if (code) {

We should test that no error is thrown when code is falsy no?

ronag

comment created time in 11 days

Pull request review commentnodejs/node

stream: throw on logic errors

 Writable.prototype.write = function(chunk, encoding, cb) {       cb = nop;   } -  let err;   if (state.ending) {-    err = new ERR_STREAM_WRITE_AFTER_END();+    throw new ERR_STREAM_WRITE_AFTER_END();

That really makes things confusing. How about this. Throw on invalid argument errors and otherwise keep previous behavior?

Yes, that what I was trying to say in my previous comment.

ronag

comment created time in 11 days

Pull request review commentnodejs/node

stream: throw on logic errors

 Writable.prototype.write = function(chunk, encoding, cb) {       cb = nop;   } -  let err;   if (state.ending) {-    err = new ERR_STREAM_WRITE_AFTER_END();+    throw new ERR_STREAM_WRITE_AFTER_END();

Not sure, keep it as is to reduce the breaking change? Yes I also don't like to throw on some cases and not on others.

ronag

comment created time in 11 days

Pull request review commentnodejs/node

stream: throw on logic errors

 Writable.prototype.write = function(chunk, encoding, cb) {       cb = nop;   } -  let err;   if (state.ending) {-    err = new ERR_STREAM_WRITE_AFTER_END();+    throw new ERR_STREAM_WRITE_AFTER_END();

yes, but without knowing when end() is called the user needs to check state.ending before every write to ensure the error is not thrown no?

ronag

comment created time in 11 days

Pull request review commentnodejs/node

stream: throw on logic errors

 Writable.prototype.write = function(chunk, encoding, cb) {       chunk = Stream._uint8ArrayToBuffer(chunk);       encoding = 'buffer';     } else {-      err = new ERR_INVALID_ARG_TYPE(+      throw new ERR_INVALID_ARG_TYPE(

👍

ronag

comment created time in 11 days

Pull request review commentnodejs/node

stream: throw on logic errors

 Writable.prototype.write = function(chunk, encoding, cb) {       cb = nop;   } -  let err;   if (state.ending) {-    err = new ERR_STREAM_WRITE_AFTER_END();+    throw new ERR_STREAM_WRITE_AFTER_END();   } else if (state.destroyed) {-    err = new ERR_STREAM_DESTROYED('write');+    // TODO(ronag): Compat. Throwing here can break stuff.+    // throw new ERR_STREAM_DESTROYED('write');+    return false;   } else if (chunk === null) {-    err = new ERR_STREAM_NULL_VALUES();+    throw new ERR_STREAM_NULL_VALUES();

👍

ronag

comment created time in 11 days

more