release nextdns/nextdns

released time in 11 hours

release nextdns/nextdns

v1.33.1

released time in 12 hours

release nextdns/nextdns

v1.33.0

released time in 14 hours

startedCuberto/liquid-swipe

started time in 15 hours

issue commentCocoaLumberjack/CocoaLumberjack

写入本地的日志，时间少了4个小时

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

songhongkang

comment created time in a day

issue commentCocoaLumberjack/CocoaLumberjack

每天生成一份日志

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

xiejicangxjc

comment created time in a day

issue commentCocoaLumberjack/CocoaLumberjack

lipo failing during build process Xcode 12 for Mac M1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

pbmorton

comment created time in a day

issue commentCocoaLumberjack/CocoaLumberjack

crash [DDLogFileFormatterDefault formatLogMessage:] + 592

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

CorkiiOS

comment created time in a day

issue commentCocoaLumberjack/CocoaLumberjack

Module compiled with Swift 5.2.4 cannot be imported by the Swift 5.3.2 compiler

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

nitinkumardb

comment created time in a day

issue commentCocoaLumberjack/CocoaLumberjack

Tag [DDLogFileManagerDefault initWithLogsDirectory:defaultFileProtectionLevel:] with NS_DESIGNATED_INITIALIZER

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

leontiy

comment created time in a day

issue commentCocoaLumberjack/CocoaLumberjack

Crash DDLog.m line 839 - [DDLog lt_log:]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

andrey-filin-arlo

comment created time in a day

issue commentCocoaLumberjack/CocoaLumberjack

Issues when trying to update the library i am getting error the following error(old version 3.4.1 and try to update for 3.5.1 or above)

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

sunil28011

comment created time in a day

issue commentCocoaLumberjack/CocoaLumberjack

Possible crash in CocoaLumberjack 3.7.1?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

latenitefilms

comment created time in a day

issue commentCocoaLumberjack/CocoaLumberjack

Issues when trying to update the library i am getting error the following error(old version 3.4.1 and try to update for 3.5.1 or above)

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

sunil28011

comment created time in a day

startedGeorgeElsham/ShoppingListSwiftUIExample

started time in 2 days

startedadamfootdev/BottomSheet

started time in 3 days

startedpedrommcarrasco/Dex.prices

started time in 4 days

pull request commentCocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

@778477 Yea, we currently run the tests on the latest version available. But that's ok... 🙂

778477

comment created time in 4 days

push eventCocoaLumberjack/CocoaLumberjack

郭妙友

commit sha 51db3a567fefac8f818637b3439568740bc00c2a

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise a NSFileHandleOperationException

view details

郭妙友

commit sha da5a44acf20aa214f082a98e1648f41769893947

Modify: fix by CR

view details

Florian Friedrich

commit sha 238fed03adc108a8862249eff766786dc47c667d

Merge pull request #1228 from 778477/gmy/fix_crash Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

view details

push time in 4 days

PR merged CocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
[ ] I have added the required tests to prove the fix/feature I am adding
[ ] I have updated the documentation (if necessary)
[x] I have run the tests and they pass
[x] I have run the lint and it passes (pod lib lint)

Pull Request Description

i has a crash when fileHandle call synchronizeFile。

Application threw exception NSFileHandleOperationException: *** -[NSConcreteFileHandle synchronizeFile]:

add try-catch DDFileLogger lt_flush

+6 -1

2 commit in 778477/CocoaLumberjack/tree/gmy/fix_crash CocoaLumberjack/CocoaLumberjack/tree/master

4 comments

1 changed file

778477

pr closed time in 4 days

startedslsa-framework/slsa

started time in 4 days

pull request commentCocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

@ffried

Added lines #L1239 - L1242 were not covered by tests

maybe we need run unit tests use iOS 12 or some old version(< iOS 13)

778477

comment created time in 4 days

pull request commentCocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

<!-- 0 failure: 2 warning: Any changes to li..., The library files...

DangerID: danger-id-Danger; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Warnings</th> </tr> </thead> <tbody><tr> <td>:warning:</td> <td>Any changes to library code should be reflected in the CHANGELOG. Please consider adding a note there about your change.</td> </tr>

<tr> <td>:warning:</td> <td>The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.</td> </tr> </tbody> </table>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/swift">Danger Swift</a> against da5a44acf20aa214f082a98e1648f41769893947 </p>

778477

comment created time in 4 days

pull request commentCocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

Codecov Report

Merging #1228 (51db3a5) into master (e518eb6) will decrease coverage by 3.84%. The diff coverage is 80.00%.

:exclamation: Current head 51db3a5 differs from pull request most recent head da5a44a. Consider uploading reports for the commit da5a44a to get more accurate results

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
- Coverage   49.01%   45.16%   -3.85%     
==========================================
  Files          32       25       -7     
  Lines        4809     4322     -487     
==========================================
- Hits         2357     1952     -405     
+ Misses       2452     2370      -82

Impacted Files	Coverage Δ
Sources/CocoaLumberjack/DDFileLogger.m	`65.91% <80.00%> (+0.46%)`	:arrow_up:
Sources/CocoaLumberjack/DDOSLogger.m	`21.73% <0.00%> (-43.48%)`	:arrow_down:
Tests/CocoaLumberjackTests/DDFileLoggerTests.m	`94.94% <0.00%> (-0.17%)`	:arrow_down:
Sources/CocoaLumberjack/DDTTYLogger.m	`0.00% <0.00%> (ø)`
Sources/CocoaLumberjack/DDASLLogCapture.m	`0.00% <0.00%> (ø)`
...oaLumberjack/include/CocoaLumberjack/DDTTYLogger.h	`0.00% <0.00%> (ø)`
Sources/CocoaLumberjackSwift/DDLog+Combine.swift
Sources/CocoaLumberjack/CLI/CLIColor.m
.../CocoaLumberjackSwiftTests/DDLogCombineTests.swift
Sources/CocoaLumberjackSwift/CocoaLumberjack.swift
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e518eb6...da5a44a. Read the comment docs.

778477

comment created time in 4 days

pull request commentCocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

/run_checks

778477

comment created time in 4 days

Pull request review commentCocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

 - (void)flush {  - (void)lt_flush {     NSAssert([self isOnInternalLoggerQueue], @"flush should only be executed on internal queue.");-    if (@available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)) {-        __autoreleasing NSError *error;-        BOOL succeed = [_currentLogFileHandle synchronizeAndReturnError:&error];-        if (!succeed) {-            NSLogError(@"DDFileLogger: Failed to synchronize file: %@", error);+    @try {

done

778477

comment created time in 4 days

Pull request review commentCocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

 - (void)flush {  - (void)lt_flush {     NSAssert([self isOnInternalLoggerQueue], @"flush should only be executed on internal queue.");-    if (@available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)) {-        __autoreleasing NSError *error;-        BOOL succeed = [_currentLogFileHandle synchronizeAndReturnError:&error];-        if (!succeed) {-            NSLogError(@"DDFileLogger: Failed to synchronize file: %@", error);+    @try {

thanks for review！

Yes，you are right

778477

comment created time in 4 days

Pull request review commentCocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

 - (void)flush {  - (void)lt_flush {     NSAssert([self isOnInternalLoggerQueue], @"flush should only be executed on internal queue.");-    if (@available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)) {-        __autoreleasing NSError *error;-        BOOL succeed = [_currentLogFileHandle synchronizeAndReturnError:&error];-        if (!succeed) {-            NSLogError(@"DDFileLogger: Failed to synchronize file: %@", error);+    @try {

Can we put the @try into the else branch? It's only necessary if the error-returning API is not available.

if (@available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)) {
    __autoreleasing NSError *error;
    BOOL succeed = [_currentLogFileHandle synchronizeAndReturnError:&error];
    if (!succeed) {
        NSLogError(@"DDFileLogger: Failed to synchronize file: %@", error);
    }
} else {
    @try {
        [_currentLogFileHandle synchronizeFile];
    } @catch (NSException *exception) {
        NSLogError(@"DDFileLogger: Failed to synchronize file: %@", exception);
    }
}

778477

comment created time in 4 days

PR opened CocoaLumberjack/CocoaLumberjack

Fix: add try-catch fix System below iOS 13 synchronizeFile will raise…

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
[ ] I have added the required tests to prove the fix/feature I am adding
[ ] I have updated the documentation (if necessary)
[x] I have run the tests and they pass
[x] I have run the lint and it passes (pod lib lint)

Pull Request Description

i has a crash when fileHandle call synchronizeFile。

Application threw exception NSFileHandleOperationException: *** -[NSConcreteFileHandle synchronizeFile]:

add try-catch DDFileLogger lt_flush

+11 -7

1 commit in 778477/CocoaLumberjack/tree/gmy/fix_crash CocoaLumberjack/CocoaLumberjack/tree/master

0 comment

1 changed file

pr created time in 4 days

startedanimir/node-rate-limiter-flexible

started time in 4 days