profile
viewpoint
Lily Pace lilyfromseattle New York, New York lilyfromseattle.com Seattle native and recent New York transplant looking to continue my career in the NYC area.

catstavi/Wandr 3

rails app for choosing an adventure by photo

kdn251/practice-app 0

Practicing React

lilyfromseattle/Adventure-TBD 0

rails app for location-photo-adventures [placeholder name]

lilyfromseattle/antcm 0

America's Next Top Cat Model

PR opened artsy/palette

Adjust left/right padding on small buttons for mWeb (to match iOS styling)

[PURCHASE-1781]

The Small button size: I know we built all btns with extra padding on right/left, but it feels unresolved/buggy or something in these smaller screen sizes. Possible to consider eliminating this extra 20px of east-west padding?

https://files.slack.com/files-pri/T02531TU5-FTNEPUDFA/image.png

we adjusted the left/right padding for small buttons in palette for iOS with the new artwork page, so we should be able to change it on web too

Before: Screen Shot 2020-03-25 at 12 43 15 PM

After: Screen Shot 2020-03-25 at 12 43 23 PM

+1 -1

0 comment

1 changed file

pr created time in 3 days

create barnchlilyfromseattle/palette

branch : button-padding

created branch time in 3 days

PR opened artsy/palette

changed casing of fillrule and cliprule for no artowrk icon

changed casing of fillRule and clipRule for no artwork icon fromfill-ruleandclip-rule` to camel case to silence console errors

+2 -2

0 comment

1 changed file

pr created time in 4 days

create barnchlilyfromseattle/palette

branch : no-artwork-fix

created branch time in 4 days

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha 1437d880ce941c13d2a11e6931c23092230617f6

updated fixtue and imports

view details

push time in 5 days

PR opened artsy/reaction

Move AddressForm component out of the order app

[PURCHASE-1750]

We use the AddressForm component in a few places (notably in the bid flow, in the order app, and on the user settings page).

It's confusing that the component still lives under the Order app in reaction. We should move it to a shared location.

It now lives in Components

+25 -25

0 comment

16 changed files

pr created time in 5 days

create barnchlilyfromseattle/reaction

branch : move-address-form

created branch time in 5 days

PR opened artsy/reaction

Missing Image Fix

Followup to my (auctions results tweaks PR)[https://github.com/artsy/reaction/pull/3284]. This commit didn't get pushed by accident, its a fix that Justin suggested in the comments for the other PR.

+4 -2

0 comment

1 changed file

pr created time in 5 days

create barnchlilyfromseattle/reaction

branch : no-photo-fix

created branch time in 5 days

push eventlilyfromseattle/reaction

Justin Bennett

commit sha 9da273905c3569a2d25439cc5e634f08bc0e2f25

Add initial UI for years created filters on auction results

view details

Justin Bennett

commit sha 9b13fe8e171a69b9ab3dfd11e796f79be3a7befe

Update select year to populate from MP, do some minor date corrections

view details

xtina-starr

commit sha 74c050cc0ec068fd3c83b00847e64c2f574f6413

WIP - new mobile nav menu

view details

xtina-starr

commit sha 5c6fd9a899a7f8738d84f24b9fc3225e2559f484

use useSystemContext and rename components

view details

xtina-starr

commit sha 390cbf79da06da26287a2a8b0aca952ac251e982

refactor component to use context provider to facilitate statement

view details

xtina-starr

commit sha 5ceefe91da4bbf6952904eaa1b071ca9360b72f7

fix type errors

view details

xtina-starr

commit sha c87e2f9c4c8fc5f74ec39ce4c26297c071f8f702

remove console.log

view details

xtina-starr

commit sha abe1aec6b9e4155ccb88943760f3bd4bce73d65e

allow menu to scroll vertically

view details

xtina-starr

commit sha 46aaac70f84bd2eec592194f3252ba8de0fbbc9e

add specs to tests first menu view

view details

xtina-starr

commit sha 8dad49cba05c330f371040635a0df45ac29fa6a9

test base menu for logged out users

view details

xtina-starr

commit sha 4856ed3955c1b7d0c0c9d3e57bc3d1829500086b

remove unused imports

view details

xtina-starr

commit sha 1cb8cd1285eecdad4e4f3d0c4154bbaf6ef47e73

add logic to conditional render old or new mobile nav menu

view details

Justin Bennett

commit sha bc1a4c65bfafc6a506531a1e2421667867cb5a16

Add tests for filter logic

view details

Justin Bennett

commit sha 66481035c1312874f0cda622d1827da44bf7f00c

Merge branch 'master' into auctions-year-created-filter

view details

Yuki Nishijima

commit sha 8d8281288448eb4e1144c1deea06e61279165ac6

Refactor <IdentityVerificationApp>

view details

Yuki Nishijima

commit sha bfffe3297b704f10378fa7d7831bac05427659da

Add a link to IDV FAQ

view details

xtina-starr

commit sha 1453e875e41f823c8a2f0f893c42ab3b3dce1800

use double quotes for auth urls and remove signupIntent

view details

Justin Bennett

commit sha 9d630eb4ec085a27c30f2b2ad667754cf7288caf

Update year filters to be numbers instead of mixed strings and numbers

view details

Justin Bennett

commit sha 64d3b2ee88ad0bed7a028ad517c2983b1990b559

Fix failing tests

view details

Christina

commit sha 2fcb01c8c75dc934667ee4253bb10633d8c96404

Merge pull request #3238 from xtina-starr/mobile-nav-menu [FX-1702] new mobile nav menu

view details

push time in 8 days

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha 18b04ed963878ff626adfd36f94c22e80a51beff

fixed conflicts

view details

Lily Pacegit

commit sha ddc1461673c5e1423b99cee68a3cc77865326d84

fixed conflicts

view details

Lily Pacegit

commit sha 50ef1cd7256d0e142cc0fbfb779307e37503d269

removed disableRightClick and fixed weird test failure by changing beforeEach to beforeAll

view details

push time in 9 days

push eventlilyfromseattle/reaction

oxaudo

commit sha 1601ebe7181b4dfa9ca097fc3c058dd1c19dde17

make countries list on the Address form render only EU countries if it's marked as euOrigin and domesticOnly

view details

oxaudo

commit sha c3ab687a417bcf38923600884ef9f141536a2f92

Merge branch 'master' of github.com:artsy/reaction into updates

view details

xtina-starr

commit sha fb00331154e6d8ef8a7b5c41165b6dd724545917

add a fallback image when there is no headerImage

view details

oxaudo

commit sha 482b517305bb9b138edec033ed6127d9f88b027d

added specs for AdressForm usage

view details

Christopher Pappas

commit sha b7ad89157846f2aede0b43809ee0ecd219ea462c

[Clientside Nav] Add <NetworkTimeout /> component

view details

Christopher Pappas

commit sha 159ff90f98e70010ccad03106f639a5e3eb8e199

[Clientside Nav] Add <NetworkStatusMonitor /> component

view details

oxaudo

commit sha 57dee9b25365a4802e89d9b9af27f3087766593c

Merge branch 'master' of github.com:artsy/reaction into updates

view details

oxaudo

commit sha 63a4f79136a4f03ad0190ae02762b952fe74de59

Merge branch 'master' of github.com:artsy/reaction into updates

view details

oxaudo

commit sha 23d0cd2d617d6d19d5db8e9c6ad0e61d57ada6be

changed the list on what is included in EU_COUNTRY_SELECT_OPTIONS

view details

xtina-starr

commit sha c1afa529303f6ffdf5094f6cea3041581776ffb4

refactor conditional to account for null check

view details

Oksana

commit sha 42097477f319480d062460101dae82694cbfdd3f

Merge pull request #3222 from oxaudo/updates Make countries list on the Address form render only EU countries if it's marked as euOrigin and domesticOnly

view details

Artsy

commit sha 4c838b45b56619237e1d3234ad46035087efe080

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha d804f526e924223bfc61ca482b87b5b2c5bb79d7

Bump version to: 25.27.15 [skip ci]

view details

Jackie Potts

commit sha 5cd21d3c75b35336707c6f965fa014d99f2d0332

Update header test for auction results page

view details

Jacqueline Potts

commit sha 87176e6317c13ea15e37edaad5968b348a50de04

Update src/Apps/Artist/Routes/AuctionResults/Components/AuctionResultHeader.tsx Co-Authored-By: Justin Bennett <zephraph@gmail.com>

view details

oxaudo

commit sha 6dfa9e55d82da601b55ae63209d1d58b4c588291

the default should be country of origin if the country select is locked to EU only

view details

Anson Wang

commit sha 2f28134ef7e499f05f8ce0c448002dbdddb52506

Merge pull request #3263 from oxaudo/updates the default should be country of origin if the country select is locked to EU only

view details

Artsy

commit sha f74d700f8907e53ed1a51eccf370aad9aed253d9

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha bdb4eb3026274713ffe8631b794f75ea3fa0c676

Bump version to: 25.27.16 [skip ci]

view details

Eve Essex

commit sha 63a4eed234fd811add550faa1dfddd2bbe974d78

add generic auth helper

view details

push time in 10 days

PR opened artsy/reaction

DO NOT MERGE: Auction Results Visual Tweaks

[PURCHASE-1819] This PR includes all of the auction results tweaks in reaction. Tweaks requiring work in other repos were not included, and will be ticketed separately. Refer to the ticket for a full list of changes.

Before:

Screen Shot 2020-03-18 at 2 09 52 PM

After:

Screen Shot 2020-03-18 at 1 58 33 PM

DO NOT MERGE: waiting on https://github.com/artsy/palette/pull/652

+146 -70

0 comment

11 changed files

pr created time in 10 days

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha d2683e852954fc1b08cfb3c4ef5d4e3c56cd966b

added fallback image

view details

Lily Pacegit

commit sha 4d7551978ad06f70e736fd7825de19aca53d08e7

removed unecessary import

view details

Lily Pacegit

commit sha d2ee4615f5b9c2b55949d22b69c57bc7f5066ced

changed icon to no artwork

view details

push time in 10 days

PR opened artsy/palette

Added no artwork icon

We needed an icon for missing artwork images on the auction results tab as part of [PURCHASE-1819]

Screen Shot 2020-03-18 at 1 23 57 PM

+19 -0

0 comment

2 changed files

pr created time in 10 days

create barnchlilyfromseattle/palette

branch : no-artwork-icon

created branch time in 10 days

push eventlilyfromseattle/reaction

Eve Essex

commit sha 48935328a7a88adbe332fe226154a467246fa043

use stricter typing for follow auth modal triggers

view details

Eve Essex

commit sha 3d682402150b380382addfb0b7d89b21df73a7bf

update props for openAuthModal

view details

Christopher Pappas

commit sha dd8b20325874a2f02e015c62e7fd60d682f8ba09

Make hide grids function a bit safer

view details

Christopher Pappas

commit sha c719aa1170a13af03ff0e6c8095626f947ca7885

Update schema

view details

Christopher Pappas

commit sha 26b2c4b6c3cfc156b4dfe436dd6fbb714af93b2e

Merge pull request #3249 from damassi/master Update schema

view details

Eve Essex

commit sha 4cb981b488bd991cd42fbc5a2c5f938f03f1c053

Merge pull request #3239 from artsy/type-open-auth Helpers for opening auth modals are strictly typed

view details

Eve Essex

commit sha 38cbeb578b99db6d4f7408aadb29152e69f37e23

Revert "Helpers for opening auth modals are strictly typed"

view details

Eve Essex

commit sha ff7a580c8d3b63f19a81d36664a615b1f64a5683

Merge pull request #3250 from artsy/revert-3239-type-open-auth Revert "Helpers for opening auth modals are strictly typed"

view details

Artsy

commit sha 67594ea6004da938592216fe4268d6d49f436918

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha a10d9b2c6bab59c666b97e6824950cf090d8b5e3

Bump version to: 25.27.4 [skip ci]

view details

Christopher Pappas

commit sha be47c1b9a83d8739f7c0d0df1370f3abbf708609

Make get safer

view details

Christopher Pappas

commit sha 984ac27da1da61d70b5aac4fdbf16d799628ac58

Merge pull request #3251 from damassi/fix-node-issue [Bugfix] => Make `SEOProductsForCollections` safer

view details

Eve Essex

commit sha a9148b73cbf580fc278968dea125b6ba1f555941

openAuthModal helpers are typed to match auth modal types

view details

Artsy

commit sha 1659c8c053a4f39409f19eb2ea1fc1267233d122

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha eb975dd7da2e6d8e8af16a9c3231ad1e1eed3ef5

Bump version to: 25.27.5 [skip ci]

view details

Eve Essex

commit sha 134cd549e53d4583dfb5c99c6e4a55904743eebd

fix tests to use signup over register

view details

Eve Essex

commit sha 370f214e9e15bcd0410b0a29589f4d2e89eb551c

use slug for saveArtwork

view details

Christopher Pappas

commit sha 6503834962b9dce574d10599b5e8319cddb06653

[Artist] Fix redirect

view details

Christopher Pappas

commit sha d9747fd6f32cc7f000b3eb08fda7e5df96818fbf

Merge pull request #3248 from damassi/fix-edges-issue Make hide grids function a bit safer

view details

Artsy

commit sha d81b630d634bee42ccf5d20089201683c75a511f

Update CHANGELOG.md [skip ci]

view details

push time in 17 days

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha 5786dd43edbc2c572bee8616150018f44e3fa5d1

updated tests

view details

push time in 17 days

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha 8727ef2f2f0596cbcd90124c8b2dae5dc3877f63

final tweaks

view details

push time in 17 days

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha b6a6496b2827a7795ff252da86e2864f8e740dfb

removed accidental padding

view details

Lily Pacegit

commit sha 4ebc7c99359b9a17c5196424f45fd4355b195c51

changes

view details

push time in 18 days

create barnchlilyfromseattle/reaction

branch : auction-results-tweaks

created branch time in 18 days

push eventlilyfromseattle/exchange

Lily Pacegit

commit sha 79f65421a3d645e475caef045b1310a1d6affef3

ran migration to make fields not null

view details

push time in 22 days

create barnchartsy/reaction

branch : scroll-tabs

created branch time in 23 days

create barnchlilyfromseattle/sarahs-website

branch : master

created branch time in 23 days

create barnchlilyfromseattle/sarahs-website

branch : container-based-size

created branch time in 23 days

created repositorylilyfromseattle/sarahs-website

created time in 23 days

push eventlilyfromseattle/exchange

Lily Pacegit

commit sha af651312d793d23e6cbc25b49a641c8067550a10

undid accidental change

view details

push time in a month

PR opened artsy/force

Updated artist header test with different dash mark

I updated reaction to use formattedNationalityAndBirthday in the artist header instead of using nationality and years and conjoining them with a comma. This caused this test to fail because the dash mark in years was different than the one in formattedNationalityAndBirthday. I have updated the test with the string from formattedNationalityAndBirthday

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchlilyfromseattle/force

branch : header-test-fix

created branch time in a month

PR opened artsy/reaction

use `formattedNationalityAndBirthday` in artist header

[PURCHASE-1808]

I changed the way we display nationality and birth year after noticing a bug where there was a comma but no year for Banksy. We now use formattedNationalityAndBirthday, which will do the formatting work for us.

Before: Screen Shot 2020-02-26 at 5 43 38 PM

After: Screen Shot 2020-02-26 at 5 47 10 PM

+21 -45

0 comment

6 changed files

pr created time in a month

create barnchlilyfromseattle/reaction

branch : birthdate-fix

created branch time in a month

push eventlilyfromseattle/reaction

Lily Pace

commit sha 019651c62a434d2c55e0a2aff18686d3f9f9bb22

Update src/Apps/Artist/Routes/Overview/index.tsx Co-Authored-By: Justin Bennett <zephraph@gmail.com>

view details

push time in a month

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha e6513966b9116abcaffda2881806ce3a5d6fc18d

updated snapshots

view details

push time in a month

PR opened artsy/reaction

Link header badges to Auction Result / Career Highlights

[PURCHASE-1782]

User experience feedback: The new labels Highest auction result and Career Stage feel/look tappable – could also lead users to Auction Result / Career Highlights?

I updated the indicators so that the auction record indicator links to the auction results tab, and the career stage indicator links to the cv page.

+51 -16

0 comment

3 changed files

pr created time in a month

create barnchlilyfromseattle/reaction

branch : tappable-badges

created branch time in a month

push eventlilyfromseattle/reaction

Christopher Pappas

commit sha 9a209f54eb826e27b88f0f42e5fded20c4d71d0b

[Lib] Add express-http-context

view details

Christopher Pappas

commit sha 0631c7de34f595168aa32bccc630aba71deed349

[Toolchain] Add optional chaining plugin

view details

Christopher Pappas

commit sha 8ced144bf8f647f7b4acab15f1e1b37498d5dfc6

Use router link in OtherWorks CTA

view details

Christopher Pappas

commit sha 94224f09b2a744509f81beb8fb2e172283ffe692

Remove unnecessary env var

view details

Christopher Pappas

commit sha bafb28f07da9161f8e7351236fc0a2f41468d3c5

Fix artwork browser full-screen z-index flap

view details

Christopher Pappas

commit sha 870711005645d8dd462625239be98bbc2f29c786

Fix referrer

view details

Christopher Pappas

commit sha 87e6a9a98d6d34a3fa64080d78d9b55151015ba3

remove incremental

view details

Christopher Pappas

commit sha 99bf1b8c90e4ae3c14661200c24601469e15508b

remove incremental

view details

Christopher Pappas

commit sha 4ad03bdf14ebd0309e7b2286c1ab34533fceaea1

Merge branch 'master' into wire-up-context

view details

Renovate Bot

commit sha c439b7ec80a78490c43fa931c57a06cb07b5d745

Update dep @artsy/palette from 7.1.0 to v7.1.1

view details

Matthew Zikherman

commit sha a9447e6096768630a4ca59e8d9f9d0d891da12c1

[Analytics] Dont gate AB test event behind flag

view details

Matt Zikherman

commit sha 2008cd359e2ffec4c0aa9cf3dd7f3dc8f46c8e69

Merge pull request #3191 from damassi/wire-up-context Simplify A/B test lookup via `express-http-context`

view details

Artsy

commit sha 6aa4b70cbfea9fd509213025c49097c756e80674

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha 235f0184a85ac568b6a535cbc7a993aa54a78d8d

Bump version to: 25.18.1 [skip ci]

view details

Renovate Bot

commit sha 2871ab44e0c58f7724e2ea371be8bbe959edcbdf

Pin dependencies

view details

Justin Bennett

commit sha 330275dd2e99509d8ca84a3d98aba79d376d5ced

Merge pull request #3195 from artsy/renovate/pin-dependencies Pin dependencies

view details

Justin Bennett

commit sha 3f5d675da19ccb0f1165ba0b848d82cb43ba84b3

Merge pull request #3194 from artsy/renovate/artsy-palette-7.x Update dep @artsy/palette from 7.1.0 to v7.1.1

view details

Sarah Weir

commit sha aad709cb5d7c80af775f5f9ae7c5328195200cbc

Return gravity-backed unread count in notifications badge

view details

Justin Bennett

commit sha 4d59b8ad6dfaa48f74a8b490a1d51316e4c4f588

Remove opening auction results from filters

view details

Justin Bennett

commit sha 962f7b437be48f507eaadd567386acb844d10276

Fix types in tests

view details

push time in a month

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha 27988a4de80194c9f2b14653145daf1a4f18587d

updated snapshots

view details

push time in a month

PR opened artsy/reaction

Handle "works for sale" copy and tabs on artwork page if no works for sale

[PURCHASE-1783]

Slack discussion: https://artsy.slack.com/archives/C9YNS4X32/p1581012423395200

"Works for sale" copy is confusing when there are no works for sale. Should be changed to "Artworks".

Before: Screen Shot 2020-02-25 at 10 57 17 AM

Screen Shot 2020-02-25 at 11 13 57 AM

After: Screen Shot 2020-02-25 at 10 57 09 AM

Screen Shot 2020-02-25 at 11 13 36 AM

+3282 -6552

0 comment

17 changed files

pr created time in a month

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha dbe5d125faed039d86da22cd254cfa9f28a91ecd

updated snapshots and fixed tests

view details

push time in a month

create barnchlilyfromseattle/reaction

branch : works-for-sale-copy-change

created branch time in a month

PR opened artsy/palette

Small dropdown arrow is misaligned

[PURCHASE-1779]

the Sort: dropdown arrow is displaying oddly/in incorrect placement on Chrome (iPhone X)

https://files.slack.com/files-pri/T02531TU5-FTC9HD19P/image.png

Before: Screen Shot 2020-02-21 at 3 20 04 PM

After: Screen Shot 2020-02-21 at 3 19 15 PM

+1 -0

0 comment

1 changed file

pr created time in a month

create barnchlilyfromseattle/palette

branch : select-bug

created branch time in a month

push eventlilyfromseattle/exchange

Lily Pacegit

commit sha f08cbe51db62a2f71561956a67b57513b1b0cb7b

rubocop fixes

view details

push time in a month

push eventlilyfromseattle/exchange

Ashkan Nasseri

commit sha 2e317e2528ceded3ecbf72056537d7188291ce69

add failing test Co-authored-by: Sarah Weir <sweir27@gmail.com>

view details

Ashkan Nasseri

commit sha 1ddfa30bb5acf458e2c0265d81b6674351284f21

Fix the failed confirm issue

view details

Ashkan Nasseri

commit sha e4ae1bff926bd272ca268e11d67e108cbeea968f

Code review comment: capture more stripe errors

view details

Sarah Weir

commit sha a6ae90a96da42d0cae388509981fa1c5a5de2dae

Merge pull request #510 from ashkan18/fix-confirm-unauthorized-payment-intents Fix fail confirm payment intent issue

view details

Ashkan Nasseri

commit sha 02df1e18aeb50b733c198f43d92abdd369b0df87

Make sure payment service returns failed transaction instead of raising processing error

view details

Ashkan Nasseri

commit sha 332584e175af7ef9aa8d7c088efebb02fb67689b

Code review comment

view details

Sarah Weir

commit sha 84dc3b3c26613fe212f07674a8a4f9ceeca8bdfe

Merge pull request #512 from ashkan18/payment-service-confirm-return-transaction Make sure payment service returns failed transaction on failed confirm

view details

Ashkan Nasseri

commit sha 8ab474fbd9ce334c25d836fcbc0aee8ec570bb78

Add external_charge_id to order event

view details

artsy-peril[bot]

commit sha 25082ae16a0750a10188285962cfa1f698a76c52

Add external_charge_id to order event (#514) Add external_charge_id to order event

view details

Ashkan Nasseri

commit sha fa02717b4e544494ba268f047db1aec71fa81d25

Add artist ids and names to charge metadata

view details

dependabot-preview[bot]

commit sha cb5e3623c79d5f9800934d070a64eda9c77a3f58

[Security] Bump rubyzip from 1.2.3 to 1.3.0 Bumps [rubyzip](https://github.com/rubyzip/rubyzip) from 1.2.3 to 1.3.0. **This update includes a security fix.** - [Release notes](https://github.com/rubyzip/rubyzip/releases) - [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md) - [Commits](https://github.com/rubyzip/rubyzip/compare/v1.2.3...v1.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Ashkan Nasseri

commit sha d78bbf36c24e73575d959bb03ad933fd2a7a665e

Merge pull request #516 from ashkan18/PURCHASE-1567 Add artist ids and names to charge metadata

view details

Sarah Weir

commit sha a4d3efef509b85543c394f75b5fa49e1632b542f

Merge pull request #518 from artsy/dependabot/bundler/rubyzip-1.3.0 [Security] Bump rubyzip from 1.2.3 to 1.3.0

view details

dependabot-preview[bot]

commit sha 9a286e5ea30cbb331c9f913b1aad97fcea6218fd

[Security] Bump loofah from 2.2.3 to 2.3.1 Bumps [loofah](https://github.com/flavorjones/loofah) from 2.2.3 to 2.3.1. **This update includes a security fix.** - [Release notes](https://github.com/flavorjones/loofah/releases) - [Changelog](https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md) - [Commits](https://github.com/flavorjones/loofah/compare/v2.2.3...v2.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Ashkan Nasseri

commit sha 31ab41d8d739e7248f3001b519af0964dcf50eb0

First pass in fixing admin canceling offer issue with undeduct

view details

Ashkan Nasseri

commit sha 25ae4fdf2a0e4027a7cc89efe5d46c921f0bbeef

Added test for offer orders cancelation

view details

Ashkan Nasseri

commit sha 81b72a317d20fed11bff51a124311f99d9d06048

Code review comments + updating schema

view details

Ashkan Nasseri

commit sha 63c60b2a9dc73b7c59d302529a6fd19d803e0e9c

Merge pull request #522 from ashkan18/fix-admin-offer-cancelation-issue Fix admin offer cancelation issue

view details

Ashkan Nasseri

commit sha bb35a1c169e38542e9e22448a8b1efc5750edf24

[admin] Make sure both buyer_reject and cancel button show up

view details

Ashkan Nasseri

commit sha 5c0d3357011247e5befa85f3dcc04f6c676fead6

Merge pull request #523 from ashkan18/fix-admin-offer-cancelation-issue [admin] Make sure both buyer_reject and cancel button show up

view details

push time in a month

push eventlilyfromseattle/exchange

Lily Pacegit

commit sha 95ef97755d29f8c6f9e85072ec8444f52a34eb57

fix for postgres issue

view details

push time in a month

PR opened artsy/exchange

Require artwork_id and artwork_version_id on line items in exchange

[PURCHASE-1212]

We recently had a case where manually-edited order mistakenly didn't have artwork_version_id set on its line items. This caused a gallery's "completed" tab to error out.

We should be requiring artwork_id and artwork_version_id be present on line items in exchange. This will help prevent similar errors in the future.

+22 -6

0 comment

3 changed files

pr created time in a month

create barnchlilyfromseattle/exchange

branch : require_fields

created branch time in a month

push eventlilyfromseattle/reaction

Lily Pace

commit sha 686646f4b2b23dc3be37151ac1570ee526ee704a

Update src/Apps/Artist/Routes/AuctionResults/ArtistAuctionResultItem.tsx Co-Authored-By: Justin Bennett <zephraph@gmail.com>

view details

push time in 2 months

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha da3cf9624bbad89aa93e3820d20126129d9ba1c2

adjusted button in logged out statre

view details

push time in 2 months

push eventlilyfromseattle/reaction

Christopher Pappas

commit sha 69619c4c72f1e90e1bc006eb4b1412049f2a2213

[Analytics] Path is relative

view details

Christopher Pappas

commit sha 3a8d97f8416ffe544d878c9ec126346af7389f75

Merge pull request #3142 from damassi/fix-path [Analytics] Path is relative

view details

Artsy

commit sha 2db9affc5d488ef01f4b478478ccaa9e0575d096

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha ead1c78d72daa3418250e5939bd917db226df024

Bump version to: 25.5.6 [skip ci]

view details

Lily Pace

commit sha c4a4ddf934578fa22ecde8a3408f3fa8773fbbac

Merge branch 'master' into auction-results-card

view details

push time in 2 months

PR opened artsy/reaction

As a user I see the updated list view of auction results and i can expand the result

[PURCHASE-1732] As a user I see the updated list view of auction results and i can expand the result

This does not involve adding any new filters or anything. It's just updating the list view item to match the new UI.

AC:

  • UI is its responsive
  • Result can expand
  • Matches the spec https://zpl.io/agB7doM

Before:

Mobile: Screen Shot 2020-02-07 at 4 14 08 PM

Desktop: Screen Shot 2020-02-07 at 4 14 52 PM

After:

Mobile: Screen Shot 2020-02-07 at 4 14 43 PM

Desktop: Screen Shot 2020-02-07 at 4 15 03 PM

+577 -347

0 comment

11 changed files

pr created time in 2 months

push eventlilyfromseattle/reaction

Eve Essex

commit sha 6983a07e402afb2649efc3146c0da5c3a882d483

Merge branch 'lint_rule' of https://github.com/artsy/reaction

view details

Lily Pacegit

commit sha 8029774f449542c7b85dac0b6875c1b4fac7735e

made phone number required for ship orders

view details

Sarah Weir

commit sha 65f826b1c1b956641efaafac01797eca520722e4

Merge pull request #3112 from lilyfromseattle/phone-number-fix User should not be able to advance to the payment page without entering a phone number with their shipping address

view details

Artsy

commit sha 77bdb5014e4b671ffd0318b2bad8294610d28503

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha 0356eaa0cc99f9aeae1cbab4f92ccb1598eea995

Bump version to: 24.4.1 [skip ci]

view details

Eve Essex

commit sha f15a3366d22d84d6c35cb9f92f11650a5fb8cb99

Merge branch 'master' of https://github.com/artsy/reaction

view details

Eve Essex

commit sha f52efdc120aa91cc32f78290b269c7e5452f70a2

rename recaptcha, add new recaptcha types

view details

xtina-starr

commit sha 42cf3b744715c8374fe481b8e9e5ffff832e1022

use resizer for featured collection image

view details

Matt Zikherman

commit sha 0e38db8443608ecba184e004f73b0ea038da7deb

Merge pull request #3113 from eessex/recaptcha Rename 'repcaptcha' to 'recaptcha', add new types

view details

xtina-starr

commit sha f501cf7cd249aaf47c95bf841ebd6ffcfd0b1b77

fix spec

view details

Artsy

commit sha 7948608f7b65e637ddd845d0324bd87a3a262fbf

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha 49a1ee5d15f06691d3f2563d9fc5c461967e2612

Bump version to: 25.0.0 [skip ci]

view details

Anandaroop Roy

commit sha 5cff0bcf86f730b89cd44a24b56ea45c38e41f6e

Replace 230px image with appropriately sized and compressed version

view details

Jackie Potts

commit sha 6e7b06767dd36d7a86315e370296a013de2b8847

Add medium field to artwork details

view details

Justin Bennett

commit sha a0e7b6863930de1d81558b5693a5ba95967dc541

[PUR-1727] Add medium field to artwork details (#3116) [PUR-1727] Add medium field to artwork details

view details

Artsy

commit sha 416ac73de2f6040fb07c73e9486ae6195ebb2a09

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha c529e8c7c5af721b8f9eb80d98bc8e8a2b6c8bba

Bump version to: 25.1.0 [skip ci]

view details

Christina

commit sha 10c2674596252db4703d416f99b2487f192cda0c

Merge pull request #3115 from anandaroop/FX-1675-optimize-header-artist-image [FX-1675] Resize collection header artist images

view details

Anandaroop Roy

commit sha 074e5f8b80438c08bef852265ce467881527d1ff

Merge pull request #3114 from xtina-starr/resize-thumbnail-featured-collections-rail [FX-1684] use resizer for featured collection image

view details

Artsy

commit sha 9067046a349d0131b8fed313ebe043bb0be8cb57

Update CHANGELOG.md [skip ci]

view details

push time in 2 months

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha abb616fdd0aefd67ba4fd013c297af1f521afa27

resolved conflict

view details

Lily Pacegit

commit sha 6f40367eb798eaab6fea2f5e5790d19dea231775

final touches

view details

push time in 2 months

create barnchlilyfromseattle/reaction

branch : auction-results-card

created branch time in 2 months

PR opened artsy/reaction

Reviewers
User should not be able to advance to the payment page without entering a phone number with their shipping address

[PURCHASE-1757] User should not be able to advance to the payment page without entering a phone number with their shipping address

This is a follow up to fix a regression that I accidentally caused with my phone number field PR.

When I place an order if I select shipping and enter a shipping address I should be required to enter a phone number

Currently, I'm able to advance without entering my phone number.

After: Screen Shot 2020-01-30 at 9 47 39 AM

+34 -1

0 comment

2 changed files

pr created time in 2 months

create barnchlilyfromseattle/reaction

branch : phone-number-fix

created branch time in 2 months

create barnchlilyfromseattle/force

branch : renaming-fix

created branch time in 2 months

push eventlilyfromseattle/force

Lily Pacegit

commit sha b89b9e5e23d8d92a2c9a0f0c3feb326e8e83f439

renames purchase to purchases

view details

push time in 2 months

Pull request review commentartsy/force

Hackathon: Orders dashboard

+import { buildServerApp } from "reaction/Artsy/Router/server"+import { stitch } from "@artsy/stitch"+import { routes } from "reaction/Apps/Purchase/routes"

Iirc I think we went with the singular to be consistent with the other apps.

lilyfromseattle

comment created time in 2 months

Pull request review commentartsy/force

Hackathon: Orders dashboard

+import { buildServerApp } from "reaction/Artsy/Router/server"+import { stitch } from "@artsy/stitch"+import { routes } from "reaction/Apps/Purchase/routes"

So just to be clear should I or should I not rename everything in this PR?

lilyfromseattle

comment created time in 2 months

PR opened artsy/force

Reviewers
Hackathon: Orders dashboard

This is the force side of the orders dashboard hackathon project. Reaction changes have already been merged, and the dashboard will be visible once this PR is merged too.

+93 -0

0 comment

4 changed files

pr created time in 2 months

create barnchlilyfromseattle/force

branch : my-purchases-2

created branch time in 2 months

push eventlilyfromseattle/force

dependabot-preview[bot]

commit sha a9189b73f94c48614acda277838905a0b42224be

[Security] Bump handlebars from 4.0.11 to 4.5.3 Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.0.11 to 4.5.3. **This update includes a security fix.** - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.0.11...v4.5.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

sepans

commit sha 97b7486827897dea563a7ea23af4c7639e3ef154

Adds json-ld to show mobile page The new `view_helpers.coffee` contains needed functions from the 'Desktop' app modified to use the `show` model object instead of MP returned object.

view details

Eve Essex

commit sha df15bb11adb22f2b1f94b7aa3bf623897fb91c79

fix inquiry form styles, display recaptcha terms in inquiry form

view details

Renovate Bot

commit sha 02cf72157089820214d10632c571335842960c1d

Update dep @artsy/reaction from 24.0.21 to v24.0.22

view details

Joey Aghion

commit sha a24de41815c6fdf5770aa15c8cfd36624313fed3

Merge pull request #4891 from artsy/dependabot/npm_and_yarn/handlebars-4.5.3 [Security] Bump handlebars from 4.0.11 to 4.5.3

view details

sepans

commit sha c73f1549d4ec1cbba2ed79dce58e81f3c669b56e

Tests and moving assertions to helper

view details

Anandaroop Roy

commit sha b22948652a46d3f16468f640c0503237d8f4ddd8

Fix list spacing in JSON pages

view details

artsy-peril[bot]

commit sha cda3e8be45945bdc5bd4cbe0bc4991a0e3b9ce11

Fix list spacing in markdown pages (#4919) Fix list spacing in markdown pages

view details

sepans

commit sha 75e340b03eba2f799d0c88978a73b530fd13c408

Fix and improve tests

view details

Anandaroop Roy

commit sha f5d1bbd2b1f899380a27a7c02601ae99f0e1b0b3

Update fixture for collection acceptance test A change in https://github.com/artsy/reaction/pull/3007 requires new ascending_artworks and descending_artworks fields on the collection response. Here they are!

view details

Matt Zikherman

commit sha 59b11148af14807ac2a61c91c6269ebb619faac2

Merge pull request #4920 from anandaroop/fix-fixture Fix collection acceptance tests

view details

sepans

commit sha 20d85ec4ad23073a0ad1053d9da1a9c5d5b02c23

PR comments

view details

Sarah Weir

commit sha 695fd110a218d1beedf772469f814a9b92a93a23

Merge pull request #4892 from sepans/show-mobile-jsond [PURCHASE-1647] Adds json-ld to show mobile page

view details

Renovate Bot

commit sha 45535b02a0c21ffa6bd13632aef3c3afc59f36fa

Update dep @artsy/reaction from 24.0.22 to v24.0.23

view details

Renovate Bot

commit sha 180bf5c645a106589e62ef41799835b93ce18238

Update dep @artsy/reaction from 24.0.23 to v24.0.24

view details

Renovate Bot

commit sha 26b04192693dcf44eae114b4bba85cfa32e8cb68

Update dep @artsy/reaction from 24.0.24 to v24.0.25

view details

Devon Blandin

commit sha bedb11c81df69d73ca070190ec2e1052de6e2b79

Remove auction_support apps and related bid/reg support We've recently moved registration and bidding functionality to artsy/reaction. These routes and components are no longer used and should be cleaned up.

view details

Devon Blandin

commit sha 8ec1cbf1743ea795ab167a397084ba21db175046

Remove old confirm bid form routing The new artsy/reaction-based confirm bid form has been enabled in production for a while. As part of cleaning up old registration/bid-resources in force, this removes the switch between the old and new confirm bid flows and associated express routing.

view details

Matthew Zikherman

commit sha bf4f7f362d0435f7d6f50fe3d11f43ece4c98c26

[Client Side Routing] Reenable AB test

view details

Devon Blandin

commit sha 5545de031058529c787c2708999ba517f7f7a305

Revert "Remove old confirm bid form routing" This reverts commit 8ec1cbf1743ea795ab167a397084ba21db175046.

view details

push time in 2 months

push eventartsy/reaction

Lily Pacegit

commit sha 29177ad6d349111a6dedf1038ace9a464f89eded

added phone number form

view details

Lily Pacegit

commit sha 493c1e9a469e45e0dc4a06cd287e011f9c49d5e2

testds

view details

Lily Pacegit

commit sha 073b55f5a30888c2f595010a518dec917387ab67

fixed title issue in tests

view details

Lily Pacegit

commit sha fede730f42250e9d53f4bdffe804d9d62a27bbdc

pr comment fixes, cleanup

view details

Lily Pace

commit sha e7ecb30d7b1f6b9a2d9f4b5f0c81d91770053a95

Merge pull request #3104 from lilyfromseattle/new_phone_number_field PURCHASE-1656: Add phone number field to Address for pickup

view details

push time in 2 months

delete branch lilyfromseattle/reaction

delete branch : new_phone_number_field

delete time in 2 months

PR merged artsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup Jira Synced Version: Minor

PURCHASE-1656 Add phone number field to Address for pickup

https://www.figma.com/file/LieDNuIuKAfhDeEPkjan4p/Checkout-Flow?node-id=0%3A1

This field should be required.

This is a refactor of this PR as was suggested in the comments

Before: Screen Shot 2020-01-02 at 11 49 45 AM

After: Screen Shot 2020-01-02 at 11 49 30 AM

+493 -113

1 comment

11 changed files

lilyfromseattle

pr closed time in 2 months

create barnchlilyfromseattle/force

branch : my-purchases

created branch time in 2 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

+import { Flex, Spacer } from "@artsy/palette"+import Input from "Components/Input"+import React from "react"++export type PhoneNumber = string++export type PhoneNumberError = Partial<PhoneNumber>+export type PhoneNumberTouched = boolean+export type PhoneNumberChangeHandler = (phoneNumber: string) => void++export const emptyPhoneNumber: string = ""++export interface PhoneNumberFormProps {+  onChange: PhoneNumberChangeHandler+  value?: string+  errors: PhoneNumberError+  touched: PhoneNumberTouched+  label: string+}++interface PhoneNumberFormState {+  phoneNumber: string+}++export class PhoneNumberForm extends React.Component<+  PhoneNumberFormProps,+  PhoneNumberFormState+> {+  state = {+    phoneNumber: this.props.value || emptyPhoneNumber,+  }++  changeEventHandler = phoneNumber => (+    ev: React.FormEvent<HTMLInputElement>+  ) => {+    this.onChangeValue(phoneNumber, ev.currentTarget.value)+  }++  changeValueHandler = phoneNumber => (value: string) => {+    this.onChangeValue(phoneNumber, value)+  }++  onChangeValue = (phoneNumber, value: string) => {+    this.setState({ phoneNumber: value }, () => {+      this.props.onChange(this.state.phoneNumber)+    })+  }++  getError = (phoneNumber): string => {+    return (this.props.touched && this.props.errors) || ""+  }++  render() {+    return (+      <Flex flexDirection="column">+        <Input+          id="PhoneNumberForm_phoneNumber"+          title="Phone number"+          type="tel"+          description={this.props.label}+          placeholder="Add phone"

It was like this before (on the shipping page) so I kept it as is

lilyfromseattle

comment created time in 2 months

PR closed artsy/reaction

Reviewers
PURCHASE-1656: Add phone number field to Address for pickup Jira Synced Version: Minor

PURCHASE-1656 Add phone number field to Address for pickup

https://www.figma.com/file/LieDNuIuKAfhDeEPkjan4p/Checkout-Flow?node-id=0%3A1

This field should be required.

This is a refactor of this PR as was suggested in the comments

Before: Screen Shot 2020-01-02 at 11 49 45 AM

After: Screen Shot 2020-01-02 at 11 49 30 AM

+192 -131

2 comments

4 changed files

lilyfromseattle

pr closed time in 2 months

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha fede730f42250e9d53f4bdffe804d9d62a27bbdc

pr comment fixes, cleanup

view details

push time in 2 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

 export class AddressForm extends React.Component<             />           </Flex>         </TwoColumnSplit>-        {(!this.props.billing || this.props.showPhoneNumberInput) && (+        {this.props.showPhoneNumberInput && (

From what I can see it's used in BidForm, RegistrationForm, PaymentPicker, and PaymentForm. In all places billing is true, so removing the !this.props.billing check shouldn't affect the other usages.

lilyfromseattle

comment created time in 2 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

 export class ShippingRoute extends Component<ShippingProps, ShippingState> {     address: this.startingAddress,     addressErrors: {},     addressTouched: {},+    phoneNumber:+      this.props.order.requestedFulfillment &&+      (this.props.order.requestedFulfillment.__typename === "CommerceShip" ||

So is it best to leave the check in for now?

lilyfromseattle

comment created time in 2 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

 export class ShippingRoute extends Component<ShippingProps, ShippingState> {     address: this.startingAddress,     addressErrors: {},     addressTouched: {},+    phoneNumber:+      this.props.order.requestedFulfillment &&+      (this.props.order.requestedFulfillment.__typename === "CommerceShip" ||

@zephraph @ds300 Any ideas on why this is causing type errors without the check?

lilyfromseattle

comment created time in 2 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

 export class AddressForm extends React.Component<             />           </Flex>         </TwoColumnSplit>-        {(!this.props.billing || this.props.showPhoneNumberInput) && (+        {this.props.showPhoneNumberInput && (

Hey @dblandin you added this check right? Is it ok if I remove it?

lilyfromseattle

comment created time in 2 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

 export class ShippingRoute extends Component<ShippingProps, ShippingState> {     address: this.startingAddress,     addressErrors: {},     addressTouched: {},+    phoneNumber:+      this.props.order.requestedFulfillment &&+      (this.props.order.requestedFulfillment.__typename === "CommerceShip" ||

It was causing type errors for some reason so this is what Sepand and I came up with but I;'m open to alternate suggestions

lilyfromseattle

comment created time in 2 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

+import { Flex, Spacer } from "@artsy/palette"+import Input from "Components/Input"+import React from "react"++export type PhoneNumber = string++export type PhoneNumberError = Partial<PhoneNumber>+export type PhoneNumberTouched = boolean+export type PhoneNumberChangeHandler = (phoneNumber: string) => void++export const emptyPhoneNumber: string = ""++export interface PhoneNumberFormProps {+  onChange: PhoneNumberChangeHandler+  value?: string+  errors: PhoneNumberError+  touched: PhoneNumberTouched+  label: string+}++interface PhoneNumberFormState {+  phoneNumber: string+}++export class PhoneNumberForm extends React.Component<+  PhoneNumberFormProps,+  PhoneNumberFormState+> {+  state = {+    phoneNumber: this.props.value || emptyPhoneNumber,+  }++  changeEventHandler = phoneNumber => (+    ev: React.FormEvent<HTMLInputElement>+  ) => {+    this.onChangeValue(phoneNumber, ev.currentTarget.value)+  }++  changeValueHandler = phoneNumber => (value: string) => {+    this.onChangeValue(phoneNumber, value)+  }++  onChangeValue = (phoneNumber, value: string) => {+    this.setState({ phoneNumber: value }, () => {+      this.props.onChange(this.state.phoneNumber)+    })+  }++  getError = (phoneNumber): string => {+    return (this.props.touched && this.props.errors) || ""+  }++  render() {+    return (+      <Flex flexDirection="column">+        <Input

Input doesn't take mb .but I can add it to the flex

lilyfromseattle

comment created time in 2 months

PR opened artsy/reaction

Reviewers
PURCHASE-1656: Add phone number field to Address for pickup

PURCHASE-1656 Add phone number field to Address for pickup

https://www.figma.com/file/LieDNuIuKAfhDeEPkjan4p/Checkout-Flow?node-id=0%3A1

This field should be required.

This is a refactor of this PR as was suggested in the comments

Before: Screen Shot 2020-01-02 at 11 49 45 AM

After: Screen Shot 2020-01-02 at 11 49 30 AM

+496 -113

0 comment

11 changed files

pr created time in 2 months

push eventlilyfromseattle/reaction

Lily Pacegit

commit sha 073b55f5a30888c2f595010a518dec917387ab67

fixed title issue in tests

view details

push time in 2 months

create barnchlilyfromseattle/reaction

branch : new_phone_number_field

created branch time in 2 months

push eventartsy/reaction

Lily Pacegit

commit sha 5e1eb7ccbecce32b6579af60e27f88cb632295e1

troubleshooting

view details

push time in 2 months

push eventartsy/reaction

Lily Pacegit

commit sha 741ed1ccecfc2f908a55e0d96d092d5ae9de6b91

conditionally show link

view details

Lily Pacegit

commit sha b686cac5df4c73174b227474bc9b385396b1a5db

moved link

view details

push time in 3 months

push eventartsy/reaction

Lily Pacegit

commit sha 1181f1fc359e38e793201ed10a2e317f5b141daf

added to menu

view details

push time in 3 months

push eventartsy/reaction

Lily Pacegit

commit sha 6426d942fe1f5976fbee17dd8f1f9e9b2fa5bf41

cleanup

view details

Lily Pacegit

commit sha 8777922b078d7fb0ce84aee4cff63de4e5ef5ea4

removed comment

view details

Lily Pacegit

commit sha eb535ec635b9bbe39ede1a7da0291d8c0d48b6cd

page title

view details

push time in 3 months

push eventartsy/reaction

Lily Pacegit

commit sha d0b737a6b1ee3268269ea1124fa33431734162c8

styling

view details

push time in 3 months

push eventartsy/reaction

Lily Pacegit

commit sha 3c1e437cc493ecb377d3bf353c82e951bc814a02

troubleshooting

view details

push time in 3 months

push eventartsy/reaction

Lily Pacegit

commit sha 1c40f97919a2895eadb526ca60ee0fc72cfae8ad

slightly less stuck

view details

push time in 3 months

create barnchartsy/force

branch : my-purchases

created branch time in 3 months

push eventlilyfromseattle/exchange

Lily Pacegit

commit sha f6cce9040b577b0a243395a83270a96b16d8f27b

fixed typo

view details

push time in 3 months

PR opened artsy/metaphysics

WIP: New exchange schema

This is to update metaphysics with the changes I made in https://github.com/artsy/exchange/pull/551

+37 -9

0 comment

3 changed files

pr created time in 3 months

create barnchlilyfromseattle/metaphysics

branch : schema-stuff

created branch time in 3 months

PR opened artsy/exchange

Only require phone number for pickup orders

Problem: We were requiring phone number on pickup orders as well as ship orders, so we were getting validation errors when pickup orders were placed without phone number (phone number field has not been added to reaction yet for pickup orders)

Solution: I changed the validation logic so it only requires phone number for pickup orders. I also added a test to confirm this.

+9 -1

0 comment

2 changed files

pr created time in 3 months

create barnchlilyfromseattle/exchange

branch : phone-number-fix

created branch time in 3 months

push eventartsy/exchange

Lily Pacegit

commit sha 25f7659120e4b813fa92ebd053aac42ced1ab112

rubocop fixes

view details

push time in 3 months

push eventartsy/exchange

Lily Pacegit

commit sha 0020def71747b8d01d08723a0de45847d95dfd15

test for old phone number passing

view details

push time in 3 months

PR opened artsy/exchange

WIP: Return phoneNumber in graphQL response for CommercePickup order

[PURCHASE-1707] Return phoneNumber in graphQL response for CommercePickup order

We want to be able to pre-fill the phone number field on the shipping page if a user has selected pickup.

Currently, we're not able to fetch for the phone number for pickup orders so this isn't possible.

We should update exchange to return phoneNumber in the graphQL response for pickup orders.

_

  • we now return phone_number for pickup orders as part of requested_fulfillment

  • we also updated setShipping mutation to now get a root level optional phone_number. We kept the phone_number passed in shipping as well. so if its not set in the root argument we try to fetch it from shipping input

+69 -11

0 comment

7 changed files

pr created time in 3 months

create barnchartsy/exchange

branch : move-phone-number-to-right-place

created branch time in 3 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

 export class AddressForm extends React.Component<   }    phoneNumberInputDescription = (): string | null => {-    if (this.props.billing && this.props.showPhoneNumberInput) {+    if (this.props.phoneNumberOnly) {

I talked it over with Ashkan and he thought this way was fine but can do it that way if you think its better

lilyfromseattle

comment created time in 3 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

 export class AddressForm extends React.Component<   }    phoneNumberInputDescription = (): string | null => {-    if (this.props.billing && this.props.showPhoneNumberInput) {+    if (this.props.phoneNumberOnly) {

Like the handlers and stuff. It just felt like a lot of duplication when I started doing it that way

lilyfromseattle

comment created time in 3 months

Pull request review commentartsy/reaction

PURCHASE-1656: Add phone number field to Address for pickup

 export const ShippingFragmentContainer = createFragmentContainer(         state         requestedFulfillment {           __typename+

Unknown field 'phoneNumber' on type 'CommercePickup'

lilyfromseattle

comment created time in 3 months

more