profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/lgandecki/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Łukasz Gandecki lgandecki @xolvio http://xolv.io JavaScript Hacker. Founder/Tech Lead @xolvio / @TheBrainFamily

lgandecki/apollo-federation-workshop 11

Apollo Federation Workshop

lgandecki/babel-plugin-ignore-html-and-css-imports 4

Ignore html and css imports in your code. Useful for testing meteor without it's context

lgandecki/advanced-react-hooks 0

Learn Advanced React Hooks workshop

lgandecki/advanced-react-patterns 0

This is the latest advanced react patterns workshop

lgandecki/Aerial 0

Apple TV Aerial Screensaver for Mac

lgandecki/apollo-live-server 0

A set of tools to enable reactivity in Apollo alongside Meteor

lgandecki/apollo-server 0

🌍 GraphQL server for Express, Connect, Hapi, Koa and more

issue commentTheBrainFamily/wait-for-expect

Async await usages not showing expectation library error

Sorry for the troubles :-( Do you guys have any simple repo that you could push to github that I could clone and reproduce? I'm loaded with work but if someone could help with the first step I might be able to figure out the problem much quicker.

sekhavati

comment created time in 12 days

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(cypress-tags.js): scenario outlines with examples were not correctly filtered by tags

Just to be clear about one thing, I don't mind that much that it's my free time and I don't get anything in return. The problem happens when you add the third element - demands, complaints, or sometimes straight-forward offensive remarks ( as here: https://github.com/TheBrainFamily/cypress-cucumber-preprocessor/issues/386 where a guy that didn't even install a package came to complain in github issues that it didn't work, he was creating one issue after another which pretty much was unpaid hand-holding/consulting and after I helped him in a few of those issues and then suggested he should move to stack overflow he started throwing ugly remarks towards me). This work is frequently less pleasant and more demanding than what I do for my clients, that treat me with respect and pay very well :-)

Take a look at some commercial repositories, like Cypress. I have an open and acknowledged issue there, with quite a few of likes, for soon to be three years - https://github.com/cypress-io/cypress/issues/3323 . there is a ton of opened issues and PRs - would you say that's also "limbo"? ;) Remember - there are many full-time employees backed by investors money..

I agree it would be nice to somehow make things clear to the users, but as you said - it's Open Source, it comes as is, the license states: "THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND". Of course if we decide to abandon the project we would let the community know, but so far it's definitely not abandoned, any significant bugs will be fixed, and any necessary updates will be performed. cypress-tags is of a lower priority since it's just a helper that's not required to use the package, and in addition to that it has no test coverage which makes it low priority and hard to change at the same time.

rkrisztian

comment created time in 13 days

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(getstepdefinitionpaths.js): add shared level of steps (#590)

@rdroog The cucumber reporter is part of this repository, but it's not part of @badeball fork. It's great that he now considers adding it to his fork, at that point I think I'd be all for doing the migration/merging plan that we've outlined a while back. I'd be happy to sponsor part of that work and/or help. @badeball if you think of some tasks that @rdroog or me or @MateuszNowosad could pick up to help you that would be great. But I imagine it might be easier to mostly do it yourself.

rdroog

comment created time in 13 days

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(getstepdefinitionpaths.js): add shared level of steps (#590)

@rdroog yeah I prefer @badeball solution, actually I agree with all the decisions he made in his fork, and we talked about joining forces, but I'm not so sure if we can skip the cucumber reporter, sounds like a ton of people are using that. It's also a huge source of issues and it made the code much more complex. As a temporary solution we could introduce some of the changes from the fork back here.

rdroog

comment created time in 14 days

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(getstepdefinitionpaths.js): add shared level of steps (#590)

@rdroog this is a significant change that we would need to understand better. In the issue you mention this is an enhancement but here you made it as a fix - which suggests it fixes a bug. I might be mistaken here since I haven't read through the issue properly, just scrolled through - is this a fix or a feature? Additionally, as @badeball mentions in #627 we should not be introducing changes without test coverage. I wouldn't ask anyone to do that for cypress-tags since there is no coverage there at all, but for the files that do have coverage it should be done

rdroog

comment created time in 14 days

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

Integration tests

Thanks for this @badeball ! And - you are right. Although scrolling through this PR I don't think that would cover the cypress-tags file? The remaining code is covered with tests pretty well. I will take a closer look if it makes sense for us to add all those tests. The cypress-tags was a quick hack I did for myself and figured it wouldn't hurt to add it here as well.. and now it's probably the biggest pain point of the whole project, exactly because of the lack of the tests.

badeball

comment created time in 14 days

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(cypress-tags.js): scenario outlines with examples were not correctly filtered by tags

@rdroog I did want to hand it over (fully or partially) to Cypress which would be the way to go, I hope they will still help at some point. They do make money out of this, so I wish people send their complaints their way :)

But to your point "project feels like it is in a limbo state" - We had 9 releases in the last 6 months, and comments like your is exactly what makes me less willing to work on this :) It's just unfair. I had a month vacation after a couple years of not taking any, and after that I had to focus on my professional and personal responsibilities first - that piled up. Do you think anyone else will work much more on this for free?

Besides the releases, there is quite a bit of support from me, @MateuszNowosad and @badeball which also is very different than what you get with projects in a "limbo state"

Another point - do you think it's that easy to find someone to take a project over? I wouldn't want to give it to someone that has not been actively working on this, because how do I know they won't just take it and never work on it? And if we are limiting to the people that do work on this repo, we narrow down the candidates significantly.

Yet another point - some of my clients do use this project, on some older, fixed version, it works great for them and they are not complaining. They don't care about what's going on in the issues section on github.

rkrisztian

comment created time in 14 days

issue commentTheBrainFamily/wait-for-expect

Async await usages not showing expectation library error

Sorry for that. I'm guessing the timeout is somehow exceeded, does it change anything if you change your timeout default like so:

waitForExpect.defaults.timeout = 1000;

sekhavati

comment created time in 15 days

issue commentTheBrainFamily/cypress-cucumber-preprocessor

[feature request] use tags for example tables for scenarios with more example tables

:tada: This issue has been resolved in version 4.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jimmy882

comment created time in 15 days

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(cypress-tags.js): scenario outlines with examples were not correctly filtered by tags

:tada: This PR is included in version 4.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

rkrisztian

comment created time in 15 days

release TheBrainFamily/cypress-cucumber-preprocessor

v4.3.0

released time in 15 days

created tagTheBrainFamily/cypress-cucumber-preprocessor

tagv4.3.0

Run cucumber/gherkin-syntaxed specs with cypress.io

created time in 15 days

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(cypress-tags.js): scenario outlines with examples were not correctly filtered by tags

There is something weird here, since I'm pretty sure we did have some tests for the cypress-tags, @MateuszNowosad don't you remember that as well? Anyway, as I don't really have time to investigate what happened to the tests or to verify this manually I'll just merge it and hope for the best.. The problem is that I don't personally use this project anymore, I reached out to Cypress to help with the maintenance, they've started a conversation with me but said they need time to think and it's been months since any information about this. Basically I feel like I'm doing someone else's work for free - people "vote with their feet", 10% of cypress users use this plugin, so clearly there is a demand for cypress + cucumber. More than working for free - I actually paid @MateuszNowosad from my own pocket to help with this project. But then there is so many negativity and unpleasant comments here that I'm not really motivated anymore.

rkrisztian

comment created time in 15 days

push eventTheBrainFamily/cypress-cucumber-preprocessor

rkrisztian

commit sha f177e54130ad977351f6e3dc105908a583958367

feat(cypress-tags.js): scenario outlines with examples were not correctly filtered by tags (#609) * fix(cypress-tags.js): scenario outlines with examples were not correctly filtered by tags Now the script supports filtering examples of scenario outlines too. I have removed the optimization that we should check scenario tags if there are any, because they do not work for negated tags (e.g. `not @tag1`). Additionally, just checking the feature tag itself is also wrong, because a feature with tag `@feature` having a scenario with tag `@scenario` would incorrectly run when we filter for `not @scenario`. So the best is to leave the tag checking for "leaf nodes", i.e. scenarios or examples. Also consider the corner case where a feature has no scenarios or scenario outlines at all, i.e. again we would not run such a feature at all. Fixes #196. * fixup! fix(cypress-tags.js): scenario outlines with examples were not correctly filtered by tags

view details

push time in 15 days

PR merged TheBrainFamily/cypress-cucumber-preprocessor

fix(cypress-tags.js): scenario outlines with examples were not correctly filtered by tags

Now the script supports filtering examples of scenario outlines too. I have removed the optimization that we should check scenario tags if there are any, because they do not work for negated tags (e.g. not @tag1). Additionally, just checking the feature tag itself is also wrong, because a feature with tag @feature having a scenario with tag @scenario would incorrectly run when we filter for not @scenario. So the best is to leave the tag checking for "leaf nodes", i.e. scenarios or examples. Also consider the corner case where a feature has no scenarios or scenario outlines at all, i.e. again we would not run such a feature at all.

Fixes #196.

+20 -19

9 comments

1 changed file

rkrisztian

pr closed time in 15 days

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(cypress-tags.js): scenario outlines with examples were not correctly filtered by tags

I can merge this in without testing it - are you actively using this version of the code in a project? If I was to test it, are there any things that come to your mind would be worth double-checking?

rkrisztian

comment created time in a month

fork lgandecki/graphql-php

A PHP port of GraphQL reference implementation

https://webonyx.github.io/graphql-php/

fork in a month

fork lgandecki/demo-npm-publish-slack-notifier

Demo KafkaJS application to notify Slack webhook on NPM package releases

fork in a month

issue commentTheBrainFamily/cypress-cucumber-preprocessor

Infinite test loading

Did you figure this out? :) Worth leaving a note for future googlers :)

ikrasnikov

comment created time in a month

issue commentTheBrainFamily/cypress-cucumber-preprocessor

help with regular expressions

ah, right... :-) I somehow assumed the first Given worked and the second did not.

The ^ has to go as well nonetheless (and Jonas omitted it in his example). ^ in the regex world means that the matching line has to start with whatever follows.

stevepkuo

comment created time in 2 months

issue commentTheBrainFamily/cypress-cucumber-preprocessor

help with regular expressions

Remove the ^

stevepkuo

comment created time in 2 months

issue commentTheBrainFamily/cypress-cucumber-preprocessor

Writing multiple scenarios in a feature file

Hello @stemmlerjs , I'm not sure if the Scenario syntax is available in cucumberjs (couldn't find it here https://github.com/cucumber/cucumber-js/blob/main/docs/support_files/api_reference.md ), but it seems great!

For similar reasons, we've done a similar thing but driven by convention, we called it "nonGlobalStepDefinitions". If you set that to true in your preprocessor configuration then you get a folder for step definitions that's scoped to a related feature file. It's not exactly 1:1 to what you are proposing, because the step definitions will still be reused between different scenarios of the same feature file, but it gets you close.

You can see an example here: https://github.com/TheBrainFamily/cypress-cucumber-example/tree/master/cypress/integration/socialNetworks

And there is more in our README if you look for nonGlobalStepDefinitions

@nicoaugereau thanks for your help, although I think Khalil was asking about something slightly different so I've decided to send my reply as well. :-)

stemmlerjs

comment created time in 2 months

issue commentTheBrainFamily/cypress-cucumber-preprocessor

[feature request] use tags for example tables for scenarios with more example tables

:tada: This issue has been resolved in version 4.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jimmy882

comment created time in 3 months

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(tags): fix inheritance according to cucumber specs

:tada: This PR is included in version 4.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Sonaryr

comment created time in 3 months

release TheBrainFamily/cypress-cucumber-preprocessor

v4.2.0

released time in 3 months

created tagTheBrainFamily/cypress-cucumber-preprocessor

tagv4.2.0

Run cucumber/gherkin-syntaxed specs with cypress.io

created time in 3 months

pull request commentTheBrainFamily/cypress-cucumber-preprocessor

fix(tags): fix inheritance according to cucumber specs

I've merged it as a feat instead of fix, to not introduce possibly a breaking change in a patch release.

Sonaryr

comment created time in 3 months

push eventTheBrainFamily/cypress-cucumber-preprocessor

Maarten

commit sha 2789e0b434ec9a1a360e39d864d9e020f1b028ac

feat(tags): fix inheritance according to cucumber specs (#557) According to cucumber tags should be inherited downwards see https://cucumber.io/docs/cucumber/api/#tags Co-authored-by: Maarten Schroeven <Sonaryr@users.noreply.github.com>

view details

push time in 3 months

PR merged TheBrainFamily/cypress-cucumber-preprocessor

fix(tags): fix inheritance according to cucumber specs

According to cucumber tags should be inherited downwards. See https://cucumber.io/docs/cucumber/api/#tags

fix #196

+57 -3

9 comments

4 changed files

Sonaryr

pr closed time in 3 months