profile
viewpoint
Laszlo Ersek lersek Red Hat, Inc.

libguestfs/libguestfs 458

library and tools for accessing and modifying virtual machine disk images. PLEASE DO NOT USE GITHUB FOR ISSUES OR PULL REQUESTS. See the website for how to file a bug or contact us.

libguestfs/supermin 140

tool for creating supermin appliances (formerly called febootstrap). PLEASE DO NOT USE GITHUB FOR ISSUES OR PULL REQUESTS. See the website for how to file a bug or contact us. http://libguestfs.org

libguestfs/hivex 72

windows registry hive extraction library. PLEASE DO NOT USE GITHUB FOR ISSUES OR PULL REQUESTS. See the website for how to file a bug or contact us. http://libguestfs.org

libguestfs/virt-v2v 26

Virt-v2v converts guests from foreign hypervisors to run on KVM

rwmjones/guestfs-tools 3

Testing new guestfs-tools split

lersek/qemu-ovmf-secureboot 1

Script to generate an OVMF vars file with default secure boot key enrolled.

lersek/edk2-CCodingStandardsSpecification 0

EDK II C Coding Standards Specification

lersek/edk2-codereview 0

Copy of tianocore/edk2 repo to test code review options

lersek/edk2-InfSpecification 0

EDK II INF Specification

push eventrwmjones/guestfs-tools

Laszlo Ersek

commit sha 903819ecf480bcefec108bdbd7e9bdec1b3b5a49

sysprep: remove system-local NetworkManager connection profiles (keyfiles) Add a simple (default) operation to remove /etc/NetworkManager/system-connections/*.nmconnection which arguably carry stale information after the initial creation of the system disk image. Note: no side effect callback is invoked. Before commit 576f1541a20c ("sysprep: Use customize module for customizing the guest after sysprepping.", 2014-03-25), the "delete" operation had been native to virt-sysprep ("sysprep/sysprep_operation_delete.ml"), and it didn't invoke side effects. In said commit, "delete" was delegated to virt-customize, and that was when "side_effects#created_file" was introduced (most likely) as a catch-all. (We still have the "XXX Did we?" comment today.) Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1980922 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202131006.12774-1-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 3 days

push eventlibguestfs/virt-v2v

Laszlo Ersek

commit sha 17a7f13ee74d1305ddbc71f4ad2c7735687f04d9

lib/types: introduce "Standard_VGA" constructor for "guestcaps_video_type" In order to replace QXL with Standard_VGA in small steps, bisectably, first just introduce the Standard_VGA constructor. Extend the string_of_video function at once ("stdvga"). The value returned by this function is only used for debug logging (indirectly, via the string_of_guestcaps function). The virt-v2v build flags turn "non-exhaustive pattern matching" warnings into errors. Match the new "Standard_VGA" constructor with a constant false assertion wherever an expression of type "guestcaps_video_type" is matched, in order to make this patch bisectable. These assertions will be gradually replaced with actual logic in the rest of this patch set. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-2-lersek@redhat.com>

view details

Laszlo Ersek

commit sha d07986596068795bf0e2167cf896d52e99388f0b

output: handle Standard_VGA in the libvirt XML and QEMU cmdline formats Libvirt domain XML fragment (with the default video RAM size made explicit): <video> <model type='vga' vram='16384' heads='1'/> </video> Example QEMU cmdline option: -vga std References: - https://www.kraxel.org/blog/2019/09/display-devices-in-qemu/#VGA - https://libvirt.org/formatdomain.html#video-devices Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-3-lersek@redhat.com>

view details

Laszlo Ersek

commit sha 6cd87671b12bba65448adfef9dfb1a986001b2fd

output: handle Standard_VGA in the OpenStack format Convert the Standard_VGA value of "guestcaps.gcaps_video" to the string "vga", in the OpenStack image properties. Reference: https://docs.openstack.org/glance/xena/admin/useful-image-properties.html Cc: Kashyap Chamarthy <kchamart@redhat.com> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com> Message-Id: <20211202094637.8020-4-lersek@redhat.com>

view details

Laszlo Ersek

commit sha e09c4ed9aef2b5274291a6d14965c4d2ae1c6c1a

output: handle Standard_VGA in the JSON format The JSON output mode was added in commit fba6a498d472 ("v2v: add -o json output mode", 2019-04-01). The format that it uses is by convention (aka "ad-hoc"); not governed by any public specification. Map the Standard_VGA value of "guestcaps.gcaps_video" to the "vga" string, as this is (a) straightforward and (b) consistent with the OpenStack and libvirt device model names. Cc: Fabian Deutsch <fdeutsch@redhat.com> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-5-lersek@redhat.com>

view details

Laszlo Ersek

commit sha 93bbe8914679b118ea7e9b71c11d19f0d10bb6de

convert_linux: flip target display to Standard_VGA Policy change: pick Standard_VGA over QXL for the video type in the output (Linux) domain, always. For Standard_VGA, use the "modesetting" X.org driver. (In a Fedora 34 guest using standard VGA video, and having no explicit X.org config file, the X.org server logs the following (excerpt): > Markers: (--) probed, (**) from config file, (==) default setting, > (++) from command line, (!!) notice, (II) informational, > (WW) warning, (EE) error, (NI) not implemented, (??) unknown. > (==) Matched modesetting as autoconfigured driver 0 > (==) Matched fbdev as autoconfigured driver 1 > (==) Matched vesa as autoconfigured driver 2 > (II) LoadModule: "modesetting" > (II) Loading /usr/lib64/xorg/modules/drivers/modesetting_drv.so > (II) LoadModule: "fbdev" > (II) Loading /usr/lib64/xorg/modules/drivers/fbdev_drv.so > (II) LoadModule: "vesa" > (II) Loading /usr/lib64/xorg/modules/drivers/vesa_drv.so > (II) Loading sub module "fbdevhw" > (II) LoadModule: "fbdevhw" > (II) Loading /usr/lib64/xorg/modules/libfbdevhw.so > (II) UnloadModule: "fbdev" > (II) Unloading fbdev > (II) UnloadSubModule: "fbdevhw" > (II) Unloading fbdevhw > (II) UnloadModule: "vesa" > (II) Unloading vesa This tells us that the standard VGA device model is driven by the "modesetting" driver.) Cc: Gerd Hoffmann <kraxel@redhat.com> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Acked-by: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-6-lersek@redhat.com>

view details

Laszlo Ersek

commit sha b82df41632a73aaa3af70e17d072e84b72a1560a

convert/windows_virtio: flip target display to Standard_VGA Policy change: pick Standard_VGA over either QXL or Cirrus for the video type in the output (Windows) domain, always. If the subject Windows version is entirely unsupported by "virtio-win.iso", continue warning the user, as IDE and RTL8139 are still considered inferior to virtio-blk and virtio-net, respectively. No warning is needed when only the QXL driver is missing for the subject Windows version, as Standard_VGA is not worse than QXL. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-7-lersek@redhat.com>

view details

Laszlo Ersek

commit sha 411cb33df9703ae9680e1160ec5d116557f55c2d

lib/create_ovf: fix "qxl_resourcetype" misnomer The OVF resource types 32768 and 20 have nothing to do with QXL (or with any other video controller); they stand for the *monitor* resource type. Rename the "qxl_resourcetype" variable to "monitor_resourcetype". Also document the ovirt-engine bugzilla for which resource type 32768 had been introduced to ovirt-engine (RHBZ#1534644). References: - ovirt-engine commit 4dc21c0fcf3b ("core: align hardware resource type with ovf specification", 2018-02-14) - [Libguestfs] specifying a standard VGA video controller in OVF for oVirt https://listman.redhat.com/archives/libguestfs/2021-November/msg00149.html Fixes: 5d078f1f324bc121f3aa29cb87768ffa69385b6f Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-8-lersek@redhat.com>

view details

Laszlo Ersek

commit sha 204b218c160905fc3e7d27e343a10e5b6c9813ac

lib/create_ovf: place a standard VGA video device in the OVF xml As of ovirt-engine commit daca2ca6cd91, ovirt-engine ignores <rasd:Device>qxl</rasd:Device> entirely. That's mainly because - the "rasd" namespace prefix selects the "http://schemas.dmtf.org/wbem/wscim/1/cim-schema/2/CIM_ResourceAllocationSettingData" namespace, and - that namespace does not define a Device element. Consequently, ovirt-engine picks the QXL device based on factors that are unrelated to <rasd:Device>qxl</rasd:Device>, even now. However, ovirt-engine does adhere to the plain <Device> element. Change the element from <rasd:Device> to <Device>, and change its contents from "qxl" to "vga", which ovirt-engine also recognizes already. References: - https://listman.redhat.com/archives/libguestfs/2021-November/msg00149.html - https://bugzilla.redhat.com/show_bug.cgi?id=1976607#c3 - https://bugzilla.redhat.com/show_bug.cgi?id=1976607#c4 - https://listman.redhat.com/archives/libguestfs/2021-November/msg00218.html Update: Liran is telling us that we should change the "VirtualSystem/DefaultDisplayType" element as well, from 1 to 2. Reference: - https://bugzilla.redhat.com/show_bug.cgi?id=1961107#c39 Cc: Arik Hadas <ahadas@redhat.com> Cc: Liran Rotenberg <lrotenbe@redhat.com> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-9-lersek@redhat.com>

view details

Laszlo Ersek

commit sha a1ce40ba7536bae8906a01c456d75c9bd73aa27f

lib/types: remove "QXL" constructor for "guestcaps_video_type" Removing the "QXL" constructor only needs the obvious fixup in the various pattern matches. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-10-lersek@redhat.com>

view details

Laszlo Ersek

commit sha f6eca254fbaf7c6c7d30fb9f155877be6a79a319

tests: remove the fake Windows guest drivers for the QXL device The QXL drivers no longer matter when converting Windows guests; remove the fake images and their references from the test suite. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-11-lersek@redhat.com>

view details

Laszlo Ersek

commit sha 292567bb25b9e84dab77b3a5661aff6c8da4006b

tests: remove the remaining QXL references (for completeness) Just for completeness' sake, change the display device from QXL to standard VGA in: - test-data/phony-guests/guests.xml.in - tests/test-v2v-print-source.xml.in This removes the last QXL occurrences in the source files. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-12-lersek@redhat.com>

view details

Laszlo Ersek

commit sha b2d6937b54bf99cb90970841ae66cc0de969f079

lib/types: remove "Cirrus" constructor for "guestcaps_video_type" At this point, virt-v2v only recognizes, but never creates, the "Cirrus" value of "guestcaps_video_type". Remove "Cirrus", and simplify the affected pattern matches. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-13-lersek@redhat.com>

view details

Laszlo Ersek

commit sha 17250f5164709a91bd58e754a3ecb975a4901e46

convert/windows_virtio: fix documentation of "install_drivers" return type When the "virtio_socket_supported" component was added to the "install_drivers" return tuple, the documentation was not updated. Do it now. Fixes: 05f780c16f0135c657615520c2245b42de1efc3e Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-14-lersek@redhat.com>

view details

Laszlo Ersek

commit sha b53be25f7807b12f495e1956eb34ca0ee644465a

lib/types: remove "guestcaps_video_type" The "guestcaps_video_type" variant type now has a single (non-parametric) constructor (namely "Standard_VGA"). Replace all uses of this type / constructor with (simpler) constant expressions, wherever values are necessary. Remove "guestcaps_video_type" from dependent types, where it effectively no longer carries any information. (The "string_of_video" function is only used for debugging, via "string_of_guestcaps", in "do_convert" [convert/convert.ml]). Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-15-lersek@redhat.com>

view details

Laszlo Ersek

commit sha 4d847539aa2bf3bd8483445fcd7f7c7c3cd30961

lib/types: replace "source_video" type with plain "string" The "source_video" union type is basically a string, with a distinguished constructor for the "cirrus" device model ("Source_Cirrus"). However, this distinction has been useless since commit 255722cbf39a ("v2v: Modular virt-v2v", 2021-09-07); now "Source_Cirrus" isn't treated specially. Replace the "source_video" type with just "string". Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-16-lersek@redhat.com>

view details

Laszlo Ersek

commit sha dbbdd4c20a6a7c7c497e43fbe6d536a2455b404f

lib/types: remove the "source.s_video" field Since commit 255722cbf39a ("v2v: Modular virt-v2v", 2021-09-07), the only use of the "source.s_video" field has been its logging via "string_of_source", for the "--print-source" debugging option. Given that the source video controller is available in the source domain description anyway (that's where "source.s_video" is parsed from), simplify the debug log code by removing "source.s_video". Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211202094637.8020-17-lersek@redhat.com>

view details

push time in 4 days

push eventlibguestfs/libguestfs

Laszlo Ersek

commit sha 0ab93050554212b905dd88f014412d288ec4e8c9

daemon/mkfs: disable creation of fake MBR partition table with "mkfs.fat" Search the usage output of "mkfs.fat" for "--mbr[="; cache the result for further invocations. If the option is supported, pass "--mbr=n" to "mkfs.fat". This will prevent the creation of a bogus partition table whose first (and only) entry describes a partition that contains the partition table. (Such a bogus partition table breaks "parted", which is a tool used by libguestfs extensively, both internally and in public libguestfs APIs.) Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1931821 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com> Message-Id: <20211125094954.9713-2-lersek@redhat.com>

view details

Laszlo Ersek

commit sha e3671362afc6d4494753e39762925c2ad32df8a2

daemon/9p: fix wrong pathname in error message The directory that readdir() and closedir() work on is BUS_PATH ("/sys/bus/virtio/drivers/9pnet_virtio"), not "/sys/block". Fix the error messages that are sent when readdir() or closedir() fails. (The invalid "sys/block" pathname could be a leftover from when the directory reading logic was (perhaps) copied from "daemon/sync.c".) Fixes: 5f10c3350338bbca735a74db26f98da968957bd9 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com> Message-Id: <20211125094954.9713-3-lersek@redhat.com>

view details

Laszlo Ersek

commit sha c33c2a1d13105cdd667ad14f1f36fa331d4bad61

daemon/parted: simplify print_partition_table() prototype Since commit 994ca1f8ebcc ("daemon: Reimplement 'part_get_mbr_part_type' API in OCaml.", 2018-05-02), we've not had any calls to print_partition_table() that would pass a "false" argument for the "add_m_option" parameter. Remove the parameter, and inside part_get_mbr_part_type(), remove the dead branch. Relatedly, update the comment on the "print_partition_table_machine_readable" OCaml function, originally from commit 32e661f42169 ("daemon: Reimplement ‘part_list’ API in OCaml.", 2017-07-27). Because print_partition_table() now passes "-m" to "parted" unconditionally, and there are no use cases left that would *forbid* "-m", "print_partition_table_machine_readable" is almost equivalent to print_partition_table() -- modulo the enforcement of the "BYT;" header. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com> Message-Id: <20211125094954.9713-4-lersek@redhat.com>

view details

Laszlo Ersek

commit sha edfebee4046ae3b67c2566bbae8bc3bf4e577b95

daemon/parted: work around part table type misreporting by "parted" "parted" incorrectly reports "loop" rather than "msdos" for the partition table type, when the (fake) partition table comes from the "--mbr" option of "mkfs.fat" (in dosfstools-4.2+), and the FAT variant in question is FAT16 or FAT32. (See RHBZ#2026224.) Work this around by - parsing the partition table ourselves, and - overriding "loop" with "msdos" when appropriate. Note that when the FAT variant is FAT12, "parted" fails to parse the fake MBR partition table completely (see RHBZ#2026220), which we cannot work around. However, FAT12 should be a rare corner case in libguestfs usage -- "mkfs.fat" auto-chooses FAT12 only below 9MB disk size, and even "-F 12" can only be forced up to and including 255MB disk size. Add the helper function "has_bogus_mbr" to the Utils module; we'll use it elsewhere too. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1931821 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com> Message-Id: <20211125094954.9713-5-lersek@redhat.com> [lersek@redhat.com: drop "fun" keyword, and use partial application, in the definition of "sec0at" [Rich]]

view details

Laszlo Ersek

commit sha d829f9ff9ae039ca25f22244c36066ba47be3b72

daemon/listfs: don't call "sgdisk -i" on bogus MBR partition table entry The "is_partition_can_hold_filesystem" function calls "Parted.part_get_gpt_type" on the partition if: - the partition table type is GPT, - or the partition table type is MBR, and the partition is primary or logical. The one entry in the fake MBR partition table described in the previous patch passes the second branch of this check, therefore "Parted.part_get_gpt_type" is reached, and it invokes "sgdisk -i 1" on the disk. Surprisingly (not), while "sgdisk -i" copes fine with valid MBR partition tables, it chokes on the fake one. The output does not contain the "Partition GUID code" line, and so "sgdisk_info_extract_field" throws an exception. Prevent calling "Parted.part_get_gpt_type" on a bogus MBR partition table, similarly to the "extended entry in MBR partition table" case; the difference is that the bogus primary entry, unlike a valid extended entry, *can* hold a filesystem. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1931821 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com> Message-Id: <20211125094954.9713-6-lersek@redhat.com>

view details

push time in 10 days

issue commentdosfstools/dosfstools

mkfs.vfat 4.2 on a whole block device adds bogus partition table

In response to https://github.com/dosfstools/dosfstools/issues/161#issuecomment-784200231 @pali

The issue is the partiition table is wrong, it's a partition table containing a partition which references itself.

Well, I do not see nothing wrong with it. Kernel correctly handles it and also other standard tools.

parted is arguably a standard tool, and it does not handle the bogus partition table created by recent mkfs.fat.

# parted -m -s -- /dev/loop0 unit b print
Error: Invalid partition table - recursive partition on /dev/loop0.
BYT;
/dev/loop0:1048576B:loopback:512:512:unknown:Loopback device:;
rwmjones

comment created time in 13 days

issue commentunixwork/xnedit

request for "open" and "save-as" dialog enhancements

@unixwork thanks a lot for implementing this change. I've been busy with other things. I hope I can test this enhancement in the near future. Thank you.

lersek

comment created time in a month

push eventlibguestfs/virt-v2v

Laszlo Ersek

commit sha 17e7cbffb9e5dad526dc8f63dc771aa15b306888

lib/types: remove "source video: QXL" constructor * Background: We intend to stop virt-v2v from outputting converted domains with a QXL display device [1]. The reason is that QXL is a complex device model with a large security attack surface, while at the same time, better device models exist with regard to either guest compatibility, or graphics acceleration. Namely, if compatibility takes priority, standard VGA is at least as widely supported by guests [2] [3] [4], with lesser security risks. And if graphics performance takes priority, then 2D acceleration is generally considered obsolete, and virtio-vga is where new 3D features are being developed [5]. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1961107#c1 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1961107#c2 [3] https://www.kraxel.org/blog/2019/09/display-devices-in-qemu/#qxl-vga [4] https://www.kraxel.org/blog/2019/09/display-devices-in-qemu/#VGA [5] https://www.kraxel.org/blog/2019/09/display-devices-in-qemu/#virtio-vga For virt-v2v in particular, compatibility is what matters, so standard VGA will ultimately supplant QXL in newly converted domains. * About this patch: In order to get the ball rolling, remove the "Source_QXL" constructor of the "source_video" union type. "Source_QXL" was originally introduced in commit [6], and then put to use in commit [7], specifically for the sake of in-place conversions, so that the "input" QXL display device serve as a distinguished hint for the "output" domain (after conversion). With the modularization of virt-v2v in commit [8], in-place conversion has been (temporarily) removed. Therefore, "Source_QXL" is functionally dead code, at the time of writing. [6] 04af2bc3cd2c ("v2v: collect source network and video adapter types", 2016-03-24) [7] 3c21ad036296 ("v2v: in-place: request caps based on source config", 2016-03-24) [8] 255722cbf39a ("v2v: Modular virt-v2v", 2021-09-07) "Functionally dead" means that, mentions of the QXL display device in the *source* domain descriptions of the test suite can be satisfied by the parametric "Source_other_video of string" constructor just as well; there is no actual functionality attached to "Source_QXL" at the moment. And once we reimplement in-place conversion for modular virt-v2v, we'll still want to flip domains that use QXL to standard VGA (see the background above). (Further patches are expected for RHBZ#1961107.) Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211020163503.9525-1-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in a month

push eventrwmjones/guestfs-tools

Laszlo Ersek

commit sha aefdf0dcd4954b822e6a098f7258899f1b6a72b7

virt-inspector.rng: recognize "kalilinux" and "msdos" distros As of libguestfs @ e597fc5317e0, the "string_of_distro" function [daemon/inspect_types.ml] may output "kalilinux" and "msdos" beyond what "virt-inspector.rng" currently accepts. Add these distro identifiers to "virt-inspector.rng" now. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211013163043.21837-2-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha f041a5e24d8c5850daf7ad8f8e1a284e0445266b

virt-inspector.rng: Add support for Kylin (RHBZ#1995391). Similar-to: b8bc491ff59cc1cc24a1935be99cee0c5edfb5be Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211013163043.21837-3-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 2 months

push eventlibguestfs/libguestfs

Laszlo Ersek

commit sha 305b02e7e74afc3777b2291783cd7634fb76ecaf

daemon: inspection: Add support for Kylin (RHBZ#1995391). Similar-to: cd08039d2427b584237265237c713d8cf46536a0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211013163023.21786-1-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 2 months

push eventlibguestfs/libguestfs

Laszlo Ersek

commit sha 54187b7f98776b30db7e52e0a049f0f88867a66a

build: fix the pkg-config identifier of the (optional) Yara library The upstream Yara project has always provided its "libyara/yara.pc.in" file with "Name: yara" -- ever since its introduction in commit 334bd1a671ca ("Add support for pkg-config", 2015-01-08). In spite of this, when the (optional) Yara dependency was added to libguestfs in commit 2e24129da376 ("appliance: add yara dependency", 2017-05-02), PKG_CHECK_MODULES was invoked with [libyara] as list-of-modules. (That was clearly a bug. I'm unsure what Debian calls their Yara pkg-config module, but calling it anything else than "yara" would be a distribution bug: upstream projects provide pkg-config files specifically so that dependent projects can find their dependencies *regardless of distribution*.) As a consequence, on Fedora today, the PKG_CHECK_MODULES macro always fails, and only the AC_CHECK_LIB / AC_CHECK_HEADER branch finds Yara. In a subsequent patch, we'll want to add a version requirement to the PKG_CHECK_MODULES macro invocation, so at first, fix the pkg-config identifier of Yara. Fixes: 2e24129da37656706b5a1d3b6bc83d4c089740bb Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211013133611.21599-2-lersek@redhat.com> Acked-by: Eric Blake <eblake@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 4daec34a01b89fddf5f85de62a6c4b4a01823c37

build: eliminate the AC_CHECK_LIB / AC_CHECK_HEADER tests for Yara Eliminate the AC_CHECK_LIB / AC_CHECK_HEADER tests for Yara, for the following reasons: - Upstream Yara has provided a pkg-config file since 2015, so the (now-fixed) pkg-config check should always find it, without the AC_CHECK_LIB / AC_CHECK_HEADER fallback branch. - In a subsequent patch, we'll want to test for the incompatible Yara API changes described at <https://github.com/VirusTotal/yara/wiki/Backward-incompatible-changes-in-YARA-4.0-API>. That's easy to do with pkg-config, but impossible with AC_CHECK_*, without a custom test. Namely, both AC_CHECK_DECLS and AC_CHECK_TYPES appear unable to check the parameter list of a function pointer typedef (namely YR_CALLBACK_FUNC and YR_COMPILER_CALLBACK_FUNC). And writing a dedicated test for this is overkill. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211013133611.21599-3-lersek@redhat.com> Acked-by: Eric Blake <eblake@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha f34bd6b12f85b7100e7e103cacc857cd5d820880

build, docs: spell out minimum version (4.0.0) for the (optional) Yara lib Commit e597fc5317e0 ("daemon/yara: fix undefined behavior due to Yara 4.0 API changes", 2021-10-12) prevents the daemon from using such a Yara version that precedes 4.0.0. If only yara < 4 is found, treat the library as absent, rather than attempting and failing to compile the yara module of the daemon. Note the version requirement in the documentation too. Suggested-by: Eric Blake <eblake@redhat.com> Suggested-by: Richard W.M. Jones <rjones@redhat.com> Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211013133611.21599-4-lersek@redhat.com> Acked-by: Eric Blake <eblake@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 2 months

push eventlibguestfs/virt-v2v

Laszlo Ersek

commit sha 7ce5df273be304ec3ba87e46319cf78275eb4990

build: fix typo in "--enable-werror" help string Fixes: af9251086030886580cd5243afabf726d5e50fdc Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211012160824.8488-1-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 2 months

push eventlibguestfs/libguestfs

Laszlo Ersek

commit sha 7915938b8e0664316fbbe78bc70213268ec80ba6

build: fix typo in "--enable-werror" help string While <https://libguestfs.org/guestfs-building.1.html> correctly documents the "--enable-werror" option, the "./configure" help text itself doesn't. Replace "--enable-error" with "--enable-werror" now. Fixes: 0f54df53d26e4c293871fb30bce88511e1d61d6c Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211011223627.20856-2-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 98ed0243e773cc66e074da26caffe7312d143fef

lib/proto: suppress "may be used uninitialized" in send_file_complete() gcc emits the following warning: > proto.c: In function ‘send_file_complete’: > proto.c:437:10: error: ‘buf’ may be used uninitialized > [-Werror=maybe-uninitialized] > 437 | return send_file_chunk (g, 0, buf, 0); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In theory, passing the 1-byte array "buf", with indeterminate contents, to xdr_bytes() ultimately, could be fine -- assuming xdr_bytes() never reads the contents of the buffer, due to the buffer size being zero. However, the xdr_bytes() manual does not seem to guarantee this (it also does not explicitly permit passing a NULL buffer alongside size=0, which would be even simpler for the caller). In order to shut up the compiler, just zero-initialize the buffer -- that's simpler than adding diagnostics pragmas. The "maybe-uninitialized" warning is otherwise very useful, so keep it globally enabled (per WARN_CFLAGS / WERROR_CFLAGS). Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211011223627.20856-3-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha e597fc5317e018c259c75eb475cf6668e07236d1

daemon/yara: fix undefined behavior due to Yara 4.0 API changes Currently, the Yara test case ("yara/test-yara-scan.sh") fails, with the following obscure error message: > ><fs> yara-scan /text.txt > libguestfs: error: deserialise_yara_detection_list: Namely, the Yara rule match list serialization / de-serialization, between the daemon and the library, is broken. It is caused by the following incompatible pointer passing (i.e., undefined behavior), in function do_internal_yara_scan(), file "daemon/yara.c": > r = yr_rules_scan_fd (rules, fd, 0, yara_rules_callback, (void *) path, 0); ^^^^^^^^^^^^^^^^^^^ The prototype of yara_rules_callback() is: > static int > yara_rules_callback (int code, void *message, void *data) however, in Yara commit 2b121b166d25 ("Track string matches using YR_SCAN_CONTEXT.", 2020-02-27), which was included in the upstream v4.0.0 release, the rules callback prototype was changed as follows: > diff --git a/libyara/include/yara/types.h b/libyara/include/yara/types.h > index cad095cd70c2..f415033c4aa6 100644 > --- a/libyara/include/yara/types.h > +++ b/libyara/include/yara/types.h > @@ -661,6 +644,7 @@ struct YR_MEMORY_BLOCK_ITERATOR > > > typedef int (*YR_CALLBACK_FUNC)( > + YR_SCAN_CONTEXT* context, > int message, > void* message_data, > void* user_data); Therefore, the yara_rules_callback() function is entered with a mismatched parameter list in the daemon, and so it passes garbage to send_detection_info(), for serializing the match list. This incompatible change was in fact documented by the Yara project: https://github.com/VirusTotal/yara/wiki/Backward-incompatible-changes-in-YARA-4.0-API#scanning-callback Gcc too warns about the incompatible pointer type, under "-Wincompatible-pointer-types". However, libguestfs is built without "-Werror" by default, so the warning is easy to miss, and the bug only manifests at runtime. (The same problem exists for yr_compiler_set_callback() / compile_error_callback(): https://github.com/VirusTotal/yara/wiki/Backward-incompatible-changes-in-YARA-4.0-API#compiler-callback except that this instance of the problem is not triggered by the test case, as the rule list always compiles.) Rather than simply fixing the parameter lists, consider the following approach. If Yara's YR_CALLBACK_FUNC and YR_COMPILER_CALLBACK_FUNC typedefs were not for *pointer* types but actual *function* prototypes, then we could use them directly in the declarations of our callback functions. Then any future changes in the param lists would force a "conflicting types" *compilation error* (not a warning). Illustration: /* this is *not* a pointer type */ typedef int HELLO_FUNC (void); /* function declarations */ static HELLO_FUNC my_hello_good; static HELLO_FUNC my_hello_bad; /* function definition, with explicit parameter list */ static int my_hello_good (void) { return 1; } /* function definition with wrong param list -> compilation error */ static int my_hello_bad (int i) { return i; } Unfortunately, given that the Yara-provided typedefs are already pointers, we can't do this, in standard C anyway. Type derivation only allows for array, structure, union, function, and pointer type derivation; it does not allow "undoing" previous derivations. However, using gcc's "typeof" keyword, the idea is possible. Given YR_CALLBACK_FUNC, the expression (YR_CALLBACK_FUNC)NULL is a well-defined null pointer, and the function designator expression *(YR_CALLBACK_FUNC)NULL has the desired function type. Of course, evaluating this expression would be undefined behavior, but in the GCC extension expression typeof (*(YR_CALLBACK_FUNC)NULL) the operand of the "typeof" operator is never evaluated, as it does not have a variably modified type. We can therefore use this "typeof" in the same role as HELLO_FUNC had in the above example. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211011223627.20856-4-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com> [lersek@redhat.com: clean up whitespace in "YR_RULE *rule"]

view details

push time in 2 months

push eventlibguestfs/libguestfs

Laszlo Ersek

commit sha 3f6f2fb8f6997e5e993d0e493470323476f33243

daemon/inspect_fs_unix: recognize modern Pardus GNU/Linux releases Recent Pardus releases seem to have abandoned the original "/etc/pardus-release" file, which the current Pardus detection, from commit 233530d3541d ("inspect: Add detection of Pardus.", 2010-10-29), is based upon. Instead, Pardus apparently adopted the "/etc/os-release" specification <https://www.freedesktop.org/software/systemd/man/os-release.html>, with "ID=pardus". Extend the "distro_of_os_release_id" function accordingly. Keep the original method for recognizing earlier releases. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1993842 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20211001125338.8956-1-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 2 months

push eventlibguestfs/virt-v2v

Laszlo Ersek

commit sha 3767ebca30c5b13775ef17a04ed44212f50655fe

Makefile.am: use $(LIBNBD_LIBS) for linking OCaml programs Otherwise the build fails with errors such as > GEN helper-v2v-output > /usr/bin/ld: cannot find -lnbd > collect2: error: ld returned 1 exit status > File "caml_startup", line 1: > Error: Error during linking (exit code 1) in the "convert", "output" and "v2v" modules. (This patch is similar to guestfs-tools commit 9b0f2e2d5893 ("Makefile.am: use $(LIBGUESTFS_LIBS) for linking OCaml programs", 2021-09-06).) Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210927063458.4824-2-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 5adf437bcc00586961d8aa058559f86eb5165149

test-v2v-i-ova: spell out viosock element in output domain XML This is likely an omission from commit 05f780c16f01 ("v2v: support configuration of viosock driver", 2021-02-26) -- if the converted Windows guest does not dispose over the virtio-sock guest drivers, an explicit "none"-model element is now generated in the domain XML. Fixes: 05f780c16f0135c657615520c2245b42de1efc3e Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210927063458.4824-5-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 2 months

push eventlibguestfs/libguestfs

Laszlo Ersek

commit sha e2f8db27d0af5217eb5d0487e0713309559d4489

Go bindings: fix "C array of strings" -- char** -- allocation The current "arg_string_list" and "free_string_list" implementations go back to commit b6f01f32606d ("Add Go (language) bindings.", 2013-07-03). There are two problems with them: - "free_string_list" doesn't actually free anything, - at the *first* such g.Internal_test() call site that passes an Ostringlist member inside the Optargs argument, namely: > g.Internal_test ("abc", > string_addr ("def"), > []string{}, > false, > 0, > 0, > "123", > "456", > []byte{'a', 'b', 'c', '\000', 'a', 'b', 'c'}, > &guestfs.OptargsInternal_test{Ostringlist_is_set: true, > Ostringlist: []string{} > } > ) the "golang/run-bindtests" case crashes: > panic: runtime error: cgo argument has Go pointer to Go pointer > > goroutine 1 [running]: > libguestfs.org/guestfs.(*Guestfs).Internal_test.func7(0xc000018180, > 0xadfb60, 0xadfb80, 0xc000010048, 0x0, 0x0, 0x0, 0xae3e10, 0xae3e30, > 0xade3a0, ...) > golang/src/libguestfs.org/guestfs/guestfs.go:6729 +0xa9 > libguestfs.org/guestfs.(*Guestfs).Internal_test(0xc000018180, 0x4ee3a5, > 0x3, 0xc000061be8, 0xc000061af8, 0x0, 0x0, 0xc000061a00, 0x0, 0x0, ...) > golang/src/libguestfs.org/guestfs/guestfs.go:6729 +0x3c9 > main.main() > golang/bindtests/bindtests.go:77 +0x151e > exit status 2 > FAIL run-bindtests (exit status: 1) In Daniel P. Berrangé's words [1], > You're allowed to pass a Go pointer to C via CGo, but the memory that > points to is not allowed to contained further Go pointers. So the struct > fields must strictly use a C pointer. One pattern to solve the problem has been shown on stackoverflow [2]. Thus, rewrite the "arg_string_list" and "free_string_list" functions almost entirely in C, following that example. While this approach is not the most idiomatic Go, as a solution exists without C helper functions [3], it should still be acceptable, at least as an incremental improvement, for letting "golang/run-bindtests" pass. [1] https://listman.redhat.com/archives/libguestfs/2021-September/msg00118.html [2] https://stackoverflow.com/questions/35924545/golang-cgo-panic-runtime-error-cgo-argument-has-go-pointer-to-go-pointer [3] https://listman.redhat.com/archives/libguestfs/2021-September/msg00106.html Cc: "Daniel P. Berrangé" <berrange@redhat.com> Cc: "Richard W.M. Jones" <rjones@redhat.com> Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210921192939.32468-1-lersek@redhat.com> Tested-by: "Richard W.M. Jones" <rjones@redhat.com> Acked-by: "Richard W.M. Jones" <rjones@redhat.com>

view details

push time in 2 months

push eventlersek/edk2

Abner Chang

commit sha a7cf2c5664b9605162b20ab6b51c7bdcab3e14f0

RedfishPkg: Fix various typos Fix various typos in comments and documentation. Signed-off-by: Cheng Zhou <zhoucheng@phytium.com.cn> Reviewed-by: Nickle Wang <nickle.wang@hpe.com> Cc: Abner Chang <abner.chang@hpe.com> Reviewed-by: Abner Chang <abner.chang@hpe.com>

view details

Sravanthi

commit sha 851785ea676b4a8899b4b997679f96d4c81002bc

UefiPayloadPkg: Include more modules in UefiPayloadPkg. Include core modules in UefiPayloadPkg.dsc and UefiPayloadPkg.fdf Cc: Guo Dong <guo.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Signed-off-by: Sravanthi <k.kavyax.sravanthi@intel.com>

view details

Sravanthi

commit sha d248516b3a190c5cb5d51164b5721ead9d24469a

UefiPayloadPkg: Include Network modules in UefiPayloadPkg. Include Network modules in UefiPayloadPkg.dsc and UefiPayloadPkg.fdf Cc: Guo Dong <guo.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Signed-off-by: Sravanthi <k.kavyax.sravanthi@intel.com>

view details

Ashraf Ali S

commit sha 6c7d6d4a5e0b69a52e65785f308be0e8ad5fcc96

UefiCpuPkg: ResetVector Tool Support for Python 3 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3506 Build Scrips for Reset Vector currently based on Python 2 which is already EOL, needs to modify the build script based on Python 3 Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Cc: Debkumar De <debkumar.de@intel.com> Cc: Harry Han <harry.han@intel.com> Cc: Catharine West <catharine.west@intel.com> Cc: Sangeetha V <sangeetha.v@intel.com> Signed-off-by: Ashraf Ali S <ashraf.ali.s@intel.com>

view details

Ashraf Ali S

commit sha cf7c65059202e7858fbc00ce1f163ee243947e08

UefiCpuPkg: ResetVector Tool additional debug prints REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3506 Before executing the nasm command, added print statement to know what commands are executing. before printing the output file need check the status of command which is executed. if the status is 0 then only print the output file name. Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Cc: Debkumar De <debkumar.de@intel.com> Cc: Harry Han <harry.han@intel.com> Cc: Catharine West <catharine.west@intel.com> Cc: Sangeetha V <sangeetha.v@intel.com> Signed-off-by: Ashraf Ali S <ashraf.ali.s@intel.com>

view details

duntan

commit sha d96df7e993b318527e92407d0fbe9600a5b7a9a9

UefiPayloadPkg: Fix the bug in dump guid HOB info functions The input HobLength of PrintHandler should be data size instead of whole length of HOB Cc: Guo Dong <guo.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com> Signed-off-by: Dun Tan <dun.tan@intel.com>

view details

duntan

commit sha dcd3d63f4f77da5540bfe35d8ccb040d70644568

UefiPayloadPkg: Dump hob info from gEdkiiBootManagerMenuFileGuid V1: Dump this hob infomation from gEdkiiBootManagerMenuFileGuid V2: Delete the duplicated assertions V3: Add input parameter in Comment Cc: Guo Dong <guo.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com> Signed-off-by: Dun Tan <dun.tan@intel.com>

view details

Stefan Berger

commit sha 610d8073f29f30aa2f9dd58fe9d59e0dc979d085

SecurityPkg/TPM: Import PeiDxeTpmPlatformHierarchyLib.c from edk2-platforms Import PeiDxeTpmPlatformHierarchyLib from edk2-platforms without any modifications. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

view details

Stefan Berger

commit sha 4d5f39cd2218a67d253212307ec892a178d76798

SecurityPkg/TPM: Fix bugs in imported PeiDxeTpmPlatformHierarchyLib Fix some bugs in the original PeiDxeTpmPlatformHierarchyLib.c. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

view details

Stefan Berger

commit sha ebbc8ab2cd047facf17bb11856f8c8001bbb6c63

SecrutiyPkg/Tcg: Import Tcg2PlatformDxe from edk2-platforms Import Tcg2PlatformDxe from edk2-platforms without any modifications. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

view details

Stefan Berger

commit sha 2906e572c6cb792fa1bbc688358fe2fab9173983

SecurityPkg/Tcg: Make Tcg2PlatformDxe buildable and fix style issues Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

view details

Stefan Berger

commit sha f108178c569c189b4a63417b50154c51ed1b986a

SecurityPkg: Introduce new PCD PcdRandomizePlatformHierarchy Introduce the new PCD gEfiSecurityPkgTokenSpaceGuid.PcdRandomizePlatformHierarchy. We need it for TpmPlatformHierarchyLib. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

view details

Stefan Berger

commit sha a4867dea2abe2a432a1a5c7e568a2b0a6e98c658

SecurityPkg/Tcg: Import Tcg2PlatformPei from edk2-platforms Import Tcg2PlatformPei from edk2-platforms without any modifications. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

view details

Stefan Berger

commit sha 2fa89c8e11b037a938fba167343c9bf72c78dfbf

SecurityPkg/Tcg: Make Tcg2PlatformPei buildable and fix style issues Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

view details

Stefan Berger

commit sha 3b69fcf5f849021aa3bc810f8100ea71c03019e5

SecurityPkg: Add references to header and inf files to SecurityPkg Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

view details

Michael Kubacki

commit sha 6c80564b8982cd669324097346ce646b01031629

MdeModulePkg/Core/Pei: Fix typo in function descriptions Corrects a typo in the return value description of MigratePeim() and EvacuateTempRam(): "Succesfully" to "Successfully" Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Dandan Bi <dandan.bi@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

view details

Michael Kubacki

commit sha 6f501a7c9bb196ce1ad9dd5b0024974d1b6784be

MdeModulePkg/Core/Pei: Make migrated PEIM message verbose Currently, the debug message that prints the name of a PEIM being migrated is DEBUG_INFO while similar messages are DEBUG_VERBOSE. This change updates the print level to DEBUG_VERBOSE for consistency. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Dandan Bi <dandan.bi@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

view details

Michael Kubacki

commit sha c19d18136ef920e3e84f961e2a335a41147adcb8

MdeModulePkg/Core/Pei: Fix pointer size mismatch in EvacuateTempRam() REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3512 In 32-bit PEI, the local variable pointers MigratedFvHeader and RawDataFvHeader in EvacuateTempRam() will be 32-bit in size. The pointers are currently passed to PeiServicesAllocatePages() which expects a 64-bit output buffer of type EFI_PHYSICAL_ADDRESS. When PeiServicesAllocatePages() writes to the buffer, the data can overflow. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Dandan Bi <dandan.bi@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

view details

Tan, Dun

commit sha f4e72cf9d665a8f1a54170b0b62739a628823c8b

UefiPayloadPkg: Add script to build UniversalPayload in UefiPayloadPkg V1: Add script to build UniversalPayload, which can be used after edksetup rebuild The final UPL.elf will be located at root folder of edk2 V2: Revise the ouput directory of generated files and coding style in the script Cc: Guo Dong <guo.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Bob Feng <bob.c.feng@intel.com> Signed-off-by: Dun Tan <dun.tan@intel.com>

view details

Tan, Dun

commit sha bda3546c55e807c5d10ca9ecb5c664c184144c98

UefiPayloadPkg: Fix the warning when building UefiPayloadPkg with IA32+X64 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3603 Move the unspecified PCDs from .common section. to .X64 section in .dsc file. The corresponding PCDs are not used in IA32. Cc: Guo Dong <guo.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Signed-off-by: Dun Tan <dun.tan@intel.com>

view details

push time in 2 months

push eventlibguestfs/libguestfs

Laszlo Ersek

commit sha 8156c16520624b7f82cac5829efe975951f4b153

test-9p: fix the base directory that's exported to the guest In commit 6d32773e8118 ("tests: Run the tests in parallel.", 2021-03-18), the "abs_srcdir" macro value that the 9p test would see changed from ".../tests/9p" to just ".../tests" -- the last component got dropped. (Said commit updated some "abs_srcdir"-based references accordingly, for example under "tests/disks", but "tests/9p/test-9p.sh" was missed.) Therefore, the guest-visible location of the "/test-9p.sh" file changed to "/9p/test-9p.sh", and a non-recursive listing of the guest-visible root directory would not return the file. Thus, the test fails now. Restore the host-side base directory to ".../tests/9p". Fixes: 6d32773e811882f78dbd8c2a39a2b7a9c3cfca7c Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210920052335.3358-2-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 24f98939ae0cb05f4b400192de03fa3cd6f0635f

test-md-and-lvm-devices: work around RAID0 regression in Linux v3.14/v5.4 The "test-md-and-lvm-devices" test case creates, among other things, a RAID0 array (md127) that spans two *differently sized* block devices (sda1: 20MB, lv0: 16MB). In Linux v3.14, the layout of such arrays was changed incompatibly and undetectably. If an array were created with a pre-v3.14 kernel and assembled on a v3.14+ kernel, or vice versa, data could be corrupted. In Linux v5.4, a mitigation was added, requiring the user to specify the layout version of such RAID0 arrays explicitly, as a module parameter. If the user fails to specify a layout version, the v5.4+ kernel refuses to assemble such arrays. This is why "test-md-and-lvm-devices" currently fails, with any v5.4+ appliance kernel. Until we implement a more general solution (see the bugzilla link below), work around the issue by sizing sda1 and lv0 identically. For this, increase the size of sdb1 to 24MB: when one 4MB extent is spent on LVM metadata, the resultant lv0 size (20MB) will precisely match the size of sda1. This workaround only affects sizes, and does not interfere with the original purpose of this test case, which is to test various *stackings* between disk partitions, software RAID (md), and LVM logical volumes. Related: https://bugzilla.redhat.com/show_bug.cgi?id=2005485 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210920052335.3358-3-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com> [lersek@redhat.com: remove stray empty line]

view details

Laszlo Ersek

commit sha 627f808e4b0ab398a149c8d39ebe7157c38e67c7

tests: xfs: remove lazy-counter disablement test According to xfs_admin(8): > -c 0|1 Enable (1) or disable (0) lazy-counters in the filesys‐ > tem. > > Lazy-counters may not be disabled on Version 5 su‐ > perblock filesystems (i.e. those with metadata CRCs en‐ > abled). > > [...] According to mkfs.xfs(1): > -m global_metadata_options > Section Name: [metadata] > These options specify metadata format options that ei‐ > ther apply to the entire filesystem or aren't easily > characterised by a specific functionality group. The > valid global_metadata_options are: > > [...] > > crc=value > This is used to create a filesystem which > maintains and checks CRC information in all > metadata objects on disk. The value is ei‐ > ther 0 to disable the feature, or 1 to en‐ > able the use of CRCs. > > [...] > > By default, mkfs.xfs will enable metadata > CRCs. Consistently with the above, the first "xfs_admin" test case in "generator/actions_core.ml", which attempts to disable lazy counters, always fails: > 534/550 test_xfs_admin_0 > libguestfs: error: xfs_admin: /dev/sda1: Cannot disable lazy-counters on V5 fs We can resolve this test failure in three ways: (1) Extend do_mkfs() [daemon/mkfs.c], possibly even introduce do_mkfs_xfs(), and permit the caller to specify "-m crc=0" for mkfs.xfs. Then use this option when the temporary filesystem is created in the XFS test that disables lazy counters. (2) Extend the "guestfs_int_xfsinfo" structure in the libguestfs-common project, with an "xfs_crc" field. Extend parse_xfs_info() [daemon/xfs.c] to populate the field from "meta-data=...crc=[01]". Modify the test case to check the following post-condition: xfs_crc || xfs_lazycount == 0 instead of the current xfs_lazycount == 0 effectively ignoring "xfs_lazycount" when "xfs_crc" is set. (3) Remove the test altogether that attempts to disable lazy counters after filesystem creation. Given that new XFS filesystems are created with metadata CRCs enabled by default, and several XFS features depend on metadata CRCs being enabled, this patch implements option (3). Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210920052335.3358-4-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 2 months

issue commentunixwork/xnedit

request for "open" and "save-as" dialog enhancements

Thank you!

lersek

comment created time in 2 months

issue commentkdave/btrfs-progs

Defrag -c is broken with progs-5.14

Clearly commit f3a132fa1b8cd was never tested (in isolation anyway), as every possible return value from the new parse_compress_type() function, namely BTRFS_COMPRESS_ZLIB, BTRFS_COMPRESS_LZO, BTRFS_COMPRESS_ZSTD, -EINVAL, was going to be nonzero, and as such, there would be no way for parse_compress_type_arg() to succeed.

Forza-tng

comment created time in 3 months

push eventlibguestfs/hivex

Laszlo Ersek

commit sha d5a522c0bb738efdd7cc1e762840b579fc9ea3de

lib: write: improve key collation compatibility with Windows There are multiple problems with using strcasecmp() for ordering registry keys: (1) strcasecmp() is influenced by LC_CTYPE. (2) strcasecmp() cannot implement case conversion for multibyte UTF-8 sequences. (3) Even with LC_CTYPE=POSIX and key names consisting solely of ASCII characters, strcasecmp() converts characters to lowercase, for comparison. But on Windows, the CompareStringOrdinal() function converts characters to uppercase. This makes a difference when comparing a letter to one of the characters that fall between 'Z' (0x5A) and 'a' (0x61), namely {'[', '\\', ']', '^', '_', '`'}. For example, 'c' (0x63) > '_' (0x5F) 'C' (0x43) < '_' (0x5F) Compare key names byte for byte, eliminating problems (1) and (3). Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1648520 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210909230617.31256-1-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 3 months

issue commentunixwork/xnedit

request for "open" and "save-as" dialog enhancements

Hi Olaf, I've checked at 4a588e237955.

A shortcut like Ctrl+L would be appreciated, because in NEdit 5.7, when the Save File As dialog appears, the focus is owned at once by the New FIle Name field.

Furthermore, a regression (relative to NEdit 5.7): when I save a file by typing its full pathname in the Save File As dialog, if the file already exists, it is silently overwritten. In this situation, NEdit 5.7 asks for confirmation. (NB the lack of confirmation is not specific to typing the full pathname -- if I select the existent file from the Files list, it is silently overwritten just the same.)

Another slight inconvenience is that the specific widget to enter the full pathname is not consistent between the Open File and the Save File As dialogs. In NEdit 5.7, both dialogs are very similar (the only difference seems to be that Save File As has a set of Format radio buttons), meaning that the user can type or paste the complete pathname in the same text entry widget -- the one at the bottom of the dialog. Whereas in XNEdit at 4a588e237955, while the Save File As dialog still offers the full pathname text entry at the bottom, the Open File dialog now offers it at the top, basically as a second function for the directory navigation line. I've found it confusing. (Perhaps with a dedicated keyboard shortcut like Ctrl+L, I wouldn't have to look for the field, just type the shortcut more or less blindly.)

... I hope it's acceptable for me to report my findings -- I don't want to sound entitled. I'd been an open source maintainer for more or less a decade; I know what it means. If you wouldn't like to receive feedback like this, I'm 100% OK to shut up. I know you must be doing xnedit for fun, in your free time. Thank you again for enabling UTF-8 / Unicode in it!

lersek

comment created time in 3 months

push eventlibguestfs/hivex

Laszlo Ersek

commit sha f9c3ce3fd1b288b90df9de8d303edf94335903e2

build: do not look for headers in "$(top_builddir)/lib" The "hivex.h" public library header is generated when "autogen.sh" is run. Thus, for example, "hivex.h" is part of the tarball distribution that is created by "make dist". When plain "make" is invoked (for building the project), "hivex.h" already exists, namely in "$(top_srcdir)/lib". "make" does not generate *any* header files in "$(top_builddir)/lib" (which, for out-of-tree builds, stands for a different pathname than "$(top_srcdir)/lib" does). Remove the useless "-I$(top_builddir)/lib" options from the lib, perl, and python makefiles, preserving the proper "-I$(top_srcdir)/lib" ones. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908132758.18575-2-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha b017b6c3b972e43d7f2b0a1355a092119629a8ca

build: expose public library header "hivex.h" without "lib" contents Move the public library header "hivex.h" from "lib" to "include". In the "lib", "sh" and "xml" subdirectories, some of the library-internal header files ("byte_conversions.h", "gettext.h", "hivex-internal.h", "mmap.h") are consumed. There, let the new "include" directory extend -- and not replace -- the existent "lib" directory. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908132758.18575-3-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha c20f54b0a89fc5dc6f6a545efff67cc2c91d93fa

build: remove "hivex.pc" from EXTRA_DIST The "configure" script creates "hivex.pc" in the build directory from "hivex.pc.in"; there's no need to package "hivex.pc" in a tarball distribution (created by "make dist"). Remove "hivex.pc" from EXTRA_DIST. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908132758.18575-4-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 18422752803bd620c73cb7dd9323dc5aeef3fb15

build: move "hivex.pc.in" to the "lib" subdirectory Bring hivex's worktree structure closer to libguestfs's, in preparation for introducing "lib/local/hivex.pc.in" in a subsequent patch. Move "hivex.pc.in" to the "lib" subdirectory. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908132758.18575-5-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 31ab045be1b7d47dcb9b6f69b86429162365b5e7

run: use 'prepend' function to build paths Port libguestfs commit cae7909f5ed8 ("./run: Use 'prepend' function to build paths.", 2015-02-13) to hivex: Add a bash function 'prepend' for intelligently prepending elements to paths. eg: prepend PYTHONPATH "/foo" would set PYTHONPATH to "/foo" or "/foo:<previous-contents-of-PYTHONPATH>". Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908132758.18575-6-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha d2afec44aeeb410008aca8be6a8d658844f8a067

build: allow C programs using hivex to be compiled against build dir Port libguestfs commits e33b3c83a02c ("build: Allow C programs using libguestfs to be compiled against build dir.", 2020-03-12) and dbfab7d3b283 ("build: fix includedir in uninstalled libguestfs.pc", 2020-09-22) to hivex. This allows C programs to find a just built, but not installed, hivex tree. The "run" script points PKG_CONFIG_PATH to the new file "lib/local/hivex.pc", which describes the just-built hivex worktree. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908132758.18575-7-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 7c200e00cab47ef45c7c4693543abf4044723689

build: link hivex statically into C programs compiled against build dir This static-only linking allows the libguestfs daemon ("guestfsd") to launch in the appliance, without unresolved hivex symbols, when libguestfs is built against the hivex build dir. (Libguestfs's automatic *package* collection for the appliance, based on the shared library requirements of "guestfsd", cannot cover hivex when hivex is provided by a local build directory.) Linking hivex statically into *host-side* C programs that are compiled against the hivex build dir is only a small penalty. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908132758.18575-8-lersek@redhat.com> [lersek@redhat.com: squash in a comment about the "-l:libhivex.a" notation, at Rich's request] Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 34c6d42a9b0e4a141426f05e9d906ef21107f6a2

build: allow OCaml programs using hivex to be compiled against build dir Port libguestfs commit bf61bf7355d3 ("build: Allow OCaml programs using libguestfs to be compiled against build dir.", 2020-03-12) to hivex. This allows C+OCaml programs, such as libguestfs itself, to find a just built, but not installed, hivex tree: > libguestfs$ ../hivex/run ./configure CFLAGS=-fPIC > libguestfs$ ../hivex/run make -j $(getconf _NPROCESSORS_ONLN) > libguestfs$ ../hivex/run make -j $(getconf _NPROCESSORS_ONLN) check Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908132758.18575-9-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 3 months

push eventlibguestfs/libguestfs

Laszlo Ersek

commit sha 53e03eefaec49960d4798a71d07b0f8d56bd8095

daemon: generalize ocaml-hivex[-devel] lookup "ocamlc -where" is supposed to "print the location of the standard library and exit". While this directory contains core OCaml C header files, it does not contain hivex-related C header files. Trim "guestfsd_CPPFLAGS" accordingly. Furthermore, the hivex module for OCaml may exist elsewhere than under the OCaml standard library directory. Invoke "ocamlfind query hivex" to find this module. This is what AC_CHECK_OCAML_PKG(hivex) does too, in "m4/guestfs-ocaml.m4" and "m4/ocaml.m4". Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908133542.19002-2-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 523b0180d8cf2eea99e418db52eca5a54ab2e7ac

daemon_utils_tests: generalize ocaml-hivex[-devel] lookup Pass $(HIVEX_LIBS) with -cclib under the "daemon_utils_tests_LINK" target; otherwise the OCaml compiler does not tell the linker where "-lhivex" can be found, and the linking step fails if "-lhivex" is not on a system library path. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210908133542.19002-3-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 3 months

issue openedunixwork/xnedit

request for "open" and "save-as" dialog enhancements

Hi,

  • The original NEdit Save-As and Open dialgs disappear when you hit ESC. The new dialogs don't seem to behave like that, ESC is just ignored.
  • Additionally, NEdit's Open dialog lets the user type or paste a complete pathname in an (unnamed) line-editing field. This capability is missing from XNEdit's new Open dialog at the moment (at commit d7218af7761e anyway).

(Would you suggest that I simply switch to -DMOTIF_FILEDIALOG? I've never had much use -- even with the original NEdit -- for the various widgets in the Save-As and Open dialogs; all I usually need is a field where I can paste a pathname. Even with the GNOME File Open dialog in other applications, the first thing I always press is Ctrl+L, for bringing up the location bar. Do you intend to support -DMOTIF_FILEDIALOG in the long term?)

Thanks! Laszlo

created time in 3 months

push eventlersek/edk2

duntan

commit sha f0fe55bca4651734abf1752a1d7c69fb5bee00b9

UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong <guo.dong@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Signed-off-by: DunTan <dun.tan@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com>

view details

Wenxing Hou

commit sha 5d34cc49d5d348012fe8acf9fb618826bd541a7c

UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou <wenxing.hou@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Cc: Sheng W <w.sheng@intel.com> Cc: Yao Jiewen <jiewen.yao@intel.com>

view details

Marvin H?user

commit sha cdda3f74a1327663a5d48cca13507085ba403af7

UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong <guo.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Cc: Vitaly Cheptsov <vit9696@protonmail.com> Signed-off-by: Marvin H?user <mhaeuser@posteo.de>

view details

Marvin H?user

commit sha 3b3f88228812e2c642eea8746858a4dad928ebf7

MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Eric Dong <eric.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Vitaly Cheptsov <vit9696@protonmail.com> Signed-off-by: Marvin H?user <mhaeuser@posteo.de>

view details

Mark Wilson

commit sha b170806518c1e414939c8b085866544814e1ce8e

UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong <eric.dong@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Signed-off-by: Mark Wilson <Mark.Wilson@amd.com>

view details

Loo, Tung Lun

commit sha 12e33dca4c0612a0975265e5ba641c6261a26455

IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma <maurice.ma@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Star Zeng <star.zeng@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Signed-off-by: Loo Tung Lun <tung.lun.loo@intel.com> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

view details

duntan

commit sha 63fddc98e06c380e654b1cfbaf24b9fd922adfad

UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong <guo.dong@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Maurice Ma <maurice.ma@intel.com> Cc: Benjamin You <benjamin.you@intel.com> Signed-off-by: DunTan <dun.tan@intel.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

view details

duntan

commit sha e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3

.azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan <sean.brogan@microsoft.com> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Signed-off-by: DunTan <dun.tan@intel.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

view details

Wenyi Xie

commit sha b6bc203375b6efb6822ee4fe4a59be4f1918436b

MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Dandan Bi <dandan.bi@intel.com> Cc: Eric Dong <eric.dong@intel.com> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com> Reviewed-by: Dandan Bi <dandan.bi@intel.com>

view details

Rebecca Cran

commit sha c5e805ffe1098601e84fd501d5fa1d45e9d96a62

MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran <rebecca@bsdio.com> Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

view details

Hao A Wu

commit sha 81d71fb86e1ad676e94becb7ffffb403cefd3019

Maintainers.txt: Update maintainer/reviewer roles in MdeModulePkg Remove Hao A Wu as the MdeModulePkg maintainer. Add Liming Gao as the MdeModulePkg maintainer. Remove Hao A Wu as the MdeModulePkg: Firmware Update modules reviewer. Remove Hao A Wu as the MdeModulePkg: Serial modules reviewer. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Guomin Jiang <guomin.jiang@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Hao A Wu <hao.a.wu@intel.com> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

view details

Michael Kubacki

commit sha edf8bc6d24c6f490c27de3144eee88f1ca40ce6a

SecurityPkg/MemoryOverwriteControl: Add missing argument to DEBUG print REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3605 The error message is missing the argument for the status code print specifier. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Qi Zhang <qi1.zhang@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>

view details

Anthony PERARD

commit sha 4473834e7d49c555eca81f96383a1d6d6f5f4bb2

OvmfPkg/OvmfXen: Fix build with QemuKernelLoaderFsDxe VerifyBlob() has been added recently to QemuKernelLoaderFsDxe, also QemuKernelLoaderFsDxe has been added recently to OvmfXen but without an implementation of VerifyBlob(). Fix this by adding the same runes that have been added to OvmfPkgX64.dsc. Fixes: 9f3eda177a4b ("OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe") Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

view details

push time in 3 months

push eventlibguestfs/virt-v2v

Laszlo Ersek

commit sha 10af3dee6a45c8867cb077a5470de1df8a613420

Update common submodule to commit 19302b64c5f1 Short log: Laszlo Ersek (2): Makefile.am: supply missing $(LIBGUESTFS_CFLAGS) Makefile.am: use $(LIBGUESTFS_LIBS) for linking OCaml test programs Signed-off-by: Laszlo Ersek <lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 3 months

push eventlibguestfs/libguestfs

Laszlo Ersek

commit sha 81ad309d47e2ff6d8ce8a9cfb1be89ffeab11294

Update common submodule to commit 19302b64c5f1 Short log: Laszlo Ersek (2): Makefile.am: supply missing $(LIBGUESTFS_CFLAGS) Makefile.am: use $(LIBGUESTFS_LIBS) for linking OCaml test programs Richard W.M. Jones (4): tools: Refactor create_standard_options tools: Add optional --program-name flag. mltools/test-getopt.sh: Allow test to work for tools version 2 mltools: Add JSON_parser.object_get_bool Signed-off-by: Laszlo Ersek <lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 3 months

push eventrwmjones/guestfs-tools

Laszlo Ersek

commit sha fd93eb128d9d580695a5563bc91a5e4d8ab3be40

Update common submodule to commit 19302b64c5f1 Short log: Laszlo Ersek (2): Makefile.am: supply missing $(LIBGUESTFS_CFLAGS) Makefile.am: use $(LIBGUESTFS_LIBS) for linking OCaml test programs Richard W.M. Jones (4): tools: Refactor create_standard_options tools: Add optional --program-name flag. mltools/test-getopt.sh: Allow test to work for tools version 2 mltools: Add JSON_parser.object_get_bool Signed-off-by: Laszlo Ersek <lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha d8e57a0027742af719f836718b4c5deb6fb8d9bd

Makefile.am: fix $(LIBGUESTFS_CFLAGS) typo for virt-ls Commit 4354a3126152 ("Add build system.", 2021-03-11) added $(LIBGUESTFS_LIBS) to "virt_ls_CFLAGS" and "virt_ls_LDADD" both. Correct the former; it should carry $(LIBGUESTFS_CFLAGS). Currently, the command > $ ../libguestfs/run make produces the error > CC virt_ls-ls.o > ls.c:47:10: fatal error: guestfs.h: No such file or directory > 47 | #include "guestfs.h" > | ^~~~~~~~~~~ Fixes: 4354a3126152a2748cc9097cba139b3908ccc342 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210906114314.14750-2-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha d01a52d739e3a137c9f002161d71feabe8b374c0

Makefile.am: supply missing $(LIBGUESTFS_CFLAGS) Common C source code pulled into virt-builder, virt-index-validate and virt-customize #includes "guestfs.h", but the guestfs-tools makefiles of those modules do not add $(LIBGUESTFS_CFLAGS) to the respective module CFLAGS macros. The command > $ ../libguestfs/run make produces errors such as > CC ../common/edit/libcustomize_a-file-edit.o > In file included from ../common/edit/file-edit.c:46: > ../common/edit/file-edit.h:22:10: fatal error: guestfs.h: No such file or directory > 22 | #include <guestfs.h> > | ^~~~~~~~~~~ Add the missing $(LIBGUESTFS_CFLAGS) instances. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210906114314.14750-3-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 9b0f2e2d58938b7112238466f155a7df3885cd1f

Makefile.am: use $(LIBGUESTFS_LIBS) for linking OCaml programs Otherwise the command > $ ../libguestfs/run make produces errors like > GEN virt-customize > /usr/bin/ld: cannot find -lguestfs > /usr/bin/ld: cannot find -lguestfs > collect2: error: ld returned 1 exit status > File "caml_startup", line 1: > Error: Error during linking (exit code 1) in the "builder", "customize", "dib", "get-kernel", "resize", "sparsify" and "sysprep" modules. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210906114314.14750-4-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 3 months

push eventlibguestfs/libguestfs-common

Laszlo Ersek

commit sha 94d5d988b749c4bf85f18b07f0199b6b84cb45a6

Makefile.am: supply missing $(LIBGUESTFS_CFLAGS) C source code in the "edit", "mlvisit", "parallel", "progress", "structs", "visit", and "windows" modules includes "guestfs.h", but the makefiles of those modules do not add $(LIBGUESTFS_CFLAGS) to the respective module CFLAGS macros. This is a problem when these modules are built as a part of guestfs-tools, against a just-built libguestfs tree, as follows: > guestfs-tools$ ../libguestfs/run ./configure > guestfs-tools$ ../libguestfs/run make Example error: > CC libmlvisit_a-visit-c.o > visit-c.c:33:10: fatal error: guestfs.h: No such file or directory > 33 | #include "guestfs.h" > | ^~~~~~~~~~~ Add the missing $(LIBGUESTFS_CFLAGS) instances. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210906114226.14689-2-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

Laszlo Ersek

commit sha 19302b64c5f13a1c247ebbb5f9036e115f081675

Makefile.am: use $(LIBGUESTFS_LIBS) for linking OCaml test programs Otherwise > guestfs-tools$ ../libguestfs/run make check produces errors like > GEN tools_utils_tests > /usr/bin/ld: cannot find -lguestfs > /usr/bin/ld: cannot find -lguestfs > collect2: error: ld returned 1 exit status > File "caml_startup", line 1: > Error: Error during linking (exit code 1) in the "mltools" and "mlvisit" modules. Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20210906114226.14689-3-lersek@redhat.com> Acked-by: Richard W.M. Jones <rjones@redhat.com>

view details

push time in 3 months

more