profile
viewpoint

leethree/WineGlass 40

🍷Demo for Apple Watch style UI in React Native

leethree/redux-persist-fs-storage 34

Redux Persist storage engine for React Native file system

leethree/minimal-logger 5

A minimal logger for React Native and others

ef-eng/react-native-swag-toggle 3

A Swag Toggle for React Native and Expo Web

leethree/FinComp-Project 3

Course Project for CSIS7802 Financial Computing

leethree/attentive-ui 2

research project on attentive UI for touch screen mobile devices

cjld/THCO-MIPS-Simulator 1

THCO-MIPS Simulator

leethree/mini-pie 1

Online Address Book Management Service

leethree/react-native-video 1

A <Video /> component for react-native

ef-carbon/react-native-callkeep 0

iOS CallKit framework and Android ConnectionService for React Native

issue commenttypescript-eslint/typescript-eslint

[ban-types] Should not ban `{}` by default!

@bbarry Thanks for the explanation. It makes sense to me. I feel TypeScript should clarify and provide a helper type for empty object because it's used a lot.

Mister-Hope

comment created time in 13 days

issue commenttypescript-eslint/typescript-eslint

[ban-types] Should not ban `{}` by default!

I'm still very confused about what {} means, and it seems like almost everybody use it as an object. It's also used extensively in the typings of react.

It's working perfectly well for typing React components without props:

const Comp = (props: {}) => null; // React component

const a = <Comp /> // Correct

const b = <Comp test={false} /> // Type '{ test: boolean; }' is not assignable to type '{}'. Property 'test' does not exist on type '{}'.(2322)

What alternative should I use to replace {} in this case?

Mister-Hope

comment created time in 13 days

delete branch leethree/react-native-agora

delete branch : patch-1

delete time in 16 days

pull request commentreact-native-community/jsc-android-buildscripts

Fix Intl default timezone is incorrect

anyone reviewing this?

Kudo

comment created time in a month

issue commentreact-native-community/react-native-netinfo

Impact on battery life caused by internet reachability test

does each NetInfo.configure call create a new instance of the reachability test? in my testing, the library will still call https://clients3.google.com/generate_204 even if I configure the URL to something else.

I'm using v5.9.0

levipro

comment created time in a month

issue commentmicrosoft/TypeScript

Allow overrides in tsconfig

mixing test and source files

It's called "colocating" and it's a common pattern in the JavaScript world.

Exhibit A:

In a component-based architecture, we already combine templates, stylesheets, and JavaScript in one directory. As it makes sense to group these tightly-coupled files together, including unit tests in this selection is the natural extension of the underlying model.

https://islovely.co/posts/colocating-unit-tests

Exhibit B:

It’s so much nicer to colocate tests with sources (either separate folder or *.test.js files). Can’t see any reasons to do it any other way.

https://twitter.com/dan_abramov/status/762658867327172608?lang=en

donaldpipowitch

comment created time in a month

created tagef-eng/react-native-swag-toggle

tagv0.2.1

A Swag Toggle for React Native and Expo Web

created time in a month

release ef-eng/react-native-swag-toggle

v0.2.1

released time in a month

push eventef-eng/react-native-swag-toggle

Sirui Li

commit sha 6d2dd84635d84d3ca7f2e598e1563d19fec4be99

chore: release 0.2.1

view details

push time in a month

push eventef-eng/react-native-swag-toggle

Sirui Li

commit sha 0c695684171fe9e51a8ab932b81d1b0d646c9d1e

fix: cursor behaviour on web

view details

Sirui Li

commit sha 6c493aaec7e05c207fa3cadfaa985bf348c50e80

docs: update README

view details

push time in a month

push eventef-eng/react-native-swag-toggle

Sirui Li

commit sha 4c676efae5de4bc3c90bfcac9fa1db18cb72f2c5

fix: update dependencies

view details

push time in a month

issue commentfacebook/react-native

URL incorrectly adds trailing slash

Hi bot, I don't think it's fixed.

leethree

comment created time in a month

issue commentfacebook/react

[eslint-plugin-react-hooks] false positive with useFocusEffect

@gaearon thanks!

leethree

comment created time in 2 months

PR opened DefinitelyTyped/DefinitelyTyped

[react-native-audio] fix prepareRecordingAtPath

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [ ] Add or edit tests to reflect the change. (Run with npm test.)
  • [ ] Follow the advice from the readme.
  • [ ] Avoid common mistakes.
  • [ ] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • [ ] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/jsierles/react-native-audio/blob/058935a117c9721efaf1824d0c18ae1ca005dd4a/index.js#L50-L63
  • [ ] If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • [ ] Include tests for your changes
  • [ ] If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
+1 -1

0 comment

1 changed file

pr created time in 2 months

push eventleethree/DefinitelyTyped

Sirui Li

commit sha 0302c2b28942dfcd4b360c59fc91853579ae6dc9

[react-native-audio] fix prepareRecordingAtPath

view details

push time in 2 months

release ef-eng/react-native-swag-toggle

v0.2.0

released time in 2 months

push eventef-eng/react-native-swag-toggle

Sirui Li

commit sha d625be109849bfb43a89cf2a3ffeaac168640f90

chore: release 0.2.0

view details

push time in 2 months

created tagef-eng/react-native-swag-toggle

tagv0.2.0

created time in 2 months

push eventef-eng/react-native-swag-toggle

Sirui Li

commit sha bbb6e849d7f74554b7a14288e4b3ee335c3925ab

docs: update README

view details

Sirui Li

commit sha e7aa9c59ba89870cb3247daa0a6348c8c9f05cf6

fix: tweak example font size

view details

Sirui Li

commit sha 980b0dfa4a5e8f59729576a4618c540796d1b0f6

docs: add a screenshot

view details

push time in 2 months

create barnchef-eng/react-native-swag-toggle

branch : master

created branch time in 2 months

created repositoryef-eng/react-native-swag-toggle

created time in 2 months

issue commentreact-native-community/react-native-video

Android video player running into infinite buffer loop when tapped rapidly on seek controls

probably related to: https://github.com/react-native-community/react-native-video/issues/1320

sourabhdadapure

comment created time in 2 months

issue commentfacebook/react

[eslint-plugin-react-hooks] false positive with useFocusEffect

Sounds reasonable to me.

we'd reserve Effect suffix for things that mirror the dependency API.

Would be great if this could be added to documentation. I would file an issue to react-navigation asking them to change the hook name 😄

leethree

comment created time in 2 months

issue commentfacebook/react

[eslint-plugin-react-hooks] false positive with useFocusEffect

Sigh. People have been asking for the opposite, so we added this for every function ending with Effect.

😢 I completely understand it. But it's difficult to ask all library authors to follow the same rules. Maybe adding an option would help.

leethree

comment created time in 2 months

issue openedfacebook/react

[eslint-plugin-react-hooks] false positive with useFocusEffect

Upgraded eslint-plugin-react-hooks to 4.0.0, it's showing errors on React-Navigation's useFocusEffect hook.

  useFocusEffect(
    React.useCallback(() => {
      const unsubscribe = API.subscribe(userId, user => setUser(user));
      return () => unsubscribe();
    }, [userId])
  );

(example copied from React-Navigation documentation)

The current behavior

Lint error:

React Hook useFocusEffect received a function whose dependencies are unknown. Pass an inline function instead.

The expected behavior

The rules shouldn't check the function because it's not a React useEffect hook.

created time in 2 months

issue commentreact-native-community/jsc-android-buildscripts

Android Intl doesn't work as expected

in my testing. default timezone in Intl is always UTC. this behaviour is different from the default Date timezone.

> time.toString()
< Tue May 12 2020 22:00:00 GMT+0800 (HKT)

> startTime.toLocaleString('en', { timeZoneName: 'long' })
< 5/12/2020, 2:00:00 PM GMT

toString is in GMT+8, while toLocaleString is GMT.

deecewan

comment created time in 2 months

push eventleethree/react-native-video

Tsukasa Setoguchi

commit sha 257be246e0182d7641041531e0106f9da39005f6

fix README about reportBandwidth (#1816)

view details

Ash Mishra

commit sha a5bfba9451244c095d72a62fda0e0fb8d7d08c84

Fixes a situation when exiting fullscreen, where observed keypath values have not been released

view details

Ash Mishra

commit sha fa20965c35da0715422f2b75e6f40af5e0c82957

add try catch block around removal of observer keypaths on playerViewController

view details

Ash Mishra

commit sha 2c5006ac50a8e29048238a9f9fa3c55d8ea820fe

Merge pull request #1827 from nfb-onf/fix-playerviewcontroller-keypath-leak Fix playerviewcontroller keypath leak of observers

view details

Learnyst

commit sha 0df667692baf52fabe35e541379beb90217ea711

Audio Poster issue fix (#1779)

view details

IbrahimSulai

commit sha 9200dce1ae66eaaf88d7dc5be0b1fac3076dd769

Add full screen support to Android Exoplayer (#1730)

view details

Benoit Dion

commit sha 029b893d58cc3b1dc77bf9a09dad5cf39749530f

Bump version to 5.1.0-alpha

view details

Mohammed Salman

commit sha 2738892631fda1b9cebc894ce51cb875f5dddd9a

Fix readme grammar (#1888)

view details

Michael Tintiuc

commit sha 82c191d97fdf38580b993aba030e1de354aee886

Improve Android Audio Focus (#1897) Implement audio focus as per android docs: https://developer.android.com/guide/topics/media-apps/audio-focus https://medium.com/androiddevelopers/audio-focus-3-cdc09da9c122 AUDIOFOCUS_LOSS should abandon focus and not try resuming audio, this is done with AUDIOFOCUS_LOSS_TRANSIENT This fixes at least: - Audio not being paused after focus being taken by some voip applications - Content resuming and pausing instantly sporadically (some race condition perhaps) when activity was resumed from background.

view details

Benoit Dion

commit sha 4d0be29cbb3b394de6d25690bc917ea47c03e3f0

Update changelog (#1913)

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 5fa4cddbf8979e763bff8ae632615b5ef9c3d582

docs(video): fix bufferConfig property name (#1855)

view details

IbrahimSulai

commit sha fd8ac76e4dc8cf7226c6477314bd4c133f77d46c

Fix play/pause regression after added fullscreen support. (#1916)

view details

Benoit Dion

commit sha f0867d7eefe922b47593dc3c2aeef5e41c8bc827

v5.1.0-alpha4

view details

Benoit Dion

commit sha 4f07aab8b1d62d1df1bfbcef514a5f587de629ad

Bump javascript dependencies (#1914) Also update linting rules to match other community repositories.

view details

Di Da

commit sha a4fec8eb99dad0457f968ba5dc37f2842a8eb9c3

Add support for react-native Windows Cpp/WinRT (#1893) This also deprecates the old react-native windows implementation

view details

Brandon Faulkner

commit sha 6d1a7bed587a8e21d70555eabe275e07f8f7f354

Fix the `ref` sample code to remove the syntax error

view details

Benoit Dion

commit sha 89b6d113a10892eed7ac6d982d9f2ad5163d9322

Update changelog

view details

Benoit Dion

commit sha 68dc15242d13043fd5ffbcfbc7aac856ca481d9d

v5.1.0-alpha5

view details

Marlon Andrade

commit sha 91384d848953d8c8b526a10f45d44f1bd38c62f0

Don't set reactViewController view frame to whole screen (#1931) this fixes the case on any time you have a react view that displays the video, but it's being rendered with controls but not as a full screen (ie. easily reproducible when you have a tabbar for instance - the reactViewController.view frame shouldnt be the whole screen bounds).

view details

push time in 3 months

more