profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ldsec/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
LDS ldsec Switzerland http://lds.epfl.ch/ Laboratory for Data Security

ldsec/lattigo 580

A library for lattice-based homomorphic encryption in Go

ldsec/unlynx 29

A decentralized privacy-preserving data sharing tool

ldsec/drynx 26

Decentralized, Secure, Verifiable System for Statistical Queries and Machine Learning on Distributed Datasets

ldsec/HideMyApp 9

HideMyApp: Hiding the Presence of Sensitive Apps on Android

ldsec/ORide 8

ORide: A Privacy-Preserving yet Accountable Ride-Hailing Service

ldsec/smarper 7

SmarPer: Context-Aware and Automatic Runtime-Permissions for Mobile Devices

ldsec/ccgd-platform 5

Citizen-Centered Genomic Discovery platform

ldsec/medco 5

MedCo: collective protection of medical data.

fork uneidel/lattigo

A library for lattice-based homomorphic encryption in Go

fork in an hour

Pull request review commentldsec/medco

Time sequence queries

 resLoop:  } -func convertPanel(parameters *Parameters) ([]*survival_analysis.SurvivalAnalysisParamsBodySubGroupDefinitionsItems0, error) {+func validateUserIntputSequenceOfEvents(parameters *Parameters) error {
func validateUserInputSequenceOfEvents(parameters *Parameters) error {
f-marino

comment created time in 10 hours

Pull request review commentldsec/medco

Time sequence queries

 resultQuery12="$(printf -- "count\n1\n1\n1")" query13="clr::/E2ETEST/e2etest/3/:/E2ETEST/modifiers/3text/:/e2etest/3/::LIKE[end]:TEXT:bc" resultQuery13="$(printf -- "count\n0\n0\n0")" +query14="clr::/SPHN/SPHNv2020.1/FophDiagnosis/ AND clr::/SPHN/SPHNv2020.1/DeathStatus/ AND clr::/SPHN/SPHNv2020.1/DeathStatus/"+resultQuery14="$(printf -- "count\n228\n228\n228")"++resultQuery15="$(printf -- "count\n0\n0\n0")"
resultQuery14a="$(printf -- "count\n228\n228\n228")"

resultQuery14b="$(printf -- "count\n0\n0\n0")"
f-marino

comment created time in 9 hours

Pull request review commentldsec/medco

Time sequence queries

 func loadQueryFile(queryFilePath string) (conceptItems []*models.PanelConceptIte  	return }++// ParseSequences parses a string to a list of temporal sequence information.+// Multiple sequence information groups must be separated with columns ":".+// The different attributes inside a group must be separated with commas ",".+func ParseSequences(sequenceString string) (sequences []*models.TimingSequenceInfo, err error) {++	if sequenceString == "" {+		return+	}++	var seq *models.TimingSequenceInfo++	for _, sequenceString := range strings.Split(sequenceString, ":") {+		seq, err = parseSequence(sequenceString)+		if err != nil {+			err = fmt.Errorf("while parsing temporal sequence information: %s", err.Error())+			return+		}+		sequences = append(sequences, seq)+	}+	return++}++func parseSequence(sequenceString string) (sequence *models.TimingSequenceInfo, err error) {+	sequenceInfoStrings := strings.Split(sequenceString, ",")++	// the 5 mandatory items are:+	// 1. the operator (before, before or same time, same time)+	// 2. which occurence should be considered for the left operand (first, any, last)+	// 3. what date should be considered fot the left operand (startdate, enddate)+	// 4. which occurence should be considered for the right operand (first, any, last)+	// 5. what date should be considered fot the right operand (startdate, enddate)
	// 5. what date should be considered for the right operand (startdate, enddate)
f-marino

comment created time in 10 hours

Pull request review commentldsec/medco

Time sequence queries

 func (q *ExploreQuery) Execute(queryType ExploreQueryType) (err error) { 		return 	} -	patientCount, patientSetID, err := i2b2.ExecutePsmQuery(q.ID, q.Query.Panels, q.Query.QueryTiming)+	patientCount, patientSetID, err := i2b2.ExecutePsmQuery(q.ID, q.Query.Panels, q.Query.QueryTimingSequence, q.Query.Panels, q.Query.QueryTiming)

Here you are using q.query.Panels both as "regular" panels ans sequence panels. Why that? I guess you added an additional parameter to i2b2.ExecutePsmQuery because you wanted to have the possibility to have both regular panels and sequence panels in the same query? If this is the case the API was not designed for this (but we can change it if needed)

f-marino

comment created time in 8 hours

Pull request review commentldsec/medco

Time sequence queries

 func loadQueryFile(queryFilePath string) (conceptItems []*models.PanelConceptIte  	return }++// ParseSequences parses a string to a list of temporal sequence information.+// Multiple sequence information groups must be separated with columns ":".+// The different attributes inside a group must be separated with commas ",".+func ParseSequences(sequenceString string) (sequences []*models.TimingSequenceInfo, err error) {++	if sequenceString == "" {+		return+	}++	var seq *models.TimingSequenceInfo++	for _, sequenceString := range strings.Split(sequenceString, ":") {+		seq, err = parseSequence(sequenceString)+		if err != nil {+			err = fmt.Errorf("while parsing temporal sequence information: %s", err.Error())+			return+		}+		sequences = append(sequences, seq)+	}+	return++}++func parseSequence(sequenceString string) (sequence *models.TimingSequenceInfo, err error) {+	sequenceInfoStrings := strings.Split(sequenceString, ",")++	// the 5 mandatory items are:+	// 1. the operator (before, before or same time, same time)+	// 2. which occurence should be considered for the left operand (first, any, last)+	// 3. what date should be considered fot the left operand (startdate, enddate)
	// 3. what date should be considered for the left operand (startdate, enddate)
f-marino

comment created time in 10 hours

PullRequestReviewEvent
PullRequestReviewEvent

push eventldsec/glowing-bear-medco

WiseIndian

commit sha d8258e267fe717c1219ed5bc5558142591ac81e3

fixes #174

view details

WiseIndian

commit sha a1aca40cd1f6d7b5e84d994c1e4dca2166161dcc

Merge branch 'dev' into redirectRandomURLToExplore

view details

Jimmy DJABALI

commit sha 834bbdff5f74f28296ac5d651a72de952157b384

Search and drag-and-drop working, need some testing

view details

Jimmy DJABALI

commit sha 09eb65ee66313d770c1246a36b475c9b68cc411d

Removed useless console.log, added line break

view details

Jimmy DJABALI

commit sha c2cbdaa2a4176a0c850af3714ecaf5861c7baf9d

Remove useless console.log

view details

Jimmy DJABALI

commit sha b5452c37c06898a4517c0cfc302babea13b81ca8

Removed useless line

view details

Jimmy DJABALI

commit sha 5c96240c6a528ec7f5871a5ddd88c6af2aabf726

Fixed lint errors

view details

Jimmy DJABALI

commit sha e361e273ab591a189c0743c44e456e06aad4871d

Added second call to API to get appliedConcept

view details

Jimmy DJABALI

commit sha c0702e39d8fb98781e9c07e9bdfb478630e19ca6

Loading blink

view details

Jimmy DJABALI

commit sha 07c9ee49c49f647f9ee1b2da375fd3caed0e7290

Added placeholder

view details

Jimmy DJABALI

commit sha ce33e1abe07e9a97b1d41a2e5ea0fc820f4c47a2

Removed button

view details

Jimmy DJABALI

commit sha 42c97386a6f5e1cac10bcc02d9e06538f6c24f30

Full path if appliedPath is defined

view details

Jimmy DJABALI

commit sha aac124ebd02a452e4cb0a6a8d28324db93e2c84f

searchTerm & dragstart event listenner stays if changing tab

view details

Jimmy DJABALI

commit sha afc1983ec221d12c998f219e4246333b493b9af6

Use new Search API (with table information prepend)

view details

Jimmy DJABALI

commit sha 8654c9a949209ccdec97feaea122067951d620c1

Commented services, added matpSearchResults generic function

view details

Jimmy DJABALI

commit sha 584d0fdde38f0064e1b17531c63b77b7eb4d8d67

Remove trailing whitespace

view details

Jimmy DJABALI

commit sha c6eb452525e4501644be2db503aee1734ebd4061

Switched to use ViewChildren

view details

Jimmy DJABALI

commit sha 78098334c0307b14250f9623c7fc651cd7835214

Fixed lint

view details

Jimmy DJABALI

commit sha e7c8f31a889d57b3d809e4d48f2bb66c570bf73b

Get elements with querySelectorAll()

view details

Jimmy DJABALI

commit sha 946f026d0c8c10cee71b209a492b596f03c996a8

Switch using accordionTab

view details

push time in 10 hours

push eventldsec/glowing-bear-medco

Jimmy DJABALI

commit sha b472460cecc8475159d286aca2cac8d50a572fa8

Fixed cohort drop

view details

Jimmy DJABALI

commit sha 1e315273ff687b40dea69619b82b7884bfbf4241

Merge branch 'dev' into fixes/225-fixed-cohort-drop

view details

WiseIndian

commit sha 065b96d21365d0a60d156d8dc7f2b3c0457ba70d

Merge pull request #226 from ldsec/fixes/225-fixed-cohort-drop Fixed cohort drop

view details

push time in 10 hours

delete branch ldsec/glowing-bear-medco

delete branch : fixes/225-fixed-cohort-drop

delete time in 10 hours

issue closedldsec/glowing-bear-medco

Weird behaviour when selecting a cohort in explore tab

We noticed this bug in the interface with @jimmydjabali. We went through the following scenario that lead to a bug. We were in the explore tab. We selected a cohort by clicking on it. The second action we performed was drag and dropping a concept in the inclusion criteria. What appeared in the inclusion criteria was the cohort and not the concept name. Jimmy concluded that clicking on the cohort saves it in a variable which determines what cohort is being dragged at the moment. If this variable is non empty it will be used to fill the inclusion criteria on the next concept drag and drop. One solution could be to empty this variable by the end of the cohort click event callback if this variable contains the same value as the cohort clicked. Another solution could be to avoid filling this variable on a simple click event.

closed time in 10 hours

WiseIndian
PullRequestReviewEvent

push eventldsec/glowing-bear-medco

WiseIndian

commit sha d8258e267fe717c1219ed5bc5558142591ac81e3

fixes #174

view details

WiseIndian

commit sha a1aca40cd1f6d7b5e84d994c1e4dca2166161dcc

Merge branch 'dev' into redirectRandomURLToExplore

view details

WiseIndian

commit sha 54a2c303a7c5b3bdff26c3ee89364e6eb8f3d0b0

Merge branch 'dev' into redirectRandomURLToExplore

view details

WiseIndian

commit sha e15743c0b3b24b0703ddfa100c4b47a71462e44a

Merge pull request #212 from ldsec/redirectRandomURLToExplore fixes #174

view details

Jimmy DJABALI

commit sha 1e315273ff687b40dea69619b82b7884bfbf4241

Merge branch 'dev' into fixes/225-fixed-cohort-drop

view details

push time in 10 hours

push eventldsec/glowing-bear-medco

WiseIndian

commit sha d8258e267fe717c1219ed5bc5558142591ac81e3

fixes #174

view details

WiseIndian

commit sha a1aca40cd1f6d7b5e84d994c1e4dca2166161dcc

Merge branch 'dev' into redirectRandomURLToExplore

view details

WiseIndian

commit sha 54a2c303a7c5b3bdff26c3ee89364e6eb8f3d0b0

Merge branch 'dev' into redirectRandomURLToExplore

view details

WiseIndian

commit sha e15743c0b3b24b0703ddfa100c4b47a71462e44a

Merge pull request #212 from ldsec/redirectRandomURLToExplore fixes #174

view details

push time in 10 hours

PR merged ldsec/glowing-bear-medco

fixes #174

Fixes this issue

+3 -0

0 comment

1 changed file

WiseIndian

pr closed time in 10 hours

issue closedldsec/glowing-bear-medco

wrong URL should redirect to explore

If random string is provided, angular router outlet has a strange behaviour.

image

image

closed time in 10 hours

nfreundl

delete branch ldsec/glowing-bear-medco

delete branch : redirectRandomURLToExplore

delete time in 10 hours

PR opened ldsec/glowing-bear-medco

Reviewers
Fixed cohort drop bug

#225

+6 -8

0 comment

1 changed file

pr created time in 10 hours

create barnchldsec/glowing-bear-medco

branch : fixes/225-fixed-cohort-drop

created branch time in 10 hours

push eventldsec/glowing-bear-medco

WiseIndian

commit sha e8c5e0feb5138f8ab47b58ba5c8d1d58fd00114b

add tooltip for more information about a concept constraint in explore

view details

WiseIndian

commit sha bd16dc6e133c610d098795df7ce345ec323ec1f7

fix linting issues

view details

WiseIndian

commit sha 9b89733dc4ca1227a53beb8db3dba67a8fc7a9d0

Apply suggestions from code review Co-authored-by: Jimmy DJABALI <hello@jimmydjabali.com>

view details

WiseIndian

commit sha a6a145ef8b505395d8f2e7687a7db5811f108438

Merge branch 'dev' into addComment

view details

WiseIndian

commit sha 6a9c839acd0fb340fc3149f9645af11d7be8415c

Merge pull request #215 from ldsec/addComment Add tooltip for concept constraint with inputs (numerical, textual)

view details

Jimmy DJABALI

commit sha 8b4e5fa26902e284652ed65648851075290802ad

Add draggable="true"

view details

Francesco Marino

commit sha 52d97590063a1f26632e6343ccfbef49d37c79eb

Merge pull request #221 from ldsec/fix/218-add-draggable-true-for-cohorts Fixed dragging Cohorts in Chrome not working

view details

Jimmy DJABALI

commit sha 834bbdff5f74f28296ac5d651a72de952157b384

Search and drag-and-drop working, need some testing

view details

Jimmy DJABALI

commit sha 09eb65ee66313d770c1246a36b475c9b68cc411d

Removed useless console.log, added line break

view details

Jimmy DJABALI

commit sha c2cbdaa2a4176a0c850af3714ecaf5861c7baf9d

Remove useless console.log

view details

Jimmy DJABALI

commit sha b5452c37c06898a4517c0cfc302babea13b81ca8

Removed useless line

view details

Jimmy DJABALI

commit sha 5c96240c6a528ec7f5871a5ddd88c6af2aabf726

Fixed lint errors

view details

Jimmy DJABALI

commit sha e361e273ab591a189c0743c44e456e06aad4871d

Added second call to API to get appliedConcept

view details

Jimmy DJABALI

commit sha c0702e39d8fb98781e9c07e9bdfb478630e19ca6

Loading blink

view details

Jimmy DJABALI

commit sha 07c9ee49c49f647f9ee1b2da375fd3caed0e7290

Added placeholder

view details

Jimmy DJABALI

commit sha ce33e1abe07e9a97b1d41a2e5ea0fc820f4c47a2

Removed button

view details

Jimmy DJABALI

commit sha 42c97386a6f5e1cac10bcc02d9e06538f6c24f30

Full path if appliedPath is defined

view details

Jimmy DJABALI

commit sha aac124ebd02a452e4cb0a6a8d28324db93e2c84f

searchTerm & dragstart event listenner stays if changing tab

view details

Jimmy DJABALI

commit sha afc1983ec221d12c998f219e4246333b493b9af6

Use new Search API (with table information prepend)

view details

Jimmy DJABALI

commit sha 8654c9a949209ccdec97feaea122067951d620c1

Commented services, added matpSearchResults generic function

view details

push time in 11 hours

push eventldsec/glowing-bear-medco

Jimmy DJABALI

commit sha 67ad7d52371aa2ee4065fa0c96b3da4502198dc3

Fixed clone()

view details

WiseIndian

commit sha 40d38eaf0b97bf1654581a35797146eade725afc

Merge pull request #224 from ldsec/features/148-searchbox-last Fixed clone() on Searchbox API

view details

push time in 11 hours

delete branch ldsec/glowing-bear-medco

delete branch : features/148-searchbox-last

delete time in 11 hours

PullRequestReviewEvent

issue openedldsec/glowing-bear-medco

Weird behaviour when selecting a cohort in explore tab

We noticed this bug in the interface with @jimmydjabali. We went through the following scenario that lead to a bug. We were in the explore tab. We selected a cohort by clicking on it. The second action we performed was drag and dropping a concept in the inclusion criteria. What appeared in the inclusion criteria was the cohort and not the concept name. Jimmy concluded that clicking on the cohort saves it in a variable which determines what cohort is being dragged at the moment. If this variable is non empty it will be used to fill the inclusion criteria on the next concept drag and drop. One solution could be to empty this variable by the end of the cohort click event callback if this variable contains the same value as the cohort clicked. Another solution could be to avoid filling this variable on a simple click event.

created time in 11 hours

PR opened ldsec/glowing-bear-medco

Reviewers
Fixed clone() on Searchbox API bug
+11 -9

0 comment

2 changed files

pr created time in 11 hours

create barnchldsec/glowing-bear-medco

branch : features/148-searchbox-last

created branch time in 11 hours