profile
viewpoint
Louis DeLosSantos ldelossa Red Hat Brooklyn, NY https://www.ldelossa.is Software Engineer at CoreOS/RedHat

go-jira/jira 2022

simple jira command line client in Go

ldelossa/bg_deploy 2

Script for handling blue green deployments in AWS

ldelossa/distlock 2

postgres backed distributed lock

cloudscaleorg/events 1

etcd backed event streams

cloudscaleorg/graphx 1

Time series metrics, real time, to the browser

ldelossa/APIclient 1

Golang scaffolding code for an API client

ldelossa/dns 1

Library for parsing DNS wire format

ldelossa/alpine-secdb 0

Alpine Linux security database

issue commentjunegunn/fzf.vim

Disable popup in favor of location window

yeah, those docs show "use a window dictionary", but my vim has no window dictionary defined.

" FZF configuration
map <C-G> :GFiles <CR>
map <C-F> :Files <CR>
nmap <C-B> :Buffers<cr>
nmap <C-S> :Tags<cr>
nmap ; :Buffers<cr>
let g:fzf_colors =
\ { 'fg':      ['fg', 'Normal'],
  \ 'bg':      ['bg', 'Normal'],
  \ 'hl':      ['fg', 'Visual'],
  \ 'fg+':     ['fg', 'Visual'],
  \ 'bg+':     ['bg', 'Visual'],
  \ 'hl+':     ['fg', 'Statement'],
  \ 'info':    ['fg', 'PreProc'],
  \ 'border':  ['fg', 'Ignore'],
  \ 'prompt':  ['fg', 'Conditional'],
  \ 'pointer': ['fg', 'Exception'],
  \ 'marker':  ['fg', 'Keyword'],
  \ 'spinner': ['fg', 'Label'],
  \ 'header':  ['fg', 'Comment'] }
ldelossa

comment created time in 2 days

issue openedjunegunn/fzf.vim

Disable popup in favor of location window

<!-- ISSUES NOT FOLLOWING THIS TEMPLATE WILL BE CLOSED AND DELETED -->

<!-- Check all that apply [x] -->

  • [x] I have fzf 0.22.0 or above
  • [x] I have read through https://github.com/junegunn/fzf.vim/blob/master/README.md
  • [x] I have read through https://github.com/junegunn/fzf/blob/master/README-VIM.md
  • [x] I have read through the manual page of fzf (man fzf)
  • [x] I have searched through the existing issues

<!--

Before submitting

  • Make sure that you have the latest version of fzf and fzf.vim
  • Check if your problem is reproducible with a minimal configuration

Start Vim with a minimal configuration

vim -Nu <(curl https://gist.githubusercontent.com/junegunn/6936bf79fedd3a079aeb1dd2f3c81ef5/raw)

-->

Hello,

Seems like recently fzf.vim began using popup window as default. There are no docs explaining how to disable this and return to the location list previous used. Is this possible?

created time in 2 days

pull request commentquay/claircore

Makefile: handle SELinux permissions for volume in docker-compose

Very cool, ill check on MacOS and report back.

jan-zmeskal

comment created time in 2 days

pull request commentquay/clair

deployment: use service prefix for simplified path routing

cc @alecmerdler - will need api changes in Quay.

ldelossa

comment created time in 2 days

PR opened quay/clair

Reviewers
deployment: use service prefix for simplified path routing

This commit adds a service prefix to api paths. Prior to this commit adding a new end point to ClairV4 would require operations to reconfigure their infrastructure.

Signed-off-by: ldelossa ldelossa@redhat.com

+102 -127

0 comment

15 changed files

pr created time in 2 days

create barnchldelossa/clair

branch : louis/api-prefixes

created branch time in 2 days

fork ldelossa/kirc

A tiny IRC client written in POSIX C99.

fork in 2 days

issue commentetcd-io/etcd

go.mod:incorrect pacakge dependency in etcd 3.3 without go.mod

@mohdahmad17 im importing via the latest commit hash directly.

cfc4n

comment created time in 2 days

issue commentmcpcpc/kirc

Chat text clobbers message text

Id be interested in helping out. I have a little bit of experience with term programming, more on the vim side of things. But this looks cool, and i like the idea of a super simple client. Know where youd want to start on this?

ldelossa

comment created time in 3 days

issue openedmcpcpc/kirc

Chat text clobbers message text

Maybe not a bug, but is it supposed to be the case that when typing a message incoming chat messages interleave with what you're typing?

To Reproduce Steps to reproduce the behavior: Use kirc in a chat where ppl are talking. Start typing a message. Text in message will interleave with text from chat

Expected behavior Message text is written in an area of the ui not interleaved by other chat messages.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: fedora 32
  • Browser N/a
  • Version 0.0.8

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

created time in 3 days

issue openedgnunn1/tilix

Confused about key mappings

Hello,

I remap my caps lock to ctrl in gnome-tweaks. Its very odd that in tilix I can only use the caps-lock button as ctrl on some key bindings. For instance I cannot use it to "maximize session", when trying to registry the key stroke it just does not register. But for other key bindings it will. Wazzzzup with that?

created time in 3 days

create barnchldelossa/kernel_modules

branch : master

created branch time in 3 days

created repositoryldelossa/kernel_modules

Toy linux kernel modules to explore how linux works

created time in 3 days

push eventldelossa/dotfiles

ldelossa

commit sha c85e79759d26c7f00febd90b70efe9af33d4a98a

add vmmount makefile

view details

push time in 3 days

push eventldelossa/clair

ldelossa

commit sha 6e27167e5a946c5a44088c867c13f0adb9dce208

auth: psk fixup this commit no longer requires a base64 PSK in the config, decoding it became an issue when interoping with Quay. commit also simplifies the PSK check to look at multiple issuers. This is mostly done for more accurate logging. Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 3 days

push eventldelossa/clair

ldelossa

commit sha ae716c91831a6f7fbf44312c78d1c2ffbb114f6c

auth: psk fixup this commit no longer requires a base64 PSK in the config, decoding it became an issue when interoping with Quay. commit also simplifies the PSK check to look at multiple issuers. This is mostly done for more accurate logging. Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 3 days

PR opened quay/clair

Reviewers
auth: psk fixup

this commit no longer requires a base64 PSK in the config, decoding it became an issue when interoping with Quay.

commit also simplifies the PSK check to look at multiple issuers. This is mostly done for more accurate logging.

Signed-off-by: ldelossa ldelossa@redhat.com

+65 -41

0 comment

5 changed files

pr created time in 3 days

push eventldelossa/clair

ldelossa

commit sha d805056e416308f45620ae66ade44596521769e8

auth: psk fixup this commit no longer requires a base64 PSK in the config, decoding it became an issue when interoping with Quay. commit also simplifies the PSK check to look at multiple issuers. This is mostly done for more accurate logging. Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 3 days

push eventldelossa/clair

ldelossa

commit sha ea696575143df450b96d958cd956d73de20bff5e

auth: psk fixup this commit no longer requires a base64 PSK in the config, decoding it became an issue when interoping with Quay. commit also simplifies the PSK check to look at multiple issuers. This is mostly done for more accurate logging. Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 3 days

push eventldelossa/clair

ldelossa

commit sha 7853652c1f90a84d18181afe63097496ac914480

auth: psk fixup this commit no longer requires a base64 PSK in the config, decoding it became an issue when interoping with Quay. commit also simplifies the PSK check to look at multiple issuers. This is mostly done for more accurate logging. Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 3 days

push eventldelossa/quay

ldelossa

commit sha 099cc6a6db5d6a00ee9f1665f01c57cfbd7786ba

sec: add default args Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 3 days

Pull request review commentquay/quay

sec: implement jwt signing to ClairV4

 pytest-sugar tox tox-docker tqdm+PyJWT==1.7.1

is there no value to pinning dependency versions so library changes do not break the code?

ldelossa

comment created time in 3 days

PullRequestReviewEvent

push eventldelossa/ldelossa-blog

ldelossa

commit sha 294ef8d21f61aef50e5e5d64daed91854307a188

lock clarification

view details

ldelossa

commit sha c1e4de435fdb2aadb0f71e6e7e76591d621b52a3

Build

view details

push time in 3 days

push eventldelossa/ldelossa-blog

ldelossa

commit sha 294ef8d21f61aef50e5e5d64daed91854307a188

lock clarification

view details

push time in 3 days

push eventldelossa/quay

ldelossa

commit sha cd4ff83d9d1db0a1e90814095dc0689aca663680

sec: add default args Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 3 days

create barnchldelossa/clair

branch : louis/jwt-fixes

created branch time in 3 days

push eventldelossa/quay

ldelossa

commit sha f1ea921b773e27eb77ef4f6e103b868bc25b06f0

sec: add default args Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 3 days

push eventldelossa/quay

ldelossa

commit sha 76f1c54b137b66979396bdf9ff14c9a25b8799d4

sec: add default args Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 3 days

push eventldelossa/dotfiles

ldelossa

commit sha f18e7c643ca76272554aecb7b1a0bf4e2b3215cd

add ctags

view details

push time in 3 days

push eventquay/clair

mcoops

commit sha 10b87578aa55ecaed27d36964b1de18e7eaffe42

logging: add similar logging to v3 Add back in HTTP logging to what was present in v3, to each of the handlers. Signed-off-by: mcoops <cooper.d.mark@gmail.com>

view details

mcoops

commit sha fb83eb66b6e328622af3b1b7906cb8d5e16a141e

Default to 200OK, otherwise get the HTTP return status Signed-off-by: mcoops <cooper.d.mark@gmail.com>

view details

mcoops

commit sha e45c1e12094bffa334ce3e8beefae5822938994c

add in writeheader Signed-off-by: mcoops <cooper.d.mark@gmail.com>

view details

push time in 3 days

PR merged quay/clair

Reviewers
logging: add similar logging to v3

Add back in HTTP logging to what was present in v3, to each of the handlers.

Matched the existing format/fields from v3 here: https://github.com/quay/clair/blob/1d1417737209cfe2e1d0b870658c8c6767832905/api/v3/server.go#L62

Didn't add tests as there isn't really much to test.

+51 -11

2 comments

2 changed files

mcoops

pr closed time in 3 days

push eventldelossa/dotfiles

ldelossa

commit sha 211ec1c33d9f258deef968dd236dbd8641459839

push

view details

push time in 4 days

push eventldelossa/ldelossa-blog

ldelossa

commit sha 4fcf6318aff0e0f6140e76f7223f3203cdf853c4

working alloc post

view details

ldelossa

commit sha df58af70ff809187de804aa8396a177598c8c594

Build

view details

push time in 4 days

push eventldelossa/ldelossa-blog

ldelossa

commit sha 4fcf6318aff0e0f6140e76f7223f3203cdf853c4

working alloc post

view details

push time in 4 days

push eventldelossa/ldelossa-blog

ldelossa

commit sha 54919148f6beafef1083c323da70ec1e4ed28bb2

touchup alloc post

view details

ldelossa

commit sha 39233241ea0d0d9cbb67768341440d07da257900

Build

view details

push time in 4 days

push eventldelossa/ldelossa-blog

ldelossa

commit sha 54919148f6beafef1083c323da70ec1e4ed28bb2

touchup alloc post

view details

push time in 4 days

push eventldelossa/clair

Alec Merdler

commit sha 5fde750ccb3cbd3531bfc7d837af8b52f9642e0e

fix struct field typo for webhook config Signed-off-by: Alec Merdler <alecmerdler@gmail.com>

view details

push time in 4 days

PullRequestReviewEvent

push eventldelossa/ldelossa-blog

ldelossa

commit sha e6347930bba39d527b1bb4f059fa055fef06ae0e

alocation in go post

view details

ldelossa

commit sha b475aeb5c207a41d0b8d39e056c1a4ea07427770

Build

view details

push time in 5 days

push eventldelossa/ldelossa-blog

ldelossa

commit sha e6347930bba39d527b1bb4f059fa055fef06ae0e

alocation in go post

view details

push time in 5 days

Pull request review commentquay/clair

logging: add similar logging to v3

+package httptransport++import (+	"net/http"+	"strconv"+	"time"++	"github.com/rs/zerolog"+)++type httpStatusWriter struct {+	http.ResponseWriter+	StatusCode int+}++// LoggingHandler will log HTTP requests using the pre initialized zerolog.+func LoggingHandler(next http.Handler) http.HandlerFunc {+	return func(w http.ResponseWriter, r *http.Request) {+		start := time.Now()++		log := zerolog.Ctx(r.Context())++		// default HTTP StatusOK+		lrw := &httpStatusWriter{ResponseWriter: w, StatusCode: http.StatusOK}++		next.ServeHTTP(w, r)++		log.Info().+			Str("remote addr", r.RemoteAddr).+			Str("method", r.Method).+			Str("request uri", r.RequestURI).+			Str("status", strconv.Itoa(lrw.StatusCode)).

Why the need to call Itoa here? can you avoid the method call with just

Int("status", lrw.StatusCode) ?

mcoops

comment created time in 5 days

Pull request review commentquay/clair

logging: add similar logging to v3

+package httptransport++import (+	"net/http"+	"strconv"+	"time"++	"github.com/rs/zerolog"+)++type httpStatusWriter struct {+	http.ResponseWriter+	StatusCode int+}++// LoggingHandler will log HTTP requests using the pre initialized zerolog.+func LoggingHandler(next http.Handler) http.HandlerFunc {+	return func(w http.ResponseWriter, r *http.Request) {+		start := time.Now()++		log := zerolog.Ctx(r.Context())++		// default HTTP StatusOK+		lrw := &httpStatusWriter{ResponseWriter: w, StatusCode: http.StatusOK}

I don't think I understand how this works, what updates lrw.StatusCode with a non http.StatusOK ?

mcoops

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventldelossa/quay

ldelossa

commit sha 77fbfb60495f3f43e73ffd2508bccd2e7f446eec

sec: add default args Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 5 days

Pull request review commentquay/clair

logging: add similar logging to v3

+package httptransport++import (+	"net/http"+	"strconv"+	"time"++	"github.com/rs/zerolog"+)++type httpStatusWriter struct {+	http.ResponseWriter++	StatusCode int+}++// LoggingHandler will log HTTP requests using the pre initialized zerolog.+func LoggingHandler(next http.Handler) http.HandlerFunc {+	return func(w http.ResponseWriter, r *http.Request) {+		start := time.Now()++		log := zerolog.Ctx(r.Context())++		next.ServeHTTP(w, r)++		log.Info().+			Str("remote addr", r.RemoteAddr).+			Str("method", r.Method).+			Str("request uri", r.RequestURI).+			Str("status", strconv.Itoa(http.StatusOK)).+			Float64("elapsed time (md)", float64(time.Since(start).Nanoseconds())*1e-6).

Ah, actually missed the second float64 wrap. I see now. Your call.

mcoops

comment created time in 5 days

PullRequestReviewEvent

push eventldelossa/quay

ldelossa

commit sha e0fdf105afb6fa0299696c9e4b3f347ae421b44e

sec: add default args Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 5 days

issue commentgo-jira/jira

ERROR reporter: Reporter is required.

@wkoszek ive been phasing the php tests out for go native ones. The tests in _t are not parallel safe and flake. Eventually _t should go away.

Here are tests ive translated. These run on CICD https://github.com/go-jira/jira/tree/master/test

wkoszek

comment created time in 5 days

push eventldelossa/quay

Jonathan King

commit sha 9a00f6c3756c1f8dfbcaf84d8d056594a085484c

added values to schema.py

view details

push time in 5 days

PR merged ldelossa/quay

Added Config Values to schema.py

Description of Changes

  • Added values to schema.py

Reviewer Checklist

  • [ ] It works!
  • [ ] Comments provide sufficient explanations for the next contributor
  • [ ] Tests cover changes and corner cases
  • [ ] Follows Quay syntax patterns and format
+10 -0

0 comment

1 changed file

jonathankingfc

pr closed time in 5 days

push eventldelossa/quay

ldelossa

commit sha 0b93c0c3b67a9c835f78ffca16c9a453cbbc40ae

sec: implement jwt signing to ClairV4 this commit adds jwt signing directly in Quay when contacting ClairV4 Signed-off-by: ldelossa <louis@localhost.localdomain>

view details

push time in 5 days

push eventldelossa/quay

ldelossa

commit sha bc14a7b8fffc5121e36e35fd6394598aefd25564

sec: implement jwt signing to ClairV4 this commit adds jwt signing directly in Quay when contacting ClairV4 Signed-off-by: ldelossa <louis@localhost.localdomain>

view details

push time in 5 days

push eventldelossa/quay

ldelossa

commit sha cfcb5ffeb8e1455952bdbb339a52d1ab8b4d388d

sec: implement jwt signing to ClairV4 this commit adds jwt signing directly in Quay when contacting ClairV4 Signed-off-by: ldelossa <louis@localhost.localdomain>

view details

push time in 5 days

push eventldelossa/quay

ldelossa

commit sha a33938ef48acb2a5e6f810ba88ae9d0a34586079

sec: implement jwt signing to ClairV4 this commit adds jwt signing directly in Quay when contacting ClairV4 Signed-off-by: ldelossa <louis@localhost.localdomain>

view details

push time in 5 days

push eventldelossa/quay

ldelossa

commit sha dc6ee87880b957f454f0d064ecef6e222a746b98

sec: implement jwt signing to ClairV4 this commit adds jwt signing directly in Quay when contacting ClairV4 Signed-off-by: ldelossa <louis@localhost.localdomain>

view details

push time in 5 days

push eventldelossa/quay

ldelossa

commit sha 30a35765ce667cff8b5906c64f879eca7f9256b7

sec: implement jwt signing to ClairV4 this commit adds jwt signing directly in Quay when contacting ClairV4 Signed-off-by: ldelossa <louis@localhost.localdomain>

view details

push time in 5 days

push eventgo-jira/jira

Keien Ohta

commit sha c2abbd986431f1d85aaed58aaf696e0eb2ff5a34

update templates with emailAddress and login go-jira/jira#369

view details

Keien Ohta

commit sha 6fbc522ee7cf321c063f729346423e38c4760ae3

also use login for subtask

view details

push time in 5 days

PR merged go-jira/jira

Reviewers
update templates with emailAddress and login

addresses go-jira/jira#369

whether we use emailAddress here or displayName is probably up for debate, but like I said in the above issue, I find emailAddress to be more consistent

I also didn't change displayName to emailAddress in non-edit commands like view - this is probably also up for debate

+15 -15

1 comment

3 changed files

keien

pr closed time in 5 days

pull request commentgo-jira/jira

update templates with emailAddress and login

I agree, email address is better. You touched on how display names can return multiple values in a query. Email addresses should not if fully qualified.

keien

comment created time in 5 days

push eventldelossa/quay

ldelossa

commit sha c873e9bfffdf6fabf6f5ef93d2ebbbeb2cd8850c

sec: implement jwt signing to ClairV4 this commit adds jwt signing directly in Quay when contacting ClairV4 Signed-off-by: ldelossa <louis@localhost.localdomain>

view details

push time in 5 days

PR opened quay/quay

sec: implement jwt signing to ClairV4

this commit adds jwt signing directly in Quay when contacting ClairV4

Signed-off-by: ldelossa louis@localhost.localdomain

Issue: https://issues.redhat.com/browse/PROJQUAY-??? Pull-request title must start with "PROJQUAY-??? - "

Changelog:

Docs:

Testing:

Details:


(This section may be deleted.) All fields are required. If a field is not applicable (eg. no relevant CHANGELOG.md), specify "none" or "n/a".

Issue: This is the PROJQUAY jira reference. Pull-request title must start with issue name "PROJQUAY-1234 - ".

Changelog: One line description to be added to CHANGELOG.md during release builds. Typically starts with "Added:", "Fixed:", "Note:", etc.

Docs: Detailed description of changes necessary to docs.projectquay.io. Examples would be addition of config.yaml, indication of UI changes and screenshot impact, and changes in behavior of features.

Testing: Detailed description of how to test changes manually. This section combined with the Docs section above must be sufficiently clear for full test cases to be performed.

Details: Other information meant for pull-request reviewers and developers.

+38 -2

0 comment

6 changed files

pr created time in 5 days

create barnchldelossa/quay

branch : louis/jwt-clairv4

created branch time in 5 days

push eventquay/clair

Alec Merdler

commit sha 5fde750ccb3cbd3531bfc7d837af8b52f9642e0e

fix struct field typo for webhook config Signed-off-by: Alec Merdler <alecmerdler@gmail.com>

view details

push time in 5 days

PR merged quay/clair

Reviewers
Notifier Config Typo

Description

s/Webbook/Webhook

+3 -3

0 comment

2 changed files

alecmerdler

pr closed time in 5 days

PullRequestReviewEvent

Pull request review commentquay/clair

logging: add similar logging to v3

+package httptransport++import (+	"net/http"+	"strconv"+	"time"++	"github.com/rs/zerolog"+)++type httpStatusWriter struct {+	http.ResponseWriter++	StatusCode int+}++// LoggingHandler will log HTTP requests using the pre initialized zerolog.+func LoggingHandler(next http.Handler) http.HandlerFunc {+	return func(w http.ResponseWriter, r *http.Request) {+		start := time.Now()++		log := zerolog.Ctx(r.Context())++		next.ServeHTTP(w, r)++		log.Info().+			Str("remote addr", r.RemoteAddr).+			Str("method", r.Method).+			Str("request uri", r.RequestURI).+			Str("status", strconv.Itoa(http.StatusOK)).+			Float64("elapsed time (md)", float64(time.Since(start).Nanoseconds())*1e-6).

Also, does this need to be a float64 at all? Looks like you get an Int with Nanoseconds.

mcoops

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentquay/clair

logging: add similar logging to v3

+package httptransport++import (+	"net/http"+	"strconv"+	"time"++	"github.com/rs/zerolog"+)++type httpStatusWriter struct {+	http.ResponseWriter++	StatusCode int+}++// LoggingHandler will log HTTP requests using the pre initialized zerolog.+func LoggingHandler(next http.Handler) http.HandlerFunc {+	return func(w http.ResponseWriter, r *http.Request) {+		start := time.Now()++		log := zerolog.Ctx(r.Context())++		next.ServeHTTP(w, r)++		log.Info().+			Str("remote addr", r.RemoteAddr).+			Str("method", r.Method).+			Str("request uri", r.RequestURI).+			Str("status", strconv.Itoa(http.StatusOK)).+			Float64("elapsed time (md)", float64(time.Since(start).Nanoseconds())*1e-6).

small nit; dividing by the constants in time package maybe a little cleaner.

(time.Since(start).Nanoseconds()/int64(time.Millisecond))
mcoops

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent
MemberEvent

push eventquay/claircore

ldelossa

commit sha 1566fc58d4d2659514240c382a1c6f7dc38da194

cicd: fix commit check regexp Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 5 days

PR merged quay/claircore

Reviewers
cicd: fix commit check regexp

Signed-off-by: ldelossa ldelossa@redhat.com

+1 -1

0 comment

1 changed file

ldelossa

pr closed time in 5 days

push eventquay/claircore

Ales Raszka

commit sha f4d10b53bcb1361f5de446c42ae0f4d271f070c3

RHEL: Use last-modified to cache data Sometime E-tag doesn't work as expected so adding last-modified makes sure we don't update same file multiple times if it hasn't changed. Signed-off-by: Ales Raszka <araszka@redhat.com>

view details

ldelossa

commit sha 123b812b02b26de9146dcf5fed3c620864ecf2be

chore: v0.1.7 changelog bump

view details

Louis DeLosSantos

commit sha 2d075ff2da73b9d74170615a2c11fac52661e68b

Merge branch 'master' into louis/commit-check-fix

view details

push time in 5 days

created tagquay/claircore

tagv0.1.7

foundation modules for scanning container packages and reporting vulnerabilities

created time in 5 days

push eventquay/claircore

ldelossa

commit sha 123b812b02b26de9146dcf5fed3c620864ecf2be

chore: v0.1.7 changelog bump

view details

push time in 5 days

PR merged quay/claircore

Reviewers
v0.1.7 Changelog Bump

This is an automated changelog commit.

+9 -1

0 comment

1 changed file

github-actions[bot]

pr closed time in 5 days

PullRequestReviewEvent

issue commentgo-jira/jira

ERROR reporter: Reporter is required.

Nice. @keien that makes sense since to get around "username" deprecation, we now use the "query" field in the search. The query definitely matches any display names with the same prefix. I think youre correct on wanting to use email address.

@wkoszek the tests correctly work against a cloud jira server. Are you suggesting having the tests work against a self hosted jira as well?

wkoszek

comment created time in 5 days

issue commentgo-jira/jira

ERROR reporter: Reporter is required.

@keien that would be a good one to start checking out. Want to see if you can figure out why? Place anything you find in that ticket.

wkoszek

comment created time in 6 days

issue commentgo-jira/jira

Any active maintainers?

@keien can you help confirm or deny this: https://github.com/go-jira/jira/issues/369

Right now its not a bug for me. So a little hard to test.

mvdan

comment created time in 6 days

push eventldelossa/distlock

Louis DeLosSantos

commit sha 6844a3589146ac8fec73c0c9aaccc385146aea3c

Merge pull request #1 from ldelossa/custom-ctx-impl Custom ctx impl

view details

push time in 6 days

push eventldelossa/distlock

ldelossa

commit sha 49f5c94c9aa1ae4ab5e33004778d1356451f6056

ctx implementation working

view details

ldelossa

commit sha a19f98f282cf74561f27b6494d54a7add7b5db76

gh action tests

view details

ldelossa

commit sha cdd48c377f51ca319309e2f46238432474d55445

add bench

view details

ldelossa

commit sha 8e4ed139cf9679529c94d7865af35c670dbf5d8c

use request pool

view details

ldelossa

commit sha 88ce4331e17e31d8f83f34a306f489ec7f3699aa

lock query via row count

view details

Louis DeLosSantos

commit sha 183e623cf07a1acdc00fc0081f636e593ec6f220

Merge pull request #1 from ldelossa/custom-ctx-impl Custom ctx impl

view details

push time in 6 days

PR merged ldelossa/distlock

Custom ctx impl
+524 -193

0 comment

10 changed files

ldelossa

pr closed time in 6 days

PR opened ldelossa/distlock

Custom ctx impl
+524 -193

0 comment

10 changed files

pr created time in 6 days

push eventldelossa/distlock

ldelossa

commit sha 88ce4331e17e31d8f83f34a306f489ec7f3699aa

lock query via row count

view details

push time in 6 days

push eventldelossa/clair

ldelossa

commit sha 4f35fd0959cbfb2f7c195c45d17d1c90ca1b7390

docs: rework mdbook this commit overhauls the ClairV4 documentation Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

Louis DeLosSantos

commit sha 5e1ac4d2bcd4cde60f899241f3969e1ff554f014

Apply suggestions from code review docs: copy editor revisions Co-authored-by: Hank Donnay <hdonnay@gmail.com> Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 6 days

push eventquay/clair

ldelossa

commit sha 4f35fd0959cbfb2f7c195c45d17d1c90ca1b7390

docs: rework mdbook this commit overhauls the ClairV4 documentation Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

Louis DeLosSantos

commit sha 5e1ac4d2bcd4cde60f899241f3969e1ff554f014

Apply suggestions from code review docs: copy editor revisions Co-authored-by: Hank Donnay <hdonnay@gmail.com> Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 6 days

PR merged quay/clair

Reviewers
docs: rework mdbook

this commit overhauls the ClairV4 documentation

Signed-off-by: ldelossa ldelossa@redhat.com

+3260 -473

0 comment

40 changed files

ldelossa

pr closed time in 6 days

Pull request review commentquay/clair

docs: rework mdbook

+# Notifications++ClairV4 implements a notification system.++The notifier service will keep track of new security database updates and inform an interested client if new or removed vulnerabilites affect an indexed manifest.++The interested client can subscribe to notifications via several substrates:+* Webhook delivery+* AMQP delivery+* STOMP delivery++Configuring the notifier is done via the yaml configuration. ++See the "Notifier" object in our [config reference](../reference/config.md)++## A Notification++When the notifier becomes aware of new vulnerabilities affecting an index manifest it will inform the client of the change. The client will receive a single notification expressing the **most servere** vulnerability inducing the change. This avoids the situation where a client gets bombarded with notifications for the same security database update. ++Once a client receives this notification they should issue a new request again the [matcher](../reference/matcher.md) to receive a up-to-date vulnerability report.++The notification schema will be the json mashalled form of the following schema:++```go+// Reason indicates the catalyst for a notification+type Reason string+const (+	Added   Reason = "added"+	Removed Reason = "removed"+	Changed Reason = "changed"+)+type Notification struct {+	ID            uuid.UUID        `json:"id"`+	Manifest      claircore.Digest `json:"manifest"`+	Reason        Reason           `json:"reason"`+	Vulnerability VulnSummary      `json:"vulnerability"`+}+type VulnSummary struct {+	Name           string                  `json:"name"`+	Description    string                  `json:"description"`+	Package        *claircore.Package      `json:"package,omitempty"`+	Distribution   *claircore.Distribution `json:"distribution,omitempty"`+	Repo           *claircore.Repository   `json:"repo,omitempty"`+	Severity       string                  `json:"severity"`+	FixedInVersion string                  `json:"fixed_in_version"`+	Links          string                  `json:"links"`+}+```++## Webhook Delivery+*See the "Notifier.Webhook" object in our [config reference](../reference/config.md) for complete configuration details.*++When you configure notifier for webhook delivery you provide the service with the following pieces of information:+* A target URL where the webhook will fire+* The callback URL where the notifier may be reached including its API path+    * e.g. "http://clair-notifier/api/v1/notifications"++When the notifier has determined an updated security database has changed the affected status of an indexed container it will deliver the following json body to the configured target:+```json+{+  "notifiction_id": {uuid_string},+  "callback": {url_to_notifications}

yup, just checked with

Here is a string "<help>"

renders to: Here is a string ""

thinks its a custom tag :(

ldelossa

comment created time in 6 days

PullRequestReviewEvent

push eventldelossa/clair

Louis DeLosSantos

commit sha e6b746874fa659f0eb5d0c2e2b4085c30306c2ae

Apply suggestions from code review docs: copy editor revisions Co-authored-by: Hank Donnay <hdonnay@gmail.com> Signed-off-by: ldelossa <ldelossa@redhat.com>

view details

push time in 6 days

push eventldelossa/clair

Louis DeLosSantos

commit sha b86bd62a871e40523f0d130be2e7f0d13da3d5ec

Apply suggestions from code review docs: copy editor revisions Co-authored-by: Hank Donnay <hdonnay@gmail.com>

view details

push time in 6 days

push eventquay/claircore

Ales Raszka

commit sha f4d10b53bcb1361f5de446c42ae0f4d271f070c3

RHEL: Use last-modified to cache data Sometime E-tag doesn't work as expected so adding last-modified makes sure we don't update same file multiple times if it hasn't changed. Signed-off-by: Ales Raszka <araszka@redhat.com>

view details

push time in 6 days

PR merged quay/claircore

Reviewers
RHEL: Use last-modified to cache data

Sometime E-tag doesn't work as expected so adding last-modified makes sure we don't update same file multiple times if it hasn't changed.

Signed-off-by: Ales Raszka araszka@redhat.com

+1 -3

0 comment

2 changed files

Allda

pr closed time in 6 days

PullRequestReviewEvent

push eventldelossa/distlock

ldelossa

commit sha cdd48c377f51ca319309e2f46238432474d55445

add bench

view details

ldelossa

commit sha 8e4ed139cf9679529c94d7865af35c670dbf5d8c

use request pool

view details

push time in 6 days

more