profile
viewpoint
Louis DeLosSantos ldelossa Red Hat Brooklyn, NY https://ldelossa.wordpress.com/ Software Engineer at CoreOS/RedHat

ldelossa/bg_deploy 2

Script for handling blue green deployments in AWS

cloudscaleorg/graphx 1

Time series metrics, real time, to the browser

ldelossa/APIclient 1

Golang scaffolding code for an API client

cloudscaleorg/events 0

etcd backed event streams

ldelossa/alpine-secdb 0

Alpine Linux security database

ldelossa/ant-design 0

🐜 A UI Design Language

Pull request review commentquay/clair

Improve the documentation on running Clair

+version: '3.7'++services:+  clair:+    image: quay.io/coreos/clair:latest

The issue i see here is by pulling :latest the user will not always run the Clair version they may think.

hrist0stoichev

comment created time in 2 days

push eventquay/claircore

ldelossa

commit sha 4ab14f34f9fcfc007d9cb608510fc4b4566aa7b4

remove unhelpful tests

view details

push time in 3 days

push eventquay/claircore

ldelossa

commit sha 9afde98adc28df4b895f0e8b3a7fb5321aca76a6

make aws relaseToDist consistent

view details

push time in 3 days

Pull request review commentquay/claircore

Louis/distribution scanner

+package aws++import (+	"bytes"+	"context"+	"regexp"+	"runtime/trace"++	"github.com/quay/claircore"+	"github.com/quay/claircore/internal/indexer"+	"github.com/rs/zerolog"+)++// AWS Linux keeps a consistent os-release file between+// major releases.+// All tested images on docker hub contained os-release file++const (+	scannerName    = "aws"+	scannerVersion = "v0.0.1"+	scannerKind    = "distribution"+)++type awsRegex struct {+	release Release+	regexp  *regexp.Regexp+}++var awsRegexes = []awsRegex{+	{+		release: Linux1,+		regexp:  regexp.MustCompile(`Amazon Linux AMI 2018.03`),+	},+	{+		release: Linux2,+		regexp:  regexp.MustCompile(`Amazon Linux 2`),+	},+}++const osReleasePath = `etc/os-release`++var _ indexer.DistributionScanner = (*DistributionScanner)(nil)+var _ indexer.VersionedScanner = (*DistributionScanner)(nil)++// DistributionScanner attempts to discover if a layer+// displays characteristics of a AWS distribution+type DistributionScanner struct{}++// Name implements scanner.VersionedScanner.+func (*DistributionScanner) Name() string { return scannerName }++// Version implements scanner.VersionedScanner.+func (*DistributionScanner) Version() string { return scannerVersion }++// Kind implements scanner.VersionedScanner.+func (*DistributionScanner) Kind() string { return scannerKind }++// Scan will inspect the layer for an os-release or lsb-release file+// and perform a regex match for keywords indicating the associated AWS release+//+// If neither file is found a (nil,nil) is returned.+// If the files are found but all regexp fail to match an empty distribution is returned.+func (ds *DistributionScanner) Scan(ctx context.Context, l *claircore.Layer) ([]*claircore.Distribution, error) {+	defer trace.StartRegion(ctx, "Scanner.Scan").End()+	log := zerolog.Ctx(ctx).With().+		Str("component", "aws_dist_scanner").+		Str("name", ds.Name()).+		Str("version", ds.Version()).+		Str("kind", ds.Kind()).+		Str("layer", l.Hash).+		Logger()+	log.Debug().Msg("start")+	defer log.Debug().Msg("done")+	files, err := l.Files(osReleasePath)+	if err != nil {+		log.Debug().Msg("didn't find an os-release")+		return nil, nil+	}+	for _, buff := range files {+		dist := ds.parse(buff)+		if dist != nil {+			return []*claircore.Distribution{dist}, nil+		}+	}+	return []*claircore.Distribution{&claircore.Distribution{}}, nil+}++// parse attempts to match all AWS release regexp and returns the associated+// distribution if it exists.+//+// separated to it's own method to aide testing.+func (ds *DistributionScanner) parse(buff *bytes.Buffer) *claircore.Distribution {+	for _, ur := range awsRegexes {+		if ur.regexp.Match(buff.Bytes()) {+			dist, err := releaseToDist(ur.release)+			if err != nil {+				panic("aws distrubution scanner: awsRegex configured with unknown release")

doesn't need too. all other releaesToDist just return an empty dist if it cannot determine one. I'll update to be consistent.

ldelossa

comment created time in 3 days

push eventquay/claircore

ldelossa

commit sha 1fde039b8dcda983a5219e040e8850a9e7b158a8

fix error, update component log

view details

push time in 3 days

push eventquay/claircore

ldelossa

commit sha 930a36232e7578d8d301af246a149ba4f9e59e43

update test names, update comments

view details

push time in 4 days

push eventquay/claircore

Yoan Blanc

commit sha 2030a929b0cc259d1a59159d5e53d6b51d6d5cbc

feat: add jUnit reports to cctool Signed-off-by: Yoan Blanc <yoan@dosimple.ch>

view details

Hank Donnay

commit sha dbd6ba2edfd85e6fb4b4b0ed0374dc15d66fe43a

docs: use mdBook config file instead of weird symlinks

view details

Hank Donnay

commit sha f2dcacc326a208eb9a80c93dcb652592511dfa5d

all: logging consistency pass

view details

Hank Donnay

commit sha 1bec5c952bdb650e3b0a7856e7eeba01d75c967f

postgres: retrieve updater informaition

view details

ldelossa

commit sha eeb8ac628ae9720dad9ca0fd1bcefedc30c53870

ubuntu dist scanner

view details

Louis Delossantos

commit sha 7f446fdfd3b52d174fae2cd8f87007a359a09867

debian distribution scanner

view details

Louis Delossantos

commit sha 583d0570cab846809cf74d35fbf9fbc201c66ad5

oracle distro scanner

view details

Louis Delossantos

commit sha 76a94b0afca7e9e8d221e1c72790c010b9380b54

suse distribution scanner

view details

ldelossa

commit sha e804d7404fa54acee4cd70d34738d70488767fb5

rhel distribution scanner

view details

ldelossa

commit sha 48edf8580c2623345d97fb18f2c96ece1a26d39e

aws distribution scanner

view details

Louis Delossantos

commit sha e3796665cf23c53b586b333961d6c5a34895b776

alpine distribution scanner

view details

push time in 4 days

PR opened quay/claircore

Louis/distribution scanner

This PR implements distribution scanners for each supported distribution. Alternative methods are used since many containers do not have os-release files. All detected distributions or normalized to reflect how their secdb's are organized.

Draft while I do a little cleanup.

+2366 -32

0 comment

21 changed files

pr created time in 4 days

push eventquay/claircore

Louis Delossantos

commit sha 2b0ca5dd00b7bbec38d4152e2e1e8009eb605d78

alpine distribution scanner

view details

push time in 4 days

Pull request review commentquay/claircore

cctool: add "manifest" subcommand

+package main++import (+	"bufio"+	"bytes"+	"context"+	"encoding/json"+	"errors"+	"flag"+	"fmt"+	"os"+	"strings"+	"sync"+	"time"+)++type manifestConfig struct {+	timeout time.Duration+	pretty  bool+}++// Manifest is the subcommand for generating container manifests.+func Manifest(cmd context.Context, cfg *commonConfig, args []string) error {

var name cmd intentional?

hdonnay

comment created time in 4 days

Pull request review commentquay/claircore

cctool: add "manifest" subcommand

 # Contributors+This is some documentation helpful for the actual nuts-n-bolts of adding code to

👍

hdonnay

comment created time in 4 days

push eventquay/claircore

ldelossa

commit sha c80c9037a4acd65dc81db3a52051a555fc13845b

aws distribution scanner

view details

push time in 5 days

push eventldelossa/dotfiles

Louis Delossantos

commit sha 8deb1daae811bfb61f283c95ca454ec9fd2d224f

adjust vimlight time

view details

push time in 5 days

push eventquay/claircore

ldelossa

commit sha 04cb83af08390d842ee45c07c406aff3f27b2f76

rhel distribution scanner

view details

push time in 5 days

push eventquay/claircore

Louis Delossantos

commit sha 17caf33bb77bb0b7fadece6121ee4c43c293f856

suse distribution scanner

view details

push time in 5 days

push eventquay/clair

qiang Xu

commit sha 8a2bb8ce1d77414a53dca0225b7caa555a2f406b

Update running-clair.md

view details

Louis DeLosSantos

commit sha bfa0d8a3da3ad4c0317caa875ee1bfaf05a053f5

Merge pull request #904 from xuqiang76/master Update running-clair.md

view details

push time in 6 days

PR merged quay/clair

Reviewers
Update running-clair.md
+1 -1

1 comment

1 changed file

xuqiang76

pr closed time in 6 days

pull request commentquay/clair

Update running-clair.md

Thanks.

xuqiang76

comment created time in 6 days

push eventquay/claircore

Louis Delossantos

commit sha 434e7febe70f7089f6671bc95edff8c0ac146b8f

oracle distro scanner

view details

push time in 6 days

push eventquay/claircore

Louis Delossantos

commit sha e245f553156e09c86430d517f413ff571bda0a78

debian distribution scanner

view details

push time in 6 days

push eventquay/claircore

Louis Delossantos

commit sha b9f1b2604f1e48f323745694393958ae7d8912f3

debian distribution scanner

view details

push time in 6 days

push eventquay/claircore

ldelossa

commit sha 2c375eeca5f4702e979b311e348507bff9b1ca73

ubuntu dist scanner

view details

push time in 6 days

push eventquay/claircore

ldelossa

commit sha add09d1c162de224ca13d9e9a154f61f6fc100de

ubuntu dist scanner

view details

push time in 6 days

push eventquay/claircore

ldelossa

commit sha 4b3ecbbe88ee773e9eb14407c356f2e95680f482

ubuntu dist scanner

view details

push time in 6 days

push eventldelossa/dotfiles

Louis Delossantos

commit sha d91dc01154c3f1f6591e43a59fac95d505da665d

fix dark/light colorscheme times

view details

push time in 6 days

push eventldelossa/dotfiles

Louis Delossantos

commit sha d685c8adc031123f325cbd4c1e4836272083d737

ssh-add .ssh dir

view details

push time in 6 days

push eventquay/claircore

ldelossa

commit sha ed4421a12ffaf4173510bfc1df2d9a1f383a44d4

ubuntu dist scanner

view details

push time in 6 days

create barnchquay/claircore

branch : louis/distribution-scanner

created branch time in 6 days

push eventquay/clair

Martin Vrachev

commit sha d55f9464c57ce86e91e0c8b3545d34c67f5c531e

Remove "Up and running" link duplication in README There is the " Follow instructions to get Clair [up and running]" link on the README and the "Get up and running with [Local Development]" link on the README. The second is a subset of the first and it doesn't make sense to include it on the README.

view details

Louis DeLosSantos

commit sha 0a67600a176f6f6a587c2a1a1a974fc32e7434d2

Merge pull request #908 from MVrachev/patch-3 Remove "Up and running" link duplication in README

view details

push time in 10 days

PR merged quay/clair

Reviewers
Remove "Up and running" link duplication in README

There is the " Follow instructions to get Clair [up and running]" link on the README and the "Get up and running with [Local Development]" link on the README. The second is a subset of the first and it doesn't make sense to include it on the README.

Signed-off-by: Martin Vrachev mvrachev@vmware.com

+0 -1

0 comment

1 changed file

MVrachev

pr closed time in 10 days

push eventquay/claircore

ldelossa

commit sha d625ee8f1210a542d0243d869ae12fc9bdcebf6d

refactor versionscanners methods

view details

push time in 10 days

push eventquay/clair

Martin Vrachev

commit sha 5a3f316c836c437256d7357c2ce3932ca52db123

Remove misleading sentence from README In the README it says that in order to read the rest of Clair's documentation we should go to the CoreOs website. On the CoreOs website there is a message which says: "These docs are deprecated while they are being migrated to Red Hat. For the most up to date docs, please see the corresponding GitHub repository." So, it doesn't make sense to point the people to the CoreOs website. Also, it doesn't make sense to point them to the documentation folder on GitHub when every documentation page has its own link on the README. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>

view details

Louis DeLosSantos

commit sha b69131db3aa007ccf36ba47f733fb97110d8ae7d

Merge pull request #907 from MVrachev/patch-2 Remove misleading sentence from README

view details

push time in 10 days

PR merged quay/clair

Reviewers
Remove misleading sentence from README

In the README it says that in order to read the rest of Clair's documentation we should go to the CoreOs website. On the CoreOs website there is a message which says: "These docs are deprecated while they are being migrated to Red Hat. For the most up to date docs, please see the corresponding GitHub repository."

So, it doesn't make sense to point the people to the CoreOs website. Also, it doesn't make sense to point them to the documentation folder on GitHub when every documentation page has its own link on the README.

Signed-off-by: Martin Vrachev mvrachev@vmware.com

+0 -1

0 comment

1 changed file

MVrachev

pr closed time in 10 days

pull request commentfatih/vim-go

Louis/vim8 term mode

@bhcleek think this PR is ready for those tests you mentioned.

ldelossa

comment created time in 10 days

push eventldelossa/vim-go

ldelossa

commit sha 3039bdc7f098e8b675a3228e99865f9a5582c5c3

handle vertical modifiers correctly

view details

push time in 10 days

issue commentquay/clair

RHEL OVAL isn't filtered to only x86 packages

@savujevi @Allda ClairCore (the library which will back ClairV4) has initial support for architecture. https://github.com/quay/claircore/blob/master/distribution.go#L31 https://github.com/quay/claircore/blob/master/vulnerability.go#L22

We haven't applied it's filtering yet, but it all the pieces are in place or this to work out of the box in ClairV4.

savujevi

comment created time in 10 days

push eventquay/claircore

ldelossa

commit sha 573ec7ffe91f753c376263933652ead434dafb68

return empty if no vscnrs in db methods

view details

push time in 10 days

push eventquay/claircore

ldelossa

commit sha 8881690d0b726e8b98b19323578b49c3f62915c0

return empty if no vscnrs in db methods

view details

push time in 10 days

PR opened quay/claircore

Reviewers
Louis/remove db coalescer

This PR removes the indexer's Store implementation from the Coalescer implementations. This is step one to moving internal indexer interfaces to a driver package.

+143 -103

0 comment

12 changed files

pr created time in 10 days

create barnchquay/claircore

branch : louis/remove-db-coalescer

created branch time in 10 days

Pull request review commentfatih/vim-go

Louis/vim8 term mode

 function! go#term#newmode(bang, cmd, errorformat, mode) abort           \ 'exit_cb' : function('s:exit_cb', [], state),         \ } -    if l:mode =~ "vertical" || l:mode =~ "vsplit" || l:mode =~ "vnew"-      let l:term["vertical"] = 1+    if !(l:mode =~ "split") || !(l:mode =~ "new")

ahh I see now, I haven't used these modifiers before. So the correct thing to do would be

if l:mode =~ "vertical" || l:mode =~ "vsplit" || l:mode =~ "vnew"
      let l:term["vertical"] = l:mode
endif

and leave it at that?

ldelossa

comment created time in 10 days

Pull request review commentquay/claircore

Don't persist empty packages

 func putVulnerabilities(ctx context.Context, pool *pgxpool.Pool, updater string, 	} 	defer tx.Rollback(ctx) +	skipCt := 0 	// safe sized batch inserts to postgres 	mBatcher := microbatch.NewInsert(tx, 2000, time.Minute) 	for _, vuln := range vulns {-		if vuln.Package == nil {-			vuln.Package = &claircore.Package{}+		if vuln.Package == nil || vuln.Package.Name == "" {+			skipCt+++			continue 		} 		if vuln.Dist == nil {

@hdonnay

Thinking about it... all matchers return a MatchContraint which means they require their pending vulns to have dists as well.

hdonnay

comment created time in 12 days

Pull request review commentquay/claircore

Don't persist empty packages

 func indexPackages(ctx context.Context, db *sqlx.DB, pool *pgxpool.Pool, pkgs [] 	if err != nil { 		return fmt.Errorf("final batch insert failed for package_scanartifact: %v", err) 	}+	log.Debug().+		Int("skipped", skipCt).+		Int("inserted", len(pkgs)-skipCt).+		Msg("scanartifactss inserted")

double s :snake:

hdonnay

comment created time in 12 days

Pull request review commentquay/claircore

Don't persist empty packages

 func putVulnerabilities(ctx context.Context, pool *pgxpool.Pool, updater string, 	} 	defer tx.Rollback(ctx) +	skipCt := 0 	// safe sized batch inserts to postgres 	mBatcher := microbatch.NewInsert(tx, 2000, time.Minute) 	for _, vuln := range vulns {-		if vuln.Package == nil {-			vuln.Package = &claircore.Package{}+		if vuln.Package == nil || vuln.Package.Name == "" {+			skipCt+++			continue 		} 		if vuln.Dist == nil {

@hdonnay I'm thinking... if we do not have a distribution associated with the vulnerability - we don't match it either... With your knowledge of the RPM stuff as well does it make sense to ignore vulns where we can't get a distribution either? Most of the time we munge this field ourselves anyway.

hdonnay

comment created time in 12 days

Pull request review commentquay/claircore

Makefile: add mdbook target

 baseimage: 		--build-arg GO_VERSION=$(GO_VERSION) \ 	   	--build-arg GO_CHECKSUM=$(GO_CHECKSUM) \ 		etc++.PHONY: mdbook+mdbook:+	# This is some faffing about to make it look like the CI environment.

tnit: he word faffing make me feel uncomfortable.

hdonnay

comment created time in 12 days

delete branch quay/claircore

delete branch : louis/doc-no-dots

delete time in 12 days

push eventquay/claircore

Louis DeLosSantos

commit sha 04b367fd2392a2ebbaa2deb5e89eea2557fa89dd

slim readme, dots to slashes (#102)

view details

push time in 12 days

PR merged quay/claircore

Reviewers
slim readme, dots to slashes

Slim the readme and point to github pages.s s/./\/g

+5 -14

0 comment

3 changed files

ldelossa

pr closed time in 12 days

PR opened quay/claircore

Reviewers
slim readme, dots to slashes

Slim the readme and point to github pages.s s/./\/g

+5 -14

0 comment

3 changed files

pr created time in 12 days

create barnchquay/claircore

branch : louis/doc-no-dots

created branch time in 12 days

delete branch quay/claircore

delete branch : louis/documentation-reboot

delete time in 12 days

push eventquay/claircore

Louis DeLosSantos

commit sha 049ba1177a0c6b7e17f36533d7f124148956e251

Louis/documentation reboot (#101)

view details

push time in 12 days

PR merged quay/claircore

Reviewers
Louis/documentation reboot

Documentation drifted quite a bit. This reorganizes it and makes it relevant again.

+369 -274

0 comment

25 changed files

ldelossa

pr closed time in 12 days

push eventquay/claircore

ldelossa

commit sha 3998ec5f64aee1a7e91830168f071bcf567de2af

mdbook summary and ci publish

view details

push time in 12 days

push eventquay/claircore

Louis DeLosSantos

commit sha ec565cb466ff52e4b7ccb0ef932a650f6dc57c59

Louis/fastest url (#95)

view details

Louis Delossantos

commit sha 29dab4908cac1787aa644316198e7b49520ee3b5

fix readme

view details

Louis Delossantos

commit sha 21650368a08c48b2e5a9f06e1d444e1c3f56913a

fix typo, remove tombstoning

view details

ldelossa

commit sha 69a170eeed78201f00d70386c461d7bbdf5aac79

rework doc structure

view details

ldelossa

commit sha 2548e7e062c39233ee319adcbd6840000861bc16

bump indexer state diagram

view details

ldelossa

commit sha 262ea47026e25852f8cac1b245a48fcbc49e219a

bump indexer state diagram again

view details

ldelossa

commit sha 1b3053507bea4c040de6799a3bc31c19fad40a0c

add match constraint explanation

view details

ldelossa

commit sha 0cc9d4fab1c0cb5c5dc3ef43f940b99cf1e1b72a

add keyword formatting

view details

ldelossa

commit sha ed07348e9f756cd02227faa6b51c2f6dec9122f1

bump diagram, fix doc ref, touchup local dev

view details

ldelossa

commit sha 4b7598a718a27e6be44880ddc684fbe65111a8df

touchup readme wording

view details

ldelossa

commit sha f687bac1f67336e113dc8e3b3b6fb8c3d92b254c

fix matcher architecture diagram ref

view details

ldelossa

commit sha 3eb3edb78368e22a656af223d1c19791660b3cde

dot notation to slash, typos, ws, and alt text

view details

ldelossa

commit sha 64879e3f961518ecea1159bfb63b86876a046f26

README spacing

view details

ldelossa

commit sha adc3cb5101e6ec188d05b1c872e319503f6a2f7b

use consistent naming

view details

ldelossa

commit sha e7fb882fd0a20cf4e59950bace60b223dde7ee70

mdbook summary and ci publish

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha 7295e26dbd2def510f1a293b97071fd2593226e7

mdbook summary and ci publish

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha ade5ba02b16805a862110c8b41b232b704d51cbb

use consistent naming

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha ce926ee495f91c2ac3e5944d871ff69d89d5293d

README spacing

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha b789e8412ba4f2c070f8e4768b980d1e9eb1686e

dot notation to slash, typos, ws, and alt text

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha a0ccf78e81612902409d92d49b65555c09094357

fix matcher architecture diagram ref

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha 8d1f074b5e5970a1ccef854456fd596a563eb9b7

fix matcher architecture diagram ref

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha 4ee6c223fa0aa2c7ba28bfb88123859b509af1e6

fix matcher architecture diagram ref

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha 8bf97aaf5abb77f15d3e42e680b3c05ecc1520ef

fix matcher architecture diagram ref

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha b9c61bf43eec93511417e2615d76a7535e4324c0

fix architecture diagram ref

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha 790f79bb25ef05f076bcda42dcbf6c7977db6d7c

touchup readme wording

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha a6ad58c38cfd602617c5be1f64b9e1cead93c293

touchup readme wording

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha 9b67689cec82e2556dba91dc76ef32b7d3604ea7

touchup readme wording

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha b2ecdbc03b2e3aa3acfbed8039973c22e70eff7f

bump diagram, fix doc ref, touchup local dev

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha e28a172b6176eee237a72afdf835c2e252a9a0fc

bump diagram, fix doc ref, touchup local dev

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha 1da480819bbe66ff513b30e44410782973088400

bump diagram, fix doc ref

view details

push time in 12 days

push eventquay/claircore

Louis DeLosSantos

commit sha ec565cb466ff52e4b7ccb0ef932a650f6dc57c59

Louis/fastest url (#95)

view details

push time in 12 days

PR merged quay/claircore

Reviewers
Louis/fastest url

This PR implements a method of obtaining the fastest http.Response given a list of urls. The intended usage is for lists of mirrors where the same content lives at different hosted servers and you want to a client to receive the first mirror that responds.

+199 -0

0 comment

2 changed files

ldelossa

pr closed time in 12 days

push eventquay/claircore

ldelossa

commit sha 69d72d521575fcd358df0ffe5bf940f146736e97

add keyword formatting

view details

push time in 12 days

Pull request review commentfatih/vim-go

Louis/vim8 term mode

 function! go#term#newmode(bang, cmd, errorformat, mode) abort           \ 'exit_cb' : function('s:exit_cb', [], state),         \ } -    if l:mode =~ "vertical" || l:mode =~ "vsplit" || l:mode =~ "vnew"-      let l:term["vertical"] = 1+    if !(l:mode =~ "split") || !(l:mode =~ "new")

@bhcleek

Does this accomplish the goal? If we do not see l:mode set to the normal split or new modifiers, we then populate l:term["vertical"] with which ever value the user placed in their config. Assuming "split" an "new" are not modifiers... but maybe I'm wrong.

ldelossa

comment created time in 12 days

push eventldelossa/vim-go

ldelossa

commit sha 13eb6f9a84be9cce75c75b6a21e9d3bebddf1c0e

allow additional command modifiers

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha b069c49c309ba03d61af51b0629f2e555634ea5b

add match constraint explanation

view details

push time in 12 days

push eventldelossa/clair

ldelossa

commit sha 05cbe6f26c9e2f74c7a3a621ab1f66c9df97fee1

bump claircore, update openapi.yaml

view details

Hank Donnay

commit sha ac0a0d49424f1f19b5044ea84a245e3139b5adb3

indexer: add Accept-Encoding aware middleware This commit adds a middleware that examines the incoming "accept-encoding" header and attempt to compress the payload accordingly, and sets the `clair` binary to use it automatically.

view details

ldelossa

commit sha 37ee58b166cd8605ff564b9bb280359447fe9d72

make ids opaque strings

view details

ldelossa

commit sha 825d5d7e36aa30dbc7839eb1b64e308c3ab4b95f

bump to v0.0.12

view details

ldelossa

commit sha ea7fd8f214d2c8e55572899f12fe1ecab59e581d

go mod tidy run

view details

Louis DeLosSantos

commit sha efbf785572b06726061c62cadecbbd102044f261

Merge pull request #903 from ldelossa/louis/environment-api environments api

view details

push time in 12 days

push eventquay/claircore

Louis DeLosSantos

commit sha 27ade1d9c22d796bae16d1e8f25b8179b3c59b8c

Louis/dedupe vulns remodel (#93)

view details

Louis DeLosSantos

commit sha 78dd32908245623025ce8bef5cc1583a39510053

lookup ids to strings (#96)

view details

Louis DeLosSantos

commit sha bd3554efc40939d67fd2c25ceca143a6e425b02e

Louis/opaque ids (#98)

view details

Hank Donnay

commit sha 7d6e79bf2515a7ce0f13178ba4444db11ddd7548

all: use bigserials in the database This commit changes the DDL to use bigserials and bigints for IDs, and any code where ids are being read out of the database is updated to use go's int64 type.

view details

Henry Donnay

commit sha d84c6c8ca229f96b8251d217839e269db9dfaa15

validate fetched layers * libindex: add options * test: add options to GenUniqueRepositories * fetcher: rewrite to include validataion logic * controller: update to call Validate * layerscanner: update test * postgres: update test * indexer: update fetcher interface * test: replace GenUniqueLayersRemote with ServeLayers * libindex: update fetcher call and test * claircore: update Layer struct * moby: remove package * update mocks * controller: update tests * alpine: update tests * dpkg: update tests * libindex: mark test as integration * osrelease: update tests * rpm: update tests * cctool: update with Layer changes * test: don't panic on nil http.Client * fix integration tests * integration: fix data race on rng * validate original bytestream while downloading

view details

Hank Donnay

commit sha 064e0f673d0d87585ded6076de4836f9df72ea60

libindex: add location header

view details

Hank Donnay

commit sha 8c1e827b7f205934b8fd2c08f329a024cf790984

cctool: update with datastructure changes and index call semantics

view details

ldelossa

commit sha 3acbadeb5de5aeb1f741507d66422fcb77a3d7cc

initial impl

view details

ldelossa

commit sha 25c09aded201f9ee35767b48fe595fd9927876d2

refactor lock usage, log errors, shorten tests

view details

ldelossa

commit sha 6ca8936e4865b8d1c6f8a4b602523436c8f5859c

fix comments, close body early return

view details

ldelossa

commit sha 20b9a90a1f136175a5a6ae8bd7de8d0b1bccee02

do not derive ctx, comment that caller needs to

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha 4c61bcea634981881134bc4856d89eb75fe7ac3b

bump indexer state diagram again

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha a07176080e647f509c60aa559f5e4834bf30b2f7

do not derive ctx, comment that caller needs to

view details

push time in 12 days

push eventquay/claircore

ldelossa

commit sha 5964240e008743d22f575bacc989282b64721be2

fix comments, close body early return

view details

push time in 12 days

delete branch quay/claircore

delete branch : louis/opaque-ids

delete time in 12 days

delete branch quay/claircore

delete branch : louis/move-suse-https

delete time in 12 days

delete branch quay/claircore

delete branch : louis/controller-fix

delete time in 12 days

push eventquay/claircore

Hank Donnay

commit sha 7d6e79bf2515a7ce0f13178ba4444db11ddd7548

all: use bigserials in the database This commit changes the DDL to use bigserials and bigints for IDs, and any code where ids are being read out of the database is updated to use go's int64 type.

view details

Henry Donnay

commit sha d84c6c8ca229f96b8251d217839e269db9dfaa15

validate fetched layers * libindex: add options * test: add options to GenUniqueRepositories * fetcher: rewrite to include validataion logic * controller: update to call Validate * layerscanner: update test * postgres: update test * indexer: update fetcher interface * test: replace GenUniqueLayersRemote with ServeLayers * libindex: update fetcher call and test * claircore: update Layer struct * moby: remove package * update mocks * controller: update tests * alpine: update tests * dpkg: update tests * libindex: mark test as integration * osrelease: update tests * rpm: update tests * cctool: update with Layer changes * test: don't panic on nil http.Client * fix integration tests * integration: fix data race on rng * validate original bytestream while downloading

view details

Hank Donnay

commit sha 064e0f673d0d87585ded6076de4836f9df72ea60

libindex: add location header

view details

Hank Donnay

commit sha 8c1e827b7f205934b8fd2c08f329a024cf790984

cctool: update with datastructure changes and index call semantics

view details

Louis Delossantos

commit sha f01b465928edafecb95e44a02be3ba001636ca06

fix readme

view details

Louis Delossantos

commit sha 6b43fdf073b5e0ece14226efe1b5dd50f1a39cc2

fix typo, remove tombstoning

view details

ldelossa

commit sha 6a50785627bc786901334177e68f325331c12580

rework doc structure

view details

ldelossa

commit sha fdb915f305fe734d417e1e7312c8fc7c2489a0ff

bump indexer state diagram

view details

ldelossa

commit sha e504bbe1ccfd757d13c94570ef7921a6600e11ed

bump indexer state diagram again

view details

push time in 12 days

PR opened quay/claircore

Reviewers
Louis/documentation reboot

Documentation drifted quite a bit. This reorganizes it and makes it relevant again.

+255 -272

0 comment

20 changed files

pr created time in 13 days

push eventquay/claircore

ldelossa

commit sha 4f4d2e917a9cae111173626571329d59051c6cb5

bump indexer state diagram again

view details

push time in 13 days

push eventquay/claircore

ldelossa

commit sha 1fd2a2066d0e013b5db1fa984a0ae54048381db5

bump indexer state diagram

view details

push time in 13 days

push eventquay/claircore

ldelossa

commit sha ee41bc43076ad0caa3d4d39ba90eeb15fe92fc8b

rework doc structure

view details

push time in 13 days

push eventquay/claircore

Louis Delossantos

commit sha bd580db7aa7481fa449fa9dfaa24c77514fb4dc1

fix typo, remove tombstoning

view details

push time in 14 days

push eventquay/claircore

Louis Delossantos

commit sha 33c2b71317399ed2ce90ac29dc2601ddaa1db6ac

fix readme

view details

push time in 14 days

create barnchquay/claircore

branch : louis/documentation-reboot

created branch time in 14 days

push eventldelossa/dotfiles

ldelossa

commit sha 58ea6e05b9de44f051b46a3e6eb978a6b0911db9

square up configs between linux and mac

view details

push time in 14 days

Pull request review commentfatih/vim-go

Louis/vim8 term mode

 function! go#term#newmode(bang, cmd, errorformat, mode) abort    execute l:cd . fnameescape(expand("%:p:h")) -  execute l:mode . ' __go_term__'--  setlocal filetype=goterm-  setlocal bufhidden=delete-  setlocal winfixheight-  setlocal noswapfile-  setlocal nobuflisted--  " explicitly bind callbacks to state so that within them, self will always-  " refer to state. See :help Partial for more information.-  "-  " Don't set an on_stderr, because it will be passed the same data as-  " on_stdout. See https://github.com/neovim/neovim/issues/2836-  let l:job = {-        \ 'on_stdout': function('s:on_stdout', [], state),-        \ 'on_exit' : function('s:on_exit', [], state),-      \ }--  let l:state.id = termopen(a:cmd, l:job)-  let l:state.termwinid = win_getid(winnr())--  execute l:cd . fnameescape(l:dir)--  " resize new term if needed.   let l:height = go#config#TermHeight()   let l:width = go#config#TermWidth() -  " Adjust the window width or height depending on whether it's a vertical or-  " horizontal split.-  if l:mode =~ "vertical" || l:mode =~ "vsplit" || l:mode =~ "vnew"-    exe 'vertical resize ' . l:width-  elseif mode =~ "split" || mode =~ "new"-    exe 'resize ' . l:height-  endif+  " setup job for nvim+  if has('nvim')+    execute l:mode . ' __go_term__'+    setlocal filetype=goterm+    setlocal bufhidden=delete+    setlocal winfixheight+    setlocal noswapfile+    setlocal nobuflisted++    " explicitly bind callbacks to state so that within them, self will always+    " refer to state. See :help Partial for more information.+    "+    " Don't set an on_stderr, because it will be passed the same data as+    " on_stdout. See https://github.com/neovim/neovim/issues/2836+    let l:job = {+          \ 'on_stdout': function('s:on_stdout', [], state),+          \ 'on_exit' : function('s:on_exit', [], state),+        \ }+    let l:state.id = termopen(a:cmd, l:job)+    let l:state.termwinid = win_getid(winnr())+    execute l:cd . fnameescape(l:dir)++    " Adjust the window width or height depending on whether it's a vertical or+    " horizontal split.+    if l:mode =~ "vertical" || l:mode =~ "vsplit" || l:mode =~ "vnew"+      exe 'vertical resize ' . l:width+    elseif mode =~ "split" || mode =~ "new"+      exe 'resize ' . l:height+    endif+    " we also need to resize the pty, so there you go...+    call jobresize(l:state.id, l:width, l:height)++  " setup term for vim8+  elseif has('terminal')+    let l:term = {+          \ 'term_rows' : l:height,+          \ 'term_cols' : l:width,+          \ 'out_cb': function('s:out_cb', [], state),+          \ 'exit_cb' : function('s:exit_cb', [], state),+        \ }++    if l:mode =~ "vertical" || l:mode =~ "vsplit" || l:mode =~ "vnew"+      let l:term["vertical"] = 1

@bhcleek

Not sure I follow this correctly. That "vertical" is coming from the vim-go config file. Would a user ever have a chance to specify belowright when spawning a terminal via vim-go commands?

ldelossa

comment created time in 14 days

push eventldelossa/dotfiles

ldelossa

commit sha 528a78a1c264ff8840847a28a9c3faa02755bb23

square up configs between linux and mac

view details

push time in 14 days

push eventquay/clair

ldelossa

commit sha 05cbe6f26c9e2f74c7a3a621ab1f66c9df97fee1

bump claircore, update openapi.yaml

view details

ldelossa

commit sha 37ee58b166cd8605ff564b9bb280359447fe9d72

make ids opaque strings

view details

ldelossa

commit sha 825d5d7e36aa30dbc7839eb1b64e308c3ab4b95f

bump to v0.0.12

view details

ldelossa

commit sha ea7fd8f214d2c8e55572899f12fe1ecab59e581d

go mod tidy run

view details

Louis DeLosSantos

commit sha efbf785572b06726061c62cadecbbd102044f261

Merge pull request #903 from ldelossa/louis/environment-api environments api

view details

push time in 15 days

PR merged quay/clair

Reviewers
environments api

API updates for claricore V0.0.11

+116 -215

0 comment

3 changed files

ldelossa

pr closed time in 15 days

push eventldelossa/clair

ldelossa

commit sha ea7fd8f214d2c8e55572899f12fe1ecab59e581d

go mod tidy run

view details

push time in 15 days

push eventldelossa/clair

ldelossa

commit sha 825d5d7e36aa30dbc7839eb1b64e308c3ab4b95f

bump to v0.0.12

view details

push time in 15 days

created tagquay/claircore

tagv0.0.12

foundation modules for scanning container packages and reporting vulnerabilities

created time in 15 days

more