profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/kvbik/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Jakub Vysoký kvbik roudnice nad labem, czech republic https://twitter.com/kvbik

josefprusa/Prusa3 787

Prusa iteration3

HonzaKral/django-threadedcomments 602

django-threadedcomments is a simple yet flexible threaded commenting system for Django.

esPass/pretix-eth-payment-plugin 11

An etheruem payment provider plugin for pretix

kvbik/lightweight-virtualenv 4

lightweight python virtual environment - have a look at rvirtualenv

kvbik/django 3

Unofficial mirror of the Subversion repository (updated every 15 minutes)

kvbik/blogisek 2

muj mily blogisku

kvbik/boto 2

Python interface to Amazon Web Services

aleszoulek/python-munin 1

Python framework for building Munin plugins (also includes some plugins prebuilt).

push eventkvbik/pretix-eth-payment-plugin

Rahul Kothari

commit sha 3205e802022bea0f6e54efe741d506350e365c75

update docs with event set up instructions

view details

Rahul Kothari

commit sha 3621b5e6d6466e2d05905a4232f97d1dff5e1084

add goerli

view details

Rahul Kothari

commit sha 4d2d8e4aad44eee928807ed86bd9be63cd16c456

Change token rates to be written as USD per token

view details

Rahul Kothari

commit sha ec013b7add540a57934ad9229abb9c2ee42e486c

Change token rates to be written as USD per token

view details

Rahul Kothari

commit sha f892030f5be98eef1699fc16fb5eb5c285745c6e

set default empty values for admin settings to prevent 500 errors

view details

Jakub Vysoky

commit sha c335357a57a66ae1fa5d214d08c81c4b963da91b

settings is using NETWORK_IDENTIFIER also do not use angle brackets, since they are interpretted as html :)))

view details

push time in 19 days

CommitCommentEvent

PR opened rahul-kothari/pretix-eth-payment-plugin

tiny fix for help text of the plugin settings

It should be documented much more in README and maybe even elsewhere, but the help text was partially helpful

What was wrong?

part of the help text was not update angle brackets were interpreted as html

+2 -2

0 comment

1 changed file

pr created time in 21 days

create barnchkvbik/pretix-eth-payment-plugin

branch : help-text-fix

created branch time in 21 days

pull request commentesPass/pretix-eth-payment-plugin

Add L2 networks - basic

Cannot create issues in the original reporitory, so here you are:

The payemnt.Ethereum.is_allowed() can bite you pretty hard - it needs to be documented what are the all things you need to setup to make the plugin work:

  • upload list of eth addresses
  • create all the other admin configuration!!!

Ideally it should not fail 500 Internal Server Error when the configs are not in place. You should do at least something like json.loads(settings.get( 'VALUE', default='{}'))... one piece of inspiration is the pretix code itself https://github.com/pretix/pretix/blob/master/src/pretix/base/payment.py#L162

rahul-kothari

comment created time in 21 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

delete branch kvbik/pretix-eth-payment-plugin

delete branch : currency_reaarch-simplify-class-definitions

delete time in a month

pull request commentrahul-kothari/pretix-eth-payment-plugin

add token based classes and refactor till payment options

initial set of comments/suggestions in the PR https://github.com/rahul-kothari/pretix-eth-payment-plugin/pull/5

rahul-kothari

comment created time in a month

pull request commentrahul-kothari/pretix-eth-payment-plugin

simplify token class definitions

I have some more ideas, like: the helpers can go straight on the L1 class, becuase they are not used anywhere else, but we can leave that for later once you implement some other L2 classes. Let me know, what you think about the PR!

kvbik

comment created time in a month

push eventkvbik/pretix-eth-payment-plugin

Jakub Vysoky

commit sha f4327db3bf5853d43ac974531414a540a2928df5

use address when not native token in uniswap_url

view details

push time in a month

PR opened rahul-kothari/pretix-eth-payment-plugin

[WIP] simplify token class definitions

with such a great and generic helpers, there is no need repeat the payment_instructions method its only change was if it was using or not the chain_id and used token address or not

which is all covered in the helpers already

+50 -127

0 comment

1 changed file

pr created time in a month

issue commentefdevcon/pretix-attestation-placeholder-plugin

Do not block serving requests when running the JAR file

I have a lot of experience with celery. The problem here is the asynchronicity - you'd have to have some placeholders before it is filled with the right content. And the email could be sent before we have the proper information...

kvbik

comment created time in a month

issue openedefdevcon/pretix-attestation-placeholder-plugin

Do not block serving requests when running the JAR file

The problem is, that in the web processing time they are opening a subprocess. You have quite a limited number of python server processes (some python wsgi server - gunicorn in our production case), let's say 10 per instance. In case of high web server load (eg.: announcing the conference), the site will be serving a lot of visitors. If at the same time people are also booking the tickets, they can block all of the web server processes! The java subprocess can take some time (microseconds if not seconds) and the web server cannot serve anything else when waiting for the java code to finish.

We need to either make it asynchronous or move it to some place where it does not block the server time that instant. Creating an order can happen way too often and could block the server.

Few ideas:

  1. do the expensive computation (subprocess calling *.jar exec) in the email template
  2. create a background task from it (using celery - django background process - probably used inside pretix, too)
  3. ???

There are of course implications from any of the possible solutions.

created time in a month

push eventkvbik/pretix-attestation-placeholder-plugin

Jakub Vysoky

commit sha 384e5f43ea2615298798d5bc4771c6e47f94e71b

explanation for the two placeholders

view details

push time in 2 months

push eventkvbik/pretix-attestation-placeholder-plugin

Jakub Vysoky

commit sha 44ba608cd01253bc7b2cfd5fca5fbaef03c171e6

better error message

view details

push time in 2 months

push eventkvbik/pretix-attestation-placeholder-plugin

Jakub Vysoky

commit sha c9c1b4bbeefd48520c0b16d90f319b3848361227

fixing tests

view details

push time in 2 months

push eventkvbik/pretix-attestation-placeholder-plugin

Jakub Vysoký

commit sha 33de280a625b2c13bc900e24cdbfbd34b3739c00

flake

view details

push time in 2 months

issue commentefdevcon/pretix-attestation-placeholder-plugin

Use settings value instead of BaseURL model

Gotcha @ligi - It crossed my mind this can be the way it works. Thank you - closing!

kvbik

comment created time in 2 months

issue closedefdevcon/pretix-attestation-placeholder-plugin

Use settings value instead of BaseURL model

There is a DB value specific for this plugin called BaseURL. If it is just the URL where the Pretix instance is running, this value should be define in Django settings (from django.conf import settings) and is called settings.SITE_URL.

closed time in 2 months

kvbik

issue openedefdevcon/pretix-attestation-placeholder-plugin

Use settings value instead of BaseURL model

There is a DB value specific for this plugin called BaseURL. If it is just the URL where the Pretix instance is running, this value should be define in Django settings (from django.conf import settings) and is called settings.SITE_URL.

created time in 2 months

issue commentefdevcon/pretix-attestation-placeholder-plugin

configuration PEM file cannot be saved

This was resolved in #25 - thx.

kvbik

comment created time in 2 months

issue closedefdevcon/pretix-attestation-placeholder-plugin

configuration PEM file cannot be saved

The configuration PEM file is being saved somewhere next to the python code [1], which may work just in development. In production the code directories are usually write-protected.

[1] https://github.com/efdevcon/pretix-attestation-placeholder-plugin/blob/main/pretix_attestation_plugin/views.py#L10

Also Django file uploads are handled [2] in quite specific way - can be configured via backends, stored in a different locations, etc. And this must be followed.

[2] https://docs.djangoproject.com/en/3.2/topics/http/file-uploads/

Another way of doing this would be saving the content directly to database as a TextField.

closed time in 2 months

kvbik

push eventkvbik/pretix-attestation-placeholder-plugin

Jakub Vysoký

commit sha 1288b03a562ec1cc1ec5be27e7e9dce6a7bfa08c

path to the jar file needs to be computed

view details

push time in 2 months

PR opened efdevcon/pretix-attestation-placeholder-plugin

Update and rename README.md to README.rst

Fixing a formatting of the README file. It must have been originally a reStructuredText document.

+2 -4

0 comment

1 changed file

pr created time in 2 months

push eventkvbik/pretix-attestation-placeholder-plugin

Jakub Vysoký

commit sha 9d7b015a4c9413fa03f592d94ca1067d3e0e8ea8

Update and rename README.md to README.rst

view details

push time in 2 months