profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/kljohann/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

kljohann/mpv.el 70

control mpv for easy note taking

kljohann/genpybind 8

Autogeneration of Python bindings from manually annotated C++ headers

kljohann/pikchr-mode 7

Emacs major mode for the pikchr diagram markup language

kljohann/clang-format.el 4

Format code using clang-format

constantinpape/machine_learning 3

Repo for machine learning project.

kljohann/pintxuos 2

A simple profile manager for Wacom's Intuos4 series of tablets. Sets Keybindings and OLED icons.

electronicvisions/spack 1

A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.

kljohann/ace-link 0

Quickly follow links in Emacs

kljohann/agile 0

#lang for agile software development

kljohann/Bear 0

Build EAR

Pull request review commentkljohann/mpv.el

Add volume control.

 This can be used with the `org-open-at-point-functions' hook."   (interactive "p")   (mpv-speed-increase (- steps))) +;;;###autoload+(defun mpv-volume-set (factor)+  "Set playback volume to FACTOR."+  (interactive "nFactor: ")+  (mpv--enqueue `("set" "volume" ,(abs factor)) #'ignore))++;;;###autoload+(defun mpv-volume-increase (steps)+  "Increase playback volume by STEPS factors of `mpv-volume-step'."+  (interactive "p")+  (let ((factor (* (abs steps)+                   (if (> steps 0)+                       mpv-volume-step+                     (/ 1 mpv-volume-step)))))

Oh, this points to an existing bug in mpv-speed-increase. :slightly_smiling_face: Shouldn't it be the following?

  (let ((factor (if (>= steps 0)
                    (* steps mpv-volume-step)
                  (/ 1 (* (- steps) mpv-volume-step)))))

If you agree, could you fix it in both places?

c1-g

comment created time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened emacs-evil/evil

Change evil-window-{next,prev} to respect other-window window parameters

Currently evil-window-next and evil-window-prev, in the case where no count is provided, use select-window instead of other-window (even though they effectively are the evil version of other-window). This has the side effect that window parameters relevant to the cyclic window ordering are ignored, in particular

  • the other-window parameter, which can be set to a function that is used to pick the window to jump to, and
  • the no-other-window parameter, which can be used to exclude a window from being jumped to by the cyclic commands.

FWIW, evil-window-{left,right,up,down} already respect the no-other-window parameter (via windmove → window-in-direction), so I think using other-window here could make the commands more consistent. I don't know why select-window was used in the first place.

+24 -2

0 comment

2 changed files

pr created time in 24 days

push eventkljohann/evil

Johann Klähn

commit sha e3133ff9c361d56e61229af55059a6c4dbe9d109

Change evil-window-{next,prev} to respect other-window window parameters

view details

push time in 24 days

push eventkljohann/evil

Johann Klähn

commit sha b759597920aabeed63f8ee1b55808fe86dc79b65

Change evil-window-{next,prev} to respect `other-window` window parameters

view details

push time in 24 days

push eventkljohann/evil

Johann Klähn

commit sha 647e5c5d0abc7bd093da6c445f89994f94c1fb00

Change evil-window-{next,prev} to respect `other-window` window parameters

view details

push time in 24 days

push eventkljohann/evil

Johann Klähn

commit sha 5db00d552b2d74e8b004a9953c5dab7c517e5fe8

Change evil-window-{next,prev} to respect window parameters (e.g., no-other-window)

view details

push time in 24 days

push eventkljohann/evil

Eivind Fonn

commit sha ecc86e4bb17d6f9f7bda34d75abbed1a9fae4757

Revert "Fix bounds of wrapped search" This reverts commit e47db185aa3e6a15eba6e34847f0b28aa7055db8.

view details

Eivind Fonn

commit sha 59675bff8d99b192ab1b96e36089c861aab40919

Respect setting of isearch-filter-predicate Filtering our matches before passing them to isearch prevents isearch from entering an infinite loop if wrapped search is turned on and all the matches are filtered out.

view details

Eivind Fonn

commit sha 608d07023a214c1f41ff938347523d24ed354e32

Don't explicitly call isearch-filter-predicate to open folds This is handled implicitly by search-func now. The variable isearch-filter-predicates was reverted and never saw light of day in an official Emacs release.

view details

Eivind Fonn

commit sha c8aa7071d84f91256206073862a9604a3313fb89

Merge pull request #1235 from TheBB/search-pred Honor isearch filter predicates

view details

Troy Hinckley

commit sha cec589059614460800da5368173776fb95aebfbd

Add support for submenu entries in goto-definition-imenu Currently evil-goto-definition-imenu will only look in top level entries and ignores everything in a submenu. Unfortunately this means that many definitions that could be found are being skipped.

view details

Eivind Fonn

commit sha e00626d9fde3d6bf556a90c653b2d50803acb74d

Silence byte compiler about imenu--in-alist

view details

Eivind Fonn

commit sha 30b77c9ab3e47f3e6e206f43de2edba405b062bf

Call delete-backward-char interactively again Reverts part of 1d6ba80.

view details

Eivind Fonn

commit sha 3a4ea09bddb3ed90496a19eda690f1e73bf09bde

Ex search highlights: use selected window as fallback In some cases search is triggered not from the minibuffer, in which case minibuffer-selected-window will not accurately capture the window in which search highlights should be created.

view details

Eivind Fonn

commit sha dee23238d32b25906f9a456edeec510238406a4d

Enable lexical binding

view details

Nathan Gass

commit sha 94af4eafacb6b4664be75722f6f04ed65c8a5ef3

Implement Vim Ctrl-f in minibuffer. Open apropriate command windows for Ctrl-f while in minibuffer for an ex command or a search. As all ways to abort a minibuffer do not return and restore the active buffer, we have to set the content of the minibuffer and exit normally to trigger the apropriate action. Also restoring the window configuration is necessary so minibuffer-selected-window is not changed.

view details

Eivind Fonn

commit sha f10f831749cebbbd4082d802c4c9710f68ffda07

Fix indentation

view details

Eivind Fonn

commit sha 9bc790d789c8107fce111c1265a72fa9fa374f48

Merge pull request #1240 from xabbu42/feature-ctrl-f-minibuffer Implement Vim Ctrl-f in minibuffer.

view details

Eivind Fonn

commit sha e9391ae769bee189ef6144b8861b117d5c948a80

Revert "Enable lexical binding" This reverts commit c6086a7b0b44963071096e3ed7545f617de88915.

view details

Eivind Fonn

commit sha 21e504a8b961d0131e4a712bd711125a86a2a703

Re-enable lexical binding This reverts commit e9391ae769bee189ef6144b8861b117d5c948a80, and removes spurious debug messages.

view details

Ivan Yonchovski

commit sha fd84a9101e1efd9794d157135cd5f386aea11014

Extract evil-append-register function - Fixes https://github.com/emacs-evil/evil/issues/1260 ```elisp (advice-add 'evil-set-register :around (lambda (orig register text) (if (eq register ?\) ) (evil-append-register ?0 text) (funcall orig register text)))) ```

view details

Bet4

commit sha 3b03a4ef9a7493d5d2ed7beb7164ee65e8e2170c

Change the way to get universal argument

view details

Eivind Fonn

commit sha 48ceb43f8a1e95e6d7eafe428ff640d83952462f

Clean up compilation warnings from lexical binding

view details

bassettmb

commit sha 48f4965e258bc6711c354f0716d108cac1d0337c

Correct typo (COMPOUNT->COMPOUND) in symbol name in window server selection data-type list.

view details

Isak Johansson

commit sha ee444722cf1243cf5e0a307300d8e3890444d5c4

Spelling fix I found a spelling error while reading through the documentation.

view details

Jon Miller

commit sha eff9194949c28c68e3742969ce0ceb4d0c2564dc

Makefile: add 'info' target Useful to have a specific info target when some Emacs package installers expect this target (such as el-get).

view details

push time in 25 days

create barnchkljohann/evil

branch : respect-window-parameters

created branch time in 25 days

issue commentkljohann/mpv.el

Failed to connect to mpv

You have to provide mpv-start with some argument, else mpv will quit because it has nothing to do. For example

(mpv-start "--idle=once")
(mpv-run-command "loadfile" "something")

That said, unfortunately I cannot reproduce the original issue right now (which seemed to include --idle).

AtomicNess123

comment created time in 2 months

CommitCommentEvent