profile
viewpoint
Kenny Lee Sin Cheong kleesc Red Hat New York Boop!

imbaky/COMP345 0

Risk Game

kleesc/.emacs.d 0

My .emacs.d directory

kleesc/apiserver-builder 0

apiserver-builder implements libraries and tools to quickly and easily build Kubernetes apiservers to support custom resource types

kleesc/bcc 0

BCC - Tools for BPF-based Linux IO analysis, networking, monitoring, and more

kleesc/category-theory 0

A formalization of category theory in Coq for personal study and practical work

kleesc/chihaya 0

A customizable, multi-protocol BitTorrent Tracker

kleesc/cilium 0

API-aware Networking and Security for Containers based on BPF

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha b764f02bd9b4ab9d25bef7504b91561284714688

TOREMOVE

view details

push time in 9 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha d097c9799ca5e75543e13b3a0f60c5bf70a7d525

TOREMOVE

view details

push time in 9 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha a4b269d3d689d5ce4cb708fad853d89f36b78cd8

Move buildpack method from buildcomponent to buildjob

view details

Kenny Lee Sin Cheong

commit sha eb0528aa795a3331ec32ebb458160ba961814e67

buildermanagerservicer implementation

view details

Kenny Lee Sin Cheong

commit sha c073d974e94364d7c325636822b308f8d47391d9

ephemeral buildmanager implementation

view details

Kenny Lee Sin Cheong

commit sha eb476410acf694c7e7479f839909eed257b412a9

S manager

view details

Kenny Lee Sin Cheong

commit sha 2567cda5ff3b53329cf44c06fe7669169261a5be

S builderserver

view details

Kenny Lee Sin Cheong

commit sha 4b9098d82d2624ad5b50573ab6f4278afd633c7a

S

view details

Kenny Lee Sin Cheong

commit sha 47978a396d7212f83ffeb9dd8c58667b4f555951

TODO: S + regen protobiuf

view details

Kenny Lee Sin Cheong

commit sha 6ffae8bbed33ba5425c90098a9aa2b10fd5f03b2

S servicer

view details

Kenny Lee Sin Cheong

commit sha 7c0f7be7103b7a7b6b7c9e3eb1a29956b742476d

S manager

view details

push time in 9 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 52a72865550ca7e58d1dbf6d7c2515846cf9f46f

Revert "Move the build canceller to a separate package from the manager." This reverts commit c9b441a7321112672435115c08a81e6ab53584cd.

view details

Kenny Lee Sin Cheong

commit sha bc5ee0a3331c3818d819184d7bc7485088a7ce18

Reenable builder in supervisord config

view details

Kenny Lee Sin Cheong

commit sha 06ee9ffd0c82bc4200515f46b96c6ed37b352be1

buildermanagerservicer implementation

view details

Kenny Lee Sin Cheong

commit sha 85c5ae9db725b97f36fd852da416ba720ef1e4f9

ephemeral buildmanager implementation

view details

Kenny Lee Sin Cheong

commit sha 55f6cb9656159e5f23b0436487fe34f8164dad8a

S manager

view details

Kenny Lee Sin Cheong

commit sha 8096667cec563baf8b7bc2765ba90cf67694842c

S builderserver

view details

Kenny Lee Sin Cheong

commit sha d244fb2f3350e49537a24758eae0692b63cc2984

S

view details

Kenny Lee Sin Cheong

commit sha aed16a65a1471ad84b28fd3bdcb6714c99c90158

Move buildpack method from buildcomponent to buildjob

view details

Kenny Lee Sin Cheong

commit sha b4569420baa0993e6175331313c63339854b81cd

TODO: S + regen protobiuf

view details

Kenny Lee Sin Cheong

commit sha 9a82f69fb938113d56ca91612d4e5ec55362e389

S servicer

view details

Kenny Lee Sin Cheong

commit sha d70006b15b4a6323f19f2cd5da851ed334459fa7

S manager

view details

push time in 10 days

delete branch kleesc/quay

delete branch : PROJQUAY-675-use-days-instead-of-weeks-for-range

delete time in 11 days

push eventquay/quay

Kenny Lee Sin Cheong

commit sha 5e03c4c1b674ffec1c1a347eb59e30acbf0e53cb

Use days instead of weeks to represent a month worth of time (#549) * Use days instead of weeks to represent a month worth of time * Returns 400 on bad date ranges

view details

push time in 11 days

PR merged quay/quay

Use days instead of weeks to represent a month worth of time

Issue: https://issues.redhat.com/browse/PROJQUAY-675

Changelog: Quay expects a month's time range to be 31 days. Using weeks limited the maximum time range to 28 days since a week is equivalent to 7 days only. Use days instead of weeks to represent a month's range.

Docs:

Testing: Try and export logs for the past n days where 28 < n < 32.

Details:

+6 -2

0 comment

2 changed files

kleesc

pr closed time in 11 days

delete branch kleesc/quay

delete branch : PROJQUAY-1011-Fix-repositorybuild-attr-name

delete time in 11 days

push eventquay/quay

Kenny Lee Sin Cheong

commit sha 32357c07e6011e55d272c953db1e71d1aba9cc76

Fix db RepositoryBuild model attribute name used (#544)

view details

push time in 11 days

PR merged quay/quay

Fix db RepositoryBuild model attribute name used

Issue: https://issues.redhat.com/browse/PROJQUAY-1011

Changelog: Fix attribute used to access build namespace

Docs:

Testing:

  • Navigate to Quay UI -> Super user panel -> Build logs -> Get Logs

Details:

+2 -2

0 comment

1 changed file

kleesc

pr closed time in 11 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha ed2f55a058cb9b1cebe5715d366ec001054f6b24

Returns 400 on bad date ranges

view details

push time in 11 days

PR opened quay/quay

Reviewers
Use days instead of weeks to represent a month worth of time

Issue: https://issues.redhat.com/browse/PROJQUAY-675

Changelog: Quay expects a month's time range to be 31 days. Using weeks limited the maximum time range to 28 days since a week is equivalent to 7 days only. Use days instead of weeks to represent a month's range.

Docs:

Testing: Try and export logs for the past n days where 28 < n < 32.

Details:


(This section may be deleted.) All fields are required. If a field is not applicable (eg. no relevant CHANGELOG.md), specify "none" or "n/a".

Issue: This is the PROJQUAY jira reference. Pull-request title must start with issue name "PROJQUAY-1234 - ".

Changelog: One line description to be added to CHANGELOG.md during release builds. Typically starts with "Added:", "Fixed:", "Note:", etc.

Docs: Detailed description of changes necessary to docs.projectquay.io. Examples would be addition of config.yaml, indication of UI changes and screenshot impact, and changes in behavior of features.

Testing: Detailed description of how to test changes manually. This section combined with the Docs section above must be sufficiently clear for full test cases to be performed.

Details: Other information meant for pull-request reviewers and developers.

+2 -2

0 comment

1 changed file

pr created time in 11 days

create barnchkleesc/quay

branch : PROJQUAY-675-use-days-instead-of-weeks-for-range

created branch time in 11 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha f924a4a5f603b7545daf43c7de60204fc66a9364

State interface definition

view details

Kenny Lee Sin Cheong

commit sha c51e874b52a80e8d6b692b3605ccdecca30bdfcf

Cherrypick buildman/orchestrator.py from 04a8f4f7

view details

Kenny Lee Sin Cheong

commit sha 4a5fa943674f9761f3cf8b3dfafe65af17363590

Define structure for build arguments for workers

view details

Kenny Lee Sin Cheong

commit sha 89445b6e4d104be9dd0aceeac1de744ffbb3c1a0

buildman_pb scaffolding

view details

Kenny Lee Sin Cheong

commit sha 8781c4de157d138bcbced87617eb207df3f1e638

BuilderServer

view details

Kenny Lee Sin Cheong

commit sha 70e31de67ead68829a77c14ef69f62be45c7c631

Removes wamp's REALM parameters from executor

view details

Kenny Lee Sin Cheong

commit sha c9b441a7321112672435115c08a81e6ab53584cd

Move the build canceller to a separate package from the manager. Since it only interacts with the orchestrator to signal a cancelled build, move it to a separate package.

view details

Kenny Lee Sin Cheong

commit sha 638e94b98dd1c7a882b0cdd634dced950b48ab57

Reenable builder in supervisord config

view details

Kenny Lee Sin Cheong

commit sha 86b75425ba1c1e827a051ac0b1dda568a1d59337

buildermanagerservicer implementation

view details

Kenny Lee Sin Cheong

commit sha 2af82251c9d541cd2ee66332b942301c58e21f69

ephemeral buildmanager implementation

view details

push time in 12 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 43bb4506cc50ff786282843190a9bdeebf6bfc4a

State interface definition

view details

Kenny Lee Sin Cheong

commit sha 71561e7789d8680fea3f7774f4bc119a739dcbf7

Cherrypick buildman/orchestrator.py from 04a8f4f7

view details

Kenny Lee Sin Cheong

commit sha e384909fbf71baa36079be016119695827e4faa6

Define structure for build arguments for workers

view details

Kenny Lee Sin Cheong

commit sha 093e51f22d8feffbbdec1b78daeb7fc085c0b69e

buildman_pb scaffolding

view details

Kenny Lee Sin Cheong

commit sha 34117a564fff689855d10900eb86a66d8bea78c0

BuilderServer

view details

Kenny Lee Sin Cheong

commit sha db1b3a6c42de1dab360ab989d094d2145d25de30

Removes wamp's REALM parameters from executor

view details

Kenny Lee Sin Cheong

commit sha 6f21ffcc9692b8abbcbd3eb38c296cb33caf7c69

Move the build canceller to a separate package from the manager. Since it only interacts with the orchestrator to signal a cancelled build, move it to a separate package.

view details

Kenny Lee Sin Cheong

commit sha b0f207d76860dd84682f88c0e884788d3767190d

WIP: Impl

view details

Kenny Lee Sin Cheong

commit sha 17fcf49ac8ec2dc5cfee88e0f346c4aa277cae19

WIP

view details

Kenny Lee Sin Cheong

commit sha 37a6d877d8b682f989ae61b2dc1784d4e80f3bc2

S

view details

Kenny Lee Sin Cheong

commit sha 408013e710a700fd21906bed82aca35ce40def7a

WIP

view details

Kenny Lee Sin Cheong

commit sha f808829a068c00b57fe37b3007ecae0924089016

WIP manager

view details

push time in 15 days

Pull request review commentquay/quay

Fix db RepositoryBuild model attribute name used

 def get_repository_build(self, uuid):         except model.InvalidRepositoryBuildException as e:             raise InvalidRepositoryBuildException(str(e)) -        repo_namespace = build.repository_namespace_user_username+        repo_namespace = build.repository.namespace_user.username         repo_name = build.repository_name

Updated to to user the correct attribute name.

kleesc

comment created time in 17 days

PullRequestReviewEvent

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 0423d99eb294b3ec982883f63a8817b4d280fb4a

Fix db RepositoryBuild model attribute name used

view details

push time in 17 days

Pull request review commentquay/quay

Fix db RepositoryBuild model attribute name used

 def get_repository_build(self, uuid):         except model.InvalidRepositoryBuildException as e:             raise InvalidRepositoryBuildException(str(e)) -        repo_namespace = build.repository_namespace_user_username+        repo_namespace = build.repository.namespace_user.username         repo_name = build.repository_name

A repo name and a repo namespace are 2 different things. The latter refers to the user/org name

kleesc

comment created time in 17 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened quay/quay

Reviewers
Fix db RepositoryBuild model attribute name used

Issue: https://issues.redhat.com/browse/PROJQUAY-1011

Changelog: Fix attribute used to access build namespace

Docs:

Testing:

  • Navigate to Quay UI -> Super user panel -> Build logs -> Get Logs

Details:

+1 -1

0 comment

1 changed file

pr created time in 17 days

create barnchkleesc/quay

branch : PROJQUAY-1011-Fix-repositorybuild-attr-name

created branch time in 17 days

PullRequestReviewEvent

Pull request review commentquay/quay

[PROJQUAY-1035] fix: Convert gunicorn worker counts to int for comparisons

 def get_worker_count(worker_kind_name, multiplier, minimum=None, maximum=None):     minimum = minimum or multiplier     maximum = maximum or (multiplier * multiplier) -    # Check for an override via an environment variable.+    # Check for a process-specific override via an environment variable.     override_value = os.environ.get("WORKER_COUNT_" + worker_kind_name.upper())-    if override_value is not None:+    if override_value:

To be consistent with how the other checks are done. And in this case its generally better, since if for some reason the value of override_value was 0, it would still evaluate correctly.

kurtismullins

comment created time in 17 days

Pull request review commentquay/quay

[PROJQUAY-1035] fix: Convert gunicorn worker counts to int for comparisons

 def get_worker_count(worker_kind_name, multiplier, minimum=None, maximum=None):     minimum = minimum or multiplier     maximum = maximum or (multiplier * multiplier) -    # Check for an override via an environment variable.+    # Check for a process-specific override via an environment variable.     override_value = os.environ.get("WORKER_COUNT_" + worker_kind_name.upper())-    if override_value is not None:+    if override_value:

This should still check against None

kurtismullins

comment created time in 18 days

Pull request review commentquay/quay

[PROJQUAY-1035] fix: Convert gunicorn worker counts to int for comparisons

 def get_worker_count(worker_kind_name, multiplier, minimum=None, maximum=None):     minimum = minimum or multiplier     maximum = maximum or (multiplier * multiplier) -    # Check for an override via an environment variable.+    # Check for a process-specific override via an environment variable.     override_value = os.environ.get("WORKER_COUNT_" + worker_kind_name.upper())-    if override_value is not None:+    if override_value:+        override_value = int(override_value)         return max(override_value, minimum) +    # Check for a generic override via an environment variables     override_value = os.environ.get("WORKER_COUNT")-    if override_value is not None:+    if override_value:

Ditto.

kurtismullins

comment created time in 18 days

PullRequestReviewEvent
PullRequestReviewEvent
CommitCommentEvent
CommitCommentEvent

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha c2e7fdb015302bb3212d6942b67cc3f2e0ea1943

Add grpc dependencies

view details

Kenny Lee Sin Cheong

commit sha 53552f5bb0df908785a25105587d41d8cd1b39e3

State interface definition

view details

Kenny Lee Sin Cheong

commit sha b7cf2f08f5b86eafc3c6c9756b24bdf25b4554fd

Cherrypick buildman/orchestrator.py from 04a8f4f7

view details

Kenny Lee Sin Cheong

commit sha 9b0fed0984cd95f5f94b73f34a69067fb149049c

Define structure for build arguments for workers

view details

Kenny Lee Sin Cheong

commit sha 1e6dd32d0d1db1dc0b9e8961eccd69d960ef038d

buildman_pb scaffolding

view details

Kenny Lee Sin Cheong

commit sha f495bf7eac4111adc3f34019c00a5f32a40d0304

BuilderServer

view details

Kenny Lee Sin Cheong

commit sha a5d9577338511d5a3a7d64aa19c8f960a75dfd73

Move the build canceller to a separate package from the manager. Since it only interacts with the orchestrator to signal a cancelled build, move it to a separate package.

view details

Kenny Lee Sin Cheong

commit sha 06422dfbdf531cecf8af9977e0e2679f3b9f1e1c

WIP: Impl

view details

Kenny Lee Sin Cheong

commit sha ed67fbdef9cc03ca8a653a2f3c753e06eadcbbc5

WIP

view details

Kenny Lee Sin Cheong

commit sha 4c1b8d4cae13a9fc15ae4b7bcbc52dc0ab239cb7

S

view details

Kenny Lee Sin Cheong

commit sha 75ad629ecb60562380686c9a3e498a4869e68a89

WIP

view details

push time in 18 days

PullRequestReviewEvent

Pull request review commentquay/quay

[PROJQUAY-1035] fix: Convert gunicorn worker counts to int for comparisons

 def get_worker_count(worker_kind_name, multiplier, minimum=None, maximum=None):      # Check for an override via an environment variable.     override_value = os.environ.get("WORKER_COUNT_" + worker_kind_name.upper())++    if override_value:+        override_value = int(override_value)

nit: You're already checking override_value below. Also check for a ValueError when doing the int conversion.

kurtismullins

comment created time in 18 days

PullRequestReviewEvent

startedconnorferster/handcalcs

started time in 18 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 5575d2a175621b5383cbb87a8e8028bad34cf206

State interface definition

view details

Kenny Lee Sin Cheong

commit sha 2433c15886036ded7750227941ed8fe0982232bd

Cherrypick buildman/orchestrator.py from 04a8f4f7

view details

Kenny Lee Sin Cheong

commit sha 154bbc72a48e6c9fb92855bcd92defd0f0c76416

Define structure for build arguments for workers

view details

Kenny Lee Sin Cheong

commit sha 7d8a8ce445a97f6192dfd425f7d7625eeb31157b

buildman_pb scaffolding

view details

Kenny Lee Sin Cheong

commit sha 385e3d1d216afa4fc1042986f59e6655e364d4b2

BuilderServer

view details

Kenny Lee Sin Cheong

commit sha e8ae129abdbe3908740663b71b0f0c9211f6058d

Move the build canceller to a separate package from the manager. Since it only interacts with the orchestrator to signal a cancelled build, move it to a separate package.

view details

Kenny Lee Sin Cheong

commit sha afa0687d827d5e5305ac6e66984500ae62786efc

WIP: Impl

view details

Kenny Lee Sin Cheong

commit sha fc520c1239c6db03b420ae1bdf13c5ef2fed91dc

WIP

view details

Kenny Lee Sin Cheong

commit sha 1f44f95eb3032a89ca99b9a76a86bcba3681daa4

S

view details

Kenny Lee Sin Cheong

commit sha b944de0ce81dfb092ba4a16e32d81966c82575e4

WIP

view details

push time in 19 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 74385a332817724e775acc9eacc37132be2e16b0

S

view details

push time in 22 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha ccec94573056e422020dcce46061ec8bbfebf821

State interface definition

view details

Kenny Lee Sin Cheong

commit sha de506868185e93b5f952d35d805858b15ce3373c

Cherrypick buildman/orchestrator.py from 04a8f4f7

view details

Kenny Lee Sin Cheong

commit sha 594fddb10eefa0c0fecd54ba005182c1311ad2e5

buildman_pb scaffolding

view details

Kenny Lee Sin Cheong

commit sha 5cdcfc892b3693301568d3272c7b7a422d2c2cf8

BuilderServer

view details

Kenny Lee Sin Cheong

commit sha adaedcd29222d41845b598660f340a0a2992011a

Move the build canceller to a separate package from the manager. Since it only interacts with the orchestrator to signal a cancelled build, move it to a separate package.

view details

Kenny Lee Sin Cheong

commit sha 27f2d503886f36dbe05861c61c4210f18860c3c2

WIP: Impl

view details

Kenny Lee Sin Cheong

commit sha d1f94f2c76309a4773a18e19b4237885bc93631e

WIP

view details

push time in 24 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 0c6f47b96de8b29737a538146d8413b4cd1f3abf

State interface definition

view details

Kenny Lee Sin Cheong

commit sha 9686425d766232200948c8f34be6f23848ca2b6d

Cherrypick buildman/orchestrator.py from 04a8f4f7

view details

Kenny Lee Sin Cheong

commit sha b89bc99832fb75266651155450800722a43da5d7

buildman_pb scaffolding

view details

Kenny Lee Sin Cheong

commit sha 29100a145f9a1464ec6f34fedbbbcfbbf19d7e56

BuilderServer

view details

Kenny Lee Sin Cheong

commit sha fcb6a7cf08bf64de8c15fa374be9ad6d6ecbbf03

Move the build canceller to a separate package from the manager. Since it only interacts with the orchestrator to signal a cancelled build, move it to a separate package.

view details

Kenny Lee Sin Cheong

commit sha 7093e4e375b7ceb89109dadd395c5ff26747a082

WIP: Impl

view details

push time in 24 days

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 9aaa2a4d524d39c381a6df7560a2cb493f0a62d0

Add grpc dependencies

view details

Kenny Lee Sin Cheong

commit sha adb42a99a4c40df46f7a683cb6d41b0bb364841e

State interface definition

view details

Kenny Lee Sin Cheong

commit sha ef54c0d2b39bfe20679ed074290191dbcdfdf848

Cherrypick buildman/orchestrator.py from 04a8f4f7

view details

Kenny Lee Sin Cheong

commit sha eeb9a3b7995d8e6035170f69ad0930519d43a8fa

buildman_pb scaffolding

view details

Kenny Lee Sin Cheong

commit sha 2a1fd12f5ffa5be4abbbe28e90573e57bb406609

Move the build canceller to a separate package from the manager. Since it only interacts with the orchestrator to signal a cancelled build, move it to a separate package.

view details

Kenny Lee Sin Cheong

commit sha dd6dfb47d0a4805907ca1ac4b6a861b0f523d2a9

WIP Impl state interface

view details

Kenny Lee Sin Cheong

commit sha 11d07427e28265ce2ffaf2aa2e58c279ff2f7502

WIP

view details

Kenny Lee Sin Cheong

commit sha 5e6645f94b6f556e4278cb2d87ae796865ec881b

WIP

view details

Kenny Lee Sin Cheong

commit sha 7c810d55a44d66a8c277f88ba99c747ef273dd86

S

view details

Kenny Lee Sin Cheong

commit sha e22c4e051c97ab661153d7e32951e6c50c5c61c3

BuilderServer

view details

push time in 24 days

push eventkleesc/quay

thomasmckay

commit sha 8c6ce2d9a4585aea3031ee1740150042ad0fb8fc

PROJQUAY-906 - update pydevd package (#493)

view details

Kenny Lee Sin Cheong

commit sha bc8f2d9bbc3118ef760359073d60b4640f8bb933

Add missing flask import + add logs date range test (#494)

view details

thomasmckay

commit sha 8d57e769fa41347bd313a8384996cb24f6246f92

PROJQUAY-907 - repo mirror initial date (#495)

view details

Joseph Schorr

commit sha 0e628b1569aa168434d154f4ed147dda484fcebd

Deprecate Image rows and move to in-memory synthesized legacy images [Python 3] (#442) * Change verbs to use a DerivedStorageForManifest table instead of DerivedStorageForImage This allows us to deprecate the DerivedStorageForImage table. Fixes https://issues.redhat.com/browse/PROJQUAY-519 * Change uploaded blob tracking to use its own table and deprecate RepositoryTag * Start recording the compressed layers size and config media type on the manifest row in the database NOTE: This change includes a database migration which will *lock* the manifest table * Change tag API to return the layers size from the manifest * Remove unused code * Add new config_media_type field to OCI types * Fix secscan V2 test for us no longer writing temp images * Remove unused uploading field * Switch registry model to use synthetic legacy images Legacy images are now (with exception of the V2 security model) read from the *manifest* and sythensized in memory. The legacy image IDs are generated realtime based on the hashids library. This change also further deprecates a bunch of our Image APIs, reducing them to only returning the image IDs, and emptying out the remaining metadata (to avoid the requirement of us loading the information for the manifest from storage). This has been tested with our full clients test suite with success. * Add a backfill worker for manifest layers compressed sizes * Change image tracks into manifest tracks now that we no longer have manifest-less tags * Add back in the missing method * Add missing joins to reduce extra queries * Remove unnecessary join when looking up legacy images * Remove extra hidden filter on tag queries * Further DB improvements * Delete all Verbs, as they were deprecated * Add back missing parameter in manifest data type * Fix join to return None for the robot if not defined on mirror config * switch to using secscan_v4_model for all indexing and remove most of secscan_v2_model code * Add a missing join * Remove files accidentally re-added due to rebase * Add back hashids lib * Rebase fixes * Fix broken test * Remove unused GPG signer now that ACI conversion is removed * Remove duplicated repomirrorworker * Remove unused notification code for secscan. We'll re-add it once Clair V4 security notifications are ready to go * Fix formatting * Stop writing Image rows when creating manifests * Stop writing empty layer blobs for manifests As these blobs are shared, we don't need to write ManifestBlob rows for them * Remove further unused code * Add doc comment to _build_blob_map * Add unit test for synthetic V1 IDs * Remove unused import * Add an invalid value test to synthetic ID decode tests * Add manifest backfill worker back in Seems to have been removed at some point * Add a test for cached active tags * Rename test_shared to not conflict with another same-named test file Pytest doesn't like having two test modules with the same name * Have manifestbackfillworker also copy over the config_media_type if present Co-authored-by: alecmerdler <alecmerdler@gmail.com>

view details

Joseph Schorr

commit sha 646dfd279e748f81df2949a7d9a821e8dc0f30bc

Fix clients test for Python 3 (#496) Must now be run from the quay root directory with PYTHONPATH=.

view details

Joseph Schorr

commit sha 40cb9ed597d5004bd03e9da56425dc0528d866f0

Add an endpoint for tracking the secscan backfill (#497) Fixes https://issues.redhat.com/browse/PROJQUAY-912

view details

Joseph Schorr

commit sha 4fa1459583d02c3194a7502b965f3880705963bb

Fix lookup of manifests if we detect a duplicate during creation (#498) This changes the lookup to occur outside of the transaction as otherwise we won't find the manifest that was inserted during the transaction's view Fixes https://issues.redhat.com/browse/PROJQUAY-915

view details

Kurtis Mullins

commit sha d3ca550a2b8ee9eff51f13142b37447bbc6aa584

[PROJQUAY-917] Fix CSRF token encoding (#500)

view details

Kenny Lee Sin Cheong

commit sha 01a61a7d23100b47f274261335b0daf52b94b080

Decode secret's bytes to str before writing to file (#499)

view details

Kenny Lee Sin Cheong

commit sha a96fcabd0352fcc33fbd49db4116a5408ba0ff7f

Handle generated ssh keypairs in build triggers as str (#503) The keys are either part of a dict being serialized into json with json.dumps to pass as a requests' body, or passed directly to the client(e.g github). In both cases, the value needs to be a str.

view details

Kenny Lee Sin Cheong

commit sha 50ba6130548ebb049db5459ca1c66853947b4f53

Rebase the boto forked to include the non-released changes (#502) Changes include various Python3 compatibility fixes.

view details

thomasmckay

commit sha 7ef725478056023800aa9b98bcf2e469ca083d8a

PROJQUAY-907 - properly check empty string (#505)

view details

Kenny Lee Sin Cheong

commit sha ac70f6b5eb7e20f8aa9c9f927bc3e3bd35890a13

Add an extra "metadata" field to Elasticsearch logentries (#504) * Add an extra "metadata" field to Elasticsearch logentries The current "metadata_json" field is stored as a text field, and cannot be searched easily. "metadata" will store the given dict as a dynamically mapped Object type. * Remove duplicate "metadata_json" field in Elasticsearch Instead, json dumps the "metadata" field for the Log datatype.

view details

Joseph Schorr

commit sha a431c61d4d5d2dc5ac679c7f02161dc24ddc337f

Fix lookup of tag history sizes (#506) Add missing @property decorator on legacy image size handler to fix the raised exception

view details

Joseph Schorr

commit sha bf656b26ef1ab16b51d4d0bd0c94c02aa2611a91

Further fixes for duplicate manifest pushing (#507) Catch IntegrityError from the other inserts as well, to ensure we handle duplicate rows Further addresses https://issues.redhat.com/browse/PROJQUAY-915

view details

Kurtis Mullins

commit sha 12941b540da1bfc40c8917421bb486de4d040001

Remove deprecated gunicorn config for verbs (#510) The verbs functionality was removed in #442

view details

Kenny Lee Sin Cheong

commit sha 71a2ba052cf9f4db33d270b7d8212b5ae7716514

Fix ldap user login (#509) * Fix typo * Make sure python-ldap uses str instead of bytes

view details

Kenny Lee Sin Cheong

commit sha 6556899b4e179fb96ac43cd041ec9a397d55b48b

Initialize the swift retry count correctly so that it is never None (#508)

view details

Joseph Schorr

commit sha f626d4ecebcd529b2d2c929cbef2b6646d97ff62

Ensure shared blob layers are present on lookup (#511) Due to the requirement for the shared empty layer for manifest schema 1, we need to make sure it is written to the ImageStorage table, even if the only schemas pushed are version 2 Fixes https://issues.redhat.com/browse/PROJQUAY-948

view details

Joseph Schorr

commit sha 005b1e44f466bac8114e9d535fc9239a16788626

Mark invalid manifests in Secscan V4 (#512) If we get an invalid manifest when indexing, we now mark the manifest as invalid for security indexing Fixes https://issues.redhat.com/browse/PROJQUAY-949

view details

push time in 24 days

push eventkleesc/quay

Joseph Schorr

commit sha eb54c545c6700378053d8e0222f2eca7361c9fdd

Fix display of robots when setting up a build trigger (#470) Fixes https://issues.redhat.com/browse/PROJQUAY-825

view details

Joseph Schorr

commit sha a7210edc6a3800093ab0598c5d26b629b568848a

Turn off ignore_exc in memcache cache to fix an NPE (#472) The PooledCache implementation incorrectly returns `None` instead of the default if an exception occurs, but `None` is a valid cached value, so we instead catch the exceptions ourselves now and skip the caching code if we encounter an exception

view details

Bill Dettelback

commit sha 2fc267f25273f444b878dc816d3a5ac210601dc3

Changes to README.md for bug bash (#469) * initial version * README.md changes for bug bash

view details

Kenny Lee Sin Cheong

commit sha 5ebc48d53e5cfae95925ad464d13a991d85c2507

Migrate to boto3 in the build executor (#467) * Migrate to boto3 in the build executor * Add required default values to aws calls

view details

thomasmckay

commit sha d9495cf015e47f169b17ca4547b593d5f0cbf730

PROJQUAY-849 - sprint release 'solo' (#474)

view details

thomasmckay

commit sha 6a608f537f2e52a8f3c8c0f1048449520a65f5d6

PROJQUAY-849 - changelog version to master (#476)

view details

Kenny Lee Sin Cheong

commit sha 08cfd7ead1c885a11cd2fdf4ffdab4e5b6475935

Update the executor image from Container Linux to Fedora CoreOS (#434) * Update the executor image from Container Linux to Fedora CoreOS * Move the container cloud config script for templating from devtable to quay's repo * Ignition config template * Move dockersystemd from devtable repo * Remove pinned dependency on devtable/container-cloud-config * Removes squashed image and logentries * Update builder image * Update mounted cert directory for Fedora * Removes old clouconfig template * Pass userdata as firmware config to qemu * Use CentOS:8 as base image

view details

Kenny Lee Sin Cheong

commit sha 3fdf2ff9ba572f8a9f016dfbba246c5aad026a51

Decode b64 bytes to str (#477)

view details

Joseph Schorr

commit sha d9695c766c0a0c615a7fbd7101b9a50cfdd8ff03

Remove pre-installed containerd to try to fix build (#480)

view details

Joseph Schorr

commit sha 74fcb25eb49c1e3e70d4e0e6d9f4eb8a1622fdb5

Undo appr automatic 302 redirect (#482) It appears some clients are using the retrieved mediatype, despite there only being a single one

view details

thomasmckay

commit sha ff99c7463f6337c399c39633e91833072402780f

PROJQUAY-872 - update pull-request template (#478)

view details

Kenny Lee Sin Cheong

commit sha 9b86bf51e2f7fb14b7dcddcf889703199b93b72c

Abort on invalid date range for logs api (#483)

view details

thomasmckay

commit sha 05632ac773a92979df03de56680227c411355490

PROJQUAY-850 - correct export of security.pem (#484)

view details

Kenny Lee Sin Cheong

commit sha 6397c05b55c9a0dacd127de5b9a0db141144d473

Update host's mounted cert directory (#485) /usr/share/pki/ca-trust-source/anchors does not have anything to copy over to the container. /etc/pki/ca-trust-source/anchors has the required system certs/trust.

view details

Ivan Bazulic

commit sha 5d433d179056465d646a266d4b3c48d323d547d8

PROJQUAY-889 Enable adding of specific CN to certs used by the config app (#487) * Enable adding of specific CN to certs * Changed indentation

view details

Kenny Lee Sin Cheong

commit sha 7bdd94505330b93173e80a11caab7ce8fcf9aa00

Repin boto version with python3 syntax fix (#489)

view details

Kenny Lee Sin Cheong

commit sha fce130e8ed78f9c6660067257f58eae2e76f15d3

Try to remove the redis key if when scheduling build it already exists (#490)

view details

thomasmckay

commit sha a60c7a2a1758b0fab163ff2c7f30f321d8b2555d

PROJQUAY-796 - skopeo mirror all manifest list (#488)

view details

thomasmckay

commit sha 8c6ce2d9a4585aea3031ee1740150042ad0fb8fc

PROJQUAY-906 - update pydevd package (#493)

view details

Kenny Lee Sin Cheong

commit sha bc8f2d9bbc3118ef760359073d60b4640f8bb933

Add missing flask import + add logs date range test (#494)

view details

push time in 25 days

push eventquay/quay

Pratik Raj

commit sha 5845afd4e032304319b1764e0589e93ae34e9364

chore: use `--no-cache-dir` flag to `pip` in dockerfiles, to save space (#529) using "--no-cache-dir" flag in pip install ,make sure downloaded packages by pip don't cached on system . This is a best practice which make sure to fetch from repo instead of using local cached one . Further , in case of Docker Containers , by restricting caching , we can reduce image size. In term of stats , it depends upon the number of python packages multiplied by their respective size . e.g for heavy packages with a lot of dependencies it reduce a lot by don't caching pip packages. Further , more detail information can be found at https://medium.com/sciforce/strategies-of-docker-images-optimization-2ca9cc5719b6 Signed-off-by: Pratik Raj <rajpratik71@gmail.com>

view details

push time in 25 days

PR merged quay/quay

PROJQUAY-987 - use `--no-cache-dir` flag to `pip` in dockerfiles, to save space

using "--no-cache-dir" flag in pip install ,make sure downloaded packages by pip don't cached on system . This is a best practice which make sure to fetch from repo instead of using local cached one . Further , in case of Docker Containers , by restricting caching , we can reduce image size. In term of stats , it depends upon the number of python packages multiplied by their respective size . e.g for heavy packages with a lot of dependencies it reduce a lot by don't caching pip packages.

Further , more detail information can be found at

https://medium.com/sciforce/strategies-of-docker-images-optimization-2ca9cc5719b6

Signed-off-by: Pratik Raj rajpratik71@gmail.com

Issue: https://issues.redhat.com/browse/PROJQUAY-987

+21 -26

3 comments

8 changed files

Rajpratik71

pr closed time in 25 days

PullRequestReviewEvent

delete branch kleesc/quay

delete branch : PROJQUAY-953-fix-ui-tag-tracks

delete time in a month

push eventquay/quay

Kenny Lee Sin Cheong

commit sha 2b60e20e67630742c65ffd749b4ac65657d15462

Use manifest_digest instead of image_id when accessing current tracks (#532)

view details

push time in a month

PR merged quay/quay

Reviewers
Use manifest_digest instead of image_id when accessing current tracks

Issue: https://issues.redhat.com/browse/PROJQUAY-953

Changelog: Fix UI tags' tracks

Docs:

Testing:

  • Push multiple tags with different manifest digests.
  • Create new tags from the tags created above -> New tracks should be displayed correctly in the repo tags panel (even after page refresh).

Details:

+1 -1

0 comment

1 changed file

kleesc

pr closed time in a month

PR opened quay/quay

Use manifest_digest instead of image_id when accessing current tracks

Issue: https://issues.redhat.com/browse/PROJQUAY-953

Changelog: Fix UI tags' tracks

Docs:

Testing:

  • Push multiple tags with different manifest digests.
  • Create new tags from the tags created above -> New tracks should be displayed correctly in the repo tags panel (even after page refresh).

Details:

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchkleesc/quay

branch : PROJQUAY-953-fix-ui-tag-tracks

created branch time in a month

delete branch kleesc/quay

delete branch : PROJQUAY-989-allow-azure-keys-to-be-overwritten

delete time in a month

push eventquay/quay

Kenny Lee Sin Cheong

commit sha 4865572ba805e95b27cbd55119f70d9d03b3c2fd

Allow existing blobs to be overwritten in azure (#531)

view details

push time in a month

PR merged quay/quay

Reviewers
Allow existing blobs to be overwritten in azure

Issue: https://issues.redhat.com/browse/PROJQUAY-989

Changelog:

  • Allow the blobs in azure to be rewritten. This is the same behaviour as in s3. This is necessary for config validation (the same test blob is written to each time storage is validated)

Docs:

Testing:

  • Setup quay with the config app with azure
  • Try to edit the saved config from the previous setup -> Azure storage should be able to validate

Details:

+2 -2

0 comment

1 changed file

kleesc

pr closed time in a month

PR opened quay/quay

Allow existing blobs to be overwritten in azure

Issue: https://issues.redhat.com/browse/PROJQUAY-??? Pull-request title must start with "PROJQUAY-??? - "

Changelog:

Docs:

Testing:

Details:

+2 -2

0 comment

1 changed file

pr created time in a month

create barnchkleesc/quay

branch : PROJQUAY-989-allow-azure-keys-to-be-overwritten

created branch time in a month

pull request commentquay/quay

PROJQUAY-987 - Use `PIP_NO_CACHE_DIR=yes` for `pip` in Dockerfiles ENV, to save space

@Rajpratik71 Doesn't look like it's able to build with PIP_NO_CACHE_DIR set to yes, at least for the version of pip we're using.

Rajpratik71

comment created time in a month

push eventquay/quay

Kenny Lee Sin Cheong

commit sha 8583206220a71dd680ab9422e3447b913f3cee2f

Fix the RepoMirrorConfig model to match the latest migrations (#530) RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

PR merged quay/quay

Reviewers
Fix the RepoMirrorConfig model to match the latest migrations

Issue: https://issues.redhat.com/browse/PROJQUAY-940

Changelog:

Docs:

Testing: :

  • Create robot (user or org)
  • Create mirror with previous robot
  • Try to delete robot.

Expected result: API call should return 400 (Error msg pop up in UI)

Details: RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not.

Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot.

Also set a default test DATABASE_SECRET_KEY when generating the test.db

+69 -40

0 comment

10 changed files

kleesc

pr closed time in a month

Pull request review commentquay/quay

Fix the RepoMirrorConfig model to match the latest migrations

 def get_user_robot(self, robot_shortname, owning_user):             metadata.unstructured_json,         ) +    def robot_has_mirror(self, robot_username):

@kurtismullins If I'm not mistaken, the interface was part of the previous v2_2 migration efforts, which is why the implementation file has a pre_oci to it.

kleesc

comment created time in a month

PullRequestReviewEvent

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 908428f490b8bf2ea2f9da3baf9ed8aa476960b0

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 36068685465b1ba5343bb9678424531dba3598de

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha db8f7d595a8ed1acb1156edef12b86b62c548edf

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

PR opened quay/quay

Reviewers
Fix the RepoMirrorConfig model to match the latest migrations

Issue: https://issues.redhat.com/browse/PROJQUAY-940

Changelog:

Docs:

Testing: :

  • Create robot
  • Create mirror with previous robot
  • Try to delete robot.

Expected result: API call should return 400 (Error pop up in UI)

Details: RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not.

Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot.

Also set a default test DATABASE_SECRET_KEY when generating the test.db

+53 -8

0 comment

9 changed files

pr created time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 8f414468b070424b9a2836c472b963b5df76278a

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha e107f17a73766bbd909a0fa7844394ddc26a9beb

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha c6d5663be092c69442d170c8ec7fce84020ff2a5

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha fb5c388c258968b42e083bb3a4272713df132fab

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha c728706ce5e02618f89ec862b27c9ba909f57429

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha ab2f9bf2a179cade6a2ff3a87e0a2a492ebe4a8a

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 7f5c655df1b55595d3fa07240606237f4c512bf7

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles delete api calls when there are mirrors still using the robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 8f348fc1a4b031026588109c491a847c6e1736b3

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles the integrity errors accordingly when trying to delete the RepoMirrorConfig robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha e3e4c4589388aee6349f6d7b758173d2ef268ed8

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles the integrity errors accordingly when trying to delete the RepoMirrorConfig robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha b205c19cc2f666c001eb4e59d87622355699da19

Fix the RepoMirrorConfig model to match the latest migrations RepoMirrorConfig in the current database migration version has a non-null constraint on the internal_robot field, but the model in database.py does not. Updates the model to match the current database revision, and handles the integrity errors accordingly when trying to delete the RepoMirrorConfig robot. Also set a default test DATABASE_SECRET_KEY when generating the test.db

view details

push time in a month

create barnchkleesc/quay

branch : PROJQUAY-940-fix-repomirrorconfig-model

created branch time in a month

delete branch kleesc/quay

delete branch : json-loads-fix

delete time in a month

push eventquay/quay

Kenny Lee Sin Cheong

commit sha 0c65f88a0ec5e3b847f45c1fdc0e53365126c22a

json loads fix: given arg should be a str (#527)

view details

push time in a month

PR merged quay/quay

json loads fix: given arg should be a str

Fixes bug from https://github.com/quay/quay/pull/526

Changelog:

Docs:

Testing:

Details:

+1 -1

1 comment

1 changed file

kleesc

pr closed time in a month

pull request commentquay/quay

json loads fix: given arg should be a str

@kurtismullins I linked the PR that introduced the issue this one fixes.

kleesc

comment created time in a month

PR opened quay/quay

Reviewers
json loads fix: given arg should be a str

Fixes bug from https://github.com/quay/quay/pull/526

Changelog:

Docs:

Testing:

Details:

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchkleesc/quay

branch : json-loads-fix

created branch time in a month

delete branch kleesc/quay

delete branch : reduce-fallback-loglevel

delete time in a month

push eventquay/quay

Kenny Lee Sin Cheong

commit sha 27c6e2b99b7f35c50f756c4f948a25ee8badf5f9

Reduce log noise from fallbacks in executor (#526)

view details

push time in a month

PR merged quay/quay

Reviewers
Reduce log noise from fallbacks in executor

Follow-up to https://issues.redhat.com/browse/PROJQUAY-974

Changelog:

  • Reduce the log level from error to warning when falling back on executors.
  • Set empty default metadata when trying to serialize to JSON if for some reason it is not set in LogEntry.

Docs:

Testing:

Details:

+3 -3

0 comment

2 changed files

kleesc

pr closed time in a month

push eventkleesc/quay

Kurtis Mullins

commit sha 1a55e352a933c77b2e814ab0cc31630bafe590fa

[PROJQUAY-319] Enable marking config-app fields as read only. (#310)

view details

Joseph Schorr

commit sha 3e8ef9574ca14b62ea563558eae54bae6a14fc59

Ensure that all user-provided filters are wrapped in parens (#322) Also adds tests and fixes some issues with our existing filter Fixes https://issues.redhat.com/browse/PROJQUAY-551

view details

Alec Merdler

commit sha e003b8e8ed3663676545aed06dde4a5da8d1c461

fix security scan column on tags view for Clair v2 (#324)

view details

Kenny Lee Sin Cheong

commit sha 0d8a6653ea70d88a24851da3bde687a994078404

Change the help text for changing user/org names (#323)

view details

Joseph Schorr

commit sha 7fc634297d7502373b2aa7e680d53d8a4ef68e7f

Change builders to no longer use a squashed pull (#307) Fixes https://issues.redhat.com/browse/PROJQUAY-553

view details

Alec Merdler

commit sha 524a8157fd6c52b71e21026a6a2714efa1be2b9e

fix app repo 'last_modified' field (#326)

view details

sunminjeon

commit sha 4380850298888c4f8a251a81aa259b6788e768b8

Update development-container.md (#272) * Fix the Quay container directory Path During installation, an error in the installation path was found. I think the path of the quay container should be changed to: This is because we set it to '-e QUAY_DEVEL_HOME=$QUAY_DEVEL_HOME' above, and the contents performed after it are in '$QUAY_DEVEL_HOME/quay'. Check, please. before: $QUAY_DEVEL_HOME after: $QUAY_DEVEL_HOME/quay

view details

Joseph Schorr

commit sha dce4d3ec1e8da852a651ab18339fbcccc4505323

Change GitHub Login to send the auth token via header (#329) GitHub has deprecated support for passing the token via URL parameter

view details

Kenny Lee Sin Cheong

commit sha 15210260d0d8829d001b6692c0232f433b5ea314

Config app logs options (#247) * Elasticsearch validator * Kinesis service validator * Add elasticsearch and kinesis to config setup * Format with black * Validators fix

view details

Joseph Schorr

commit sha 88db2ee96f0d462276182b293e0d7da679c054d7

Fix our handling of chunked uploads to meet the OCI spec (#325) We were using the wrong header name and format

view details

Joseph Schorr

commit sha b211816abab67f8ef49e514aac8340f5539a1ca2

Implement experimental support for OCI manifests (#279) * Implement OCI manifest and index support * Remove unnecessary data model check in registry protocol fixtures * Implement OCI testing * Add migration for adding OCI content types * Remove unused supports_schema2 * Add OCI_NAMESPACE_WHITELIST and reformat with black * Catch errors in legacy image population and raise appropriately * Add support for registration of additional artifact types This change adds the infrastructure to support artifacts in OCI manifests, but does not yet register any types * Add a feature flag for enabling experimental Helm support via OCI See: https://helm.sh/docs/topics/registries/

view details

Joseph Schorr

commit sha 6d733110da48f15e9f93f05198d1e7fc7c5c5bf5

Add some additional information to help debug a flaky GC test (#333) * Add some additional information to help debug a flaky GC test * Make sure to cleanup our register callbacks

view details

Joseph Schorr

commit sha f5d0dfde8fa70b0f859339c8fe2721045c294a97

Change email template to use the configured values instead of hard (#335) coding the Quay name Also removes the obsolete docs.quay.io reference

view details

thomasmckay

commit sha 2b2cc34311002282a8a687559e0fd87770d4be92

PROJQUAY-293 - update local storage wording (#338)

view details

thomasmckay

commit sha 3a7804c65a1e8010fae057db228bd216b7b34ce0

PROJQUAY-455 - update v1 deprecation wording (#339)

view details

Joseph Schorr

commit sha 3449acca8c2845085b8aed5b449020a1f8eea382

Have Azure copy blob use the destination credentials (#301) We were incorrectly using the source blob service Fixes https://issues.redhat.com/browse/PROJQUAY-540

view details

Joseph Schorr

commit sha e919361a9aad73df015c692e31a1fe1d015cafa4

Remove unused user analytics code (#337)

view details

Alec Merdler

commit sha 516e34b961b4d732ee410b5f2afce6b49e9e957c

use /index_state endpoint for Clair v4 and update OpenAPI (#344)

view details

Kenny Lee Sin Cheong

commit sha b703cb452480ae5e85f311751346eefcc50a885d

Fix wrong reference name in ClairSecurityScannerAPI (#347) * Fix wrong reference name in ClairSecurityScannerAPI * Fix min_id referencing the value instead of the tuple reference

view details

Joseph Schorr

commit sha 2f171889e451015b21ae5acd44cde8368973b0ef

Fix search filter for LDAP user lookup when no user filter is specified (#346) The LDAP class defined the filter using a default Python parameter, so we need to mimic it

view details

push time in a month

PR opened quay/quay

Reviewers
Reduce log noise from fallbacks in executor

Changelog:

  • Reduce the log level from error to warning when falling back on executors.
  • Set empty default metadata when trying to serialize to JSON if for some reason it is not set in LogEntry.

Docs:

Testing:

Details:

+2 -2

0 comment

2 changed files

pr created time in a month

create barnchkleesc/quay

branch : reduce-fallback-loglevel

created branch time in a month

delete branch kleesc/quay

delete branch : azure-update

delete time in a month

push eventquay/quay

Kenny Lee Sin Cheong

commit sha 18bf4dcb294aff742b0b8f5ec4c552ce25286c20

Update azure client to v12 (#524) - Updates the Azure client to use the recent v12, which provides better support for large file uploads and access to newer api versions from Azure. - Increase chunk size when iterating over chunks' streams (for some reason, read() calls are slower in Python 3 than in Python 2, which caused timeouts on larger layers. Increasing the amount read from 4096 per iteration is a workaround to get performance similar to Python 2).

view details

push time in a month

PR merged quay/quay

Reviewers
Azure client update

Issue: https://issues.redhat.com/browse/PROJQUAY-942

Changelog:

  • Update Azure client library to v12
  • Increase chunk size when reading stream when uploading to Azure

Docs:

Testing: Try pushing/pulling images of different layer sizes to Quay

Details: Python 3 has some performance issues with the way streams are currently iterated over when uploading data using Azure. This PR tweaks the chunk size to improve performance on Python 3 to be more comparable to Python 2, and updates the Azure library version used to v12.4.0 from 1.1.0, which handles large files better, and has support for newer Azure API versions.

+157 -115

0 comment

3 changed files

kleesc

pr closed time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha ae936f73a2c7e25598681b25f94e284984ffa116

Update azure client to v12 - Updates the Azure client to use the recent v12, which provides better support for large file uploads and access to newer api versions from Azure. - Increase chunk size when iterating over chunks' streams (for some reason, read() calls are slower in Python 3 than in Python 2, which caused timeouts on larger layers. Increasing the amount read from 4096 per iteration is a workaround to get performance similar to Python 2).

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha 39cb17c797b9b3b6a02f9d1866bc77f75adabf64

Update azure client to v12 - Updates the Azure client to use the recent v12, which provides better support for large file uploads and access to newer api versions from Azure. - Increase chunk size when iterating over chunks' streams (for some reason, read() calls are slower in Python 3 than in Python 2, which caused timeouts on larger layers. Increasing the amount read from 4096 per iteration is a workaround to get performance similar to Python 2).

view details

push time in a month

push eventkleesc/quay

Kenny Lee Sin Cheong

commit sha b61702b956f92335532bffb944e3070a58e14280

Update azure client to v12 - Updates the Azure client to use the recent v12, which provides better support for large file uploads and access to newer api versions from Azure. - Increase chunk size when iterating over chunks' streams (for some reason, read() calls are slower in Python 3 than in Python 2, which caused timeouts on larger layers. Increasing the amount read from 4096 per iteration is a workaround to get performance similar to Python 2).

view details

push time in a month

delete branch quay/quay

delete branch : azure-update

delete time in a month

push eventquay/quay

Kenny Lee Sin Cheong

commit sha b61702b956f92335532bffb944e3070a58e14280

Update azure client to v12 - Updates the Azure client to use the recent v12, which provides better support for large file uploads and access to newer api versions from Azure. - Increase chunk size when iterating over chunks' streams (for some reason, read() calls are slower in Python 3 than in Python 2, which caused timeouts on larger layers. Increasing the amount read from 4096 per iteration is a workaround to get performance similar to Python 2).

view details

push time in a month

create barnchquay/quay

branch : azure-update

created branch time in a month

PR opened quay/quay

WIP: Azure update

Issue: https://issues.redhat.com/browse/PROJQUAY-??? Pull-request title must start with "PROJQUAY-??? - "

Changelog:

Docs:

Testing:

Details: Python 3 has some performance issues with the way streams are currently iterated over when uploading data using Azure. This PR tweaks the chunk size to improve performance on Python 3 to be more comparable to Python 2, and updates the Azure library version used to v12.4.0 from 1.1.0, which handles large files better, and has support for newer Azure API versions.

+96 -89

0 comment

2 changed files

pr created time in a month

create barnchkleesc/quay

branch : azure-update

created branch time in a month

delete branch kleesc/quay

delete branch : builder-handles-empty-job-on-component

delete time in a month

more