profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/kindoflew/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

pmndrs/react-spring 21293

✌️ A spring physics based React animation library

kindoflew/svelte-parallax 34

a spring-based parallax component for Svelte

kindoflew/svelte-starter 1

Basic Svelte boilerplate

kindoflew/code-red 0

Experimental toolkit for writing x-to-JavaScript compilers

kindoflew/idkwid 0

¯\_(ツ)_/¯

PR opened fastruby/dotenv_validator

add boolean format options

Closes #34

Description: Adds:

  • when case for 'bool' and 'boolean'
  • boolean? method to check variable
  • relevant tests for boolean ENV variables

Additional thought: Since ENV variables are strings, this just checks that it equals either 'true' or 'false'. Francois pointed out that it should maybe also cover both of those capitalized as well.

I will abide by the code of conduct.

+65 -0

0 comment

2 changed files

pr created time in 2 days

issue openedfastruby/dotenv_validator

[BUG] RuboCop 'New Cops' message causes overcommit to fail

Before we start...:

  • [x] I checked the documentation and found no answer
  • [x] I checked to make sure that this issue has not already been filed
  • [x] I'm reporting the issue to the correct repository (for multi-repository projects)

Version, Branch, or Commit: I made my own local branch, but confirmed with Francois that the issue is also happening on main.

Expected behavior: When commiting changes, RuboCop should only fail when it is supposed to (as per config).

Actual behavior: RuboCop fails because of 'unexpected output' to overcommit. There is a message from RuboCop detailing new cops that have not been configured yet, which seems to trip up overcommit.

Steps to reproduce:

How do I achieve this behavior? Use the following format to provide a step-by-step guide:

Step 1: Clone repo Step 2: Run setup script (ensure both overcommit and rubocop are installed) Step 3: Make changes and commit.

Context and environment: I found some relevant (but old) issues while trying to solve: sds/overcommit#704 rubocop/rubocop#7731

One fix recommended in the linked overcommit issue is to add --disable-pending-cops to RuboCop.flags in the config.

Provide any relevant information about your setup (Customize the list accordingly based on what info is relevant to this project)

  1. Version of the software the issue is being opened for: 1.1.0
  2. Operating System: MacOS
  3. Operating System version: BigSur 11.6
  4. Ruby version: 2.7.2

Logs

Analyze with RuboCop........................................[RuboCop] FAILED
Unexpected output: unable to determine line number or type of error/warning for output:

Please also note that you can opt-in to new cops by default by adding this to your config:
  AllCops:
    NewCops: enable
Gemspec/DateAssignment: # new in 1.10
  Enabled: true
Layout/LineEndStringConcatenationIndentation: # new in 1.18
  Enabled: true
Layout/SpaceBeforeBrackets: # new in 1.7
  Enabled: true
Lint/AmbiguousAssignment: # new in 1.7
  Enabled: true
Lint/AmbiguousRange: # new in 1.19
  Enabled: true
Lint/DeprecatedConstants: # new in 1.8
  Enabled: true
Lint/DuplicateBranch: # new in 1.3
  Enabled: true
Lint/DuplicateRegexpCharacterClassElement: # new in 1.1
  Enabled: true
Lint/EmptyBlock: # new in 1.1
  Enabled: true
Lint/EmptyClass: # new in 1.3
  Enabled: true
Lint/EmptyInPattern: # new in 1.16
  Enabled: true
Lint/LambdaWithoutLiteralBlock: # new in 1.8
  Enabled: true
Lint/NoReturnInBeginEndBlocks: # new in 1.2
  Enabled: true
Lint/NumberedParameterAssignment: # new in 1.9
  Enabled: true
Lint/OrAssignmentToConstant: # new in 1.9
  Enabled: true
Lint/RedundantDirGlobSort: # new in 1.8
  Enabled: true
Lint/SymbolConversion: # new in 1.9
  Enabled: true
Lint/ToEnumArguments: # new in 1.1
  Enabled: true
Lint/TripleQuotes: # new in 1.9
  Enabled: true
Lint/UnexpectedBlockArity: # new in 1.5
  Enabled: true
Lint/UnmodifiedReduceAccumulator: # new in 1.1
  Enabled: true
Naming/InclusiveLanguage: # new in 1.18
  Enabled: true
Style/ArgumentsForwarding: # new in 1.1
  Enabled: true
Style/CollectionCompact: # new in 1.2
  Enabled: true
Style/DocumentDynamicEvalDefinition: # new in 1.1
  Enabled: true
Style/EndlessMethod: # new in 1.8
  Enabled: true
Style/HashConversion: # new in 1.10
  Enabled: true
Style/HashExcept: # new in 1.7
  Enabled: true
Style/IfWithBooleanLiteralBranches: # new in 1.9
  Enabled: true
Style/InPatternThen: # new in 1.16
  Enabled: true
Style/MultilineInPatternThen: # new in 1.16
  Enabled: true
Style/NegatedIfElseCondition: # new in 1.2
  Enabled: true
Style/NilLambda: # new in 1.3
  Enabled: true
Style/QuotedSymbols: # new in 1.16
  Enabled: true
Style/RedundantArgument: # new in 1.4
  Enabled: true
Style/RedundantSelfAssignmentBranch: # new in 1.19
  Enabled: true
Style/StringChars: # new in 1.12
  Enabled: true
Style/SwapValues: # new in 1.1
  Enabled: true
For more information: https://docs.rubocop.org/rubocop/versioning.html

✗ One or more pre-commit hooks failed

I will abide by the code of conduct

created time in 2 days

create barnchfastruby/dotenv_validator

branch : feature/add-bool-format

created branch time in 2 days

startedtypicode/pinst

started time in 5 days

pull request commentpmndrs/react-spring

fix: handle ParallaxLayers inside fragments (#1667)

Continuing from this comment, I'm not sure that this idea is a complete fix for this bug. I also think it'd be too much to check everything a user places inside Parallax to make sure that it doesn't have ParallaxLayers as children.

Not really sure what a good solution would be. Especially considering that there are two CSS rules (overflow: clip and contain: paint) that would eliminate issues like this, except that neither is supported by Safari (or IE, but, you know).

But since doing nothing is (probably?) worse than a half-finished fix, maybe I should just finish this PR and we can use it as a stop-gap, with the above mentioned caveat (only ParallaxLayers and fragments as direct children) and just continue waiting.

kindoflew

comment created time in 5 days

issue commentfastruby/skunk.fyi

skunk is failing on pull requests

hi @etagwerker! can this be closed since fastruby/skunk#69 closed the related issue?

etagwerker

comment created time in 6 days

pull request commentfastruby/points

Rails 6.1 Upgrade

hi @mateusdeap! just wondering what the status of this is?

mateusdeap

comment created time in 6 days

issue commentpmndrs/react-spring

Parallax sticky elements don't work when wrapped in div or fragment

My original thinking was that the issue was only with fragment because those shouldn't affect anything in the DOM as they are essentially "invisible" wrappers. Also, (in my head) the ideal setup is having the only direct children of Parallax be ParallaxLayers because we use position: absolute on all of them.

But then I remembered that as long as your div doesn't use position, the layers should just position themselves relative to the next element that does (the Parallax container in this case).

So yes, I agree that this is also part of the bug and I'm probably going to close that PR in favor of working on a more comprehensive one.

gpanciera

comment created time in 9 days

startedprivatenumber/tasuku

started time in 10 days

startedgreensock/GSAP

started time in 10 days

push eventkindoflew/svelte-parallax

Lewis

commit sha 14bff75795ff19e5fe5c2c35791f45f2943cb616

add demo for testing threshold prop

view details

Lewis

commit sha 6c33613a489fd8c97a2ccb7b076749cfd6d6e6a3

clean up demos a little bit

view details

kindoflew

commit sha 5a0329e195eb9fbcb9b0c993b7b5dadf10fe393c

Merge pull request #15 from kindoflew/develop clean up demo app and add threshold

view details

push time in 10 days

push eventkindoflew/svelte-parallax

Lewis

commit sha 14bff75795ff19e5fe5c2c35791f45f2943cb616

add demo for testing threshold prop

view details

Lewis

commit sha 6c33613a489fd8c97a2ccb7b076749cfd6d6e6a3

clean up demos a little bit

view details

push time in 10 days

issue closedfastruby/afip_bill

Rename `master` branch to `main`

More here: https://www.ombulabs.com/blog/inclusion/team/culture/removing-negative-words.html

closed time in 11 days

etagwerker

issue commentfastruby/afip_bill

Rename `master` branch to `main`

No PR, but this has been completed.

etagwerker

comment created time in 11 days

delete branch fastruby/afip_bill

delete branch : master

delete time in 11 days

create barnchfastruby/afip_bill

branch : main

created branch time in 11 days

delete branch fastruby/rails_stats

delete branch : master

delete time in 11 days

create barnchfastruby/rails_stats

branch : main

created branch time in 11 days

pull request commentpmndrs/react-spring

fix: handle ParallaxLayers inside fragments (#1667)

I forgot to mention, this fix also assumes that we should only allowParallaxLayers or fragments to be direct children of Parallax (so no divs, etc.) and we should probably document that.

kindoflew

comment created time in 19 days

PR opened pmndrs/react-spring

fix: handle ParallaxLayers inside fragments (#1667)

Why

Resolves #1667

What

I've added a check where children is mapped to see if the child is a React.Fragment. If it is, we also map over the fragment's children.

Checklist

<!-- Have you done all of these things? -->

<!-- To check an item, place an "x" in the box like so: "- [x] Documentation" Remove items that are irrelevant to your changes. -->

  • [ ] Ready to be merged

A couple related questions/thoughts:

  • I threw together a very simple isReactFragment function just to confirm this works. Should we use the react-is package instead? One benefit of that is that it might also aid in figuring out a solution to #1639 (if we decide that we should do something about that). Also, it will be less brittle because we won't be relying on React internals.
  • I'm not sure if the way in which I map over the children of a fragment is ideal.

Hopefully, one day, overflow: clip will solve most of the workarounds we use for sticky.

+25 -8

0 comment

1 changed file

pr created time in 19 days

create barnchkindoflew/react-spring

branch : fix-wrapped-sticky-layers

created branch time in 19 days

startedSvelteStack/svelte-query

started time in 21 days

release kindoflew/svelte-parallax

v0.3.1

released time in 23 days

created tagkindoflew/svelte-parallax

tagv0.3.1

a spring-based parallax component for Svelte

created time in 23 days

push eventkindoflew/svelte-parallax

kindoflew

commit sha 21ec4e17a34ca46e89b1dee19b50bcafd89c0552

Merge pull request #6 from kindoflew/develop add focus-options-polyfill to dependencies

view details

kindoflew

commit sha 53e597f29cea640f59ef5013f88354922cbd3224

Merge pull request #8 from kindoflew/develop chore: update README

view details

kindoflew

commit sha 4063a998e375787d9aa2dad19842095e0b9d850a

Merge pull request #9 from kindoflew/develop small README updates

view details

kindoflew

commit sha ce93ea570025fac2b606014aac3c83674f3d40c3

Merge pull request #10 from kindoflew/develop add postinstall script for demo app

view details

kindoflew

commit sha 0fa6c27bf78843197a25096467602543aef84d1a

Merge pull request #11 from kindoflew/develop add cypress and tests

view details

kindoflew

commit sha 93d4faf345a9438eaddfa53480f522e419497da7

Merge pull request #12 from kindoflew/develop replace hardcoded value

view details

kindoflew

commit sha 366b804413365917ad658f080073ecd74daf471f

Merge pull request #13 from kindoflew/develop v0.3.0

view details

Matt Jones

commit sha 5f2abde6ba39be1bb8caa06729656d9f82051057

Update package.json Removed postinstall script.

view details

kindoflew

commit sha 97cda9aa1f179fe3242ef19ffc52b394116c6003

Merge pull request #14 from thewjones/main Removed postinstall script as it seems to be stopping the package from installing.

view details

Lewis

commit sha c64f1b970c4046d9f446b325cd41b0901be6d963

0.3.1

view details

push time in 23 days

push eventkindoflew/svelte-parallax

Lewis

commit sha c64f1b970c4046d9f446b325cd41b0901be6d963

0.3.1

view details

push time in 23 days