profile
viewpoint
Sjoerd Siebinga kiivihal Delving B.V. Den Haag, The Netherlands http://www.delving.eu

manuelbernhardt/play2-groovy-templates 22

Groovy templates for Play! 2

kiivihal/delving 4

The old home of Delving, the open-source version of the Europeana Framework.

kiivihal/open-europeana 4

Open Source version of the Europeana Framework

kiivihal/bimg 0

Small Go package for fast high-level image processing powered by libvips C library

kiivihal/chi 0

lightweight, idiomatic and composable router for building Go HTTP services

kiivihal/cookiecutter-flask 0

A flask template with Bootstrap 3, asset bundling+minification, starter templates, and registration/authentication. For use with cookiecutter.

kiivihal/cookiecutter-pypackage 0

Cookiecutter template for a Python package. See https://github.com/audreyr/cookiecutter.

kiivihal/gin 0

Live reload utility for Go web servers

kiivihal/goharvest 0

OAI harvesting toolkit for golang

PR merged delving/hub3

Bugfix/ead redirect loop

Prevent 404 when call is made to /ead/tree without "q" parameter. Both 'query' and 'byQuery' are valid parameters as well.

This was causing some issues with automated regression tests.

+6 -2

1 comment

2 changed files

YoctoByte

pr closed time in a day

push eventdelving/hub3

YoctoByte

commit sha 5064cbcd492e1e91c852125101876f06508c2f95

Bugfix/ead redirect loop (#114) Check for "q", "query" and "byQuery" url parameter before returning a 404 Co-authored-by: david <david@yoctobyte.nl> Co-authored-by: Sjoerd Siebinga <sjoerd.siebinga@gmail.com>

view details

push time in a day

push eventYoctoByte/hub3

YoctoByte

commit sha 8ae9cac5856e6908f6f5847548c67cbcbecc3bdb

Fix: ead redirect loop (#112) * Return 404 instead of 303 when inventoryID is not found * Update changelog. Co-authored-by: david <david@yoctobyte.nl> Co-authored-by: Sjoerd Siebinga <sjoerd.siebinga@gmail.com>

view details

Sjoerd Siebinga

commit sha bae477f325649ca67ee11c464afaccf7ee360174

Merge branch 'master' into bugfix/ead-redirect-loop

view details

push time in a day

push eventkiivihal/rdf2go

Sjoerd Siebinga

commit sha ee2bfee92d7771dd8b676581443e712b9281b94e

Made Graph safe for concurrent access. The previous implementation would panic when goroutines would write and read concurrently. This has been resolved through using sync.Map.

view details

push time in 6 days

created tagkiivihal/rdf2go

tagv0.1.5

Native golang library for RDF (includes parser/serializer for Turtle and JSON-LD)

created time in 6 days

created tagkiivihal/rdf2go

tagv0.1.4

Native golang library for RDF (includes parser/serializer for Turtle and JSON-LD)

created time in 9 days

push eventkiivihal/rdf2go

Sjoerd Siebinga

commit sha 45001699d18987c5dc16e3b31739a591cc072473

Added support for iteration over triples based on insert order.

view details

push time in 9 days

created tagkiivihal/rdf2go

tagv0.1.3

Native golang library for RDF (includes parser/serializer for Turtle and JSON-LD)

created time in 11 days

push eventkiivihal/rdf2go

Sjoerd Siebinga

commit sha ee0da79aab23faeeae650a6b40ef7670897916d9

Using forked version of gon3 to properly handle blank-node parsing

view details

push time in 11 days

push eventkiivihal/gon3

Sjoerd Siebinga

commit sha 4c6aac646e7e4911ed1ff7478e758a67b2e6ee57

Retain the blanknode label during parsing. Previously, the wrong function was called while parsing the blanknodes.

view details

push time in 11 days

fork kiivihal/gon3

RDF Turtle parser/serializer

fork in 11 days

push eventdelving/hub3

YoctoByte

commit sha 8ae9cac5856e6908f6f5847548c67cbcbecc3bdb

Fix: ead redirect loop (#112) * Return 404 instead of 303 when inventoryID is not found * Update changelog. Co-authored-by: david <david@yoctobyte.nl> Co-authored-by: Sjoerd Siebinga <sjoerd.siebinga@gmail.com>

view details

push time in 21 days

PR merged delving/hub3

Fix: ead redirect loop

When no result is found for a query in the tree API with an inventoryID, you are redirected to the first result page. When the inventoryID is invalid, it can create a redirectloop, see #111.

This pull-request returns a 404 when the first page returns zero results.

+6 -0

2 comments

2 changed files

YoctoByte

pr closed time in 21 days

push eventYoctoByte/hub3

Sjoerd Siebinga

commit sha 8eed6cd15610ce7a27e1ed2cf728acb858b737cd

Update changelog.

view details

push time in 21 days

issue commentdelving/hub3

quering an invalid inventoryID with paging=true causes a redirect loop

I think the workflow is dependent on a query being present in the query params. If we search for something on a specific inventoryID and we get 0 results it should show the first page.

If we get zero results because the inventoryID is invalid then we should not have a 'q' in the query params. If we do, we terminate with a 404.

A solution could be:

		if paging.HitsTotalCount == 0 && searchRequest.Tree.IsSearch && searchRequest.Tree.IsPaging {
			// if there is no query in the params then this is already a redirect
			if !r.URL.Query().Has("q") {
				http.Error(w, fmt.Sprintf("inventoryID '%s' not found", searchRequest.Tree.UnitID), http.StatusNotFound)
				return
			}
			newPath := fmt.Sprintf("%s?paging=true&page=1", r.URL.Path)
			http.Redirect(w, r, newPath, http.StatusSeeOther)
			return
		}

YoctoByte

comment created time in 22 days

push eventdelving/hub3

Sjoerd Siebinga

commit sha 1fa9cf55d6b76cbb5b1fd3f67dfd016cf02a5945

validator: Add validator package This package can be used by other packages to create validation chains.

view details

dependabot[bot]

commit sha 8b2d52f35e2035da1bcd4fb4bcd3e3325cd651aa

Bump code.gitea.io/gitea from 1.12.2 to 1.13.4 (#104) Bumps [code.gitea.io/gitea](https://github.com/go-gitea/gitea) from 1.12.2 to 1.13.4. - [Release notes](https://github.com/go-gitea/gitea/releases) - [Changelog](https://github.com/go-gitea/gitea/blob/main/CHANGELOG.md) - [Commits](https://github.com/go-gitea/gitea/compare/v1.12.2...v1.13.4) --- updated-dependencies: - dependency-name: code.gitea.io/gitea dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Sjoerd Siebinga

commit sha 863779d2fceb1d79a0966ef258292905d710c586

Added support for custom Run function to posthook interface. (#107) This function will run before DropDataset(). This addition will allow for custom functions to only run after all records have been indexed.

view details

Sjoerd Siebinga

commit sha 12094dceb7e6b355835940a5958d29f2f6fb0315

Remove deprecated custom tagging functionality.

view details

Sjoerd Siebinga

commit sha 778b0954cd864d304e1b93f766d5da3f894707a7

Removed unused storage placeholders.

view details

Sjoerd Siebinga

commit sha 4a14ee5fb266d801c4457e0496164cc82c2fafcc

Added http.HandlerFunc for static files from embed.FS. embed.FS does not support last modified time-stamps. Without this wrapper the static files can never be cached by the browser.

view details

Sjoerd Siebinga

commit sha 612f4389252c8970f0a88b963442925bf7bdaf6e

Added support for serving static content. Via the SetStaticFS option you can serve content from embed.FS.

view details

Sjoerd Siebinga

commit sha 7c29d1e740d07133236863bbdbfbdf4127ef9bf5

Return breadcrumbs from BreadCrumbBuilder. This allows for package external use of the builder to build breadcrumbs.

view details

Daniel Karso

commit sha 6e206f4ef198acc013ec9a5b57aadae4cf645152

Add metadata message to File message

view details

Daniel Karso

commit sha aab7673f981d0e8e22bb86ea3d11511a533d7a94

Add label to field to values

view details

Sjoerd Siebinga

commit sha 7019ea2149c710da569bae1d002e13984ed3db55

Updated changelog

view details

Sjoerd Siebinga

commit sha d2f7f04d9f9061a6dd7774b72d6a0ff46511515b

Fix for too strict EAD sanitizer for unittitle. (#109) * Fix for too strict EAD sanitizer for unittile. * Also <subject> to test data.

view details

Sjoerd Siebinga

commit sha 52e22f40f3e3aa24f5f954902383090e8c1854b5

Show all EAD unittitles in tree.Label output. (#110) Previously, only the first title was shown.

view details

Sjoerd Siebinga

commit sha 852cb70f81d60a1f0d7d76628908da1ff1229924

Merge branch 'master' into feature/configuration-organization-service

view details

push time in 25 days

release delving/narthex

v0.6.2

released time in a month

created tagdelving/narthex

tagv0.6.2

Performs bulk dataset-processing for the Delving platform.

created time in a month

push eventdelving/narthex

Sjoerd Siebinga

commit sha c493dec4244f33f0369205b3af6ec0c17e3fa4be

bumped version number.

view details

push time in a month

PR opened delving/hub3

Show all EAD unittitles in tree.Label output.

Previously, only the first title was shown.

+2 -1

0 comment

2 changed files

pr created time in a month

create barnchdelving/hub3

branch : feature/show-all-ead-unittitles-in-tree-label

created branch time in a month

PR opened delving/narthex

Feature/local id extraction fix

Fixed incorrect localID for NA /doc based URLs.

Previously everything before the slash was extracted, which lead to invalid hubIDs being submitted for indexing.

+11 -5

0 comment

2 changed files

pr created time in a month

create barnchdelving/narthex

branch : feature/localID-extraction-fix

created branch time in a month

push eventdelving/hub3

Sjoerd Siebinga

commit sha d2f7f04d9f9061a6dd7774b72d6a0ff46511515b

Fix for too strict EAD sanitizer for unittitle. (#109) * Fix for too strict EAD sanitizer for unittile. * Also <subject> to test data.

view details

push time in a month

PR merged delving/hub3

Fix for too strict EAD sanitizer for unittitle.

In same cases a <unittitle> contained an embedded <title> tag. Without the relaxing the content of this tag would be removed as well after sanitation.

This change adds exemptions for 'subject' and 'title'. So the tag is removed, but the content is left in place.

+3 -3

4 comments

3 changed files

kiivihal

pr closed time in a month

Pull request review commentdelving/hub3

Fix for too strict EAD sanitizer for unittitle.

 <did>     <unitid identifier="42343242" type="ABS">1</unitid>     <unitid audience="internal" type="handle">http://hdl.handle.net/10648/1c01167d-7b89-49cc-a681-9a438f95a2ae</unitid>-    <unittitle>Octrooi verleend door de Staten-Generaal betreffende de alleenhandel ten oosten van Kaap de Goede Hoop en ten westen van de Straat van Magallanes voor de duur van 21 jaar</unittitle>+    <unittitle><title>Octrooi</title> verleend door de Staten-Generaal betreffende de alleenhandel ten oosten van Kaap de Goede Hoop en ten westen van de Straat van Magallanes voor de duur van 21 jaar</unittitle>

I added '<subject>' to the test as well.

kiivihal

comment created time in a month

PullRequestReviewEvent

push eventdelving/hub3

Sjoerd Siebinga

commit sha 5f66d48f44a00470cb172a10e4a1e10fa0634bef

Also <subject> to test data.

view details

push time in a month

PR opened delving/hub3

Fix for too strict EAD sanitizer for unittitle.

In same cases a <unittitle> contained an embedded <title> tag. Without the relaxing the content of this tag would be removed as well after sanitation.

This change adds exemptions for 'subject' and 'title'. So the tag is removed, but the content is left in place.

+3 -3

0 comment

3 changed files

pr created time in a month

create barnchdelving/hub3

branch : feature/ead-sanitizer-relaxing

created branch time in a month

more