profile
viewpoint
Kevin Weber kevinweber @Airbnb San Francisco, CA https://www.kweber.com

Bounteous-Inc/aem-webpack-example 78

Best practice for setting up Webpack in AEM.

kevinweber/aem-front 36

[Deprecated] Use AEM Fed instead: aemfed.io

kevinweber/inline-comments 26

Inline Comments adds your comment system to the side of paragraphs and other sections of your post. WordPress plugin.

kevinweber/dime 4

Uber-micro library (<1kb) for selecting elements and handling custom events. No dependencies. IE9+

Bounteous-Inc/eslint-config-infield 2

An ESLint configuration following Infield Digital's JavaScript Coding Guidelines

Bounteous-Inc/stylelint-config-infield 1

A Stylelint configuration following Infield Digital's CSS Coding Guidelines

christopher-siegel/meshmix-app 1

Repo for the ionic app Meshmix

christopher-siegel/meshmix-backend 1

Repo for the meshmix API backend

christopher-siegel/meshmix-website 1

Repo for the meshmix website

kevinweber/aem-front-extension 1

Chrome extension to make BrowserSync work with AEM Front. Plus extras to get work done faster.

startedbrowserslist/browserslist-useragent

started time in 9 days

startedtutao/tutanota

started time in 14 days

startedGoogleChromeLabs/tooling.report

started time in a month

startedpiuccio/cowsay

started time in 2 months

starteduber/piranha

started time in 2 months

pull request commentfacebook/react

Support Babel's envName option in React Refresh plugin

@gaearon Any update on getting this merged? It's not urgent; I'm just guessing that this will never get merged unless I keep pinging you :D

kevinweber

comment created time in 2 months

startedmapbox/pixelmatch

started time in 2 months

issue commentkevinweber/lazy-load-for-videos

Youtube image overlapping white triangle

@mrbm Thanks for reporting! Should now be fixed with version 2.8.7

mrbm

comment created time in 3 months

created tagkevinweber/lazy-load-for-videos

tagv2.1.1

Speed up your site by replacing embedded Youtube and Vimeo videos with a clickable preview image. Free WordPress plugin.

created time in 3 months

push eventkevinweber/lazy-load-for-videos

Kevin Weber

commit sha 43e458509b71591c946321b6482eca37c60db7cf

Update compiler options

view details

Kevin Weber

commit sha 2e14f40dd8094a9dc4acc6d699da92f604729dc8

Update dependencies

view details

Kevin Weber

commit sha f9772e859ada15730f905e15b886c6ced4edbce5

Speed up Webpack build

view details

Kevin Weber

commit sha 43c1e35fc4132d559c1962ffc39bfb631846934f

Fix output path

view details

Kevin Weber

commit sha 75269792dae42e87fb86f97c340b26be99c85cdb

Use bg gradient instead of img

view details

Kevin Weber

commit sha 499a04eec8ebbee1d4808745f5f82b48d33b650f

Simplify

view details

Kevin Weber

commit sha 5583dd555b0e1cc72f3982c5c601eaf1101d3dfa

Fix duplicate play buttons and simplify

view details

Kevin Weber

commit sha 43afd07a09af03e6e23d82395d5b3dfedf893a58

Build prod

view details

Kevin Weber

commit sha f8999c47a445f50a1003972970ca307b03351426

v2.8.7

view details

push time in 3 months

Pull request review commentfacebook/react

Support Babel's envName option in React Refresh plugin

 export default function(babel, opts = {}) {   if (typeof babel.getEnv === 'function') {

@gaearon Good callout, thanks! It's fixed now.

kevinweber

comment created time in 3 months

push eventkevinweber/react

Kevin Weber

commit sha 6f032e62c7f928c529d34cafb413f053ed729b89

Replace getEnv with env

view details

push time in 3 months

push eventkevinweber/react

Yann アウネ Eves

commit sha 4821d609e99f6bd6454279ee2a82448703d2f616

fix(eslint-plugin-react-hooks): Added matching for nullish coalescing and optional chaining of dependencies, relates to #18985 (#19008)

view details

Julien Deniau

commit sha 8abc202c7fc73fdfcd9443b00d09d06da4b5cbb1

[eslint-plugin-react-hooks] Prefer recommended eslint configuration (#18951) * [eslint-plugin-react-hooks] Prefer recommended eslint configuration * Update README.md Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

view details

Toru Kobayashi

commit sha fb735423bb10ae7d23ae42470620e963b8110163

Fix rollup validate script (#18900) * Revert "Revert "deps: update ESLint version to v7 (#18897)" (#18899)" This reverts commit 84fd4b853fd64651abf0b84f4ca879a9e43a106a. * fix rollup validate script

view details

Andrew Clark

commit sha 9273e6585fba9d66901c29b2c4eaed1b5af52f2c

Disable DevTools build job to unblock master (#19012)

view details

Kevin Weber

commit sha c4ae5734492c68aac5ba7278d41cc15a3e56252d

Fix envName bug

view details

push time in 3 months

push eventkevinweber/react

Yann アウネ Eves

commit sha 4821d609e99f6bd6454279ee2a82448703d2f616

fix(eslint-plugin-react-hooks): Added matching for nullish coalescing and optional chaining of dependencies, relates to #18985 (#19008)

view details

Julien Deniau

commit sha 8abc202c7fc73fdfcd9443b00d09d06da4b5cbb1

[eslint-plugin-react-hooks] Prefer recommended eslint configuration (#18951) * [eslint-plugin-react-hooks] Prefer recommended eslint configuration * Update README.md Co-authored-by: Dan Abramov <dan.abramov@gmail.com>

view details

Toru Kobayashi

commit sha fb735423bb10ae7d23ae42470620e963b8110163

Fix rollup validate script (#18900) * Revert "Revert "deps: update ESLint version to v7 (#18897)" (#18899)" This reverts commit 84fd4b853fd64651abf0b84f4ca879a9e43a106a. * fix rollup validate script

view details

Andrew Clark

commit sha 9273e6585fba9d66901c29b2c4eaed1b5af52f2c

Disable DevTools build job to unblock master (#19012)

view details

push time in 3 months

push eventkevinweber/react

Kevin Weber

commit sha 18155d4f3c9e95792d811d4e601c19503c00c3a7

Update test input

view details

push time in 3 months

PR opened facebook/react

Support Babel's envName option in React Refresh plugin

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (yarn test). Tip: yarn test --watch TestName is helpful in development.
  5. Run yarn test-prod to test in the production environment. It supports the same options as yarn test.
  6. If you need a debugger, run yarn debug-test --watch TestName, open chrome://inspect, and press "Inspect".
  7. Format your code with prettier (yarn prettier).
  8. Make sure your code lints (yarn lint). Tip: yarn linc to only check changed files.
  9. Run the Flow typechecks (yarn flow).
  10. If you haven't already, complete the CLA.

Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html -->

Summary

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

babel.getEnv() ignores Babel's envName option that can be used, for example, when calling transformFromAst from @babel/core directly. This can throw an error if skipEnvCheck == false and process.env.BABEL_ENV !== 'development'.

Using babel.env() prioritizes envName over process.env.<x> values and resolves the issue.

Test Plan

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. --> Added a test. If I change babel.env() back to babel.getEnv(), the test fails.

+19 -2

0 comment

2 changed files

pr created time in 3 months

create barnchkevinweber/react

branch : kw--babel-envname

created branch time in 3 months

fork kevinweber/react

A declarative, efficient, and flexible JavaScript library for building user interfaces.

https://reactjs.org

fork in 3 months

startedmiukimiu/react-kawaii

started time in 3 months

more