profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/kcsongor/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Csongor Kiss kcsongor London, United Kingdom http://kcsongor.github.io dysfunctional programmer

kcsongor/generic-lens 401

Generically derive traversals, lenses, and prisms.

kcsongor/arm-doom 48

Doom-like engine on Raspberry Pi, in pure bare metal assembly

j-mie6/ParsleyHaskell 31

Reimplementation of Parsley in Haskell, with improvements

isovector/hs2 14

a new, WIP Haskell compiler

justinwoo/records-fields-pairwise 6

a pairwise records operation demo with GHC8 generics and generic-lens

kcsongor/ghc 3

Mirror of the Glasgow Haskell Compiler. Patches are best submitted to GHC's GitLab instance (https://gitlab.haskell.org/), bugs and feature-requests are best filed to GHC's Trac (https://ghc.haskell.org/trac/ghc), or sent to the mailing list (ghc-devs@haskell.org). First time contributors are encouraged to get started by just sending a Pull Request.

kcsongor/haskell-auto-reload-mode 2

Emacs minor mode to automatically reload interactive haskell sessions

kcsongor/ghc-proposals 1

Proposed compiler and language changes for GHC and GHC/Haskell

issue commentkcsongor/generic-lens

A different approach to fields

There might be some subtleties I'm missing, but I think we already a have a similar lens:

https://github.com/kcsongor/generic-lens/blob/8e1fc7dcf444332c474fca17110d4bc554db08c8/generic-lens/src/Data/Generics/Product/Fields.hs#L112-L124 with the instance defined as https://github.com/kcsongor/generic-lens/blob/8e1fc7dcf444332c474fca17110d4bc554db08c8/generic-lens/src/Data/Generics/Product/Fields.hs#L167-L168

https://github.com/kcsongor/generic-lens/blob/8e1fc7dcf444332c474fca17110d4bc554db08c8/generic-lens-core/src/Data/Generics/Product/Internal/Fields.hs#L44-L50

This uses

https://github.com/kcsongor/generic-lens/blob/8e1fc7dcf444332c474fca17110d4bc554db08c8/generic-lens-core/src/Data/Generics/Internal/Families/Changing.hs#L133-L137

This machinery looks similar to Similar at a first glance. Is this what you're after? If there's anything more we can do, I'm happy to add it to the package.

For concrete types this works out quite well, but in my experience, the fundeps come in really handy in a polymorphic context (like when a function has a HasField constraint, then without the fundeps, GHC will complain about ambiguous constraints).

treeowl

comment created time in a day

startedrougier/nano-sidebar

started time in 18 days

pull request commentghc-proposals/ghc-proposals

Unsaturated type families

Yes, unsaturated applications are supported within equality constraints too, but type families are only reduced once all arguments are supplied.

kcsongor

comment created time in a month

issue closedkcsongor/generic-lens

Build failure with GHC 9.0

The Hackage releases now needs an upper bound on base. Error from building generic-lens-core-2.1.0.0 with GHC 9:

src/Data/Generics/Internal/Profunctor/Iso.hs:76:7: error:
    • Couldn't match type: p0 i0 a b -> p0 i0 s t
                     with: forall (p :: * -> * -> * -> *) i.
                           Profunctor p =>
                           p i a b -> p i s t
      Expected: (s -> a) -> (b -> t) -> Iso s t a b
        Actual: (s -> a) -> (b -> t) -> p0 i0 a b -> p0 i0 s t
    • In the expression: dimap
      In an equation for ‘iso’: iso = dimap
    • Relevant bindings include
        iso :: (s -> a) -> (b -> t) -> Iso s t a b
          (bound at src/Data/Generics/Internal/Profunctor/Iso.hs:76:1)
   |
76 | iso = dimap
   |       ^^^^^

closed time in 2 months

Lysxia

issue commentkcsongor/generic-lens

Build failure with GHC 9.0

#130 is now released on 2.2.0.0

Lysxia

comment created time in 2 months

push eventkcsongor/generic-lens

Csongor Kiss

commit sha 127863b163b4caddc58a56664a643d774272b6fc

Comment out failing test

view details

push time in 2 months

push eventkcsongor/generic-lens

Csongor Kiss

commit sha 3e7b7414156f36b7d548b7e7ba715e626125b39e

Comment out failing tests

view details

push time in 2 months

issue commentkcsongor/generic-lens

Build failure with GHC 9.0

Making a release now

Lysxia

comment created time in 2 months

push eventkcsongor/generic-lens

Csongor Kiss

commit sha 0ca60f43057908ca68b0971cd17dff04d645f3ad

Bump to 2.2.0.0

view details

push time in 2 months

created tagkcsongor/generic-lens

tag2.2.0.0

Generically derive traversals, lenses, and prisms.

created time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha 37744fd3920513c02970f3c96658ea33d16a4372

p22 no longer a link

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha c7185dfb2b66517a972e421c5b53d31832eaad10

Within 25

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha 82ba2ccd0f99245620f39582c39ca9f565646639

strangeness

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha 199de6950fed6e7ccda125462a1ed8e868d2672c

More minor edits

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha beb7a2882fdfed6b291587c9148e619f58e23d0b

Minor edits to 5.2

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha ad7be2625f68c4ae2b65356396daab517e437e75

Typo

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha c525fe5918b147c2251a5f6509cb1e12b4088e58

Fix colour

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha 3bd4f6275491614a6bfd4ec4251a7a623ed8a809

Add missing comma

view details

Csongor Kiss

commit sha 8031e9cfd5e8af400dc368ab1fffed9417f4e0da

Prove solver soundness

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha f83f3e8f275a879b0b09469a239efabdd42d34b2

Use cref everywhere

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha cda9a9476a8c9f6512699b5651a1bb7d7d11f13d

Fix reference and use cref

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha b86f09fb0e266f339dbb156c9791760a904645a6

No longer wrong

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha 912e73ae00397f162a6b4c539146c61dfd7c5f35

State constraint solver soundness

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha f7f7d2589d23ea7923ae9bb52282759d1f571097

Fix constraint generation proof (for new Var rule)

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha b6462a03a88eb10e25c887ffc65aff655d42968b

Note about equalities

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha 815989443bb4d43f5d890aae1aa4f97a905bbc06

Remove footnote and add note

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha d67d642217ddcc8bf99544af7cd106d1b44262f9

Comment out details about existentials

view details

Csongor Kiss

commit sha d718e4854f9ff7d284f26a331f2ae0ba48e53111

Include example in 9.3

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha bf1d7d6d8828ab93d1542f93cf514ab3f7acbc83

Better center |->

view details

Csongor Kiss

commit sha 50b3b1ed1d8b0caf22618f73cd7a96414b38684b

Fix UPPERCASE in bib

view details

Csongor Kiss

commit sha 52f8065be5f04c8be41205c7aa255f948aead309

Revamp Section 8

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha 90c2ace8fa73a61ada40f0185123c87163d20094

author order

view details

push time in 2 months

push eventtweag/linear-constraints

Csongor Kiss

commit sha bc7f0ec5bb23873bd49591347c32fb49451f2d4f

Constraint generation is a two step process

view details

Csongor Kiss

commit sha d3cefed4f084557f3410b8c75ecd7b453d9397d0

Fix dangling reference

view details

push time in 3 months

issue commentkcsongor/generic-lens

Recursing with typed as well as types

I implemented this feature a while ago (it might be on a branch? I can't remember), but never merged it because of how brittle I thought it was. Since the lens focuses on a single element, it only makes sense if the whole type has exactly one value of that type (as your A6 example shows). We have to look deep, and if any type in the tree has no Generic instance then the procedure fails. (though the "types" combinator suffers from the same issue, and that has a workaround)

I thought about maybe taking an additional numeric argument to specify the maximum depth, but that seemed inelegant. Since then, I've actually whished for this feature a few times myself, and I'm now thinking that this might be a good thing to do after all.

I won't have too much time/energy in the near future to work on it though. I'll keep it in mind the next time I come back here!

PPKFS

comment created time in 3 months