profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/kara/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Kara kara Google San Francisco, CA Aurora team (Google Chrome)

angular/cdk-builds 32

Angular CDK builds

angular/material2-docs-content 30

Docs content for @angular/material

angular/flex-layout-builds 13

Build snapshots for @angular/flex-layout

kara/dashboard 3

General-purpose web UI for Kubernetes clusters

IgorMinar/purify 2

experimental stuff, not something you want to rely on :-)

issue openedvercel/next.js

Add more data to docs on why image optimization is important

Describe the feature you'd like to request

The top of the Image Optimization page now has a list of next/image performance benefits, but it also might be helpful for folks to hear more specific data about the problem that it's trying to solve (i.e.why images are such a big contributor to perf issues on the web).

Describe the solution you'd like

Add stats to the Image Optimization intro like:

  • Unoptimized images account for over 70% of the total page weight in bytes at the 90th percentile. (https://almanac.httparchive.org/en/2020/page-weight#image-bytes)
  • The number of images on a page is the second greatest predictor of conversions of users visiting websites. (https://almanac.httparchive.org/en/2019/page-weight#bigger-complex-pages-can-be-bad-for-your-business)

Describe alternatives you've considered

There are a bunch more stats in the Web Almanac that could be interesting to cite.

created time in 2 hours

issue openedvercel/next.js

Clarify in Image Optimization docs which width/height to use

Describe the feature you'd like to request

The current Image Optimization guide mentions that a width/height is mandatory when not using a static image or a "fill" layout, but doesn't specify which width/height to provide. The intrinsic size of the image or the size at which you'd like the image to be displayed? This confuses people because with a responsive strategy, you'd want to render the image at many different sizes depending on the device (so which width to provide?)

Describe the solution you'd like

Add a sentence or two to the "Image Sizing" requirements section that clarifies how to set width/height.

Describe alternatives you've considered

Could also add some explanation to the initial code example that includes width/height

created time in 2 hours

push eventkara/next.js

Kara Erickson

commit sha fc7089a2e4da3d85d0e0cc8e5658d5c52d630473

Add "priority" section to Image Optimization doc This change addresses some feedback that some users don't realize that the `priority` attribute exists and is critical for managing LCP when using the next/image component. It adds a dedicated section to the Image Optimization doc that explains how and when to use the attribute. Fixes #29624

view details

push time in 2 hours

PR opened vercel/next.js

Add "priority" section to Image Optimization doc

This change addresses some feedback that some users don't realize that the priority attribute exists and is critical for managing LCP when using the next/image component. It adds a dedicated section to the Image Optimization doc that explains how and when to use the attribute.

Fixes #29624

Documentation / Examples

  • [x] Make sure the linting passes by running yarn lint
+30 -0

0 comment

1 changed file

pr created time in 2 hours

create barnchkara/next.js

branch : priority

created branch time in 2 hours

PR opened vercel/next.js

Deferred content returns placeholder

This change is more prep to support "classic" (two-part) streaming. It adds a placeholder for content that is deferred and adds structure to infer whether the content should be deferred based on whether "props" returned from gSSP is a promise. However, it still enforces that deferring content is always turned off (until the feature is fully implemented).

See more of the full design here: https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

+74 -20

0 comment

5 changed files

pr created time in 10 days

push eventkara/next.js

Kara Erickson

commit sha ca41b60d19fa4a4951a33d599895aa15aa6d4101

Deferred content returns placeholder This change is more prep to support "classic" (two-part) streaming. It adds a placeholder for content that is deferred and adds structure to infer whether the content should be deferred based on whether "props" returned from gSSP is a promise. However, it still enforces that deferring content is always turned off (until the feature is fully implemented). See more of the full design here: https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 10 days

push eventkara/next.js

Kara Erickson

commit sha c2cb5dfa8a4bb589653629a1257cc7c57d0e33c2

Deferred content returns placeholder This change is more prep to support "classic" (two-part) streaming. It adds a placeholder for content that is deferred and adds structure to infer whether the content should be deferred based on whether "props" returned from gSSP is a promise. However, it still enforces that deferring content is always turned off (until the feature is fully implemented). See more of the full design here: https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 10 days

push eventkara/next.js

Kara Erickson

commit sha 1bcf37811eb17af096467c75721d3de51a79ceef

Deferred content returns placeholder This change is more prep to support "classic" (two-part) streaming. It adds a placeholder for content that is deferred and adds structure to infer whether the content should be deferred based on whether "props" returned from gSSP is a promise. However, it still enforces that deferring content is always turned off (until the feature is fully implemented). See more of the full design here: https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 10 days

create barnchkara/next.js

branch : placeholder

created branch time in 10 days

push eventkara/next.js

Kara

commit sha 5760ceac8668af23b81e66026259385b33159e03

Refactor Document to prep for classic streaming (#29834) This refactor is the first of a few changes to support "classic" (two-part) streaming. This one should be a noop that doesn't actually change the behavior. It re-organizes the way that functions are wrapped in Document Head/NextScript so anything that will be part of the second flush can be separated out from the first flush. It also adds the structure for a useMaybeDeferContent hook, but currently always assumes that nothing should be deferred. The next PRs will actually implement streaming.

view details

Kara Erickson

commit sha 68bf675386fd1155135e3f078083e94ab9e4a4a5

Deferred content returns placeholder This change is more prep to support "classic" (two-part) streaming. It adds a placeholder for content that is deferred and adds structure to infer whether the content should be deferred based on whether "props" returned from gSSP is a promise. However, it still enforces that deferring content is always turned off (until the feature is fully implemented). See more of the full design here: https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 10 days

pull request commentvercel/next.js

Refactor Document to prep for classic streaming

Note: HMR failures look like flakes (e.g. on master too here, https://github.com/vercel/next.js/pull/29884#issuecomment-942461341)

kara

comment created time in 10 days

push eventkara/next.js

Kara Erickson

commit sha 0336e541b503327e8820608db861407fa6d4a683

Refactor Document to prep for classic streaming This refactor is the first of a few changes to support "classic" (two-part) streaming. This one should be a noop that doesn't actually change the behavior. It re-organizes the way that functions are wrapped in Document Head/NextScript so anything that will be part of the second flush can be separated out from the first flush. It also adds the structure for a useMaybeDeferContent hook, but currently always assumes that nothing should be deferred. The next PRs will actually implement streaming. For more details on the full design, see https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 10 days

push eventkara/next.js

Kara Erickson

commit sha 511715a756ab0e5eaeb3186672330148a41cf705

Refactor Document to prep for classic streaming This refactor is the first of a few changes to support "classic" (two-part) streaming. This one should be a noop that doesn't actually change the behavior. It re-organizes the way that functions are wrapped in Document Head/NextScript so anything that will be part of the second flush can be separated out from the first flush. It also adds the structure for a useMaybeDeferContent hook, but currently always assumes that nothing should be deferred. The next PRs will actually implement streaming. For more details on the full design, see https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 10 days

push eventkara/next.js

Steven

commit sha f6d99c3d7442a8e97a84bc251c39a72c3e2a5e07

Add rich to codeowners for docs (#29848)

view details

Max Schmitt

commit sha ca062db2a45e90a1270e7b33033b3a2c4cebac3c

docs(testing): added Playwright guide (#29832) Blocked by https://github.com/vercel/next.js/pull/29426

view details

Phattarapol L

commit sha 5d992a6a2830c7ca62ef15f6411b68d07d18a218

Add Scss variables section to Built-in CSS Support document (#29822) ## Feature - [x] Documentation added ## Documentation / Examples - [x] Make sure the linting passes

view details

Donny/강동윤

commit sha 7b3cce3f94ef88379f037bf02975996d3cbebaed

Update swc (#29843) Co-authored-by: kdy1 <kdy1@users.noreply.github.com>

view details

Seraphina Orsini

commit sha c78d8fad19e70a71fe9975984bf6f59e3bfb27bb

Pin create-next-app to eslint@v7 (#29837) Fixes https://github.com/vercel/next.js/issues/29770 ## Description Pins `eslint` to `v7`. This avoids issues with `v8` from both [changes to the public api](https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0#the-lib-entrypoint-has-been-removed) and [lack of support from rushstack](https://github.com/microsoft/rushstack/issues/2890). See https://github.com/vercel/next.js/issues/29770#issuecomment-940636627 for slightly more detail. Local testing showed output of next app correctly pinned to `v7`. <img width="495" alt="Screen Shot 2021-10-12 at 12 31 56 AM" src="https://user-images.githubusercontent.com/29002354/136892312-1571718c-882b-4235-98f4-c1b8d4c72d26.png"> ### Bug Checklist - [X] Related issues linked using `fixes #number` - [ ] Integration tests added - Happy to add an integration test for pinning to v7 if we'd like, will need to be updated / removed when v8 is supported. - [ ] Errors have helpful link attached, see `contributing.md` - No errors to add links for

view details

Steven

commit sha bda4ca6ef369ea529359339bf3972017fdc53e44

v11.1.3-canary.65

view details

Mike Osterhout

commit sha 3910c3890e2c2e7f71cc15b5a790d0ad96a2dbcf

Update typescript version (#29854) Resolves message using `yarn dev` ``` warn - Minimum recommended TypeScript version is v4.3.2, older versions can potentially be incompatible with Next.js. Detected: 4.0.8 ``` ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`

view details

Genet Schneider

commit sha e40785e1e2d58459e958dad287e0e9ef3d089898

Avoid TypeError when comparing path param (#29821) ## Bug Fixes a TypeError when accessing url with no path params `_next/data/<BUILD_ID>` ``` TypeError: Cannot read property 'endsWith' of undefined at Object.fn (/app/node_modules/next/server/next-server.ts:644:52) at Router.execute (/app/node_modules/next/server/router.ts:346:40) at Server.run (/app/node_modules/next/server/next-server.ts:1229:41) at Server.handleRequest (/app/node_modules/next/server/next-server.ts:489:25) at /app/node_modules/next/server/next.ts:47:14 ``` - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` - [ ] ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes

view details

Tobias Koppers

commit sha 7cb5577e48a1c4bed0582c0398fd81c27e11d67c

make test directories more unique (#29864) I wouldn't believe it, but it actually happens that the first two test cases try to create their test directory at the same millisecond, resulting in a shared directory, which leads to conflicts.

view details

Jan Nicklas

commit sha 31a701b9dac6db200f5b75039a2d04a23cb572e4

feat(jsconfig-paths-plugin): Resolve paths synchronously (#29467)

view details

Donny/강동윤

commit sha c3971010f5773f7da8d6c0b4838ffe73ade3add0

Update swc (#29866) Co-authored-by: kdy1 <kdy1@users.noreply.github.com>

view details

Tim Neutkens

commit sha 96c2980c77fdf185cda64c70fab4c6b228ab516b

v11.1.3-canary.66

view details

Donny/강동윤

commit sha b99cfb8cfa32ebd5c8ae9da1cdc280fc48f137eb

Update swc (#29881) Co-authored-by: kdy1 <kdy1@users.noreply.github.com>

view details

Tim Neutkens

commit sha 9cf49ddf4305d87735341e1bc4b4c4858e6b8d1d

v11.1.3-canary.67

view details

Rich Haines

commit sha eed43115eca722540a8dbc165e070a4462a43d97

Added more examples to Response Helpers page (#29462) ## Bug - [x] Related issues linked using Fixes: https://github.com/vercel/front/issues/11154 - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes

view details

Angelo P

commit sha 541259d9922801027b4de29515c86a7dcbb790e1

Update testing based on Failed to parse src "test-file-stub" on `next… (#29039) …/image` Error While learning how to test next.js applications I came across this error when testing components using next/image with an image import eg: ``` // /quiz-hero import Image from 'next/image'; import quizImage from '../../public/undraw-quiz.svg'; // In render <Image height='91' width='198' layout='fixed' src={quizImage} alt='QuizImage' /> ``` ### Error -> Failed to parse src "test-file-stub" on `next/image`, if using relative image it must start with a leading slash "/" or be an absolute URL (http:// or https://) This is fixed by adding a "/" to the beginning of your file-stub module export string. This is not an error when you're awaiting an image using async waitFor, But comes up as an error when you're testing a component that holds another component with a "next/image" import. eg: ``` // quizHero.test.tsx works like this without change. const image = await waitFor(() => screen.findByAltText('QuizImage')); // but index.test.tsx fails rendering the homepage without the change. render(<Home />); // Error: Failed to parse src "test-file-stub" on `next/image`... // with change to __mocks__/fileMock quizHero.test.tsx //test pass index.test.tsx //test pass ``` <!-- Thanks for opening a PR! Your contribution is much appreciated. In order to make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change that you're making: --> ## Bug possibly related to -> #26749 ## Feature - [X] Documentation added ## Documentation / Examples - [X] Make sure the linting passes

view details

Tobias Koppers

commit sha ecd31ab62fe8b856c6a09104ce774f99914f5434

update webpack (#29870)

view details

Tim Neutkens

commit sha a002f612c3d00886402368cc0c705324a9b56ff0

Add experimental option to enable fullySpecified (#29880)

view details

Tobias Koppers

commit sha f530b0d312ff14fba2e689a7de6ae0f258d09212

only listen to drain even once (#29885) gets rid of `(node:670) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 drain listeners added to [WriteStream]. Use emitter.setMaxListeners() to increase limit`

view details

Donny/강동윤

commit sha bf9e998ae3a58699bf8d01362daa5eb63fade82a

Update swc & Improve CI time (#29884) Co-authored-by: JJ Kasper <jj@jjsweb.site> Co-authored-by: kdy1 <kdy1@users.noreply.github.com>

view details

push time in 10 days

push eventkara/next.js

Kara Erickson

commit sha 1e8b1466393425029fbe3a6137a6e0cbcd408b2a

Refactor Document <Head> to prep for classic streaming This refactor is the first of a few changes to support "classic" (two-part) streaming. This one should be a noop that doesn't actually change the behavior. It re-organizes the way that functions are wrapped in Document Head so anything that will be part of the second flush can be separated out from the first flush. It also adds the structure for a useMaybeDeferContent hook, but currently always assumes that nothing should be deferred. The next PRs will actually implement streaming. For more details on the full design, see https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 10 days

push eventkara/next.js

Kara Erickson

commit sha f106bf33daf3b2b7d5ca25676275b7f5fc7b4393

Add useMaybeDeferContent hook

view details

push time in 12 days

push eventkara/next.js

Keen Yee Liau

commit sha 13f68debfeb9062007017e345a73c30cfe2dfc5a

Collect feature usage for optimizeCss (#29828) `optimizeCss` is a feature that inlines critical CSS using critters. The Aurora team would like to gauge adoption rate for this feature. ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Documentation added - [x] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes

view details

Steven

commit sha cc1f3b8a38645726c6ec1d9c6c843f0a200adcf0

Add support for AVIF to `next/image` (#29683) Add support for AVIF to `next/image` - Fixes #27882 - Closes #27432 ## Feature - [x] Implements an existing feature request - [x] Related issues linked - [x] Integration tests added - [x] Documentation added - [x] Update manifest output - [x] Warn when `sharp` is outdated - [x] Errors & Warnings have helpful link attached - [ ] Remove `image-size` in favor of `squoosh`/`sharp` (optional, need to benchmark)

view details

Kara Erickson

commit sha 58f3dceec6a222f4426c3b43145ed73c88294899

Refactor Document <Head> to prep for classic streaming This refactor is the first of a few changes to support "classic" (two-part) streaming. This one should be a noop that doesn't actually change the behavior. It simply re-organizes the way that functions are wrapped in Document Head so anything that will be part of the second flush can be separated out from the first flush. The next PRs will actually implement streaming. For more details on the full design, see https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 12 days

push eventkara/next.js

Kara Erickson

commit sha abbd285a4be8aec9a8731a981a3e77400d44d47d

Refactor Document <Head> to prep for classic streaming This refactor is the first of a few changes to support "classic" (two-part) streaming. This one should be a noop that doesn't actually change the behavior. It simply re-organizes the way that functions are wrapped in Document Head so anything that will be part of the second flush can be separated out from the first flush. The next PRs will actually implement streaming. For more details on the full design, see https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 12 days

PR opened vercel/next.js

Refactor Document to use useMaybeDeferContent hook (non-streaming case)

This refactor is the first of a few changes to support "classic" (two-part) streaming. This one should be a noop that doesn't actually change the behavior. It simply re-organizes the way that functions are wrapped in Document Head so anything that will be part of the second flush can be separated out from the first flush. It also adds a placeholder useMaybeDeferContent hook that only supports the non-streaming (isDeferred:false) case for now. The next PR will actually add logic to the hook that will support two-part streaming.

For more details on the full design, see https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

+70 -20

0 comment

4 changed files

pr created time in 12 days

push eventkara/next.js

Kara Erickson

commit sha 4e95f89cd305af4281610abec7d015ac7b94d3ee

Refactor Document to use useMaybeDeferContent hook (non-streaming case) This refactor is the first of a few changes to support "classic" (two-part) streaming. This one should be a noop that doesn't actually change the behavior. It simply re-organizes the way that functions are wrapped in Document Head so anything that will be part of the second flush can be separated out from the first flush. It also adds a placeholder `useMaybeDeferContent` hook that only supports the non-streaming (isDeferred:false) case for now. The next PR will actually add logic to the hook that will support two-part streaming. For more details on the full design, see https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview#

view details

push time in 12 days

push eventkara/next.js

Kara Erickson

commit sha e97c9b7b62a702bf3d37765b4022dbd12fe19a22

Refactor Document to use useMaybeDeferContent hook (non-streaming case) This refactor is the first of a few changes to support "classic" (two-part) streaming. This one should be a noop that doesn't actually change the behavior. It simply re-organizes the way that functions are wrapped in Document Head so anything that will be part of the second flush can be separated out from the first flush. It also adds a placeholder `useMaybeDeferContent` hook that only supports the non-streaming (isDeferred:false) case for now. The next PR will actually add logic to the hook that will support two-part streaming. For more details on the full design, see https://docs.google.com/document/d/1O60XZxvkwx4ch8D7pi67K3RLN8OtbBEbYS8qyS0PQ2w/preview# # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Date: Mon Oct 11 16:37:07 2021 -0700 # # On branch classic # Changes to be committed: # modified: packages/next/pages/_document.tsx # modified: packages/next/server/render.tsx # new file: packages/next/server/use-maybe-defer-content.ts # modified: packages/next/shared/lib/utils.ts #

view details

push time in 12 days

push eventkara/next.js

Kara Erickson

commit sha 9e6e28176bcfdf52d95c6878d394ef0932688958

support non-streaming case with hooks

view details

push time in 12 days

create barnchkara/next.js

branch : classic

created branch time in 12 days

push eventkara/next.js

Scotty Waggoner

commit sha 04cc37f763e36fc4458105d37215f79f7c9b108d

Add docs for using pageExtensions to colocate other files with page components (#22740) Feel free to edit this/suggest changes as you see fit to match the style of your docs or how you want this feature represented. There seemed to be many issues regarding colocating non-page files with page components in the `pages` directory where `pageExtensions` was finally suggested as a solution. I think it would be great to document it better since it seems to be a often requested workflow to colocate test, generated files, styles, and other files needed by page components in the `pages` directory. The note that exists in the docs currently alludes to the ability to do this but it doesn't contain much context that would help make it more discoverable. Relevant issues: https://github.com/vercel/next.js/discussions/11113#discussioncomment-427139 https://github.com/vercel/next.js/issues/8454#issuecomment-560432659 https://github.com/vercel/next.js/issues/8617#issuecomment-790030032 https://github.com/vercel/next.js/issues/3728#issuecomment-523789071

view details

Mike Hedman

commit sha d209435724891fd20222cd268d95bf0f304ffaa4

Small grammar fixes (#28590) "exclusive of" implies that it doesn't pertain to `export` https://www.merriam-webster.com/dictionary/exclusive%20of "Exclusive to" implies that it's only relevant to `export`. Also changed "can not" to "cannot". ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes

view details

Anderson Leite

commit sha 8711c5ca53b468d4a270bb4d627a3c813565b8b3

Tests: Remove unnecessary await (#28594) 'await' has no effect on the type of this expression.ts(80007) ## Bug - [X] Integration tests clean up ## Documentation / Examples - [x] Make sure the linting passes

view details

Steven

commit sha 7afc97c5744b38bdf36aa7f87625f438224688aa

Add CSP to Image Optimization API (#28620) Add CSP header to Image Optimization API

view details

Steven

commit sha a60690f59b211777cb49abd4c5ecc4656464d0e9

v11.1.1-canary.18

view details

Knut Melvær

commit sha 36d922fbdadcc357824d20169754e5bb4b950725

Add apiVersion to config (#28610) The client now warns against missing `apiVersion` ([docs](https://www.sanity.io/docs/api-versioning)). This PR adds the config for using the latest API version. There shouldn't be breaking changes in this app. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes

view details

jj@jjsweb.site

commit sha 194d70f068288e3f08273694370910c0d8b2548b

v11.1.1-canary.19

view details

Steven

commit sha 804971fd9a49dfd009f7339dd8bf4bc32e6eb02c

v11.1.1

view details

Jiachi Liu

commit sha 8c553e8dc0441932dbf1d798500102a408a792dc

chore: upgrade styled-jsx to 4.0.1 (#28626) Fix warning of peer dep on yarn (berry version) install

view details

Kara

commit sha 9be387c7f476fb0a0fed3bf04162ab22e0a0074a

getServerSideProps should support props value as Promise (#28607) Previous to this change, getServerSideProps could only return plain objects for props, e.g.: ```javascript export async function getServerSideProps() { return { props: { text: 'some value', } } } ``` With this commit, the props object can also be a Promise, e.g. ```javascript export async function getServerSideProps() { return { props: (async function () { return { text: 'promise value', } })(), } } ``` For now, the framework simply waits for the results of the props Promise to resolve, but this small change sets the groundwork for later allowing props to be streamed (cc @devknoll). ## Feature - [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. -- *This is part of @devknoll's ongoing work to support streaming.* - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. *not sure if this applies here* - [ ] Errors have helpful link attached, see `contributing.md`

view details

JJ Kasper

commit sha ff9dcc6a47aee81cb6f6dca4647e2c81273b885a

Ensure custom app regex is correct for Windows (#28631) * Ensure custom app regex is correct for Windows * lint-fix * update test for ie * update test * lint-fix

view details

jj@jjsweb.site

commit sha 248b34105b538f935beb33e725125540806f32ea

v11.1.2-canary.0

view details

Tim Neutkens

commit sha 97456e81ce9860ce8b4bb58931b8d723d312d389

v11.1.2

view details

matamatanot

commit sha 71771df6fa7e4a37bc6b60673c882c6625ee1d57

Add error page path for next-script-for-ga (#28643) ## Documentation / Examples - [x] Make sure the linting passes **My console** > src/pages/_document.tsx#L14 > Use the `next/script` component for loading third party scripts. See: https://nextjs.org/docs/messages/next-script-for-ga https://nextjs.org/docs/messages/next-script-for-ga is 404 now.

view details

Tobias Koppers

commit sha f6d8a112df76197362b407fc1e0fb6f323dccf39

fix esm externals edge case with "module" condition (#28612) prefer commonjs externals even if "module" condition is used in package.json ## Bug - [ ] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md`

view details

Steven

commit sha acf65f92dc7ce459a25ac5a9bc668300e8cff28b

Fix TS type conflict for `<img>` tag (#28672) This type was added in PR #28269 but doesn't need to be public and was causing conflicts with `@types/react@17`. We currently use `@types/react@16` so ideally we should upgrade to `@types/react@17` and then remove the `ts-ignore`. Fixes #28647

view details

Rahul Gaba

commit sha c21cbdf8997db636100f578cd70f838f8b95b407

Fix for `next-script-for-ga` ESLint rule crashing when a method is used in dangerouslySetInnerHTML (#28675) Fixes #28635 ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [x] Errors have helpful link attached, see `contributing.md`

view details

jj@jjsweb.site

commit sha c1a97e557b7fad7a87907a56d10f018401154edc

v11.1.3-canary.0

view details

Aleksa Cukovic

commit sha 501bfe69695b0e563e88af689105882513c2b370

Update docs about exposing env vars to the browser (#28673) Current docs on exposing environment variables to the browser are slightly misleading as they say that variables loaded from `.env.local` are only available in node by default, but this is the case for all environment variables not just those loaded from `.env.local`. ## Documentation - [x] Make sure the linting passes

view details

Eungyeol

commit sha c1dbc1260922276f62d010e7bccc3ec2c3ccf627

Do not have the required package error fix (#28662) The following error occurred when I created a project with the typecript template of createp-next-app and did the 'next build'. ```shell It looks like you're trying to use TypeScript but do not have the required package(s) installed. Please install @types/node by running: yarn add --dev @types/node If you are not trying to use TypeScript, please remove the tsconfig.json file from your package root (and any TypeScript files in your pages directory). ``` This issue was resolved by adding @types/node. So I added @types/node to the devDependencies of the create-next-app typecript template.

view details

push time in 12 days

issue openedvercel/next.js

<Image> components in <p> tags act oddly

What version of Next.js are you using?

11.x

What version of Node.js are you using?

14.15.0

What browser are you using?

Chrome

What operating system are you using?

macOS

How are you deploying your application?

n/a

Describe the Bug

Because <Image> uses a <div> wrapper under the hood, adding an <Image> tag within a <p> tag results in a <div> inside a <p> (which is considered a semantic malformation in HTML). In attempting to handle the malformation, the browser starts with the <div> outside the <p>, then eventually appends it correctly. This churn causes CLS as a line break is briefly visible.

Expected Behavior

There shouldn't be a line break. One potential fix is to replace the wrapper <div> with a <span>, which would be semantically valid. This would be a breaking change.

To Reproduce

See repro here: https://github.com/goncy/nextjs-image-bug-repro

created time in 16 days

issue openedvercel/next.js

Add explanation for why to use each next/image layout

Describe the feature you'd like to request

We recently got feedback from a partner that it's not clear how to select the "right" layout mode for your next/image instance. In other words, the current docs explain what each layout mode does, but not why each layout mode might be right for your app.

Describe the solution you'd like

Examples of canonical use cases for each layout mode might be helpful. Also might be good to have a short, more general discussion about how to decide.

Describe alternatives you've considered

There could also be a dedicated guide for layout modes, but I think the core problem could be solved with a paragraph and a few examples.

created time in 19 days

issue openedvercel/next.js

Explain "priority" attribute in "Image Optimization" guide

Describe the feature you'd like to request

We recently got feedback from a partner that it wasn't clear that LCP images needed to use the "priority" attribute of next/image. This requirement is buried in the API ref and not easy for first-time users of next/image to find.

Describe the solution you'd like

We should add a more obvious section to the "Image optimization" guide about how to treat LCP images, with an example that uses the "priority" attribute (with a caveat that it should be used sparingly).

Describe alternatives you've considered

We could also just add the "priority" attribute to one of the first examples, but we should also explain when it's appropriate to use it (so folks don't add it where it's not needed)

created time in 19 days

Pull request review commentvercel/next.js

[DRAFT] Overhaul image component documentation

 const MyImage = (props) => {  ### sizes -A string mapping media queries to device sizes. Defaults to `100vw`.+A string that provides information about how wide the image will be at different breakpoints. Defaults to `100vw` (the full width of the screen) when using `layout="responsive"` or `layout="fill"`.++`sizes` is important for performance when using `layout="responsive"` or `layout="fill"` with images that take up less than the full viewport width. -We recommend setting `sizes` when using `layout="responsive"` or `layout="fill"` and your image will **not** be the same width as the viewport.+If you are using `layout="fill"` and the image will always be less than half the viewport width, include `sizes="50vw"`. Without `sizes`, the image will be sent at twice the necessary resolution, decreasing performance.

Per offline discussion, add layout responsive here too

atcastle

comment created time in a month

PullRequestReviewEvent