profile
viewpoint
Hugo Tunius k0nserv @Skyscanner Edinburgh, Scotland http://hugotunius.se I write code in many languages. Interested in low level performance, UX/UI, API design, testing, ray tracing, @danger, @CocoaPods, Swift, Rust, and more

k0nserv/chip-8 5

A CHIP-8 Emulator in Rust

k0nserv/CLBrot 2

Mandlebrot generator using OpenCL. Old project circa 2012

k0nserv/activerecord_enum 1

Adds ENUM and SET support to ActiveRecord

k0nserv/advent-of-code-2017 1

Advent of Code 2017 solutions. http://adventofcode.com/

pull request commentCocoaPods/shared

Update shared Rubocop file

@segiddins Please review.

jasl

comment created time in 18 hours

PR opened CocoaPods/shared

Update shared Rubocop file

This updated Rubocop file designed for latest Rubocop (1.8 at time)

Notable change:

  • Performance linting rules extract to a standalone gem
  • Cops' namespace update
  • AllCops/Include is a whitelist in newer version, so must add lib/**/*.rb
  • Looks like ./ has problem, remove them, this should no harm
+32 -30

0 comment

1 changed file

pr created time in 18 hours

startedashtom/hkimport

started time in 20 hours

created repositorytvooo/orchard

A personal wiki, outliner, and task manager

created time in 20 hours

push eventSkyscanner/backpack

Ollie Curtis

commit sha 34b350fec039cf1c2c5273db1cf6656b3c977984

Update changelog

view details

push time in 20 hours

created tagSkyscanner/backpack

tagbpk-component-datatable@2.2.0

Backpack Design System

created time in 20 hours

push eventSkyscanner/backpack

Ollie Curtis

commit sha b01fcbc506709c8115fec8358cab1993df40a590

Publish - bpk-component-datatable@2.2.0

view details

push time in 20 hours

push eventbackpack/storybook

k0nserv

commit sha 407ba4e3b161bd02eb8224a538dedd1d5cf865ef

deploy: Skyscanner/backpack@47c5e42489c1747d054dd5601346cd8b39e64b1d

view details

push time in 20 hours

startedGiancarloCode/form_bloc

started time in 21 hours

pull request commentSkyscanner/backpack

[NEON-167] DataTable rowClassName can be a function

Visit https://backpack.github.io/storybook-prs/2068 to see this build running in a browser.

jorgedc93

comment created time in 21 hours

push eventbackpack/storybook-prs

jorgedc93

commit sha 63c91853361e5101cd4c01fbcc022be486b1cdfe

deploy: Skyscanner/backpack@c9f1759224a08f7ab9a12dd963278677130a7e04

view details

push time in 21 hours

PR closed Skyscanner/backpack

NEON-167 DataTable rowClassName can be a function

While working on a feature to dynamically change the background of a row depending on a value, I noticed that BpkDataTable did not allow to pass a function for rowClassName while the original react-virtualized Table does.

This PR extends the component to allow passing a function as in Table

Remember to include the following changes:

  • [x] UNRELEASED.md
  • [ ] README.md
  • [ ] Tests
  • [ ] Docs (either update backpack-docs now, or create a follow up ticket)
+275 -4

0 comment

4 changed files

jorgedc93

pr closed time in 21 hours

PR opened Skyscanner/backpack

[NEON-167] DataTable rowClassName can be a function

While working on a feature to dynamically change the background of a row depending on a value, I noticed that BpkDataTable did not allow to pass a function for rowClassName while the original react-virtualized Table does.

This PR extends the component to allow passing a function as in Table

Remember to include the following changes:

  • [x] UNRELEASED.md
  • [ ] README.md
  • [ ] Tests
  • [ ] Docs (either update backpack-docs now, or create a follow up ticket)
+275 -4

0 comment

4 changed files

pr created time in 21 hours

create barnchSkyscanner/backpack

branch : NEON-167_rowClassName_can_get_function

created branch time in 21 hours

PR opened Skyscanner/backpack

NEON-167 DataTable rowClassName can be a function

While working on a feature to dynamically change the background of a row depending on a value, I noticed that BpkDataTable did not allow to pass a function for rowClassName while the original react-virtualized Table does.

This PR extends the component to allow passing a function as in Table

Remember to include the following changes:

  • [ ] UNRELEASED.md
  • [ ] README.md
  • [ ] Tests
  • [ ] Docs (either update backpack-docs now, or create a follow up ticket)
+275 -4

0 comment

4 changed files

pr created time in a day

push eventbackpack/ios-prs

paulomendes

commit sha 71a83d9dd36d56d840850f81da0301ccf7919808

deploy: Skyscanner/backpack-ios@5e09bd9feb6879837e97267d533d8666f3518077

view details

push time in a day

startedzino-app/graphql-flutter

started time in a day

PR closed Skyscanner/backpack-ios

Reviewers
Add customisation capability to BPKBottomSheet

Add Persistent and Modal Presentation Style

This PR has the objective to introduce a new style of presentation to BottomSheet. Now we are capable to present it modally or persistently.

Persistent Bottom Sheet

It can be initialized by using

let bottomSheet = BPKBottomSheet(contentViewController: viewController, 
 scrollViewToTrack: viewController.tableView, 
 bottomSectionViewController: nil, 
 presentationStyle: .persistent)

To use the .persistent presentation style we need to ensure to use the method addPanel instead of present.

This will allow the following behavior.

ezgif-6-7f75e33ed95b

What is New

  • New parameter in the initialization called presentationStyle which is an enum
public enum PresentationStyle {
        case modal
        case persistent
    }
  • New layout definition: ModalBottomSheetLayout and PersistentBottomSheetLayout
  • New addPanel(toParent parent: UIViewController) method, that will add a BottomSheet and make it persistent and allow you to interact with the parent view controller
  • New removePanel(animated: Bool) in case you added a BottomSheet persistently but needs to hide it for some loading interaction or something else.
  • New public func move(to position: BPKFloatingPanelPosition) that will allow you to programmatically change the position of the BottomSheet.

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

+921 -73

6 comments

12 changed files

paulomendes

pr closed time in a day

PR opened Skyscanner/backpack-ios

Add customisation capability to BPKBottomSheet

Add Persistent and Modal Presentation Style

This PR has the objective to introduce a new style of presentation to BottomSheet. Now we are capable to present it modally or persistently.

Persistent Bottom Sheet

It can be initialized by using

let bottomSheet = BPKBottomSheet(contentViewController: viewController, 
 scrollViewToTrack: viewController.tableView, 
 bottomSectionViewController: nil, 
 presentationStyle: .persistent)

To use the .persistent presentation style we need to ensure to use the method addPanel instead of present.

This will allow the following behavior.

ezgif-6-7f75e33ed95b

What is New

  • New parameter in the initialization called presentationStyle which is an enum
public enum PresentationStyle {
        case modal
        case persistent
    }
  • New layout definition: ModalBottomSheetLayout and PersistentBottomSheetLayout
  • New addPanel(toParent parent: UIViewController) method, that will add a BottomSheet and make it persistent and allow you to interact with the parent view controller
  • New removePanel(animated: Bool) in case you added a BottomSheet persistently but needs to hide it for some loading interaction or something else.
  • New public func move(to position: BPKFloatingPanelPosition) that will allow you to programmatically change the position of the BottomSheet.

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

+921 -73

0 comment

12 changed files

pr created time in a day

pull request commentSkyscanner/backpack-docs

[BPK-4339]: Cleanup files

Visit https://backpack.github.io/prs/883 to see this build running in a browser.

olliecurtis

comment created time in a day

push eventbackpack/prs

olliecurtis

commit sha 8314521204d27b6574403444262e16b3e503b511

deploy: Skyscanner/backpack-docs@76ab26a4b75b527fc76b0a41f243dbd732d116d8

view details

push time in a day

PR opened Skyscanner/backpack-docs

[BPK-4339]: Cleanup files

<!-- Thanks for contributing to Backpack :pray: Please include a description of the changes you are introducing and some screenshots if appropriate. -->

Changes:

  • Deleted large amounts of unused files since the migration to mdx format docs
  • Removed Accessibility pages as they were still in WIP (with no content) and not officially released, and are planned to be redesigned and worked into new mdx format
    • Which lead to more pages being able to be removed
  • Fixed a flex issue that was being thrown by webpack on build.
  • Removed old assets which should shrink project size also

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

+6 -2780

0 comment

72 changed files

pr created time in a day

create barnchSkyscanner/backpack-docs

branch : BPK-4339-old-files-cleanup

created branch time in a day

startedgonsolo/gonzales

started time in a day

startedLeonardoCardoso/SwiftLinkPreview

started time in a day

fork iammiles/one-cent-blog

The template for a one cent/month blog using S3, Cloudflare, Jekyll and Travis-Ci

fork in a day

pull request commentSkyscanner/backpack-docs

Update Bpk

Visit https://backpack.github.io/prs/882 to see this build running in a browser.

olliecurtis

comment created time in 2 days

push eventbackpack/prs

olliecurtis

commit sha 749e9a42a56f912ada15bffaeb936d1d0a5acfa7

deploy: Skyscanner/backpack-docs@5176c630af98939fa45c3a9acca1cca8fc46d910

view details

push time in 2 days

pull request commentSkyscanner/backpack-docs

Update Bpk

<!-- 0 failure: 1 warning: `package-lock.jso...

DangerID: danger-id-Danger; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Warnings</th> </tr> </thead> <tbody><tr> <td>:warning:</td> <td>

package-lock.json was updated. Ensure that this was intentional. </td> </tr> </tbody> </table>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 95fd7ccbcbab4d81a339aff4f73a3f978a1d8025 </p>

olliecurtis

comment created time in 2 days

more