profile
viewpoint
Janne Valkealahti jvalkeal Pivotal London, UK Working for Pivotal and contributing to various Spring projects from left to right.

Haybu/demo-spring-distributed-transaction 7

demo of a distributed transaction using spring stream and a saga pattern with a spring state machine

jvalkeal/hqu-adminhelper 6

Hyperic HQU plugin to help modifying alert definitions.

jvalkeal/hypclipse-plugin 3

Eclipse plugin for custom HQ plugin development.

jvalkeal/hqu-wallmount 2

Hyperic HQU plugin to create different view to availability data

jvalkeal/pi-wip 2

Research projects for iot

jvalkeal/randomstuff 2

Just some stuff I share outside of other repos

jvalkeal/hq-sunglassfish 1

Hyperic HQ plugin for Sun Glassfish enterprise server.

jvalkeal/antlr4-c3 0

A grammar agnostic code completion engine for ANTLR4 based parsers

jvalkeal/app-starters-release 0

Spring Cloud Stream App Starters and its Release Train

push eventjvalkeal/spring-cloud-deployer-cloudfoundry

Janne Valkealahti

commit sha b65ae77ea7562c8eb91c92b560597d6729819733

Move away from CF utils for retry - Trouble with DelayUtils.exponentialBackOffError utility was that is don't propagate errors back to caller which essentially meant that whole part of this stream got cancelled and no default error responses were created, which then cause other issues. - Now moving to use reactor's own retry utils and we essentially retry anything else than exceptions having `org.cloudfoundry.client` in a class name which means it's probably real error not worth to retry. - I've seen exceptions like java.nio.channels.NotYetConnectedException which is weird but worth to retry.

view details

push time in 19 hours

push eventjvalkeal/spring-cloud-skipper

Janne Valkealahti

commit sha 0abefc4373f37c1974e190638854bd1208fd3112

Polish

view details

push time in a day

push eventjvalkeal/spring-cloud-skipper

Janne Valkealahti

commit sha 015bc967d159e7e16f0ca904460ad55f82b80763

Polish

view details

push time in a day

push eventjvalkeal/spring-cloud-skipper

Janne Valkealahti

commit sha 01e38a966b4ada21db508506e7ea63acad7b34cf

Polish

view details

push time in a day

create barnchjvalkeal/spring-cloud-skipper

branch : gh940-xxx

created branch time in 2 days

PR opened spring-cloud/spring-cloud-dataflow

Use reactive methods to get stream statuses
  • StreamDeployer has a new method to ask multiple statuses at a same time which allows use to make only one call to skipper.
  • /runtime/streams has been changed to use new method in a StreamDeployer to use only one request.
  • SkipperStreamDeployer uses new method from SkipperClient to request all streams at a same time.
  • Fixes #3800
+125 -67

0 comment

5 changed files

pr created time in 4 days

create barnchjvalkeal/spring-cloud-dataflow

branch : gh3800

created branch time in 4 days

PR closed spring-cloud/spring-cloud-dataflow

Use reactive methods to get stream statuses
  • StreamDeployer has a new method to ask multiple statuses at a same time which allows use to make only one call to skipper.
  • /runtime/streams has been changed to use new method in a StreamDeployer to use only one request.
  • SkipperStreamDeployer uses new method from SkipperClient to request all streams at a same time.
  • Fixes #3799
+125 -67

1 comment

5 changed files

jvalkeal

pr closed time in 4 days

pull request commentspring-cloud/spring-cloud-dataflow

Use reactive methods to get stream statuses

closing to create against correct issue.

jvalkeal

comment created time in 4 days

PR opened spring-cloud/spring-cloud-dataflow

Use reactive methods to get stream statuses
  • StreamDeployer has a new method to ask multiple statuses at a same time which allows use to make only one call to skipper.
  • /runtime/streams has been changed to use new method in a StreamDeployer to use only one request.
  • SkipperStreamDeployer uses new method from SkipperClient to request all streams at a same time.
  • Fixes #3799
+125 -67

0 comment

5 changed files

pr created time in 4 days

PR opened spring-cloud/spring-cloud-skipper

Add new api to request multiple stream statuses
  • ReleaseController now has a new method /statuses which returns a map of statuses wrapped in a mono and subscription is then handled by framework itself.
  • ReleaseManager has a new method to request status reactively with a Release.
  • SkipperClient has a new statuses method for dataflow to request info for multiple releases at a same time.
  • DefaultReleaseManager now tries to use reactive methods for statuses and doesn't a bit of caching so that we don't ddos our own server.
  • ReleaseStatUpdateService now also uses reactive methods so that update is faster by not doing things sequentially. There's also a little fix to do update immediately when server starts(via initial polling flag).
  • Fixes #940
+283 -42

0 comment

9 changed files

pr created time in 4 days

PR opened spring-cloud/spring-cloud-deployer-cloudfoundry

Add reactive status methods
  • Implement reactive status methods and use Caffeine cache for statuses.
  • Differentiate between timeout and api exception
  • Fixes #339
+61 -4

0 comment

3 changed files

pr created time in 4 days

PR opened spring-cloud/spring-cloud-deployer

Add reactive status methods
  • New methods statusReactive where we can pass in multiple id's getting status back with one request.
  • Fixes #336
+42 -2

0 comment

3 changed files

pr created time in 4 days

create barnchjvalkeal/spring-cloud-dataflow

branch : gh3799

created branch time in 4 days

push eventjvalkeal/spring-cloud-skipper

Janne Valkealahti

commit sha 7adadd1e4771816881c8da7ce0a15ddaf494d481

Add new api to request multiple stream statuses - ReleaseController now has a new method /statuses which returns a map of statuses wrapped in a mono and subscription is then handled by framework itself. - ReleaseManager has a new method to request status reactively with a Release. - SkipperClient has a new statuses method for dataflow to request info for multiple releases at a same time. - DefaultReleaseManager now tries to use reactive methods for statuses and doesn't a bit of caching so that we don't ddos our own server. - ReleaseStatUpdateService now also uses reactive methods so that update is faster by not doing things sequentially. There's also a little fix to do update immediately when server starts(via initial polling flag). - Fixes #940

view details

push time in 4 days

push eventjvalkeal/spring-cloud-deployer-cloudfoundry

Janne Valkealahti

commit sha 4032003ccddd87a1be307f6240675209590d3d2b

Add reactive status methods - Implement reactive status methods and use Caffeine cache for statuses. - Differentiate between timeout and api exception - Fixes #339

view details

push time in 4 days

push eventjvalkeal/spring-cloud-skipper

Janne Valkealahti

commit sha fcb533836118017d33e1a9c3bab9b402791f05ce

Polish

view details

push time in 4 days

create barnchjvalkeal/spring-cloud-skipper

branch : gh940

created branch time in 4 days

push eventjvalkeal/spring-cloud-deployer-cloudfoundry

Janne Valkealahti

commit sha 4351ad5ccb0dba73d2e171cc1b1bf9afcf54e48c

Differentiate between timeout and api exception - Relates #339

view details

push time in 4 days

create barnchjvalkeal/spring-cloud-deployer-cloudfoundry

branch : gh339

created branch time in 4 days

create barnchjvalkeal/spring-cloud-deployer

branch : gh336

created branch time in 4 days

push eventjvalkeal/spring-cloud-skipper

Janne Valkealahti

commit sha c11ce891ae3be0038341e28e60e803cebbcb680f

stash2

view details

push time in 6 days

push eventjvalkeal/spring-cloud-deployer-cloudfoundry

Janne Valkealahti

commit sha 609824128c83de43e66941e4ef71c507e57fa44b

stash2

view details

push time in 6 days

issue openedspring-cloud/spring-cloud-skipper

Adapt to reactive AppStatus changes

This is a related part for spring-cloud/spring-cloud-deployer#336 to implement reactive api's. Also relates to spring-cloud/spring-cloud-skipper#939 for perf enhancements.

created time in 6 days

issue openedspring-cloud/spring-cloud-deployer-cloudfoundry

Adapt to reactive AppStatus changes

This is a related part for spring-cloud/spring-cloud-deployer#336 to implement reactive api's. Also relates to spring-cloud/spring-cloud-skipper#939 for perf enhancements.

created time in 6 days

issue openedspring-cloud/spring-cloud-dataflow

Adapt to reactive AppStatus changes

This is a related part for spring-cloud/spring-cloud-deployer#336 to implement reactive api's. Also relates to spring-cloud/spring-cloud-skipper#939 for perf enhancements.

created time in 6 days

push eventjvalkeal/spring-cloud-deployer

Janne Valkealahti

commit sha 4b4da6acf234a7734a3a40118e48e9d865a012f0

stash2

view details

push time in 6 days

issue openedspring-cloud/spring-cloud-deployer

Reactive api for AppStatus

Basically reactive part of:

AppStatus status(String id);

For performance reasons we also want to have method accepting multiple id's.

created time in 6 days

issue openedspring-cloud/spring-cloud-dataflow

Support reactive api's for non-blocking communication

This is a long running epic to overhaul various external and internal api's to support non-blocking communication to provide better performance throughout a stack. While we've not really needed to use reactive api's, work started for spring-cloud/spring-cloud-skipper#939 showed that easiest way to provide performance enhancements is to use reactor through calls as cf-java-client itself is based on reactor.

Thus, we need to start adding various new api's for dataflow/skipper/deployers so that we can do same work with less traffic and roundabouts, and not trying to be sequential.

created time in 6 days

push eventjvalkeal/spring-cloud-deployer-kubernetes

David Turanski

commit sha d49cd80d7f77b3697e3158e4f505952345b387c0

Add filtering to createCommandArgs Rebased and polishing

view details

Janne Valkealahti

commit sha 509ee0dc9a7114e07390112d3cb4cc00ec5d6cc0

Use deployer spi 2.2.0.M1

view details

Janne Valkealahti

commit sha c4e6255da53168b20cb56153c9709743022310c1

Use deployer spi snapshots

view details

Janne Valkealahti

commit sha 701defc045db6d7242057b12c96f51e3d3341dcb

Upgrade spring-cloud-deployer 2.2.0.RC1

view details

Janne Valkealahti

commit sha c4bb4190027d53c4e5cfa6cd9a38aa58e87b8858

Upgrade spring-cloud-deployer 2.2.0.RELEASE

view details

Spring Buildmaster

commit sha e241349f98773fda038c94fea02d8dc11dd5c321

Next development version 2.2.1.BUILD-SNAPSHOT

view details

Janne Valkealahti

commit sha 700b9b6be31c0231ea231a004cb933a5313384f2

Align used deployer property name

view details

Janne Valkealahti

commit sha 8c0001aa1f9e2090cd5d4d841a626d43a81819d5

Add maven maintenance scripts

view details

Janne Valkealahti

commit sha cef36976ef203b880fa2a5a62b363cdd4405430f

Move to next minor development version

view details

Janne Valkealahti

commit sha 63dcf924b0f34f50d907f61051f107dcfa8aaa92

Add workflow for master and pr's

view details

Ilayaperumal Gopinathan

commit sha 62a90e57103bfe019b0ec468b848c9f8d15aa2f3

Convert cmdline args as environment props in Shell entrypoint - When the docker entrypoint style is set to `shell`, the commandline arguments are ignored. To fix this issue, convert all the commandline arguments and set as environment properties. When applying the commandline arguments, we also need to make sure the commandline arguments override the existing app properties. This will also make sure some of the platform specific properties to be passed in as environment properties. - Add tests Resolves #365

view details

push time in 6 days

push eventjvalkeal/spring-cloud-deployer-local

Janne Valkealahti

commit sha c36bec65c518952f86fe27128d1624f61227f288

Use deployer spi 2.2.0.M1

view details

Janne Valkealahti

commit sha ce4bb6fd01d3ef0c3b5ef00cde3c2f22bd8379e7

Use deployer spi 2.2.0.M1 fix

view details

Janne Valkealahti

commit sha 05efbe41a48d6327d0f172dbba8c7addc812d645

Use deployer spi snapshots

view details

Janne Valkealahti

commit sha fcd2bad307f959757f59f24a3743053a9c254b92

Upgrade spring-cloud-deployer 2.2.0.RC1

view details

Janne Valkealahti

commit sha e258113ca2549dd3fed50f6e13d705c94b67fb52

Upgrade spring-cloud-deployer 2.2.0.RELEASE

view details

Spring Buildmaster

commit sha 955d3bd57784ae93d90bdd4583820a1032c0e345

Next development version 2.2.1.BUILD-SNAPSHOT

view details

Janne Valkealahti

commit sha 0e55e79f96e32feb6784723c70dace792128ce4c

Add maven maintenance scripts

view details

Janne Valkealahti

commit sha 467da2c9d161049f9ad5f2196d51f728fe1e81b8

Move to next minor development version

view details

push time in 6 days

create barnchjvalkeal/spring-cloud-dataflow

branch : xxx-cf-1

created branch time in 7 days

create barnchjvalkeal/spring-cloud-skipper

branch : xxx-cf-1

created branch time in 7 days

create barnchjvalkeal/spring-cloud-deployer-cloudfoundry

branch : xxx-cf-1

created branch time in 7 days

create barnchjvalkeal/spring-cloud-deployer

branch : xxx-cf-1

created branch time in 7 days

push eventjvalkeal/spring-cloud-deployer

Janne Valkealahti

commit sha 28319faee21219a6d2a24897367e53b3facd1a9c

Add https role to HttpWagon - Original wagon commit missed a point that roleHint given to resolver is not http for https so need to register that as well. - Relates #331

view details

Janne Valkealahti

commit sha 4a0783a648a55f02aff8aedddc53fd6d07e2c4a6

Use our own dependencies parent - Switch to spring-cloud-dataflow-dependencies-parent from spring-cloud-dependencies-parent to align corrent build concept.

view details

Janne Valkealahti

commit sha db0b1d8d9671de73f52561254531ba64204f8983

Use dataflow build 2.4.0.M1

view details

Janne Valkealahti

commit sha 1b416fb538ec6c2ccd9acd6b4aa8e45ae74af47b

Use dataflow build 2.4.0 snapshots

view details

Janne Valkealahti

commit sha f561ff701f2f1a43dff5d708d2face8a3dae0b71

Upgrade to spring-cloud-dataflow-build 2.4.0.RC1

view details

Janne Valkealahti

commit sha 903f578d2ab95d5980407bb8e001a15a51346f62

Upgrade to spring-cloud-dataflow-build 2.4.0.RELEASE

view details

Spring Buildmaster

commit sha d06005641ada72e9faf5393963c54f507cb1df15

Next development version 2.2.1.BUILD-SNAPSHOT

view details

Janne Valkealahti

commit sha da07f5c9221031f3a187d0d583e9780ced5bfd07

Add maven maintenance scripts

view details

Janne Valkealahti

commit sha 8b2746f21158308e4207b66806363ed37a058fb4

Move to next minor development version

view details

Janne Valkealahti

commit sha 739b6919878807b6d7137d2176c988068c32acd4

Add workflow for master and pr's

view details

push time in 7 days

create barnchjvalkeal/spring-cloud-dataflow

branch : gh3796-work1

created branch time in 8 days

create barnchjvalkeal/spring-cloud-skipper

branch : gh907-work2

created branch time in 8 days

create barnchjvalkeal/spring-cloud-dataflow-common

branch : gh3-work1

created branch time in 8 days

issue openedspring-cloud/spring-cloud-dataflow

Upgrade to flyway 6.x

created time in 9 days

push eventjvalkeal/spring-cloud-dataflow-common

Janne Valkealahti

commit sha 0dd919713a38cc051daae02f8a8437cefdcf9d9c

Add dependencies bom - Fixes #1

view details

Janne Valkealahti

commit sha 44cc9bf5eb71cad44ce20e21bdee8bf8db5b35bb

Fix correct versions in bom - Relates #1

view details

Janne Valkealahti

commit sha 9b01507a617901f69c9d4d43a754b48125c5d51e

Fix correct naming in bom - Relates #1

view details

Janne Valkealahti

commit sha 272f0b9e9be8276e90bd8a556c069bae46c1f1ae

Rename unit test classes - Postfix all needed unit tests with `Tests` so that build config will actually run those.

view details

Janne Valkealahti

commit sha 115493bbd5c5d84aad93a4c45ff03694527ac278

Support resolving docker compose files from classpath - Adding relatively naive way to resolve docker compose files with classpath: prefix. - Fixes #2

view details

Janne Valkealahti

commit sha 5d1b74ebd4397c5470892361346e407ed07e71f1

Change version from 1.0.0 to 2.4.0 to align dataflow

view details

Janne Valkealahti

commit sha e5ae01eb97241c2a01aa4e12ad1d7686d47ac464

Rename commons to common

view details

Janne Valkealahti

commit sha f1f8ea5bc714998d10462bf3f7e9881acc57179c

Use dataflow build 2.4.0.M1

view details

Janne Valkealahti

commit sha 2ad4c67ee536bf75309ce104ab502555aa82ff37

Use dataflow build 2.4.0 snapshots

view details

Janne Valkealahti

commit sha f540158e61f0224f325be0da2d968c5fcbe60a5f

Upgrade to spring-cloud-dataflow-build 2.4.0.RC1

view details

Janne Valkealahti

commit sha 6bd1766b98fb8d05a2ae181b23496242a2946c98

Upgrade to spring-cloud-dataflow-build 2.4.0.RELEASE

view details

Spring Buildmaster

commit sha cbe09b4bd2c19a82244c2b46b7641c5ec5cb0261

Next development version 2.4.1.BUILD-SNAPSHOT

view details

Janne Valkealahti

commit sha 99d9fc7e2aae275114df7276ee3a91e89deb9edc

Add maven maintenance scripts

view details

Janne Valkealahti

commit sha 468710040782d9c0122303034e7a92b851ad0325

Move to next minor development version

view details

Janne Valkealahti

commit sha 375586432e066185080c2ddb14170b98b8aa43ac

Add workflow for master and pr's

view details

push time in 9 days

issue openedspring-cloud/spring-cloud-dataflow-common

Extract common flyway code

Dataflow and Skipper contain a lot of copy/pasted code for flyway feature which should be in a shared place.

created time in 9 days

push eventjvalkeal/spring-cloud-skipper

Janne Valkealahti

commit sha 42af60a10b365934f47e7e9c1512327863e0906a

Remove explicit spring-cloud-dependencies dependency - Now favour dependency handling coming from parent build. - Essentially upgrades to Hoxton SR1

view details

Janne Valkealahti

commit sha f1ffcbf87e0a67d7a4f6bb47b4573099c0f79f15

Upgrade to statemachine 2.2.0

view details

Janne Valkealahti

commit sha 8eee2a2fe9fb4649cc9c93febd0a1445909cc7db

Add workflow for master and pr's - This basically runs a normal maven build on linux for every push to master or PR's related to master.

view details

Janne Valkealahti

commit sha ada7377f6af9a112b4a4db365cddc6cfc91457d9

Upgrade spring-cloud-dataflow-build 2.4.0.RC1, spring-cloud-deployer 2.2.0.RC1

view details

Ilayaperumal Gopinathan

commit sha 4b910c4d12f325d690494e32b1b66f1d9a9cd445

Update snapshot dependencies

view details

Ilayaperumal Gopinathan

commit sha 87cb392f75da55f908fc0f390acb221f5d93e86c

Fix navbar link in Skipper documentation Resolves #936

view details

Ilayaperumal Gopinathan

commit sha adbb89c798925608f4f7246a417f45c8fc5718f5

Update dataflow-build/deployer release versions

view details

Ilayaperumal Gopinathan

commit sha b55b5ad08d2db6046563fc7aff1ca42d784aa426

Update dataflow dependencies parent to use 2.4.0.RELEASE

view details

Spring Buildmaster

commit sha f1ccd83268443de2866f6411dbae10b619df446a

[artifactory-release] Next development version 2.3.1.BUILD-SNAPSHOT

view details

Janne Valkealahti

commit sha 66c869b0eca5d15963840b84975ba4553a98ca70

Move dependency management to parent

view details

Janne Valkealahti

commit sha b5c8586c04254158eaeb5309610cd3ea74a7425d

Add maven maintenance scripts

view details

Janne Valkealahti

commit sha 65523ae73d16dff824e796cc417e9eea85fcef3b

Move to next minor development version

view details

Janne Valkealahti

commit sha 54ba97c3ef97ead056e290279f96e7c7bde6fd06

Use checkstyle config from parent build - Also fix bunch of static import usage cases locally in favour of defining those in a common build config.

view details

push time in 9 days

push eventjvalkeal/spring-cloud-dataflow

Christian Tzolov

commit sha c1f8f6860962e11657ec4cacf38e7dcdbcbef07d

Add Docker Compose Host File System Access file (#3791) * Add Docker Compose Host File System Access file Resolves #3790 * Inline the docker-compose-mount-host-folder.yml configuraiton directly into the docker-compose.yml * Add docker-compose in-file documentation * Update spring-cloud-dataflow-server/docker-compose.yml Co-Authored-By: Ilayaperumal Gopinathan <igopinathan@pivotal.io> * Update spring-cloud-dataflow-server/docker-compose.yml Co-Authored-By: Ilayaperumal Gopinathan <igopinathan@pivotal.io> Co-authored-by: Ilayaperumal Gopinathan <igopinathan@pivotal.io>

view details

Glenn Renfro

commit sha 75810d947bc9fde43eb7b5b8b785e977e8bd562c

Checks to make sure any CTR split does not exceed maxConcurrentCount (#3777) * Checks to make sure CTR split does not exceed naxConcurrentCount resolves #3630 * Updated based on code review Created ComposedTaskRunnerVisitor in the DSL module in a new visitor package. Rebased

view details

David Turanski

commit sha 7e2326f89684e31553d42b5c3c26497348a7960c

Use org/space in task platform runtime - Relates to spring-cloud/spring-cloud-deployer-cloudfoundry#335

view details

push time in 10 days

issue commentspring-cloud/spring-cloud-dataflow

Having more than 1000 entries in the table `app_registration` causes different errors

This is kind of a design flaw how apps are shown. Theoretically we should have designed every location in UI to use proper paging or not use paging on a rest api at all. Some part of an UI don't use paging and thus original workaround was to request one with size 1000.

It might be even better to fetch less and do multiple queries. We probably have this issue in other parts of an UI as well.

xetra11

comment created time in 10 days

push eventspring-cloud/spring-cloud-dataflow-build

Janne Valkealahti

commit sha ffc1f695198e3e0e8939b1ee546054c64b662b4d

Add profile for checkstyle - Not all projects have checkstyle enabled so this checkstyle profile will enable it which makes it easier to move to it in dependant projects.

view details

push time in 10 days

issue openedspring-cloud/spring-cloud-dataflow-build

Check spring-cloud-dataflow-build-tools version for release

spring-cloud-dataflow-build-tools is defined as a version in a plugin management and we need to check that next release changes that to 2.5.0.M1. If our release build doesn't do it we need to figure out something else.

created time in 10 days

PR opened spring-cloud/spring-cloud-deployer-cloudfoundry

Change not to cache error signals
  • Modify org/space result caching so that we let empty and errors getting evicted immediately so that next request is re-attempted.
  • Without this you'd need to restart server to clear out cache.
  • New test is throwing conditionally so it should simulate real scenario.
  • Fixes #337
+158 -3

0 comment

2 changed files

pr created time in 10 days

create barnchjvalkeal/spring-cloud-deployer-cloudfoundry

branch : gh337

created branch time in 10 days

push eventjvalkeal/spring-cloud-deployer-cloudfoundry

David Turanski

commit sha 479d6f92ecd4465a202df7aed475275a01521c0e

Include platform org/space for task execution count - Add space and org to RuntimeEnvironmentInfo - Fixes #335

view details

push time in 10 days

issue openedspring-cloud/spring-cloud-deployer-cloudfoundry

Handle error with caching

Relates to previous work for #335 and its PR #336. When we're caching a response from a CF api we should use operator which allows to define time-to-live values as otherwise first error will get cached indefinitely.

created time in 10 days

PR closed spring-cloud/spring-cloud-dataflow

Reviewers
Update k8s deployment files automated pr

Detected a change with mvn process-resources -P deploymentfiles.

This PR were created to align k8s deployment file changes.

+4 -4

4 comments

3 changed files

github-actions[bot]

pr closed time in 10 days

pull request commentspring-cloud/spring-cloud-dataflow

Update k8s deployment files

Ah, this was from a time after a release and we're already gone to 2.5.x. Closing without merging...

github-actions[bot]

comment created time in 10 days

push eventjvalkeal/atest2

Janne Valkealahti

commit sha e38a6d2f129112a84de32ff45a719cb5ebe54123

stash

view details

push time in 11 days

delete branch spring-cloud/spring-cloud-dataflow-common

delete branch : 2.4.0.M1

delete time in 12 days

delete branch spring-cloud/spring-cloud-dataflow-common

delete branch : 2.4.0.RC1

delete time in 12 days

delete branch spring-cloud/spring-cloud-dataflow-common

delete branch : 2.4.0.RELEASE

delete time in 12 days

delete branch spring-cloud/spring-cloud-dataflow-build

delete branch : 2.4.0.M1

delete time in 12 days

delete branch spring-cloud/spring-cloud-dataflow-build

delete branch : 2.4.0.RC1

delete time in 12 days

delete branch spring-cloud/spring-cloud-dataflow-build

delete branch : 2.4.0.RELEASE

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer-local

delete branch : 2.2.0.M1

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer-local

delete branch : 2.2.0.RC1

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer-local

delete branch : 2.2.0.RELEASE

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer-kubernetes

delete branch : 2.2.0.M1

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer-kubernetes

delete branch : 2.2.0.RC1

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer-kubernetes

delete branch : 2.2.0.RELEASE

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer-cloudfoundry

delete branch : 2.2.0.M1

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer-cloudfoundry

delete branch : 2.2.0.RC1

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer-cloudfoundry

delete branch : 2.2.0.RELEASE

delete time in 12 days

delete branch spring-cloud/spring-cloud-skipper

delete branch : 2.3.0.RELEASE

delete time in 12 days

delete branch spring-cloud/spring-cloud-skipper

delete branch : 2.3.0.M1

delete time in 12 days

delete branch spring-cloud/spring-cloud-skipper

delete branch : 2.3.0.RC1

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer

delete branch : 2.2.0.M1

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer

delete branch : 2.2.0.RC1

delete time in 12 days

delete branch spring-cloud/spring-cloud-deployer

delete branch : 2.2.0.RELEASE

delete time in 12 days

push eventspring-cloud/spring-cloud-dataflow-common

Janne Valkealahti

commit sha 375586432e066185080c2ddb14170b98b8aa43ac

Add workflow for master and pr's

view details

push time in 12 days

PR closed spring-cloud/spring-cloud-dataflow

Reviewers
Cf deployer issue 335

Depends on https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/pull/336 and Fixes https://github.com/spring-cloud/spring-cloud-deployer-cloudfoundry/issues/335

Since SCDF configures the TaskPlatform, this fix requires changes to CloudFoundryTaskPlatformFactory and corresponding changes to tests for the CF task platform.

It would be difficult to automate integration tests for this. I verified the fix manually using one of our AT environments and an account that has access to multiple orgs and spaces. I deployed this branch of dataflow server to two different orgs and launched tasks in one while monitoring tasks/executions/current using watch curl ... on both dataflow servers. The instance that launched the task shows 1 task running, while the instance in the other space/org, correctly, continues to show 0 tasks running. See attached (the missing url error due to an extra space, but the command still worked) Screen Shot 2020-02-05 at 10 01 24 AM

+108 -12

1 comment

5 changed files

dturanski

pr closed time in 13 days

pull request commentspring-cloud/spring-cloud-dataflow

Cf deployer issue 335

Squashed and merged

dturanski

comment created time in 13 days

push eventspring-cloud/spring-cloud-dataflow

David Turanski

commit sha 7e2326f89684e31553d42b5c3c26497348a7960c

Use org/space in task platform runtime - Relates to spring-cloud/spring-cloud-deployer-cloudfoundry#335

view details

push time in 13 days

PR closed spring-cloud/spring-cloud-deployer-cloudfoundry

Add space and org to RuntimeEnvironmentInfo

Fixes #335

The AbstractCloudFoundryTaskLauncher does not have direct access to the current space and org names. These are carried in CloudFoundryConnectionProperties. Rather than add a constructor arg, it seems easier to add these values in the RuntimeEnvironmentInfo.platformSpecificInfo Map.
This is done in CloudFoundryDeployerAutoConfiguration but also required the same change in spring-cloud-dataflow-platform-cloudfoundry : CloudFoundryTaskPlatformFactory

+223 -71

1 comment

4 changed files

dturanski

pr closed time in 13 days

pull request commentspring-cloud/spring-cloud-deployer-cloudfoundry

Add space and org to RuntimeEnvironmentInfo

Squashed and merged.

dturanski

comment created time in 13 days

push eventspring-cloud/spring-cloud-deployer-cloudfoundry

David Turanski

commit sha 479d6f92ecd4465a202df7aed475275a01521c0e

Include platform org/space for task execution count - Add space and org to RuntimeEnvironmentInfo - Fixes #335

view details

push time in 13 days

issue closedspring-cloud/spring-cloud-deployer-cloudfoundry

TaskLauncher getRunningTaskExecutionCount() should only include platform org and space

Hi David - Let me provide you with some more information from the ticket."Within this single foundation, we have multiple ORGS and SPACES therein. Our app alone resides in ORG(s): Tax_us-prd and Tax_us-ext-uat (external uat user testing). The space for both is DigitalTaxPaymentDecisions. Issue: in both Orgs we are running Spring Cloud Data Flow as a service, each instance having a unique url/instance of EXT-UAT and PRD Our issue is that sometimes PROD will report "The maximum concurrent task executions is at its limit [20]". But if we look at PROD Dataflow, there are no running tasks. Through research we have come to find that the url above is reporting counts for the entire PROD foundation regardless of ORG, Space. If we run cf curl v3/tasks?states=RUNNING from cf cli, we only see the tasks that we have org/space access to, but it also shows all orgs, regardless of which one we actually logged into.

Question:

  1. How do we isolate concurrent running task count by org and space?
  2. How do we configure the maximumTaskExecutions by org and space? (edited)

closed time in 13 days

dturanski

push eventjvalkeal/spring-cloud-deployer-cloudfoundry

Janne Valkealahti

commit sha 126db674d3705d3c3a64d2928147b0c9605ed1db

Use deployer spi 2.2.0.M1

view details

Janne Valkealahti

commit sha 492fdbd8cee42d34bc4f6e95de7e2bda254bcf16

Use deployer spi snapshots

view details

Janne Valkealahti

commit sha 94149e17563e2348861400daa66bdc2e2af49670

Upgrade spring-cloud-deployer 2.2.0.RC1

view details

Janne Valkealahti

commit sha 452ec13173e36f119a3efaefbaf775e76351d752

Upgrade spring-cloud-deployer 2.2.0.RELEASE

view details

Spring Buildmaster

commit sha 17ca24dcc4e945718e321897dca8648d33b8073f

Next development version 2.2.1.BUILD-SNAPSHOT

view details

Janne Valkealahti

commit sha 7d46d21cd910f771c4337bfc20024dbc49b70074

Align used deployer property name

view details

Janne Valkealahti

commit sha 3e54477f6d0cdb2aeb886fab6b45e188f922e85b

Add maven maintenance scripts

view details

Janne Valkealahti

commit sha 467eadab470f1015e7e3fe97433907eb0c9faaaf

Move to next minor development version

view details

Janne Valkealahti

commit sha 59e10dc5b9d4c65661210a8ac6aa42828cf18341

Add workflow for master and pr's

view details

push time in 15 days

push eventjvalkeal/spring-cloud-common-security-config

Janne Valkealahti

commit sha 8d45acecd3433c5b573f57512f5b577a0e1a3fc9

Enable checkstyle and fix common errors

view details

push time in 17 days

push eventspring-cloud/spring-cloud-common-security-config

Janne Valkealahti

commit sha 8d45acecd3433c5b573f57512f5b577a0e1a3fc9

Enable checkstyle and fix common errors

view details

push time in 17 days

create barnchjvalkeal/spring-cloud-common-security-config

branch : enable-checkstyle

created branch time in 17 days

push eventjvalkeal/spring-cloud-common-security-config

Janne Valkealahti

commit sha 9dab64d82529b5daf24513c44a48432eeda06156

Next minor development version

view details

Janne Valkealahti

commit sha 00e8b2d7ea49d84def2ddc04f61921f2099310c9

Move to spring-cloud-dataflow-build parent and polish poms

view details

Janne Valkealahti

commit sha c6a53277b5b81f5ea4955b1280444ed52408c0ff

Add workflow for master and pr's

view details

Janne Valkealahti

commit sha ea391465b5aea93f91ef43f70f24fb016159be3e

Polish

view details

push time in 17 days

issue commentspring-cloud/spring-cloud-common-security-config

Make "OpaqueTokenIntrospector" an optional bean

When we moved away from supporting LDAP in favour of just "oauth", opaque token introspection was kinda replacement. It's baked in rather deep in our security classes to map scopes into roles, etc. As Azure AD don't have introspection endpoint, afaik, we'd need to bring back all these ways to handle AD groups.

sabbyanandan

comment created time in 17 days

push eventjvalkeal/spring-cloud-dataflow

Glenn Renfro

commit sha 992a5689b72e7e456218ff05be04f19f640da882

Added docs for scheduling shell commands (#3770) * Added docs for scheduling shell commands resolves #3754 * Updated based on code review. Thanks!

view details

Christian Tzolov

commit sha aed447f37c4d2f7d19b278867d88e886531ae2b5

Clarify the whitelisted property configuration Resolves https://github.com/spring-io/dataflow.spring.io/issues/181

view details

push time in 17 days

push eventspring-cloud/spring-cloud-common-security-config

Janne Valkealahti

commit sha ea391465b5aea93f91ef43f70f24fb016159be3e

Polish

view details

push time in 20 days

push eventspring-cloud/spring-cloud-common-security-config

Janne Valkealahti

commit sha 9dab64d82529b5daf24513c44a48432eeda06156

Next minor development version

view details

Janne Valkealahti

commit sha 00e8b2d7ea49d84def2ddc04f61921f2099310c9

Move to spring-cloud-dataflow-build parent and polish poms

view details

Janne Valkealahti

commit sha c6a53277b5b81f5ea4955b1280444ed52408c0ff

Add workflow for master and pr's

view details

push time in 20 days

create barnchspring-cloud/spring-cloud-common-security-config

branch : 1.2.x

created branch time in 20 days

delete branch spring-cloud/spring-cloud-common-security-config

delete branch : 1.2.1.RELEASE

delete time in 20 days

push eventjvalkeal/spring-cloud-common-security-config

Gunnar Hillert

commit sha e0a782e991ae697a943f9e844abc94304ab875ef

Add roles SCHEDULE, DEPLOY, DESTROY, MODIFY - Add additional roles - Update tests - Fix injection of oauth2ClientContext - Fixes #31

view details

Gunnar Hillert

commit sha acfc896ad7fe5f8fc7675adf9de2d7b486b515d9

gh-33 Validate scope of the OAuth token * Add class ` DataFlowUserInfoTokenServices` which is an extension of `DefaultTokenServices` that provides the functionality of the `RemoteTokenServices` * Add Tests * Make non-empty assertion on `userInfoEndpointUrl` + `tokenInfoUri` Fixes #33

view details

Spring Buildmaster

commit sha ee58816af8e711b83682e54984a0a57679af57fa

[artifactory-release] Release version 1.1.0.RC1

view details

Spring Buildmaster

commit sha 297e3244bb4962578b963e37a7274c0447d0fea0

[artifactory-release] Next development version 1.1.0.BUILD-SNAPSHOT

view details

Spring Buildmaster

commit sha 5d1fee6f12d7d2e922a7a26736d8f8ad0119feb2

[artifactory-release] Next development version 1.1.1.BUILD-SNAPSHOT

view details

Gunnar Hillert

commit sha c9bb94a9333f928796544c85e4b2bd53fe861f1c

gh-37 Update spring-security-oauth2 dependency

view details

Spring Buildmaster

commit sha 4d5dad2c32921d6eb0da5f4e69bde4be40dfd169

[artifactory-release] Release version 1.1.1.RELEASE

view details

Spring Buildmaster

commit sha 09bb5e4950b079c1705792e8f69d084560c77c89

[artifactory-release] Next development version 1.1.2.BUILD-SNAPSHOT

view details

Mike Heath

commit sha 24471dbf28348c1a885631ec05cd82b6c1a60024

Add support for DEPLOY, DESTROY, MODIFY, and SCHEDULE roles

view details

Spring Buildmaster

commit sha ecd42c02cce90334c17c570aef373215393a9d1b

[artifactory-release] Release version 1.1.2.RELEASE

view details

Spring Buildmaster

commit sha 91442aed5303a5c2185468bdb0dd91f9c759ae61

[artifactory-release] Next development version 1.1.3.BUILD-SNAPSHOT

view details

Spring Operator

commit sha 59bfacfb9555aa079a13ef74d2770f7bdd34967f

URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://www.apache.org/licenses/LICENSE-2.0 migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200). * http://www.apache.org/licenses/LICENSE-2.0.txt migrated to: https://www.apache.org/licenses/LICENSE-2.0.txt ([https](https://www.apache.org/licenses/LICENSE-2.0.txt) result 200). * http://www.spring.io migrated to: https://www.spring.io ([https](https://www.spring.io) result 301). # Ignored These URLs were intentionally ignored. * http://maven.apache.org/POM/4.0.0 * http://maven.apache.org/xsd/maven-4.0.0.xsd * http://www.w3.org/2001/XMLSchema-instance

view details

Ilayaperumal Gopinathan

commit sha 26260e7d7a2d82f5e9449bf132b14cf4924dc811

Update Spring Boot to 2.1.6.RELEASE Resolves #54

view details

Spring Operator

commit sha c01cc77184fff279ccb4f3a4065442c24580573b

URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://maven.apache.org/xsd/maven-4.0.0.xsd with 3 occurrences migrated to: https://maven.apache.org/xsd/maven-4.0.0.xsd ([https](https://maven.apache.org/xsd/maven-4.0.0.xsd) result 200). * http://repo.spring.io/libs-milestone-local with 2 occurrences migrated to: https://repo.spring.io/libs-milestone-local ([https](https://repo.spring.io/libs-milestone-local) result 302). * http://repo.spring.io/libs-snapshot-local with 2 occurrences migrated to: https://repo.spring.io/libs-snapshot-local ([https](https://repo.spring.io/libs-snapshot-local) result 302). * http://repo.spring.io/release with 1 occurrences migrated to: https://repo.spring.io/release ([https](https://repo.spring.io/release) result 302). # Ignored These URLs were intentionally ignored. * http://maven.apache.org/POM/4.0.0 with 6 occurrences * http://www.w3.org/2001/XMLSchema-instance with 3 occurrences

view details

Spring Operator

commit sha 9c4792d181432f2514b966525aeb29fac0b67af3

URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * [ ] http://scdf2/ (UnknownHostException) with 1 occurrences migrated to: https://scdf2/ ([https](https://scdf2/) result UnknownHostException). * [ ] http://server/ (UnknownHostException) with 1 occurrences migrated to: https://server/ ([https](https://server/) result UnknownHostException). * [ ] http://the.authorities.server/authorities (UnknownHostException) with 1 occurrences migrated to: https://the.authorities.server/authorities ([https](https://the.authorities.server/authorities) result UnknownHostException). # Ignored These URLs were intentionally ignored. * http://localhost:8080/uaa/check_token with 1 occurrences * http://localhost:8080/uaa/userinfo with 1 occurrences * http://test/authorities with 1 occurrences

view details

Spring Operator

commit sha bc9c13c82df9bce0092ebde6967587337c21307d

URL Cleanup This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://www.apache.org/licenses/LICENSE-2.0 with 20 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).

view details

Gunnar Hillert

commit sha 2a391240c188d8eb1a6fdfa4e8dbdfbd38569260

Upgrade to Boot 2.2.x - Move to next minor dev version. - Fixes #56

view details

Gunnar Hillert

commit sha 9fbf72471db6025fa74f9577ffd815bd86a9c9a7

gh-58 Add OAuth2AccessTokenProvidingClientHttpRequestInterceptor gh-58 Polishing gh-58 Polishing gh-58 Add Tests Polished some tests on merge

view details

Janne Valkealahti

commit sha c0050f3116231828f94a05c9a5a61fee19400b67

Use boot 2.2.0.M5

view details

Janne Valkealahti

commit sha b62435745e6311c999197fef7ca3b64181671f40

Use correct version of spring-security-oauth2-autoconfigure

view details

push time in 20 days

Pull request review commentspring-cloud/spring-cloud-deployer-cloudfoundry

Add space and org to RuntimeEnvironmentInfo

 public TaskStatus status(String id) { 	@Override 	public int getRunningTaskExecutionCount() { -		ListTasksRequest listTasksRequest = ListTasksRequest.builder().state(TaskState.RUNNING).build();-		return this.client.tasks().list(listTasksRequest).map(listTasksResponse ->-			listTasksResponse.getPagination().getTotalResults())-			.doOnError(logError("Failed to list running tasks"))-			.doOnSuccess(count -> logger.info(String.format("There are %d running tasks", count)))-			.block(Duration.ofMillis(this.deploymentProperties.getStatusTimeout()));+		ListTasksRequest listTasksRequest = ListTasksRequest.builder()+				.state(TaskState.RUNNING)+				.organizationId(this.organizationId)

I think the issue here is that you're trying to use fully imperative programming with reactive api's which usually don't end up well. You could still make those org/space requests with reactive way with a original method and cache those responses within a reactive chain itself. That would then handle caching and also you would not need to worry about threads.

dturanski

comment created time in 21 days

Pull request review commentspring-cloud/spring-cloud-deployer-cloudfoundry

Add space and org to RuntimeEnvironmentInfo

 public TaskStatus status(String id) { 	@Override 	public int getRunningTaskExecutionCount() { -		ListTasksRequest listTasksRequest = ListTasksRequest.builder().state(TaskState.RUNNING).build();-		return this.client.tasks().list(listTasksRequest).map(listTasksResponse ->-			listTasksResponse.getPagination().getTotalResults())-			.doOnError(logError("Failed to list running tasks"))-			.doOnSuccess(count -> logger.info(String.format("There are %d running tasks", count)))-			.block(Duration.ofMillis(this.deploymentProperties.getStatusTimeout()));+		ListTasksRequest listTasksRequest = ListTasksRequest.builder()+				.state(TaskState.RUNNING)+				.organizationId(this.organizationId)

Uh-oh, blocking network calls in a constructor. I wonder when those are actually getting called?

dturanski

comment created time in 21 days

more