profile
viewpoint

dunglas/vaccin.click 97

Une extension Firefox pour trouver et réserver automatiquement votre créneau de vaccination COVID-19.

fxbox/openzwave-rust 4

Rust wrapper for the open-zwave library

bocoup/gaia 3

Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing

julienw/calendar 2

This is a simple calendar made in PHP, centered around events instead of people.

fxbox/open-zwave 1

a C++ and DotNet library to control Z-Wave Networks via a Z-Wave Controller.

gnarf/gaia 1

Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing

fxbox/calendar 0

:calendar: Project Cue -Currently looking for a slogan-

issue commentfirefox-devtools/profiler

Sluggish call tree performance in threads with lots of samples

One big problem, as usual, is that the react render happens in the keydown handler, rather than from a requestAnimationFrame callback. So multiple keydowns are never batched.

I wonder if React 18 helps with that 🤔

mstange

comment created time in 12 hours

push eventjulienw/advent-of-code

Julien Wajsberg

commit sha ead68e1d294287e3e3a6db90249afb924a06d3ef

Day 5

view details

push time in 20 hours

push eventjulienw/advent-of-code

Julien Wajsberg

commit sha 6573241829dd5c856a55235564901f5635902b7e

Day 4

view details

push time in a day

issue openedfirefox-devtools/profiler

Show timestamps in call node tooltips

It's currently challenging to know what is the timestamp of an hovered sample. A user has to look at the vertical line and the top ruler to know about that. By adding the timestamp in the call node tooltip, it will be easier to navigate in a profile.

created time in 3 days

issue openedfirefox-devtools/profiler

It should be easier to display the tooltip for activity graph points where the graph has a small height

Currently, when the activity graph has a small height, it can be challenging to display the tooltip for samples in that area.

We can try displaying a tooltip for the topmost sample when the user doesn't hover on the filled part of the activity graph. If we decide it's too much, we could do it only when the mouse is close enough of the activity graph's edge.

created time in 3 days

issue closedfirefox-devtools/profiler

Navigating back before the profile loading is buggy

There are a few different STRs, that could cover one or several issues, that all deal with the handling of the back button.

STR1:

  1. load any profile (eg https://perf-html.io/public/8c8e1c9f7feb95c69e1eee7b059d4ac33eb9194f/calltree/?globalTrackOrder=0-1-2-3-4-5-6-7-8-9-10&hiddenGlobalTracks=1-2-3-4-5-6-7-8-9-10&localTrackOrderByPid=11808-0~&react_perf&thread=0&v=3)
  2. press back => error

STR2:

  1. Go to https://perf-html.io/compare
  2. Enter 2 URLs to compare (could be twice the same one) and then press enter.
  3. Press back. => error

closed time in 3 days

julienw

issue commentfirefox-devtools/profiler

Navigating back before the profile loading is buggy

The 2 STR from the description are now working.

julienw

comment created time in 3 days

issue openedfirefox-devtools/profiler

We should be able to right click on the sample graph

As a reminder, the sample graph is the blue line below the activity and cpu graph.

We should be able to right click this sample graph and get the same context menu that we have on the activity graph.

created time in 3 days

issue openedfirefox-devtools/profiler

All memory graphs should have the same scale

Currently memory graphs are computed independently. That means that in a situation like:

  • memory graph A going from 0 to 1 GB
  • memory graph B going from 0 to 10 kB

They would all look the same despite that memory graph B is unimportant.

We should compute one same scale for the whole profile and use it. I'm not sure yet whether this scale should change with the range, or rather stay fixed. Feedback welcome!

Then once we have this scale, we could also decide that some memory graphs could be automatically hidden depending on some threshold computed from the scale.

created time in 3 days

issue openedfirefox-devtools/profiler

Handle selected markers in the marker chart

Currently we don't have the notion of a selected marker in the marker chart, but we do have that for the marker table.

created time in 3 days

issue openedfirefox-devtools/profiler

Make it easier to do a selection from 2 markers

Currently doing a selection from 2 markers requires a lot of clicks. We could make that easier.

An idea is, once we have the notion of a "selected marker" in the marker chart like we want to do, right clicking on another marker will give some options to select a range, eg "select the space between markers" and "select the space including markers".

created time in 3 days

issue commentfirefox-devtools/profiler

Implement Sticky Tooltips

Current idea: show the tooltip for the currently selected marker.

julienw

comment created time in 3 days

issue openedfirefox-devtools/profiler

Copying with Ctrl-C doesn't work in the flamegraph

We should handle the copy gesture in the flamegraph, which should copy the function's name like in the call tree.

created time in 3 days

issue openedfirefox-devtools/profiler

The tooltip saying "either buffer full or profiler not started yet" could be clarified

Here is an example

Either we already have the information to clarify this (the "starting profiler phase" could be known?), or we should add it from the backend.

created time in 3 days

issue openedfirefox-devtools/profiler

Show the CPU time of the preview selection close to the selection's range

The selection's current time range is displayed at the top of the preview selection. We could also show the CPU time for this selection

created time in 3 days

issue openedfirefox-devtools/profiler

We should show the total profile duration next to "Full Range"

Currently we don't see the total profile duration. We should show it at the top next to "Full Range", where ranges are displayed later when the user selects one.

created time in 3 days

issue openedfirefox-devtools/profiler

The algorithm to control the ellipsis in our canvas-based panels can be improved

The algorithm to control the ellipsis is implemented in https://github.com/firefox-devtools/profiler/blob/main/src/utils/text-measurement.js.

We can see in several profiles how it's not perfect: sometimes the text is cut too soon, sometimes too late. This is because we use an approximation in https://github.com/firefox-devtools/profiler/blob/bf0d12fe12d02855b9b8945c1a4d7f477d472aec/src/utils/text-measurement.js#L82-L92. We use this approximation because using the real measure in a loop is presumably too slow.

We could try various things:

  • bisection instead of this dumb loop, possibly only a few measures would be necessary
  • use a well positioned element for just the text, and let the browser do its thing

This measurement is used in all our canvas-based panels: marker chart, flame graph, stack chart.

This profile has a bunch of problems in the marker chart, some are too long (look at the Runnable line, or the label starting with PWebRenderBridge), some are too short (especially the network request here).

We should also probably avoid drawing a few characters only (there are even some examples where only the ellipsis is displayed, this is clearly useless).

created time in 3 days

issue closedfirefox-devtools/profiler

Allowlist markers for webdev mode

We want to show only relevant markers for webdevs.

closed time in 3 days

julienw

issue commentfirefox-devtools/profiler

Allowlist markers for webdev mode

We filter markers by their innerWindowId now. This is probably OK as a first step, we can always adjust if we need to later, but we'll file another issue for that.

julienw

comment created time in 3 days

created tagfirefox-devtools/react-contextmenu

tagv3.0.0

This is a fork of the original react-contextmenu, to fix a few bugs that was impairing the Firefox Profiler.

created time in 3 days

created tagfirefox-devtools/react-contextmenu

tagvkbansal-last-commit

This is a fork of the original react-contextmenu, to fix a few bugs that was impairing the Firefox Profiler.

created time in 3 days

push eventfirefox-devtools/react-contextmenu

Julien Wajsberg

commit sha 99a9f7750eea50ec0474581a5144d93419cde5a3

v3.0.0

view details

push time in 3 days

push eventfirefox-devtools/react-contextmenu

Julien Wajsberg

commit sha c9bea79e5c0685bf75b29778be4afca511df82b6

Upgrade jsprim transitive dependency so that a fixed json-schema is used (PR #24)

view details

push time in 3 days

PR merged firefox-devtools/react-contextmenu

Upgrade jsprim transitive dependency so that a fixed json-schema is used

json-schema has a security alert that is fixed with v0.4.0. This PR upgrades jsprim that itself updated its dependency on json-schema and released a minor update.

These packages are used by coveralls, so nothing really important for the library itself.

+8 -8

0 comment

1 changed file

julienw

pr closed time in 3 days

create barnchjulienw/react-contextmenu

branch : remove-security-issue-dependency

created branch time in 3 days

push eventfirefox-devtools/react-contextmenu

depfu[bot]

commit sha 3f1a7b10a1ac8d4ecd736367d22b1133b6f806ee

Update all development Yarn dependencies (2021-11-30)

view details

Julien Wajsberg

commit sha 6216a256a0b08b9e02a5b5de6c2adf0a574563ff

Fix eslint configuration

view details

Julien Wajsberg

commit sha a4095331ccc46b7a83607f058a4a2514af3fb514

Fix autofixed eslint errors

view details

Julien Wajsberg

commit sha abf6cead8925d31ca7061db7cb541fdb803cfe8a

Fix the last eslint error

view details

Julien Wajsberg

commit sha 3478b0bf12d80cd71c007677aa3bdd71123807f0

Fix enzyme tests

view details

Julien Wajsberg

commit sha 101ccce546eb619281aff4ea6723eb9c92679bf5

Upgrade webpack configuration to webpack v5

view details

Julien Wajsberg

commit sha 23605c06634fef2f3dc82c19629bded8ee0e5cb3

Changes related to the new version of react-router

view details

Julien Wajsberg

commit sha eef2b6db16260a18f25cb04d24fc8b668630e3a8

Merge branch 'master' into depfu/batch_dev/yarn/2021-11-29

view details

Julien Wajsberg

commit sha 856f5bcca6ccfe61b57a925460d0e191b1cfb51e

Update all development Yarn dependencies (2021-11-30) (Merge PR #22)

view details

push time in 3 days

PR merged firefox-devtools/react-contextmenu

Update all development Yarn dependencies (2021-11-30) dependencies

This is your weekly update of all development Yarn dependencies. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ cross-env (6.0.3 → 7.0.3, major) · Repo · Changelog · Release · Diff

✳️ css-loader (0.28.11 → 6.5.1, major) · Repo · Changelog · Release · Diff

✳️ eslint (4.18.2 → 8.2.0, major) · Repo · Changelog · Release · Diff

✳️ eslint-import-resolver-webpack (0.8.4 → 0.13.2, major) · Repo · Changelog

✳️ history (4.10.1 → 5.1.0, major) · Repo · Changelog · Release · Diff

✳️ html-webpack-plugin (2.30.1 → 5.5.0, major) · Repo · Changelog · Diff

✳️ http-server (0.11.1 → 14.0.0, major) · Repo · Release · Diff

✳️ react (16.8.6 → 17.0.2, major) · Repo · Changelog · Release · Diff

✳️ react-dom (16.8.6 → 17.0.2, major) · Repo · Changelog · Release · Diff

✳️ react-router-dom (5.0.1 → 6.0.2, major) · Repo · Changelog · Release · Diff

✳️ react-test-renderer (16.8.6 → 17.0.2, major) · Repo · Changelog · Release · Diff

✳️ style-loader (0.19.1 → 3.3.1, major) · Repo · Changelog · Release · Diff

✳️ webpack (3.12.0 → 5.64.1, major) · Repo · Release · Diff

✳️ @babel/cli (7.15.4 → 7.16.0, minor) · Repo · Changelog · Release · Diff

✳️ @babel/core (7.15.5 → 7.16.0, minor) · Repo · Changelog · Release · Diff

✳️ @babel/preset-env (7.15.4 → 7.16.4, minor) · Repo · Changelog · Release · Diff

✳️ @babel/preset-react (7.14.5 → 7.16.0, minor) · Repo · Changelog · Release · Diff

✳️ babel-jest (27.1.0 → 27.3.1, minor) · Repo · Changelog · Release · Diff

✳️ coveralls (3.0.7 → 3.1.1, minor) · Repo · Release · Diff

✳️ enzyme (3.10.0 → 3.11.0, minor) · Repo · Changelog

✳️ enzyme-to-json (3.4.3 → 3.6.2, minor) · Repo · Changelog · Release · Diff

✳️ eslint-plugin-import (2.18.2 → 2.25.3, minor) · Repo · Changelog · Diff

✳️ eslint-plugin-react (7.16.0 → 7.27.0, minor) · Repo · Changelog · Diff

✳️ jest (27.1.0 → 27.3.1, minor) · Repo · Changelog · Release · Diff

✳️ babel-loader (8.2.2 → 8.2.3, patch) · Repo · Changelog · Release · Diff

✳️ enzyme-adapter-react-16 (1.15.1 → 1.15.6, patch) · Repo · Changelog


Depfu Status

Depfu will only send you the next scheduled PR once you merge or close this one.

<details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@​depfu refresh</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@​depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@​depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@​depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@​depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> </dl></blockquote> </details>

+2756 -5619

2 comments

22 changed files

depfu[bot]

pr closed time in 3 days

push eventfirefox-devtools/react-contextmenu

Julien Wajsberg

commit sha d008c5b930d24a25fda7ba2ad33c9baf35d19f68

Change some remaining URLs from the old repository to the new one (PR #23)

view details

Julien Wajsberg

commit sha eef2b6db16260a18f25cb04d24fc8b668630e3a8

Merge branch 'master' into depfu/batch_dev/yarn/2021-11-29

view details

push time in 3 days

PullRequestReviewEvent
more