profile
viewpoint
Juan José juanarbol @NodeSource https://juanarbol.com Anti hero, @soyjuanarbol on Twitter

juanarbol/33-js-conceptos 0

📜 33 Conceptos que todo desarrollador de JavaScript debería saber.

juanarbol/abi-stable-node 0

NAPI — Node with PoC ABI stable API for native modules.

juanarbol/async 0

Async utilities for node and the browser

juanarbol/bin2 0

Converter of binary numbers to any other numeric system

juanarbol/build 0

Better build and test infra for Node.

juanarbol/colmillo 0

Partnership with colmillo! 🐢✨

juanarbol/cpp_algorithms 0

A bunch of c++ algorithms just for having fun!

Pull request review commentnodejs/node

doc: clarify docs fs.watch exception may be emitted

 to be notified of filesystem changes. * On Aix systems, this feature depends on [`AHAFS`][], which must be enabled.  If the underlying functionality is not available for some reason, then-`fs.watch` will not be able to function. For example, watching files or-directories can be unreliable, and in some cases impossible, on network file-systems (NFS, SMB, etc), or host file systems when using virtualization software-such as Vagrant, Docker, etc.+`fs.watch` will not be able to function (may an exception will be thrown).

Thank you, fixed!

juanarbol

comment created time in 14 hours

push eventjuanarbol/node

Juan José Arboleda

commit sha 69d061b9c6e6eb4338d472b9a13390848bde31e6

fixup

view details

push time in 14 hours

pull request commentnodejs/node

lib: expose performance interface to global object

Ping @BridgeAR I think Performance API is no longer experimental, should we consider re-open this PR?

juanarbol

comment created time in a day

issue commentnodejs/node

display node.js version (process.version) at the end of stacktraces

@ORESoftware Diagnostic report is now stable, you should consider using it for this case.

ORESoftware

comment created time in a day

PR opened nodejs/node

doc: clarify docs fs.watch exception may be emitted

Fixes: https://github.com/nodejs/node/issues/29894

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+4 -4

0 comment

1 changed file

pr created time in a day

create barnchjuanarbol/node

branch : juanarbol/fix-29894

created branch time in a day

push eventjuanarbol/node

Myles Borins

commit sha 4a3ccd8938f03d308952dbfedb654392ee8e6f31

deps: update npm to 6.14.3 PR-URL: https://github.com/nodejs/node/pull/32368 Refs: https://github.com/nodejs/node/issues/32296 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Sam Roberts

commit sha f7771fffd012d32dcdeba1405e207934618a3fa7

doc: update security release process PR-URL: https://github.com/nodejs/node/pull/31679 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Anna Henningsen

commit sha c0115424849e4bf193efd2341b6cc017e70971c8

src: prefer OnScopeLeave over shared_ptr<void> They do the same thing, but OnScopeLeave avoids an extra heap allocation and is more explicit about what it does. PR-URL: https://github.com/nodejs/node/pull/32247 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Anna Henningsen

commit sha 4cfcaaeef38031ffb4b87296702508b45dbb4222

deps: upgrade to c-ares v1.16.0 Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0 PR-URL: https://github.com/nodejs/node/pull/32246 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 95e3733532e050b72ee2e1269ecc05d795839ae6

cli: allow --huge-max-old-generation-size in NODE_OPTIONS PR-URL: https://github.com/nodejs/node/pull/32251 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Ben Noordhuis

commit sha fbecc07d4c931d9e86f5eeeed19ae31aa279a3eb

deps: remove *.pyc files from deps/npm These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. PR-URL: https://github.com/nodejs/node/pull/32387 Refs: https://github.com/nodejs/node/pull/32368 Refs: https://github.com/npm/cli/issues/1037 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Xu Meng

commit sha b891e9348b77468623ece665ae6b0a78c9644478

test: uv_tty_init returns EBADF on IBM i When TTY initialization failed, uv_tty_init returned EBADF on IBM i PASE, rather than EINVAL PR-URL: https://github.com/nodejs/node/pull/32338 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Gabriel Schulhof

commit sha c16007381f0325af866e9f382b0d9457af540d08

src: add debug option to report large page stats This adds the new option `HUGEPAGES` to `NODE_DEBUG_NATIVE` that causes the code responsible for re-mapping to large pages to output memory range and page count information to `stderr`. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/32331 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Sam Roberts

commit sha 131b50d1878924291e4a7e3304e180494d5a3e0f

build: expand ASAN acronym in configure help There is lots of space to expand this not-so-well-known acronym in the option usage message. PR-URL: https://github.com/nodejs/node/pull/32325 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Steven R. Loomis

commit sha b8a794d72bad66f25ce645d08defb41bd57c3371

deps: minor ICU fixes: maint docs/tool, downloader - Docs used the word "copy" when it really meant a tool is needed. - README-FULL-ICU.txt was generated in binary mode, but it's a text file. This breaks on Python3 for maintaining ICU - The ICU downloader was broken (also probably python3). It's basically dead code since 1a25e901b7c380929f0d08599f49dd77897a627f landed (full icu in repo), unless someone deleted the deps/icu-small directory from their repo. Co-Authored-By: Christian Clauss <cclauss@me.com> PR-URL: https://github.com/nodejs/node/pull/32347 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Steven R. Loomis

commit sha 74e7e727684703c918026679f47732f8c69c0fa2

deps: update to ICU 66.1 - ICU 66.1 http://site.icu-project.org/download/66 - Unicode 13 - CLDR 36.1 - Updated ./LICENSE PR-URL: https://github.com/nodejs/node/pull/32348 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha 064a6703a720f669f868e35cca69412ee3f962c5

src: update comment for SetImmediate() Refs: https://github.com/nodejs/node/pull/31502#issuecomment-599242824 PR-URL: https://github.com/nodejs/node/pull/32300 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha d129e0c782914df8720d1335c95bd7f635f2788e

src: avoid Isolate::GetCurrent() for platform implementation There’s no need to use `Isolate::GetCurrent()`, which is generally discouraged, as the `Isolate*` pointer can generally be looked up from the per-Isolate platform data structure. PR-URL: https://github.com/nodejs/node/pull/32269 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rod Vagg

commit sha 78a2dc7de2139cc51cf4992da7d835eed0b69c32

deps: update term-size with signed version PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Refs: https://github.com/sindresorhus/macos-term-size/pull/3 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Signed-off-by: Rod Vagg <rod@vagg.org>

view details

Anna Henningsen

commit sha d7bc5816a5d88e18d7ede081042d87f48a2bc54b

src: make `FreeEnvironment()` perform all necessary cleanup Make the calls `stop_sub_worker_contexts()`, `RunCleanup()` part of the public API for easier embedding. (Note that calling `RunAtExit()` is idempotent because the at-exit callback queue is cleared after each call.) PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Anna Henningsen

commit sha 288382a4ce4c1eb5d6eaccf698099804f6a3697d

src: fix memory leak in CreateEnvironment when bootstrap fails PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Anna Henningsen

commit sha 64c01222d9b62942f356048026742a7c8d778cef

src: move worker_context from Environment to IsolateData Workers are fully in control of their Isolates, and this helps avoid a problem with later changes to `CreateEnvironment()` because now we can run the boostrapping code inside the latter. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Anna Henningsen

commit sha 084c3796483a15da102480b2c5a1496417b5d7cf

src: associate is_main_thread() with worker_context() In our codebase, the assumption generally is that `!is_main_thread()` means that the current Environment belongs to a Node.js Worker thread. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Anna Henningsen

commit sha a9fb51f9be570001accfce8a057e885827655a2f

src: align worker and main thread code with embedder API This addresses some long-standing TODOs by Joyee and me about making the embedder API more powerful and us less reliant on internal APIs for creating the main thread and Workers. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

Anna Henningsen

commit sha c44edec4daff9f478eb9b5820d03da6c71253787

src: provide a variant of LoadEnvironment taking a callback This allows embedders to flexibly control how they start JS code rather than using `third_party_main`. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

push time in a day

issue commentnodejs/node

assert: confusion between JS strict mode and assert strict mode

Ping @BridgeAR I think this issue can be closed now.

shobhitchittora

comment created time in a day

issue commentnodejs/node

Nominating @Himself65 as a collaborator

+1

I thought he already was collaborator

gabrielschulhof

comment created time in a day

Pull request review commentnodejs/node

src: deprecate errname method at runtime

 using v8::Value;  void ErrName(const FunctionCallbackInfo<Value>& args) {

Yeap, deleted on 01eb79f

juanarbol

comment created time in 2 days

Pull request review commentnodejs/node

src: deprecate errname method at runtime

 'use strict'; const common = require('../common'); -// Flags: --pending-deprecation--common.expectWarning({-  DeprecationWarning: [-    ['process.binding() is deprecated. Please use public APIs instead.',

Thanks for reviewing!

Fixed

juanarbol

comment created time in 2 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 01eb79ff7f08409193715a16865075fccdaaba65

fixup

view details

push time in 2 days

pull request commentnodejs/node

lib: support MessagePort to workers data

ping @jasnell

juanarbol

comment created time in 4 days

PR closed nodejs/node

support maxConnections event on net server net semver-minor

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

I think this could help with the developer experience, when the server connection limit is reached there is not feedback.

At this point, the event is emitted every new connection over the limit, I mean, if the limit is 10, and we get 12 connections, the event will be emitted twice.

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+11 -1

3 comments

4 changed files

juanarbol

pr closed time in 4 days

pull request commentnodejs/node

support maxConnections event on net server

Closing

juanarbol

comment created time in 4 days

pull request commentnodejs/node

src: deprecate errname method at runtime

Ping @joyeecheung

juanarbol

comment created time in 4 days

PR opened nodejs/node

src: remove unused v8 namespace

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+0 -1

0 comment

1 changed file

pr created time in 9 days

create barnchjuanarbol/node

branch : juanarbol/remove-unused-v8-namespace

created branch time in 9 days

PR opened nodejs/node

src: clean v8 namespaces in env.cc file

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+7 -7

0 comment

1 changed file

pr created time in 9 days

create barnchjuanarbol/node

branch : juanarbol/v8-namespaces

created branch time in 9 days

Pull request review commentnodejs/node

lib: support MessagePort to workers data

 changes:     occur as described in the [HTML structured clone algorithm][], and an error     will be thrown if the object cannot be cloned (e.g. because it contains     `function`s).+  * `transferList` {Object[]} If you pass one or multiple `MessagePort`+    like objects in `workerData`, you will need to provide `transferList` for+    those items. Otherwise, [ERR_MISSING_MESSAGE_PORT_IN_TRANSFER_LIST][] will+    be thrown.

May resolved in 78b3e7b

juanarbol

comment created time in 9 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 78b3e7b4ad87201453e902cb686e69e2a7739c35

fixup

view details

push time in 9 days

push eventjuanarbol/node

Matheus Marchini

commit sha 86f146a2c0ff08df79fd99efb238e44c75b73381

test: make test-memory-usage predictable The current test relies on undeterministic behavior from V8 GC, and on newer versions of V8 this test ocasionally fails because that behavior changed. Prevent that from happening using --predictable-gc-schedule. If this test fails in the future, it should fail consistently instead of ocasionally, which should help debug. Ref: https://github.com/nodejs/node-v8/issues/144#issuecomment-597945219 Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32239 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

view details

cjihrig

commit sha 8617508d6b44a31abd904173cba6ca934bc094d2

src: fix warn_unused_result compiler warning ../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: https://github.com/nodejs/node/pull/32241 Refs: https://github.com/nodejs/node/pull/31972 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha a6bd2c2f81a0a238bf0f45174fee70b7870f8ef2

src: unconditionally include report feature This commit removes all #ifdef NODE_REPORT checks in the src directory. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

cjihrig

commit sha f1d3d927e1225f0b8a959d36024788bd65600c5b

build: remove node_report option in node.gyp PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

cjihrig

commit sha 765c3759eff73851bdc5c4f1f8f63819eed9a2e9

build: make --without-report a no-op This commit makes the configure --without-report flag a no-op. This commit also updates a test that depends on the report CLI flags being conditionally present. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

cjihrig

commit sha 4c64e7c59a655142367a361bae873683208b9f9b

test: remove common.skipIfReportDisabled() The report feature won't ever be disabled moving forward, so checking for its existence in the tests is no longer needed. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

cjihrig

commit sha 9d1a3b6f608d864f3e4b1e8dc667f733f5acdcb8

doc,lib,src,test: make --experimental-report a nop This commit makes the --experimental-report CLI flag a no-op. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

cjihrig

commit sha a022d387ea89a3bc5e7435faf2ae7030e0646af1

doc: update stability of report features This commit updates the stability documentation for the report feature. All diagnostic report APIs are now listed as stable, with the exception of report-on-fatalerror, which still has a few bugs to work out. PR-URL: https://github.com/nodejs/node/pull/32242 Fixes: https://github.com/nodejs/node/issues/26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Matheus Marchini

commit sha 2e3dc12ebd3294c09e14dc44e05b31d03fc75b37

test: workaround for V8 8.1 inspector pause issue `test-inspector-multisession-ws` and `test-inspector-break-when-eval` will be affected by an upstream bug when we upgrade V8 to 8.1. The bug is caused when the Inspector sets a pause at the start of a function compiled with `CompileFunctionInContext`, but that function hasn't been executed yet. On both tests, this issue is triggered by pausing while in C++ executing LookupAndCompile, which is called by requiring internal modules while running `console.log`. To eliminate this issue in both tests, we add an extra `console.log` to ensure we only pause we required all internal modules we need. On `test-inspector-break-when-eval`, we also need to start the child process with `--inspect-brk` instead of `--inspect` to ensure the test is predictable (this test would occasianlly fail on slower machines, when console.log doesn't run fast enough to finish after emitting `Runtime.consoleAPICalled` and before the parent process sending `Runtime.evaluate` message. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10287 PR-URL: https://github.com/nodejs/node/pull/32234 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10287 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Gabriel Schulhof

commit sha 25cb855b090c29eacebb78e4180c1f3678b7e86a

src: find .text section using dl_iterate_phdr Use `dl_iterate_phdr(3)` to find the mapping containing `__node_text_start` instead of parsing `/proc/self/maps`. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/32244 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Michael Dawson

commit sha e063ebd337b5723fb47e29c9c55fd333828473ca

n-api: fix comment on expected N-API version Remove the comment about the expected version so that it does not get out of sync. The code shows the expected version anyway. Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32236 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 40b559a376ae1db031132a86a76834decf6f0c2d

tools: update minimist@1.2.5 Update minimist used by lint-md.js to 1.2.5. Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764 Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32274 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 9b20b5db7b829dff0bcf0383c898c7fc85924369

stream: don't emit 'finish' after 'error' PR-URL: https://github.com/nodejs/node/pull/32275 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Sam Roberts

commit sha 8cbbc70fbc835fa82c9cfffdd89a5ee323533398

src,cli: support compact (one-line) JSON reports Multi-line JSON is more human readable, but harder for log aggregators to consume, they usually require a log message per line, particularly for JSON. Compact output will be consumable by aggregators such as EFK (Elastic Search-Fluentd-Kibana), LogDNA, DataDog, etc. PR-URL: https://github.com/nodejs/node/pull/32254 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Sam Roberts

commit sha 5eb85dd972b1b69aebf16d331df6761847a31b2a

deps,doc: move openssl maintenance guide to doc The maintainenance guides are mostly in doc/guides-maintaining-*.md, so move the OpenSSL one there, too. PR-URL: https://github.com/nodejs/node/pull/32209 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha c788964a75c7ccec63bce9d464e9c96eb6e17080

errors: drop pronouns from ERR_WORKER_PATH message This commit drops pronouns from the ERR_WORKER_PATH message, and also shortens the text a bit. PR-URL: https://github.com/nodejs/node/pull/32285 Refs: https://github.com/nodejs/node/pull/31664 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

himself65

commit sha 960df3fd90bcbf14d9fae44929a4c9e6a29a694d

src: handle NULL env scenario PR-URL: https://github.com/nodejs/node/pull/32230 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Rich Trott

commit sha 1a3c7473ec9ca0e1acf0512996e05eecc870f7bf

test: use Promise.all() in test-hash-seed We have several tests where a number of asynchronous processes need to finish before some checks happen. These are done in a number of ways, including (as here) using our Countdown testing module. I think Promise.all() may be the idiomatic and ergonomic way to go for a lot of these tests. Using this one to get feedback on the idea. PR-URL: https://github.com/nodejs/node/pull/32273 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Robert Nagy

commit sha a9270dcbeba4316b1e179b77ecb6c46af5aa8c20

http: don't emit 'finish' after 'error' PR-URL: https://github.com/nodejs/node/pull/32276 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Gus Caplan

commit sha 7a742ec050222dfabfa8fca07167a3b2c680fb3c

lib: add option to disable __proto__ Adds `--disable-proto` CLI option which can be set to `delete` or `throw`. Fixes #31951 PR-URL: https://github.com/nodejs/node/pull/32279 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>

view details

push time in 9 days

push eventjuanarbol/juanarbol.github.io

Juan José

commit sha 385c94f6274caf4dd66ca9d42bfbeca4bc678ed5

Update CNAME

view details

push time in 10 days

push eventjuanarbol/juanarbol.github.io

Juan José

commit sha 72aae133c1d4c7a950d6708e09e96a1cfcd9b05c

Update CNAME

view details

push time in 10 days

push eventjuanarbol/juanarbol.github.io

Juan José

commit sha f666983cf12d9c152d4c322670ed16e23743468c

Update CNAME

view details

push time in 10 days

Pull request review commentnodejs/node

lib: support MessagePort to workers data

 changes:     occur as described in the [HTML structured clone algorithm][], and an error     will be thrown if the object cannot be cloned (e.g. because it contains     `function`s).+  * `transferList` {Object[]} If you pass one or multiple `MessagePort`+    like objects in `workerData`, you will need to provide `transferList` for+    those items. Otherwise, [ERR_MISSING_MESSAGE_PORT_IN_TRANSFER_LIST][] will+    be thrown.

Get it.

So the final result will be:

  * `transferList` {Object[]} If one or more `MessagePort`-like objecst are passed in `workerData`, a `transferList` is required for those items or [ERR_MISSING_MESSAGE_PORT_IN_TRANSFER_LIST][] will be thrown.

Am I right?

juanarbol

comment created time in 11 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 21bc6fefaa3862a4d121406e923d965cfc9845a1

fixup

view details

push time in 13 days

Pull request review commentnodejs/node

lib: support MessagePort to workers data

+'use strict';++require('../common');+const assert = require('assert');++const {+  Worker, MessageChannel+} = require('worker_threads');++const channel = new MessageChannel();+const workerData = { mesage: channel.port1 };+const transferList = [channel.port1];+const meowScript = () => 'meow';++{+  new Worker(`${meowScript}`, { eval: true, workerData, transferList });+}++{+  // Should work with more than one MessagePort+  const channel1 = new MessageChannel();+  const channel2 = new MessageChannel();+  const workerData = { message: channel1.port1, message2: channel2.port1 };+  const transferList = [channel1.port1, channel2.port1];+  new Worker(`${meowScript}`, { eval: true, workerData, transferList });+}+

Nope, thanks for the the new test and semicolon is not required (make lint-js passed on my machine)

juanarbol

comment created time in 13 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 953fdfa4d25f1c45977c83f5decc886400ca44a9

fixup

view details

push time in 13 days

Pull request review commentnodejs/node

lib: support MessagePort to workers data

 class Worker extends EventEmitter {     this[kParentSideStdio] = { stdin, stdout, stderr };      const { port1, port2 } = new MessageChannel();+    const transferList = [port2];+    if (options.transferList) transferList.push(...options.transferList);

Improved! Thank you!!!

juanarbol

comment created time in 13 days

push eventjuanarbol/node

Juan José Arboleda

commit sha d223899e44777777f161b3f57068fd5a3295c3a5

fixup

view details

push time in 13 days

issue commentnodejs/node

HTTP2 Server Upgrade listener undocumented

Hey @jasnell, you may can answer this docs questions, I've seen the upgrade event documented here: https://nodejs.org/dist/latest-v12.x/docs/api/http.html#http_event_upgrade

najibghadri

comment created time in 13 days

PR opened nodejs/node

lib: support MessagePort to workers data

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Fixes: https://github.com/nodejs/node/issues/32250

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+42 -1

0 comment

3 changed files

pr created time in 13 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 1ed4c0ab2e29e481231734963678c694d5d01453

lib: support MessagePort to workers data

view details

push time in 13 days

push eventjuanarbol/node

Juan José Arboleda

commit sha be3980a6a2d09f941aeec72c0c41c9a71758e527

fixup

view details

push time in 13 days

push eventjuanarbol/node

Juan José Arboleda

commit sha e1aa7133e6750e296022e166c639ce20f0c70a26

lib: support MessagePort to workers data

view details

push time in 13 days

push eventjuanarbol/node

push time in 14 days

create barnchjuanarbol/node

branch : juanarbol/transfer-list-workers

created branch time in 14 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 32e0de448613e24a1d6fafe7aecf1e1541566926

WIP

view details

push time in 14 days

push eventjuanarbol/node

Brian White

commit sha 5cc0754090b4dc504652ea57803312c9b9f1cef0

benchmark: remove problematic tls params These very small values can cause crashes/exceptions to occur on some systems because most time is spent in V8 GC or in parts of node core that are not being tested (e.g. streams). PR-URL: https://github.com/nodejs/node/pull/31816 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha b6cd2155c3442a8c56aa6f6ffa0dc9b6a308a7b1

doc: remove em dashes Our documentation uses em dashes inconsistently. They are treated inconsistently typographically too. (For example, they are sometimes surrounded by spaces and sometimes not.) They are also often confused with ordinary hyphens such as in the CHANGELOG, where they are inadvertently mixed together in a single list. The difference is not obvious in the raw markdown but is very noticeable when rendered, appearing to be a typographical error (which it in fact is). The em dash is never needed. There are always alternatives. Remove em dashes entirely. PR-URL: https://github.com/nodejs/node/pull/32080 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

James M Snell

commit sha 434d39dd670845cafd122fadb0a75d72c1658b05

src,http2: introduce node_http_common The nghttp2 and nghttp3 (used in the QUIC implementation) share nearly identical structs for header handling. However, they differ enough that they need to be handled slightly different in each case. This PR includes some elements introduced in the QUIC PR separated out to make them independently reviewable, and updates the http2 implementation to use the shared utilities. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32069 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Andrey Pechkurov

commit sha 86ab4ee6e49681fb4a9603128af4f6fa29806183

async_hooks: fix ctx loss after nested ALS calls PR-URL: https://github.com/nodejs/node/pull/32085 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Luigi Pinca

commit sha 6f0ec79e42c07357fe33f353e65d76856d922582

http,stream: make virtual methods throw an error Make virtual methods throw an ERR_METHOD_NOT_IMPLEMENTED error instead of emitting it. The error is not recoverable and the only way to handle it is to override the method. PR-URL: https://github.com/nodejs/node/pull/31912 Refs: https://github.com/nodejs/node/pull/31818#pullrequestreview-359403469 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Alba Mendez

commit sha f69de13bfe1102ff53aa93d40045352441880704

fs: fix writeFile[Sync] for non-seekable files Completely disables the use of positioned writes at writeFile and writeFileSync, which allows it to work with non-seekable files. Fixes: https://github.com/nodejs/node/issues/31926 PR-URL: https://github.com/nodejs/node/pull/32006 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Robert Nagy

commit sha 960be159ac3b21bf8a4f8c3bca7e733d483fb7d9

stream: add comments to pipeline implementation Fixes: https://github.com/nodejs/node/issues/32039 PR-URL: https://github.com/nodejs/node/pull/32042 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

zfx

commit sha 1b3dbc9635d45c83e355d312b6114d58664b1e7a

events: fix removeListener for Symbols Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () => { }; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) => { console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn); }); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: https://github.com/nodejs/node/pull/31847 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 8700d89306cc4c1fd1a540d4b8f27a59f7b4957e

http: fix socket re-use races Whether and when a socket is destroyed or not after a timeout is up to the user. This leaves an edge case where a socket that has emitted 'timeout' might be re-used from the free pool. Even if destroy is called on the socket, it won't be removed from the freelist until 'close' which can happen several ticks later. Sockets are removed from the free list on the 'close' event. However, there is a delay between calling destroy() and 'close' being emitted. This means that it possible for a socket that has been destroyed to be re-used from the free list, causing unexpected failures. PR-URL: https://github.com/nodejs/node/pull/32000 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Jakob Kummerow

commit sha 654dbd001b797f9d38f3267edef0ef3e8110df21

test: update tests for larger Buffers V8 is about to increase the max TypedArray length to 2**32-1, which Node inherits as Buffer.kMaxLength. Some tests relied on values greater than the previous max length (2**31-1) to throw errors; this updates those tests for the new max length. PR-URL: https://github.com/nodejs/node/pull/32114 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

view details

Michaël Zasso

commit sha c49286ba8b3b8aeac1aa40abcc1da7bb4dd7cbf1

build: enable backtrace when V8 is built for PPC and S390x Refs: https://github.com/nodejs/node-v8/issues/119 PR-URL: https://github.com/nodejs/node/pull/32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Robert Nagy

commit sha 4d93e105bfad79ff6c6f01e4b7c2fdd70caeb43b

stream: don't destroy final readable stream in pipeline If the last stream in a pipeline is still usable/readable don't destroy it to allow further composition. Fixes: https://github.com/nodejs/node/issues/32105 PR-URL: https://github.com/nodejs/node/pull/32110 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha 6aff62fcb326bd3d51dbbcf91e63f6d2150488b3

wasi: add returnOnExit option This commit adds a WASI option allowing the __wasi_proc_exit() function to return an exit code instead of forcefully terminating the process. PR-URL: https://github.com/nodejs/node/pull/32101 Fixes: https://github.com/nodejs/node/issues/32093 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Rich Trott

commit sha 4c6ef4b7e28afb31228ce29bf3a20f94b90554dc

test: apply camelCase in test-net-reconnect-error Rename two idnetifiers that were snake_case rather than camelCase. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32120 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

Rich Trott

commit sha 1b35e8402f890a7b7c9b701a0d2f61cf39a0fc7c

test: remove superfluous checks in test-net-reconnect-error The process.on('exit', ...) checks duplicate the work of `common.mustCall()` and are superfluous. Remove them. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32120 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

Rich Trott

commit sha 5688eb8f83646a8c4896d5b81086377eb5092b3e

doc: fix broken links in benchmark README PR-URL: https://github.com/nodejs/node/pull/32121 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

cjihrig

commit sha aa3360f88a60e1bdda3af8a51b7534bb89983765

test: add WASI test for path_link() PR-URL: https://github.com/nodejs/node/pull/32132 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

cjihrig

commit sha 99e57259ecc15cdcd7fc73d454ff93ce36a94bcd

doc: document fs.watchFile() bigint option This commit documents the bigint option to fs.watchFile(), which has been supported since v10.5.0. PR-URL: https://github.com/nodejs/node/pull/32128 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

cjihrig

commit sha 3b8d70d924bee5126b1583fc3f1c4a8c70bce53b

src: fix -Winconsistent-missing-override warning ../src/node_http_common.h:497:8: warning: 'MemoryInfo' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void MemoryInfo(MemoryTracker* tracker) const { PR-URL: https://github.com/nodejs/node/pull/32126 Refs: https://github.com/nodejs/node/pull/32069 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

cjihrig

commit sha 7bb4f95c1cdf860082a27e2592488c2ba6734c20

src: fix -Wreorder compiler warning ../src/node_http_common-inl.h:126:7: warning: field 'token_' will be initialized after field 'name_' [-Wreorder] : token_(other.token_), PR-URL: https://github.com/nodejs/node/pull/32126 Refs: https://github.com/nodejs/node/pull/32069 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

push time in 14 days

PR closed nodejs/node

lib: add debug logs to writable stream stream

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+10 -0

4 comments

1 changed file

juanarbol

pr closed time in 14 days

pull request commentnodejs/node

lib: add debug logs to writable stream

Move it to #32255! Thanks for contributing @YoDaMa

juanarbol

comment created time in 14 days

issue commentnodejs/node

Multiple Identical ExperimentalWarnings

As long as #31845 is landed now, I think this issue could be closed.

LJNeon

comment created time in 15 days

issue commentnodejs/node

Worker Threads: Add transferList to Worker constructor options

can I work on this one?

sinclairzx81

comment created time in 15 days

pull request commentnodejs/node

src: deprecate errname method at runtime

Comment fixed now, sorry fot the delay

juanarbol

comment created time in 15 days

push eventjuanarbol/node

Juan José Arboleda

commit sha a6937f2d5ff95a6b835bfe6cfa5c38665baf931d

FIXUP

view details

push time in 15 days

pull request commentnodejs/node

lib: add debug logs to writable stream

Sorry, I'm gonna return to this soon

juanarbol

comment created time in 15 days

pull request commentnodejs/node

support maxConnections event on net server

ping @Trott

juanarbol

comment created time in 15 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 373eb4c4c9f1f53075d95c46dc1c1f6c55dcedaf

src: create a getter for kernel version

view details

push time in 18 days

push eventjuanarbol/node

Harshitha KP

commit sha 31e4a0d7ace1621b9f3bcb94f8e1da7de9aea67d

src: Handle bad callback in asyc_wrap Align with the MaybeLocal<> API contract PR-URL: https://github.com/nodejs/node/pull/31946 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 89987b3a9f253f10d0edcf0100d23628a69a30cb

test: remove common.expectsInternalAssertion Remove convenience function for internal assertions. It is only used once. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Rich Trott

commit sha 83e9a3ea59123d2d13f0884ba8c5f2c9f338f0d2

test: add coverage for FSWatcher exception Cover an previously uncovered exception possible in the internal start function for FSWatcher. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Ben Noordhuis

commit sha a727b133438f8e76febf68f4c6d73414b7945f13

crypto: make update(buf, enc) ignore encoding Make the cipher/decipher/hash/hmac update() methods ignore the input encoding when the input is a buffer. This is the documented behavior but some inputs were rejected, notably when the specified encoding is 'hex' and the buffer has an odd length (because a _string_ with an odd length is never a valid hex string.) The sign/verify update() methods work okay because they use different validation logic. Fixes: https://github.com/nodejs/node/issues/31751 PR-URL: https://github.com/nodejs/node/pull/31766 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

James M Snell

commit sha 4ac1ce1071ede979956ab4654d40d31291b99f3d

src: introduce node_sockaddr Introduce the SocketAddress utility class. The QUIC implementation makes extensive use of this for handling of socket addresses. It was separated out to make it generically reusable throughout core Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32070 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Yael Hermon

commit sha 5f12595e00772da0c1a4877c7a3c65b5f26374c7

doc: update email address in authors update my personal email PR-URL: https://github.com/nodejs/node/pull/32026 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha c0ba6ec5603b6415300e06b6959b04d8cb0ab229

meta: move thefourtheye to TSC Emeritus thefourtheye has a considerable history of contributions to Node.js. They have not been active much of late, and the TSC Charter has a section about activity indicating that moving to Emeritus at this time is the thing to do. Thanks for all you've done to make Node.js fantastic, thefourtheye, and hope to see you around again soon! PR-URL: https://github.com/nodejs/node/pull/32059 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

view details

Brian White

commit sha 31ec44302a8367103f274e193dd4573b363f88d8

benchmark: remove problematic tls params These very small values can cause crashes/exceptions to occur on some systems because most time is spent in V8 GC or in parts of node core that are not being tested (e.g. streams). PR-URL: https://github.com/nodejs/node/pull/31816 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 50094de274309b417cfdd4b1b3bdb550a6b60594

doc: remove em dashes Our documentation uses em dashes inconsistently. They are treated inconsistently typographically too. (For example, they are sometimes surrounded by spaces and sometimes not.) They are also often confused with ordinary hyphens such as in the CHANGELOG, where they are inadvertently mixed together in a single list. The difference is not obvious in the raw markdown but is very noticeable when rendered, appearing to be a typographical error (which it in fact is). The em dash is never needed. There are always alternatives. Remove em dashes entirely. PR-URL: https://github.com/nodejs/node/pull/32080 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

James M Snell

commit sha a03777096ea495821f1c234c947fd52b4cdba50c

src,http2: introduce node_http_common The nghttp2 and nghttp3 (used in the QUIC implementation) share nearly identical structs for header handling. However, they differ enough that they need to be handled slightly different in each case. This PR includes some elements introduced in the QUIC PR separated out to make them independently reviewable, and updates the http2 implementation to use the shared utilities. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32069 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Andrey Pechkurov

commit sha 3befe80c4fa864fbef445dc8eee7b81f22b184de

async_hooks: fix ctx loss after nested ALS calls PR-URL: https://github.com/nodejs/node/pull/32085 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Robert Nagy

commit sha 2585b814b0da4895b156e486351fa740910068b7

stream: add comments to pipeline implementation Fixes: https://github.com/nodejs/node/issues/32039 PR-URL: https://github.com/nodejs/node/pull/32042 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

zfx

commit sha 55486bceb977fcc46a6d80431fe14b016b9c3c9a

events: fix removeListener for Symbols Fix removeListener when eventName type is 'symbol'. ```js const EventEmitter = require('events'); const myEmitter = new EventEmitter(); const sym = Symbol('symbol'); const fn = () => { }; myEmitter.on(sym, fn); myEmitter.on('removeListener', (...args) => { console.log('removeListener'); console.log(args, args[0] === sym, args[1] === fn); }); myEmitter.removeAllListeners() ``` When the listener's eventName type is 'symbol' and removeListener is called with no parameters, removeListener should be emitted. PR-URL: https://github.com/nodejs/node/pull/31847 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 1ffa9f388fbd4d732c9d91a0696225e65ba68fe9

http: fix socket re-use races Whether and when a socket is destroyed or not after a timeout is up to the user. This leaves an edge case where a socket that has emitted 'timeout' might be re-used from the free pool. Even if destroy is called on the socket, it won't be removed from the freelist until 'close' which can happen several ticks later. Sockets are removed from the free list on the 'close' event. However, there is a delay between calling destroy() and 'close' being emitted. This means that it possible for a socket that has been destroyed to be re-used from the free list, causing unexpected failures. PR-URL: https://github.com/nodejs/node/pull/32000 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Jakob Kummerow

commit sha 8e435687bb6507ade9fdd5bc1b555896d0aa5b30

test: update tests for larger Buffers V8 is about to increase the max TypedArray length to 2**32-1, which Node inherits as Buffer.kMaxLength. Some tests relied on values greater than the previous max length (2**31-1) to throw errors; this updates those tests for the new max length. PR-URL: https://github.com/nodejs/node/pull/32114 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

view details

Michaël Zasso

commit sha 7c739aa3869c936b4efd87d96e157e55e9588c25

build: enable backtrace when V8 is built for PPC and S390x Refs: https://github.com/nodejs/node-v8/issues/119 PR-URL: https://github.com/nodejs/node/pull/32113 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

cjihrig

commit sha dd83bd266dfb0c0e426565bf427678daa5b96e1e

wasi: add returnOnExit option This commit adds a WASI option allowing the __wasi_proc_exit() function to return an exit code instead of forcefully terminating the process. PR-URL: https://github.com/nodejs/node/pull/32101 Fixes: https://github.com/nodejs/node/issues/32093 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Rich Trott

commit sha 74edcc5dd9ffce381236e183a92b249661d20f5a

test: apply camelCase in test-net-reconnect-error Rename two idnetifiers that were snake_case rather than camelCase. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32120 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

Rich Trott

commit sha da7349d9084b4a5e59b2423b211b456aff58af7d

test: remove superfluous checks in test-net-reconnect-error The process.on('exit', ...) checks duplicate the work of `common.mustCall()` and are superfluous. Remove them. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32120 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

Rich Trott

commit sha 2e5f81f69c637e4e9e3c004e886fbdd35d9e6af3

doc: fix broken links in benchmark README PR-URL: https://github.com/nodejs/node/pull/32121 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 18 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 34a13d0cb10ded1aca86f8ab7dbe0579ef8efc6e

fixup

view details

push time in 18 days

create barnchjuanarbol/node

branch : juanarbol/os-kernel-version

created branch time in 18 days

PR opened nodejs/node

[backport v13.x] src: create a getter for kernel version

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> Ref: https://github.com/nodejs/node/pull/31732

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+27 -26

0 comment

3 changed files

pr created time in 18 days

pull request commentnodejs/node

src: create a getter for kernel version

MEEEEEEE ME ME ME ME ME MEEEEEEE, I want to

juanarbol

comment created time in 18 days

pull request commentnodejs/node

doc: fix os.version() Windows API

Honestly, I don't think Node should be calling out these implementation details. If anything, I'd direct users to the libuv docs. Not because the libuv docs are particularly good, but because Node uses libuv directly, and if implementation changes are made in libuv, the docs there are more likely to get updated properly.

Yeah, I think you're right.

I'm +1 on this.

cjihrig

comment created time in 19 days

pull request commentnodejs/node

doc: fix os.version() Windows API

I suggest adding the RtlGetVersion() also on os.release() docs, as long as is basically doing the same, if RtlGetVersion() is not available the fallback is GetVersionExW()

cjihrig

comment created time in 19 days

pull request commentnodejs/node

doc: fix os.version() Windows API

You're completely rigth.

cjihrig

comment created time in 19 days

push eventjuanarbol/node

Rich Trott

commit sha 9ac42f1be42f162ec9cf6bb56e817d7b210a6db9

test: remove common.port from test-tls-securepair-client OpenSSL s_server accepts port 0 as an indicator to use an open port provided by the operating system. Use that instead of common.PORT in the test. Remove 500ms delay added in 8e461673c44cb550a7aadc20f0af6453810f1b18. Hopefully the race condition in OpenSSL s_server has been fixed and/or the change to port 0 means that the server is listening by the time the ACCEPT text is printed and the setTimeout() is no longer necessary. PR-URL: https://github.com/nodejs/node/pull/32024 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Rich Trott

commit sha 5e1f059db4f8b324ef4448e0fbdc5dc7fc6c57d8

test: move test-inspector-module to parallel test-inspector-module is very fast and seems to be runnable at the same time as other tests. Move from sequential directory to parallel. PR-URL: https://github.com/nodejs/node/pull/32025 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Gerhard Stoebich

commit sha ed8007af0bc8fd4fa575217b50e8ca611a7e8679

events: convert errorMonitor to a normal property Convert property errorMonitor to a normal property as non-writable caused unwanted side effects. Refs: https://github.com/nodejs/node/pull/30932#discussion_r379679982 PR-URL: https://github.com/nodejs/node/pull/31848 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Andrey Pechkurov

commit sha 96e70c4ce786f43de16a0267a92ee73abf218356

test: add GC test for disabled AsyncLocalStorage PR-URL: https://github.com/nodejs/node/pull/31995 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

James M Snell

commit sha dd8183632d4bc8929371ee4676ef9bb5c95f7aaa

src: add node_crypto_common and refactor Two things in one on this commit: (a) For the QUIC implementation, we need to separate out various bits from node_crypto.cc to allow them to be reused. That's where this commit starts. (b) Quite a bit of the node_crypto.cc code was just messy in terms of it's organization and lack of error handling and use of Local vs. MaybeLocal. This cleans that up a bit and hopefully makes certain parts a bit more manageable also. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32016 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Gabriel Schulhof

commit sha 987a67339518d0380177a2e589f2bbd274230d0e

src: start the .text section with an asm symbol We create an object file in assembly which introduces the symbol `__node_text_start` into the .text section and place the resulting object file as the first file the linker encounters. We do this to ensure that we can recognize the boundaries of the .text section when attempting to establish the address range to map to large pages. Additionally, we rename the section containing the remapping code from `.lpstub` to `lpstub` so as to take advantage of the linker's feature whereby it inserts the symbol `__start_lpstub` when the section's name can be rendered as a valid C variable. We need this symbol in order to avoid self-mapping the remapping code to large pages, because doing so would cause the process to crash. PR-URL: https://github.com/nodejs/node/pull/31981 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

gengjiawen

commit sha 3ec4b21b1c438255df6f1652377011080dc28052

build: add asan check in Github action PR-URL: https://github.com/nodejs/node/pull/31902 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Robert Nagy

commit sha 7cafd5f3a924451294a4f2ce6efb628b53fce7eb

stream: fix finished w/ 'close' before 'end' Emitting 'close' before 'end' on a Readable should result in a premature close error. PR-URL: https://github.com/nodejs/node/pull/31545 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 43b7142fedc706d79ea77254bc463f63a3b73358

dgram: make UDPWrap more reusable Allow using the handle more directly for I/O in other parts of the codebase. Originally landed in the QUIC repo Original review metadata: ``` PR-URL: https://github.com/nodejs/quic/pull/165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> ``` Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/31871 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

view details

Robert Nagy

commit sha 8429295c5b2bf3eb52a5b57eaceaffc3158a0c4a

stream: eos make const state const writable & readable is based on type and is not actual state, treat them as such. PR-URL: https://github.com/nodejs/node/pull/32031 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Richard Lau

commit sha de6cbd0e374e3d9209ddf56d1041b83b41efcbe6

build: fix building with ninja The ninja build places objects in a different directory. Co-authored-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32071 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

ConorDavenport

commit sha bf7409e9740ce602b09e088aac70b7c817f5d27c

doc: improve doc/markdown file organization coherence * Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the file. * Moved files to appropriate location and updated naming style for some of them. Fixes: https://github.com/nodejs/node/issues/31741 PR-URL: https://github.com/nodejs/node/pull/31792 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Harshitha KP

commit sha 37287d3f5819daabade7b8ade81c4265bd596edf

doc: visibility of Worker threads cli options Fixes: https://github.com/nodejs/node/issues/28518 PR-URL: https://github.com/nodejs/node/pull/31380 Fixes: https://github.com/nodejs/node/issues/28518 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Shelley Vohr

commit sha 75466869fb6e1dd09b36dc2b44ef8748ecc6e7de

2020-03-04 Version 13.10.0 (Current) Notable changes: * async_hooks * introduce async-context API (vdeturckheim) #26540 * stream * support passing generator functions into pipeline() (Robert Nagy) #31223 * tls * expose SSL\_export\_keying\_material (simon) #31814 * vm * implement vm.measureMemory() for per-context memory measurement (Joyee Cheung) #31824 PR-URL: https://github.com/nodejs/node/pull/32027

view details

Shelley Vohr

commit sha 213047489002d3f7f7a8cc8a12d64ecf99723b82

build: fix zlib tarball generation PR-URL: https://github.com/nodejs/node/pull/32094 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha 787143bf3e3a96bed9da17c453c8f77e016fd1b1

src: pass resource object along with InternalMakeCallback This was an oversight in 9fdb6e6aaf45b2364bac89a. Fixing this is necessary to make `executionAsyncResource()` work as expected. Refs: https://github.com/nodejs/node/pull/30959 Fixes: https://github.com/nodejs/node/issues/32060 PR-URL: https://github.com/nodejs/node/pull/32063 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Myles Borins

commit sha 67d45fb298158f47974a41d821c25dec26bbd40a

2020-03-04 Version 13.10.1 (Current) Notable changes: In Node.js 13.9.0 deps/zlib was switched to the chromium maintained implementation. This change had the unforseen consequence of breaking building from the tarballs we release as we were too aggressively removing `unneccessary files` from the `deps/zlib` folder. This release includes a patch that ensures that individuals will once again be able to build Node.js from source. PR-URL: https://github.com/nodejs/node/pull/32099

view details

João Reis

commit sha cb8898c48feac55ef49b1594d7a4131e827c213e

win: block running on EOL Windows versions Windows 7 and Windows Server 2008 R2 EOL was January 14, 2020. Windows 8 EOL was January 12, 2016. Windows 2012 (not R2) is still supported and allowed to run. This clarifies that support is experimental. PR-URL: https://github.com/nodejs/node/pull/31954 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Harshitha KP

commit sha 757e2037e74fecca521c664fc8486596b306de39

src: Handle bad callback in asyc_wrap Align with the MaybeLocal<> API contract PR-URL: https://github.com/nodejs/node/pull/31946 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 616a729b3837c6152da6bb7f7c06aecbbdaa2696

test: remove common.expectsInternalAssertion Remove convenience function for internal assertions. It is only used once. Signed-off-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32057 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

push time in 23 days

pull request commentnodejs/node

src: create a getter for kernel version

Is this a semver-minor thing?

juanarbol

comment created time in 24 days

Pull request review commentnodejs/node

src: create a getter for kernel version

 const home = os.homedir(); is.string(home); assert.ok(home.includes(path.sep)); +const version = os.version();+assert.strictEqual(typeof version, 'string');

Sure!

juanarbol

comment created time in 25 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 03f66819bd52dd1773fb46ba75882577a634dafa

fixup

view details

push time in 25 days

push eventjuanarbol/node

Juan José Arboleda

commit sha 6789e0b6d41d15fe2a6537a69c09058636226b34

fixup

view details

push time in a month

PR closed nodejs/node

lib: add ERR_ESM_INVALID_JSON_MODULE ES Modules errors

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

cc @BridgeAR

+11 -7

1 comment

3 changed files

juanarbol

pr closed time in a month

PR closed nodejs/node

test: remove deprecated connections net attribute test work in progress (WIP)

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

This may fixes #31168

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+38 -14

8 comments

1 changed file

juanarbol

pr closed time in a month

PR closed nodejs/node

src,lib: remove internal emitwarning C++

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+18 -35

9 comments

5 changed files

juanarbol

pr closed time in a month

pull request commentnodejs/node

src,lib: remove internal emitwarning

Closing

juanarbol

comment created time in a month

PR closed nodejs/quic

updateKey() should throws if not TLS Handshake

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

Note: this test is unstable, sometimes it's passes, sometimes doesn't, seems that handshake is completed before excepcion is handled, I've tried setInmediate and process.nextTick, did not work; so I'd love to receive some suggestions or opinions.

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+80097 -2256

6 comments

471 changed files

juanarbol

pr closed time in a month

pull request commentnodejs/quic

updateKey() should throws if not TLS Handshake

Closing

juanarbol

comment created time in a month

PR closed nodejs/node

WIP Make CJS suggestions when file ext is not provided module work in progress (WIP)

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included <!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+37 -4

11 comments

4 changed files

juanarbol

pr closed time in a month

pull request commentnodejs/node

WIP Make CJS suggestions when file ext is not provided

I'll close this, and spend some time to understand the new loader then open another PR; sorry

juanarbol

comment created time in a month

push eventjuanarbol/node

James M Snell

commit sha cbaae7a2f811e57860f560df5cb8fc308f6d70b3

doc: clarify http2.connect authority details Fixes: https://github.com/nodejs/node/issues/31827 PR-URL: https://github.com/nodejs/node/pull/31828 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Signed-off-by: James M Snell <jasnell@gmail.com>

view details

James M Snell

commit sha c6ed01cf6d0d54f8de862fd41413e5cbac2a8ba4

doc: update zlib doc Just some general improvements to zlib docs and examples Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/31665 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Shelley Vohr

commit sha 20a51b9dff69c3cc9c38e1e57c389db16ea02807

repl: eager-evaluate input in parens PR-URL: https://github.com/nodejs/node/pull/31943 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Denys Otrishko

commit sha 468bfd3487c5fba678bb6455add59e774ffbcd82

test: increase timeout in vm-timeout-escape-queuemicrotask It looks like under high load the loop isn't even started and therefore successfully finishes without 'escaping'. After increasing the timeout during parallel run of the test failure rate decreased from 15/1000 to 0/1000. PR-URL: https://github.com/nodejs/node/pull/31966 Refs: https://github.com/nodejs/node/issues/25529 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha 2ec9b58a4107bb915ada2e4fdf01cb41e9dff67c

test: fix usage of invalid common properties PR-URL: https://github.com/nodejs/node/pull/31933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Denys Otrishko

commit sha 5c86475e201709ea2e15b3002c547abfbd3e823b

test: validate common property usage `common` contains multiple 'check'(boolean) properties that will be false if mistyped and may lead to errors. This makes sure that the used property exists in the `common`. PR-URL: https://github.com/nodejs/node/pull/31933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

cjihrig

commit sha a29b6cd921fddeaed07b3a68b4c4f75a26b3e61f

build: add missing comma in node.gyp This commit adds a missing comma for consistency with the surrounding lines. PR-URL: https://github.com/nodejs/node/pull/31959 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

view details

Shelley Vohr

commit sha 18ddb1da38ad6eb78c357f182b5379a8ab3332ce

src: move InternalCallbackScope to StartExecution PR-URL: https://github.com/nodejs/node/pull/31944 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Andrey Pechkurov

commit sha 6510a741c4ed04288d56486a1384b1fbecd08eaf

async_hooks: add store arg in AsyncLocalStorage This commit introduces store as the first argument in AsyncLocalStorage's run methods. The change is motivated by the following expectation: most users are going to use a custom object as the store and an extra Map created by the previous implementation is an overhead for their use case. Important note. This is a backwards incompatible change. It was discussed and agreed an incompatible change is ok since the API is still experimental and the modified methods were only added within the last week so usage will be minimal to none. PR-URL: https://github.com/nodejs/node/pull/31930 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Shelley Vohr

commit sha 65e18a8e9f912dfa04a804124b6a19514bb45165

src: don't run bootstrapper in CreateEnvironment PR-URL: https://github.com/nodejs/node/pull/31910 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Luigi Pinca

commit sha a777cfa843d5b996e45c4f8188733b637594378b

doc: remove repetition Merge two similar sentences into one. PR-URL: https://github.com/nodejs/node/pull/31868 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

bcoe

commit sha fb26b136238240eeac1b3ede098e097a343aef0b

module: port source map sort logic from chromium Digging in to the delta between V8's source map library, and chromium's the most significant difference that jumped out at me was that we were failing to sort generated columns. Since negative offsets are not restricted in the spec, this can lead to bugs. fixes: #31286 PR-URL: https://github.com/nodejs/node/pull/31927 Fixes: https://github.com/nodejs/node/issues/31286 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 1b2e2944bc069abd1dd7cbf90d3badad4289235d

dgram: don't hide implicit bind errors When dgram socket implicit binding fails, an attempt is made to clean up the send queue. This was originally implemented using an 'error' handler that performed cleanup and then emitted a fake error, which concealed the original error. This was done to prevent cases where the same error was emitted twice. Now that the errorMonitor event is available, use that to perform the cleanup without impacting the actual error handling. PR-URL: https://github.com/nodejs/node/pull/31958 Refs: https://github.com/nodejs/help/issues/2484 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha 331d63624007be4bf49d6d161bdef2b5e540affa

errors: remove unused ERR_SOCKET_CANNOT_SEND error This error is no longer used within core. This commit removes it. PR-URL: https://github.com/nodejs/node/pull/31958 Refs: https://github.com/nodejs/help/issues/2484 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Matheus Marchini

commit sha 3d894d0511bc76c2bd886077d1cb434d878527de

deps: V8: backport f7771e5b0cc4 Original commit message: [runtime] Recompute enumeration indices of dictionaries upon bitfield overflow Otherwise we'll get weird semantics when enumerating objects after many deletes/reinserts. Bug: chromium:1033771 Change-Id: If0a459169c3794a30d9632d09e80da3cfcd4302c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993966 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65690} Refs: https://github.com/v8/v8/commit/f7771e5b0cc46ab75fe5291482a727b3f115dcba PR-URL: https://github.com/nodejs/node/pull/31957 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Rusty Conover

commit sha 2b16c13f79972b16b574e795b04119a55c1fba89

test: remove sequential/test-https-keep-alive-large-write.js Remove a test that made a flawed assumption that a single large buffer write can be interrupted by a timeout event. PR-URL: https://github.com/nodejs/node/pull/31499 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rusty Conover

commit sha 35f491b2e89232e28603b5ad4400353e9338beb4

test: change test to not be sensitive to buffer send size Change the test to not be sensitive to the buffer size causing TCP resets to be received by the client causing the test to fail. The test now reads the entire expected buffer and then checks for the expected event to fire. PR-URL: https://github.com/nodejs/node/pull/31499 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rusty Conover

commit sha 8b1efe0306c4c0ed35a271cfa9ea00033b75c6c2

tls: reduce memory copying and number of BIO buffer allocations Avoid copying buffers before passing to SSL_write if there are zero length buffers involved. Only copy the data when the buffer has a non zero length. Send a memory allocation hint to the crypto BIO about how much memory will likely be needed to be allocated by the next call to SSL_write. This makes a single allocation rather than the BIO allocating a buffer for each 16k TLS segment written. This solves a problem with large buffers written over TLS triggering V8's GC. PR-URL: https://github.com/nodejs/node/pull/31499 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 311e12b96201c01d6c66c800d8cfc59ebf9bc4ae

stream: fix multiple destroy calls Previously destroy could be called multiple times causing inconsistent and hard to predict behavior. Furthermore, since the stream _destroy implementation can only be called once, the behavior of applying destroy multiple times becomes unclear. This changes so that only the first destroy() call is executed and any subsequent calls are noops. PR-URL: https://github.com/nodejs/node/pull/29197 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Tobias Nießen

commit sha 46b92c854deeca6cb0d1b3d473f7f006b3f59639

crypto: turn impossible DH errors into assertions PR-URL: https://github.com/nodejs/node/pull/31934 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a month

issue closedlibuv/libuv

Hi

<!-- If you want to report a bug, you are in the right place!

If you need help or have a question, go here: https://github.com/libuv/help/issues/new

If you are reporting a libuv test failure, please ensure that you are not running the test as root.

Please include code that demonstrates the bug and keep it short and simple. -->

  • Version: <!-- libuv version -->
  • Platform: <!-- uname -a (UNIX), or Windows version and machine type -->

6e9b4849-bad2-4017-883e-08be1f1dc2ea

A friend of mine did this, unfortunately she's not on GitHub, but you could find her on twitter as @ritmicoazul

closed time in a month

juanarbol

fork juanarbol/learning-v8

Project for learning V8 internals

fork in a month

push eventjuanarbol/async

Juan José

commit sha 2f329d082c8bdd0d92603574d8fafcd24f1a8533

fix(docs): fix code example in whilst docs (#1703)

view details

Alexander Early

commit sha 686443ea93179ddaccb96b6dcb11c7ebe38d34d4

improve intro docs around async functions

view details

Alexander Early

commit sha 08f1b4deb383ab6bfd2c27214f21c4a5b1481a71

regenerate docs

view details

Alexander Early

commit sha 01f88c98fc8088cf252f1f1a6cc9e135c895fa71

fix error in docs

view details

Alexander Early

commit sha 16d3c56722456bb890ec086aa8602783a2ed3fea

fix until example. Closes #1688

view details

Alexander Early

commit sha d13a5894dd35bf14e5c492eefb2b843e04e6b208

regen docs

view details

Alexander Early

commit sha 8141ac011ee1c73c0e4f1eacfdc43a29a7b61b41

fix cargoQueue return type. Closes #1704

view details

Alexander Early

commit sha a7b030dfd2f2d6bc7b8e3e9998a39e7aaa13e829

regen docs

view details

Alexander Early

commit sha 6919fa0258599bf354224ffb17f9d4ff11e0dc49

remove browserify configuration. Closes #1653

view details

Alexander Early

commit sha f4d19c7714b7fd4f54aa18b8595bc869e6028400

remove redundant npm test in xyz

view details

Alexander Early

commit sha 9204af17d92b5a92d301a05df47a65979bed8835

remove setting asyncFn.name to fix a safari bug

view details

Alexander Early

commit sha 0e4087b3c28a25152327594f8932277169b7ad43

update changelog

view details

Alexander Early

commit sha 2130a8245338a6e8e53a269aa3b48e1c8f8a54a3

fix tests related to wrapped function names

view details

Alexander Early

commit sha ea7365a9f175a894a006cea7052734572097f219

Update built files

view details

Alexander Early

commit sha 98ccc7ca57de64430ed69400e512a27a23e3f96e

Version 3.2.0

view details

Alexander Early

commit sha 41a00c57d335318f2867f91d5b9fdecfcbe12ea4

regen docs

view details

Alexander Early

commit sha 4e23a9d9a74d422a7f5c3b01ba11f4e431e9a3bf

update test matrixes

view details

Juan José Arboleda

commit sha df87030f1405d40533c15669adcb46fed4c9a885

Fix code until code example

view details

push time in a month

push eventjuanarbol/async

Juan José Arboleda

commit sha fe07c1c17a2d04cd0a7814c042eb3f1833b559b6

Fix code until code example

view details

push time in a month

PR opened caolan/async

Fix code until code example
+1 -1

0 comment

1 changed file

pr created time in a month

create barnchjuanarbol/async

branch : juanarbol/until-example-fix

created branch time in a month

Pull request review commentnodejs/node

lib: add debug logs to writable stream

 function endWritable(stream, state, cb) {   }   state.ended = true;   stream.writable = false;+  debug('endWritable', state.ended);

Get it!

juanarbol

comment created time in a month

Pull request review commentnodejs/node

lib: add debug logs to writable stream

 function writeOrBuffer(stream, state, chunk, encoding, cb) { }  function doWrite(stream, state, writev, len, chunk, encoding, cb) {+  debug('Writting');

Thank you sr, fixing this!

juanarbol

comment created time in a month

push eventjuanarbol/node

Rich Trott

commit sha 24aa9bda4636741e52002c9e9cbf5e0042349b8d

doc: updated YAML version representation in readline.md All other versions in YAML throughout the docs start with _v_. Fix two cases in `readline.md` that did not. PR-URL: https://github.com/nodejs/node/pull/31924 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha fb7304503f8503597d630855461cab34836897ba

vm: implement vm.measureMemory() for per-context memory measurement This patch implements `vm.measureMemory()` with the new `v8::Isolate::MeasureMemory()` API to measure per-context memory usage. This should be experimental, since detailed memory measurement requires further integration with the V8 API that should be available in a future V8 update. PR-URL: https://github.com/nodejs/node/pull/31824 Refs: https://github.com/ulan/performance-measure-memory Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Gerhard Stoebich

commit sha fd3d02ac32660dfe5edcfa7592576da68780f7e2

async_hooks: executionAsyncResource matches in hooks Ensure that resource returned by executionAsyncResource() in before and after hook matches that resource causing this before/after calls. PR-URL: https://github.com/nodejs/node/pull/31821 Refs: https://github.com/nodejs/node/pull/30959 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>

view details

Sam Roberts

commit sha 24a4f76709bd9edc8d86e9f3fb4d5e3c7d4c3d69

test: mark empty udp tests flaky on OS X They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: https://github.com/nodejs/node/issues/30030 Refs: https://github.com/nodejs/build/pull/2189#issuecomment-589767606 PR-URL: https://github.com/nodejs/node/pull/31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

view details

Rich Trott

commit sha 54eb7e61032f7871d5384db6bd6ece73514622ac

meta: move not-an-aardvark to emeritus not-an-aardvark confirmed in email that it's probably time for him to move to emeritus. PR-URL: https://github.com/nodejs/node/pull/31928 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha fc68bf22a9525def6b10f2a03a59e80723f7ea85

test: fix typo in common/index.js All tests using enoughTestCpu checks are always having the checks come back false due to a typo in common/index.js. Fix the typo. PR-URL: https://github.com/nodejs/node/pull/31931 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 8824229787dd7e28c14bdb6e5f3dcb8dd5ed813d

test: add documentation for common.enoughTestCpu PR-URL: https://github.com/nodejs/node/pull/31931 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Guy Bedford

commit sha 49ad16104fb467e5e76049950830b15f4793bc7c

module: disable conditional exports, self resolve warnings PR-URL: https://github.com/nodejs/node/pull/31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

Robert Nagy

commit sha b2be348fcce7efd30f88b9fabbb2e9629b534e20

stream: ensure pipeline always destroys streams There was an edge case where an incorrect assumption was made in regardos whether eos/finished means that the stream is actually destroyed or not. PR-URL: https://github.com/nodejs/node/pull/31940 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha b44c63b87e6c165844f7303a9ec6f8c0cce7d3dc

src: enable `StreamPipe` for generic `StreamBase`s Originally landed in the nodejs/quic repo and used there for file sending. Original review: ``` PR-URL: https://github.com/nodejs/quic/pull/150 Reviewed-By: James M Snell <jasnell@gmail.com> ``` PR-URL: https://github.com/nodejs/node/pull/31869 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

view details

push time in a month

PR opened nodejs/node

build: remove empty line on node.gyp file

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+0 -1

0 comment

1 changed file

pr created time in a month

create barnchjuanarbol/node

branch : juanarbol/empty-line

created branch time in a month

push eventjuanarbol/node

Gabriel Schulhof

commit sha 0dff851336ea2a3801667e5390d5821db746baae

src: include large pages source unconditionally Restrict the usage of the C preprocessor directive enabling large pages support to the large pages implementation. This cleans up the code in src/node.cc. PR-URL: https://github.com/nodejs/node/pull/31904 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Daniel Bevenius

commit sha 940325042bef787e84917a27f9435d423b3f7f6d

test: add secp224k1 check in crypto-dh-stateless This commit adds a check to test-crypto-dh-statless to avoid an error if the curve secp224k1 is not present. This could occur if node was configured with shared-openssl. The use case for this was building on RHEL 8.1 which only has the following curves: $ openssl ecparam -list_curves secp224r1 : NIST/SECG curve over a 224 bit prime field secp256k1 : SECG curve over a 256 bit prime field secp384r1 : NIST/SECG curve over a 384 bit prime field secp521r1 : NIST/SECG curve over a 521 bit prime field prime256v1: X9.62/SECG curve over a 256 bit prime field PR-URL: https://github.com/nodejs/node/pull/31715 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 1f209129c7e6c3ec6628809821fc9a36deae7ec8

stream: throw invalid argument errors Logic errors that do not depend on stream state should throw instead of invoke callback and emit error. PR-URL: https://github.com/nodejs/node/pull/31831 Refs: https://github.com/nodejs/node/pull/31818 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Joyee Cheung

commit sha 914d800a23f1c7877770d62bd4061957c402c8ca

tools: add NODE_TEST_NO_INTERNET to the doc builder At the moment the doc builder tries to access the internet for CHANGELOG information and only falls back to local sources after the connection fails or a 5 second timeout. This means that the doc building could take at least 7 minutes on a machine with hijacked connection to Github for useless network attempts. This patch adds a NODE_TEST_NO_INTERNET environment variable to directly bypass these attempts so that docs can be built in reasonable time on a machine like that. PR-URL: https://github.com/nodejs/node/pull/31849 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in a month

issue commentnodejs/node

add debug logs to _stream_writable

I've sent the first proposal:

https://github.com/nodejs/node/pull/31937

YoDaMa

comment created time in a month

push eventjuanarbol/node

Robert Nagy

commit sha 85c6fcd1cd11ec6ee22891e48a67cc97f60880e8

stream: avoid writing to writable A remainder from a previous refactoring. Refs: https://github.com/nodejs/node/pull/31197 PR-URL: https://github.com/nodejs/node/pull/31805 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 99428e0858bb3cce820190770ca8217460d95c80

doc: reword possessive form of Node.js in debugger.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha d40c648e884bd64028fa0a67122a0af87c60f467

doc: reword possessive form of Node.js in process.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha d25fcb0c201286d18c07653347258ce02951ddf8

doc: reword possessive form of Node.js in http.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha eb0ade10a7af855ecdaa822dea028d661664cd43

doc: reword possessive form of Node.js in adding-new-napi-api.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha fab3eff2e53eb9bfbb890e5ac45523ae68ae95e5

src: inform callback scopes about exceptions in HTTP parser Refs: https://github.com/nodejs/node/commit/4aca277f16b8649b5fc21d41f340fad0a47c2e61 Refs: https://github.com/nodejs/node/pull/30236 Fixes: https://github.com/nodejs/node/issues/31796 PR-URL: https://github.com/nodejs/node/pull/31801 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha 794bfacb26c4059c2eab7efb475489b7010054c3

test: remove common.PORT from test-net-timeout Switch test-net-timeout from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 76fd17a7dff6b89b8851044b17125a88a3043b4e

test: remove common.PORT from test-net-throttle Switch test-net-throttle from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha a092886b1d29d17c94683348430e062cf7ae2fc9

test: remove common.PORT from test-tls-server-large-request Switch test-tls-server-large-request from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha af19f4116c5c3ce0fc7b18b62ffb05e8138bf74b

test: remove common.PORT from test-net-pause Switch test-net-pause from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Guy Bedford

commit sha 58de9b46b80fd3e48f5faf9db8101930a6493fc4

module: package "exports" error refinements PR-URL: https://github.com/nodejs/node/pull/31625 Reviewed-By: Jan Krems <jan.krems@gmail.com>

view details

Myles Borins

commit sha 1c2d77d3d9dd5753a96c0033265c5eeaf3531d00

2020-02-18, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 6 regressions that are being fixed in this release **Accidental Unflagging of Self Resolving Modules**: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. **Process Cleanup Changed Introduced WASM-Related Assertion**: A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases. **Use Largepages Runtime Option Introduced Linking Failure**: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release. **Async Hooks was Causing an Exception When Handling Errors**: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. **New Enumerable Read-Only Property on EventEmitter breaks @types/extend** A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the `@types/extend` module for extending classses as `@types/extend` was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re land in a future Semver-Minor release if a non breaking way of applying it is found. **Exceptions in the HTTP parser were not emitting an uncaughtException** A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by `process.on('uncaughtException')`. The fix to this bug has been included in this release. PR-URL: https://github.com/nodejs/node/pull/31781

view details

Robert Nagy

commit sha 8ba7a2f889472d58478bf40b758d336b41af682b

http2: make compat finished match http/1 finished should true directly after end(). PR-URL: https://github.com/nodejs/node/pull/24347 Refs: https://github.com/nodejs/node/issues/24743 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Shelley Vohr

commit sha 0c3c0e7184c4ca625148c14d61d8e9438a1b69f2

2020-02-18, Version 13.9.0 (Current) Notable changes: * async_hooks * add executionAsyncResource (Matteo Collina) #30959 * crypto * add crypto.diffieHellman (Tobias Nießen) #31178 * add DH support to generateKeyPair (Tobias Nießen) #31178 * simplify DH groups (Tobias Nießen) #31178 * add key type 'dh' (Tobias Nießen) #31178 * test * skip keygen tests on arm systems (Tobias Nießen) #31178 * perf_hooks * add property flags to GCPerformanceEntry (Kirill Fomichev) #29547 * process * report ArrayBuffer memory in `memoryUsage()` (Anna Henningsen) #31550 * readline * make tab size configurable (Ruben Bridgewater) #31318 * report * add support for Workers (Anna Henningsen) #31386 * worker * add ability to take heap snapshot from parent thread (Anna Henningsen) #31569 * added new collaborators * add ronag to collaborators (Robert Nagy) #31498 PR-URL: https://github.com/nodejs/node/pull/31837

view details

Myles Borins

commit sha 43fb664701d771c00595fa1c152cfca03b10a4fd

doc: fix missing changelog corrections There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch. PR-URL: https://github.com/nodejs/node/pull/31854 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Shelley Vohr

commit sha 31290824de068eb4b282ab74829450b988ae225b

doc: fix notable changes for v13.9.0 PR-URL: https://github.com/nodejs/node/pull/31857 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Robert Nagy

commit sha 7c524fb092b143470795c8ca869de4654c728fe1

doc: fix Writable.write callback description Clarifies a userland invariant until a better solution can be found. Also moves a misplaced sentence from _write to write. Refs: https://github.com/nodejs/node/pull/31756 Refs: https://github.com/nodejs/node/pull/31765 PR-URL: https://github.com/nodejs/node/pull/31812 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 822101f570478ffa15e4ed0e00cd0d67b9cc789e

meta: move eljefedelrodeodeljefe to emeritus eljefedelrodeodeljefe confirmed in email that moving to emeritus was fine at this time. PR-URL: https://github.com/nodejs/node/pull/31735 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Joyee Cheung

commit sha e6c2277241e542cdf86475d71c5fdc581bd72025

vm: lazily initialize primordials for vm contexts Lazily initialize primordials when cross-context support for builtins is needed to fix the performance regression in context creation. PR-URL: https://github.com/nodejs/node/pull/31738 Fixes: https://github.com/nodejs/node/issues/29842 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Gus Caplan

commit sha b8e41774d4287d128a40f7ecfecf170fe16fe9ed

fs: add fs/promises alias module PR-URL: https://github.com/nodejs/node/pull/31553 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>

view details

push time in a month

PR opened nodejs/node

lib: add debug logs to writable stream

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+10 -0

0 comment

1 changed file

pr created time in a month

create barnchjuanarbol/node

branch : juanarbol/add-debug-logs

created branch time in a month

issue commentnodejs/node

add debug logs to _stream_writable

Get it, I'll put all the documented events, I may add some extras, as readable stream debug logs.

YoDaMa

comment created time in a month

issue openedlibuv/libuv

Hi

<!-- If you want to report a bug, you are in the right place!

If you need help or have a question, go here: https://github.com/libuv/help/issues/new

If you are reporting a libuv test failure, please ensure that you are not running the test as root.

Please include code that demonstrates the bug and keep it short and simple. -->

  • Version: <!-- libuv version -->
  • Platform: <!-- uname -a (UNIX), or Windows version and machine type -->

6e9b4849-bad2-4017-883e-08be1f1dc2ea

A friend of mine did this, unfortunately she's not on GitHub, but you could find her on twitter as @ritmicoazul

created time in a month

issue commentnodejs/node

add debug logs to _stream_writable

Any specific events you want to be covered?

YoDaMa

comment created time in a month

pull request commentnodejs/node

lib: add ERR_ESM_INVALID_JSON_MODULE

Sorry, I don't know how to reach this code, do you have any example of how could I write the test?

juanarbol

comment created time in a month

pull request commentnodejs/node

test: remove deprecated connections net attribute

Sorry, this is gonna timeout always. Does anyone here knows hoy could I fix this issue?

juanarbol

comment created time in a month

push eventjuanarbol/dotconf

Juan José Arboleda

commit sha 89d26a9d1cd840a6dfb883a591fd62845d5c514d

Add kitty conf

view details

push time in a month

create barnchjuanarbol/dotconf

branch : master

created branch time in a month

created repositoryjuanarbol/dotconf

Just few of my config files

created time in a month

issue commentnodejs/node

HTTP2 Server Upgrade listener undocumented

Could you add a code snippet for make upgrade event emitted?

najibghadri

comment created time in a month

issue commentnodejs/node

add debug logs to _stream_writable

I'll work on this one.

YoDaMa

comment created time in a month

push eventjuanarbol/node

Anna Henningsen

commit sha a7c523e26df468782691c7e16b2e033c6256beb3

src: prefer 3-argument Array::New() This is nicer, because: 1. It reduces overall code size, 2. It’s faster, because `Object::Set()` calls are relatively slow, and 3. It helps avoid invalid `.Check()`/`.FromJust()` calls. PR-URL: https://github.com/nodejs/node/pull/31775 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Robert Nagy

commit sha c776a37791007e0d570355b731647e58ea5885be

http: end with data can cause write after end Calling end() with data while ending should trigger a write after end error. PR-URL: https://github.com/nodejs/node/pull/28666 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 568fdfb1658bfcaa7832759e03661f2cb958c155

fs: fix WriteStream autoClose order WriteStream autoClose was implemented by manually calling .destroy() instead of using autoDestroy and callback. This caused some invariants related to order of events to be broken. Fixes: https://github.com/nodejs/node/issues/31776 PR-URL: https://github.com/nodejs/node/pull/31790 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Samuel Attard

commit sha 093639614fa1cea7a1bc3493d28119a924c97bc9

doc: claim ABI version 82 for Electron 10 PR-URL: https://github.com/nodejs/node/pull/31778 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 26e49d83323c78e89b2664b6eeaee90757d52868

worker: unroll file extension regexp Refs: https://github.com/nodejs/node/pull/31662#discussion_r377016190 PR-URL: https://github.com/nodejs/node/pull/31779 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Jeff

commit sha e028ea0291b845e4bec3c7cff7319a027b8c815e

doc: fix typos in doc/api/https.md PR-URL: https://github.com/nodejs/node/pull/31793 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Jeremiah Senkpiel

commit sha 4d6c861800cc6ac1dc6a0fd9d3a8b0053baec62a

doc: move @Fishrock123 to a previous releaser I have not done a release in well over a year, maybe even two. I also don't really plan to do more, as Node.js releases are very tedious. PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 928c210a611fb6b4575843708e7cb921f311ebde

doc: move @Fishrock123 to TSC Emeriti It was a good run. Almost 5 years. I haven't really been involved in the last 3+? months though, so it's time I call it and 'retire'. I think it is unlikely that I'll be on the TSC again, as node is unfortunately becoming increasingly disinteresting (& frustrating) to me. (So long and thanks for all the fish!) PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 30e6049c75590dec8d5edbf033edbc20e79efcb7

doc: pronouns for @Fishrock123 might as well while I'm at it feels a bit weird being the first person on this list with '/they' but I guess someone's gota do it PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Gireesh Punathil

commit sha 4c746a6cfda980c1cd0de6246781c0083d9e416c

doc: move gireeshpunathil to TSC emeritus PR-URL: https://github.com/nodejs/node/pull/31770 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

James M Snell

commit sha 5bef2ccf20cceda7975f8bce860e0f60595482fc

test: add known issue test for sync writable callback If the write callbacks are invoked synchronously with an error, onwriteError would cause the error event to be emitted synchronously, making it impossible to attach an error handler after the call that triggered it. PR-URL: https://github.com/nodejs/node/pull/31756 Refs: https://github.com/nodejs/quic/commit/b0d469c69c49c9186c1a581a7cebce4c5d398947 Refs: https://github.com/nodejs/quic/pull/341 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

push time in a month

pull request commentcaolan/async

fix(docs): fix code example in docs

Should I close this?

juanarbol

comment created time in a month

more