profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jtlisi/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Jacob Lisi jtlisi @grafana United States

jtlisi/alertmanager 0

Prometheus Alertmanager

jtlisi/azure-marketplace-1 0

Elasticsearch Azure Marketplace offering + ARM template

jtlisi/azure-quickstart-templates 0

Azure Quickstart Templates

jtlisi/common-1 0

Libraries used in multiple Weave projects

jtlisi/cortex 0

A horizontally scalable, highly available, multi-tenant, long term Prometheus.

delete branch cortexproject/cortex

delete branch : 2021w24_fix_zone_aware_ring_get

delete time in 2 months

PR closed cortexproject/cortex

fix: ensure zone aware ring checks filter out unavailable zones size/M

What this PR does:

  • Updates the ring test to check for cases when an entire zone is unavailable
  • Refactors the ReplicationStrategy interface to take a slice of distinct zones as opposed to a bool
  • Filters out instances from unavailable zones in the default replication strategy filter

Which issue(s) this PR fixes:

Fixes #4291

+63 -18

0 comment

4 changed files

jtlisi

pr closed time in 2 months

startedibraheemdev/modern-unix

started time in 2 months

push eventcortexproject/cortex

Peter Štibraný

commit sha fbf067776f612ec33e7228430d4670ef566b57ec

New ruler alerts that ignore user-errors (#4281) * Move error translate queryable to querier package, to allow reuse. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Introduce new metrics for tracking ruler evaluation and append errors. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added PR number. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix name. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Make lint happy. Signed-off-by: Peter Štibraný <pstibrany@gmail.com> * Address review feedback. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Henry Huang

commit sha 9d049abe21c77e00bf167915e64b3bc3676e91af

Added etcd username and userpassword from config (#4205) * added Signed-off-by: Henry Huang <hhh@rutcode.com> * added flags Signed-off-by: Henry Huang <hhh@rutcode.com> * Fixed CHANGELOG entry Signed-off-by: Marco Pracucci <marco@pracucci.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>

view details

Marco Pracucci

commit sha 6349c9121fa3c779bc9e49e05e47e8eabc8b35a4

Fix chunkenc.Iterator comment (#4286) Signed-off-by: Marco Pracucci <marco@pracucci.com>

view details

Gábor Lipták

commit sha eef2c03c1b1bdab0e817ad59dfe76a1beb4b18c0

Set Ubuntu to 20.04 in CI (#4285) Signed-off-by: Gábor Lipták <gliptak@gmail.com>

view details

Marco Pracucci

commit sha e51141518880f8d92baf560a58a2f24ac3f4a9c7

Deprecated Cortex chunks storage (#4268) Deprecate Cortex chunks storage Remove k8s example config which is chunks-based Signed-off-by: Marco Pracucci <marco@pracucci.com>

view details

Marco Pracucci

commit sha b15782ef8cf42ac6653efbf0bd1cf6b3489ea5aa

Updated doc about chunks storage deprecation (#4294) Signed-off-by: Marco Pracucci <marco@pracucci.com>

view details

Niclas Schad

commit sha 83b51d1de55aa5174da87c6bc2bf7a9e84d125b4

docs: added alertmanager_storage docs (#4264) Signed-off-by: ShuzZzle <niclas.schad@gmail.com>

view details

Marco Pracucci

commit sha 8bdf5b1f77d9915aedb3e3e60d8a29d80061a911

Reduce chunks storage usage in integration tests (#4296) * Reduce chunks storage usage in integration tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed userID in integration tests Signed-off-by: Marco Pracucci <marco@pracucci.com> * Deleted unused code Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed 'make doc' Signed-off-by: Marco Pracucci <marco@pracucci.com>

view details

Peter Štibraný

commit sha 8e84b22ce77163f8f0a859067aa344ba18d42c36

Added option to ignore specific metrics when checking max-series-per-metric limit. (#4302) * Added option to ignore specific metrics when checking max-series-per-metric limit. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Kaviraj

commit sha ceb46463a5296977b91e3bcae702019e96aead2b

Add ability to support strict JSON unmarshal for `limits` (#4298) * Add ability to support strict JSON unmarshal for `limits` This is the default behaviour for YAML now. ``` in := `{"unknown_fields": 100}` l := cortex.Limits{} fmt.Println(yaml.UnmarshalStrict([]byte(in), &l)) // yaml: unmarshal errors: // line 1: field unknown_fields not found in type validation.plain ``` This PR adds same behaviour if unmarshalled from JSON input as well. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * Add changelog Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> * Update CHANGELOG.md Co-authored-by: Steve Simpson <steve.simpson@grafana.com> Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> Co-authored-by: Steve Simpson <steve.simpson@grafana.com>

view details

Christian Simon

commit sha 20f8931014bc9f3271380884f8eadee8de83ae96

chore: Define interface api.Distributor (#4297) This allows reusing the API handler while swapping out the Ddistributor implementation. Signed-off-by: Christian Simon <simon@swine.de>

view details

Marco Pracucci

commit sha 5e078f965e15ff325bb43dab91b337293a108c8d

Fixed 'wait ring stability' log (#4306) Signed-off-by: Marco Pracucci <marco@pracucci.com>

view details

Marco Pracucci

commit sha c1023f3358e1a2c01cd1b6479c584fde96259fe7

Fix TestStoreGateway_InitialSyncWithWaitRingStability flakyness (#4305) Signed-off-by: Marco Pracucci <marco@pracucci.com>

view details

Peter Štibraný

commit sha 5b70304cbf8df5ef9e492ba7d36040891f5918df

Expose some ruler types to ease reuse. (#4312) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

view details

Tyler Reid

commit sha fdb1106d951d7b85c3a6cb9db7824b55d47fcc27

Fix flakey MaxChunkBytesPerQueryLimit test (#4258) * Add replication factor flag to the prepConfig Struct. Use replication factor 2 in TestDistributor_QueryStream_ShouldReturnErrorIfMaxChunkBytesPerQueryLimitIsReached test to make the test stable Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Add comment to explain replication factor default. Signed-off-by: Tyler Reid <tyler.reid@grafana.com> * Update comment pkg/distributor/distributor_test.go Co-authored-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Tyler Reid <tyler.reid@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>

view details

Arve Knudsen

commit sha 31fceca88235e7d2442a6608a49fc45a583e187b

RedisCache: Use CollectedRequest (#3976) * RedisCache: Use CollectedRequest Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * RedisCache: Apply feedback from review Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Rename innerCtx to ctx Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Add changelog entry Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

view details

Bryan Boreham

commit sha 7b9ac0d5d61cf5fb9a8fc0db00c63ca290ca4052

Prepare release 1.10 (#4320) Update the release timeline, swap Bryan for Marco. Tweak some CHANGELOG entries. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

view details

George Robinson

commit sha 145cbd8bd280f3a0515cb4acd6475b0ab9673964

Fix any should be all in docs/architecture.md (#4315) I understand that any should be all when talking about queries when using the metric name, labels and Tenant ID as the hashing strategy. Signed-off-by: George Robinson <george.robinson@grafana.com>

view details

Bryan Boreham

commit sha 64fb282c0fef8ce2864b91a14f66e49e412cc0f5

Update for 1.10.0-rc.0 release candidate (#4325) Update version and add some missed items Signed-off-by: Bryan Boreham <bjboreham@gmail.com>

view details

Alan Protasio

commit sha 345ec0312ae98a4fbde0711d42ec91d6058645f5

max chunks per query limit shared between ingesters and storage gateways (#4260) * max chunks per query limit shared between ingesters and storage gateways Signed-off-by: Alan Protasio <approtas@amazon.com> * Addressing comments Signed-off-by: Alan Protasio <approtas@amazon.com> * Addressing comments -2 Signed-off-by: Alan Protasio <approtas@amazon.com> * Addressing comments - 3 Signed-off-by: Alan Protasio <approtas@amazon.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>

view details

push time in 2 months

issue commentcortexproject/cortex

build: upgrade alpine image to 3.13.5

still valid

jtlisi

comment created time in 2 months

startedDataDog/go-profiler-notes

started time in 3 months

issue commentcortexproject/cortex

Zone-aware ring checks can fail when an entire zone is unavailable

In the PR #3414 we've handled a similar case for GetReplicationSetForOperation().

I'm wondering for which service and setup you're experiencing the issue. Assuming it's related to the ingesters ring (read/write samples), I guess you're fixing it for the case "shard by all labels" is disabled, because when that is enabled we use GetReplicationSetForOperation() instead of Get() and GetReplicationSetForOperation() should handle it.

Could you share more details about the setup?

This is for remote-write operations to the Distributor with shard by all labels enabled. I may be a bit confused. I thought and it looks to me that Push is called for all writes and that functions uses ring.DoBatch which calls Get. Do we swap out implementations if ShardByAllLabels is enabled?

jtlisi

comment created time in 3 months

PullRequestReviewEvent
PullRequestReviewEvent

push eventcortexproject/cortex

Jacob Lisi

commit sha c6eb59aed26d9324b4c44d70953d66b4b094c0af

fix linting Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>

view details

push time in 3 months

push eventcortexproject/cortex

Jacob Lisi

commit sha 2b4d50c7e5120a7e9f9372171e3550fbb13e007c

fix linting

view details

push time in 3 months