profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jsgf/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

jsgf/EyeFiServer 4

An open source Eye-Fi Server written in Python

jsgf/concurrent-barrier 2

Simple concurrency barriers

jsgf/aeson 1

A fast Haskell JSON library

jsgf/AndroidMessenger 1

A project I worked on to make a multiclient messaging client back when the android API was in beta

jsgf/constellation 1

Constellation

jsgf/criterion 1

A powerful but simple library for measuring the performance of Haskell code.

jsgf/dep-analyzer 1

Experiment in analyzing Rust dependencies with save-analysis output

jsgf/eventfd-rust 1

Rust binding to Linux eventfd

jsgf/frond 1

Frond firmware

jsgf/gloop 1

Link manager thingy

PullRequestReviewEvent

Pull request review commenttokio-rs/tracing

subscriber: fix missing `on_layer` for `Box`/`Arc` layer impls

 where     L: Layer<S>,     S: Subscriber, {+    fn on_layer(&mut self, subscriber: &mut S) {+        if let Some(inner) = Arc::get_mut(self) {+            // XXX(eliza): this may behave weird if another `Arc` clone of this+            // layer is layered onto a _different_ subscriber...but there's no+            // good solution for that...

Better to deprecate a bad idea earlier than later. And if Arc<Layer> isn't actually usable, then presumably that will dissuade people from using it.

hawkw

comment created time in 3 days

PullRequestReviewEvent

Pull request review commenttokio-rs/tracing

subscriber: fix missing `on_layer` for `Box`/`Arc` layer impls

 where     L: Layer<S>,     S: Subscriber, {+    fn on_layer(&mut self, subscriber: &mut S) {+        if let Some(inner) = Arc::get_mut(self) {+            // XXX(eliza): this may behave weird if another `Arc` clone of this+            // layer is layered onto a _different_ subscriber...but there's no+            // good solution for that...

I don't understand this comment. Arc::get_mut will only return a value if there are no other aliases so if it gets here there can't be a different subscriber. So the weird behaviour will be if there are multiple references to the Layer then this won't get called.

It seems like Arc<L: Layer> and on_layer are intrinsically incompatible. If having on_layer(&mut self, ... is useful, then maybe there shouldn't be Arc<L: Layer> after all?

hawkw

comment created time in 10 days

push eventjsgf/cxx

Jeremy Fitzhardinge

commit sha a7b691b54ca18bcf244a35a2b587a39fe7ef019a

Add some helper templates to cxx.h `rust::make_shared` - construct a type into a `std::shared_ptr` `rust::make_unique` - construct a type into a `std::unique_ptr` `rust::shared_as_mutable` - obtain a mutable reference to a `std::shared_ptr` value These are used as follows: ``` mod ffi { extern "C++" { type MyTypeA; type MyTypeB; #[namespace = "rust"] #[cxx_name = "make_shared"] fn make_MyTypeA(arg1: u32, arg2: bool) -> SharedPtr<MyTypeA>; #[namespace = "rust"] #[cxx_name = "make_unique"] fn make_MyTypeB(arg1: u32, arg2: bool) -> UniquePtr<MyTypeB>; #[namespace = "rust"] #[cxx_name = "shared_as_mutable] unsafe fn make_mutable_MyTypeA(ptr: &SharedPtr<MyTypeA>) -> Pin<&mut MyTypeA>; } } ```

view details

push time in 11 days

push eventjsgf/cxx

Jeremy Fitzhardinge

commit sha 47814da4694c4eeb1fe78ad469616ab526881696

Add some helper templates to cxx.h `rust::make_shared` - construct a type into a `std::shared_ptr` `rust::make_unique` - construct a type into a `std::unique_ptr` `rust::shared_as_mutable` - obtain a mutable reference to a `std::shared_ptr` value These are used as follows: ``` mod ffi { extern "C++" { type MyTypeA; type MyTypeB; #[namespace = "rust"] #[cxx_name = "make_shared"] fn make_MyTypeA(arg1: u32, arg2: bool) -> SharedPtr<MyTypeA>; #[namespace = "rust"] #[cxx_name = "make_unique"] fn make_MyTypeB(arg1: u32, arg2: bool) -> UniquePtr<MyTypeB>; #[namespace = "rust"] #[cxx_name = "shared_as_mutable] unsafe fn make_mutable_MyTypeA(ptr: &SharedPtr<MyTypeA>) -> Pin<&mut MyTypeA>; } } ```

view details

push time in 11 days

push eventjsgf/cxx

Jeremy Fitzhardinge

commit sha 67c2777ac3be6c8f68c9f95c6aea30e56d37e6aa

Add some helper templates to cxx.h `rust::make_shared` - construct a type into a `std::shared_ptr` `rust::make_unique` - construct a type into a `std::unique_ptr` `rust::shared_as_mutable` - obtain a mutable reference to a `std::shared_ptr` value These are used as follows: ``` mod ffi { extern "C++" { type MyTypeA; type MyTypeB; #[namespace = "rust"] #[cxx_name = "make_shared"] fn make_MyTypeA(arg1: u32, arg2: bool) -> SharedPtr<MyTypeA>; #[namespace = "rust"] #[cxx_name = "make_unique"] fn make_MyTypeB(arg1: u32, arg2: bool) -> UniquePtr<MyTypeB>; #[namespace = "rust"] #[cxx_name = "shared_as_mutable] unsafe fn make_mutable_MyTypeA(ptr: &SharedPtr<MyTypeA>) -> Pin<&mut MyTypeA>; } } ```

view details

push time in 11 days

create barnchjsgf/cxx

branch : cxx-helper-templates

created branch time in 11 days

fork jsgf/cxx

Safe interop between Rust and C++

https://cxx.rs

fork in 11 days

PR opened tokio-rs/tracing

Cleanups 0.1.x

Small doc and test cleanups.

+42 -38

0 comment

5 changed files

pr created time in 16 days

create barnchjsgf/tracing

branch : cleanups-0.1.x

created branch time in 16 days

push eventjsgf/tracing

Jeremy Fitzhardinge

commit sha 6ac52155d54dd0a1bb4027aae37e01806acf0a6c

subscriber: make `Layer` impls for ` Box<dyn Layer<..>>` `Send+Sync` (#1547) And for Arc This is a fixup for https://github.com/tokio-rs/tracing/pull/1536.

view details

Jeremy Fitzhardinge

commit sha 4f5ef51ae18fd50fa5c4f2d56370bba06ff041ce

core: make NoSubscriber public and move it to tracing_core::subscriber (#1549) This is useful when you need a placeholder subscriber for something.

view details

Eliza Weisman

commit sha e4015f8626252997ffd6ad9d36b77d6d5938f0ff

chore(ci): use `working-directory` instead of cd (#1540) This is a little bit nicer IMO. Signed-off-by: Eliza Weisman <eliza@buoyant.io>

view details

Eliza Weisman

commit sha c95321a02e04eee7b2eb2863ff9da980248f06bb

chore: simplify Netlify config (#1541) Previously, the Netlify configuration copied the docs into a `_netlify_out` dir as a workaround for netlify/build-image#505. This upstream issue was fixed back in January, so this workaround hasn't been necessary for a while. Therefore, we can remove this extra complexity from our configuration. I also changed the build script to a multi-line string which I think is a bit nicer.

view details

Eliza Weisman

commit sha a1d12820864842cea8c7dd249a101f37f8593f6f

subscriber: fix missing `doc(cfg(...))` attributes for `EnvFilter` (#1544) ## Motivation Currently, some types in the `filter` module that require the "env-filter" feature flag don't properly show in the docs that they require this feature. This is because the `doc(cfg(feature = "env-filter"))` attribute is only placed on the _re-export_ from the `env` module (and on the `EnvFilter` type), not on the individual types that are re-exported. However, placing a `doc(cfg(...))` attribute on a re-export doesn't actually do anything. ## Solution This commit fixes that.

view details

LIU JIE

commit sha 0ab63ef5cb6bfb118bddf051cc0a00ef0924fb93

log: fix `LogTracer` not honoring max level filters (#1543) Co-authored-by: Eliza Weisman <eliza@buoyant.io>

view details

Jeremy Fitzhardinge

commit sha e4a854a27aa84e6b34271f7a8ebace2b3cd4294d

Merge branch 'v0.1.x' into inst-skip_all

view details

push time in 16 days

push eventjsgf/qmk_firmware

leviport

commit sha 3f73a2879a9cdc8a025cb86dc753da68dc07271e

Update Levi's Launch keymap

view details

leviport

commit sha 1b508235d7546d5ff5ff320ddfc197432f161a2d

Update flashing instructions and rewrite layout design instructions

view details

leviport

commit sha 3e342a85421443f657ebd996a5b3dc09870ad2f6

Update README.md

view details

Jeremy Fitzhardinge

commit sha ecc42ee3319b6f8e276657c40f060bbd17d5c805

Merge remote-tracking branch 'origin/master' into jsgf-config

view details

push time in 16 days

push eventjsgf/tracing

Jeremy Fitzhardinge

commit sha 4d55b1457cdb0169539b6dfb5c706c315b70dcb6

add runtime test

view details

push time in 16 days

Pull request review commenttokio-rs/tracing

tracing-attributes: implement `skip_all`

 fn skip() {     #[instrument(target = "my_target", level = "debug", skip(_arg2, _arg3))]     fn my_fn(arg1: usize, _arg2: UnDebug, _arg3: UnDebug) {} +    #[instrument(target = "my_target", level = "debug", skip_all)]+    fn my_fn2(_arg1: usize, _arg2: UnDebug, _arg3: UnDebug) {}

Yeah I was wondering if there were some existing skip tests for that.

jsgf

comment created time in 18 days

PullRequestReviewEvent

Pull request review commenttokio-rs/tracing

Make NoSubscriber public and move it to tracing_core::subscriber

 impl Interest {     } } +/// A no-op [`Subscriber`]+///+/// [`NoSubscriber`] implements the [`Subscriber`] trait by never being enabled,+/// never being interested in any callsite, and drops all spans and events.+#[derive(Debug, Copy, Clone)]+pub struct NoSubscriber;

I guess there's the question of whether it should be Copy, if it might stop being Copy in future.

jsgf

comment created time in 18 days

PullRequestReviewEvent

push eventjsgf/tracing

Jeremy Fitzhardinge

commit sha 610926d8622c50f01a069af8a00cb23c579e55aa

Require construction for NoSubscriber Just in case it ever needs a real field later.

view details

push time in 18 days

PullRequestReviewEvent

Pull request review commenttokio-rs/tracing

Make NoSubscriber public and move it to tracing_core::subscriber

 impl Interest {     } } +/// A no-op [`Subscriber`]+///+/// [`NoSubscriber`] implements the [`Subscriber`] trait by never being enabled,+/// never being interested in any callsite, and drops all spans and events.+#[derive(Debug, Copy, Clone)]+pub struct NoSubscriber;

Done.

jsgf

comment created time in 18 days

push eventjsgf/tracing

Jeremy Fitzhardinge

commit sha b25bd62d94e672f936d7fbfe7068e3c0f8891138

Require construction for NoSubscriber Just in case it ever needs a real field later.

view details

push time in 18 days

push eventjsgf/tracing

Jeremy Fitzhardinge

commit sha 454aef4fb4ad1a2fb0575d6b3f4444c619b53cee

Make NoSubscriber public and move it to tracing_core::subscriber

view details

push time in 18 days

push eventjsgf/tracing

Jeremy Fitzhardinge

commit sha 6ac52155d54dd0a1bb4027aae37e01806acf0a6c

subscriber: make `Layer` impls for ` Box<dyn Layer<..>>` `Send+Sync` (#1547) And for Arc This is a fixup for https://github.com/tokio-rs/tracing/pull/1536.

view details

Jeremy Fitzhardinge

commit sha 0a8f135e0fc09a85b7211bee55f9685a90ef6982

Layer impls for Box<dyn Layer<..>> should be Send+Sync+'static And for Arc

view details

push time in 18 days

push eventjsgf/tracing

Jeremy Fitzhardinge

commit sha f28a62aa34d5e781c467c28f7ed9a94f33279f12

tracing-attributes: implement `skip_all` Using `#[instrument(skip_all)]` is equivalent to `#[instrument(skip(foo, bar..))]` for all the parameters.

view details

push time in 18 days

PR opened tokio-rs/tracing

Make NoSubscriber public and move it to tracing_core::subscriber

This is useful when you need a placeholder subscriber for something.

+32 -27

0 comment

2 changed files

pr created time in 18 days

pull request commenttokio-rs/tracing

Layer impls for Box<dyn Layer<..>> should be Send+Sync

That was quick. Should it have had 'static too?

jsgf

comment created time in 18 days

PR opened tokio-rs/tracing

tracing-attributes: implement `skip_all`

Using #[instrument(skip_all)] is equivalent to #[instrument(skip(foo, bar..))] for all the parameters.

+29 -3

0 comment

2 changed files

pr created time in 18 days

push eventjsgf/tracing

Jeremy Fitzhardinge

commit sha 9d38d18a8c983b3bb4beacc6c982b135a40c81f8

Layer impls for Box<dyn Layer<..>> should be Send+Sync+'static And for Arc

view details

push time in 18 days

create barnchjsgf/tracing

branch : public-nosub

created branch time in 18 days