profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/jpeach/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

jpeach/cscope-lsp 5

cscope line interface for cquery

jpeach/envoy-build 3

Scaffold for out of tree Envoy builds

jpeach/envoy-proto 2

Consolidated Envoy protobufs

jpeach/githubfs 2

GitHub repository filesystem client.

jpeach/httpd 1

Mirror of Apache HTTP Server

jpeach/atscppapi 0

This library provides wrappers around the existing Apache Traffic Server API which will vastly simplify the process of writing Apache Traffic Server plugins.

jpeach/bench 0

Random benchmarks and experiments.

jpeach/bonk 0

bonk

jpeach/brew 0

:beer: The missing package manager for macOS

jpeach/churn 0

Create churn in a Kubernetes cluster

issue commentpulumi/pulumi-aws

Using `ec2` in go results in compile errors

v4.21.2 has just been released that includes this fix

Thanks @stack72, I verified that I was able to upgrade the Go modules to this version :tada:

iwahbe

comment created time in an hour

PullRequestReviewEvent

Pull request review commentkumahq/kuma

feat(kuma-cp) add GatewayRoute route generation

+package route++import (+	"net/http"++	envoy_config_core_v3 "github.com/envoyproxy/go-control-plane/envoy/config/core/v3"

This is the import alias that Goland generates. I'll switch to envoy_core and add that to the golint config.

jpeach

comment created time in an hour

push eventkumahq/kuma

mergify[bot]

commit sha 7977accf42925f5539789309b32e2328c3dd6a7b

fix(kuma-cp) remove insight update rate limit burst (#2825) (#2835) The token burst that is configured for the insight update rate limit allows the update rate to burst up to 50 times before stabilizing to the desired rate. This would typically happen when kuma-cp starts up and all the dataplanes reconnect, which is precisely the time when you want the rate limit to apply for operational stability. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 13df4cfb3e448c47783ece9d16cb911867014a4f) Co-authored-by: James Peach <james.peach@konghq.com>

view details

push time in an hour

delete branch kumahq/kuma

delete branch : mergify/bp/release-1.3/pr-2825

delete time in an hour

PR merged kumahq/kuma

fix(kuma-cp) remove insight update rate limit burst (backport #2825)

This is an automatic backport of pull request #2825 done by Mergify.


<details> <summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/ </details>

+1 -1

1 comment

1 changed file

mergify[bot]

pr closed time in an hour

delete branch jpeach/kuma

delete branch : fix/insight-rate-burst

delete time in an hour

Pull request review commentkumahq/kuma

docs(OWNERS.md) add Mike Beaumont

 In alphabetical order: * Marco Palladino ([subnetmarco](https://github.com/subnetmarco)) (marco@konghq.com) * Nikolay Nikolaev ([nickolaev](https://github.com/nickolaev)) (nicknickolaev@gmail.com) * Paul Parkanzky ([parkanzky](https://github.com/parkanzky)) (paul.parkanzky@konghq.com)+* Mike Beaumont ([michaelbeaumont](https://github.com/michaelbeaumont)) (michael.beaumont@konghq.com)

Looks like this should be alphabetical by first name :)

michaelbeaumont

comment created time in a day

PullRequestReviewEvent

push eventjpeach/pulumi-stacks

James Peach

commit sha 4802551c05ae9db38064afff358ab710c9b9a974

Extract SSH key generation package.

view details

push time in 2 days

issue commentpulumi/pulumi-aws

Using `et2` in go results in compile errors

@EvanBoyle I came across this issue since I had the same error trying to upgrade to v4.21.1. How fixed is this issue considered to me? A cursory look shows that NetworkInterfaceAttachmentType is still duplicated with different definitions:

https://github.com/pulumi/pulumi-aws/blob/master/sdk/go/aws/ec2/networkInterfaceAttachment.go:

type NetworkInterfaceAttachmentType struct {
	pulumi.CustomResourceState

	// The ENI Attachment ID.
	AttachmentId pulumi.StringOutput `pulumi:"attachmentId"`
	// Network interface index (int).
	DeviceIndex pulumi.IntOutput `pulumi:"deviceIndex"`
	// Instance ID to attach.
	InstanceId pulumi.StringOutput `pulumi:"instanceId"`
	// ENI ID to attach.
	NetworkInterfaceId pulumi.StringOutput `pulumi:"networkInterfaceId"`
	// The status of the Network Interface Attachment.
	Status pulumi.StringOutput `pulumi:"status"`
}

https://raw.githubusercontent.com/pulumi/pulumi-aws/master/sdk/go/aws/ec2/pulumiTypes.go

type NetworkInterfaceAttachmentType struct {
	AttachmentId *string `pulumi:"attachmentId"`
	// Integer to define the devices index.
	DeviceIndex int `pulumi:"deviceIndex"`
	// ID of the instance to attach to.
	Instance string `pulumi:"instance"`
}
iwahbe

comment created time in 2 days

delete branch kumahq/kuma

delete branch : mergify/bp/release-1.3/pr-2818

delete time in 2 days

push eventkumahq/kuma

mergify[bot]

commit sha 363b3d0eac9360cfaae05ec66e89c430c0fb97a8

chore(ci) fix "make tidy" (#2818) (#2821) This fixes #2088. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit e48d37a05b69da1adb46accc9f2aa1f183fad2c3) Co-authored-by: James Peach <james.peach@konghq.com>

view details

push time in 2 days

PR merged kumahq/kuma

chore(ci) fix "make tidy" (backport #2818)

This is an automatic backport of pull request #2818 done by Mergify.


<details> <summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/ </details>

+656 -8

1 comment

5 changed files

mergify[bot]

pr closed time in 2 days

pull request commentkumahq/kuma

feat(kuma-cp) generate GatewayRoute clusters

Reviewers - this PR is based on #2782, so only the 2nd commit is relevant. I'll rebase when the base PR lands.

jpeach

comment created time in 2 days

push eventkumahq/kuma

James Peach

commit sha 6ffb0624dc141b11a060322b3d049947abea8a15

chore(ci) fix "make tidy" (#2818) This fixes #2088. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit e48d37a05b69da1adb46accc9f2aa1f183fad2c3)

view details

push time in 2 days

push eventjpeach/kuma

James Peach

commit sha e48d37a05b69da1adb46accc9f2aa1f183fad2c3

chore(ci) fix "make tidy" (#2818) This fixes #2088. Signed-off-by: James Peach <james.peach@konghq.com>

view details

parkanzky

commit sha 4cf589d8157b09778c49f29875aa9a0e0561f30c

fix(kuma-cp) apply ratelimit to service insights (#2815) Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

view details

James Peach

commit sha f3536e90bba28f1b6615db7cafb31eb0fb51f676

chore(*) remove unnecessary go-kit dependency (#2817) Wrapping the Go rate limiter in an interface from go-kit doesn't have any advantages at this point. Getter to just remove the dependency. Signed-off-by: James Peach <james.peach@konghq.com>

view details

Ilya Lobkov

commit sha 1333e7c965a15bed2527cf69977931021add4c35

docs(kuma-cp) permissive mtls proposal (#2550) Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>

view details

James Peach

commit sha b855063a8308c6204eb77c329e28aae4337b486f

feat(kuma-cp) add GatewayRoute route generation Add machinery to generate Envoy routes from GatewayRoute resources. This is split into a generator that translates GatewayRoute resources into a generic route table structure, and a generator that translates the generic structure into Envoy resources. The generic route table structure provides an API-independent way to configure Envoy. This change only generates routes (not cluster or endpoints), but the full semantics of GatewayRoute are supported, including path prefix matches, multiple match criteria and correct route match ordering. Signed-off-by: James Peach <james.peach@konghq.com>

view details

James Peach

commit sha 3691699f19ea4cf8a7f3531edba8b7247ac6e922

feat(kuma-cp) generate GatewayRoute clusters Add cluster and load assignment support to the GatewayRoute generator. This makes simple end-to-end Gateway configurations work. Signed-off-by: James Peach <james.peach@konghq.com>

view details

push time in 2 days

issue openedkumahq/kuma

Create an explicit signal to run e2e tests

Summary

The end-to-end test suites typically begin by skipping unless framework.IsK8sClustersStarted() returns true. This function tests for the presence of the K8SCLUSTERS= environment variable, which is a magic handshake with the makefile targets that are used to run e2e tests. The test still need to call this even if it doesn't use any Kubernetes clusters, because other wise some other environmental dependency will break (e.g. the KUMACTLBIN environment variable might not be set.

This would be a lot clearer and easier to manage if there was a more explicit signal for running e2e tests. My suggestion is a +iintegration or +e2e build tag.

created time in 2 days

push eventjpeach/kuma

James Peach

commit sha e48d37a05b69da1adb46accc9f2aa1f183fad2c3

chore(ci) fix "make tidy" (#2818) This fixes #2088. Signed-off-by: James Peach <james.peach@konghq.com>

view details

parkanzky

commit sha 4cf589d8157b09778c49f29875aa9a0e0561f30c

fix(kuma-cp) apply ratelimit to service insights (#2815) Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>

view details

James Peach

commit sha f3536e90bba28f1b6615db7cafb31eb0fb51f676

chore(*) remove unnecessary go-kit dependency (#2817) Wrapping the Go rate limiter in an interface from go-kit doesn't have any advantages at this point. Getter to just remove the dependency. Signed-off-by: James Peach <james.peach@konghq.com>

view details

Ilya Lobkov

commit sha 1333e7c965a15bed2527cf69977931021add4c35

docs(kuma-cp) permissive mtls proposal (#2550) Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>

view details

James Peach

commit sha b855063a8308c6204eb77c329e28aae4337b486f

feat(kuma-cp) add GatewayRoute route generation Add machinery to generate Envoy routes from GatewayRoute resources. This is split into a generator that translates GatewayRoute resources into a generic route table structure, and a generator that translates the generic structure into Envoy resources. The generic route table structure provides an API-independent way to configure Envoy. This change only generates routes (not cluster or endpoints), but the full semantics of GatewayRoute are supported, including path prefix matches, multiple match criteria and correct route match ordering. Signed-off-by: James Peach <james.peach@konghq.com>

view details

push time in 2 days

push eventjpeach/kuma

James Peach

commit sha b2490ac40745817673d134b9b266397c5db6796e

feat(kuma-cp) generate GatewayRoute clusters Add cluster and load assignment support to the GatewayRoute generator. This makes simple end-to-end Gateway configurations work. Signed-off-by: James Peach <james.peach@konghq.com>

view details

push time in 2 days

delete branch jpeach/kuma

delete branch : chore/fix-check-tidy

delete time in 2 days

push eventkumahq/kuma

mergify[bot]

commit sha 7099bded9ae55a022e0dc9f3cbe1a9a5609598be

chore(*) remove unnecessary go-kit dependency (#2817) (#2823) Wrapping the Go rate limiter in an interface from go-kit doesn't have any advantages at this point. Getter to just remove the dependency. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit f3536e90bba28f1b6615db7cafb31eb0fb51f676) Co-authored-by: James Peach <james.peach@konghq.com>

view details

push time in 2 days

delete branch kumahq/kuma

delete branch : mergify/bp/release-1.3/pr-2817

delete time in 2 days

PR merged kumahq/kuma

chore(*) remove unnecessary go-kit dependency (backport #2817)

This is an automatic backport of pull request #2817 done by Mergify.


<details> <summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/ </details>

+8 -9

0 comment

3 changed files

mergify[bot]

pr closed time in 2 days

pull request commentkumahq/kuma

fix(kuma-cp) remove insight update rate limit burst

cc @parkanzky @lobkovilya

jpeach

comment created time in 2 days

PR opened kumahq/kuma

fix(kuma-cp) remove insight update rate limit burst backport-to-stable

Summary

The token burst that is configured for the insight update rate limit allows the update rate to burst up to 50 times before stabilizing to the desired rate. This would typically happen when kuma-cp starts up and all the dataplanes reconnect, which is precisely the time when you want the rate limit to apply for operational stability.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • [x] Unit tests
  • [x] E2E tests
  • [ ] Manual testing on Universal
  • [ ] Manual testing on Kubernetes

Backwards compatibility

  • [x] Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.
+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchjpeach/kuma

branch : fix/insight-rate-burst

created branch time in 2 days

push eventjpeach/kuma

James Peach

commit sha 9d37e249be21d4bdcb78bd2925db4f157ba1488b

WIP add e2e test Signed-off-by: James Peach <james.peach@konghq.com>

view details

push time in 2 days

issue commentkumahq/kuma-demo

Not Getting 2/2 PODS for Services or Deployment

Issue is resolved after I switched to minikube way of kubernetes

What kind of cluster did you start with?

jaikratsinghtariyal

comment created time in 2 days

issue commentkumahq/kuma-demo

Not Getting 2/2 PODS for Services or Deployment

  • Not able to hit URL kubectl apply -f https://bit.ly/demokuma due to company policies so cloned the repo locally and hitting the command with file.

FWIW, the bitly link resolves to https://raw.githubusercontent.com/kumahq/kuma-demo/master/kubernetes/kuma-demo-aio.yaml

jaikratsinghtariyal

comment created time in 2 days