profile
viewpoint
Josh Gavant joshgav Discover Financial Services Chicago, IL

joshgav/azure-log-processor 2

Receive and process logs from Azure resources via Event Hubs.

joshgav/azure-scripts 2

Scripts for deploying to Azure platforms.

joshgav/gdrive 2

CLI for Google Drive.

joshgav/azure-go-labs 1

Labs demonstrating how to use Go on Azure.

joshgav/chrome-remote-interface 1

Chrome Debugging Protocol interface

joshgav/diagnostics 1

Tracing Working Group

joshgav/go-sample 1

Sample app for tests.

joshgav/ApplicationInsights-node.js 0

Microsoft Application Insights SDK for node.js

joshgav/appsvc-scratch 0

scripts and tests for Azure App Service

PR closed knative/eventing-contrib

Reviewers
support other cred providers in sqs adapter cla: yes needs-rebase ok-to-test size/S

Background

I'd like to use the SQS adapter from awssqs/pkg/adapter with a custom credentials provider, but at the moment the adapter strictly uses a credentials file.

This PR proposes allowing the adapter to accept any AWS credentials provider, which will enable others to initialize and inject their own. It also updates the adapter container's main.go to create and use a file-based provider so that this change is transparent to current container users.

Proposed Changes

Release Note <!-- Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required". If no release note is required, write "NONE". -->

The SQS receive_adapter now accepts a credentials provider rather than a path to a credentials file, enabling use of alternate providers. If you use the adapter via the default cmd and container this change is transparent. If you use the adapter directly then action required: you will need to specify your file in a SharedCredentials provider and use that to initialize the adapter.
+17 -5

10 comments

2 changed files

joshgav

pr closed time in 12 days

pull request commentknative/eventing-contrib

support other cred providers in sqs adapter

Closing as I haven't been able to work on this and things have moved on.

joshgav

comment created time in 12 days

issue closedopen-telemetry/opentelemetry-java

Shim from OpenTracing impl to OpenTelemetry API

Is your feature request related to a problem? Please describe. I'd like to use the OpenTelemetry API/SDK with an OpenTracing tracer, specifically AppDynamics'. AppD doesn't (yet?) provide an OpenTelemetry or even OpenCensus exporter or tracer, so using their OpenTracing tracer seems to be the only integration option for now.

Describe the solution you'd like I'd like a shim which bridges from an OpenTracing tracer implementation to the OpenTelemetry API, similar to the existing inverse shim, which bridges from an OpenTelemetry tracer impl to the OpenTracing API.

Describe alternatives you've considered I'd be even happier with a shim which bridges from an OpenTracing tracer to the OpenTelemetry Exporter API, so it could be used in the collector rather than in process, but assume that would be more difficult if not impossible due to different correlation identifier formats. I've asked the vendor and will continue to do so about providing an exporter themselves.

closed time in 13 days

joshgav

issue commentopen-telemetry/opentelemetry-java

Shim from OpenTracing impl to OpenTelemetry API

@bogdandrutu

making an exporter in Opentelemetry for AppD and rely on the implementation in Opentelemetry to collect span data

Yes, that's reasonable and I'll pursue that. :+1: I think we can perceive the OpenTelemetry API as a new version of the OpenTracing API (i.e. v0.34!) and ask vendors to "upgrade", ideally by providing an exporter instead of a tracer.

@carlosalberto

I'd also vow your having an AppD exporter

The trouble is AppD's formats and source are proprietary and closed :( so it's iffy for someone other than AppD themselves to write the initial implementations. Best to get AppD themselves on board if possible.

I'll close this request now but follow it, if other users come along with a similar request hopefully they'll find it and +1 and/or comment.

Thanks for the consideration.

joshgav

comment created time in 13 days

issue openedopen-telemetry/opentelemetry-java

Shim from OpenTracing impl to OpenTelemetry API

Is your feature request related to a problem? Please describe. I'd like to use the OpenTelemetry API/SDK with an OpenTracing tracer, specifically AppDynamics'. AppD doesn't (yet?) provide an OpenTelemetry or even OpenCensus exporter or tracer, so using their OpenTracing tracer seems to be the only integration option for now.

Describe the solution you'd like I'd like a shim which bridges from an OpenTracing tracer implementation to the OpenTelemetry API, similar to the existing inverse shim, which bridges from an OpenTelemetry tracer impl to the OpenTracing API.

Describe alternatives you've considered I'd be even happier with a shim which bridges from an OpenTracing tracer to the OpenTelemetry Exporter API, so it could be used in the collector rather than in process, but assume that would be more difficult if not impossible due to different correlation identifier formats. I've asked the vendor and will continue to do so about providing an exporter themselves.

created time in 14 days

startedopen-telemetry/opentelemetry-collector

started time in 22 days

push eventjoshgav/joshgav.github.io

Josh Gavant

commit sha c1f56bc8ef4642041c6fa8d66c5a21be9715fdd9

update metadata

view details

push time in a month

push eventjoshgav/joshgav.github.io

Josh Gavant

commit sha d2683591c3bee87bf9a0b2ea01e4dd9f06e127ff

update welcome post

view details

push time in a month

push eventjoshgav/joshgav.github.io

Josh Gavant

commit sha 5bc5b12ec893df63a01ee47ad2ce02a0b893d23b

update welcome post

view details

push time in a month

push eventjoshgav/joshgav.github.io

Josh Gavant

commit sha a4f7386078b3aac297b3d695661ad8aa3d1301ca

change source branch

view details

push time in a month

create barnchjoshgav/joshgav.github.io

branch : source

created branch time in a month

push eventjoshgav/joshgav.github.io

Josh Gavant

commit sha af5fb243645e3662436937d07d876228f5549954

use 'moving' theme

view details

push time in a month

push eventjoshgav/joshgav.github.io

Josh Gavant

commit sha 1038b5af74e248f9c47beec6cd9009be7edb0986

update title

view details

push time in a month

issue openedjoshgav/joshgav.github.io

write a post on operators

created time in a month

issue openedjoshgav/joshgav.github.io

choose a theme

https://jekyllrb.com/docs/themes/

created time in a month

push eventjoshgav/joshgav.github.io

Josh Gavant

commit sha 80f19d52d43a030d794426a4798ae2944efcdcc8

update welcome post

view details

push time in a month

push eventjoshgav/joshgav.github.io

Josh Gavant

commit sha a0036153aee9fced29cc83a70c6c9414dfe081a5

initial blog source and build action

view details

push time in a month

create barnchjoshgav/joshgav.github.io

branch : master

created branch time in a month

created repositoryjoshgav/joshgav.github.io

My blog.

created time in a month

startedcncf/sig-observability

started time in 2 months

more