profile
viewpoint
Joseph Mancuso josephmancuso @MasoniteFramework Long Island, New York http://docs.masoniteproject.com Joseph Mancuso | Software Developer | Creator of the @MasoniteFramework

josephmancuso/django-heroku-production 10

A Django project that's ready to deploy to Heroku within minutes.

josephmancuso/ambient 5

Quick Masonite & Vue Ambient sounds website

Apress/definitive-guide-to-masonite 1

Source Code for 'The Definitive Guide to Masonite' by Christopher Pitt and Joe Mancuso

girardinsamuel/masonite4-template 0

Examples of possible project templates for Masonite 4

josephmancuso/awesome-python 0

A curated list of awesome Python frameworks, libraries, software and resources

josephmancuso/bootstrap-studio-themes 0

Themes to use with Bootstrap Studio

josephmancuso/bootstrap4-tagsinput 0

jQuery tags input plugin based on Twitter Bootstrap 4

josephmancuso/college 0

repo for college project

josephmancuso/core 0

Main pip package location for Masonite

issue closedMasoniteFramework/orm

model command PEP8 standar

Describe the feature as you'd like to see it When you use the masonite-orm model command. the name that you choose for the model should comply with PEP8 on both the ClassName that is camelcase and the file snake_case

What do we currently have to do now? Currently the command creates file with CamelCase.

Additional context Link to the PEP8 file naming, class naming page https://www.python.org/dev/peps/pep-0008/#package-and-module-names.

  • [ ] Is this a breaking change? For the orm no I don't know if is for the framework

closed time in 3 hours

alfonsocv12

issue commentMasoniteFramework/orm

model command PEP8 standar

Fixed in #579

alfonsocv12

comment created time in 3 hours

IssuesEvent

push eventMasoniteFramework/orm

Joe Mancuso

commit sha ec78162781d0696b17f6f44b35d9beaf16c1ffab

added pep to model command

view details

Joe Mancuso

commit sha f59fd007b760debf92c4ca8c968a49efdbaa0a48

formatted

view details

Joseph Mancuso

commit sha 24ed840c0f4ed0866f8bbb6a6033e0b817606d5a

Merge pull request #581 from MasoniteFramework/feature/579 added pep to model command

view details

push time in 3 hours

PR merged MasoniteFramework/orm

added pep to model command

Closes #579

$ python orm model DashboardUser -p

Model created: app/dashboard_user.py
+6 -2

0 comment

1 changed file

josephmancuso

pr closed time in 3 hours

issue closedMasoniteFramework/orm

model command migration argument suggestion

Describe the feature as you'd like to see it I think in most cases when you wan't to build a model and migration at the same time the migration should be creating a table.

What do we currently have to do now? Default -m argument edits existing table.

Additional context This command.

masonite-orm model [model-name] -m

will generate this migration.

"""[model-name] Migration."""

from masoniteorm.migrations import Migration


class [model-name](Migration):
    def up(self):
        """
        Run the migrations.
        """
        with self.schema.table([model-name]) as table:
            pass

    def down(self):
        """
        Revert the migrations.
        """
        pass

suggestion.

"""[model-name] Migration."""

from masoniteorm.migrations import Migration


class [model-name](Migration):
    def up(self):
        """
        Run the migrations.
        """
        with self.schema.create([model-name]) as table:
            pass

    def down(self):
        """
        Revert the migrations.
        """
        pass

  • [] Is this a breaking change? No

closed time in 3 hours

alfonsocv12

push eventMasoniteFramework/orm

Joe Mancuso

commit sha dfc09e5fdc1f18400a114048456c98256224b2e9

Fixed postgres long text

view details

Joseph Mancuso

commit sha bbec31568bc6b0c8f7e9a1e255d68b471c55d31c

Merge pull request #580 from MasoniteFramework/fix/577 Fixed postgres long text

view details

push time in 3 hours

PR merged MasoniteFramework/orm

Fixed postgres long text

Closes #577

+13 -1

0 comment

2 changed files

josephmancuso

pr closed time in 3 hours

issue closedMasoniteFramework/orm

Using `long_text()` with postgres does not work

Describe the bug When creating a table with long_text() with postgres it raises : type "longtext" does not exist.

Screenshots or code snippets

remote:   QueryException
remote: 
remote:   type "longtext" does not exist
remote:   LINE 1: ...uthor_email" VARCHAR(255) NOT NULL, "description" LONGTEXT N...
remote:                                                                ^
remote:   
remote: 
remote:   at .heroku/python/lib/python3.9/site-packages/masoniteorm/connections/PostgresConnection.py:158 in query
remote:       154│                     if "SELECT" in cursor.statusmessage:
remote:       155│                         return cursor.fetchall()
remote:       156│                     return {}
remote:       157│         except Exception as e:
remote:     → 158│             raise QueryException(str(e)) from e
remote:       159│         finally:
remote:       160│             if self.get_transaction_level() <= 0:
remote:       161│                 self.open = 0
remote:       162│                 self._connection.close()

Desktop (please complete the following information):

  • OS: Ubuntu

What database are you using?

  • Type: Postgres 13.5
  • Masonite ORM latest

closed time in 3 hours

girardinsamuel

push eventMasoniteFramework/orm

Joe Mancuso

commit sha f59fd007b760debf92c4ca8c968a49efdbaa0a48

formatted

view details

push time in 3 hours

PR opened MasoniteFramework/orm

added pep to model command

Closes #579

$ python orm model DashboardUser -p

Model created: app/dashboard_user.py
+7 -2

0 comment

1 changed file

pr created time in 3 hours

create barnchMasoniteFramework/orm

branch : feature/579

created branch time in 3 hours

push eventMasoniteFramework/orm

Samuel Girardin

commit sha 1c211bc77e971ce8ae44b872a9e2427466a96d7b

Add new framework classifier

view details

Samuel Girardin

commit sha 0ab6623d6982b002d0f008504aeea5f9b29c088c

Update setup.py

view details

Joseph Mancuso

commit sha 4f1599fe211d2337dc0250ddec15950409c49a6f

Merge pull request #570 from girardinsamuel/patch-1 WIP: Add new framework classifiers

view details

push time in 3 hours

PR merged MasoniteFramework/orm

WIP: Add new framework classifiers

Add Masonite framework generic classifier along with version classifier (I made a request to PyPi). This will allow this package to be listed on masonite-packages.

We should wait that PyPI new classifiers are created to merge this.

+1 -0

1 comment

1 changed file

girardinsamuel

pr closed time in 3 hours

PullRequestReviewEvent

issue commentMasoniteFramework/orm

Using `long_text()` with postgres does not work

Yes postgres doesn't have long text it should just be TEXT

girardinsamuel

comment created time in 3 hours

PR opened MasoniteFramework/orm

Fixed postgres long text

Closes #577

+13 -1

0 comment

2 changed files

pr created time in 3 hours

create barnchMasoniteFramework/orm

branch : fix/577

created branch time in 3 hours

issue commentMasoniteFramework/orm

model command migration argument suggestion

hmm this is wrong. @Marlysson do you want to handle this if you have some time?

alfonsocv12

comment created time in 4 hours

issue commentMasoniteFramework/orm

model command PEP8 standar

I personally like the pascal case for the file names so i am not open to change it but I would be open to adding like a -p flag for pep 8

alfonsocv12

comment created time in 4 hours

PullRequestReviewEvent

pull request commentMasoniteFramework/masonite

Throw exception if route is not found when in debug mode and add http error views

Everything else seems to work fine

girardinsamuel

comment created time in 4 hours

pull request commentMasoniteFramework/masonite

Throw exception if route is not found when in debug mode and add http error views

I believe this is due to the fact that I don't have a templates/errors/500.html page

girardinsamuel

comment created time in 4 hours

pull request commentMasoniteFramework/masonite

Throw exception if route is not found when in debug mode and add http error views

Tested this with APP_DEBUG false and got this error:

  File "/Users/personal/Desktop/test 4/venv4/lib/python3.9/site-packages/jinja2/loaders.py", line 319, in __init__
    raise ValueError(
ValueError: The 'templates' package was not installed in a way that PackageLoader understands.
girardinsamuel

comment created time in 4 hours

issue commentMasoniteFramework/masonite

Improve `response.view()` method

not really sure the issue you are trying to solve with this

girardinsamuel

comment created time in 4 hours

push eventMasoniteFramework/cookie-cutter

Samuel Girardin

commit sha 5ec0e6151d03149528d4af6744346716a84c37dc

simplify staticfiles aliases

view details

Samuel Girardin

commit sha 207d4242adac70cd4a58793e744abc4a3ddc731f

add default assets commented in base view

view details

Joseph Mancuso

commit sha 8bae27c7bab0eec65e37c0ee3b55d3366ed5d3c8

Merge pull request #30 from girardinsamuel/fix/29 Improve default assets aliases and use

view details

push time in 11 hours

issue closedMasoniteFramework/cookie-cutter

Include basic assets (js and css) in default view ?

Someone was mentioning this: then we just have to run npm run dev and start serving the app...but what if assets are not compiled, there will be 404 for the assets on the default page...

@josephmancuso How Laravel is handling this ?

Also the default staticfiles bindings were found to be not coherent, like css resource is served at assets/css but not js, so maybe we have to fix this too.

closed time in 11 hours

girardinsamuel
PullRequestReviewEvent
PullRequestReviewEvent
more