profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/johnthagen/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

axnsan12/drf-yasg 2427

Automated generation of real Swagger/OpenAPI 2.0 schemas from Django REST Framework code.

johnthagen/min-sized-rust 2415

🦀 How to minimize Rust binary size 📦

johnthagen/python-blueprint 198

:snake: Example Python project using best practices :nut_and_bolt:

johnthagen/clang-blueprint 78

:european_castle: Example C++11 CMake project that incorporates awesome Clang tooling :dragon:

johnthagen/rust-belt 52

:rocket: Asteroids-like arcade game implemented in Rust ✨

johnthagen/clion-cppcheck 22

:ballot_box_with_check: cppcheck plugin for CLion

sillsdev/TheCombine 11

This is a tool for supporting the rapid word collection workshop and post workshop clean-up

johnthagen/pytap2 9

Object oriented interface to Linux Tun/Tap devices for Python 3

johnthagen/cppcheck-junit 7

Converts Cppcheck XML output to JUnit XML.

johnthagen/exitstatus 5

:door: POSIX exit status definitions for Python

startedtfranzel/drf-spectacular-sidecar

started time in 2 days

issue commenttfranzel/drf-spectacular

Provide self-hosting swagger UI/Redoc support

@tfranzel This looks great! One small idea is that the drf-yasg porting section could link to this feature since users coming from that package might be expecting self hosting.

johnthagen

comment created time in 2 days

issue openedsillsdev/TheCombine

Deleting user email address causes 401 backend error

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Create a new user
  2. Login
  3. User Settings
  4. Delete the contents of email address and press save
401 Unauthorized
http://localhost:5000/v1/users/isemailtaken/

If this is not allowed, I believe the frontend should stop the user from trying to execute this action.

created time in 2 days

push eventsillsdev/TheCombine

johnthagen

commit sha 03f8fd6d56dcd49899696f5c57a7799af4e9a672

Revert testing change

view details

push time in 2 days

push eventsillsdev/TheCombine

johnthagen

commit sha 71c92d3a8cb9dc3e9b3bd5cd2e09661f7b6eede1

Pull in sweetalert2

view details

push time in 2 days

push eventsillsdev/TheCombine

Jim Grady

commit sha ac160963e82b09c96a05b7ca0e7ac4b2b86f2c46

K3s engine (#1382) * Migrate from microk8s to k3s for NUCs * Remove Helm installation * Configure systemd-resolved to use ap_gateway as a nameserver * Remove kubeconfig secret from AWS login jobs * Change from ClusterIssuers to Issuers for cert-manager

view details

johnthagen

commit sha 0491535898b9457bdfe5cbcd210e6dff9c7b3717

Merge branch 'master' into display-network-errors

view details

push time in 2 days

issue commentsweetalert2/sweetalert2

does sweetalert have notification like toastr notification

For the current version of sweetalert2 I had to modify the code slightly:

import Swal from "sweetalert2";

const toast = Swal.mixin({
  toast: true,
  position: 'top-end',
  showConfirmButton: false,
  timer: 3000
});

toast.fire({
  icon: "success",
  title: "Signed in successfully",
});
azarzaza

comment created time in 2 days

push eventsillsdev/TheCombine

johnthagen

commit sha a5c6e08308b883b4a056f23a78970b4aed8d04be

Fix frontend spelling typos (#1386)

view details

johnthagen

commit sha 70d1b54e7cbc348cf86173f8ee726313f5b336e5

Merge branch 'master' into display-network-errors

view details

push time in 2 days

PullRequestReviewEvent

delete branch sillsdev/TheCombine

delete branch : fix-frontend-typos

delete time in 2 days

push eventsillsdev/TheCombine

johnthagen

commit sha a5c6e08308b883b4a056f23a78970b4aed8d04be

Fix frontend spelling typos (#1386)

view details

push time in 2 days

PR merged sillsdev/TheCombine

Fix frontend spelling typos frontend maintenance

Fix spelling typos within the frontend source folder

<!-- Reviewable:start -->

This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+16 -16

0 comment

9 changed files

johnthagen

pr closed time in 2 days

push eventsillsdev/TheCombine

johnthagen

commit sha 8cbe0f177503bc9cc3303a5f2749e3331c13f36c

Change console.log to alert

view details

push time in 2 days

PR opened sillsdev/TheCombine

Display popups to alert users of bad network requests enhancement frontend

Closes #1125

+25 -4

0 comment

1 changed file

pr created time in 2 days

create barnchsillsdev/TheCombine

branch : display-network-errors

created branch time in 2 days

Pull request review commentsillsdev/TheCombine

Fix frontend spelling typos

 describe("Pronunciations", () => {     expect(iconRelease).toBeTruthy();   }); -  it("style depends on pronunciationsAtate", () => {

@imnasnainaec I actually am not sure what this was supposed to be, but took an educated guess. If you could confirm, that'd be great.

johnthagen

comment created time in 2 days

PullRequestReviewEvent

issue openedsillsdev/TheCombine

Evaluate usage of console.log

There are several instances where errors are logged to the console. These are easy to miss and should probably be surfaced visually so that the user/developer knows there are errors happening rather than silently ignored.

https://github.com/sillsdev/TheCombine/blob/edc23b50fe4f31735a3a222ae763a0507f6488d5/src/components/Login/LoginPage/LoginComponent.tsx#L194

https://github.com/sillsdev/TheCombine/blob/edc23b50fe4f31735a3a222ae763a0507f6488d5/src/backend/index.ts#L277

Related to #1125

created time in 2 days

PR opened sillsdev/TheCombine

Reviewers
Fix frontend spelling typos frontend maintenance

Fix spelling typos within the frontend source folder

+16 -16

0 comment

9 changed files

pr created time in 2 days

create barnchsillsdev/TheCombine

branch : fix-frontend-typos

created branch time in 2 days

PR merged sillsdev/TheCombine

Add site-wide banners enhancement backend frontend

Closes #1297

Also: enable attr_list Markdown extension in the user guide and center images.

TODO

  • [x] Display Banner.Login on the login page
  • [x] Display Banner.Announcement at the top of all pages
  • [x] Update Site Settings to allow admin users to update the Banner
  • [x] Fix useEffect getBanner() calls to not ignore returned promises
  • [x] Fix unit test (related to ignored promise)
  • [x] Fix styling on new UI elements (margins, etc)
  • [x] Add button for user to close a banner

Ideally for the announcement banner we could use https://github.com/alexplumb/material-ui-banner, but it does not support compiling under TypeScript: https://github.com/alexplumb/material-ui-banner/issues/8

<!-- Reviewable:start -->

This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+1127 -171

10 comments

56 changed files

johnthagen

pr closed time in 2 days

push eventsillsdev/TheCombine

johnthagen

commit sha edc23b50fe4f31735a3a222ae763a0507f6488d5

Add site-wide banners (#1319) * Add a basic banner model * Merge branch 'master' into banners * Merge branch 'master' into banners * Update model definition * Add banner repository * Merge branch 'master' into banners * Merge branch 'master' into banners * Add stub for controller * Merge branch 'master' into banners * Generate OpenAPI bindings * Add BannerContext * Return a bool from Update controller method * Fix Update method * Merge branch 'master' into banners * Merge branch 'master' into banners * Add BannerControllerTests * Add unit tests for banner controller when missing permissions * Add unit tests for the SiteBanner model * Add banners stub to site settings * Generate Banner component * Fix file encoding * Add backend getBanner function * Add basic site settings UI for banners * Add updateBanner backend helper function * Make ID's more specific * Merge branch 'master' into banners * Handle saving banners into database from site settings * Add TODO * Fmt * Merge branch 'master' into banners * Fetch banner when site settings are loaded * Render login banner on the login component * Fix equality operator * Add initial Announcement Banner support * Remove banners icons from site settings * Merge branch 'master' into banners * Cleanup tests. * Allow user to close banner; lasts until logout or banner update. * Merge branch 'master' into banners * Update package-lock.json * Merge branch 'master' into banners * Merge branch 'master' into banners * Cleanup ui, code * Update license report * Use .then() * Avoid general import * Fix typos, imports * Look for new banner on refresh and navigation * Little changes * Move from singleton banner to one banner per banner type * Add mfile missed in previous commit * In SiteSettings, split banners so each has own buttons * Fix lint warning; Update test * Fix bug that reset doesn't save * Merge branch 'master' into banners * Merge branch 'master' into banners * Update user guide * Add announcement banner image * Fmt * Remove bg color from login banner * Remove unused import * Remove unused import * Merge remote-tracking branch 'origin/banners' into banners * Add login image and center user guide images * Cleanup LocalStorage function, tests for ClosedBanner * Fix typo * Update login banner description

view details

push time in 2 days

delete branch sillsdev/TheCombine

delete branch : banners

delete time in 2 days

issue closedsillsdev/TheCombine

Add maintenance/admin messages to frontend

Add the ability to display maintenance and administration messages to the user, such as planned downtime for backups and upgrades.

The GitLab Broadcast Messages are an example implementation. See also GitLab's documentation on how to Customize the Help and sign-in page messages.

closed time in 2 days

jmgrady
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentsillsdev/TheCombine

K3s engine


scripts/kube_setup.py, line 1 at r3 (raw file):

#!/usr/bin/env python3

Are we planning to add an equivalent for k3s later?

<!-- Sent from Reviewable.io -->

jmgrady

comment created time in 2 days

pull request commentsillsdev/TheCombine

K3s engine


deploy/roles/k3s/tasks/main.yml, line 63 at r3 (raw file):

    state: present
    path: "{{ kubecfg }}"
    regexp: '^(\s+server: https:\/\/)[.0-9]+:(1?6443)'

An example before/after for this regex might make it easier to review. Does this run over port6443?

<!-- Sent from Reviewable.io -->

jmgrady

comment created time in 2 days

pull request commentsillsdev/TheCombine

Add site-wide banners


src/components/Login/RegisterPage/RegisterComponent.tsx, line 287 at r15 (raw file):


              {/* "Failed to register" */}
              {!!this.props.failureMessage && (

Similar to previous comment. We should probably discuss what our preferred style is relative to implicit boolean checks are.

<!-- Sent from Reviewable.io -->

johnthagen

comment created time in 2 days