profile
viewpoint
John Stallo johnsta Microsoft Corporation Redmond

greenie-msft/dev-spaces 0

Azure Dev Spaces is an Azure developer service that helps teams develop with speed on Kubernetes.

johnsta/api-service 0

A public API service for the BikeSharing app

johnsta/bikesharingweb 0

Bike Sharing web app

johnsta/dev-spaces 0

Azure Dev Spaces is an Azure developer service that helps teams develop with speed on Kubernetes.

johnsta/go-devspaces 0

Hello world Go sample app with instructions to run with Dev Spaces

johnsta/learnnextjs-demo 0

Demo App of the http://learnnextjs.com

push eventjohnsta/dev-spaces

John Stallo

commit sha 1e9e4bb070fea4308b41778902f79ad4abe0303e

test

view details

push time in 11 days

push eventjohnsta/dev-spaces

John Stallo

commit sha 20c39aabdab3fde3a9e4779dabd86e87f6856dcc

automate creation with script

view details

push time in 11 days

fork johnsta/dev-spaces

Azure Dev Spaces is an Azure developer service that helps teams develop with speed on Kubernetes.

fork in 11 days

push eventjohnsta/dev-spaces

John Stallo

commit sha 0f21c9f405aa7fb9d2066ec977a547ae8bd3925d

Update bikes.yml

view details

John Stallo

commit sha 9b806537a8d08c2aafb62ec27916ecebeb9c3478

Merge pull request #3 from johnsta/master Update bikes.yml

view details

push time in 3 months

PR merged johnsta/dev-spaces

Update bikes.yml
+2 -2

0 comment

1 changed file

johnsta

pr closed time in 3 months

PR opened johnsta/dev-spaces

Update bikes.yml
+2 -2

0 comment

1 changed file

pr created time in 3 months

push eventjohnsta/dev-spaces

John Stallo

commit sha 0f21c9f405aa7fb9d2066ec977a547ae8bd3925d

Update bikes.yml

view details

push time in 3 months

PR opened johnsta/dev-spaces

Fix bike images
+1 -270

0 comment

3 changed files

pr created time in 3 months

PR closed johnsta/dev-spaces

Fix bike images
+1 -270

0 comment

3 changed files

johnsta

pr closed time in 3 months

PR opened johnsta/dev-spaces

Fix bike images
+1 -270

0 comment

3 changed files

pr created time in 3 months

create barnchjohnsta/dev-spaces

branch : fix-bike-images

created branch time in 3 months

fork johnsta/dev-spaces

Azure Dev Spaces is an Azure developer service that helps teams develop with speed on Kubernetes.

fork in 3 months

push eventjohnsta/dev-spaces

Nick

commit sha 88443117fdd34dc2c167fefa1e80cf2955528299

Add existingWindowsBackend application to sample apps

view details

Philo

commit sha 93606bc97da3151e59d46d1185929f9084e3ee80

Merge pull request #134 from Greenie0506/existingWindowsContainer Existing windows container

view details

Nick

commit sha 55dc05b26f1a66fdf32377b064ad3fe5010f91ab

Always include bootstrap stylesheet

view details

Philo

commit sha 0157d8647f4c5975bd74bf638801a7f24b5af08b

Merge pull request #136 from Greenie0506/frontend_styles Always include bootstrap stylesheet

view details

Nick

commit sha 8bf2ae346e1714c48bb936d68f4e6b360574d786

Add existing windows container description to the samples Readme

view details

Xin Yan

commit sha 02bd4e83750d86ffb45cf38136b707a4a2851245

RequestLoggingMiddleware is not aware certain HTTP response can not carry body. Setting body on HTTP status such as 204 will cause exception. This repros today already by going through a bike renting flow and examine the logs of Gateway container. If running under a debugger, the exception will fail the request. Fix the issue by skipping setting HTTP body for 204, 205 and 304. This is what asp.net core checks in AspNetCore\src\Servers\Kestrel\Core\src\Internal\Http\ HttpProtocol.cs.

view details

Philo

commit sha 080910d29a086de3027834ce879119a76a5e0b05

Merge pull request #141 from xinyanmsft/master bug fix in Gateway

view details

daniv-msft

commit sha 88a56705cc1b603c4276608506c698e5525e8a89

Fix missing bike images

view details

daniv-msft

commit sha 498dd8fca7e7eb9d4017cfaa3f4633ef9bcac49d

PR comment

view details

daniv-msft

commit sha 4a01fc992a8972d9b34bbd267fb7b87920df1df3

Update charts tags to match latest builds

view details

Nick

commit sha 3fd21cfa68b2e65e82826b15112123c37b568837

Add bikes pr workflow and biksharing workflow for GitHub Actions

view details

Nick

commit sha 685c6e4d6cc7cbec17a6294e3de9ee0052164afa

Fix spelling on Action label

view details

Nick

commit sha a2abab9b6a668bb625ae6debbead3aba1679cea9

Change secret from PARENT_SPACE to MASTER_SPACE

view details

Philo

commit sha 5ce9013eb35f650f539837f84e4f16dc45b67639

Merge pull request #165 from Azure/add_github_actions Add bikes pr workflow and bikesharing workflow for GitHub Actions

view details

Nick

commit sha e6b6e3cb2f77db36f2f81cdfe1877cd169a89108

Format helm commands

view details

Anupama Tuli

commit sha 90e1b55d97d41a0bdabe37ab5a8076e62f5febb6

1. Update Bikes.yml to include /** under paths such that the workflow gets triggered recursively under the paths specified. 2.Add yml code such that the review url is added at the end of the flow.

view details

greenie-msft

commit sha ce8b516f2e1e444a117c6b0d5abf7837fd54c4db

Merge pull request #171 from Azure/anutuli/updateBikes 1. Update Bikes.yml to include /** under paths and add review url

view details

Anupama Tuli

commit sha dfcccff8ecf6fe37ec59a396e34734f03c256eb6

Add label using kubectl for pull request flow

view details

Anupama Tuli

commit sha 4e08064b2bda5ab0b959e027ddea2cda8597f1a3

Changing the label to be azds.io/pull-request

view details

Anupama Tuli

commit sha e97673b1ba7f58c734279c4d5d5a5845a29586a2

Updating the label on pull request namespace

view details

push time in 3 months

PR merged johnsta/dev-spaces

Merge from azure/dev-spaces
+6804 -33

0 comment

84 changed files

johnsta

pr closed time in 3 months

PR opened johnsta/dev-spaces

Merge from azure/dev-spaces
+6804 -33

0 comment

84 changed files

pr created time in 3 months

delete branch Azure/dev-spaces

delete branch : parent-space-update

delete time in 3 months

PR closed Azure/dev-spaces

Name parent space as 'master'

Helps encourage the feature branch concept

+2 -2

1 comment

1 changed file

johnsta

pr closed time in 3 months

pull request commentAzure/dev-spaces

Name parent space as 'master'

We'll leave it as it is ('dev') since it breaks other quickstarts

johnsta

comment created time in 3 months

delete branch Azure/dev-spaces

delete branch : bikesharing-setup

delete time in 3 months

delete branch Azure/dev-spaces

delete branch : delete-cloud-resources

delete time in 3 months

create barnchAzure/dev-spaces

branch : parent-space-update

created branch time in 3 months

PR opened Azure/dev-spaces

Name parent space as 'master'

Helps encourage the feature branch concept

+2 -2

0 comment

1 changed file

pr created time in 3 months

PR opened Azure/dev-spaces

Add steps to delete cloud resources
+6 -0

0 comment

1 changed file

pr created time in 3 months

create barnchAzure/dev-spaces

branch : delete-cloud-resources

created branch time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha 018b6ba678417afc109161d4f71b1d9b52ad0cc3

responding to PR feedback

view details

push time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+*Bike Sharing* is a microservices-based sample application that helps showcase the sandboxing capabilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)

Good catch! I updated the link.

johnsta

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+*Bike Sharing* is a microservices-based sample application that helps showcase the sandboxing capabilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `MyResourceGroup` and an AKS cluster called `MyAKS` in the `eastus` region.++    ```bash+    az login+    az group create --name MyResourceGroup --location eastus+    az aks create -g MyResourceGroup -n MyAKS --location eastus --disable-rbac --generate-ssh-keys+    ```++1. **Enable Azure Dev Spaces on the AKS cluster.**+    ```bash+    az aks use-dev-spaces -g MyResourceGroup -n MyAKS --space master --yes+    ```++## Deploy the BikeSharing sample app++1. **Create a fork of this GitHub repo.** It's better to create a *fork* for this exercise so that you can save your own commits and repo configuration.

I added a link to GitHub documentation on how to create a fork.

johnsta

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+*Bike Sharing* is a microservices-based sample application that helps showcase the sandboxing capabilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `MyResourceGroup` and an AKS cluster called `MyAKS` in the `eastus` region.++    ```bash+    az login+    az group create --name MyResourceGroup --location eastus+    az aks create -g MyResourceGroup -n MyAKS --location eastus --disable-rbac --generate-ssh-keys+    ```++1. **Enable Azure Dev Spaces on the AKS cluster.**+    ```bash+    az aks use-dev-spaces -g MyResourceGroup -n MyAKS --space master --yes+    ```++## Deploy the BikeSharing sample app++1. **Create a fork of this GitHub repo.** It's better to create a *fork* for this exercise so that you can save your own commits and repo configuration.++1. **Clone your fork and navigate into its directory**.+    ```bash+    git clone https://github.com/USERNAME/dev-spaces+    cd dev-spaces/samples/BikeSharingApp/+    ```++1. **Retrieve the HostSuffix for the `master` dev space.**+    ```bash+    azds show-context++    Name                ResourceGroup     DevSpace  HostSuffix+    ------------------  ----------------  --------  -----------------------+    MyAKS               MyResourceGroup   master    fedcab0987.eus.azds.io+    ```++1. **Update the Helm chart with your HostSuffix.** Open [`charts/values.yaml`](https://github.com/Azure/dev-spaces/blob/master/samples/BikeSharingApp/charts/values.yaml) and replace all instances of `<REPLACE_ME_WITH_HOST_SUFFIX>` with the HostSuffix value you retrieved earlier. Save your changes and close the file.

I added this as the last step so that the user can validate they have a successful deployment before committing to master.

johnsta

comment created time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha 2e74a26e404714baeaf202c7a8c8d1eea0f3cc84

type

view details

push time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha bcdaec078d74308478e636c2793311a108a00e88

Commit and push helm update to fork

view details

push time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+*Bike Sharing* is a microservices-based sample application that helps showcase the sandboxing capabilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `bikesharing-group` and an AKS cluster called `bikesharing-cluster` in the `eastus` region.++    ```bash+    GROUP_NAME=bikesharing-group+    AKS_NAME=bikesharing-cluster+    LOCATION=eastus++    az login+    az group create --name $GROUP_NAME --location $LOCATION+    az aks create -g $GROUP_NAME -n $AKS_NAME --location $LOCATION --disable-rbac --generate-ssh-keys+    ```++1. **Enable Azure Dev Spaces on the AKS cluster.**+    ```bash+    az aks use-dev-spaces -g $GROUP_NAME -n $AKS_NAME --space master --yes+    ```++<!-- 1. **Create an Azure Container Registry.** Save the loginServer value from the output because it is used in a later step.+    ```bash+    ACR_NAME=bikesharing-container-registry+    az acr create -g $GROUP_NAME --name $ACR_NAME --sku Basic+    ```++1. **Set up role access for the cluster and container registry.** Note: The user running these commands needs to be an *owner* of the target resources.+    ```bash+    # Save the output from this command, you'll need the `clientId` value for the next commands+    az ad sp create-for-rbac --sdk-auth --skip-assignment ++    # Get the AKS resource id+    az aks show -g $GROUP_NAME -n $AKS_NAME --query id -o tsv++    # Create role assignment for access to AKS cluster+    az role assignment create --assignee <clientId> --scope "<aksResourceId>" --role Contributor++    # Get the container registry (ACR) id+    az acr show -g $GROUP_NAME -n $ACR_NAME --query id -o tsv+    +    # Create role assignment for 'push access' to container registry+    az role assignment create --assignee  <clientId>  --scope "<acrResourceId>" --role AcrPush+    ```+ -->+++## Deploy the BikeSharing sample app++1. **Create a fork of this GitHub repo.** It's better to create a *fork* for this exercise so that you can save your own commits and repo configuration.++1. **Clone your fork and navigate into its directory**.+    ```bash+    git clone https://github.com/USERNAME/dev-spaces+    cd dev-spaces/samples/BikeSharingApp/+    ```++1. **Retrieve the HostSuffix for the `master` dev space.**+    ```bash+    azds show-context++    Name                ResourceGroup     DevSpace  HostSuffix+    ------------------  ----------------  --------  -----------------------+    MyAKS               MyResourceGroup   master    fedcab0987.eus.azds.io+    ```++1. **Update the Helm chart with your HostSuffix.** Open [`charts/values.yaml`](https://github.com/Azure/dev-spaces/blob/master/samples/BikeSharingApp/charts/values.yaml) and replace all instances of `<REPLACE_ME_WITH_HOST_SUFFIX>` with the HostSuffix value you retrieved earlier. Save your changes and close the file.++1. **Deploy the sample application to Kubernetes.** We'll use Helm to run this sample application, but other tooling could be used to run your entire application in a namespace within a cluster. The Helm commands are targeting the namespace named `master` you created earlier, and can take several minutes to complete.+    ```bash+    cd charts/+    helm init --wait+    helm install -n bikesharing . --dep-up --namespace master --atomic+    ```+    Note: **If you are using an RBAC-enabled cluster**, be sure to configure [a service account for Tiller](https://helm.sh/docs/using_helm/#role-based-access-control). Otherwise, `helm` commands will fail.++1. **Open your browser to the app's website.** Run the `azds list-uris` command to see the public endpoints in the running app. Navigate to the `bikesharingweb` service - in the below example, the public URL for the `bikesharingweb` service is http://master.bikesharingweb.fedcab0987.eus.azds.io/. Select **Aurelia Briggs (customer)** as the user, then select a bike to rent.+    ```bash+    azds list-uris++    Uri                                                   Status+    --------------------------------------------------    ---------+    http://master.bikesharingweb.fedcab0987.eus.azds.io/  Available+    http://master.gateway.fedcab0987.eus.azds.io/         Available+    ```++## Next Steps+Now that you have the BikeSharing app deployed in AKS, try these walkthroughs try these walkthroughs to learn how Dev Spaces can enhance the Kubernetes development experience:++1. **[Use your public endpoint in the cloud to privately debug backend code that’s running on your local dev machine.](https://aka.ms/devspaces/connect)** This minimizes what you need to set up on your dev machine – the only thing you need to run on your machine is the microservice you’re working on and your preferred dev tools, no need to set up mocks or simulators. You don’t even need Kubernetes YAML or Docker configuration to do this, and you won’t affect the currently deployed app or anyone who’s using the AKS cluster.++1. **[Combine GitHub Actions with Dev Spaces in a pull request review.](https://aka.ms/devspaces/pr-flow)** You can use GitHub Actions to automatically deploy to a new sandbox whenever a pull request is opened so that your team can review a live version of the app that includes your pull request changes – all before that code is merged into your main branch! As a bonus, team members such as product managers and designers can become part of the review process during early stages of development.++1. **[Debug and iterate code directly in AKS.](https://docs.microsoft.com/azure/dev-spaces/quickstart-netcore)** This is similar to the first scenario, except this mode enables a *higher fidelity development and testing experience* by helping you build and run a container image directly in AKS. Dev Spaces can help you generate Docker and Kubernetes assets.

Done

johnsta

comment created time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha e52a300f544cca9b88da55f84f8b8d05e83d87a9

Tweak next scenarios

view details

push time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha de84c322147cbc8db1e5da44efde76b2ef5e99f1

Inline resource names for better cross-platform

view details

push time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+BikeSharing is a microservices-based sample application that helps showcase the sandboxing capbilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `bikesharing-group` and an AKS cluster called `bikesharing-cluster` in the `eastus` region.++    ```bash+    GROUP_NAME=bikesharing-group+    AKS_NAME=bikesharing-cluster+    LOCATION=eastus

Agree we don't gain much by parametrizing this - there were originally more commands so there was greater benefit. I've updated to leave the names inline.

johnsta

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+BikeSharing is a microservices-based sample application that helps showcase the sandboxing capbilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `bikesharing-group` and an AKS cluster called `bikesharing-cluster` in the `eastus` region.++    ```bash+    GROUP_NAME=bikesharing-group+    AKS_NAME=bikesharing-cluster+    LOCATION=eastus++    az group create --name $GROUP_NAME --location $LOCATION+    az aks create -g $GROUP_NAME -n $AKS_NAME --location $LOCATION --disable-rbac --generate-ssh-keys+    ```++1. **Enable Azure Dev Spaces on the AKS cluster.**+    ```bash+    az aks use-dev-spaces -g $GROUP_NAME -n $AKS_NAME --space master --yes+    ```++<!-- 1. **Create an Azure Container Registry.** Save the loginServer value from the output because it is used in a later step.+    ```bash+    ACR_NAME=bikesharing-container-registry+    az acr create -g $GROUP_NAME --name $ACR_NAME --sku Basic+    ```++1. **Set up role access for the cluster and container registry.** Note: The user running these commands needs to be an *owner* of the target resources.+    ```bash+    # Save the output from this command, you'll need the `clientId` value for the next commands+    az ad sp create-for-rbac --sdk-auth --skip-assignment ++    # Get the AKS resource id+    az aks show -g $GROUP_NAME -n $AKS_NAME --query id -o tsv++    # Create role assignment for access to AKS cluster+    az role assignment create --assignee <clientId> --scope "<aksResourceId>" --role Contributor++    # Get the container registry (ACR) id+    az acr show -g $GROUP_NAME -n $ACR_NAME --query id -o tsv+    +    # Create role assignment for 'push access' to container registry+    az role assignment create --assignee  <clientId>  --scope "<acrResourceId>" --role AcrPush+    ```+ -->

Removed block

johnsta

comment created time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha bc42ad8400c872cfde122802813f0c76c97515fd

More feedback updates

view details

push time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+BikeSharing is a microservices-based sample application that helps showcase the sandboxing capbilities of [Azure Dev Spaces](https://aka.ms/devspaces). 

Good catch!

johnsta

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+BikeSharing is a microservices-based sample application that helps showcase the sandboxing capbilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `bikesharing-group` and an AKS cluster called `bikesharing-cluster` in the `eastus` region.++    ```bash+    GROUP_NAME=bikesharing-group+    AKS_NAME=bikesharing-cluster+    LOCATION=eastus++    az group create --name $GROUP_NAME --location $LOCATION+    az aks create -g $GROUP_NAME -n $AKS_NAME --location $LOCATION --disable-rbac --generate-ssh-keys+    ```++1. **Enable Azure Dev Spaces on the AKS cluster.**+    ```bash+    az aks use-dev-spaces -g $GROUP_NAME -n $AKS_NAME --space master --yes+    ```++<!-- 1. **Create an Azure Container Registry.** Save the loginServer value from the output because it is used in a later step.+    ```bash+    ACR_NAME=bikesharing-container-registry+    az acr create -g $GROUP_NAME --name $ACR_NAME --sku Basic+    ```++1. **Set up role access for the cluster and container registry.** Note: The user running these commands needs to be an *owner* of the target resources.+    ```bash+    # Save the output from this command, you'll need the `clientId` value for the next commands+    az ad sp create-for-rbac --sdk-auth --skip-assignment ++    # Get the AKS resource id+    az aks show -g $GROUP_NAME -n $AKS_NAME --query id -o tsv++    # Create role assignment for access to AKS cluster+    az role assignment create --assignee <clientId> --scope "<aksResourceId>" --role Contributor++    # Get the container registry (ACR) id+    az acr show -g $GROUP_NAME -n $ACR_NAME --query id -o tsv+    +    # Create role assignment for 'push access' to container registry+    az role assignment create --assignee  <clientId>  --scope "<acrResourceId>" --role AcrPush+    ```+ -->

This block is currently commented out and not required.

johnsta

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+BikeSharing is a microservices-based sample application that helps showcase the sandboxing capbilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `bikesharing-group` and an AKS cluster called `bikesharing-cluster` in the `eastus` region.++    ```bash+    GROUP_NAME=bikesharing-group+    AKS_NAME=bikesharing-cluster+    LOCATION=eastus++    az group create --name $GROUP_NAME --location $LOCATION+    az aks create -g $GROUP_NAME -n $AKS_NAME --location $LOCATION --disable-rbac --generate-ssh-keys+    ```++1. **Enable Azure Dev Spaces on the AKS cluster.**+    ```bash+    az aks use-dev-spaces -g $GROUP_NAME -n $AKS_NAME --space master --yes+    ```++<!-- 1. **Create an Azure Container Registry.** Save the loginServer value from the output because it is used in a later step.+    ```bash+    ACR_NAME=bikesharing-container-registry+    az acr create -g $GROUP_NAME --name $ACR_NAME --sku Basic+    ```++1. **Set up role access for the cluster and container registry.** Note: The user running these commands needs to be an *owner* of the target resources.+    ```bash+    # Save the output from this command, you'll need the `clientId` value for the next commands+    az ad sp create-for-rbac --sdk-auth --skip-assignment ++    # Get the AKS resource id+    az aks show -g $GROUP_NAME -n $AKS_NAME --query id -o tsv++    # Create role assignment for access to AKS cluster+    az role assignment create --assignee <clientId> --scope "<aksResourceId>" --role Contributor++    # Get the container registry (ACR) id+    az acr show -g $GROUP_NAME -n $ACR_NAME --query id -o tsv+    +    # Create role assignment for 'push access' to container registry+    az role assignment create --assignee  <clientId>  --scope "<acrResourceId>" --role AcrPush+    ```+ -->+++## Deploy the BikeSharing sample app++1. **Create a fork of this GitHub repo.** We need a *fork* because we'll be setting some GitHub Secrets to configure GitHub Actions in our workflow.++1. **Clone your fork and navigate into its directory**.+    ```bash+    git clone https://github.com/USERNAME/dev-spaces+    cd dev-spaces/samples/BikeSharingApp/+    ```++1. **Retrieve the HostSuffix for the `master` dev space.**+    ```bash+    azds show-context++    Name                ResourceGroup     DevSpace  HostSuffix+    ------------------  ----------------  --------  -----------------------+    MyAKS               MyResourceGroup   master    fedcab0987.eus.azds.io+    ```++1. **Update the Helm chart with your HostSuffix.** Open [`charts/values.yaml`](https://github.com/Azure/dev-spaces/blob/master/samples/BikeSharingApp/charts/values.yaml) and replace all instances of `<REPLACE_ME_WITH_HOST_SUFFIX>` with the HostSuffix value you retrieved earlier. Save your changes and close the file.++1. **Deploy the sample application to Kubernetes.** We'll use Helm to run this sample application, but other tooling could be used to run your entire application in a namespace within a cluster. The Helm commands are targeting the namespace named `master` you created earlier, and can take several minutes to complete.+    ```bash+    cd charts/+    helm init --wait+    helm install -n bikesharing . --dep-up --namespace master --atomic+    ```+    Note: **If you are using an RBAC-enabled cluster**, be sure to configure [a service account for Tiller](https://helm.sh/docs/using_helm/#role-based-access-control). Otherwise, `helm` commands will fail.++1. **Open your browser to the app's website.** Navigate to the `bikesharingweb` service by opening the public URL from the `azds list-uris` command. In the below example, the public URL for the `bikesharingweb` service is http://master.bikesharingweb.fedcab0987.eus.azds.io/. Select **Aurelia Briggs (customer)** as the user, then select a bike to rent.+    ```bash+    azds list-uris++    Uri                                                   Status+    --------------------------------------------------    ---------+    http://master.bikesharingweb.fedcab0987.eus.azds.io/  Available+    http://master.gateway.fedcab0987.eus.azds.io/         Available+    ```++## Next Steps

Done. Note that this points to our existing quickstart which is not bikesharing-based. We could consider updating the quickstart once we have better automation around setting up the bikesharing sample.

johnsta

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+BikeSharing is a microservices-based sample application that helps showcase the sandboxing capbilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `bikesharing-group` and an AKS cluster called `bikesharing-cluster` in the `eastus` region.++    ```bash+    GROUP_NAME=bikesharing-group+    AKS_NAME=bikesharing-cluster+    LOCATION=eastus++    az group create --name $GROUP_NAME --location $LOCATION+    az aks create -g $GROUP_NAME -n $AKS_NAME --location $LOCATION --disable-rbac --generate-ssh-keys+    ```++1. **Enable Azure Dev Spaces on the AKS cluster.**+    ```bash+    az aks use-dev-spaces -g $GROUP_NAME -n $AKS_NAME --space master --yes+    ```++<!-- 1. **Create an Azure Container Registry.** Save the loginServer value from the output because it is used in a later step.+    ```bash+    ACR_NAME=bikesharing-container-registry+    az acr create -g $GROUP_NAME --name $ACR_NAME --sku Basic+    ```++1. **Set up role access for the cluster and container registry.** Note: The user running these commands needs to be an *owner* of the target resources.+    ```bash+    # Save the output from this command, you'll need the `clientId` value for the next commands+    az ad sp create-for-rbac --sdk-auth --skip-assignment ++    # Get the AKS resource id+    az aks show -g $GROUP_NAME -n $AKS_NAME --query id -o tsv++    # Create role assignment for access to AKS cluster+    az role assignment create --assignee <clientId> --scope "<aksResourceId>" --role Contributor++    # Get the container registry (ACR) id+    az acr show -g $GROUP_NAME -n $ACR_NAME --query id -o tsv+    +    # Create role assignment for 'push access' to container registry+    az role assignment create --assignee  <clientId>  --scope "<acrResourceId>" --role AcrPush+    ```+ -->+++## Deploy the BikeSharing sample app++1. **Create a fork of this GitHub repo.** We need a *fork* because we'll be setting some GitHub Secrets to configure GitHub Actions in our workflow.++1. **Clone your fork and navigate into its directory**.+    ```bash+    git clone https://github.com/USERNAME/dev-spaces+    cd dev-spaces/samples/BikeSharingApp/+    ```++1. **Retrieve the HostSuffix for the `master` dev space.**+    ```bash+    azds show-context++    Name                ResourceGroup     DevSpace  HostSuffix+    ------------------  ----------------  --------  -----------------------+    MyAKS               MyResourceGroup   master    fedcab0987.eus.azds.io+    ```++1. **Update the Helm chart with your HostSuffix.** Open [`charts/values.yaml`](https://github.com/Azure/dev-spaces/blob/master/samples/BikeSharingApp/charts/values.yaml) and replace all instances of `<REPLACE_ME_WITH_HOST_SUFFIX>` with the HostSuffix value you retrieved earlier. Save your changes and close the file.++1. **Deploy the sample application to Kubernetes.** We'll use Helm to run this sample application, but other tooling could be used to run your entire application in a namespace within a cluster. The Helm commands are targeting the namespace named `master` you created earlier, and can take several minutes to complete.+    ```bash+    cd charts/+    helm init --wait+    helm install -n bikesharing . --dep-up --namespace master --atomic+    ```+    Note: **If you are using an RBAC-enabled cluster**, be sure to configure [a service account for Tiller](https://helm.sh/docs/using_helm/#role-based-access-control). Otherwise, `helm` commands will fail.++1. **Open your browser to the app's website.** Navigate to the `bikesharingweb` service by opening the public URL from the `azds list-uris` command. In the below example, the public URL for the `bikesharingweb` service is http://master.bikesharingweb.fedcab0987.eus.azds.io/. Select **Aurelia Briggs (customer)** as the user, then select a bike to rent.

I like that better - changed!

johnsta

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+BikeSharing is a microservices-based sample application that helps showcase the sandboxing capbilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `bikesharing-group` and an AKS cluster called `bikesharing-cluster` in the `eastus` region.++    ```bash+    GROUP_NAME=bikesharing-group+    AKS_NAME=bikesharing-cluster+    LOCATION=eastus++    az group create --name $GROUP_NAME --location $LOCATION+    az aks create -g $GROUP_NAME -n $AKS_NAME --location $LOCATION --disable-rbac --generate-ssh-keys+    ```++1. **Enable Azure Dev Spaces on the AKS cluster.**+    ```bash+    az aks use-dev-spaces -g $GROUP_NAME -n $AKS_NAME --space master --yes+    ```++<!-- 1. **Create an Azure Container Registry.** Save the loginServer value from the output because it is used in a later step.+    ```bash+    ACR_NAME=bikesharing-container-registry+    az acr create -g $GROUP_NAME --name $ACR_NAME --sku Basic+    ```++1. **Set up role access for the cluster and container registry.** Note: The user running these commands needs to be an *owner* of the target resources.+    ```bash+    # Save the output from this command, you'll need the `clientId` value for the next commands+    az ad sp create-for-rbac --sdk-auth --skip-assignment ++    # Get the AKS resource id+    az aks show -g $GROUP_NAME -n $AKS_NAME --query id -o tsv++    # Create role assignment for access to AKS cluster+    az role assignment create --assignee <clientId> --scope "<aksResourceId>" --role Contributor++    # Get the container registry (ACR) id+    az acr show -g $GROUP_NAME -n $ACR_NAME --query id -o tsv+    +    # Create role assignment for 'push access' to container registry+    az role assignment create --assignee  <clientId>  --scope "<acrResourceId>" --role AcrPush+    ```+ -->+++## Deploy the BikeSharing sample app++1. **Create a fork of this GitHub repo.** We need a *fork* because we'll be setting some GitHub Secrets to configure GitHub Actions in our workflow.

Good catch. I added: It's better to create a fork for this exercise so that you can save your own commits and repo configuration.

johnsta

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+BikeSharing is a microservices-based sample application that helps showcase the sandboxing capbilities of [Azure Dev Spaces](https://aka.ms/devspaces). 

Fixed

johnsta

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Bikesharing setup

-# Bike Sharing Sample: Iteratively Develop and Debug Microservices in Kubernetes+# Deploy the Bike Sharing sample application to Azure Kubernetes Service -## Quickstart-[Quickstart: Team development on Kubernetes using Azure Dev Spaces](https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-team-development).\ No newline at end of file+BikeSharing is a microservices-based sample application that helps showcase the sandboxing capbilities of [Azure Dev Spaces](https://aka.ms/devspaces). ++Follow the steps below to deploy this sample app to Azure Kubernete Service (AKS).++## Prerequisites+* [Azure subscription](https://azure.microsoft.com/free)+* [Azure CLI](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest)+* [Helm 2.13 (or greater)](https://github.com/helm/helm/blob/master/docs/install.md)++## Configure Azure resources++1. **Create an Azure Kubernetes Service cluster.** You must create an AKS cluster in a [supported region](https://docs.microsoft.com/azure/dev-spaces/about#supported-regions-and-configurations). The below commands create a resource group called `bikesharing-group` and an AKS cluster called `bikesharing-cluster` in the `eastus` region.

Agreed, added az login step.

johnsta

comment created time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha eac838bcd4ba060b4fda6cffedca4f877a443f07

Updates based on feedback

view details

push time in 3 months

PR opened Azure/dev-spaces

Bikesharing setup

Detailed steps for deploying the Bike Sharing sample app to AKS

+99 -3

0 comment

1 changed file

pr created time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha cb3ea9e2321496c7fe434dc671705e8a8282afd2

Fix command parameter typos

view details

push time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha c081c99258081f236df5f24b6aed42840bb14042

Update steps

view details

push time in 3 months

push eventAzure/dev-spaces

John Stallo

commit sha 0c3335c4b71eb535fbaf09c36e14e8664edc25c7

Update title

view details

push time in 3 months

create barnchAzure/dev-spaces

branch : bikesharing-setup

created branch time in 3 months

Pull request review commentAzure/dev-spaces

Add support for GitHub action add review url

+# Azure Dev Spaces GitHub Action for adding the review url on pull request
+add-review-url GitHub Action can be used to write a comment on the pull request which is the app review url hence enabling the testing prior to checkin
+
+## Pull Request workflow can have the below snippet
+Refer to the documentation for [Azure Dev-spaces sample app](https://github.com/Azure/dev-spaces/) - [Pull Request Flow Documentation for Azure Dev Spaces](https://review.docs.microsoft.com/en-us/azure/dev-spaces/how-to/github-actions?branch=pr-en-us-91033)
+
+## Example workflow syntax on how this GitHub Action can be used 
+Refer: [Pull Request worflow for Azure dev-spaces](https://github.com/Azure/dev-spaces/blob/master/.github/workflows/bikes.yml)
+```
+    - uses: azure/dev-spaces/actions/add-review-url@Releases/v1              
+        with:
+            repo-token: ${{ secrets.GITHUB_TOKEN }}  
+            host: ${{ secrets.HOST }}
+ ```       
+where secrets.HOST value is the host for your Dev Space. Refer [Pull Request Flow Documentation for Azure Dev Spaces](https://review.docs.microsoft.com/en-us/azure/dev-spaces/how-to/github-actions?branch=pr-en-us-91033#configure-your-github-action)
+
+## Try out the code - you will need node_modules to be built

How to build this GitHub Action for development

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Add support for GitHub action add review url

+# Azure Dev Spaces GitHub Action for adding the review url on pull request
+add-review-url GitHub Action can be used to write a comment on the pull request which is the app review url hence enabling the testing prior to checkin
+
+## Pull Request workflow can have the below snippet
+Refer to the documentation for [Azure Dev-spaces sample app](https://github.com/Azure/dev-spaces/) - [Pull Request Flow Documentation for Azure Dev Spaces](https://review.docs.microsoft.com/en-us/azure/dev-spaces/how-to/github-actions?branch=pr-en-us-91033)
+
+## Example workflow syntax on how this GitHub Action can be used 
+Refer: [Pull Request worflow for Azure dev-spaces](https://github.com/Azure/dev-spaces/blob/master/.github/workflows/bikes.yml)
+```
+    - uses: azure/dev-spaces/actions/add-review-url@Releases/v1              
+        with:
+            repo-token: ${{ secrets.GITHUB_TOKEN }}  
+            host: ${{ secrets.HOST }}
+ ```       
+where secrets.HOST value is the host for your Dev Space. Refer [Pull Request Flow Documentation for Azure Dev Spaces](https://review.docs.microsoft.com/en-us/azure/dev-spaces/how-to/github-actions?branch=pr-en-us-91033#configure-your-github-action)

where secrets.HOST is the host URL for the app deployed in AKS. See Pull Request Flow Documentation for Azure Dev Spaces.

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Add support for GitHub action add review url

+# Azure Dev Spaces GitHub Action for adding the review url on pull request
+add-review-url GitHub Action can be used to write a comment on the pull request which is the app review url hence enabling the testing prior to checkin
+
+## Pull Request workflow can have the below snippet
+Refer to the documentation for [Azure Dev-spaces sample app](https://github.com/Azure/dev-spaces/) - [Pull Request Flow Documentation for Azure Dev Spaces](https://review.docs.microsoft.com/en-us/azure/dev-spaces/how-to/github-actions?branch=pr-en-us-91033)
+
+## Example workflow syntax on how this GitHub Action can be used 
+Refer: [Pull Request worflow for Azure dev-spaces](https://github.com/Azure/dev-spaces/blob/master/.github/workflows/bikes.yml)

Suggested wording: The following Action snippet is used in the Bikesharing sample PR workflow:

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Add support for GitHub action add review url

+# Azure Dev Spaces GitHub Action for adding the review url on pull request
+add-review-url GitHub Action can be used to write a comment on the pull request which is the app review url hence enabling the testing prior to checkin
+
+## Pull Request workflow can have the below snippet
+Refer to the documentation for [Azure Dev-spaces sample app](https://github.com/Azure/dev-spaces/) - [Pull Request Flow Documentation for Azure Dev Spaces](https://review.docs.microsoft.com/en-us/azure/dev-spaces/how-to/github-actions?branch=pr-en-us-91033)
+
+## Example workflow syntax on how this GitHub Action can be used 

Shorten to: Example workflow syntax

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Add support for GitHub action add review url

+# Azure Dev Spaces GitHub Action for adding the review url on pull request
+add-review-url GitHub Action can be used to write a comment on the pull request which is the app review url hence enabling the testing prior to checkin
+
+## Pull Request workflow can have the below snippet

An alternative heading could be: How to include this action in our pull request workflow

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Add support for GitHub action add review url

+# Azure Dev Spaces GitHub Action for adding the review url on pull request
+add-review-url GitHub Action can be used to write a comment on the pull request which is the app review url hence enabling the testing prior to checkin

Suggested description: Azure Dev Spaces can provide reviewers a live, sandboxed preview of the pull request's changes before code is merged into the main branch. The add-review-url GitHub Action writes the URL of the preview app as a comment on the pull request.

s-tuli

comment created time in 3 months

more