profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/johnnyshields/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Johnny Shields johnnyshields CTO, TableCheck Tokyo, Japan sales.tablecheck.com

aq1018/paperclip-dimension 4

paperclip plugin to persist image dimensions of originals and thumbnails

johnnyshields/activerecord-q-adapter 1

Adds support Q database language from Kx Systems to Rails 3

johnnyshields/activemodel_phone 0

A lightweight, opinionated ActiveModel field wrapper for phone numbers, using the Phony gem.

johnnyshields/active_admin 0

The administration framework for Ruby on Rails applications.

johnnyshields/antiscroll 0

OS X Lion style cross-browser native scrolling on the web that gets out of the way.

johnnyshields/asset_sync 0

Synchronises Assets between Rails and S3

johnnyshields/axlsx 0

xlsx generation with charts, images, automated column width, customizable styles and full schema validation. Axlsx excels at helping you generate beautiful Office Open XML Spreadsheet documents without having to understand the entire ECMA specification. Check out the README for some examples of how easy it is. Best of all, you can validate your xlsx file before serialization so you know for sure that anything generated is going to load on your client's machine.

johnnyshields/base32 0

A library which provides base32 decoding and encoding.

johnnyshields/bootstrap 0

Sleek, intuitive, and powerful front-end framework for faster and easier web development.

PR opened collectiveidea/delayed_job_mongoid

Add additional indexes

The queries generated by the #reservation_criteria method are not indexed properly. I've learned this the hard way...

  • where(failed_at: nil) is always set, so we need this at the front of our index
  • any_in(queue: ...) is optional, so we need to have a second index with this at the front.
+2 -0

0 comment

1 changed file

pr created time in 27 minutes

create barnchjohnnyshields/delayed_job_mongoid

branch : additional-indexes

created branch time in 29 minutes

push eventjohnnyshields/mongoid_userstamp

johnnyshields

commit sha c6b5fd03a97d798c7302acf2c80aa822d361c16e

Drop support for Ruby 1.9

view details

Johnny Shields

commit sha 7ef46575297323fd06380d41317958b1075ed7ba

Merge pull request #29 from tbpro/drop-ruby19 Drop test coverage for Ruby 1.9

view details

Goh Toh Chye

commit sha 682be01cb94d96dd53c33c217e2aa1f129fbe48c

Check for Rails::Railtie instead of Rails

view details

anilmaurya

commit sha fea07d0256d3aa7fafe9246c20181c793f63edb2

Use before_action instead of before_filter

view details

anilmaurya

commit sha 4376c2705cb778957968e1d680cffdef4d5d8d4f

Use respond_to?(:before_filter) to make it Rails version agnostic

view details

anilmaurya

commit sha 2e8ce931befc419aa573713acea5f17d758d64ee

Give before_action precedence over before_filter

view details

Vsevolod Avramov

commit sha e503313f3aa7e77fd0d27f43f9834eff18b3d873

Merge remote-tracking branch 'simply_smart_tech/master' * simply_smart_tech/master: Give before_action precedence over before_filter Use respond_to?(:before_filter) to make it Rails version agnostic Use before_action instead of before_filter

view details

Javier Aranda

commit sha 0289a844c5883782240fc56aad01db07ce3c79cb

Add Readme warning

view details

Avramov Vsevolod

commit sha b2e5ac90ee06213ddb0002f998ce4ff3b37b4798

Merge pull request #1 from vsevolod/master Upgrade to rails 4+

view details

Johnny Shields

commit sha 542daa26652f3797845cae69d234fc0b8c732890

Major refactor: (#2) * Major refactor: * BREAKING: API method renaming * `GlobalConfig.created_name` --> `created_by_field` * `GlobalConfig.updated_name` --> `updated_by_field` * `Model.mongoid_userstamp` --> `userstamp` * option `:created_name` --> `:created_by_field` * option `:updated_name` --> `:updated_by_field` * `User.mongoid_userstamp_user` --> `userstamp_user` * option `:reader` --> `:controller_current_user` * `User.current` --> `current_user` / `current_user=` / `current_user?` * Method renaming done for clarity and consistency. Refer to updated documentation * Improvement * Raise error if invalid options are supplied to core `userstamp` and `userstamp_user` functions. * Add Rubocop config. * Replace Travis CI with Github Actions. * Add additional CHANGELOG line * Add specs for new behavior

view details

shields

commit sha 681b2e68f4401931a1d0f0d0bb6914ece30f4bfe

Improve README.md

view details

Johnny Shields

commit sha 866abfa5a3f73430aa9cdc9c5371f209792cad92

Synchronize assignment of all class-level variables (#3) - Add rubocop in CI

view details

Johnny Shields

commit sha a581b7a8710e928cdee526274a7a7a8639475c51

Add user_class_name to GlobalConfig (#4) - Fix all RSpec deprecations

view details

shields

commit sha d4de93816b37c4a704f61fb367e1c8a9cf74b754

Fix controller integration behavior

view details

Johnny Shields

commit sha 9ca9df516682782a968f4985027e5d11ee45ed42

Add tests for controller (#5)

view details

push time in 6 hours

pull request commentmongodb/mongoid

MONGOID-5105: Mongoid::Association::EmbedsMany::Proxy#count should allow block form

Shall we merge this? If Mongoid team would like to add the hacks it can be done as a separate PR; be aware they apply to many methods (#any?, #all?, #none?, etc.) which are not being touched in this PR (this PR only affects #count)

johnnyshields

comment created time in 9 hours

push eventtablecheck/mongoid-slug

Johnny Shields

commit sha 12ab6772cf7d320d44fcc88c6b6f72da1979811c

Remove ruby 1.9 and 2.1

view details

push time in 11 hours

PR closed mongoid/mongoid-slug

GH actions v2
+88 -38

0 comment

4 changed files

johnnyshields

pr closed time in a day

PR closed mongoid/mongoid-slug

Mongoid7
+58 -38

0 comment

4 changed files

johnnyshields

pr closed time in a day

push eventjohnnyshields/mongoid-slug

shields

commit sha 535574f18edd739cb1cd9a962c650fdea5a9852f

second try

view details

push time in a day

push eventjohnnyshields/mongoid-slug

Johnny Shields

commit sha 0c2088648e6648aafc624209081e2fe0912d613d

Changes to Gemfile.mongoid4 - Mongoid 4 has been officially released - simi/mongoid-paranoia is now released at mongoid_paranoia with an underscore.

view details

Andreas Sæbjørnsen

commit sha aee83311964b3a14078beb683bc60055577851ce

Merge branch 'johnnyshields-mongoid-4'

view details

Andreas Sæbjørnsen

commit sha a961f8e6d663839661796b41c485c4c4bbfd92de

update changelog

view details

Andreas Sæbjørnsen

commit sha 44c6ee9d4b17e771e484584ee12ad73307977fbb

fix specs

view details

Marcos Piccinini

commit sha edb20e25e60d925ba5d391fed2f8b37fb85b950b

To be 'mongoid-slug', notice the hyphen.

view details

Andreas Sæbjørnsen

commit sha 527bb90e20f7d6db3698408e497d4ae37b1936b5

bumping version to 4.0.0 due to renaming gem

view details

Andreas Sæbjørnsen

commit sha 690f636ba0707a6cda4ad52563975140a4bb3a10

Update CHANGELOG.md

view details

Johnny Shields

commit sha 424e86bcb01f1990614faf8a0b4ab56a968e0def

Correct gem name of "mongoid_paranoia"

view details

Andreas Sæbjørnsen

commit sha 83384a8a46db2749b708cbff6cdf6c06736fe1dc

Merge pull request #181 from johnnyshields/patch-1 Correct gem name of "mongoid_paranoia"

view details

dB

commit sha cd19e895061946b2536fb3450223754c045e4f1c

Added mongoid 5 support.

view details

Daniel Doubrovkine (dB.) @dblockdotorg

commit sha c82e2d6df5ecd6db4767afb1af4bc4ce1d229bbe

Merge pull request #187 from dblock/mongoid-5 Added mongoid 5 support.

view details

dB

commit sha 1820f6df7b01f9aaebc4c639d37d225229e1804b

Removed deprecated gemspec, extracted UPGRADING.md, added version badge.

view details

dB

commit sha f74a394c65edb9618cb2ad1c1b29dc833be01b57

Mongoid_paranoia 0.2.0 has been released.

view details

dB

commit sha 1195322ea265a22da7e615e388c34212880e62f0

Rewritten CHANGELOG.

view details

Daniel Doubrovkine (dB.) @dblockdotorg

commit sha 5039cfabe2fb4943bf4d0bc7abcfdfd9645fcc08

Merge pull request #188 from dblock/misc Misc things getting ready to release.

view details

dB

commit sha 572bbc64c04fb4a1d8f356f643311c82a3bcd1a3

Implemented RuboCop, Ruby-style linter.

view details

Daniel Doubrovkine (dB.) @dblockdotorg

commit sha d5e9569cfa3b7533a0dac04186e502950c2e18a3

Merge pull request #189 from dblock/rubocop Implemented RuboCop, Ruby-style linter.

view details

dB

commit sha 47fca2c8156ec259b9e12f7a3e884d0b12546e08

Added CONTRIBUTING, updated copyright and license.

view details

Daniel Doubrovkine (dB.) @dblockdotorg

commit sha 429b2b1aaa5428a12a8afa639fcca16aa753065e

Merge pull request #191 from dblock/contributing Added CONTRIBUTING, updated copyright and license.

view details

dB

commit sha a8c13882bdf459f3d6b3cdab4c2a7557cda8b257

Preparing for release, 5.0.

view details

push time in a day

PR opened mongoid/mongoid-slug

Mongoid7
+145 -72

0 comment

14 changed files

pr created time in a day

push eventtablecheck/mongoid-slug

shields

commit sha 9b28d27ba2c6c98f1ca42ce71c233a0975ff35c6

force actions to work

view details

push time in a day

PR opened mongoid/mongoid-slug

GH actions v2
+88 -38

0 comment

4 changed files

pr created time in a day

create barnchtablecheck/mongoid-slug

branch : gh-actions-v2

created branch time in a day

PR opened mongoid/mongoid-slug

#slug should not default to _id.to_s

#slug should not default to _id.to_s. This is inconsistent with the rest of the gem:

  • _slugs does not contain _id.to_s
  • clear_slug! sets _slugs to [], so #slug will return nil in this case
  • it will be overwritten when saving
  • before saving, one would expect both slug and _slugs to be nil
+1 -2

0 comment

1 changed file

pr created time in a day

create barnchtablecheck/mongoid-slug

branch : remove-default-id

created branch time in a day

push eventtablecheck/mongoid-slug

shields

commit sha ba9fcf9fa1764dc110eaa0e57a9a88ed49835181

Fix actions

view details

push time in a day

pull request commentmongoid/mongoid-slug

Add Github Actions and remove Travis CI

@dblock can you make me an admin on this repo? I'd like to do some gardening.

johnnyshields

comment created time in a day

create barnchtablecheck/mongoid-slug

branch : github-actions

created branch time in a day

create barnchjohnnyshields/mongoid-slug

branch : mongoid7

created branch time in a day

pull request commentmongodb/mongoid

MONGOID-5078 Fix shard_key_selector_in_db during post-persist callbacks - DRAFT

@dalton-braze sorry my comment was mistaken, please ignore.

dalton-braze

comment created time in a day

pull request commentmongodb/mongoid

MONGOID-5126: Fix Mongoid::Document === override

FYI the latest one from @mdehoog matches ActiveRecord https://github.com/rails/rails/blob/main/activerecord/lib/active_record/core.rb#L421

mdehoog

comment created time in a day

pull request commentmongodb/mongoid

MONGOID-5128: Scoped associations

Hmmm.... I'm not following. Can you provide a code (or pseudo-code) example?

johnnyshields

comment created time in a day

pull request commentmongodb/mongoid

MONGOID-5128: Scoped associations

Mongoid (and I believe AR too) already provides scoping under associations

Yes, BUT there is one important point. You can't eager load scoped associations.

In other words:

# you can't do this
Foo.all.includes(:"bars.open")

# my PR allows this
class Foo
  ...
  association_scope :open_bars, :bars, -> { where(open: true) }
end

Foo.all.includes(:open_bars)
johnnyshields

comment created time in 2 days

pull request commentmongodb/mongoid

MONGOID-5128: Scoped associations

@p-mongo would like to get your comments on this.

johnnyshields

comment created time in 2 days

Pull request review commentmongodb/mongoid

MONGOID-5105: Mongoid::Association::EmbedsMany::Proxy#count should allow block form

 def clear           #           # Use #size if you want the total number of documents.           #+          # If args or block are present, #count will delegate to the target and

Done.

johnnyshields

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentmongodb/mongoid

MONGOID-5105: Mongoid::Association::EmbedsMany::Proxy#count should allow block form

 class TrackingIdValidationHistory       it "returns true" do         expect(person.addresses.any?).to be true       end++      it "block form iterates across all documents" do+        expect(person.addresses.any? {|a| a.street == "Upper" }).to be false+        expect(person.addresses.any? {|a| a.street == "Bond" }).to be true+      end++      context 'ruby version >= 2.5' do+        ruby_version_gte '2.5'++        it "argument form is supported" do+          expect(person.addresses.any?(person.addresses.first)).to be true+          expect(person.addresses.any?(1)).to be false+        end+      end     end -    context "when documents are not created" do+    context "when documents are not present" do       it "returns false" do         expect(person.addresses.any?).to be false       end++      it "block form iterates across all documents" do+        expect(person.addresses.any?(&:a)).to be false+      end++      context 'ruby version >= 2.5' do+        ruby_version_gte '2.5'++        it "argument form is supported" do+          expect(person.addresses.any?(1)).to be false+        end+      end+    end+  end++  describe "#all?" do++    let(:person) do+      Person.create

Done. I've changed all usages of .create in the spec file.

johnnyshields

comment created time in 2 days

PullRequestReviewEvent

push eventjohnnyshields/mongoid

shields

commit sha af28e437df6ff7ecadbd84e0440d207742ea8ef6

Fix specs on Ruby 2.3 and 2.4

view details

Dmitry Rybakov

commit sha 2f3505c3641718b8fdbe2b8b81fc58dd517b29ee

MONGOID-5130 Disable Clients::Options#with test (#5018)

view details

shields

commit sha c127641d6e96dfaf06f89bdc95959883f685c634

Merge remote-tracking branch 'remotes/origin/master' into embeds-many-proxy-count-block

view details

shields

commit sha c050e9830f59ced0c23ae97f176a2cac0b7cf754

- .create --> .create! in spec - Update docs

view details

push time in 2 days