profile
viewpoint
John Reilly johnnyreilly Priou London https://blog.johnnyreilly.com/ MacGyver turned Dev

DefinitelyTyped/DefinitelyTyped 28833

The repository for high quality TypeScript type definitions.

johnnyreilly/jQuery.Validation.Unobtrusive.Native 75

Provides MVC HTML helper extensions that marry jQuery Validation's native unobtrusive support for validation driven by HTML 5 data attributes with MVC's ability to generate data attributes from Model metadata. With this in place you can use jQuery Validation as it is. Please look at the project site for demos and documentation.

johnnyreilly/jquery-validation-globalize 40

An extension to the jQuery Validation Plugin which makes it use Globalize.js for number and date parsing (enabling simple internationalized validation)

johnnyreilly/globalize-so-what-cha-want 10

Tell me what Globalize modules you want to use, I'll tell you what you need.

johnnyreilly/BootstrapMvcSample 9

Experiments built upon Twitter.Bootstrap.MVC4

johnnyreilly/HotTowel-Angular-TypeScript 9

A types-only port of HotTowel-Angular to TypeScript

johnnyreilly/auth0-react-typescript-asp-net-core 5

A boilerplate illustrating Auth0 usage with a React / TypeScript client and an ASP.Net Server

johnnyreilly/ES6-TypeScript-Babel-React-Karma 3

ES6 + TypeScript + Babel + React + Karma: The Secret Recipe

johnnyreilly/C--WebKit-HTML-to-PDF-wrapper 2

A C# wrapper for the wkhtmltopdf library

push eventjohnnyreilly/poor-clares-arundel-koa

Johnny Reilly

commit sha c3cc92b9d709d5d172687502b87948b3803f9076

upgrade node 12 to node 14

view details

push time in 8 hours

push eventjohnnyreilly/poor-clares-arundel-koa

Johnny Reilly

commit sha a73af7e8289438808f9891494174b7dd5d887ca7

fix debugging on Linux

view details

push time in 8 hours

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Add "typescript" option from v4 back in some form

Hey @onigoetz!

I suspect this would be good to add back - @piotr-oles what are your thoughts?

onigoetz

comment created time in 9 hours

issue commentTypeStrong/fork-ts-checker-webpack-plugin

types.ts files do not trigger rebuild in webpack-dev-server

I reopened this as @sangeeth96 opened an issue which seems to be this. It could be worth trying the importsNotUsedAsValues: preserve tip anyone that comes here - but perhaps it doesn't solve all issues?

abirmingham

comment created time in 9 hours

issue closedTypeStrong/fork-ts-checker-webpack-plugin

Changes to types.ts not triggering type/eslint checks

Current behavior

If I have a types only file (say types.ts), changes to this file doesn't cause the plugin to perform type checks or run eslint checks when used in combination with babel-loader.

Expected behavior

<!-- Describe what the desired behavior would be. --> Changes to a file that only has types should cause the plugin to do type/eslint checks again so that correct information is reported.

Steps to reproduce the issue

<!-- Describe how we can reproduce this problem step by step. --> Use the babel-loader example project and add a types.ts file with the following contents:

export type Animal = {
  type: 'Dog' | 'Cat';
  speak: () => string;
};

Change index.ts to:

import { Animal } from './types';

const dog: Animal = {
  speak: () => 'Bark!',
  type: 'Dog',
};

console.log(dog);

Make some change to types.ts and see that nothing happens during yarn dev. Same goes for eslint if it was enabled.

Issue reproduction repository

<!-- Optional location of a minimal repository that demonstrates the issue. -->

Environment

{
    "@babel/core": "^7.10.3",
    "@babel/preset-env": "^7.10.3",
    "@babel/preset-typescript": "^7.10.1",
    "babel-loader": "^8.1.0",
    "fork-ts-checker-webpack-plugin": "^5.0.5",
    "typescript": "^3.9.5",
    "webpack": "^4.43.0",
    "webpack-cli": "^3.3.12",
    "webpack-dev-server": "^3.11.0"
}

os: WSL Ubuntu 18.04.4 LTS

closed time in 9 hours

sangeeth96

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Changes to types.ts not triggering type/eslint checks

Closing as a duplicate of https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/36 (which I've just reopened)

@piotr-oles had hoped this issue would be resolved by v5 - but it looks like it hasn't been.

sangeeth96

comment created time in 9 hours

IssuesEvent

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Extremely high compilation time for production build on v5

Although it's primitive - simply hacking in console.log statements will get you a long way. It's surprisingly effective even if you feel that "there must be a better way"

IlCallo

comment created time in 2 days

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Extremely high compilation time for production build on v5

Fascinating - I hadn't heard of "Quasar types"

IlCallo

comment created time in 2 days

issue commentcypress-io/cypress-documentation

Docs on using Cypress in a devcontainer

Thanks @jennifer-shehane!

I spent some time digging into this yesterday and I'm wondering if what I'm outlining is possible or not. Given that devcontainers have no UI of their own (as I understand it anyway).

When you cypress open to fire up the test runner you fire up an electron app. That can't work (I guess) due to the lack of a UI.

However, given you can also run the test runner in Chrome, I wonder if it's possible to trigger the test runner in the devcontainer but then connect to it using Chrome on your host OS be it Windows / Mac / Linux. Do you have an idea if that's even possible? Is the test runner accessible in that way? Can we go to http://localhost:7777 (I just made up a random port) and see the test runner? Or am I barking up the wrong tree? 🐩🌳

johnnyreilly

comment created time in 2 days

issue openedcypress-io/cypress-documentation

Docs on using Cypress in a devcontainer

Hello everyone!

I ❤️ Cypress - it is an amazing product. Thanks for your work on it.

I've found myself doing more and more work lately using devcontainers as my development environment in VS Code.

The one thing that I haven't yet cracked is working out how to get Cypress fully working in a devcontainer. I've been able to get a part of the way there by using the Node example devcontainer here: https://github.com/microsoft/vscode-dev-containers/tree/master/containers/javascript-node-14

And tweaking it based upon the Cypress docs for CI here: https://docs.cypress.io/guides/guides/continuous-integration.html#Dependencies to add in the Cypress dependencies.

The tricky part is that whilst this gets us to the point of Cypress technically running, it doesn't show the Cypress Test Runner. Running cypress open . does not error which is lovely. However, crucially it doesn't fire up the Cypress Test Runner UI that you might expect. I imagine this is because the Test Runner uses an Electron app by default. I wonder if there's a way to do this by using the browser on the host machine (Chrome in my case) for the test runner.

I'm not sure what the way forward here would look like and I'm curious if there are docs that explain how to get up and running with devcontainers. I haven't found any and I suspect this is going to become an increasingly common workflow - it's likely that many others are likely trying to do the same thing. The advent of approaches such as GitHub Codespaces will only add to the popularity!

I'd be happy try and help out with some docs on this if I knew just how do get this up and running. Any ideas?

created time in 2 days

push eventDefinitelyTyped/DefinitelyTyped

Yuxuan Xie

commit sha f25da746d2cf4e8671a11ce81bf0cd00997f70bc

Add 'inline' to UglifyJS source map content (#45904)

view details

push time in 2 days

PR merged DefinitelyTyped/DefinitelyTyped

Reviewers
Add 'inline' to the type definition of SourceMapOptions.content Critical package Perf: Same

UglifyJS's source code as well as its --source-map document saying content accepts 'inline' string. This is to fix type definitions that are present in UglifyJS version 3.9.

  • Added 'inline' to the type definition of SourceMapOptions.content
  • Added a new test.
  • Moved mis-placed checking output.warnings closer to its corresponding test body.
  • Run prettier on the test file.
+12 -7

4 comments

2 changed files

teststaybaka

pr closed time in 2 days

issue commentTypeStrong/ts-loader

webpack --watch do not detect changes in files that only export TS interfaces/types etc.

No it is not.


From: Keni notifications@github.com Sent: 05 July 2020 19:00 To: TypeStrong/ts-loader ts-loader@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [TypeStrong/ts-loader] webpack --watch do not detect changes in files that only export TS interfaces/types etc. (#1138)

@sokrahttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsokra&data=02|01||421d7dc4c62f42ec7ea108d821159fd2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637295724036393689&sdata=0coCKqmw53Ty02tx8DrIvxpLgQGqUiKWszZgund2hqs%3D&reserved=0 i actually deprecated ts-loader and migrated to es-loader few weeks ago. But to be fair, this behaviour also happen in ts-loader

That also raise a second question, is ts-loader deprecating?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTypeStrong%2Fts-loader%2Fissues%2F1138%23issuecomment-653925897&data=02|01||421d7dc4c62f42ec7ea108d821159fd2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637295724036403687&sdata=ceizOe4RPw4%2BWWxEOdXFha77eegTSpUDFl8LUb4blVc%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAHWWXOOBNII4FU73IKTK2LR2DETFANCNFSM4OQ4RRMQ&data=02|01||421d7dc4c62f42ec7ea108d821159fd2|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637295724036403687&sdata=9SqugttygMy%2Bm1szJKIdk0wubSk2FThYk2YIm47SL3M%3D&reserved=0.

webpack-bot

comment created time in 3 days

issue openedcypress-io/cypress

Docs on using Cypress in a devcontainer

Hello everyone!

I ❤️ Cypress - it is an amazing product. Thanks for your work on it.

I've found myself doing more and more work lately using devcontainers as my development environment in VS Code.

The one thing that I haven't yet cracked is working out how to get Cypress working in a devcontainer. I've been able to get a part of the way there by using the Node example devcontainer here: https://github.com/microsoft/vscode-dev-containers/tree/master/containers/javascript-node-14

And tweaking it based upon the Cypress docs for CI here: https://docs.cypress.io/guides/guides/continuous-integration.html#Dependencies to add in the Cypress dependencies.

The tricky part is that whilst this gets us to the point of Cypress technically running, it doesn't allow for the Cypress Test Runner that you typically use with cypress open .. https://docs.cypress.io/guides/guides/command-line.html#cypress-open to fire up.

I'm not sure what the way forward here would look like and I'm curious if there are docs that explain how to get up and running with devcontainers. I haven't found any and I suspect this is going to become an increasingly common workflow so I thought I'd ask!

created time in 3 days

push eventjohnnyreilly/poor-clares-arundel-koa

Johnny Reilly

commit sha 6437a0abf8d7c6a1ef20b4e41be15ae023311fd2

put back missing bit

view details

push time in 4 days

push eventTypeStrong/ts-loader

John Reilly

commit sha 7f5be4938cef4943eda168bddb1fa7b15bdbc55a

Update CHANGELOG.md

view details

push time in 4 days

push eventTypeStrong/ts-loader

John Reilly

commit sha 91a63295ed5fa213343332e85a657744e5cf69a7

Update version to 8.0.0 in package.json

view details

push time in 4 days

pull request commentTypeStrong/ts-loader

Support for symlinks in project references

From the looks of it this is done @sheetalkamat? Thanks so much for your work! @andrewbranch would you be able to give this a review when you get a chance please?

sheetalkamat

comment created time in 4 days

pull request commentTypeStrong/ts-loader

Fix webpack deprecations

@sheetalkamat has a PR which drops support for older versions of TypeScript here: https://github.com/TypeStrong/ts-loader/pull/1136

When that's merged we can take a look at your PR - it only seems to be failing on older versions of TypeScript.

g-plane

comment created time in 4 days

issue commentTypeStrong/ts-loader

Deprecation Warning on Webpack 5

@sheetalkamat has a PR which drops support for older versions of TypeScript here: https://github.com/TypeStrong/ts-loader/pull/1136

When that's merged we can take a look at your PR - it only seems to be failing on older versions of TypeScript.

artola

comment created time in 4 days

push eventjohnnyreilly/poor-clares-arundel-koa

Johnny Reilly

commit sha 2ce75d3359235405a61fb29e975d3b883ecca2be

COVID-19 update to events

view details

push time in 4 days

pull request commentTypeStrong/ts-loader

Support for symlinks in project references

Nice work @sheetalkamat!

I can see there's a bunch of failing tests which you're no doubt looking into. Having had a quick look it seems that TypeScript <= 2.6 tests are failing.

I've been wondering about dropping support for older versions of TypeScript; maybe making the minimum supported version TypeScript 3.6. It would speed up our CI considerably as we'd have a much smaller test matrix to run in Travis / AppVeyor. Users on older versions of TypeScript would still have older versions of ts-loader they could use.

If it makes your life easier, then do feel free to consider doing that in this PR. TypeScript 2.6 was a long time ago!

sheetalkamat

comment created time in 6 days

issue commentTypeStrong/ts-loader

Project reference example

Yup - good shout. if someone would like to contribute an example I'd happily include it.

IIIristraM

comment created time in 8 days

issue commentTypeStrong/ts-loader

Deprecation Warning on Webpack 5

If memory serves (and it may not) this removes errors registered by ts-loader from a previous run, so the full set of current ts-loader errors can be registered without creating duplicates. Make sense?

artola

comment created time in 8 days

issue openeddependabot/dependabot-core

Could yarn.lock update PRs include the dependency they come from?

Heya,

Dependabot is awesome!

I wonder if when a PR is raised relating to a yarn.lock file, the message could also indicate which dependencies / devDependencies in the package.json this relates to?

This PR tells me just about the yarn.lock file. If I knew which package this came from up front that would be helpful / interesting. Also, I'm likely to attach greater urgency to shipping a new release if this is a dependency rather than a devDependency

https://github.com/TypeStrong/ts-loader/pull/947

created time in 9 days

pull request commenttannerlinsley/react-query

fix(types): v2

Nice work all!

wolverineks

comment created time in 9 days

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Extremely high compilation time for production build on v5

It would be nice to add a note in the Vue section of the readme,

Would you like to submit a PR?

IlCallo

comment created time in 12 days

startedmicrosoft/vscode-dev-containers

started time in 14 days

issue commentTypeStrong/ts-loader

Enum values from d.ts files cause exception when build with transpileOnly=true

Thanks for a really clear and helpful write up Nick!

ArtemZag

comment created time in 17 days

IssuesEvent

issue closedTypeStrong/ts-loader

Enum values from d.ts files cause exception when build with transpileOnly=true

I tried to speed up build process. And transpileOnly=true works amazing! Until I use any enum value in my code.

Example: Definition file: definitions.d.ts

declare module MyModule {
  export const enum MyEnum {
    EnumValue1 = 0,
    EnumValue2 = 1
  }
}

TS file: example.ts

/// <reference path="./definitions.d.ts" />
console.log(MyModule.MyEnum.EnumValue1);

In runtime I get error: "MyModule is not defined" Is there any way to force ts-loader NOT to ignore some specific *.d.ts files when I use transpileOnly=true? (something like transpileOnlyExcept...)

closed time in 17 days

ArtemZag

pull request commentjohnnyreilly/fork-ts-checker-notifier-webpack-plugin

Update to support `fork-ts-checker-webpack-plugin` v5

https://github.com/johnnyreilly/fork-ts-checker-notifier-webpack-plugin/releases/tag/v3.0.0

It's live! Thanks for the help! 🌻❤️

sanex3339

comment created time in 18 days

push eventjohnnyreilly/fork-ts-checker-notifier-webpack-plugin

Timofey Kachalov

commit sha 7a1af76c7df745742ce04ccd66836c4082adaa18

Update to support `fork-ts-checker-webpack-plugin` v5 (#37) * Update to support `fork-ts-checker-webpack-plugin` v5 * Updated changelog with link to the PR * Fixed imports. Dropped support for node@8 * Updated readme Co-authored-by: sanex3339 <yarabotayuvyandex3339>

view details

push time in 18 days

PR merged johnnyreilly/fork-ts-checker-notifier-webpack-plugin

Update to support `fork-ts-checker-webpack-plugin` v5

https://github.com/johnnyreilly/fork-ts-checker-notifier-webpack-plugin/issues/36

+210 -57

16 comments

8 changed files

sanex3339

pr closed time in 18 days

pull request commentjohnnyreilly/fork-ts-checker-notifier-webpack-plugin

Update to support `fork-ts-checker-webpack-plugin` v5

Oh yes! Could you update the readme please!

sanex3339

comment created time in 18 days

pull request commentjohnnyreilly/fork-ts-checker-notifier-webpack-plugin

Update to support `fork-ts-checker-webpack-plugin` v5

Is there anymore to do, or are we ready to ship?

sanex3339

comment created time in 18 days

pull request commentjohnnyreilly/fork-ts-checker-notifier-webpack-plugin

Update to support `fork-ts-checker-webpack-plugin` v5

Interesting! I wonder if that's down to a deliberate behaviour choice in fork-ts-checker-webpack-plugin v5. @piotr-oles - does the Issues event only get triggered after initial compilation in v5?

sanex3339

comment created time in 18 days

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Improve eslint files option documentation

Thanks for the recommendation @ianschmitz! What do you think @piotr-oles ?

ianschmitz

comment created time in 19 days

pull request commentTypeStrong/fork-ts-checker-webpack-plugin

fix: use typescript watcher for directories to prevent TS6307

This means that it will not notice if we create a new file that is not missing

I didn't quite understand what this means - could you provide an example please?

piotr-oles

comment created time in 19 days

Pull request review commentTypeStrong/fork-ts-checker-webpack-plugin

fix: use typescript watcher for directories to prevent TS6307

 function createControlledTypeScriptSystem(       return;     } -    const directoryWatchers = directoryWatchersMap.get(directory);-    if (directoryWatchers) {-      directoryWatchers.forEach((directoryWatcher) =>-        directoryWatcher(forwardSlash(normalizedPath))+    const directoryWatcherCallbacks = directoryWatcherCallbacksMap.get(directory);+    if (directoryWatcherCallbacks) {+      directoryWatcherCallbacks.forEach((directoryWatcherCallback) =>+        directoryWatcherCallback(forwardSlash(normalizedPath))       );     } -    recursiveDirectoryWatchersMap.forEach((recursiveDirectoryWatchers, watchedDirectory) => {-      if (-        watchedDirectory === directory ||-        (directory.startsWith(watchedDirectory) &&-          forwardSlash(directory)[watchedDirectory.length] === '/')-      ) {-        recursiveDirectoryWatchers.forEach((recursiveDirectoryWatcher) =>-          recursiveDirectoryWatcher(forwardSlash(normalizedPath))-        );+    recursiveDirectoryWatcherCallbacksMap.forEach(+      (recursiveDirectoryWatcherCallbacks, watchedDirectory) => {+        if (+          watchedDirectory === directory ||+          (directory.startsWith(watchedDirectory) &&+            forwardSlash(directory)[watchedDirectory.length] === '/')+        ) {+          recursiveDirectoryWatcherCallbacks.forEach((recursiveDirectoryWatcherCallback) =>+            recursiveDirectoryWatcherCallback(forwardSlash(normalizedPath))+          );+        }       }-    });+    );+  }++  function updateDirectorySnapshot(path: string, recursive = false) {+    const dirents = passiveFileSystem.readDir(path);

What is a dirent? Is that directory?

piotr-oles

comment created time in 19 days

pull request commentDefinitelyTyped/DefinitelyTyped

[react] readonly array for value attr in DOM elements

Sorry to hear that - though I'm afraid that is something that will happen; for (good) reasons, definitely typed does not use semantic versioning. If you expect it to you will be disappointed I'm afraid. There's some more details here:

https://blog.johnnyreilly.com/2018/09/ivan-drago-and-definitely-typed.html

G07cha

comment created time in 21 days

pull request commentmicrosoft/TypeScript

Type-only imports and exports

This wasn't my question, but I just wanted to give props to @andrewbranch for such a thoughtful and clear answer. Well done sir!

andrewbranch

comment created time in 21 days

issue commentTypeStrong/ts-loader

Deprecation Warning on Webpack 5

Thanks - if someone would like to work on this I'll happily review the PR 🤗

artola

comment created time in 23 days

issue commentjohnnyreilly/fork-ts-checker-notifier-webpack-plugin

Update plugin to support fork-ts-checker@5

Looking at the plugin I think the hooks have changed. Probably we need to hook into issues now.

https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/blob/master/README.md#plugin-hooks

sanex3339

comment created time in 24 days

issue commentjohnnyreilly/fork-ts-checker-notifier-webpack-plugin

Update plugin to support fork-ts-checker@5

If you'd like to submit a PR to make this v5 compatible that'd be greatly appreciated!

You may want to use the v5 PR for reference: https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/pull/445

sanex3339

comment created time in 25 days

pull request commentTypeStrong/fork-ts-checker-webpack-plugin

Release 5.0.0

This is the big one!

piotr-oles

comment created time in a month

issue commentdividab/tsconfig-paths-webpack-plugin

Failed to load tsconfig.json: Missing baseUrl in compilerOptions

Can we have a fix for this?

Do you fancy having a go at working on this? PRs are generally gratefully received 🥰

rhys-vdw

comment created time in a month

Pull request review commentTypeStrong/fork-ts-checker-webpack-plugin

feat: add issue.scope option

 Options for the issues filtering (`issues` option object). | --------- | --------------------------------- | ------------- | ----------- | | `include` | `object` or `function` or `array` | `undefined`   | If `object`, defines issue properties that should be [matched](./src/issue/IssueMatch.ts). If `function`, acts as a predicate where `issue` is an argument. | | `exclude` | `object` or `function` or `array` | `undefined`   | Same as `include` but issues that match this predicate will be excluded. |+| `scope`   | `'all'` or `'webpack'`            | `'webpack'`   | Defines issues scope to be reported. If `'webpack'`, reports errors only related to the webpack compilation. Reports all errors otherwise. |

Could be worth being specific about what "all errors" means in this context? I imagine this is what tsc would do. Is that right?

piotr-oles

comment created time in a month

push eventjohnnyreilly/poor-clares-arundel-koa

dependabot[bot]

commit sha 5d670421784e722fa9276ab350f126f157666fb3

Bump websocket-extensions from 0.1.3 to 0.1.4 in /src/client (#20) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in a month

PR merged johnnyreilly/poor-clares-arundel-koa

Bump websocket-extensions from 0.1.3 to 0.1.4 in /src/client dependencies

Bumps websocket-extensions from 0.1.3 to 0.1.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md">websocket-extensions's changelog</a>.</em></p> <blockquote> <h3>0.1.4 / 2020-06-02</h3> <ul> <li>Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)</li> <li>Change license from MIT to Apache 2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/faye/websocket-extensions-node/commit/8efd0cd6e35faf9bb9cb08759be1e27082177d43"><code>8efd0cd</code></a> Bump version to 0.1.4</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/3dad4ad44a8c5f74d4f8f4efd3f9d6e0b5df3051"><code>3dad4ad</code></a> Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/4a76c75efb1c5d6a2f60550e9501757458d19533"><code>4a76c75</code></a> Add Node versions 13 and 14 on Travis</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/44a677a9c0631daed0b0f4a4b68c095b624183b8"><code>44a677a</code></a> Formatting change: {...} should have spaces inside the braces</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/f6c50aba0c20ff45b0f87cea33babec1217ec3f5"><code>f6c50ab</code></a> Let npm reformat package.json</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/2d211f3705d52d9efb4f01daf5a253adf828592e"><code>2d211f3</code></a> Change markdown formatting of docs.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/0b620834cc1e1f2eace1d55ab17f71d90d88271d"><code>0b62083</code></a> Update Travis target versions.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/729a4653073fa8dd020561113513bfa2e2119415"><code>729a465</code></a> Switch license to Apache 2.0.</li> <li>See full diff in <a href="https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in a month

issue commentTypeStrong/ts-loader

Unstable behavior across builds

That's cool - if you can help we'd appreciate it. No worries if not!

freiondrej

comment created time in a month

issue commentTypeStrong/ts-loader

Unstable behavior across builds

Thanks for reporting your findings - that's super helpful. If you're able to create a minimal reproducible repo (even if it is flaky) that will give someone a chance to potentially work on a permanent fix. Please do consider having a go yourself if you get a chance 🤗

freiondrej

comment created time in a month

issue commentTypeStrong/ts-loader

TS2305: Module has no exported member

I'm only just spotting this now, but from the looks of it @thekevinbrown opened up an issue which the very generous @appzuka was able to solve by providing a guide to using project references! (support of which in ts-loader is down to the wonderful @andrewbranch and @sheetalkamat )

Thanks all! 🥰🌴

thekevinbrown

comment created time in a month

issue commentTypeStrong/ts-loader

Error while using typescript 3.8 export aliases

Thanks @mastrzyz - really appreciate you sharing

guillaume86

comment created time in a month

IssuesEvent

issue commentTypeStrong/ts-loader

Project References won't work if extends config file

No update - if someone would like to work on this that would be amazing 🥰

t83714

comment created time in a month

IssuesEvent

issue commentTypeStrong/ts-loader

ts-loader config with transpileOnly: true and experimentalWatchApi: true

Or this feature works, but tsconfig.tsbuildinfo is not generated?

I believe it is this

AClimber

comment created time in a month

issue commentTypeStrong/ts-loader

ts-loader config with transpileOnly: true and experimentalWatchApi: true

Why tsconfig.tsbuildinfo is not generated when transpileOnly: true and experimentalWatchApi: true?

transpileOnly: true does not support tsconfig.tsbuildinfo. That's the behaviour of tsc. You could try transpileOnly: false

AClimber

comment created time in a month

pull request commentvercel/next.js

Replace `fork-ts-checker-webpack-plugin` with faster alternative

Incidentally, I've an idea that isolatedModules: true may hurt your performance and skipLibCheck: true could improve your performance (regardless of context).

Incidentally, skipLibCheck: true is going to become the default as of TypeScript 3.9

Timer

comment created time in a month

pull request commentvercel/next.js

Replace `fork-ts-checker-webpack-plugin` with faster alternative

The DX we're aiming for (in dev) is that TS/ESLint errors show up in a toast though, and not a full overlay ("compile error").

Yeah that was exactly why I wrote https://github.com/johnnyreilly/fork-ts-checker-notifier-webpack-plugin

Something very lovely about having errors as toasts outside of the application. I've never really enjoyed the full overlay approach; I like to have the application running even if it does contain errors. I find value in being able to debug a broken application - particularly if it's a type system error which may not massively impair functionality.

Timer

comment created time in a month

pull request commentvercel/next.js

Replace `fork-ts-checker-webpack-plugin` with faster alternative

We're also exploring ESLint in the future too, so this all parlays.

Did you use the ESLint integration in fork-ts-checker-webpack-plugin BTW? My own use case is running fork-ts-checker-webpack-plugin to surface up both type checking errors from TypeScript and lints from ESLint.

Timer

comment created time in a month

pull request commentTypeStrong/fork-ts-checker-webpack-plugin

Rewrite to version 5.0.0

Just wanted to share these timings that @timer was kind enough to do here: https://github.com/vercel/next.js/pull/13529#issuecomment-635776458

Base build: 7s (no TypeScript features enabled)

fork-ts-checker-webpack-plugin@3.1.1: 90s, computer sounds like an airplane fork-ts-checker-webpack-plugin@4.1.6: 84s, computer did not sound like an airplane fork-ts-checker-webpack-plugin@5.0.0-alpha.14: 90s, regressed npx tsc -p tsconfig.json --noEmit: 12s (time: 18.57s user 0.97s system 169% cpu 11.525 total)

piotr-oles

comment created time in a month

pull request commentvercel/next.js

Replace `fork-ts-checker-webpack-plugin` with faster alternative

Thanks @timer - that's tremendously helpful! @piotr-oles it looks like there's a performance degradation with v5 - see the numbers from @timer above.

Timer

comment created time in a month

pull request commentvercel/next.js

Replace `fork-ts-checker-webpack-plugin` with faster alternative

Thanks for the detailed response @Timer! It does sound like you're planning some pretty hefty (and cool sounding!) architectural changes. Super interesting that you don't run type checking in development - that's where I particularly appreciate it!

We want to run type checking before the webpack build, and skip it [webpack] if checks fail. This gives a faster turnaround time IMO.

This is a really interesting idea. I'm very curious as to how it works out.

We firmly believe in keeping the webpack build's responsibilities as small as possible. We're going to start moving as many things as we can into side-cars, completely off the Node.js event loop (this PR is the first step).

Super interesting - as the name suggests, the initial motivation for fork-ts-checker-webpack-plugin was exactly that: "Webpack plugin that runs TypeScript type checker on a separate process."

Sounds like you're going all in on this. Fascinating.

If you do get a chance to compare v4 and v5 alpha performance we'd love to get an idea of the numbers.

Thanks again for sharing the ideas here - really cool!

Timer

comment created time in a month

pull request commentvercel/next.js

Replace `fork-ts-checker-webpack-plugin` with faster alternative

You will no doubt will (and should!) pick the approach that works best for you. Couple of things to note in case there are properties of the fork-ts-checker-webpack-plugin that are directly useful to the project:

  • it looks like you're using an old version (V3?) of the checker - I wonder how v4 compares?
  • related to that piotr-oles has been doing some incredible work for v5 https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/pull/404 - even though it's technically alpha it's pretty well advanced and I'd recommend taking it for a spin!

Of course, please make the calls that work for your project, I just wanted to let you know some possibilities 🤗

Timer

comment created time in a month

MemberEvent

issue commentTypeStrong/ts-loader

Does ts-loader support the `export * as <name>` introduced in typescript 3.8?

Then this is something of a mystery! If you'd like to look into it I'd greatly appreciate it!

Tiedye

comment created time in a month

issue commentTypeStrong/ts-loader

Does ts-loader support the `export * as <name>` introduced in typescript 3.8?

ts-loader shouldn't need to do anything specific to support this. Does what you're doing work with tsc alone?

Tiedye

comment created time in a month

push eventTypeStrong/ts-loader

Nick Excell

commit sha 8b7c8ed72b3c3399bd59d351477144015397db0b

Fix comparison tests under WSL (#1109) * Ensure a separate webpack instance is created if different loader options are used Add execution test for this behaviour * Fix import order (lint error) * Update version to 7.04 and include in changelog * Tweak to Changelog * Add a delay before starting the comparison tests * Update pull request number in changelog * Add comments to link to pull request Co-authored-by: John Reilly <johnny_reilly@hotmail.com>

view details

push time in a month

PR merged TypeStrong/ts-loader

Fix comparison tests under WSL

Under WSL2 (Windows Subsystem for Linux) the comparison tests were sometimes failing. The error showed that in patch0 the app.ts file was being rebuilt.

In watchpack, any file which is newer than the last compilation will be recompiled. Although app.ts was not changed between the first compilation and patch0, watchpack is conservative and if the file's timestamp is older than the last compilation time by less than the file system accuracy, it will assume that the file may be new and will include it for compilation. Although the bundle output is the same, the output includes a [built] tag, which causes a comparison error.

On my system I found that the file system accuracy (FS_ACCURACY in watchpack) for Windows 10 was 10ms but for WSL2 it was 100ms. This explains why the tests failed under WSL but not native Windows.

A delay has already been included in copyPatchOrEndTest with the comment that without the delay results can be inconsistent. copyPatchOrEndTest only affects later tests so a 200ms delay has been added between copying the test files and starting webpack. With this change all tests pass under Windows and WSL.

+12 -4

7 comments

2 changed files

appzuka

pr closed time in a month

pull request commentTypeStrong/ts-loader

Fix comparison tests under WSL

Thanks @appzuka!

appzuka

comment created time in a month

push eventappzuka/ts-loader

John Reilly

commit sha 466d067915c01201081a515f81e7326ea07214d9

migrate from tslint to eslint (#1120) * migrate from tslint to eslint * unignore .eslintrc.js

view details

John Reilly

commit sha 3670a789f0b4b4fd6f2bd0d4da884b06326f1aab

Merge branch 'master' into master

view details

push time in a month

push eventTypeStrong/ts-loader

John Reilly

commit sha 466d067915c01201081a515f81e7326ea07214d9

migrate from tslint to eslint (#1120) * migrate from tslint to eslint * unignore .eslintrc.js

view details

push time in a month

delete branch TypeStrong/ts-loader

delete branch : feature/eslint

delete time in a month

PR merged TypeStrong/ts-loader

migrate from tslint to eslint

Just what it says on the tin. Also vanquished some unused files.

+859 -43945

0 comment

227 changed files

johnnyreilly

pr closed time in a month

pull request commentTypeStrong/ts-loader

Fix comparison tests under WSL

Seriously how many days can ci take?!

appzuka

comment created time in a month

issue commentTypeStrong/fork-ts-checker-webpack-plugin

Add an example `tasks.json` to README?

I have only just realised that gitlens uses ts-loader and fork-ts-checker-webpack-plugin to build itself! I didn't realize you could use webpack to build a vs code extension.... There's so much I don't know!

phryneas

comment created time in a month

push eventTypeStrong/ts-loader

Johnny Reilly

commit sha e5f80a2d3f7aeb90def2fb77fcebf369f91fdf5b

unignore .eslintrc.js

view details

push time in a month

Pull request review commentTypeStrong/fork-ts-checker-webpack-plugin

fix: remove references to external typings

 hooks.waiting.tap('yourListenerName', () => { }); ``` +## Typings++To use the plugin typings, you have to install `@types/webpack`. It's not included by default to not collide with your+existing typings (`@types/webpack` imports `@types/node`). [It's an old TypeScript issue](https://github.com/microsoft/TypeScript/issues/18588), +the alternative is to set `skipLibCheck: true` in the `compilerOptions` 😉

Did you know that skipLibCheck: true is the default as of TypeScript 3.9?

https://www.twitter.com/orta/status/1260583041740812288

piotr-oles

comment created time in a month

issue commentTypeStrong/ts-loader

Feature: Support incremental build

I'm not totally up to speed with this, but I have an idea that .tsbuildinfo only comes into play with project references on. I'm assuming that isn't how your project works?

I have a feeling this changed with ts-loader 6.0.0

See conversation between the marvellous @sheetalkamat and @andrewbranch here:

https://github.com/TypeStrong/ts-loader/pull/1076#issuecomment-611081226

mc0

comment created time in a month

Pull request review commentTypeStrong/fork-ts-checker-webpack-plugin

fix: handle absolute paths for the eslint.files option

 function createEsLintReporterConfiguration(     enabled: !!(options && options.enabled === true),     memoryLimit: 2048,     ...(typeof options === 'object' ? options : {}),-    files: typeof options === 'object' ? castToArray(options.files) : [],-    cwd: compiler.options.context || process.cwd(),+    files: (typeof options === 'object' ? castToArray(options.files) : []).map((files) =>+      // ensure that `files` is an absolute path+      isAbsolute(files) ? files : join(compiler.options.context || process.cwd(), files)+    ),

Should files be file here? i.e. single rather than plural? It's always a single file in this context I think?

    files: (typeof options === 'object' ? castToArray(options.files) : []).map((file) =>
    cwd: compiler.options.context || process.cwd(),	      // ensure that `file` is an absolute path
      isAbsolute(file) ? file : join(compiler.options.context || process.cwd(), file)
    ),
piotr-oles

comment created time in a month

Pull request review commentTypeStrong/fork-ts-checker-webpack-plugin

fix: handle absolute paths for the eslint.files option

 function createEsLintReporterConfiguration(     enabled: !!(options && options.enabled === true),     memoryLimit: 2048,     ...(typeof options === 'object' ? options : {}),-    files: typeof options === 'object' ? castToArray(options.files) : [],-    cwd: compiler.options.context || process.cwd(),+    files: (typeof options === 'object' ? castToArray(options.files) : []).map((files) =>
    files: (typeof options === 'object' ? castToArray(options.files) : []).map((file) =>
    cwd: compiler.options.context || process.cwd(),	      // ensure that `file` is an absolute path
      isAbsolute(file) ? file : join(compiler.options.context || process.cwd(), file)
    ),
piotr-oles

comment created time in a month

PR opened TypeStrong/ts-loader

migrate from tslint to eslint

Just what it says on the tin. Also vanquished some unused files.

+820 -43944

0 comment

225 changed files

pr created time in a month

create barnchTypeStrong/ts-loader

branch : feature/eslint

created branch time in a month

push eventappzuka/ts-loader

John Reilly

commit sha e39b9f487f0f95095442df44a7569371ba3fa37f

Feature/upgrade to typescript 3 9 (#1119) * generate 3.9 output * generate stubs for transpile as well * all the void 0 changes

view details

John Reilly

commit sha 6b95470d4002236c2d5d749eea32542dcb21e7d8

Merge branch 'master' into master

view details

push time in a month

delete branch TypeStrong/ts-loader

delete branch : feature/upgrade-to-typescript-3_9

delete time in a month

push eventTypeStrong/ts-loader

John Reilly

commit sha e39b9f487f0f95095442df44a7569371ba3fa37f

Feature/upgrade to typescript 3 9 (#1119) * generate 3.9 output * generate stubs for transpile as well * all the void 0 changes

view details

push time in a month

PR merged TypeStrong/ts-loader

Feature/upgrade to typescript 3 9

Upgrade to ts 3.9

Lots of void 0 changes related to https://github.com/microsoft/TypeScript/issues/38552

+37048 -44

0 comment

626 changed files

johnnyreilly

pr closed time in a month

pull request commentTypeStrong/ts-loader

Fix comparison tests under WSL

WSL1 had some drawbacks, especially that copying large numbers of files (such as on yarn install) was very slow. In WSL2 this is improved and the file systems of WSL and Windows are better integrated. From the WSL2 command line you can type 'explorer.exe .' and a Windows File Explorer window opens up in your WSL folder.

The new Windows Terminal app lets you open WSL, CMD and Powershell terminals in separate tabs. And Docker now lets you run docker from within WSL. It is pretty seamlessly integrated and WSL2 is my main development environment now.

This is so cool! At home my main machine runs Ubuntu which I really like. Work is Windows 10. I like it well enough but I'd like to unify my home and work development workflows. WSL 1 is cool but (as you say) pretty slow. I'd heard speed was much better with WSL 2 so I've high hopes for it!

appzuka

comment created time in a month

PR opened TypeStrong/ts-loader

Feature/upgrade to typescript 3 9

Upgrade to ts 3.9

+37048 -44

0 comment

626 changed files

pr created time in a month

create barnchTypeStrong/ts-loader

branch : feature/upgrade-to-typescript-3_9

created branch time in a month

pull request commentTypeStrong/ts-loader

Fix comparison tests under WSL

This is really cool! Could you put a comment in the code that briefly explains this (and maybe links back to this PR)?

appzuka

comment created time in a month

pull request commentTypeStrong/ts-loader

Apply other loaders when updating files in watch mode

Will ship with https://github.com/TypeStrong/ts-loader/releases/tag/v7.0.5 - thanks for your help! :sunflower:

iorate

comment created time in a month

more